webstaff: serials code cleanup and removing an inf digest loop

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: Teach serials perl to predict for "current" issue, not just future

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: service addition for generating holding codes, seeded or unseeded

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: Provide a way to get shallow (no nested objects) clones from IDL objects

This will have an impact on the webstaff offline interface, which has a similar
but less advanced implementation of the same.  We want THIS one going forward,
not the one from offline.  HEAD'S UP!

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstasff: start serials Issues tab

Just a grid for now.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: implement creating scap from a pattern template

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: Link MFHD action

under Manage Subscriptions

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

webstaff: Clone Subscription action

under Manage Subscriptions

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

webstaff: implement fetcher for pattern templates

The method open-ils.serial.pattern_template.retrieve.at
takes a org unit ID and returns the set of patterns visible
to it.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: add admin interface for managing serial pattern templates

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: teach egEditFmRecord how to use custom template for a field

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: implement saving pattern as a template

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: fix problem with IDL definition for spt

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: new egShareDepthSelector directive

This directive implements a selector for OU-sharing depths; depths
and names come from the actor.org_unit_type table. If there are
multiple types defined for a given depth, the display value in
the selector is the concatenation of their names.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: new table to store shared prediction pattern codes

serial.pattern_template is a new table for establishing a
shared list of predication pattern codes. Pattern templates
have an OU owner and share depth; CUD has a new ADMIN_SERIAL_PATTERN_TEMPLATE
permission.

The share depth is meant to be advisory, so there's no pcrud
permission tied to retrieving serial.pattern_template rows.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: improve initialization from pattern code

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: clicking outside pattern modal no longer closes it

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: implement action to cancel creating new pattern

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: implement prediction deletion action

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: implement adding a new prediction

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: fix creating PredictionPattern from null pattern code

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: finish implementing updating patterns

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: changing pattern now marks form dirty

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: embed serials prediction wizard into modal

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: Serials Admin menu and Serial Templates

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

webstaff: update review pane to display pattern summary

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: add PredictionPattern.compile() method

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: start work on review pane of pattern wizard

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: more work on the regularity UI

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: UI for setting pattern regularity

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: add basic frequency inputs

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: tweak add/remove level buttons on enum pane

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: implement chronology tab

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: finish first pass at enumeration pane

Includes three new directives:

egMonthSelector
egSeasonSelector
egMonthDaySelector

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: start of prediction wizard

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: start list of patterns

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: serials: improvements to updating address bar

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: add subscription selector to prediction manager

This also implement updating the browser URL when a
different subscription is chosen.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: serials: add egSubSelector directive

This directive allows the operator to select the subscription
they want to work on in contexts such as the prediction
manager.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: fix toTypedHash conversion of null dates

... and avoid flashbacks to 1969/1970

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: serials - start egPredictionManager directive

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: add subscription ID to serials routes

Teach the serials app to recognize the subscription ID if supplied
in the path. The subscription ID is validated against the bib record;
if it doesn't belong to the bib, the path is rewritten to
drop it.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: wrap serials app directives in ng-if

This is meant to reduce running initialization code unnecessarily
when a user goes directly to one of the tabs

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: rename subscription management tab

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: ensure grid in egSerialsManager is consistently initialized

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: adjust whitespace a bit

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: reorganize serials app layout

This patch lays the groundwork for breaking out each tab
in the main page into a separate directive, and establishes
the directive for the subscription manager. Note that at present
stuff under serials/directives is expected to be firmly bound
with other aspects of the over serials app, including its
services.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: Additional Routing in serials grid

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

webstaff: changes to subscription management form

- adjust layout and styling to be a bit more compact
- add cancel/reset button
- save button now active only when form is dirty

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: add subscription management pane

TODO: more precise dirty field detection
TODO: formatting of form
TODO: use something other than buttons to add distributions and streams?

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: teach egIDL a new fieldmapper object representation

This is the beginning of work to teach egIDL how to
represent FM objects in a way that more easily can be bound
to Angular input widgets, given the verbosity of getterSetter
and the fact that some widgest like uib-datepicker-popup don't
support getterSetter.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: typo fix

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: fix sorting in serials distribution/stream grid

Literal attribute names need to be in double quotes when
using orderByFilter.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: dist/streams grid now handles partial subs

If a subscription has no distributions, or if a distribution
has no streams, a partially-filled-in row is now displayed
in the grid.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: create serials distribution/stream grid

TODO: move most of this to a separate directive

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: start core serials services

Routines to fetch a subscription/dist/stream tree for a bib
and produced a flattened version of it for the distribution/stream
grid.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: tweak labels of serials management tabs

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: chop out "/manage/" from serials routes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: skeleton of the serials management page app

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1682609: upgrade to angular-ui-bootstrap 1.3.3

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff serials: add placeholder link to serials app

This is just a placeholder to get to the serials management
page from the record details page; navigation will be sorted
out later.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1312824: follow-up to fix whitespace

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1312824: Change success message for transferred holds

The holds transferred success message should clarify which holds were
transferred to mitigate potential confusion.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1312824 open-ils.circ.hold.change_title fix

Add a capture_time => undef limit to both change_title
APIs to prevent currently captured holds from being reset
when moving holds from one title to another.
More work is needed to prevent items currently in transit
from having their transits canceled.

Test plan
---------
1. Create a bib with multiple holdings
2. Add multiple holds to this title and capture one of them - Item
   will have a status of On Holds Shelf
3. Open another bib record, open Actions for this Record menu,
   Mark as Hold Transfer Destination
4. Return to the record that has a captured hold, open Actions for
   this Record, Transfer all Title Holds
5. Check Captured hold, Item status is Available, hold has been reset
   and now points to the new bib record.

With the patch applied, steps 2-5 above should be repeated, but this
time in step 5 the hold will still be on the original record and the
item's status will still be On Holds Shelf.

Signed-off-by: Jason Boyer <JBoyer1@library.in.gov>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1672775 Stamping A/T purge SQL upgrade

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1672775: add purge_at_events.srfsh to example crontab

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1672775 Action/Trigger retention interval release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1672775 Action/Trigger CRON-able purge script

Installs a new purge_at_events.sh script into the Evergreen bin
directory.  Invoked at regular intervals to remove expired events.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1672775 Action/Trigger purge PGTAP tests

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1672775 Action/Trigger retention interval SQL/IDL

Adds a new 'retention_interval' column for Action/Trigger Event
Definitions and an action_trigger.purge_events() function for deleting
events that have exceeded their configured retention time, including any
outputs linked to those events.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1691284 alpha sort circ modifiers on the copy editor

Alphabetically sort circ modifiers on webstaff, so large lists
are easier to use.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: Fix buggy AsciiDoc rendering of backticks

Apparently, AsciiDoc matches backticks (`) with single quotes (') as a
valid quote pair, and this happens before matching a pair of backticks.
So in cases where a pair of backticks is followed by only one single
quote (not within a word), the first backtick is treated as a single
quote, thus breaking the backtick pair and not applying the intended
monospace formatting.

This commit fixes two such cases by escaping the backticks. This doesn't
prevent the same problem in the future, but I haven't found any way to
change this parsing behavior.

Signed-off-by: Remington Steed <rjs7@calvin.edu>

LP#1077212: add qstore to eg_db_config.pl --update-config list

To test
-------
[1] After applying the patch, run eg_db_config --update-config --service all
    as per the upgrade instructions.
[2] Verify that the <open-ils.qstore> section of opensrf.xml contains
    the correct database credentials.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1687971: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1687971: follow-up fix to copy location editor

This fixes an issue where URLs of existing copy locations
could not be edited.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1687971 - Make copy locations in the OPAC clickable.

Adds a url field to asset.copy_location. The presence of a url in the
field will cause the copy location to display as a link in the OPAC. Urls
can be edited in the Copy Locations Editor.

Additional contributors: Martha Driscoll, Christine Morgan, Suzanne
Paterno.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1498155: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1498155 - Also remove user-assigned SET_CIRC_MISSING perm.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1498155 - Remove SET_CIRC_MISSING permission.

SET_CIRC_MISSING isn't used anywhere, remove it to avoid
confusing it with MARK_ITEM_MISSING permission.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1574141: add release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1574141: minor code tweaks

- return the BAD_PARAMS event if client provides neither patron ID
  nor contact value
- more precisely identify missing parameters
- standardize indentation

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1574141 - Allow invalidate for all patrons with the same contact.

Teach the open-ils.actor.invalidate.* methods to allow invalidating
by the contact value, so all patrons with that contact value can have
it invalidated with one call.

This adds a new parameter for the contact value (email address, phone
number).  Then all customers with that value have it invalidated from
their account.

This somewhat simplifies writing a cli script for invalidating email
addresses since the script doesn't have to look up the user first.

The ability to invalidate all with the same contact value was already
there, it just wasn't exposed.

Testing:

1. Make sure the normal staff client invalidate buttons still work.
2. Use srfsh to try the call with a contact value.
  request open-ils.actor open-ils.actor.invalidate.email "<authkey>" "" "" "" "test@email.com"

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1691801 Webstaff grid column move controls

Add options to grid "Configure Columns" interface for moving a column
left or right by one, all the way left, and all the way right.

Most recently modified column is styled so it's easier for users to track
the movement of a column.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Translation updates - po files

Signed-off-by: Ben Shum <ben@evergreener.net>

Translation updates - newpot

Signed-off-by: Ben Shum <ben@evergreener.net>

forward-port 2.12.1-2.12.2 schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

forward-port 2.11.4-2.11.5 schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

2.10.11-2.10.12 schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

release notes for 2.10.12

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

update 2.11.5 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

update 2.12.2 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1478128: Avoid XSS in public catalog

This patch escapes various GET param values by passing them through
the Template Toolkit html filter, including:

* in the locale picker
* in the searchbar
* in the login form

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: 2.12.2 Maintenance release notes

Well, this turned out to be a busy maintenance release. Lots of bug fixes
are now outlined in the 2.12.2 release notes.

This commit also adds a missing new feature - LSE setting for default
status for received acq line items - to the 2.12.0 notes.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: 2.11.5 maintenance release notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1677902: Remove search formats from advanced search limiter block

The original behavior of the advanced search limiter block was to remove
search formats from the display because it is available for limiting in the
search bar. Other code broke this behavior, and I've now restored it by
adding the ignore search format code to the searchbar.tt2 file. It also fixes
a problem where the search format limiters were incorrectly displaying on the
low hits page.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>

LP#1650410: include --days_back in synopsis and other tidying

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1650410: doc authority_control_fields.pl's --days_back flag

This patch updates the POD that in turn is displayed when
running authority_control_fields.pl -h

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1690468: fix Exclude Electronic Resources checkbox with advanced search limiters

When advanced search limiters are applied, you cannot successfully
uncheck the Exclude Electronic Resources checkbox.  When you uncheck it,
your current search is reloaded, but e-resources are still excluded
(and the box remains checked).

When you use the checkbox to exclude e-resources, the search form on the
results page contains a hidden input element:

<input type="hidden" name="fi:-search_format" value="electronic" />

This commit uses Javascript to remove that element from the search form
when the box is unchecked, before submitting the search.

Test plan:

[1] Enable the "Exclude Electronic Resources" checkbox in config.tt2.
[2] Do an advanced search, applying at least one search filter (e.g.
    Language = "English").
[3] On the search results page, check the Exclude Electronic Resources
    checkbox.  This repeats your search, excluding e-resources.
[4] Uncheck the Exclude Electronic Resources box.  Your search is
    repeated, but e-resources are still excluded and the box remains
    checked on your new results page.
[5] Apply this fix.
[6] Refresh the page or clear your browser cache, and try to uncheck the
    Exclude Electronic Resources box again.  This time, it should work:
    e-resources will no longer be excluded, and the box is unchecked
    when your new results page loads.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1678638: use new preferred extension for AsciiDoc files

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1678638: add text versions the qstore and query_schema docs

qstore.txt includes some AsciiDoc markup, while query_schema.txt
is just the results of passing query_schema.odt through unoconv
and pandoc.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>