LP#1505286: stamping upgrade script for limit facets retrieved

Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1505286: add release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1505286: add pgTAP tests

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1505286: limit number of facets retrieved

This patch teaches search how to limit the number of facets retrieved
per defined facet field. Setting a limit is useful so that
open-ils.cstore backends don't end up needlessly consuming
memory when fetching facets for a large result set; if a broad
search retrieves over 10,000 author facets (say), even the most
persistant user is not going to actually look at all of them. Fetching
fewer facets can also slightly speed up generation of search
results.

The limit is controlled by a new global flag, search.max_facets_per_field,
whose label is "Search: maximum number of facet values to retrieve for
each facet field".  The default limit value is 1,000, but lower values
(e.g., 100) are perhaps even better for most catalogs.

To test:

[1] Upon applying the patch, set the value of the
    search.max_facets_per_field global flag to a small
    value.
[2] Perform some searches and verify that the number
    of facets retrieved doesn't exceed the limit; note
    that the limit is per facet *field*, not overall
    or per field class.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1545178: remove two unused methods

This patch removes two methods that were both broken
and not in use:

  * open-ils.actor.org_unit.closed_date.create
  * open-ils.actor.org_unit.closed_date.delete

To test:

[1] This patch has no user-visible impact whatsoever, but
    to check for regressions, verify the proper functioning
    of the closed dates editor.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1466990: Detailed search results shows parts for items that dont have parts

The part_label variable needs to be reset between iterations. The variable was still set
and bled from copy to copy. Testing this will require a search with details turned on.
The search result set needs to include a bib that has copies with parts (with at least
one copy invisible) and another bib that has copies without parts.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1474051 Stamping upgrade script for drop-cc-data

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1474051 Release/Upgrade Notes on dropped CC fields

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1474051 CRON script for clearing CC numbers

Adds a new srfsh script which calls a new open-ils.storage API call
which sets the cc_number value to NULL on all credit card payments
older than the age specified in the srfsh script.

Adds example CRON entry.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1474051 PGTAP test checking dropped columns

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1474051 Drop unneeded CC payment fields

Avoid storing the following credit card fields:

expire month
expire year
first name
last name
credit card type

Print and email receipts for credit card data modified to avoid
referencing these fields.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Porting 2.8.4-2.8.5 / 2.8.5-2.8.6 DB upgrade scripts

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Forward port 2.9.1 to 2.9.2 upgrade script and server upgrade instructions.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP#1202742 non-active copy transit release notes

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1202742 Non-active transit copy status messages

When an in-transit copy is checked into the staff client, display a special
message in the transit alert dialog and in the printed transit receipt
(optionally, via macro) if the copy is in (or, rather, will be once it
arrives at its destination) a non-active copy status.

See config.copy_status.copy_active.

For example, assuming the org unit setting 'circ.lost_immediately_available'
is unset, when a Lost copy is checked in that must transit home, the
following message will appear in the transit alert dialog:

This item is in status "Lost", additional staff action may be required.

Additionally, the value of the 'transit_copy_status_msg' macro, which
defaults to "", will be set to this message, so that the message may
appear in printed transit slips.

Note that the code will test for the presence of the
"staff.circ.utils.transit.copy_status_message" string property and fail
gracefully if it is unset.  Through this, admins can disable this
feature entirely.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1486151 Stamping upgrade script for password reset regex description

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1013786 TPAC add reminder to modify update_pasword_msg.tt2 to global.password_regex

Currently, libraries can configure their own password strength regular expressions
via the Library Settings Editor.  This, however, did not provide a reminder
that the message shown to the patron when resetting their password needed to
meet those requirements.

This patch provides a hint in the description of the YAOUS global.password_regex
to remind that update_password_msg.tt2 should be updated with a user-friendly
text string explaining the password requirements if they are changed from the default.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Signed-off by: Christine Burns <christine.burns@bc.libraries.coop>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1380709 Stamping upgrade script for fund debit invoice links

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1367926 Stamping upgrade script for direct access to full unapi backend

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1380709 Renaming live-t test to avoid duplicate numbers

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1380709 Perl live test

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1380709 acq.lineitem_detail.fund_debit INDEX

Use of the new fund_debit.invoice_entry column includes a query joining
fund_debits to lineitem_details.  On sufficiently large data sets
(tested on 2M rows), the query can take > 1 second without the index.
Down to < 1ms with the index.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1380709 fund_debit.invoice_entry INDEX

Adds index on new acq.fund_debit.invoice_entry column, since fund_debit
can get quite large.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1380709 Fund debit links to invoice entry

Fund debits created by lineitem_details (copies) now track which invoice
entry last touched the fund debit.  With this, it's possible to say with
certainty which invoice a fund_debit "belongs" to, which is particularly
useful for reporting fund summary information on an invoice.

Note this has no affect fund_debit's linked to invoice_item's, since
they already link to the fund debits.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1367926 Release notes addition

Adding a bullet point to the release notes to further clarify the format that
the URL should take.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1367926: release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1367926: add some unit tests

- a pgTAP test of the new 'bre.extern' include option
  for unapi.bre()
- tests for OpenILS::WWW::SuperCat::unapi2_formats and
  OpenILS::Utils::TagURI

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1367926: various improvements and bugfixes

- use entityize() so that non-ASCII characters don't break
  XML well-formedness
- when a U2 identifier is given, the list of supported formats
  returned is now accurate
- biblio_record_entry_feed now works; for example,

/opac/extras/unapi?id=tag::U2@biblio_record_entry_feed/1608,454{holdings_xml}&format=mods32

returns a modsCollection of bibs 1608 and 454.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1367926: Expose non-MARC bre data via U2

Many use cases for the new unAPI implemetation depend on being able to run
recurring processes on new, updated, or deleted objects.  For most objects,
this is simple because they carry timestamps as fields.  However, the bre
class, as exposed by unAPI, does not provide access to many non-MARC fields.

So, here we add an 'includes' options to expose the non-MARC fields of use
to external processes.  The option is spelled "bre.extern", as in the tag
URI:

  tag::U2@bre/267{bre.extern}

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1367926: Add support for (nearly) direct access to the full unapi backend

Some parts of Evergreen (notably the TPAC), and various 3rd party services,
would benefit from full and direct access to the power of the backend (read:
faster, more complete, more API-stable) unAPI (um) API. Related, many moons
ago, I built a perl module (OpenILS::Utils::TagURI) to make parsing of tag
URIs systematic for use in OpenSearch and unAPI contexts. This branch uses
O::U::TagURI and a simple shim inside open-ils.supercat to expose the power
of that backend unAPI functionality.

By way of example, here is the tag URI to look up a copy, by barcode, and
request the call number, bib and bib attributes at the same time.  The
barcode in this example is "ACQ140":

 tag::U2@acp/ACQ140{acn,bre,mra}/-/0/barcode

The full example URL would be something like:

 http://example.com/opac/extras/unapi?id=tag::U2@acp/ACQ140{acn,bre,mra}/-/0/barcode&format=xml

Here is retrieving a bib in MODS 3.2 with holdings embedded:

 tag::U2@bre/267{holdings_xml,acn,acp,mra}

And the URL:

 http://example.com/opac/extras/unapi?tag::U2@bre/267{holdings_xml,acn,acp,mra}&format=mods32

To test:

Try the example URLs, varying record ID, classes, and includes. Some
classes and includes available are:

* bre (bibs)
* acn (volumes)
* acp (copies)
* biblio_record_entry_feed (multiple bibs)
* holdings_xml
* cbs (bib source)
* circ (circulation checkout and due dates)

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Forgot an acknowledgement in the 2.9.2 point release notes

Sorry Ben!

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Adding 2.9.2 bug fixes and acknowledgements to the 2.9 release notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Adding 2.8.6 bug fixes to the 2.8 Release Notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1544606: Copy the new directories we make for locales

Make it cp -r to copy the directories and not just the files (of which
there won't be any by default).

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP#1544606: Change i18n Makefile so that there are different dirs for opac vs webstaff

In i18n Makefile, we only have a single directory variable TT2_DATA_DIR.

Remove that variable, and add distinct variables for TT2_OPAC_DATA_DIR and
TT2_WEBSTAFF_DATA_DIR that point to more distinct defined areas.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP#1544606: Change docs to more specific locale/opac location

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP#1544606: Change apache examples for TPAC to more specific locale/opac location

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP#1544606: Change static entry to variable in config example for locale/staff

We were using a hardcoded entry for /openils/var here, but this should be a
variable that is altered based on how users configure/build Evergreen.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP#1544606: Remove trailing whitespace from sample configs for locale/staff

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP#1067823: stamp upgrade script

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1067823 Add genre facet by default and remove tag 659 from definition

Since genre will work well as a facet, add it to the facets in config.tt2 so
that it displays by default. Also removes the 659 MARC field from the genre
definition since it is currently an unassigned tag.

Release notes have been updated to reflect these changes.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1067823: add release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Andrea Neiman <aneiman@kent.lib.md.us>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1067823: follow-up: add back a space

Ensure that there's a space displayed between
each component of a heading coming from a subfield
boundary; this prevents

600 $aHarry Potter$c(Fictional character)

from getting displayed as

Harry Potter(Fictional character)

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Andrea Neiman <aneiman@kent.lib.md.us>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1067823: tweak new identifier|genre index

[1] Adjust facet XPath to work for more Pg versions.
[2] Ensure that upgrade script adds stock search
    normalizers.
[3] Make update script provide instructions for
    running a partial reingest.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Andrea Neiman <aneiman@kent.lib.md.us>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1067823: Genre links launch subject search

And genres are not subjects.  So now we will index genres in the identifier
class and teach the tpac to build links appropriately.  Genre is herein
defined as data in tags 655 or 659 (as the tpac currently thinks), restricted
to subfields [abvxyz], per LoC documentation.

To test:

[1] Apply the update and run the partial reingest as suggested
    by the upgrade script.
[2] In the public catalog, navigate to a record that has one
    or more 655 fields.  Click on one of the genre links and
    verify that it retrieves records sharing that genre heading.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Andrea Neiman <aneiman@kent.lib.md.us>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1486592 - Generate prices for concerto dataset.

The "concerto" test data needs prices on copies to test
various features. This adds a function to generate a price
when a copy is populated.

To test:

[1] Create a fresh Evergreen database and load the Concerto
    dataset; verify that that vast majority of copies now
    have a price set.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP 1499123: Stamping upgrade script for standing-penalty-ignore-proximity

Nearly forgot to stamp the upgrade script for lp1499123. While I'm at it,
correcting a small typo found in the release notes.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP 1499123: Add release notes.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP 1499123: Modify Perl code for csp.ignore_proximity field.

* Add get_org_unit_proximity function to AppUtils.

First, we add a helper function to OpenILS::Application::AppUtils that
returns the proximity value between a "from" org_unit and a "to"
org_unit.  It takes a CStoreEditor and the ids of the two org_units as
arguments.

* Use csp.ignore_proximity in O::A::Circ::Circulate::Circulator.

Modify the check_hold_fulfill_blocks method of the Circulator object
to take the csp.ignore_proximity into account.

The new code first calculates the proximity of the circ_lib and the
copy's circ_lib with the patron's home_ou.  It then modifies the main
query in the function to check if the csp object's ignore_proximity
is null or greater than either of the two calculated proximity values.

* Teach SIP::Patron about csp.ignore_proximity.

We modify SIP::Patron::flesh_user_penalties to not report penalties
within csp.ignore_proximity of the user's home_ou.

In order to have a notion of "here" for the proximity check, we modify
SIP::Patron->new to assign its authtoken argument, if any, to the
CStoreEditor.  We then use this authtoken to retrieve the authsession
user so that we may use the authsession user's ws_ou or home_ou as a
context ou for penalty lookup and filtering based on the
csp.ignore_proximity in flesh_user_penalties. If we're not given the
authtoken, we fall back to using the patron's home_ou and the
penalty's context ou for the proximity lookup.

This assumes, of course, that the authsession user's ws_ou or home_ou
have a logical relationship with the desired transaction ou.  For most
self-checks this will likely be true.  For other uses of the SIP
protocol, this is less likely to be true.

* Add Perl live tests.

Add tests for basic checkout and hold functionality as well as for
the OpenILS::SIP::Patron->flesh_user_penalties() changes.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP 1499123: Add ignore_proximity to config.standing_penalty.

This commit adds the integer column ignore_proximity to the
config.standing_penalty table.  It also adds the column to the
csp class entry in the IDL.

It also modifies the action.hold_permit_test() function from
110.hold_matrix.sql to use the ignore_proximity field from
config.standing_penalty when checking the user's penalties to see if
they block the hold.

We also modify the action.item_user_circ_test() function from
100.circ_matrix.sql to use the ignore_proximity field from the
config.standing_penalty table when checking to see if the user's
penalties block the circulation.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1429268 credit card payment address fall-thru

When a patron has no mailing address linked, attempt to read address
data from the patron's billing address.  Similarly, if all address
fields are properly set by the API caller, except the country, and the
patron has no addresses, attempt to determine the country from org unit
settings.

If insufficient address data is provided or divined, return an invalid
params Event (similar to other CC failures).

To test:

[1] Create a patron record that has no mailing address but does
    have a billing address.  Perform or simulate a credit card
    payment; it shoudl fail with an internal error.
[2] Apply the patch and repeat step 1; this time, the payment
    attempt should succeed and use the billing address.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1522604: Remove red alert style for non-cataloged checkouts

The non-cataloged checkouts in the patron summary had a red alert style
applied when there was a lost item count on the patron record. This branch
removes any alert styling since we don't need to highlight non-cataloged
checkouts.

Test plan:
Pre-patch, retrieve a patron record with lost transactions in the web client.
The non-cataloged count in the patron summary will be red. Apply the patch.
The count will no longer be red.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1240657 - Creating and Deleting Closed Dates permissions wrong.

The code referenced two permissions that didn't exist
CREATE_CLOSEING and DELETE_CLOSEING.  Should be CREATE_ORG_UNIT_CLOSING,
and DELETE_ORG_UNIT_CLOSING.

[RM note: the affected methods don't appear to be in use, however]

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

lp1422802 Release notes entry

Release notes entry for more visible parts feature.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

lp1422802: Improve visibility of parts on Place Holds screen

Users often miss the list of parts on the Place Holds screen, leading to
many title-level holds on records where only one or two libraries have
'unparted' copies. This branch adds some styling to add padding around the
parts selector and to bold the Select a Part text. Many thanks to Christine
Morgan whose custom work at NOBLE served as an inspiration for this styling.

The branch also adds a new config.tt2 option to display parts with
radio buttons instead of a select menu so that all of the parts will display on
the screen. With this option, no parts are pre-selected, forcing the users to
actively choose a part.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1526547 Re-broaden backdate note setting

The previous commit missed a case where we still want the backdate
message to appear.  Let's recentralize it, but at a different level.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1526547 Improve note setting for backdates

The backdate note was the default note for voiding and adjusting, but
this proved to be an unexpected default.

Let's set the note only where we need it, and also genericize the
wording to cover both voiding and adjusting.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1526547 Prevent bogus notes when adjusting lost/lod overdues

If you void/adjust an overdue, but don't supply a reason, the code
automatically adds "VOIDED FOR BACKDATE" to the billing note. This is
obviously wrong for overdues adjusted or voided due to lost (or long
overdue) processing.

This commit simply adds a more appropriate note.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1516867: set limit on when HTML report output sorting

To avoid taking an excessive amount of time to render an
HTML report or sort its values, dynamic sorting is enabled
only when there are at most 10,000 rows of output.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1516867 Make HTML report tables sortable

Using the sortable JavaScript library from https://github.com/hubspot/sortable
(MIT license), we can make HTML reports much more usable by making them
sortable by clicking on the column headers. This should save some downloading
of CSV or Excel versions of the reports.

To test:

[1] Create or use a report template and generate an HTML report; ensure
    that the report has at most 10,000 rows of output.
[2] View the report output and click on one of the column headings;
    verify that the table sorts itself by that column's values.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

webstaff: add angular-file-saver to test manifest

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Docs: small leveloffset fix for root.txt

Signed-off-by: Yamil Suarez <yamil@yamil.com>

Docs: web client copy buckets documentation

Signed-off-by: Yamil Suarez <yamil@yamil.com>

webstaff: fix more cases where new copies weren't being saved

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: work around race condition in vol/copy editor

Fix (or workaround) issue whereby the volume/copy editor
could fail to select a copy's current stat cats.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: clean up console noise

Ensure that if a default stat cat OU filter is not set,
that errors aren't logged when creating a new volume/copy.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: fix issue that prevent new copies from being added

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: add copy ID column to holdings table and volcopy editor

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: add circulate as MARC type column to holdings table

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: add prefix, suffix, and parts columns to holdings table

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: ensure that volcopy editor saves copy part maps

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: add circulating library as optional column in holdings view

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: copy template fix

This patches fixes applying the volume portion of a
template when in the copy template tab of the volume/copy
editor.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: fix updating stat cats in the volume/copy editor

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: expose ascecm to open-ils.pcrud

Doing this allows the volume/copy editor to use
pcrud to retrieve copies with stat_cat_entries fleshed.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: fix selection of stat cats in copy editor and templates

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: fix setting default copy status for new items

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: consolidate code for generate new copies

This patch does a bit of refactoring to get rid of
some copy-and-paste code that creates new copies
in the volume/copy editor.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: fix console noise spawned by OU selector

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: tweak setting default classification scheme in volcopy editor

With this patch, the volume/copy editor creation default for
classification scheme now can have a value of "Use Library Setting".
If this is in effect, the default classification scheme for new
volumes is taken from the library setting.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: add more volume transfer options

The volume/copy editor now has the following new actions:

  * (Transfer) Volumes to Previously Marked Record
  * (Transfer) Volumes to Previously Marked Record and Library

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: add a Transfer Copies to Previously Marked Library action

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: grab default call number from bib when creating volume

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: save copy templates now unconditional

The save copy templates button in the volume/copy editor
no longer requires that a working template be active; this
way, users can save the set of templates after an import
without having to select one of them first.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: implement import/export of copy templates

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: add egJsonExporter directive

This directive is used to allow a piece of JSON
to be saved to the user's filesystem.  For example:

<span eg-json-exporter container="foo" default-file-name="example.json">Export</span>

specifies a button that, when click, allows the user to save
the contents of the scope variable foo.  The dialog that
appears will use "example.json" as the default filename.

This also adds a new dependency, the MIT-licensed
 angular-file-saver service written by Philipp Alferov:

https://alferov.github.io/angular-file-saver/

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: style file input buttons more nicely

Using technique devised by Cory LaViska per
http://www.abeautifulsite.net/whipping-file-inputs-into-shape-with-bootstrap-3/

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: fixed client-side sorting of names in add-to-bucket dialog

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: alphabetize status and location dropdowns in copy-editor

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: display floating group correctly in item status

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: add copy editor support for floating field

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: rework Local Administration

maintain links and labels as a data structure

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: tweak how element IDs in MARC editor are generated

For new records (or records that for whatever reason lack
a 901 field), use '0' as a dummy value for the record
ID when constructing element IDs (e.g., r0f5, r0f10sf0value,
etc.).  This fixes a problem where setCaret() couldn't
successfully change focus after adding a field or subfield
to a new record.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: users with negative balance

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: Wire up statcat filtering in item attribute editor

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: open title from item status in a new tab

Also, iindicate that will happen with an icon by the title link

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: Move new Vol Transfer UI menu option to "misc" section to avoid confusion

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: Use the record id to fetch the summary record data in item status

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: for selected grids, allow display of 10000 items

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: enable copy edit link from opac view

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>