lp1811710: automated tests

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

lp1811710: hopeless holds release notes

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

lp1811710: minor fixes to other code

outside of the holds grid and the Hopeless Holds interface

* Retargetd vs Retargeted typo

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

lp1811710: hide Pre-Fetch for now

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

lp1811710: minor tweaks to the eg2 holds grid

column label fixes and let some actions work with multiple rows

fix for item barcode link

prevent certain actions from spawning broken interfaces

disable Title Hold Transfer if non-title holds are selected

render hold status

return the sms carrier name instead of the id in the wide_holds API
(we may want to back this one out and do it differently)

show time component for timestamp columns

fixed live summaries for various hold actions intended for large batches

remove mvr.* from eg2 holds grid; not doing anything

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

lp1811710: toward hopeless data

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

lp1811710: toward hopeless UI

dedicated interface and grid tweaks

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

lp1811710: toward hopeless holds, backend and existing UI's

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1857350 Org selector sorts by display value

When displaying the org unit selector, sort each set of children by the
display label (defaults to shortname).

Fixes issues with the org server sortTree function and adds a unit test
to test the repaired sort function.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

PINES Fix to custom holdings list

Corrects system name not showing up on record detail screen in
holdings copy table. Also adds system name to the linked up library
info page.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1843599: AngularJS MARC editor once again sets bib source

This patch fixes a regression introduced by the patch for bug 1693580
that prevent changes to the bib source from being made via the AngularJS
MARC editor.

To test
-------
[1] Apply the patch.
[2] Create a new bib record and save it with a non-empty source. Verify
    that the record sets the source as expected.
[3] Edit a bib record and change the source. Verify that the new source
    is retained when the record is saved.
[4] Edit an authority record and save it. Verify that it can be updated
    without error. (Note that authority records do not have sources in
    the same way that bib records do.)

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

PINES Hide Print and Email Options on Lists

The print & email options on lists in the OPAC are currently
broken (launchpad bug 1854986) - hide them until fixed.

Also includes a couple minor adjustments to spacing.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

lp1712644 Prevent check out due date in past

- Prevents selecting past due date when checking out an item
- Prevents saving a due date with hatch when input date is invalid

Signed-off-by: Katlyn Beck <kbeck@catalyte.io>
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/circ/patron/t_checkout.tt2
modified:   Open-ILS/web/js/ui/default/staff/circ/patron/checkout.js
modified:   Open-ILS/web/js/ui/default/staff/services/ui.js

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES - indent popularity line on search results page

We recently enabled popularity ranking visibility in the OPAC,
but it isn't indented with the rest of the item info. This adds
the indent and un-does the bolding since it is distracting.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES Self-check Customization

New PINES logo and matching color scheme

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Customization of self-check interface so that username, password,
and barcode text banners appear in different colors in an effort
to make it clearer to patrons that they are being asked for a
different type of information.

Note that that this also tweaks the password check because the old
format was different from current master and no longer working correctly.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES KPAC: New logo

Updates to incorporate new PINES logo.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES logo and color scheme changes

For January 2020 upgrade

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES Staff Client Logo Update

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Add new PINES logo.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1846484 - Add BETWEEN SYMMETRIC to reporter SQL builder

Let's give end users a break and forgive them when they mix
up the order of a date range.  BETWEEN SYMMETRIC allows users
to enter a date range in any order rather than strictly
enforcing "oldest date first" and returning an empty result
set.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1849334 - Protect precat volumes from accidental staff edits

It is possible to edit the precat volume (id = -1) in a batch
volume/copy edit in the webclient.  We assume that valid changeable
volumes have an id > 0, then allow changes.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

adding post-3.4 upgrade script

removing legacy upgrade script

LP#1822630: fix sanitizing CGI params on place_hold_result

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Stephenson <jason@sigio.com>
(cherry picked from commit 019118895c94f5cc810b3f1fb95b2634a1c993b6)

Revert "Temp fix for Broken Hold Links"

This reverts commit d8722f1c7a5b76f965e59ffbf20342a4c48bbeb0.

LP#1851524: fix adding a bucket when saving a new carousel

This patch fixes a regression where saving a new carousel
would not result in its bucket being created due to the
post-save callback never getting invoked.

This patch does not fix any carousels that do not have
buckets due to this bug. Because such carousels will
not function anyway, they should be deleted and
recreated by the local admin.

To test
-------
[1] Create a new carousel in local adminstration. Open it
    in the edit modal again and note that no record bucket
    is linked to it.
[2] Apply the patch and repeat step 1. This time, the
    bucket should be created.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

disable trigger USER, not ALL

update 3.3-3.4 upgrade script with PINES customizations and speed improvements

LP#1570072: add release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1570072: update hold notification methods upon preference changes

This patch adds a feature where if a patron's hold notification
preferences are changed, they are given an opportunity to have
notfication methods for their pending hold requests updated to
reflect their new prefernces.

This feature affects both the public catalog My Account interface
and the staff patron registration form. In both cases, the user
is presented with a modal (staff-side) or interstitial page (public
catalog) asking them whether to update current hold requests.

Sponsored-by: MassLNC
Additional-work-by: Mike Rylander <mrylander@gmail.com>
Additional-work-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

update DB upgrade scripts to accommodate what we have already applied

Remove "In Receiving" status from magical status list

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Adding 'In Receiving' status to back-end functionality.

KPAC Updates: Add E-Read Kids

Add new permanent KPAC icon for E-Read Kids, hide summer reading,
show back to school.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES Customization: Alter wording for COPY_CIRC_NOT_ALLOWED

Change wording of COPY_CIRC_NOT_ALLOWED message because the default
wording indicates that it is a problem with the copy, but it can
also be triggered when there is a problem with the user (such as when
a Digital Only user attempts to check out a physical item).

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1713138 EDI buyer codes from RFF+API

Support extracting buyer code (AKE edi_account.vendcode) values directly
from the EDI RFF+API field.  This provides better matching to
edi_accounts based on vendcode values for inbound EDI messages.

The code will still fall back to extracting vendcodes appended to the SAN,
when no RFF+API is present.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Modifies our previously customized code for the new books dropdown
list so that it limits what is retrieved in the new books supercat
feeds by available statuses only.

LP #1705497 Replaces functionality in web client from legacy
XUL client by including a find function for originating
acquisition where it exists.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1642036 Group member detail grid query repair

Teach the grid to automatically use the current version of the grid
query in group member details lookup, since the query changes as
patron's change and is sometimes applied after the grid has already
absorbed the setQuery function.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1029601: Prevent double-clicking when submitting hold requests.

Double clicking on hold submit buttons causes multiple holds to be generated.  This adds some code to
disable the Submit button(s) after the first click, so subsequent clicks don't "work" in unintended ways.

Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>

KPAC Update: Remove Tumblebooks Link

GALILEO canceled Tumblebooks, so removing link.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES KPAC: Summer Reading 2019 Topics

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1630271: Add a field, change a label.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1630271 - Correct encumbrance subquery.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1630271 - Add Purchase Order Summary View

The purchase order reporting source contains several fields that are
available in the reporter but are non-functional (because they are
generated on-the-fly within user interfaces).  This view allows a
similar calculation and provides access back to the PO object as well.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP 1744386 & LP 1777184 - stat cats & stat cat entries not alphabetical

Statistical categories will be alphabetized first by library and then byt category.

The entires within each category will also be alphabetizes

fix broken holds link in My Account page

PINES Customization: Link to spine label documentation

To be added on top of Adam's spine label work.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1777677 Test Notification Method

Correcting two code typos (USER_VIEW should be VIEW_USER in Actor.pm
and language string typo in test_notification.tt2).

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

lp1777677 Security tweaks

- Refactor test notification API to check if requestor
is user,and if not, then check if requestor has
permissions to view users at target user's home ou.
- Change event_def_type references to "hook"
- Separate out sendTestEmail and sendTestSMS functions
in frontend to prevent potential misuse of functionality.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm
modified:   Open-ILS/src/templates/opac/myopac/prefs.tt2
modified:   Open-ILS/src/templates/opac/myopac/prefs_notify.tt2
modified:   Open-ILS/src/templates/staff/circ/patron/t_edit.tt2
modified:   Open-ILS/web/js/ui/default/opac/test_notification.js
modified:   Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

lp1777677 Test Notification Release Notes

- Add release notes for Test Notification functionality.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
new file:   docs/RELEASE_NOTES_NEXT/Circulation/test_notification_method.adoc

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

lp1777677 Test Notification Permission & String change

- Update permission requirement to OPAC_LOGIN
- Update strings to be more end-user friendly

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm
modified:   Open-ILS/src/sql/Pg/950.data.seed-values.sql
modified:   Open-ILS/src/sql/Pg/upgrade/XXXX.data.lp1777677-action-triggers-test-notification.sql
modified:   Open-ILS/src/templates/opac/myopac/prefs.tt2
modified:   Open-ILS/src/templates/opac/myopac/prefs_notify.tt2
modified:   Open-ILS/src/templates/opac/myopac/test_notification.tt2

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

lp1777677 Show test notification buttons by retrieved data

- Prevents test notification buttons from displaying when email or sms
data is input but no data exists on server.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/circ/patron/t_edit.tt2
modified:   Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

lp1777677 Test Notification OPAC success prompt

- Move OPAC success prompt higher up to ensure message is
seen.
- Ensure OPAC SMS test notification doesn't send email.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/opac/myopac/prefs.tt2
modified:   Open-ILS/src/templates/opac/myopac/prefs_notify.tt2

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

lp1777677 Test Notification Method

- Create fire_test_notification subroutine to create, fire, and
return event
- Add Test Notification UI buttons to preferences and patron edit screen.
- Add Toast to inform of success or failure of sending test notification
- Add Strings to patron interface to handle ngToast notifications
- Add Test Notification to OPAC preferences UI for email
and default sms number.
- Abort Test Notification event if no user is found.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm
modified:   Open-ILS/src/sql/Pg/400.schema.action_trigger.sql
modified:   Open-ILS/src/sql/Pg/950.data.seed-values.sql
new file:   Open-ILS/src/sql/Pg/upgrade/XXXX.data.lp1777677-action-triggers-test-notification.sql
modified:   Open-ILS/src/templates/opac/myopac/prefs.tt2
modified:   Open-ILS/src/templates/opac/myopac/prefs_notify.tt2
new file:   Open-ILS/src/templates/opac/myopac/test_notification.tt2
modified:   Open-ILS/src/templates/opac/parts/header.tt2
modified:   Open-ILS/src/templates/opac/parts/js.tt2
modified:   Open-ILS/src/templates/staff/circ/patron/index.tt2
modified:   Open-ILS/src/templates/staff/circ/patron/t_edit.tt2
new file:   Open-ILS/web/js/ui/default/opac/test_notification.js
modified:   Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

PINES Cust: Don't auto-open added content in staff client

Novelist and Syndetics content will still automatically open in
the OPAC but not in the staff client, which should improve client
performance.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

uncomment div to allow NoveList Select to work correctly

PINES Custom Default Spine & Pocket Label Template Code

This strips out old and unnecessary comments and code that is
no longer used after Adam's work is applied.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES Custom UI Change: Date Field on Circ Screen

Forced size of custom date selector on checkout screen since
it is too small. This will probably be fixed differently in
master later, but this will help us for now.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES Customization: Link to spine label documentation

To be added on top of Adam's spine label work.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1797973 - misc UI fixes where eg-org-selector expands too much

The new template for the type-ahead OU selector needs to width bound
by a parent container, this adds one where needed.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

LP1796945: More Accurate Joins in AngularJS IDL

Currently all joins of all classes are hard-coded to
inner, which is clearly sub-optimal. This branch
tries to correct this by looking at the reltype param
on links.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>

LP#1642036 - Prevent race condition in Group Member Grid

A timing condition was causing the setQuery() fnc to not
exist when called resulting in a blank group members grid.
A simple $timeout seems to address it.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

adding xact rollback & begin

Removes red notice about emailed queue complete notice on LMOR.

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>

Returns Activate PO ticky to LMOR

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>

typo correction

add copy alert perms to LocalAdmin and LibraryManager

Adds documentation links to acqadmin menus

Adds links to appropriate PINES wiki pages for remaining Dojo Acquisition administration menus. Additionally also marks required fields on Load MARC Order Records page.

Removes checkin date column

Removes Circ ID and fixes publisher

Removes edition, due date, floating and holds count

Removed auto-populate of column options in Item Bucket, individually outlined column options in alphabetical order.

LP#1737800 - add delete action to pending patrons

This adds a way to remove a pending/staged user from
the pending users grid.

Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

removing spine label printing feature

LP#1726568: expose circ lib and owning lib fields to spine/pocket labels

This patch fleshes the item circulation library and owning library
fields so that spine/pocket labels can include the short name or
full name of the OU rather than just the ID.  As a consequence, the
following fields are now available for label templates:

* copy['call_number.owning_lib.id']
* copy['call_number.owning_lib.shortname']
* copy['call_number.owning_lib.name']
* copy['circ_lib.id']
* copy['circ_lib.shortname']
* copy['circ_lib.name']

If, for some reason, existing label templates intentionally use
copy['call_number.owning_lib'] or copy['circ_lib'] to include the numeric
ID of the OU on the label, they will need to be replaced with
copy['call_number.owning_lib.id'] or copy['circ_lib.id'] respectively.

To test
-------
[1] Apply the patch.
[2] Open the print labels window for an item and try including one
    or more of the new fields listed above; verify that the current
    value is displayed on the label preview.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

switch around order, update already existing setting

adding several other post-upgrade tasks to script

LocalAdmin already has COPY_DELETE_WARNING.override

Cat1 already has COPY_DELETE_WARNING.override

Staff already have CREATE_DUPLICATE_HOLDS perm

more typo corrections

LocalAdmin already has EMERGENCY_CLOSING

typo corrections

adding perms and settings for post-upgrade

adding refressh of reporter.materialized_simple_record

tweak parent/guardian data update

PINES Fix to Search Results Title

Fixes problem where Search Results page title was overlapping
filter boxes.

Signed-off-by: McCanna <tmccanna@georgialibraries.org>

adding file to combine rbdigital installation

adding parent/guardian data

Removes "Activate PO" ticky box on the Load MARC Order Records page.

LP#1714070 Patron parent/guardian field

Adds a new dedicated patron parent/guardian field.  This field is
editable in the patron edit interface, displays in the patron summary
side bar on the browser client, and is search-able from the patron
search interface in the browser client.

Adds patron editor "show" and "suggest" library settings.

Also adds a new library setting
'ui.patron.edit.guardian_required_for_juv' ("GUI: Juvenile account
requires parent/guardian").  When this setting is applied, a value
will be required in the patron editor when the juvenile flag is active.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

PINES Cust: Make offline interface alerts bolder

This overwrites the bootstrap CSS just for the offline
circulation page alerts boxes.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES Custom: Redisplay print and email links on item record page

These were hidden in a previous patch because the functionality
wasn't there, but now that the functionality is working, adding
them back in.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1737800 - add delete action to pending patrons

This adds a way to remove a pending/staged user from
the pending users grid.

PINES Customization: Patron Summary Link to Library

Turn patron home library name on the patron summary bar into
a link to the library's contact info page.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1810296: Fix selfcheck patron password setting check

Previously, the selfcheck ignored this setting if it was
set to "False", since the setting value is stored as text
and the truth test always succeeded.  Instead, explicitly
check that the setting is "True".

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

PINES Custom Hold Shelf Slip

Updated to include new preferred name at top of slip (when
present).

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

adding perms for new copy alert features