LP#1923225: have search highlighting stored procedure do HTML-escaping

This patch builds on the previous work to have the stored procedures
that produced highlighted and unhighlighted versions of display
attributes HTML-escape the source values, then adjusts the TPAC
and Bootstrap templates to avoid double-escaping.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1923225: avoid over-escaping ISBNs and ISSNs

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1928684 Catalog view holds tab sort by patron barcode error

This changes the Patron Barcode column name to ucard_barcode to
match the field name in the database.

Note: due to the name change, users who saved the column on the
grid will have to add it again.

To test:
1. Go to the View Holds tab on a record that has hold requests
2. Add the Patron Barcode column to the grid
3. Sort by the barcode column and note that it works
4. It's a good idea to test that the grid settings save properly

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

DOCS LP 1857917 Update glossary.adoc to include IDL

LP bug https://bugs.launchpad.net/evergreen/+bug/1857917
Add IDL definition to glossary, with synonym link to Fieldmapper IDL & change anchor point for F heading

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1912097 Add timestamps

Adds timestamps to the date columns in Acquisitions Search.

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1918362 Unchanged workstation settings applied on every checkin

* Stop attempting to save the Update Inventory setting on every
checkin - incorrect prefix & redundant (it's a modifier now)
* Stop saving the Strict Barcode setting on every checkin,
renewal, and checkout
* Save Strict Barcode on user interaction with its checkbox

To test:
1. confirm Strict Barcode and Do Inventory Update settings still
apply and are "sticky" on the Circulation->Checkin interface
2. confirm Strict Barcode still applies and is "sticky" on the
Circulation->Renew Items and Circulation->Checkout interfaces

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1911238 Angular grid shift-click support

Clicking on a row, then shift+clicking on another row now selects both
the second row and all rows between the first and second in Angular
grids.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1924185: use preferred name before legal name in My Account

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1924185: use preferred name in patron summary

When available, the preferred name is used as the main name in the
patron summary (rather than as a less-prominent field beneath the main
name).  The legal name is displayed further down in the summary, just
after the ID fields.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1881607 stamp upgrade script

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1881607 E-resource relationship labels

Display the relationship designation for 856 URL's in the staff catalog.

See Second Indicator:

https://www.loc.gov/marc/bibliographic/bd856.html

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1881607 Angular catalog located URIs

Display in-range located URIs in the staff catalog record summary pane.

Also applies a fix to the staff catalog to clear cached record detail
summaries on new searches to ensure the correct org-scoped version of
the record summary is retrieved on each new navigation to the detail
page.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1881607 Angular catalog e-resource links display

Display electronic resource links (MARC 856's) in the Angular staff
catalog.  The extraction logic, which matches the TPAC, has been put
into its own API.

To test in concerto, navigate to:

/eg2/staff/catalog/record/208

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1906825 Flesh acqcr on PO search

Fleshes the cancel reason column on PO searches.

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Chrisy Schroth <chrisy.schroth@kentonlibrary.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1873539 Active column in SMS carrier configuration

This fixes the lack of values displaying in the Active column of the
SMS Carrier configuration screen.  (Administration->Server Administration->SMS Carriers)

To test apply the patch.
Go to the Carrier Configuration screen and note that the 'Yes' and 'No'
boolean values now display for the Active column.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

lp1615800 Accessibility on Patron Pages

Modify patron search, patron search results, and patron edit pages so
that they are compatible with screen readers. aria-labelledby can be
used to associate input fields with their labels.

(Rebased to master)

Signed-off-by: Mike Risher <mrisher@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/circ/patron/t_edit.tt2
modified:   Open-ILS/src/templates/staff/share/t_patron_search_form.tt2

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1891699 Ang grid column picker sorting

Angular grid column picker displays colums in the following order:

1. Visible colums first, sorted alphabetically.
2. Non-visible columns second, sorted alphabetically.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1895660: Booking.pm, Search/Biblio.pm

Argument "whatev_strings" isn't numeric in numeric eq (==) at ...

A couple places that use == to compare strings. Numbers are == to
each other, but strings are eq to each other.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1895660: Proxy.pm Proxy/Authen.pm

Checking perms LOUD_NOISES for user 123 at location 321

So? I have changed these to use $logger->debug though they can
maybe just be removed entirely?

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1895660: Search/Authority.pm

Argument "" isn't numeric in numeric ne (!=)

One of the "fun" things about perl and its type system is that
it uses different operators to compare strings vs comparing numbers...

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1895660: AppUtil.pm

substr outside of string

unique_unnested_numbers expects a list of pg arrays, but if its given
an empty results list it tries to remove { and } from an undefined value.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1895660: HoldTarger.pm

"order_by" object in a query is not a JSON_HASH or JSON_ARRAY;no ORDER BY generated

json_query and CStoreEditor search_* functions don't want a string field name,
they work with hashes or arrays thereof.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1895660: EGCatLoader/Search.pm

CGI::param called in list context from ...
this can lead to vulnerabilities

For any call to $cgi->param that happens in a list context we need
to verify 2 things: 1, that it is intentional (otherwise use scalar())
and 2, that we don't use the results in an unsafe manner.
For those situations where it's safe and a list is expected (join,
foreach, etc.) there is a $cgi->multi_param() that behaves the same way
but does not issue a warning on use in a list context.

An assumption was made that there will only be a single 'query'
parameter (see _prepare_biblio_search_basics) but if that should
instead be run through a join() that function will need to be updated.

For more details about the potential issues read
https://metacpan.org/pod/distribution/CGI/lib/CGI.pod#Fetching-the-value-or-values-of-a-single-named-parameter

Note that this change will likely require additional testing to
be sure there are no surprises.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1895660: Course.pm

"my" variable $results masks earlier declaration in same scope

my $var should only be used once within a block.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1895660: Biblio.pm

Odd number of elements in anonymous hash

The type key is missing from some param descriptions,
leaving things uneven.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1895660: SuperCat.pm

"my" variable $U masks earlier declaration in same scope

AppUtils is 'use'-ed and assigned to $U at the top of the file
and shared among the rest of the modules already.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1895660: Silence Perl Warnings

There are many perl warnings in make check and the day-to-day
logs when using Evergreen. This branch aims to address the
warnings and to make reviewing easier each file will be
individually committed with a small rationale for the changes
though it is assumed that this branch will be largely squashed
away if / when committed.

Booking.pm: Possible precedence issue with control flow operator
The precedence of 'or' is significantly lower than '||', so much so
that it can be less than the precedence for assignments.
Replace 'or' with '||' since they're equivalent in this case anyway,
and also add parens for flavor.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1917944k: (follow-up) fix ng lint issue

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1917944-Hold Pickup Library sometimes Empty

Checks to make sure that the opac.default_pickup_location in usr_setting
has a value.

To test.
1. The patron must have a opac.default_pickup_location set to ""
2. Place a hold for this patron.
3. Notice that the pickup location is blank.
4. Apply the patch.
5. The hold pickup location should now be filled with the patron's home library.

To re-create this in concerto you may have to tweak the usr_setting table.
1. Assign a default pickup location to a patron.
2. Find the id field for the above in the usr_setting table.
   select * from actor.usr_setting;
3. Update the setting.
   update actor.usr_setting set value = '""' where id = <the id number>;

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1925725 Relabel copy location filter to shelving location

Changes the labeling of the all copy locations filter to say "All Shelving Locations" instead, reflecting current practice.

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1926310 Record bucket batch edit destination

Record Bucket => Batch Edit now opens the new Angular MARC Batch Edit
interface.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1927527: (follow-up) add comment

Just in case there's a question in the future, make it clear
that the case where the context OU is the root OU is special.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1927527 Catalog: Root OU shelving locations do not display

When the top level org unit is selected in the staff catalog you
only have the option to search all shelving locations.

This allows you to filter on the root org unit's shelving
locations, which is the same behavior as the OPAC.

To test:
1. Make sure the top level org unit has shelving locations
   (Local Administration->Shelving Locations Editor)
2. In the staff catalog, select the top level org unit
3. Click the three dot icon next to the query text input
4. The root org unit's shelving location options display

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Docs: fixing a typo

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Introduce documentation on how to contribute docs

This commit adds several screenshots and the basic outline on contributing
to the Evergreen documentation

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1892435 - Add Release Note

Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>

LP#1892435 Splash page catalog searches don't work with spaces

On older versions of Apache's mod_rewrite, splash page catalog
searches are escaped in JavaScript and escaped again during the
redirect to the Angular locale path, so searches with special
characters result in a search that's still encoded.

Test on Ubuntu 16.04.7, Apache 2.4.18, EG 3.6+. A splash page
catalog search for Harry Potter results in a search for
Harry%20Potter.

Add the NE (noescape) flag to the Angular locale path redirect
in /etc/apache2/eg_vhost.conf as indicated in this example file.
A splash page search for Harry Potter then works as expected.

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>

LP#1905091: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1905091 Supply environment for added print/email triggers

Ensures that OPAC print and email triggers added by upgrade script 1231
(lp 1749475) have appropriate environment.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1879769 Cannot Edit Carousels from Action Menu

The Edit Carousels action was appearing in the action menu and
right-click menu, but wasn't wired up. This adds in the missing
piece.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1917495 Angular Catalog: Hold status in View Holds is not saved

To test:
1. Go to a record in the Angular catalog
2. Click the View Holds tab
3. If status col is visible, remove status col, and save grid
4. Add status col and save grid.
5. Refresh page and note status field didn't stay visible
6. Apply patch, repeat steps 1-5, note Status stays visible

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1920815 Item edit link displayed for all users

The Angular catalog item table doesn't check UPDATE_COPY perm
before displaying an edit link. The back-end checks, so this is
a display issue only. This commit grabs a list of org Ids where
the user has UPDATE_COPY perm and checks the copy circ lib or
cn owning lib is in the list before displaying the edit link.

To test:
1. Search for a record with items you don't have perm to edit
2. Note the edit link shows on every item
3. Apply patch
4. Repeat steps 1-2
5. Note edit link displays if you have perm to edit

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: added script info to Carousels docs

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

Docs: 3.5.4 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Evergreen 3.5.3 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: 3.6.3 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Evergreen 3.6.2 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1902965: Fix search in Bootstrap OPAC

Filters and localization functions don't mix. Assign the html filtered
title to a temp var first.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1902965: change format type in XML transform to avoid XSS in SuperCat

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1902965: HTML filter on Bootstrap OPAC search results and record display

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1902965: HTML filter on OPAC search results and record display

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1896840: (follow-up) update script to include the DB rev

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1873322: Angular Admin Pages default to workstation OU

To test:

1) Apply this patch.
2) Log in using a workstation at a particular org unit.
3) Open some of the following admin pages:

Local Admin > Address Alerts
Local Admin > Carousels
Local Admin > Group Penalty Thresholds
Local Admin > Course Reserves List > Terms Tab
Server Admin > Billing Types
Server Admin > Call Number/Volume Suffixes
Server Admin > Copy Tags
Server Admin > Hard Due Date Configuration
Acquisitions Admin > Cancel Reason Configuration
Acquisitions Admin > Claim Policies
Booking Admin > Resource Types
Booking Admin > Resource Attribute Values

4) Verify that these pages automatically open to your
workstation's org unit.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1915323 Angular Staff Client Hamburger Menu Clipped Off Screen

Aligns navbar corner dropdown menu to the right to prevent it
from clipping off-screen.

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1917804: only show MARC 500 data in the General Note field

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Stephenson <jason@sigio.com>

Stamping upgrade script

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1896840 Publisher display includes 264 tag

The stock Publisher display field now extracts data from 260 OR 264
tags, whichever has a value first.

Release notes included with upgrade instructions.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1859513: In-house use link to item summary

Adds a link from the item's barcode in the in-house checkin screen to the item summary screen.

To test:
Type an item barcode into the In-House Use screen. Click on the barcode that displays in the item list.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1907979: Fix Search by Instructor setting lookup in OPAC

Previously, the Search Courses screen in the OPAC relied on a locg
param in the URL to determine whether or not to display the "Search
by Instructor option", defaulting to location id 1 if no such param
exists.  However, we can also consult physical_loc and other settings
to get a more accurate idea of which library's setting we need here.

To test:
1) In the Library settings editor, set Course Materials Module Opt In
to true for BR1.
2) In the Library settings editor, set Search by Instructor to true
for BR1.
3) In eg.conf, add the line:
    SetEnv physical_loc 4
4) Restart httpd
5) Go to your OPAC.  Note that the OPAC is at the BR1 level, and that
course search and browse options are available.
6) Click Search courses.
7) Note that only two values are available in the qtype dropdown: Course
Name and Course Number.
8) Apply this patch.
9) Repeat steps 5-6.
10) Note that the screen now appropriately consults the value for the
"Search by Instructor" setting at the BR1 level, with an "Instructor"
value now available in the qtype dropdown.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1908616 Add email display to hold edit

Note: This is built atop the patch for LP1902265

This display's the current email address (or note if there
is no address) on the Edit Hold page of My Account in the
Bootstrap OPAC.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Revert the effects of both LP1687545 and LP1914116

Revert "LP1687545: Force TT CGI plugin to use ampersands in query strings"
and "LP1914116: Apply html filter to mkurl() output"
until a fix for LP1918470 is available.

Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>

LP1908444 Support browse search record result sorting

Allow users to sort the set of bib records which link to a browse
heading via the existing sort options.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1907977: Display course name and number in course material editor

To test:

1) Go to Administration > Local > Course List
2) Make sure you have a variety of courses added.
3) Double click on a course that already has materials
attached to it.
4) Go to the materials tab.
5) Select a material and choose Edit
6) Note that the Course combobox shows both the course
number (HST243) and course name (History of Indonesia).
7) Note that you can blank out that field and type to
complete to get other courses in the same format.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1899405 - Add Part column to item table in Angular Catalog

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1913219: (follow-up) clean up ng lint warning

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1908763: (follow-up) clean up ng lint warnings

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

lp 1848579 filtering interval columns

This is a shot term change intended to prevent the "I don't know how
to filter" default message from showing up when the datatype 'interval'
is filtered.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1895679: Simplify and genericize the refund policy

Don't refrence the "email above" since that's not always
the case and simplify the languge slightly, though most
users will still likely want to customize it.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1895679: Add Stripe v3 support to Bootstrap OPAC

Update the Bootstrap OPAC to use Stripe v3, added to the TPAC
in LP 1774892.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Lp 1703658: Stamp DB Upgrade

Signed-off-by: Jason Stephenson <jason@sigio.com>

Lp 1703658: Repair DB Upgrade

Remove an errant semicolon in the db upgrade script.

Add release notes.

Signed-off-by: Jason Stephenson <jason@sigio.com>

LP1703658: Convert GIST Indexes to GIN

Rather than suggest that sites experiencing search speed issues
do this conversion on demand just knock it out from the start.

Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP1912380 Bottom Pagination for Catalog Search

Adds pagination to the bottom of a catalog search in the staff catalog.

To Test:
Search for a general topic in the staff catalog.  Pagination is at the top
of the search results but not the bottom.

Apply the patch.  Pagination now appears at the top and bottom of the search results.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1843969 Composite Attribute Entry Defs

Create a port of the Coded Value Maps UI from Angular JS to
Angular. Allow creation and edits of the Composite Attribute
Entry Definitions.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Jason Boyer <boyer.jason@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1916904 Bootstrap OPAC: Call number on Search Results Page

This adds the call number to the search results page when
"Show More Details" is not selected. (This brings back the same
behavior as the pre-bootstrap OPAC.)

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1913458 Bucket Add/Delete Item Operations Batched

In the record bucket administration UI, the act of adding or removing
items from a bucket are now done in batch to avoid too many parallel
requests.

These changes include new batch create/delete API calls that can operate
on any bucket type, so other UI's can be similarly batched as needed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1871510 Update Interface Titles

Update titles on several local admin interfaces so that they match the page listing all Local Admin interfaces.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Forward port 3.6.1 to 3.6.2 db upgrade script

Signed-off-by: Jason Stephenson <jason@sigio.com>

LP1908743 Hold pickup lib does not require have-users; repairs

To match the TPAC, only disable org units where can_have_vols is false
in the hold pickup library selector (plus those explicitly disabled via
setting).

Also fixes a thinko in the settings retrieval code.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1908743 Staff catalog honors org-not-pickup-lib

In the Angular staff catalog, disable org units in the pickup library
selector that have the 'opac.holds.org_unit_not_pickup_lib' org unit
setting applied, plus those that have false values for can-have-users or
can-have-vols.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1908743 Org select now supports disabled org unit

Org units specified as disabled in <eg-org-select /> are now visible,
but disabled when the typeahead displays.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1858114: Fix thinko in template-parameter collection

Minor thinko in the use of Array.prototype.concat() when gathering the
"where" and "having" template parameters -- concat() does not alter the
array it is called on, so we need to assign the result back to the
array.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>

LP#1858114: Record template filter values for aggregate columns

Currently the "having" clause does not record template-level filter
values in the template, but forces use of a report-level parameter.
This commit allows "having" to receive a value in the same way that
"where" does.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>

LP#1858114: Present proper input widget for aggregate parameters

There's currently logic to override the filter widget for all columns
that have a selector defined, such as the ID column of many tables. When
we transform the column with an aggregate transform, though, we don't want
to pick a particular selector-labeled value.

While I can imagine using a min or max aggregate to get a representative
value for a group, when other dependent filters would make the value
stable or where the value in particular doesn't matter but isn't needed
in a count (say), all the other aggregate transforms that are currently
supported are specifically numeric (sum, average, count, and
count_distinct). Because of that, and the most likely use case of
matching a count to "0" or "1", we should only present the "remote
object widget" for non-aggregates, and just use the baseline text string
input here.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>

LP#1866406 Followup: Add Release Note

Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>

LP#1866406: Use carousel item order

Previous to this commit, the item display order for carousels was
undefined.  Now, ordering is stable and predictable.

For Newly Cataloged Item and Newest Items by Shelving Location
carousels, the order is from most recently cataloged to least
recently cataloged.

For Recently Returned Item carousels, the order is from most recently
returned to least recently returned.

For Top Circulated Items carousels, the order is from most circulated
to least circulated.

For Manual carousels (as of now, without the ability to adjust the
Position of items) it is the order they are added to the backing bucket.
Thus emptying and refilling the bucket allows reordering.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>

LP#1772955: Stamp Upgrade Script

Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>

LP#1772955: Only include xacts with balance in summary

This commit adds a new view and IDL definition that shows the total
owed/paid/balance for transactions that have a balance other than 0.
This new view is used in the patron summary bar, and access is provided
wherever the all-open-transactions version is available in case we want
to move to the new one elsewhere.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>

LP1670457 Action Menu Grid Selection Change

I reworked the grid to disable certain actions, if
an item was needed. However, if there were actions, were
there was no item needed, they would still be available.

Signed-off-by: Zavier Banks <zbanks@catalyte.io>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>

LP1468132 MARC search honors search scope

Adds a 'Results from All Libraries' checkbox to the MARC search form in
the Angular staff catalog.  When unchecked, the MARC search will limit
to results with holdings in the search scope.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>

LP1468132 Staff MARC Search API supports copy filtering

Teaches the MARC search code to filter results on records with items
attached (though not necessarily opac-visible) for scoped staff
searches.  Prior to this patch, the scope of staff searches was
effectively ignored.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>

LP1914116: Apply html filter to mkurl() output

Because of the way that mkurl() generates its query parameters they're
generally escaped correctly, but nowhere do we run the output of mkurl()
through the html filter to correctly handle ampersands. Rather than adding
"|html" to every invocation of mkurl, it's just added to the macro directly.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>

LP1474029 Stamping DB upgrade: expired staff no-login

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1474029: teach Evergreen how to prevent expired staff from logging in

This patch adds the ability to prevent staff users whose
accounts have expired from logging in. This is controlled
by the new global flag "auth.block_expired_staff_login", which
is not enabled by default. If that flag is turned on, accounts
that have the `STAFF_LOGIN` permission and whose expiration date
is in the past are prevented from logging into any Evergreen
interface, including the staff client, the public catalog, and SIP2.

It should be noted that ordinary patrons are allowed to log into
the public catalog if their circulation privileges have expired. This
feature prevents expired staff users from logging into the public catalog
(and all other Evergreen interfaces and APIs) outright in order to
prevent them from getting into the staff interface anyway by
creative use of Evergreen's authentication APIs.

Evergreen admins are advised to check the expiration status of staff
accounts before turning on the global flag, as otherwise it is
possible to lock staff users out unexpectedly.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1907115 MARC editor avoid ID collisions

Generate DOM IDs for editable content components via incrementing int
instead of a random int.  This addresses cases where records with higher
numbers of MARC fields could result id DOM ID collisions, leading to
empty subfield values.

Also remove use of Renderer2, which is considered harmful and overkill
for simple document.getElementById()-equivalent calls.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1907115 MARC editor correctly absorbs breaker changes

MARC editor now correctly extracts MARC field data from the new
underlying MARC record when it is changed as a result of a breaker text
change and re-absorb.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Lp 1913219: Use window.open for staff catalog edit link; angular version

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Jason Stephenson <jason@sigio.com>

Lp 1913219: Use window.open for staff catalog edit link

To avoid the "Scripts may close only the windows that were opened by
them" console message in Chrome 88, and a similar message in Firefox
84, when clicking "Save & Exit" in the Volume/Copy editor of the
AngularJS staff client after opening it via the "edit" link in the
copy table of the TT OPAC record summary, we use an onclick handler
with window.open instead of a standard href in the edit anchor.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1910409 MARC Batch Edit Allows CSV Column 0

Fixes an issue where the "Go!" button was disabled in the MARC Batch
Edit interface when chosing column "0" for a CSV file updload.

Form now prevents values below 0 from being applied (via the number
spinner) and treats all column values >= 0 as valid.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1908763 Survey column sorting broken

Fixes the sorting on the Administration > Local Administration > Surveys
table.

To test.
1. Create a 3 or more surveys and note that none of the columns sort.
2. Apply the patch.
3. Sorting should now work.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>