evergreen/bjwebb.git
13 years agoSerials: routing list display glitchiness. Previously, the display did not
senator [Mon, 29 Nov 2010 16:25:38 +0000 (16:25 +0000)]
Serials: routing list display glitchiness.  Previously, the display did not
correctly handle a mix of received items with and without routing lists.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18851 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoAddress 1.6.1-2.0 upgrade problems reported by Ben Shum
dbs [Sun, 28 Nov 2010 15:11:55 +0000 (15:11 +0000)]
Address 1.6.1-2.0 upgrade problems reported by Ben Shum

1. We were attempting to update the asset.uri ID sequence value
with the wrong syntax; also, adding just 1 would return an error
in the event that only the seed value for asset.uri had been
inserted.

2. Somehow the body of the maintain_control_numbers() function
was pasted twice, resulting in a syntax error.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18850 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoAdd the asset.copy(create_date) index to the 1.6.1-2.0 update script
dbs [Wed, 24 Nov 2010 20:11:05 +0000 (20:11 +0000)]
Add the asset.copy(create_date) index to the 1.6.1-2.0 update script

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18847 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoEverything else in the menu is alphabetized (in English anyway), so Copy
senator [Wed, 24 Nov 2010 16:32:50 +0000 (16:32 +0000)]
Everything else in the menu is alphabetized (in English anyway), so Copy
Template Editor may as well be too.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18845 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoAdd an index on asset.copy(create_date) for item-age browse
dbs [Wed, 24 Nov 2010 03:31:14 +0000 (03:31 +0000)]
Add an index on asset.copy(create_date) for item-age browse

Running an item-age browse against a database with a reasonable
number of entries in asset.copy is dog-slow without an index
like this.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18842 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agomove all invocations of Volume/Copy Creator and Spine Label interfaces to tabs to...
phasefx [Tue, 23 Nov 2010 21:52:01 +0000 (21:52 +0000)]
move all invocations of Volume/Copy Creator and Spine Label interfaces to tabs to workaround https://bugs.launchpad.net/evergreen/+bug/677628

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18841 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoSerials: add ability to print routing lists from the batch receive interface
senator [Tue, 23 Nov 2010 21:40:36 +0000 (21:40 +0000)]
Serials: add ability to print routing lists from the batch receive interface

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18840 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoSerials: Fix error in batch receiving when trying to change the shelving
senator [Tue, 23 Nov 2010 21:38:28 +0000 (21:38 +0000)]
Serials: Fix error in batch receiving when trying to change the shelving
location of the previous item in the stream when there /is/ no previous
item in the stream

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18838 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoFurther fixes for hold-driven recalls
dbs [Tue, 23 Nov 2010 20:58:28 +0000 (20:58 +0000)]
Further fixes for hold-driven recalls

Force a scalar context on the array reference of circs returned
from the search clause to short-circuit the recall processing
if we have no applicable circs to work through.

Also, open-ils.trigger.event.autocreate needs a Fieldmapper object,
not a raw CDBI object, so invoke the to_fieldmapper() method to
convert it accordingly (thanks to miker for the assist!)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18837 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agofix broken prefix and namespace URI for the mods32 transform
gmc [Tue, 23 Nov 2010 14:11:51 +0000 (14:11 +0000)]
fix broken prefix and namespace URI for the mods32 transform

This breakage can be found in databases that started out at
version 1.2 or earlier; matters since in-DB ingest is stricter
with its XPATH processing.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18835 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agofix missing dep that prevented acq bib search form from working
gmc [Mon, 22 Nov 2010 22:47:09 +0000 (22:47 +0000)]
fix missing dep that prevented acq bib search form from working

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18831 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoappend to bottom of list for xul-based hold list interfaces. The result of this...
phasefx [Mon, 22 Nov 2010 20:38:28 +0000 (20:38 +0000)]
append to bottom of list for xul-based hold list interfaces.  The result of this is that rows appended off-screen (with just the hold id) will not make a network request for fleshing until they either become visible, or a column sort action is initiated

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18828 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agominor FeedTemplate bug fixes
miker [Mon, 22 Nov 2010 20:33:58 +0000 (20:33 +0000)]
minor FeedTemplate bug fixes

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18827 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agobug #680096 - upgrade script to partially reingest bibs after upgrade to 2.0
gmc [Mon, 22 Nov 2010 17:17:59 +0000 (17:17 +0000)]
bug #680096 - upgrade script to partially reingest bibs after upgrade to 2.0

This solves the problem of the new facets sidebar showing up empty in
OPAC search results.  Since the process of populating metabib.facet_entry
and updating metabib.*_field_entry can take a long time on large databases,
the update SQL is generated by a separate script, reingest-1.6-2.0.pl.  Usage
from an example run is:

./reingest-1.6-2.0.pl: generate SQL script to reingest bibs during an upgrade to Evergreen 2.0

By default, the script writes to the file reingest-1.6-2.0.sql.  To modify
this script's behavior, you can supply the following options:

--config /path/to/opensrf_core.xml  used to get connection information to
                                    the Evergreen database
--chunk_size n                      number of bibs to reingest in a chunk;
                                    specify if you don't want all of the
                                    bibs in the database to be reindexes
                                    in a single transaction
--output /path/to/output_file.sql   path of output SQL file

Writing output to file reingest-1.6-2.0.sql

SQL script complete.  To perform the reingest, please run the script using
the psql program, e.g.,

psql {connection parameters}  < reingest-1.6-2.0.sql

If you are running a large Evergreen installation, it is recommend that you
examine the script first; note that a reingest of a large Evergreen database
can take several hours.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18826 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agomore SuperCat XML fixup needed to support serials data -- important for opac customiz...
miker [Mon, 22 Nov 2010 17:04:56 +0000 (17:04 +0000)]
more SuperCat XML fixup needed to support serials data -- important for opac customization though BibTemplate (as in, "do not blow up")

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18823 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoadd field to IDL needed by, well, a bunch of stuff: sstr-[has_many]->items
miker [Mon, 22 Nov 2010 15:16:42 +0000 (15:16 +0000)]
add field to IDL needed by, well, a bunch of stuff: sstr-[has_many]->items

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18821 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agodocument a potential gotcha for users of open-ils.storage.action.circulation.overdue
gmc [Mon, 22 Nov 2010 13:36:54 +0000 (13:36 +0000)]
document a potential gotcha for users of open-ils.storage.action.circulation.overdue

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18818 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoparallel fine generator
gmc [Mon, 22 Nov 2010 13:17:57 +0000 (13:17 +0000)]
parallel fine generator

The fine generator cronjob can now use multiple
parallel processes by setting fine_generator/parallel
in opensrf.xml to a value greater than 1.  This
can speed up periodic fine generation in a database
containing a large number of overdue loans.

Also added a service to return just the list of
IDs of overdue loans and reservations - fleshing
the entire set of overdue loans when generating fines
has been observed to cause significant swap-thrashing in
at least one large database.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18817 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoThe absence of holds-triggered recall rules should not break hold targeting
dbs [Mon, 22 Nov 2010 04:46:49 +0000 (04:46 +0000)]
The absence of holds-triggered recall rules should not break hold targeting

Thanks to Galen Charlton for pointing out that if rules were not set for
holds-triggered recalls, then all hold targeting would break because of
an assumption the code made that one could invoke the ->{value} member
of the OU settings. But of course the return value for an unset OU setting
is undef, not an object with an undef ->{value} member.

This should unbreak that code path.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18816 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agohold targeter: add option to run parallel targeter processes
gmc [Mon, 22 Nov 2010 04:26:44 +0000 (04:26 +0000)]
hold targeter: add option to run parallel targeter processes

Permit the hold targeter to divvy up the work and run more than one process
at a time by setting the opensrf.xml setting hold_targeter/parallel to a
value greater than one.  Doing so can significantly reduce the
time it takes to (re)target a large number of hold requests, although
only up to a point (in other words, if increasing the number of parallel
targeters beyond one, it is recommended to do so slowly.)

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18815 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agobump xulrunner version
phasefx [Sun, 21 Nov 2010 15:38:52 +0000 (15:38 +0000)]
bump xulrunner version

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18814 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoadd xhtml namespace to global.css, though I can't figure out how to style the xhtml...
phasefx [Sun, 21 Nov 2010 10:36:10 +0000 (10:36 +0000)]
add xhtml namespace to global.css, though I can't figure out how to style the xhtml.textarea in the marc editor with font_helper.  Tried .ALL_FONTS_LARGER xhtml.textarea and .ALL_FONTS_LARGER *.textarea to no avail

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18813 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoSerials: a routing list editor for the alternate serials control view
senator [Sat, 20 Nov 2010 22:55:56 +0000 (22:55 +0000)]
Serials: a routing list editor for the alternate serials control view

Now we still need to teach the receive interface to offer to print the list
when there is one, but I think that should be relatively simple.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18812 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoUpgrade script should define a valid PLPERLU function
dbs [Sat, 20 Nov 2010 19:55:03 +0000 (19:55 +0000)]
Upgrade script should define a valid PLPERLU function

Also update 1.6.1-2.0 upgrade script.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18810 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoAddress maintain_control_numbers() database function bug #677160
dbs [Sat, 20 Nov 2010 19:47:54 +0000 (19:47 +0000)]
Address maintain_control_numbers() database function bug #677160

Jason Stephenson reported a bug handling records with multiple
001 or 003 fields, and supplied a set of test records to
reproduce the condition. The bug caused the ingest process
to throw a database error, rolling back the transaction and
preventing the actual ingest of those records.

The solution was to simplify the logic in maintain_control_numbers().
Now, in the case that there are either multiple 001s or 003s in the
incoming record, we simply delete all of the 003s and 001s and
create the desired 001 and 003. Also, if there are not exactly one
001 and one 003 in the incoming record, we do not try to preserve
one of those values in the 035 as it would be close to meaningless.

Many thanks to Jason for the clear bug report and test cases!

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18809 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agono one likes the persisting call number with fast add, not even me :)
phasefx [Fri, 19 Nov 2010 20:40:53 +0000 (20:40 +0000)]
no one likes the persisting call number with fast add, not even me :)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18807 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoPlace holds on issuances from the OPAC. Not backporting yet as it might be too
senator [Thu, 18 Nov 2010 22:45:34 +0000 (22:45 +0000)]
Place holds on issuances from the OPAC. Not backporting yet as it might be too
ugly (visually)

Also a couple very minor API documentation fixes

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18800 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoonly allow choice from active providers when creating POs and invoices
gmc [Thu, 18 Nov 2010 20:31:39 +0000 (20:31 +0000)]
only allow choice from active providers when creating POs and invoices

Also removed cusotm defaultLinkedDataLoader for the provider selection widget;
no longer necessary since pcrud handles filter by OUs

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18798 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoStomp another ru-RU PO problem in lang.dtd
dbs [Thu, 18 Nov 2010 20:03:38 +0000 (20:03 +0000)]
Stomp another ru-RU PO problem in lang.dtd

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18796 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoUnbreak the Russian translation
dbs [Thu, 18 Nov 2010 19:43:51 +0000 (19:43 +0000)]
Unbreak the Russian translation

Ampersands at the end of msgstr entries break translate-toolkit but good.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18795 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoReplace deprecated use of window.opener in unit selection window.
dbwells [Thu, 18 Nov 2010 19:22:46 +0000 (19:22 +0000)]
Replace deprecated use of window.opener in unit selection window.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18792 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agomark some non-NULL provider and EDI fields as required
gmc [Thu, 18 Nov 2010 17:38:21 +0000 (17:38 +0000)]
mark some non-NULL provider and EDI fields as required

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18790 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agouse pcrud auto-complete widget when selecting providers
gmc [Thu, 18 Nov 2010 16:28:21 +0000 (16:28 +0000)]
use pcrud auto-complete widget when selecting providers

Fixes general slowness working with invoice and PO forms if
more than a couple hundred providers are defined.

This could be generalized with a bit of work with Fieldmapper
to define "has-one-chosen-by-user-from-cast-of-thousands"
relationships that should trigger use the auto-complete widget.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18785 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agofetchItemByIdentity now returns null immediately upon null identity
gmc [Thu, 18 Nov 2010 16:28:19 +0000 (16:28 +0000)]
fetchItemByIdentity now returns null immediately upon null identity

Besides being trivially more efficient, this avoids a situation
where pcrud can sometimes time out when attempting to retrieve
a row by a null PK value.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18784 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agofetch more than the default 10 (per page) distrib formulas; 500 is arbitrary, but...
erickson [Thu, 18 Nov 2010 15:36:18 +0000 (15:36 +0000)]
fetch more than the default 10 (per page) distrib formulas;  500 is arbitrary, but still notably less than the infinity that was in effect before paging.  todo: research optiosn for using the new autofieldwidget/dojo/pcrud-store instead

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18780 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoApparently, IE versions 6+ can handle ssl+keepalive. this apache change should help...
erickson [Thu, 18 Nov 2010 14:31:33 +0000 (14:31 +0000)]
Apparently, IE versions 6+ can handle ssl+keepalive.  this apache change should help speed up IE w/ ssl and reduce server back-and-forth

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18775 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoHold targeting didn't work right on type I (issuance) holds, but now it does
senator [Wed, 17 Nov 2010 21:59:50 +0000 (21:59 +0000)]
Hold targeting didn't work right on type I (issuance) holds, but now it does

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18772 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoAdd authority control support for 630 and 648 fields
dbs [Wed, 17 Nov 2010 18:59:58 +0000 (18:59 +0000)]
Add authority control support for 630 and 648 fields

Thanks to Ole Kerpel <oke@iisg.nl> for providing the additional
definitions for this support to bring us closer to MARC
authority control norms.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18770 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years ago0 (zero) is a valid depth, so allow it via defined()
miker [Wed, 17 Nov 2010 16:57:55 +0000 (16:57 +0000)]
0 (zero) is a valid depth, so allow it via defined()

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18768 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agopass the supplied depth parameter to the query parser for use
miker [Wed, 17 Nov 2010 16:42:38 +0000 (16:42 +0000)]
pass the supplied depth parameter to the query parser for use

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18766 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoadd libnet-ssh2-perl to Debian package deps
gmc [Wed, 17 Nov 2010 04:08:29 +0000 (04:08 +0000)]
add libnet-ssh2-perl to Debian package deps

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18764 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoin the staff client, use the user object in the XUL stash instead of grabbing the...
erickson [Tue, 16 Nov 2010 23:33:27 +0000 (23:33 +0000)]
in the staff client, use the user object in the XUL stash instead of grabbing the user object on each page load for embedded staff web UIs (/eg/).  This is one less pre-onload XHR and another step in the avoidance of the cursed WSOD.  Added support for launching the xul login dialog after a timed out session event is returned.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18763 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoWonder of wonders, a Dojo data store supporting lazy loading objects via pcrud!
senator [Tue, 16 Nov 2010 23:02:25 +0000 (23:02 +0000)]
Wonder of wonders, a Dojo data store supporting lazy loading objects via pcrud!

So openils.PermaCrud.Store was dreamt up and directed by Mike Rylander, and
implemented by me.  Right now it gives us a new way to provide widgets for
selecting objects in Dojo-based interfaces.

Where previously we had some dropdowns here and there that really shouldn't
be dropdowns (such as one for selection lists in Acq, and several for resources
and resource types in Booking -- these examples I've replaced, but there are
surely more) because loading a dropdown with potentially zillions of items
to choose from can take forever and break the interface, now we can have
autocompleting textboxes that only load items matching what you type (and
even then with a low-ish default limit so that if you're vague in your input
you still don't get huge unwieldy result sets).

Easiest way to see an example is if you already have any acq selection lists.
Just go to any catalog record, choose Actions for this Record, choose View/Place
orders, then click "Add to Selection List." In the resulting dialog, that
second field used to be a dropdown, but now it's an autocompleting textbox.

Alternatively, you can see these in the affected booking interfaces (see files
modified in this commit) under Admin -> Server Administration -> Booking.

The future promises even better things for this store. When it implements the
Dojo Write API, interfaces using grids can potentially be vastly simplified
by relying on the store to save its own dirty objects. The Notification API
would facilitate easy use of single stores with multiple widgets. All good
things for faster-to-write interfaces.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18762 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoRemove deprecated 'all_dists' option for make_predictions(), pass along _build_unit...
dbwells [Tue, 16 Nov 2010 21:16:05 +0000 (21:16 +0000)]
Remove deprecated 'all_dists' option for make_predictions(), pass along _build_unit events.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18760 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoextend the opac org hiding feature to the place hold pickup lib menu. Note that...
phasefx [Tue, 16 Nov 2010 20:10:13 +0000 (20:10 +0000)]
extend the opac org hiding feature to the place hold pickup lib menu.  Note that this feature depends on Apache being configured to maintain the ol= URL param

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18757 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoand ... we do not need GREATEST()
miker [Tue, 16 Nov 2010 16:51:49 +0000 (16:51 +0000)]
and ... we do not need GREATEST()

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18755 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agopush the asset.uri pkey serial into reality -- before 2.0 we did not use the serial
miker [Tue, 16 Nov 2010 16:50:31 +0000 (16:50 +0000)]
push the asset.uri pkey serial into reality -- before 2.0 we did not use the serial

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18754 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoreturn AutoIDL to its original state of loading the while IDL if no classes are selec...
erickson [Mon, 15 Nov 2010 20:26:22 +0000 (20:26 +0000)]
return AutoIDL to its original state of loading the while IDL if no classes are selected.  This will ease the process of moving to /IDL2js;  other minor cleanup

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18747 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoSerials: two little things to make alt serials control interfaces less painful
senator [Mon, 15 Nov 2010 18:28:25 +0000 (18:28 +0000)]
Serials: two little things to make alt serials control interfaces less painful
to use.

The copy template editor now gives dropdowns for fine level and loan duration.
This is particularly useful since at receive time, if you're trying to create
units, you can't do it with null values in those fields.

The caption and pattern pane of the subscription details interface now sets the
active checkbox to checked by default when creating new caption and patterns.
This helps prevent user confusion if you create a caption/pattern and move on
to the issuances tab and find that you can't apply the caption/pattern that
you just created because you didn't make it "active."

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18745 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agomake sure dojo.cookie is loaded before use; removed unnecessary import of dojoData
erickson [Mon, 15 Nov 2010 17:01:07 +0000 (17:01 +0000)]
make sure dojo.cookie is loaded before use; removed unnecessary import of dojoData

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18740 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoReverting and extending r18472 to correct implementation thinko
miker [Mon, 15 Nov 2010 15:15:15 +0000 (15:15 +0000)]
Reverting and extending r18472 to correct implementation thinko

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18734 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoPrevent creation of authority records that are truncated by one letter
dbs [Mon, 15 Nov 2010 05:23:56 +0000 (05:23 +0000)]
Prevent creation of authority records that are truncated by one letter

The summarizeField() function grabbed the values of the XUL elements,
which were set by the keypress event listeners on the XUL elements.
However, the keypress event listener seems to capture the value of
the XUL element before the value of the new key is appended to the
existing value in a textbox - so, when you typed a new subfield, then
right-clicked to create an authority, the value that was captured was
missing the final character.

Adding the "input" event to the registered listeners captures the
actual value for creating an authority and solves the problem. It
might be possible to remove the keypress event listeners, but for
now we'll take the cautious route.

Address Launchpad bug 669445

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18731 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoFix negative paging issue in open-ils.supercat.authority.author.startwith
dbs [Mon, 15 Nov 2010 04:50:22 +0000 (04:50 +0000)]
Fix negative paging issue in open-ils.supercat.authority.author.startwith

When paging backwards through authority lists, we were skipping the
first page of results. By reducing the offset by the value of one
page, we restore the expected order.

The same problem might affect other paging interfaces: to be determined.

Closes Launchpad bug 669247

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18728 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoDo not cache the authority context menu
dbs [Mon, 15 Nov 2010 01:45:11 +0000 (01:45 +0000)]
Do not cache the authority context menu

Caching would be great, except when you add an authority in the
flow and you expect to see it the next time you right-click
on the authority that you just added.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18727 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoMerge translations from Launchpad
dbs [Sun, 14 Nov 2010 03:23:11 +0000 (03:23 +0000)]
Merge translations from Launchpad

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18726 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoin some scenarios, the 'mous' class may not have loaded yet. pre-load the class...
erickson [Fri, 12 Nov 2010 20:52:08 +0000 (20:52 +0000)]
in some scenarios, the 'mous' class may not have loaded yet.  pre-load the class in myopac init

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18723 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoCache the language set (per locale) in a cookie
miker [Fri, 12 Nov 2010 20:39:09 +0000 (20:39 +0000)]
Cache the language set (per locale) in a cookie

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18719 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoTrim the set of classes and fields pulled in by Searcher; Cache the cmc data (cmf...
miker [Fri, 12 Nov 2010 20:37:37 +0000 (20:37 +0000)]
Trim the set of classes and fields pulled in by Searcher; Cache the cmc data (cmf is too big)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18718 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoensure that we only fetch this setting once per page
phasefx [Fri, 12 Nov 2010 19:43:27 +0000 (19:43 +0000)]
ensure that we only fetch this setting once per page

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18715 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoread XSL file and path from opensrf.xml
erickson [Fri, 12 Nov 2010 18:36:19 +0000 (18:36 +0000)]
read XSL file and path from opensrf.xml

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18714 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoServer-generated IDL JS
erickson [Fri, 12 Nov 2010 13:55:58 +0000 (13:55 +0000)]
Server-generated IDL JS

The goal is to reduce use of pre-onload XHR, which is known to cause
problems (dreaded white-screen-of-death) in firefox/xulrunner.  Change
allows opac, staff client, and embedded browser interfaces to load
a pre-formatted JS object instead of IDL XML via XHR.  In addition to
dropping the XHR, clients no longer parse the XML, which should reduce
page render time.  Finally, in the staff interfaces, the full IDL is
once again loaded, so there is no need to specifiy per-page classes.
Per-page classes are still supported and used in the OPAC to reduce the
up-front load time.

Change requires an update to the Evergreen Apache config.  See -r18700.

Part of this change included condensing fieldmapper.hash and
fielmapper.dojoData content into fieldmapper.Fieldmapper to avoid
circular dependencies, which was causing problems with IE.  Will
eventually want to deprecate .hash and .dojoData, but for now they still
function as before.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18712 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoadded permacrud chunk to IDL JS; fixed datatype copy/paste-o
erickson [Thu, 11 Nov 2010 19:03:58 +0000 (19:03 +0000)]
added permacrud chunk to IDL JS; fixed datatype copy/paste-o

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18711 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agopatch from bshum to bring his Search Catalog button in the button bar inline with...
phasefx [Thu, 11 Nov 2010 17:41:13 +0000 (17:41 +0000)]
patch from bshum to bring his Search Catalog button in the button bar inline with tsbere's r18431 for new tab vs current tab functionality with the button bar

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18710 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoAvoid munging 035 when a new record is created
dbs [Thu, 11 Nov 2010 16:55:52 +0000 (16:55 +0000)]
Avoid munging 035 when a new record is created

If there is no 003 in the record when it is created, then we will not attempt
to generate a 035. If the incoming record contains a 001 and 003, then we will
create a 035.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18707 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoDo not supply a default value for 003 in new authority records
dbs [Thu, 11 Nov 2010 16:50:10 +0000 (16:50 +0000)]
Do not supply a default value for 003 in new authority records

With cat.maintain_control_numbers enabled by default, we can trust
the database trigger to create the appropriate 003 for us - and by
not supplying a 003 in the new record, we won't create a spurious
035 for a brand new record.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18706 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoreal fields start at position 0; isnew/changed/deleted are shoved into the end
erickson [Thu, 11 Nov 2010 16:03:09 +0000 (16:03 +0000)]
real fields start at position 0; isnew/changed/deleted are shoved into the end

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18705 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoUse a more generic defaultValue template for datatype defaulting; Apply said to label...
miker [Thu, 11 Nov 2010 15:50:36 +0000 (15:50 +0000)]
Use a more generic defaultValue template for datatype defaulting; Apply said to label for class and field

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18704 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agowraps tips appendChild in try/catch to prevent occaisonal exeptions.
erickson [Thu, 11 Nov 2010 15:39:59 +0000 (15:39 +0000)]
wraps tips appendChild in try/catch to prevent occaisonal exeptions.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18702 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoretab w/ spaces for copy/paste tabs
erickson [Thu, 11 Nov 2010 15:38:37 +0000 (15:38 +0000)]
retab w/ spaces for copy/paste tabs

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18701 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agomod_perl handler for idl2js transform w/ configs
erickson [Thu, 11 Nov 2010 15:37:04 +0000 (15:37 +0000)]
mod_perl handler for idl2js transform w/ configs

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18700 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agorepaired field name iteration thinko. reduce calls to Array.length, mainly for poor...
erickson [Thu, 11 Nov 2010 15:31:24 +0000 (15:31 +0000)]
repaired field name iteration thinko.  reduce calls to Array.length, mainly for poor ol' IE's sake.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18699 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoAdd key, class and reltype to link fields; Provide default datatype of "text"; Add...
miker [Thu, 11 Nov 2010 14:46:03 +0000 (14:46 +0000)]
Add key, class and reltype to link fields; Provide default datatype of "text"; Add isnew, ischanged and isdeleted inline

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18698 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoXSL for creating a JS representation of the IDL XML. sample usage: xsltproc --string...
erickson [Thu, 11 Nov 2010 13:35:37 +0000 (13:35 +0000)]
XSL for creating a JS representation of the IDL XML.  sample usage: xsltproc --stringparam class_list acn,bre fm_IDL2js.xsl fm_IDL.xml.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18697 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoUpdate the edit dates for authority and MFHD records when they are edited
dbs [Thu, 11 Nov 2010 03:49:31 +0000 (03:49 +0000)]
Update the edit dates for authority and MFHD records when they are edited

Addresses the oversight in the original implementation that missed this;
important if we're going to differentiate between creating and editing
a record for triggers.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18695 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoEnable "maintain control numbers" and "record ID as TCN" behavior by default
dbs [Wed, 10 Nov 2010 22:26:42 +0000 (22:26 +0000)]
Enable "maintain control numbers" and "record ID as TCN" behavior by default

Per http://ur1.ca/2bgc4, this behavior hews more closely to the MARC21
specification. Note, however, that duplicate bib detection in the
"Import via Z39.50" interface will be somewhat affected; a more
trustworthy workaround is to include the "Local catalog" in Z39.50 searches to
determine if a matching record already exists in the database.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18693 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoSerials: patch from Dan Wells to address Launchpad bug #670734
senator [Wed, 10 Nov 2010 21:51:01 +0000 (21:51 +0000)]
Serials: patch from Dan Wells to address Launchpad bug #670734

Previously, a dialog box to select an org unit for the creation of legacy
MFHD records relied on a feature (window.opener) that has been
removed in newer versions of XULRunner.

This patch has that dialog box use a different, safer approach to accomplish
its task.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18691 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoBooking: fix bug reported by Robert Soulliere wherein the items associated
senator [Wed, 10 Nov 2010 21:29:51 +0000 (21:29 +0000)]
Booking: fix bug reported by Robert Soulliere wherein the items associated
with picked-up reservations didn't actually get their status set to 'checked
out' like they should have.

Robert reported this bug on Launchpad (#672748) and provided a patch, but
there were some neighboring bugs in the circulation logic anyway, so they've
all been fixed together.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18688 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoreplace Cookie.js/cookieManager with dojo.cookie. Some things to watch out for as...
phasefx [Wed, 10 Nov 2010 20:51:23 +0000 (20:51 +0000)]
replace Cookie.js/cookieManager with dojo.cookie.  Some things to watch out for as we review this changeset:

In Cookie.js, a -1 passed as the expires parameter indicated a session cookie.  We could also specify such things as "+1y" or a specific date.  With dojo.cookie, an expires value of -1 deletes a cookie.  Not specifying an expires option will create a session cookie.  We can enter a date or a number days from today.  For the case in the code where we had "+1y", I supplied a value of 365.

In the previous code, we used empty strings for a lot of cookie deletion.  The canonical dojo example has us using null (with an expires of -1).  There were also some cases where it seemed obvious that we were deleting cookies, but were at the same passing an actual value (see base.js).  I changed these to nulls.

In opac_utils.js, grabFleshedUser(), I fixed a dead code path where a cookie deletion attempt came after a return statement.

I ran through the opac within and outside of the staff client, tried all of the acquisition UI's from the Acq menu, and most of the interfaces under Admin, and didn't find any auth cookie errors.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18687 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoImproved permission checking speed for PCRUD mode.
miker [Wed, 10 Nov 2010 19:53:37 +0000 (19:53 +0000)]
Improved permission checking speed for PCRUD mode.

When there are more than some number of rows (5, by default) we use usr_has_perm_at_all to get the list of locations and cache them.  This cache is flushed per-session.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18686 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoMerge serials-integration branch, incorporating new work from Dan Wells.
senator [Wed, 10 Nov 2010 17:54:34 +0000 (17:54 +0000)]
Merge serials-integration branch, incorporating new work from Dan Wells.

Specifically, this contains changesets 18670, 18669, 18379, and 18373.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18685 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoddoouubblleedd line ... thought I squashed that
miker [Wed, 10 Nov 2010 16:26:23 +0000 (16:26 +0000)]
ddoouubblleedd line ... thought I squashed that

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18684 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoMove the magic-bib update to the top of the file, avoiding triggers that care about...
miker [Wed, 10 Nov 2010 14:52:13 +0000 (14:52 +0000)]
Move the magic-bib update to the top of the file, avoiding triggers that care about XML namespaces

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18683 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agodo not use TRUNCATE when refreshing reporter.materialized_simple_record
gmc [Wed, 10 Nov 2010 13:18:29 +0000 (13:18 +0000)]
do not use TRUNCATE when refreshing reporter.materialized_simple_record

Previous behavior would break Slony replication after doing a
bib load.  Since a deletion is slower than a truncate, if you're
not using Slony replication, you may prefer to truncate rmsr
prior to calling reporter.enable_materialized_simple_record_trigger.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18677 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoremove the last of DP_DateExtensions. We should probably move the format options...
phasefx [Tue, 9 Nov 2010 20:34:36 +0000 (20:34 +0000)]
remove the last of DP_DateExtensions.  We should probably move the format options for dojo.date.locale.format to some constants for easier skinning

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18675 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agodynamically loaded classes also need access to toHash
erickson [Mon, 8 Nov 2010 22:05:50 +0000 (22:05 +0000)]
dynamically loaded classes also need access to toHash

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18673 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoremoving original typo
miker [Mon, 8 Nov 2010 21:43:55 +0000 (21:43 +0000)]
removing original typo

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18672 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAllow forced loading of the whole IDL with: fieldmapper.IDL.load(["*"]);
miker [Mon, 8 Nov 2010 21:37:42 +0000 (21:37 +0000)]
Allow forced loading of the whole IDL with: fieldmapper.IDL.load(["*"]);

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18668 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agorepaired typo
erickson [Mon, 8 Nov 2010 21:26:26 +0000 (21:26 +0000)]
repaired typo

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18667 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAdd the OpenURL resolver caching service as an optional component
dbs [Mon, 8 Nov 2010 21:21:31 +0000 (21:21 +0000)]
Add the OpenURL resolver caching service as an optional component

Currently limited to supporting the Ex Libris SFX OpenURL resolver,
this caches the results of looking up full-text availability of
resources by ISBN or ISSN.

For an example of incorporating this service into your OPAC, see
http://svn.open-ils.org/trac/ILS-Contrib/browser/conifer/branches/rel_1_6_1/web/opac/skin/lul/xml/result/result_table.xml#L102
for returning the full-text availability of a given resource by ISSN.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18666 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoteach vivicateClass to set up dojoData APIs for classes loaded by fieldmapper.IDL...
miker [Mon, 8 Nov 2010 21:18:40 +0000 (21:18 +0000)]
teach vivicateClass to set up dojoData APIs for classes loaded by fieldmapper.IDL.load() when appropriate

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18665 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agomake sure classes are /always/ loaded from the server
miker [Mon, 8 Nov 2010 21:17:45 +0000 (21:17 +0000)]
make sure classes are /always/ loaded from the server

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18664 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAcq: in acq search, avoid trying to create a dropdown from every bib ID in
senator [Mon, 8 Nov 2010 20:44:06 +0000 (20:44 +0000)]
Acq: in acq search, avoid trying to create a dropdown from every bib ID in
the system, providing a normal text input field instead (or search by file
of terms).

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18662 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoMore fixing related to r18657
miker [Mon, 8 Nov 2010 19:03:38 +0000 (19:03 +0000)]
More fixing related to r18657

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18660 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agosyntax
phasefx [Mon, 8 Nov 2010 18:46:21 +0000 (18:46 +0000)]
syntax

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18657 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agokeep trunk version of the 2.0 upgrade script in sync ... for now
miker [Mon, 8 Nov 2010 16:34:11 +0000 (16:34 +0000)]
keep trunk version of the 2.0 upgrade script in sync ... for now

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18656 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoTeach vandelay.replace_field to be a little smarter by allowing simple cases of both...
miker [Mon, 8 Nov 2010 16:22:59 +0000 (16:22 +0000)]
Teach vandelay.replace_field to be a little smarter by allowing simple cases of both replacing and regexp-testing the same subfield

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18652 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoholds retrieval API call sorting and cleanup; sort non-cancelled holds by ready...
erickson [Mon, 8 Nov 2010 16:21:15 +0000 (16:21 +0000)]
holds retrieval API call sorting and cleanup;  sort non-cancelled holds by ready-for pickup, then active, then suspended;  use json_query to fetch IDs first, so id_list calls can avoid fetching the full hold objects in the ML.  sort fleshed transit by send time to pick up the latest transit

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18650 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoFurther Fedora prereq installer tweaks
dbs [Mon, 8 Nov 2010 02:57:04 +0000 (02:57 +0000)]
Further Fedora prereq installer tweaks

  * Install the Perl DBD::Pg module
  * Force the CPAN modules, as Business::OnlinePayment::AuthorizeNet
    still suffers from an install-crippling bug

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18648 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAdd UUID::Tiny to Fedora prerequisites
dbs [Mon, 8 Nov 2010 01:29:26 +0000 (01:29 +0000)]
Add UUID::Tiny to Fedora prerequisites

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18646 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoImprove Fedora prerequisite installer
dbs [Mon, 8 Nov 2010 00:34:00 +0000 (00:34 +0000)]
Improve Fedora prerequisite installer

  * Explicitly install wget, which isn't installed in a minimal install
  * Hack JavaScript-SpiderMonkey Makefile.PL for 32-bit Fedora
  * Provide a fedora14 target
  * Change "fedora-13" to "fedora13" to match OpenSRF prereq installer

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18644 dcc99617-32d9-48b4-a31d-7c20da2025e4