miker [Mon, 7 Jun 2010 16:53:55 +0000 (16:53 +0000)]
Patch from Galen Charlton:
Fix glitch in definition of the new default identifier indexes that would cause bib ingest to fail. Note that this affected only newly-created databases; the upgrade script for 0265 is correct.
Thanks to Lee Dickens for running into this bug.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16615
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Mon, 7 Jun 2010 16:10:48 +0000 (16:10 +0000)]
Patch from Galen Charlton: The attached patch adds triggers on biblio.record_entry and authority.record_entry to prevent the insertion or update of MARCXML that is not well-formed. Since the various consumers of bre.marc and are.marc tend not to handle invalid XML all that well, these triggers serve as a (very basic) data integrity check. libmail.georgialibraries.org/pipermail/open-ils-dev/2010-June/006116.html
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16614
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Mon, 7 Jun 2010 13:52:29 +0000 (13:52 +0000)]
Added a new login type "persist", as a peer of "opac", "staff", and "temp".
It is intended for sessions that may stay open for days or weeks at a time
even in the absence of activity. The default timeout interval is defined
as two weeks in opensrf.xml, and may be overridden by the org unit
setting "auth.persistent_login_interval".
Timeout resets work a little differently for persistent logins. They
have no effect unless the session is within ten minutes of expiring. When
they do take effect, they reset the timeout to ten minutes, rather than to
the full length of the original timeout. That way we can avoid rudely
interrupting an active session without extending it excessively.
The ten minute reset interval for persistent timeouts is currently
hard-coded. With some further work it could be made configurable.
The timeout resets for the older login types still work the way they
always have.
------------
In order to make it easier to specify long timeout intervals, the
auth server now accepts PostgreSQL-style interval strings, such as
"15 minutes" or "2 weeks". Such strings work for any of the login
types, and they work either in opensrf.xml or in the org unit setting
values.
If the timeout setting (in either context) is all digits, then it will
be interpreted as an integral number of seconds, as it has been in the
past. So existing settings will almost certainly continue to work
without change.
The exception -- an unlikely one -- is if the existing setting carries
a leading plus sign. Under the old regime, a leading plus sign was
simply superfluous, and had no effect. With the new version, a
leading plus sign means that the following number is to be treated as
a number of hours, rather than a number of seconds (just because
that's what PostgreSQL does with it).
Hence in the unlikely event that existing settings use a leading
plus sign, this change will make those timeouts 3600 times as long
as they should be.
If the timeout interval is expressed as anything other than a string
of all digits (possibly with leading and/or trailing white space), we
make a database call to get PostgreSQL to interpret it for us. So the
convenience of using interval strings comes at the price of some
additional overhead.
--------------
Besides applying the changes to the C code, it will be necessary to
update the opensrf.xml file in order to define a default timeout
interval for the new login type.
M Open-ILS/include/openils/oils_constants.h
M Open-ILS/src/c-apps/oils_auth.c
M Open-ILS/examples/opensrf.xml.example
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16612
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 7 Jun 2010 06:19:33 +0000 (06:19 +0000)]
Update a complete set of PO files in trunk
For all languages that have submitted any significant amount of translation,
commit PO files for every available POT or PO file (including our many new Dojo
I18N resource bundles)
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16611
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 7 Jun 2010 06:02:03 +0000 (06:02 +0000)]
Get the Makefile up to date with all of our new Dojo resource files
At some point, this Makefile has to become smarter, because there's a
whole lot of error-prone copying and pasting going on right now.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16610
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 7 Jun 2010 05:57:06 +0000 (05:57 +0000)]
Stab at matching up reservation.js with the pluralized, JSON-compliant Dojo NLS file
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16609
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 7 Jun 2010 05:45:26 +0000 (05:45 +0000)]
Make booking reservation Dojo NLS file JSON-compliant
You can't use string concatentation based on the plurality of arguments
to create a translatable string. Solution: create a singular and a plural
version of the string, and use the logic in the program itself to pass in
the substitution variable to the correct respective string.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16608
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 7 Jun 2010 05:38:08 +0000 (05:38 +0000)]
Smarter error handling in Dojo i18n script
Identify the troublesome file before allowing the traceback
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16607
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 7 Jun 2010 05:36:47 +0000 (05:36 +0000)]
More cleanup of Dojo JSON files
* Double-quote all strings - no single-quoting or barewords
* Don't escape dollar signs
* JSON doesn't allow expressions like string continuations ("" + "")
reservations.js has some remaining issues, looks like functions were
defined for what should be simple string substitutions. dojo.string.substitute()
will solve this problem, I believe, with ${0}, ${1}, etc tokens for substitution
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16606
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 7 Jun 2010 05:15:52 +0000 (05:15 +0000)]
In Dojo i18n script: create output directories if they don't exist
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16605
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 7 Jun 2010 05:00:16 +0000 (05:00 +0000)]
Fix up acq Dojo NLS file to be strictly JSON compliant
simplejson chokes on non-compliant JSON:
* Strings must be delimited in double-quotes
* Joining strings with + is not allowed
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16604
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 7 Jun 2010 03:48:07 +0000 (03:48 +0000)]
Commit updates from Launchpad translation
Bringing all of the translated files up to date with what is in Launchpad.
Next steps: generate all of the updates from trunk and add all the new files
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16603
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Sun, 6 Jun 2010 01:54:31 +0000 (01:54 +0000)]
New function oilsUtilsIntervalToSeconds() to translate a string into a
number representing the number of seconds in an interval of time.
Simple integers are converted directly. Anything else is passed to
PostgreSQL to be translated as an interval string.
M Open-ILS/include/openils/oils_utils.h
M Open-ILS/src/c-apps/oils_utils.c
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16602
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Fri, 4 Jun 2010 21:36:03 +0000 (21:36 +0000)]
Email/print methods for printing A/T templated bib information
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16601
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 4 Jun 2010 20:53:27 +0000 (20:53 +0000)]
Bugfixes: undef handling and legacy script support setting.
The legacy setting was a major bug. It was not possible to disable legacy scripts
except by *removing* the setting. That is, if you set it to 'false',
we failed to interpret that here in SIP to mean FALSE. Instead we
looked at it as a non-zero-length string and therefore TRUE!
This patch also prevents warnings from unitialized values (undef concatenation), like:
Use of uninitialized value in concatenation (.) or string at /openils/lib/perl5/OpenILS/SIP/Patron.pm line 110.
Added a little formatting and whitespace cleanup to address display along w/ undef handling.
Corrected an error screen message also.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16600
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 4 Jun 2010 20:53:25 +0000 (20:53 +0000)]
Checkin overhual for extensions, including item, patron and checkin underpinnings.
Extensions fields added to AUTOLOADable content.
Also fix checkin logic to check for NO_CHANGE and SUCCESS at necessary moments.
Update new code to match berick's #16544.
Add AUTOLOAD to Item and provide a slot to store the raw EG hold object.
Store the hold data down on the item (not the Checkin transaction level).
Allow SIP Patron lookup by usr ID (not barcode).
This is important because we need supplemental data when we find holds info at checkin.
The change is backwards compatible (w/ just 1 arg it will still be treated as a barcode).
Propagate $inst_id down into checkout core, needed for hold routing logic.
Remove old accessor methods, also make some of the settings checks more flexible w/ regex.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16599
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 4 Jun 2010 20:53:24 +0000 (20:53 +0000)]
Experimental implementation: renewal, block, enable.
Add sip_renewal (not implemented), correct log message w/ join
Patron block message and patron enable
This adds code for enable, still experimental. It also adds the
client's block message to the patron alert, bracketed by <sip> tags.
The tags are necessary because enable has to be able to regexp out
the block alert message (including user-specified variable text).
Remove unused vars.
Whitespace cleanup and extra feedback data.
Return object on failure, not just 0
Signed-off-by: Joe Atzberger <atz@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16598
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 4 Jun 2010 20:53:23 +0000 (20:53 +0000)]
Lots of cleanup, logging improvements, and comments.
One arrayref accessor updated to recommended style
Removed unused dependency.
Removed never-possible return statement.
Trying to use an arrayref in the log message results in a string like "ARRAY(0x2541870)".
I added a prebuilt string representation of the array for use in those messages.
More whitespace cleanup.
More flexible to_bool, extra comments;
Also added institution_id method.
Note: OpenILS::Event->new returns a hash, not a true object.
script_x_check.sh is executable.
Irony: this script could have been used to detect itself.
Typo in Cronscript POD.
Signed-off-by: Joe Atzberger <atz@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16597
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 4 Jun 2010 20:53:22 +0000 (20:53 +0000)]
Basic check for missing DB upgrades
Run this after a update_db.sh failure to see what failed.
Or run in before update_db.sh to make sure you are ready to apply
new updates.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16596
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Fri, 4 Jun 2010 19:00:55 +0000 (19:00 +0000)]
Add two little utility functions to convert from intervals to seconds.
M Open-ILS/src/sql/Pg/999.functions.global.sql
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0293.function.interval-to-seconds.sql
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16594
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Fri, 4 Jun 2010 15:07:13 +0000 (15:07 +0000)]
thinko (unquoted string literal); be more explicity about circ lib comparisons
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16593
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 4 Jun 2010 13:28:37 +0000 (13:28 +0000)]
added granularity and user_data options to create_events_for_hook wrapper
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16590
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Fri, 4 Jun 2010 03:54:14 +0000 (03:54 +0000)]
Improve circ transaction performance by indexing NULL circs (Launchpad 587031)
Creating a unique index on target_copy in the action.circulation table where
the checkin_time is NULL will increase the speed of circ transactions,
particularly on systems with a lot of traffic. The uniqueness also
ensures that a given item will not be able to be checked out multiple times
concurrently.
Thanks to James Fournie from BC Sitka for suggesting the index in Launchpad
bug 587031!
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16589
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Fri, 4 Jun 2010 03:29:03 +0000 (03:29 +0000)]
Improve database performance for partial indexes on boolean columns (bug 587028 in Launchpad)
PostgreSQL 8.3/8.4 treats "IS FALSE" and "= FALSE" expressions differently,
which can have a significant impact on database performance if an index is
created with one and a query uses the other. This patch addresses all existing
partial indexes on boolean columns to enable the query planner to use an index
scan whether the query uses either expression.
Thanks to James Fournie of BC Sitka for noticing the problem with the index
on asset.copy and opening bug 587028 in Launchpad with the suggested fix!
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16588
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Thu, 3 Jun 2010 20:02:39 +0000 (20:02 +0000)]
Various tweaks:
1. When resetting the timeout for a session: if the session object
carries an endtime, and the expiration time is within a designated
interval, extend the expiration time a bit instead of reapplying the
entire original timeout from the current time.
This feature is unreachable at the moment because it is designed for
persistent sessions, which aren't otherwise implemented yet. The
purpose is to avoid rudely terminating an active session, but without
extending it too much.
2. Whenever possible, use integral types instead of doubles.
3. Instead of calling osrfCacheSetExpire(), call osrfCachePutObject()
directly, which does the same thing with less overhead.
4. Tinkered with white space and comments here and there.
M Open-ILS/src/c-apps/oils_auth.c
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16586
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 3 Jun 2010 19:56:53 +0000 (19:56 +0000)]
implemented a simple mechanism to allow for linking to record detail pages by ISBN. If no record ID is present in the URL and the URL has a search type of isbn and an isbn value, do an ISBN lookup and display the first record we get back from the search.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16585
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 3 Jun 2010 19:33:11 +0000 (19:33 +0000)]
org unit setting for requiring a matching email for password reset requests (no UI support yet)
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16584
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 3 Jun 2010 17:30:48 +0000 (17:30 +0000)]
display first name instead of usrname in self-check display as a security/obscurity compromise
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16583
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 3 Jun 2010 17:30:47 +0000 (17:30 +0000)]
prevent warnings that occur when the event type is not defined
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16582
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Thu, 3 Jun 2010 14:56:08 +0000 (14:56 +0000)]
documentation cut-n-pasto ... authority records are not org-scoped
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16580
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Thu, 3 Jun 2010 14:35:03 +0000 (14:35 +0000)]
add authority browsing framework to backend supercat app
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16579
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 3 Jun 2010 10:31:18 +0000 (10:31 +0000)]
templates and methods for generating payment receipts
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16578
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 3 Jun 2010 10:31:17 +0000 (10:31 +0000)]
fix some id collisions and make use of properties instead of attributes for textboxes
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16577
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 3 Jun 2010 10:31:16 +0000 (10:31 +0000)]
faster Library Settings UI and progress dialog
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16576
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 3 Jun 2010 05:28:25 +0000 (05:28 +0000)]
more due date convenience options for offline mode, courtesy of Michael Peters, Indiana State Library
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16574
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 3 Jun 2010 05:28:24 +0000 (05:28 +0000)]
util.list gets used in offline mode, so don't assume that we have fetched org unit settings
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16573
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Thu, 3 Jun 2010 04:25:51 +0000 (04:25 +0000)]
Don't hardcode our password forms to en-US
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16572
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Thu, 3 Jun 2010 04:05:39 +0000 (04:05 +0000)]
Apache2::Const::DECLINED leads to ugly error dialogues. I'm OK, you're OK.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16571
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Thu, 3 Jun 2010 03:39:16 +0000 (03:39 +0000)]
< is not >; get our time-to-live threshold comparison correct
Also add a useful log entry to differentiate this not-active-request reason from the others
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16570
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Thu, 3 Jun 2010 03:15:38 +0000 (03:15 +0000)]
Setting apache->status() caused 500 server errors for password reset requests
Don't do that.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16569
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Thu, 3 Jun 2010 02:52:10 +0000 (02:52 +0000)]
password reset URI needs a trailing slash, and this enables the aupr entry to be created, but:
* Server is now returning a 500 instead of 200, which causes an error dialogue
to be displayed instead of "success!" and JavaScript errors to cascade
* We don't want to hard-code the en-US locale; need to pull that from current locale
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16568
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Wed, 2 Jun 2010 22:46:02 +0000 (22:46 +0000)]
s/perl/javascript/
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16567
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Wed, 2 Jun 2010 22:39:16 +0000 (22:39 +0000)]
fix logic error that could result in partial list of available libs for workstation registration
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16566
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Wed, 2 Jun 2010 21:36:34 +0000 (21:36 +0000)]
Undouble these elements of password-reset that somehow doubled up during the forward-porting from rel_1_6
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16565
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Wed, 2 Jun 2010 21:34:55 +0000 (21:34 +0000)]
some defensive programming
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16564
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Wed, 2 Jun 2010 19:24:14 +0000 (19:24 +0000)]
Replace most of the serial schema with a different set of tables. Only
the serial.record_entry table remains unscathed.
In addition: a new table asset.copy_template.
M Open-ILS/src/sql/Pg/002.schema.config.sql
M Open-ILS/src/sql/Pg/040.schema.asset.sql
A Open-ILS/src/sql/Pg/upgrade/0288.schema.serial-overhaul.sql
M Open-ILS/src/sql/Pg/210.schema.serials.sql
M Open-ILS/examples/fm_IDL.xml
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16563
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Wed, 2 Jun 2010 18:46:24 +0000 (18:46 +0000)]
some more API documentation for these password reset request methods
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16562
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 2 Jun 2010 18:02:06 +0000 (18:02 +0000)]
adding more non-auto Identifier specifiers
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16560
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 2 Jun 2010 17:42:40 +0000 (17:42 +0000)]
use dojo.query instead of getElementsByTagName ... IE--
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16559
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 2 Jun 2010 15:11:52 +0000 (15:11 +0000)]
add class/instance methods for checking required-ness and validity of an object field in JS FM implementation
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16557
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 2 Jun 2010 14:55:23 +0000 (14:55 +0000)]
add class/instance methods for checking required-ness and validity of an object field in perl FM implementation; also fixing typo
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16556
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 2 Jun 2010 14:38:58 +0000 (14:38 +0000)]
get rid of search.staged_fts() and supporting functions -- entirely replaced by search.query_parser_fts(); deprecating only, no upgrade script required
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16555
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 2 Jun 2010 12:48:40 +0000 (12:48 +0000)]
made overly restrictive example validation regexp more generic -- just require at least one character, instead of all upper-case ASCII
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16554
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 2 Jun 2010 02:43:32 +0000 (02:43 +0000)]
add required IDL flag and validation regexp support
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16553
dcc99617-32d9-48b4-a31d-
7c20da2025e4
senator [Tue, 1 Jun 2010 21:04:39 +0000 (21:04 +0000)]
Make in-db hold checking consistent with circulation when it comes to
returning events with fail_part set.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16552
dcc99617-32d9-48b4-a31d-
7c20da2025e4
senator [Tue, 1 Jun 2010 20:35:21 +0000 (20:35 +0000)]
Move credit card processing ML code into the circ module, removing API method
for direct payment processing. (Using open-ils.circ.money.payment with auth
can invoke CC processing).
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16550
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Tue, 1 Jun 2010 19:19:08 +0000 (19:19 +0000)]
Forward port r16547 from rel_1_6_0: fix regression in date formatting for non-due dates
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16549
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Tue, 1 Jun 2010 19:02:19 +0000 (19:02 +0000)]
rid ourself of some namespace prefixes because IE is too braindead to understand them
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16546
dcc99617-32d9-48b4-a31d-
7c20da2025e4
senator [Tue, 1 Jun 2010 17:38:21 +0000 (17:38 +0000)]
Remove accidentally committed OPAC CC payment test code.
Only the changes in payment.js and selfcheck.js were supposed to be commited
in 16542. The opac changes themselves were only a rough test and aren't
seaworthy.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16545
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Tue, 1 Jun 2010 17:21:31 +0000 (17:21 +0000)]
in the SIP server plugin, don't connect and start a transaction by default with every cstore handle. only connect/begin when necessary. also, making use of new CStoreEditor::init() call for setting up the editor environment when initial load was done before the IDL was available.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16544
dcc99617-32d9-48b4-a31d-
7c20da2025e4
senator [Tue, 1 Jun 2010 16:10:36 +0000 (16:10 +0000)]
In OPAC CC payment, fall back on alert()ing events if onPaymentSubmit undef
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16543
dcc99617-32d9-48b4-a31d-
7c20da2025e4
senator [Tue, 1 Jun 2010 15:59:25 +0000 (15:59 +0000)]
Incorporate CC payment interface into OPAC fines page (rough)
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16542
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Tue, 1 Jun 2010 15:06:20 +0000 (15:06 +0000)]
Add support for GROUP BY.
M Open-ILS/include/openils/oils_buildq.h
M Open-ILS/src/c-apps/oils_storedq.c
M Open-ILS/src/c-apps/buildSQL.c
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16541
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Tue, 1 Jun 2010 14:48:11 +0000 (14:48 +0000)]
add usr_setting_type of history.hold.retention_start for setting "opt-in" date of holds retention
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16540
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Tue, 1 Jun 2010 06:14:27 +0000 (06:14 +0000)]
substream for better performance with large datasets
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16539
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Mon, 31 May 2010 19:45:26 +0000 (19:45 +0000)]
Add support for BETWEEN conditions.
M Open-ILS/src/c-apps/oils_storedq.c
M Open-ILS/src/c-apps/buildSQL.c
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16538
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Mon, 31 May 2010 03:03:03 +0000 (03:03 +0000)]
1. Add support for function calls. Note that certain functions have
peculiar calling syntax. They will require special handling as exceptions,
and are not yet supported.
2. Add a bit of sanity checking for numeric and string literal expressions.
3. Eliminate the function_id member of Expression.
M Open-ILS/include/openils/oils_buildq.h
M Open-ILS/src/c-apps/oils_storedq.c
M Open-ILS/src/c-apps/buildSQL.c
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16537
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Sun, 30 May 2010 03:50:47 +0000 (03:50 +0000)]
For various updatable views based on query.expression:
add COALESCE to the insert rule so that we don't always
have to specify a value for the "negate" column.
Also: eliminate a harmless but annoying duplication of
the create statements for the query.expr_xbind view.
M Open-ILS/src/sql/Pg/002.schema.config.sql
M Open-ILS/src/sql/Pg/008.schema.query.sql
A Open-ILS/src/sql/Pg/upgrade/0286.schema.query-coalesce-negate.sql
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16536
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Fri, 28 May 2010 21:35:04 +0000 (21:35 +0000)]
utilities for testing circ and ahr events
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16535
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Fri, 28 May 2010 21:35:04 +0000 (21:35 +0000)]
.print and .email event-firing variants of open-ils.actor.history.hold.visible and open-ils.actor.history.circ.visible
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16534
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Fri, 28 May 2010 21:35:03 +0000 (21:35 +0000)]
templates and methods for print/email of historical hold/circ lists
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16533
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 28 May 2010 19:37:32 +0000 (19:37 +0000)]
added a wait flag to create_events_for_hook() to allow for processing large sets of objects without dropping all the calls on the network at once
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16532
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Fri, 28 May 2010 16:40:39 +0000 (16:40 +0000)]
Added org_unit_setting_type auth.persistent_login_interval
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0284.data.persistent-login-interval.sql
M Open-ILS/src/sql/Pg/950.data.seed-values.sql
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16531
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 28 May 2010 15:50:23 +0000 (15:50 +0000)]
added duplicate username checking/warning
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16530
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 28 May 2010 14:19:21 +0000 (14:19 +0000)]
API calls to expose the circ/hold history stored procedures
moved circ chain summary creator code to apputils for sharing
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16529
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 28 May 2010 13:25:47 +0000 (13:25 +0000)]
repaired misnamed function oils_json_to_string -> oils_json_to_text; updated funcs to use the setting name provided by the seed data retention_start_date -> retention_start
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16528
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Fri, 28 May 2010 03:35:32 +0000 (03:35 +0000)]
Support IN lists.
M Open-ILS/src/c-apps/oils_storedq.c
M Open-ILS/src/c-apps/buildSQL.c
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16527
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Fri, 28 May 2010 01:46:29 +0000 (01:46 +0000)]
Support series expressions, i.e. a series of expressions
separated by operators or commas. This construct will
be especially useful for chains of ANDs or ORs.
M Open-ILS/include/openils/oils_buildq.h
M Open-ILS/src/c-apps/oils_storedq.c
M Open-ILS/src/c-apps/buildSQL.c
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16526
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Thu, 27 May 2010 20:16:33 +0000 (20:16 +0000)]
adding function to return holds visible to the user, based on their horizon settings; fixing logic reversal in circ version of same
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16525
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 27 May 2010 18:47:48 +0000 (18:47 +0000)]
edi_message fetching for POs is just for counting, use id_list instead of full object fetching
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16524
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Thu, 27 May 2010 18:44:22 +0000 (18:44 +0000)]
functions and settings for purging circs and user-settable circ memory horizon
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16523
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 27 May 2010 18:42:08 +0000 (18:42 +0000)]
for some added privacy, display the user's username instead of their real name in the self-check welcome banner. i18n-ified
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16522
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Thu, 27 May 2010 16:10:50 +0000 (16:10 +0000)]
Add new expression type 'xser' to represent series expressions,
i.e. a series of expressions separated by operators, such as a
chain of ANDed conditions.
M Open-ILS/src/sql/Pg/002.schema.config.sql
M Open-ILS/src/sql/Pg/008.schema.query.sql
A Open-ILS/src/sql/Pg/upgrade/0280.schema.query-xser.sql
M Open-ILS/examples/fm_IDL.xml
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16521
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 27 May 2010 16:04:46 +0000 (16:04 +0000)]
added global_flag editing UI and staff client menu entry
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16519
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 27 May 2010 16:04:44 +0000 (16:04 +0000)]
repaired bug in dojo.mixin usage for applying overrides. support for stying fields marked readOnly via override
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16518
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 27 May 2010 13:18:46 +0000 (13:18 +0000)]
added note about new direction of opt-in circ history maintenance; minor cleanup
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16517
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 27 May 2010 13:18:45 +0000 (13:18 +0000)]
added Replace Barcode option into new patron reg. interface. Also added a basic See All operation that shows all attached barcodes for a user, provides no editing capabilities
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16516
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Thu, 27 May 2010 12:38:48 +0000 (12:38 +0000)]
Bug fix in verifyObjectPCRUD().
When traversing a chain of rows according to the "jump" attribute:
if you encounter a null foreign key, just stop looking, without
issuing an exception.
M Open-ILS/src/c-apps/oils_sql.c
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16515
dcc99617-32d9-48b4-a31d-
7c20da2025e4
senator [Wed, 26 May 2010 21:29:54 +0000 (21:29 +0000)]
Minor whitespace/syntax changes, sifted out of the previous telephony commit.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16514
dcc99617-32d9-48b4-a31d-
7c20da2025e4
senator [Wed, 26 May 2010 21:26:55 +0000 (21:26 +0000)]
Foundations of Action/Triger-based telephony,
by Joe Atzberger and Lebbeous Fogle-Weekley
Just as described to the open-ils-dev mailing list on May 21, 2010, with a
whitespace/non-semantic-changes patch to follow.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16513
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Wed, 26 May 2010 20:32:51 +0000 (20:32 +0000)]
have new patron editor honor global.password_regex
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16512
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Wed, 26 May 2010 20:32:50 +0000 (20:32 +0000)]
these entities are no longer used
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16511
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Wed, 26 May 2010 19:03:25 +0000 (19:03 +0000)]
Correcting some diverging drift in the usr_merge function
M Open-ILS/src/sql/Pg/999.functions.global.sql
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0278.function.usr-merge-drift.sql
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16510
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Wed, 26 May 2010 18:57:06 +0000 (18:57 +0000)]
Adding a qualifying schema name to keep PG happy
M upgrade/0277.schema.address_schema_drift.sql
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16509
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 26 May 2010 18:07:46 +0000 (18:07 +0000)]
and, of course, the same typo /in/ the file. fixed
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16507
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 26 May 2010 18:07:04 +0000 (18:07 +0000)]
arg ... typo in filename. moved
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16506
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 26 May 2010 15:08:33 +0000 (15:08 +0000)]
after nearly 280 schema updates, we had a little drift. this addresses upgrade vs stock substantive differences
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16505
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Wed, 26 May 2010 13:27:29 +0000 (13:27 +0000)]
Bug fixes in verifyObjectPCRUD():
1. Don't throw an exception just because a foreign key is null.
2. When looking for local or foreign contexts, always do a lookup of
the current row, even if you already have an image of that row in
hand. The image you have may not include the foreign key(s) you need.
The latter fix is simple but inefficient. It should be possible to
avoid the extra lookup most of the time, and maybe all of the time,
for the search, retrieve, and id_list methods. However that will
involve additional complications, not yet implemented. Let's make
it correct first, and worry about efficiency later.
M Open-ILS/src/c-apps/oils_sql.c
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16504
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Wed, 26 May 2010 01:35:37 +0000 (01:35 +0000)]
Add actor.usr_password_reset table required for password reset functionality - missed it in 0237.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16503
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Tue, 25 May 2010 21:27:52 +0000 (21:27 +0000)]
this doesn't work. I think my environment wasn't pristine when I pushed it
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16501
dcc99617-32d9-48b4-a31d-
7c20da2025e4