Made table cells in holdings white to temporarily solve CSS display
issue in staff client.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/src/templates/opac/parts/record/copy_table.tt2

Fix to Advanced Search 'Clear Form' button not clearing
previously selected library.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

KPAC 2.7 Upgrade Tweaks

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:

Open-ILS/examples/kpac.xml

Fix to grouped search result set navigation bar display issue in OPAC.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/src/templates/opac/results.tt2

Fix for KPAC holdings display issue.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Fix for too-large header sizes causing display issues in KPAC

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Tweak to make library selector box wider in OPAC only.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

KPAC Login Redirect Fix

Fixes the redirect from the KPAC login to return back to the
home page of the KPAC from the /opac/login screen, rather
than back to the /opac/home screen, which is the current
behavior, and confuses users of the KPAC when they end
up back in the OPAC after having logged in.

Modified KPAC login code to redirect to KPAC after logging in

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:

Open-ILS/src/templates/kpac/parts/header.tt2

Correcting typo that breaks this template.

Conflicts:
Open-ILS/src/templates/opac/parts/record/summary.tt2

Change to allow KPAC to display more than one format icon (like OPAC).

Fix for KPAC multi-format items

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:

Open-ILS/src/templates/kpac/record.tt2
Open-ILS/web/css/skin/default/kpac/style.css

Further modifications in preparation for 2.7 upgrade

Conflicts:
Open-ILS/src/templates/opac/browse.tt2

Updates to adjust layout issues with new UI changes.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

2 more missing files...

OPAC UI modifications as per OPAC Working Group suggestions.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/src/templates/opac/myopac/circs.tt2
Open-ILS/src/templates/opac/myopac/holds.tt2
Open-ILS/src/templates/opac/myopac/prefs.tt2
Open-ILS/src/templates/opac/myopac/prefs_notify.tt2
Open-ILS/src/templates/opac/parts/advanced/search.tt2
Open-ILS/src/templates/opac/parts/footer.tt2
Open-ILS/src/templates/opac/parts/myopac/main_base.tt2
Open-ILS/src/templates/opac/parts/place_hold.tt2
Open-ILS/src/templates/opac/parts/record/copy_counts.tt2
Open-ILS/src/templates/opac/parts/record/extras.tt2
Open-ILS/src/templates/opac/parts/record/navigation.tt2
Open-ILS/src/templates/opac/parts/record/summary.tt2
Open-ILS/src/templates/opac/parts/result/table.tt2
Open-ILS/src/templates/opac/parts/topnav.tt2
Open-ILS/src/templates/opac/register.tt2
Open-ILS/src/templates/opac/results.tt2

replacing copy_table.tt2 with the correct version

Conflicts:
Open-ILS/src/templates/kpac/parts/copy_table.tt2

Tweaks to OPAC UI - account login page, my account holds page, text call number page

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Revert label change on item detail page from 'Related electronic
resources' to 'Electronic resources.'

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Changes to item detail page holdings:

- fixed customized holding location links
- moved shelving location after library location and before call number

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/src/templates/opac/parts/record/copy_table.tt2

Remove "Mailing Address" heading per request from Terran

Signed-off-by: Michael Peters <mpeters@emeralddata.net>

Customize the Library Details page for US format, link to Google Map

Signed-off-by: Michael Peters <mpeters@emeralddata.net>

Change 'About PINES' link location

2.7.1 Issue Tracker Wish List requested that the About PINES
link point to http://pines.georgialibraries.org/about/ which
this commit implements.:

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Conflicts:
Open-ILS/src/templates/opac/parts/footer.tt2
Open-ILS/src/templates/opac/parts/topnav_links.tt2

Add self-registration link to topnav links.

Syncing kpac.xml with rel_2_5_1_kpac

Add GALILEO for Kids link to KPAC header.

Hiding unnecessary and unpopulated Chilifresh content and NoveList "loading" message.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/src/templates/opac/parts/record/awards.tt2

PINES Customization: NoveList Added Content Attempt 2

Forced Awards & Suggested Reads tab to always be open
in order to highlight NoveList Select content.

Taking a different approach to displaying the NoveList
content upon loading.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Added Nutrition subcategory under Early Learning category in KPAC.

Added README and graphics template for use of KPAC graphics.

Conflicts:
Open-ILS/examples/kpac.xml

Corrected version of kpac.xml with properly nested preset searches

This commit removes confirmation boxes popping up when a hyperlink is clicked

In PINES, we expect the behavior we've always had, so we revert the change.

Revert "Sort of in line with 949322 but not absolutely necessary"

This reverts commit e1a7501799119e0f305616af5bf97149d9bdf4c0.

Adding fix for KPAC hold placement.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

temporary workaround for holds error when user isn't logged in and doesn't select a pickup location

Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGKPacLoader.pm

fixed problem with referencing wrong org selector

Conflicts:
Open-ILS/src/templates/kpac/getit.tt2

Attempt to fix default pickup location bug when user is not logged in.

Conflicts:
Open-ILS/src/templates/kpac/getit.tt2

Modified style guide to emphasize call numbers in search results and item display.

Temporarily hid Add to List functionality until it can be further developed.

Adding KPAC link to header and footer.

PINES KPAC landing page doesn't include the Print button.

Correcting file path for PINES logo on KPAC.

Removing "Bib Call Number" from the advanced numeric search options.

Commenting out Bib Call Number and uncommenting Call Number Browse.

Conflicts:
Open-ILS/src/templates/opac/parts/advanced/numeric.tt2

Allowing unfillable hold placement in the staff client, not the OPAC

In PINES, we do not allow patrons to override hold policies, but staff
may in certain circumstances.  This change makes the option visible in
the staff client, but not the OPAC.

Small changes to Search Limit names and Category names.

Further tweaks to search limits and modifications to book bag links.

Testing modifications to navigation.

Modifications to quick search functions and stylesheet.

Conflicts:

Open-ILS/web/css/skin/default/kpac/style.css

Image handling has changed in the new version...

Removing PINES-customized code that referred to a now-missing image.

Typo in footer.tt2 causing a server error.

Removing "kpac-original" directory in order to keep a clean source directory.

PINES customization of KPAC - beta ready for testing

Updated dewey.tt2

Initial commit of PINES KPAC customizations.

Conflicts:

Open-ILS/src/templates/kpac/home.tt2
Open-ILS/src/templates/kpac/parts/copy_table.tt2
Open-ILS/src/templates/kpac/parts/header.tt2
Open-ILS/web/css/skin/default/kpac/style.css

Conflicts:
Open-ILS/src/templates/kpac/parts/copy_table.tt2
Open-ILS/web/css/skin/default/kpac/style.css

Removing "You have permission to override some of the failed holds." OPAC message

Changing the default hold message for when an item is age protected.

PINES Survey Link - TPAC Edition

PINES does an online survey that runs for a week every Spring. These
changes create a red link to the survey above the search bar on the
OPAC home page.

Remove "Claims Never Checked Out" in Items Out summary

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

adding in gmcharlt's fix for trailing TCN spaces

Conflicts:

Open-ILS/src/perlmods/lib/OpenILS/Application/Cat/BibCommon.pm

adding new macros to listed ones

Adding GPLS Helpdesk link to Staff Client portal page and correcting a small typo

Conflicts:

Open-ILS/web/opac/locale/en-US/lang.dtd

Conflicts:
Open-ILS/xul/staff_client/server/index.xhtml

Revert "Use my_asv here.. surveys pertinent to the workstation library.. in case survey usage ever takes off.  Should probably move some of this to the middle layer"

This reverts commit 54d45c37d91c78cffa00ca3ff0f6298261d548b2.

adding file that returns circ mod view to normal

adding mrpeters' awesome favicon

adding PINES help links

Conflicts:

Open-ILS/src/templates/opac/parts/login/help.tt2

updating the username/password hints for the opac

Conflicts:

Open-ILS/src/templates/opac/parts/login/form.tt2
Open-ILS/src/templates/opac/parts/login/password_hint.tt2

improving the default hold message for range-protected items

Enabling the display of 856 field URLs for related resources

Password Length Helpers

This branch provides length helpers when patrons are setting or resetting
passwords.

This assumes the default 7 characters, 1 number requirement that comes stock.
You would need to change the hard coded strings if you use a different password
requirement regex in Library Settings Editor.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>

Remove the hardcoded width of locg dropdown

The hard coded 12em width causes longer library names to be cut
off.  This removes that restriction.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>

removing journal title and bib call number from query type selector dropdown

Conflicts:

Open-ILS/src/templates/opac/parts/qtype_selector.tt2

Conflicts:
Open-ILS/src/templates/opac/parts/qtype_selector.tt2

adding newly designed PINES logos

removing bib level advanced search filter

Conflicts:

Open-ILS/src/templates/opac/parts/config.tt2

Conflicts:
Open-ILS/src/templates/opac/parts/config.tt2

adding footer and topnav links and logo

Conflicts:

Open-ILS/src/templates/opac/parts/footer.tt2
Open-ILS/src/templates/opac/parts/topnav_logo.tt2

Conflicts:
Open-ILS/src/templates/opac/parts/footer.tt2

PINES GALILEO TPAC link and auth redirector

* adds a GALILEO link in the footer template
* adds a new TPAC URL target for /eg/opac/galileo, which redirects the
  user to the GALILEO URL, ensuring the user is first logged in.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Conflicts:
Open-ILS/src/templates/opac/parts/footer.tt2

PINES/GALILEO avoid auth redirect within library

If the physical_loc is set, indicating the patron is physically at a
branch (via IP redirect), link directly to the GALILEO site with no
authentication pass-through.  GALILEO does not requires PINES auth
if the client is coming from a known IP address.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Conflicts:
Open-ILS/src/templates/opac/parts/footer.tt2

Sadly, GALILEO/EBSCO does not use HTTPS, so this will create errors for patrons who authenticate via PINES.  Reverting to HTTP.

Bumping version numbers, adding Upgrade Script and Changelog

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Update upgrade docs for 3.2.2 release

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Bump OpenILS.pm version

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Translation updates - po files

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Translation updates - newpot

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Release notes entry for LP#1804038

Also, add a missing contributor.

Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1804038 Fix-ups for older 'clense' functions

Way back when, we switched from a misspelled 'clense_ISO8601' to a
corrected 'cleanse_ISO8601' in OpenSRF.  This function has again moved,
and is now part of OpenILS::Utils::DateTime, and is named
'clean_ISO8601'.  This was done as part of LP bug #1552778.

However, a few stragglers of the misspelling remained, so these were
missed when the big changeover occurred.  This hopefully catches them
all!

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>

Docs: Multilingual search documentation

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Release notes entry for LP#1793154

Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1793154: Cancel Holds from OPAC Record

The name of the grid handler was misspelled
in the holds grid for records in the opac.
Swapping the location of the 'wide' part of
the function name will allow it to match up
with the functions available in the holds
grid module.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Docs: documenting multiple emails in patron editor (LP1755625)

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: release notes for 3.2.2

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: adding release notes for 3.1.8

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1643709: Stamping upgrade scripts

Include placeholder 1137 for 3.1 version of the SQL function changed
vs. 1138 which contains the one for 3.2 and master and beyond.

Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1643709 User merge + purge pgtap test

Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1643709 purge users on merge instead of flag deleted

Purge merged user accounts.

Update the upgraded version of the usr_merge() db function to match
recnet changes in master.

Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP1801156: Add missing assets to 3.2 Offline mode

t_org_select was missing from the UpUp asset list,
causing offline mode to be non-functional when unable
to connect to the server.

Signed-off-by: Jason Boyer <JBoyer@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1761242 Z39.50 Marc View Usability with Mobile Repsonsiveness

This patch changes the size of the image in the Z39.50 Marc View from large to
medium.  It also incorporates bootstrap's media classes to present the Marc
record and the cover image side by side.  If there is no image the marc record
display floats to the left of the modal. From a suggestion by Jane Sandbert, it
also hides the book cover image on small devices.

To test.
1. Perform a search in z39.50.  An LOC title search for "Cat in the Hat"
   returms results of titles with and without images.
2. View some of the titles in Marc View, noting the large image.
3. Apply the patch.
4. Perform the same search and view the results in Marc View.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Janet Schrader <jschrader@cwmars.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Lp 1753813: Wrap all oils_persist:source_definitions in CDATA blocks.

For safety's sake, we add CDATA sections in all fm_ILD.xml
oils_persist:source_definition elements as show in the example at the
top of the IDL.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1764542: Fixing upgrade script numbering

Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1764542: Stamping upgrade script

Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1764542 - Update older sites to MODS 3.3

MODS 3.3 support was introduced in March 2009, but this
change was never included in an upgrade script.  Older
sites on 3.1+ will need to apply this update to avoid scary
segmentation faults, and it should be harmless for newer
sites and desirable for those on 3.0 or older.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1792621: Fix think-o in Hold Shelf Delay YAOUS test

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1792621: Ignore deleted items on hold shelf

The hold shelf rewrite brought back an old behavioral bug where items deleted
while on the hold shelf continued to show on the hold shelf list.  The most
recent behavior was to ignore those items, which this commit does.  It also
addresses an adjacent issue where holds may show with "Hold Shelf Delay"
instead of "Ready For Pickup" in some cases.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP1755625: Multiple emails in patron editor

Even though the HTML5 "email" input type allows multiple
addresses to be separated by commas there is nothing that
can be done to signal to Angular.js that this is ok; it
will only ever accept a single address. This patch forces
the type of the input tag to plain text so Angular will
rely on any supplied regex to verify the entry.

The ui.patron.edit.au.email.regex (Regex for email field on patron
registration) library setting can be used to control whether
one or multiple email addresses will be permitted on the
patron registration form.

To allow multiple addresses, that setting can be:

^(?:(?:\b[^@,\s]+@[^@,\s]+\.[^@.,\s]+\b)(?:,\s?(?!$)|$))*$

To allow only a single address, use:

^(?:\b[^@,\s]+@[^@,\s]+\.[^@.,\s]+\b)$

To test
-------
[1] In the web staff client, try to register a new patron, entering
    multiple email addresseses in the email field separated by
    commas.
[2] Note that the email field displays as invalid and the
    record cannot be saved.
[3] Apply the patch and repeat step #1, This time, the email
    field should accept multiple addresses.
[4] Set the Regex for email field on patron registration library
    setting to the multiple-email form listed above. Reload
    the patron registration form and verify that it will
    continue to accept multiple email addresses but will not
    accept entry that doesn't look like an email address.
[5] Set the library setting to the single-address value. Reload
    the patron registration form; this time it should accept
    a valid email address but not multiple ones.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Docs: LP#1578719 Update DIG Attributions page

Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1797007 Grid cell tooltips apply to all cells (Ang)

Avoid excessive browser page re-flows, caused by checking cell
widths for rendering tooltips, by rendering tooltips for all cells
regardless of the size of the content.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1797007 Grid cell tooltips apply to all cells

Avoid excessive browser page re-flows, caused by checking cell widths
for rendering tooltips, by rendering tooltips for all cells regardless
of the size of the content.

This reverts commit 1e9c0ab388a0697a1f099970240f2da21bfb5e1f.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1684202 - fix holdings grid refresh... bre_id array always be integers

For some strange reason the volcopy bchannel event data.records
would be an array of string integers or a array of ints depending
on whether you're adding or editing holdings. This addresses that
weirdness.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1684202 - fix bug the prevented automatic refresh

Turns out that Array.includes() does not do implicit type convertions
Typical javascript...

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1684202: Protect against missing features; Make feature more general

I've wrapped the BroadcastChannel code in a test derived from the auth version
of the same concept.  Also broadcasting the full set of record IDs and the
pre-update call number IDs for other interfaces that might be interested. The
channel name is also made more generic and made to follow the precedent from
the auth channel name.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>