lp1846354 add a WARNING to the release notes

about the auditor table

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

lp1846354 update auditors

fixes updating patrons and allowing them to login

one consequence of this is that old alert_messages in the auditor will be deleted

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

lp1846354 upgrade script tweaks

the main change is that we're creating SILENT_NOTE penalties for migrated
actor.usr_note's in order to preserve the creator.  I'm also removing explicit
TEMP tables in case admins do want to preserve these staging tables (by
commenting out the DROP's at the bottom of the script).

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

lp1846354 set existing user messages to public

before adding new ones; also, remove a lingering reference to alert_message in
Storage/CDBI/actor.pm

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

lp1846354 alert message wording

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

lp1846354 qa tests

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

lp1846354 release notes

Patron notes, messages, alert messages, and standing penalties have been folded
into one Notes interface.  Notes designated as public will show in the My Account
-> Message Center in the OPAC for patrons.  The underlying data structure has
also changed with all notes living in the actor.usr_message table, so certain
reports may need to be adjusted.

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

lp1846354 staff client changes

References to Message or Messages in the UI, including the button bar that
spawns the interface, will be changed to Note and Notes.

The Alert Message field in the patron editor will be removed.

The Notes interface under Other -> Notes will be removed.

The Notes (and count) indicator in the patron summary sidebar will be removed.
The note count will instead be presented as part of the Notes nav button.

The patron summary sidebar and the "stop sign page" will be modified to
retrieve and display user messages linked to standing penalties that are
flagged as staff alerting.  It will retain the same styling (i.e. red text) by
default.

The Messages interface, including the archived view, will be populated with a
combination of user messages and user penalties, which may or may not be linked
in pairs via a new foreign key on the penalties.  For messages without
associated standing penalties, the sending_lib column will be used for the
implicit filtering on org units that standing penalties get now, based on the
workstation library.  This combined view will result in new columns for the
interface.  At minimum the following columns (subject to label changes) will be
displayed by default: Title, Message, Create Date, Creator, Library, and Patron
Visible.  Columns such as Staff Alert, Org Depth, Block List, Ignore Proximity,
and Penalty Label will still be available.

The Apply Penalty / Message dialog will gain a new widget for toggling whether
or not a message is intended to be visible to the patron.  The Edit message
version of the dialog will also show when/if a patron has read and/or deleted
the message.  An entry field for the message title will be added.  The dialog
will also gain an org selector to the right of the penalty type selector, which
will default to the workstation library, and will change based on the org depth
of any standing penalty type selected in the UI (either via the
Note/Alert/Block buttons or the penalty menu).  This will be passed as the
org_unit field for a penalty instead of the workstation library and org depth
that is implicitly used today  The sending_lib field for the user message will
always be set to the workstation library.

The Archive Penalty / Message action will be modified to work with both
penalties and user messages depending on what it is selected.  If an archived
penalty has a linked user message, then both will have their archive fields
set.  An archived user message may still be otherwise visible to the patron if
it is not marked as deleted or staff only.

The Remove Penalty / Message action will behave as normal for a selected
penalty.  For a user message, linked or unlinked, the message will be flagged
as deleted and, even if public, will no longer show up in the patron's Message
Center.

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

lp1846354 OPAC changes

Surface the edit date for patron visible notes in the Message Center.

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

lp1846354 middle layer changes

The ApplyPatronPenalty A/T Reactor will be modified to create a user message if
needed instead of setting the note field on the created penalty, and will set
the new usr_message field accordingly.

The API method open-ils.actor.user.penalty.note.update will be similarly
adjusted, though it may edit or create a user message as needed.

The API method open-ils.actor.user.penalty.apply will also be modified to
create user messages in lieu of setting a note field.  The sending_lib field
for such messages will be set to match the session's workstation library,
regardless of the org unit that actually gets applied to the penalty's org_unit
field.  The org_unit field will use the value as passed by the caller, and no
longer do the org_unit_ancestor_at_depth adjustment that happens today.

Both penalty.note.update and penalty.apply will set the editor and edit date
columns on any linked user messages to the current time and staff member for
any already existing message that has its title or message value modified.  The
read_date column will also be NULL'ed in such circumstances so that the message
will appear unread to the patron if public.

The react sub in Event.pm will be tweaked to explicitly set the pub field on
created user messages to true for Action/Trigger.

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

lp1846354 changes to IDL, DB, and upgrade script

A new view actor.usr_message_penalty and associated IDL entry will be created
for use with populating the staff Messages interface.  It will perform a full
outer join between penalties and user messages.

The default IDL permissions for user messages will remain VIEW_USER and
UPDATE_USER.

The view that populates the Message Center will be changed slightly to ensure
that staff-only messages are never retrieved for patrons.  The Date column in
the grid/list view will show the edit_date value if populated in lieu of the
create_date value.  The message view will explicitly show an Edit Date label and
value below the Date row if set.

The actor.usr_message table will gain a new boolean column called pub, which
will default to false.

The actor.usr_message table will also gain a stop_date column for handling
archival as with standing penalties.

The actor.usr_message table will also gain editor and edit_date columns.

The actor.usr_message_limited view will be changed to only include rows where
pub is true.

As part of the upgrade script, Patron alert messages will be migrated as
ALERT_NOTE penalties and linked User Messages.  A database assertion will ensure
that this has happened prior to the removal of the alert_message field from the
actor.usr table.  The field will also be removed from the corresponding IDL
entry.  The sending_lib column for these user messages and the org unit field
for these penalties will be set to the top org from the org hierarchy.

Also, non-public entries in the actor.usr_note table will be migrated as
non-public User Messages. Subject to a database assertion that this has
happened, the table actor.usr_note and the actor.convert_usr_note_to_message
trigger will be removed.  The corresponding IDL entry will also be removed.  The
sending_lib column for these user messages will be set to the top org from the
org hierarchy.

Also, rows from actor.org_unit_setting for
ui.staff.require_initials.patron_info_notes will be migrated to
ui.staff.require_initials.patron_standing_penalty.  Collisions will be recorded
in a text file but otherwise dropped.  The row in config.org_unit_setting_type
for ui.staff.require_initials.patron_info_notes will then be removed.  The label
and description for ui.staff.require_initials.patron_standing_penalty in
config.org_unit_setting_type will be edited to reflect the Notes/Penalties
labeling from the UI.

The actor.usr_standing_penalty table and associated IDL entry will gain a
foreign key column linking to actor.usr_message called usr_message, and the note
column itself will be migrated to User Messages.  The usr_message field on the
penalties will be updated accordingly.  Subject to a database assertion that
this has happened, the note field on the actor.usr_standing_penalty table will
be removed.  The corresponding IDL entry will also be removed.  The sending_lib
column for these user messages will be set to match the org_unit column from
their associated penalties.

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

lp1859502 fix A/T ApplyPatronPenalty reactor

To test this, you could create the following A/T definition:

    Owning Library: CONS
    Name: test lp1859502
    Hook: penalty.PATRON_EXCEEDS_FINES
    Enabled: True
    Processing Delay: 00:00:00
    Processing Group Context Field: usr
    Reactor: ApplyPatronPenalty
    Validator: NOOP_TRUE
    Max Event Validity Delay: 1 day
    Template: test message

with environment:

    Field Path: usr
    Label: user

    Field Path: usr.home_ou
    Label: context_org

with event params:

    Parameter Name: standing_penalty
    Parameter Value: ALERT_NOTE

Then bill a test patron for $100 and run something like:

/openils/bin/action_trigger_runner.pl --osrf-config /openils/conf/opensrf_core.xml --run-pending

Without the patch, you'll get something like this in osrfsys.log:

ApplyPatronPenalty: missing parameters

And no ALERT_NOTE penalty.  With the patch you should see a "test message" alert note
when reloading the patron.

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>

LP#1851413: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1851413: Restore assumed order of full_path

Some code, including UI rendering code in the reporting interfaces,
assumes that the order of the full_path stored procedure will be the
same as for the ancestors and descendants procedures, which is tree
order from top to bottom. However, because the full_path procedure
simply UNIONs the other two together without an explicit ORDER BY,
that may not be -- and for org hierarchies that have been modified
heavily, often is not -- the case in practice. This is due to
internals of query planning in Postgres.

The easiest place to see this issues is in the report interface.
Select a template folder that is not currently shared, choose Manage
Folder, select Share Folder, click Go, and see the dropdown of options.
Under some circumstances, the list of org units in the dropdown there
are incorrectly ordered (should be from top of the tree down), and some
that should be available are disabled.

This commit uses the org unit type depth to order the output as assumed.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1879335: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1879335 Tweak bib-list sorting continued

Teach the bib-list component to honor the sort specification when
fetching its records.  In cases where IDs are sorted externally (via
bibIdSource), this ensures the records retrieved from those IDs are
also similarly sorted.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1879335: (follow-up) improve extraction of thesaurus

Use the stored procedure authority.extract_thesaurus(), which knows
how to grab the thesaurus from the 040 when necessary.

This also renames the "Thesaurus" column in the display grid to
"Thesaurus (Short Code)", which corresponds to the 008 thesarus
position, and "Thesaurus Code" to "Thesaurus"

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1879335: (follow-up) tweak sorting of bib list

Make sorting the list by bib ID work, but also disable sorting
by title and author since that's not supported without surgery on
the grid data source.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1879335 Retrieve linked bibs on demand

Avoid populating any lists of all linked bib IDs for an authority
record, since these lists can be very large.  Instead, report the linked
record count to the browse UI and teach the linked bibs UI to retrieve
paged linked bib data on demand.

Modifies the "abl" IDL class to be accessible via pcrud.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1879335 Disable authority link buttons for auth recs

In the Angular MARC editor, avoid showing the 'Create authority link'
buttons when editing authority records.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1879335 Manage authorities hide owner/source cols

These fields are generally unused, but may be in the future, so hide
them by default.

Additionally, teach the grid to show the org unit shortname instead of
the org ID when the owner column is visible.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1879335 Manage Authorities Angular Port

Migrates the Manage Authorities interface from Dojo to Angular.  In
addition to the existing functionality, the UI contains additional
authority record data and it's now possible to jump to a list of linked
bib records.

Includes release notes.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Antora follow-up: update references to eg-antora.git

[1] This repository currently can be cloned only over the Git
    protocol, so adjust URIs accordingly.
[2] Ensure that git://git.evergreen-ils.org/eg-antora.git is the
    default Antora UI repo for generate_docs.pl

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Antora Docs Supplement

Update the Antora build procedure to no longer rely on ansible and
automatically build the search-enabled version of the documentation.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1857150: stamp schema update

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>

LP#1857150: adjust routing and single vs. double-click actions

This patch adjusts the routing to use a custom matcher so that
the base AcqProviderComponent doesn't get reinitalized unecessarily
when moving from the search form to a provider record and back. It
also ensures that when starting from the search form, single-clicking
a result won't hide the search form, while double-clicking will.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>

LP#1857150: add release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>

LP#1857150: Angular provider search and management interface

The interfaces for searching for and managing acquisitions provider
records have been rewritten in Angular. This rewrite includes the
following significant changes:

* The provider search interface is now available directly from the
  Acquisitions menu, supplementing its longstanding availability from
  the Acquisitions Administration page.
* The search interface is modeled after the patron interface, including
  a search form that can be hidden or displayed, a provider summary box,
  and a multi-tabbed interface for managing the provider itself.
* The grid displaying search results is filterable and sortable.
* The provider display tabs are
 ** Details, allowing the user to view, and if permitted, edit
    the base provider record.
 ** Addresses
 ** Contacts
 ** Attribute Definitions
 ** Holdings Definitions
 ** EDI
 ** Invoices, providing an interface for viewing the invoices
    associated with the provider.
 ** POs, providing an interface for viewing the purchase orders
    associated with the provider.
* The new interface makes it possible to edit contact addresses.
* The base provider record now has an optional primary contact field.
  Selecting a contact as the primary one is managed on the Contacts
  tab.  The primary contact, if set, is displayed on the provider
  summary box.

Interfaces that used to link to the Dojo provider interface now link
to the Angular one instead.

This patch also includes a mechanism for stopping navigation away
from a dirty provider or holdings tag form unless the user expressly
confirms that they want to abandon the unsaved changes.

This patch includes contributions by Mike Rylander and Jason Etheridge.

Sponsored-by: Evergreen Community Development Initiative
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>

LP#1857150: add workstation settings for new grids

Sponsored-by: Evergreen Community Development Initiative
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>

LP#1857150: various schema and IDL changes

* Add a primary_contact column to acq.provider. The primary contact,
  when set, signifies the primary point of contact in case a provider
  has multiple contacts. This is displayed on the summary pane in
  the Angular interface.

* Mark various non-NULL fields as required so that the record editor,
  can require them in turn:

  - acqpro.name
  - acqpro.owner
  - acqpro.currency_type
  - acqpro.code
  - acqpa.city
  - acqpa.country
  - acqpa.post_code
  - acqpa.state
  - acqpa.street1
  - acqpc.provider
  - acqpc.name
  - acqpca.city
  - acqpca.country
  - acqpca.post_code
  - acqpca.state
  - acqpca.street
  - acqlipad.code
  - acqlipad.description
  - acqlipad.xpath
  - acqlipad.provider
  - acqphsm.provider
  - acqphsm.name
  - acqphsm.subfield
  - acqedi.label
  - acqedi.host
  - acqedi.owner
  - acqedi.provider
  - acqedi.use_attrs

* Make acqpro.name not be translatable. This appears to have just
  been a case of copy-and-pastitis, as providers don't seem to
  vary their names by locale.

* Add various virtual fields to support more fleshing:

  - acqpro.contacts
  - acqpro.holdings_subfields
  - acqpro.attributes
  - acqpro.edi_accounts
  - acqpc.addresses

This patch includes contributions by Mike Rylander.

Sponsored-by: Evergreen Community Development Initiative
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>

LP#1857150: org-family-select: have ngModel changes update the control

Sponsored-by: Evergreen Community Development Initiative
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>

LP#1857150: eg-fm-record-editor: support field-level help popovers

Add a new helpText field option to supply text for help popovers
that display next to the field label.

Example usage:

<eg-string #hostHelpStr text="EDI FTP or SCP server, including protocol. For example, ftp://ftp.example.org." i18n-text></eg-string>

<eg-fm-record-editor #editDialog
  idlClass="acqedi"
  [fieldOptions]="{
                    host: {helpText: hostHelpStr},
                  }"
</eg-fm-record-editor>

Sponsored-by: Evergreen Community Development Initiative
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>

LP#1857150: eg-fm-record-editor: handle unavailable linked values

In some cases, a record editor might be handed a base object
that has a linked column whose values cannot be retrieved
because the user has permission to fetch the base object
but not the linked objects. This patch makes the record editor
more resilient in the face of that situation.

Sponsored-by: Evergreen Community Development Initiative
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>

LP#1857150: eg-fm-record-editor: add isDirty() method

This adds an isDirty() method to the form that components embedding
an eg-fm-record-editor can use to check whether the form is
currently dirty.

NOTE: not all of the custom components that can show up on
      an fm-edit form currently implement component-level
      dirty checks.

Sponsored-by: Evergreen Community Development Initiative
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>

LP#1857150: eg-fm-record-editor: add remainOpenOnError option

Give eg-fm-record-editor an option controlled by the boolean
remainOpenOnError attribute to, when used as a dialog, keep
the dialog open if an error is encountered upon saving the
record.

Sponsored-by: Evergreen Community Development Initiative
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>

LP1835736: Rearrange seed data

If a search_format and icon_format are defined before the DO blocks
around line 9200 at least the icon_format definition must exist
before the DO blocks are executed.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>

LP#1835736: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1835736: add stock icon and search formats for preloaded audio

Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1860703: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1860703: Adding release notes for A/T HTTP reactor

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1860703: Additional A/T hooks for use with various patron changes

This commit normalizes the au.update/au.updated and au.create/au.created
hooks, making them match between code and seed data, and adds two
entirely new hooks, au.renewed and au.barcode_changed.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Troy Leonard <leonardt@aadl.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1860703: Create A/T hook and reactor for push integration

There is currently no stock mechanism for pushing information out of Evergreen
to trigger activities in external systems.  Third party discovery systems,
among other external systems, would benefit from the ability to be alerted of
changes to data within an Evergreen instance.

This commit adds such a capability by supplying a new A/T reactor module that
can make HTTP requests that supply data to a third party endpoint.

To support the discovery system use case, this commit also adds a new A/T hook,
bre.edit, fired whenever a bibliographic record is modified due to staff
interaction.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Troy Leonard <leonardt@aadl.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: add release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: update references to docs-antora

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: tweak the Antora site.yml

- point to docs/
- default to the current checkout when building docs

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: tweaks to generate_docs.pl

- make executable
- adjust so that it doesn't need root privileges
  to install in the system Node module directory
- let Gulp be installed in the temporary scratch
  directory

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: update the README symlink

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: ... and swap in the Antora docs

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: remove old docs...

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: synchronize installation instructions document

This will avoid regressions on the following documentation bugs:

LP#1849208
LP#1845693
LP#1849506

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: move a couple top-level docs to TechRef so they don't get lost

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: Docs: fixed antora docs for heading syntax

Found some leftover files missing their heading upgrades.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: Docs: Corrected page headings

Included script that helped find them

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: Add doc site generator generate_docs.pl

Also update the README to document the new steps to create the Antora
site.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: Docs: lunr - delete header-content.hbs

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: Docs: refreshed antora lunr search component from upstream

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: Upgraded headers in admin module

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: Fixed a word wrap issue with many of our nav.adocs

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: Corrected a couple of things in cataloging

Moved the physical character wizard into MARC_Editor and updated nav

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: Docs: Attempt an Acq topic manual

This is a first draft at structuring a topic manual in Antora (mostly
reusing files from the main "docs" component).

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: fix various sections

For Serials:

  - Add chapter labels to nav file items
  - (Not needed for this section.) Combine adoc files so that each
    "chapter" from the old docs structure has a single file linked from
    the nav
  - Upgrade all heading levels in each adoc file so that the top-most
    heading is a "Level 1" heading (example: "= Chapter Name =")
  - Add ":toc:" below top heading of each file

For Circulation:

  - Add chapter labels to nav file items
  - To match existing docs "chapter" level headings, combine adoc files as
    needed so that each "chapter" from the old docs structure has a single
    file linked from the nav
      - Added advanced_holds.adoc to the end of basic_holds.adoc
  - Upgrade all heading levels in each adoc file so that the top-most
    heading is a "Level 1" heading (example: "= Chapter Name =")
  - Add ":toc:" below top heading of each file

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: Docs: Fix sections for Antora: "reports"

* Added :toc: for each page
* Upgraded all headings in each page
* Updated nav to display the English name for each page
* fixed Intro page

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: Docs: section fixes

For "System Configuration and Customization":

  - Add chapter labels to nav file items
  - To match existing docs "chapter" level headings, combine adoc files as
    needed so that each "chapter" from the old docs structure has a single
    file linked from the nav
  - Upgrade all heading levels in each adoc file so that the top-most
    heading is a "Level 1" heading (example: "= Chapter Name =")
  - Add ":toc:" below top heading of each file

For 'Using the Public Access Catalog'":

  - Add chapter labels to nav file items
  - To match existing docs "chapter" level headings, combine adoc files as
    needed so that each "chapter" from the old docs structure has a single
    file linked from the nav
      - In this case, the only change was in advanced_features.adoc,
        where two sections had the top heading level (seems like a mistake).
        I bumped the second one down ("Binary MARC21 Feeds") so it is a
        subsection of the file. Ironically, since this commit also bumps
        up all headings by one level, it means that heading is the only one
        not changed in this commit.
  - Upgrade all heading levels in each adoc file so that the top-most
    heading is a "Level 1" heading (example: "= Chapter Name =")
  - Add ":toc:" below top heading of each file

For "Developer Resources" and "Getting Data from Evergreen":

  - Add chapter labels to nav file items
  - To match existing docs "chapter" level headings, combine adoc files as
    needed so that each "chapter" from the old docs structure has a single
    file linked from the nav
  - Upgrade all heading levels in each adoc file so that the top-most
    heading is a "Level 1" heading (example: "= Chapter Name =")
  - Add ":toc:" below top heading of each file

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: Docs: Fix incorrect module path in API nav

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: Docs: Move misplaced adoc file

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: Docs: Cataloging section improvements

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: various fixes

* Update acquisitions nav

  Level 2 became level 1 and Table of contents added. Two files were merged
  onto the "parent" as per the live docs layout. So it makes more sense when
  viewed via Antora

* Fix double level 0 headings end_matter.adoc
* Add MOBIUS's name and DIG individuals to the _attributes.adoc
* Changed the home page to be the introduction page

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: Docs: Adding recent docs changes to the antora version

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: various fixes

* Fix syntax broken by "heading conversion" script
* Improve antora navs, add missing attrib files
  - Remove numbering from install docs headers
  - Link top-level nav items to each section's intro file
  - Add a few missing _attributes.adoc files in pages/ subdirs
* Start converting internal links to antora format

  Links to sections in the same file only need the section ID like this:

  xref:#section_id

  But links to sections in another file need the Antora page_id also:

  xref:MODULE:PAGE.adoc#section_id

* Convert existing anchors to Antora syntax
* Convert more links to Antora syntax

Antora requires that links to sections in a different file use the xref
syntax, not the double-angle-bracket shortcut syntax. As best as I can
tell, this commit changes all the links that go to other files (not the
file that the link is in).

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: Removed the Antora UI bits in favor of the dedicated repo

Also edited the README to reflect the new build procedure.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: Docs: Add missing file from TechRef directory

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: Docs: Adjust headings where we used to use leveloffset

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: Docs: Add intro material to ROOT nav file

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: Docs: Add Index file and appendix attribs file

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: Docs: Draft of all nav files

Some files still contain 'leveloffset' commands which need to be
removed, and those previously offset files should probably have their
headings adjusted accordingly.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: Docs: Add draft nav for "Software Installation" section

Note: I don't think "leveloffset" is allowed like this here. We could
pass it to "include" as an attribute, but I'd rather us standardize our
headings in our files.

Also adjust heading levels to avoid using leveloffset

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: AsciiDoc HEADING CONVERSION

This commit changes all headings from two-line style to prefix/suffix
style. (For now, we're only doing this in the docs using Antora.) Example:

Heading 1
=========

becomes

= Heading 1 =

This conversion makes it much easier to adjust the heading levels of
several files which were previously included using the 'leveloffset'
command.

NOTE: Only the prefix is required, but we felt the suffix improves
readability of the source.

Below is the python script I used to do the conversion. It is slightly
modified from a script used by ___ here:

https://github.com/JanusGraph/janusgraph/pull/115/commits/dc67ce73c08e79fa65b30bc8280861056070c573

Here's my source:

import re
import sys

def main(argv):
    #http://asciidoctor.org/docs/asciidoc-recommended-practices/#section-titles
    patterns = [
        (re.compile('^=+$'), '='),
        (re.compile('^-+$'), '=='),
        (re.compile('^~+$'), '==='),
        (re.compile('^\^+$'), '===='),
        (re.compile('^\++$'), '====='),
    ]

    with open(argv[1], 'r') as input_file:
        prev_line = None
        curr_line = None
        for line in input_file.readlines():
            prev_line = curr_line
            curr_line = line

            if prev_line is None:
                continue

            for pattern, heading in patterns:
                if pattern.match(curr_line) and len(prev_line) == len(curr_line):
                    # remove newline so we can append suffix to heading
                    prev_line = prev_line.rstrip()
                    sys.stdout.write('%s %s %s\n' % (heading, prev_line, heading))
                    prev_line = None
                    curr_line = None
                    break

            if prev_line is not None:
                sys.stdout.write(prev_line)

        # end for
        if curr_line is not None:
            sys.stdout.write(curr_line)

    # end with

if __name__ == '__main__':
    main(sys.argv)

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: Docs: Remove Unicode Byte-Order Mark (BOM)

A few asciidoc files start with the BOM, which occasionally causes us
trouble.  For example, it interfered with our python script converting
headings from two-line style to prefix/suffix style.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: Remove "Admonitions" section and images, not used by AsciiDoctor/Antora

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: Docs: Convert normal includes to Antora "partials"

Antora treats all includes as either "partials" or "examples". This case
seems like "partials", since "examples" seems to be meant for code
snippets.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: Docs: Treat code include as an Antora "example"

This seems like a case that matches Antora's idea of an "example",
rather than a "partial".

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: various tweaks

* Renamed the supplimental_ui folder for ease of understanding
* UI Tweaks
* Fixed README.adoc for working repo
* add Next/Previous links at the bottom of the pages

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: start an "Evergreen Theme" for the Antora docs

Changed several values for css theming. Still need to figure out how to
padd the nav bar off of the right so the dropdown isn't cut off.

Also added links to stuff in the nav. Making it more useful.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: add lunr search functionality to the docs build

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: start adding Antora support to the docs

This introduces the antora directory structure stub. Started a new folder
docs-antora. The sub folder "ui" contains a dump of the Antora-provided default
UI from https://gitlab.com/antora/antora-ui-default.git

This commit also starts updating the document navigation.

This commit includes contributions by Remington Steed.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1848524: Docs: Delete unused assets

This commit attempts to delete all images from the media/ directory that
aren't used within an AsciiDoc file (via "image:" or "image::"). This
commit also doesn't touch images that are known to be used in the HTML
template (such as the Evergreen logo, PDF/ePUB icons, NOTE icons, and
callout number icons).

This list of images was generated via multiple bash commands, grepping
and diffing. It would be great for us to have a standard command for
finding these periodically.

This commit also removes all AsciiDoc files that we don't currently include
in another AsciiDoc file (via "include::"), because that means they
never appear in the generated docs (HTML, PDF, or ePUB). Some files have
been left untouched, such as everything in the TechRef/ directory. It
also further removes any images referenced by these files.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1418694 Change wording for saving to selection list

Changes label in line item table Actions menu for 'Save to Selection List' to 'Move to Selection List' to better reflect action taken.

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>

LP#1841974: Stamp Upgrade Scripts

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>

LP#1841974: Allow adjusted proximity for age-protect

When testing prospective transit distance for age-protected items at
hold placement time we currently use the direct, baseline proximity
between the item circ (or owning) lib and the pickup lib.  With this
commit, setting a new YAOUS will allow the circ library of the item to
specify that a potentially-adjusted, calculated proximity should be used
instead.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Diane Disbro <ddisbro@scenicregional.org>
Signed-off-by: Nelson Appell <nappell@washmo.gov>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>

LP#1880028 Backdate Checkins Until Logout Option

- Adds a checkbox option to store the backdate as a
  session item and only loads the backdate on the checkin
  screen (backdate ignored on the hold capture screen)
- Adjusts existing $watch to enable/disable the checkbox
  and store/remove session backdate when appropriate
- Adjusts is_backdate() to not consider null or undefined
  dates as backdates so the visible alert is accurate
- Adjusts "today" comparison to use a time of 00:00:00 so
  that when the Clear button is used and clears the time
  the Today button won't cause a backdate just because it's
  an earlier time on the same date

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: rfrasur <rfrasur@library.in.gov>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>

LP1850547 Stamping DB upgrade: Ang Acq Search

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1850547: (follow-up) add a bit of spacing between two buttons

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1850547: (follow-up) fix 'New Selection List' button

Now that it's a toolbar button rather than a grid action,
the check to see if the button should be active needed to be
adjusted.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1850547: release notes for Angular Acquisitions Search

The general test plan for the feature includes:

- verifying that results are retrieved as expected
- verifying that default searches can be saved and cleared
  and are used to populate the form.
- verifying that the run immediately checkbox works as expected
- verifying that grid result sorting and filtering works
  as expected
- verifying that links to POs, providers, catalog records,
  etc. find their correct targets

Sponsored-by: Evergreen Community Development Initiative
Sponsored-by: Georgia Public Library Service
Sponsored-by: Indiana State Library
Sponsored-by: C/W MARS
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1850547: Angular Acquistions Search

This patch adds the Angular application for acquisitions search
and links the Angular and AngularJS navbars to it.

Includes contributions by Mike Rylander and Jason Etheridge.

I would like to also specifically acknowledge feedback from
Bill Erickson and Mike Risher on this patch series.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1850547: Angular Acq Search: Perl API changes

This patch makes a variety of changes to methods used by
acquisitions search and retrieval. The overall intention of this
patch is to not change functionality used by the old Dojo
search interface but to add support for new functionality for
the Angular search form.

Specific changes include:

open-ils.acq.*.unified_search
-----------------------------
* Add __age (interval), __starts, __ends, __gt, and __lt operators.

Update __between to support __castdate modifier, for a more natural
comparison of dates entered by humans to timestamps stored in the
database.

* fix sorting by line item attributes

* add support for __gte, __gt, __lte, and __lt for acqlia searches

* add permissions checks for retrieving POs and invoices via
  unified_search

* improvements to server-side sorting of search results

- create joins for aou, acqim, and acqipm as needed
- look up identity column for a class rather than assuming
  that it's always 'id'

* allow searching on an explicit null value

This adjusts the special logic introduced in LP#1031535 so
that explicitly searching with a field set to not null (e.g.,
when using the Angular grid 'exists' filter) will work.

* add __isnotnull as an acq search field modifier

* allow __fuzzy to override au_by_id in unified search

* Sort by remote selector column when sort-on-link is requested and
  selector exists

* Add additional fleshing for purchase order, selection lists,
  and invoice searches.

* Add au_by_id option

This specifies performing queries on au-linked fields by
ID rather than adding joins to query the fields by user
barcode or username, etc.

* Implement "contains" operator for searches on provider
  fields.

This is similar to how user searches are handled.

Other methods
-------------
* teach open-ils.acq.lineitem.retrieve more fleshing

In particular, teach it how to flesh the LI provider, Vandelay queue,
creator, editor, selector, and claim policy so that Angular LI search
can display them without having to make additional server requests.

* clarify open-ils.acq.picklist.clone

Method is now clear that _nothing_ of the acq.picklist row
itself gets copied over.

This patch contains work by Mike Rylander, Galen Charlton, and Jason
Etheridge.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1850547: add views for PO and LI state labels

This patch adds two new views, acq.po_state_label and
acq.li_state_label, to map from the state codes to human-friendly
labels in a way that allows the labels to be retrieved and
translated.

This patch also changes the fieldmapper label of the PO
and LI state column from "State" to "Status".

This patch includes contributions by Mike Rylander.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1862022: add more permissions to stock Acquisitions and Acq Admin profiles

This patch makes the stock Acquisitions and Acquisitions Administrator
profiles better able to use the acquisitions modules out of the box.

The permissions added are:

Acquisitions Administrator Profile
-----------------------------------------
VIEW_FUND
VIEW_FUNDING_SOURCE
VIEW_FUND_ALLOCATION
VIEW_PICKLIST
VIEW_PROVIDER
VIEW_PURCHASE_ORDER
VIEW_INVOICE
CREATE_PICKLIST
ACQ_ADD_LINEITEM_IDENTIFIER
ACQ_SET_LINEITEM_IDENTIFIER
MANAGE_FUND
CREATE_INVOICE
CREATE_PURCHASE_ORDER
IMPORT_ACQ_LINEITEM_BIB_RECORD
IMPORT_ACQ_LINEITEM_BIB_RECORD_UPLOAD
MANAGE_CLAIM
MANAGE_PROVIDER
MANAGE_FUNDING_SOURCE
RECEIVE_PURCHASE_ORDER
ADMIN_ACQ_LINEITEM_ALERT_TEXT
UPDATE_FUNDING_SOURCE
UPDATE_PROVIDER
VIEW_IMPORT_MATCH_SET
VIEW_MERGE_PROFILE
IMPORT_MARC

Acquisitions Profile
-----------------------------------------
ACQ_ADD_LINEITEM_IDENTIFIER
ACQ_SET_LINEITEM_IDENTIFIER
ADMIN_ACQ_FUND
ADMIN_FUND
ACQ_INVOICE-REOPEN
ADMIN_ACQ_DISTRIB_FORMULA
ADMIN_INVOICE
IMPORT_ACQ_LINEITEM_BIB_RECORD_UPLOAD
VIEW_IMPORT_MATCH_SET
VIEW_MERGE_PROFILE

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1850547: Seed data for Angular acquisitions search

* grid persistance WS settings
* retrieve-results-immediately sticky checkbox settings
* default saved searches settings

Sponsored-by: Evergreen Community Development Initiative
Sponsored-by: Georgia Public Library Service
Sponsored-by: Indiana State Library
Sponsored-by: C/W MARS
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1850547: eg-date-select: let blur trigger emitting changes

(Otherwise, you have to select the calendar button or hit
 return inisde the input)

Sponsored-by: Evergreen Community Development Initiative
Sponsored-by: Georgia Public Library Service
Sponsored-by: Indiana State Library
Sponsored-by: C/W MARS
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>