Evergreen.git
15 years agomake sure we change the juvenile flag on the patron object when we automatically...
phasefx [Fri, 8 Oct 2010 15:46:57 +0000 (15:46 +0000)]
make sure we change the juvenile flag on the patron object when we automatically change the juvenile checkbox in the UI

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@18242 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoAvoid scary SSL / HTTPS errors in Apache configuration
dbs [Fri, 8 Oct 2010 03:28:05 +0000 (03:28 +0000)]
Avoid scary SSL / HTTPS errors in Apache configuration

When port 443 is the last listener port, Apache generates lots
of "unknown protocol speaking not SSL to HTTPS port!?" errors in
the logs - which are scary, but harmless. Putting port 80 last
avoids those errors entirely, per http://wiki.apache.org/httpd/InternalDummyConnection

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@18237 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoprevent repeat renderings of opac sidebar (relevant subjects, authors, etc.) in Firef...
phasefx [Mon, 4 Oct 2010 17:31:45 +0000 (17:31 +0000)]
prevent repeat renderings of opac sidebar (relevant subjects, authors, etc.) in Firefox.  What's happening is that the rresultHandleMods is not firing immediately with each record retrieve, and so we get a flurry at the end where resultPageIsDone() returns true for all of them, triggering the allRecordsReceived event more than once.  So now at the end of the first allRecordsReceived event chain, we set a global variable, and have these render functions check to see if it has been set.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@18156 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoimprove hold targetting
gmc [Fri, 24 Sep 2010 18:57:06 +0000 (18:57 +0000)]
improve hold targetting

* all potential capturable copies are now checked (up to the first
  one that is permitted for the request), instead of a small random
  subset of them
* don't do redundant permission checks

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@17969 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agomerge r17958 from trunk for patron display juvenile CSS
phasefx [Fri, 24 Sep 2010 18:07:10 +0000 (18:07 +0000)]
merge r17958 from trunk for patron display juvenile CSS

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@17962 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoPatch from Steve Callendar, via James Fournie, via launchpad:
miker [Thu, 23 Sep 2010 15:30:43 +0000 (15:30 +0000)]
Patch from Steve Callendar, via James Fournie, via launchpad:

When the patron.password.use_phone is set, new patrons are created with their password set to the last 4 digits of their phone number, HOWEVER, when a patron's password is reset, it does not work properly. Although the little underlined summary shows the proper 4 digits, the password box displays 9-ish digits, and is not the last 4 digits of the password.

The attached patch was created by Steve Callender and is confirmed working on 1.6.0

This patch will not work on 2.0 as that has a new user editor, but it would presumably be worthwhile to verify this functionality works in that editor as well.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@17919 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoUpdate version stamp for Evergreen service, adopting branch convention from trunk
dbs [Fri, 10 Sep 2010 14:49:06 +0000 (14:49 +0000)]
Update version stamp for Evergreen service, adopting branch convention from trunk

http://hostname/gateway?service=open-ils.actor&method=opensrf.open-ils.system.ils_version
was returning "1-5" for a number of systems we checked; in trunk, we have adopted the
"x-y" convention for branches, so in the 1.6 branches we will follow the "x-y-z"
approach for a little more clarity.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@17570 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agofixes a bug when purging offline transactions after an Export
phasefx [Tue, 31 Aug 2010 17:14:55 +0000 (17:14 +0000)]
fixes a bug when purging offline transactions after an Export

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@17412 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years ago1-line fix for false 404 from sylvar
atz [Tue, 24 Aug 2010 15:40:02 +0000 (15:40 +0000)]
1-line fix for false 404 from sylvar

solves "The requested URL /xul/rel_1_6_0_7/server/patron/ue.xhtml&clone=112879 was not found on this server."

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@17325 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agobackport of r17299: we need an index on LOWER(barcode) with r17018
miker [Sat, 21 Aug 2010 18:08:42 +0000 (18:08 +0000)]
backport of r17299: we need an index on LOWER(barcode) with r17018

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@17302 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoBackport of 17243: so, some datasets have records with multiple 245a subfields. yeah...
miker [Wed, 18 Aug 2010 16:40:33 +0000 (16:40 +0000)]
Backport of 17243: so, some datasets have records with multiple 245a subfields. yeah, really.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@17247 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoAnd get that closing brace back in place for the Dojo user editor
dbs [Thu, 12 Aug 2010 18:33:51 +0000 (18:33 +0000)]
And get that closing brace back in place for the Dojo user editor

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@17198 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoShow the "Active?" checkbox as part of the required (minimal) set of fields
dbs [Thu, 12 Aug 2010 18:22:12 +0000 (18:22 +0000)]
Show the "Active?" checkbox as part of the required (minimal) set of fields

As we're registering users, it's probably a good idea to ensure that staff
can set the user to active at the same time that they enter the minimal
patron information.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@17195 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoEnable "Delete address" button to work in rel_1_6
dbs [Thu, 12 Aug 2010 17:50:56 +0000 (17:50 +0000)]
Enable "Delete address" button to work in rel_1_6

In some ways the inverse of r17023, the else clause that enabled
the delete button to be enabled was never being reached because
the preceding clauses caught all cases.

Moving it outside of the foreach() loop entirely seems to resolve the problem.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@17192 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoRemove broken old JavaScript in Google Book preview code
dbs [Thu, 12 Aug 2010 07:46:01 +0000 (07:46 +0000)]
Remove broken old JavaScript in Google Book preview code

I /think/ this was supposed to change the title of the "Preview" link to
"Read this online" or the like in the case that the full text is available,
but it was relying on a function that didn't exist (setText) and trying
to reference an ID that didn't exists. So it broke in those rare cases
where Google Books did provide the full text.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@17184 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agobug 592777: allow authoritative version of open-ils.circ.retrieve
gmc [Tue, 10 Aug 2010 21:22:44 +0000 (21:22 +0000)]
bug 592777: allow authoritative version of open-ils.circ.retrieve

Part of a fix to avoid race condition that can occur
when patron renews an item in the OPAC in a database
that uses pgpool and replication, which sometimes
results in an erroneous 'action_circulation_not_found' error.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@17164 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoremove extra DB upgrade script
gmc [Tue, 10 Aug 2010 18:29:07 +0000 (18:29 +0000)]
remove extra DB upgrade script

Thought better of including it in the backport to rel_1_6_0

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@17156 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agofix age protection proximity test for in-DB circ
gmc [Tue, 10 Aug 2010 18:27:51 +0000 (18:27 +0000)]
fix age protection proximity test for in-DB circ

Patch from John Craig.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@17155 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoPatch from Ben Ostrowsky <ben@esilibrary.com> to specify "staff account" in proxied...
dbs [Mon, 9 Aug 2010 13:15:56 +0000 (13:15 +0000)]
Patch from Ben Ostrowsky <ben@esilibrary.com> to specify "staff account" in proxied pages

This change will make it a bit more clear that we're not looking for a
patron barcode/PIN in the Selfcheck Login screen (and make the wording
consistent across similar login pages).

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@17134 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agobug 532217: work around caching issue resulting doubled title display
gmc [Fri, 6 Aug 2010 20:35:57 +0000 (20:35 +0000)]
bug 532217: work around caching issue resulting doubled title display

Quick hack shamelessly borrowed from Dan Scott to fix problem
of title being displayed twice on bib details page when back
button is used in OPAC or staff client.

This is a temporary fix in lieu of rewriting the bib details
display to use BibTemplate exclusively.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@17123 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agobackporting changeset 16688 for more robust printing (addresses some "inner print_tre...
phasefx [Fri, 6 Aug 2010 17:53:33 +0000 (17:53 +0000)]
backporting changeset 16688 for more robust printing (addresses some "inner print_tree" errors).  See https://bugs.launchpad.net/evergreen/+bug/567505/

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@17119 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agobug 614150: bail out on ACTOR_USER_NOT_FOUND
gmc [Fri, 6 Aug 2010 01:22:56 +0000 (01:22 +0000)]
bug 614150: bail out on ACTOR_USER_NOT_FOUND

This fixes a bug where uploading an offline checkout
that refers to a missing patron returns an INTERNAL_SERVER_ERROR
instead of ACTOR_USER_NOT_FOUND.  More generally, this avoids
an exception in case case where a circ operation is made
without checking the existence of the patron record beforehand.

mk_env could use a better name, too.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@17116 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agobug 614132: fix glitch when used cached permission group widget
gmc [Fri, 6 Aug 2010 00:56:48 +0000 (00:56 +0000)]
bug 614132: fix glitch when used cached permission group widget

Fixes bug where the initial permission group value in a circ or
hold matrix entry was not displayed when editing an
existing matchpoint.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@17112 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoPatch from Bill Erickson backporting various autogrid fixes
gmc [Fri, 6 Aug 2010 00:54:52 +0000 (00:54 +0000)]
Patch from Bill Erickson backporting various autogrid fixes

* includes autogrid caching and paging
* purpose is to more gracefully handle large circ and
  hold policy matrixes in the 1.6.0.x branch

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@17109 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agobug 613703: normalize backdate on item checkin better
gmc [Thu, 5 Aug 2010 02:58:58 +0000 (02:58 +0000)]
bug 613703: normalize backdate on item checkin better

Fixes bug that appears to cause all checkins uploaded
via offline circ to fail with an "invalid date format"
error.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@17085 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoinclude null fields, via .toStoreItem(), when creating a permission map store item
miker [Fri, 23 Jul 2010 17:19:18 +0000 (17:19 +0000)]
include null fields, via .toStoreItem(), when creating a permission map store item

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@17024 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agobug #608937: make barcode search from main patron search form case-insensitive
gmc [Thu, 22 Jul 2010 21:48:24 +0000 (21:48 +0000)]
bug #608937: make barcode search from main patron search form case-insensitive

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@17020 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agobackport of r17007: retain the indicators on located uri 856 merge during asset merge
miker [Thu, 22 Jul 2010 01:06:59 +0000 (01:06 +0000)]
backport of r17007: retain the indicators on located uri 856 merge during asset merge

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@17011 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoindex which /greatly/ speeds collection of pending active events
miker [Wed, 21 Jul 2010 15:39:06 +0000 (15:39 +0000)]
index which /greatly/ speeds collection of pending active events

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16998 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoBackport of r16987: Patch from John Craig providing a saner timestamp cleansing setup...
miker [Tue, 20 Jul 2010 19:58:48 +0000 (19:58 +0000)]
Backport of r16987: Patch from John Craig providing a saner timestamp cleansing setup for backdated circs, 1.6 edition

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16989 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agobackporting r16982: use the correct table and field, caught by Doug Kyle and reported...
miker [Tue, 20 Jul 2010 15:53:23 +0000 (15:53 +0000)]
backporting r16982: use the correct table and field, caught by Doug Kyle and reported via IRC

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16983 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoback-porting action trigger fixes 16953
erickson [Fri, 16 Jul 2010 14:53:02 +0000 (14:53 +0000)]
back-porting action trigger fixes 16953

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16961 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agocomplete backporting fun for conify started around 1.6.0.4
miker [Thu, 15 Jul 2010 20:17:20 +0000 (20:17 +0000)]
complete backporting fun for conify started around 1.6.0.4

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16944 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoPatch from James Fournie to address backdating timestamp format error
miker [Fri, 9 Jul 2010 16:41:11 +0000 (16:41 +0000)]
Patch from James Fournie to address backdating timestamp format error

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16901 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoadd missing event definition required by vandelay authority import
miker [Wed, 7 Jul 2010 17:12:04 +0000 (17:12 +0000)]
add missing event definition required by vandelay authority import

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16867 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agobackport r16838 from trunk
gmc [Thu, 1 Jul 2010 02:28:55 +0000 (02:28 +0000)]
backport r16838 from trunk

bug #600021: fix lookup of FIFO holds OU setting

Patch from Anoop Atre that fixes enabling FIFO
holds via the circ.holds_fifo org unit setting.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16840 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoBackport security fix r16747 from trunk
dbs [Fri, 18 Jun 2010 04:48:03 +0000 (04:48 +0000)]
Backport security fix r16747 from trunk

1. Disable fleshing for PCRUD.  Otherwise fleshing would provide a
back door whereby a user could see stuff he has no permission to see.

2. For the id_list method: strip out the "flesh_fields" entry, not
the "flesh_columns" entry (which doesn't exist).  This actually makes
no difference, but if we're going to do something useless, we might
as well do it right.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16749 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoremoved unused method retrieved from method_lookup. apart from being unused, the...
erickson [Mon, 14 Jun 2010 15:43:05 +0000 (15:43 +0000)]
removed unused method retrieved from method_lookup.  apart from being unused, the call was attempting to fetch a nonexistent method ('auth' vs. 'authority') and hilarity ensued

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16706 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoadded a number of info messages to the action/trigger runner and server code. the...
erickson [Fri, 11 Jun 2010 13:49:45 +0000 (13:49 +0000)]
added a number of info messages to the action/trigger runner and server code.  the messages provide summary data about what event defs / hooks are being processed and when/if they complete or timeout.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16675 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoPatch from James Fournie of SITKA:
miker [Thu, 10 Jun 2010 19:16:27 +0000 (19:16 +0000)]
Patch from James Fournie of SITKA:

There was some discussion about problems with holds fulfillment at the
holds roundtable at EG2010.  I am pleased to share this patch with the
community which has been thoroughly tested by the folks at
Thompson-Nicola Regional District Library.  (thanks guys!)

Background:

Evergreen's default out-of-the-box behaviour for holds fulfillment is
a gas-saving method.  Holds are fulfilled by proximity.  In a
multibranch library, holds are fulfilled at the local branch first.
Many libraries, particularly single branch libraries may be ok with
this, but it may be problematic for other libraries.

Imagine a scenario where you have a large central branch and a small
rural branch of the same library system.  At the large branch, there
are many copies of Popular New DVD with lots of holds.   There are no
copies at the rural branch.  Patrons at the small rural branch who
want to pick up Popular New DVD at their home branch may never get
their hold fulfilled because the copies will stay at the large branch
as long as there are holds for pickup there.

This patch adds an org unit setting that changes the opportunistic
check-in so that items checked in will be assigned to holds by request
date first, rather than proximity.   This setting can be applied to
any level of the org tree, so in some situations you may even want to
activate FIFO for large libraries, but leave the original setting for
smaller libraries with less traffic who want to keep their copies more
local.

Also credit to Jeff Godin who thought of the same patch and
contributed the setting name "holds FIFO" for the setting

[ NOTE:  Implications of mixed FIFO and non-FIFO environments that are
not sufficiently segregated by the use of Hard Boundaries for Holds
present a potenial for user confusion.  Beware that mixing FIFO and
non-FIFO settings within a resource-sharing group will likely result in
severe imbalance of hold fulfillment, though further configuration,
development, tuning and testing may be able to mitigate these issues.
 --miker ]

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16661 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoupdated report param editor to handle join types embedded in the field name. this...
erickson [Thu, 10 Jun 2010 18:49:14 +0000 (18:49 +0000)]
updated report param editor to handle join types embedded in the field name.  this bug caused sporadic failed rendering of the report editor params widgets

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16657 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoback-porting: protect against empty results from bib searches caused by search timeou...
erickson [Tue, 8 Jun 2010 19:14:27 +0000 (19:14 +0000)]
back-porting: protect against empty results from bib searches caused by search timeouts.  This allows the API call to log the error and return reasonable results

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16627 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoBackport r16558 from rel_1_6: Avoid schema creation failure by ensuring metabib exist...
dbs [Wed, 2 Jun 2010 18:28:26 +0000 (18:28 +0000)]
Backport r16558 from rel_1_6: Avoid schema creation failure by ensuring metabib exists before referencing rule is created

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16561 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoFix regression in date formatting for purposes other than due dates
dbs [Tue, 1 Jun 2010 19:05:07 +0000 (19:05 +0000)]
Fix regression in date formatting for purposes other than due dates

Thanks to #atheos in IRC for pointing out this problem

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16547 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoPatch from Bill Ott to add missing apostrophe in rdetail.js
erickson [Tue, 25 May 2010 20:52:55 +0000 (20:52 +0000)]
Patch from Bill Ott to add missing apostrophe in rdetail.js

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16499 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoPatch from Dan Wells to fix the bookbag menu not showing up in Craftsman.
miker [Fri, 21 May 2010 16:51:59 +0000 (16:51 +0000)]
Patch from Dan Wells to fix the bookbag menu not showing up in Craftsman.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16476 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoadjust upgrade script in case there is ever a 1.6.0.5Open-ILS/src/sql/Pg/1.6.0.4...
miker [Sun, 16 May 2010 19:09:44 +0000 (19:09 +0000)]
adjust upgrade script in case there is ever a 1.6.0.5Open-ILS/src/sql/Pg/1.6.0.4-1.6.0.5-upgrade-db.sql

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16436 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agobackport changesets 16411 and 16393 for authoritative methods
phasefx [Mon, 10 May 2010 18:37:44 +0000 (18:37 +0000)]
backport changesets 16411 and 16393 for authoritative methods

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16412 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agobackporting 16376: fixed bug where updating the email address resulted in updating...
erickson [Mon, 3 May 2010 15:37:24 +0000 (15:37 +0000)]
backporting 16376: fixed bug where updating the email address resulted in updating the username instead of the email address on the local copy of the user object in the opac.  this bug likely affected nothing.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16378 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoFix another DML bug in the 1.6.0.3-1.6.0.4 upgrade script.
dbs [Wed, 28 Apr 2010 14:48:05 +0000 (14:48 +0000)]
Fix another DML bug in the 1.6.0.3-1.6.0.4 upgrade script.

Thanks to Anoop Atre for catching this.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16331 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoMerge r16263 from tags/rel_1_6_0_4 into rel_1_6_0
dbs [Wed, 28 Apr 2010 03:36:33 +0000 (03:36 +0000)]
Merge r16263 from tags/rel_1_6_0_4 into rel_1_6_0

Correct "materialized.simple_record" to "reporter.materialized_simple_record"

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16327 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoWe missed r15825 in 1.6.0.4 release; catch it for future releases
dbs [Tue, 27 Apr 2010 17:19:17 +0000 (17:19 +0000)]
We missed r15825 in 1.6.0.4 release; catch it for future releases

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16322 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agobackport changeset 16306: There is no template for printing patron lists. Quick fix...
phasefx [Mon, 26 Apr 2010 20:06:40 +0000 (20:06 +0000)]
backport changeset 16306: There is no template for printing patron lists. Quick fix until we replace those actions with standard List actions

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16314 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoApply Jeff Godin's patch to fix Exporter forwarding to HTTPS
dbs [Thu, 22 Apr 2010 13:37:09 +0000 (13:37 +0000)]
Apply Jeff Godin's patch to fix Exporter forwarding to HTTPS

From https://bugs.launchpad.net/evergreen/+bug/538286

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16287 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agobackport r16265: addressing LP bug #562553, added content in the slimpac and callnumb...
miker [Sat, 17 Apr 2010 21:11:43 +0000 (21:11 +0000)]
backport r16265: addressing LP bug #562553, added content in the slimpac and callnumber browser

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16267 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years ago1.6.0.4 upgrade script changes
miker [Fri, 16 Apr 2010 17:31:16 +0000 (17:31 +0000)]
1.6.0.4 upgrade script changes

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16255 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoDecode input, encode output. That's what Perl Unicode advice says, and it happens...
dbs [Fri, 16 Apr 2010 15:02:46 +0000 (15:02 +0000)]
Decode input, encode output. That's what Perl Unicode advice says, and it happens to fix a problem for Indiana.

Tested on Conifer production, no problems were introduced.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16250 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoBackport r16247 to avoid unwanted marc8_to_utf8 conversion of records with incorrect...
dbs [Fri, 16 Apr 2010 14:34:30 +0000 (14:34 +0000)]
Backport r16247 to avoid unwanted marc8_to_utf8 conversion of records with incorrect leaders

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16249 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agobackport 16217: verify thaw date exists before attempting to iso-string-ify it, other...
erickson [Mon, 12 Apr 2010 19:15:10 +0000 (19:15 +0000)]
backport 16217: verify thaw date exists before attempting to iso-string-ify it, otherwise dojo dies

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16219 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoUpdate copyright statement to current year; include "and others" to be more accurate
dbs [Mon, 12 Apr 2010 18:22:48 +0000 (18:22 +0000)]
Update copyright statement to current year; include "and others" to be more accurate

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16215 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoBackporting r16201: w/ in-db circ, if patron permit fails with no_item, continue...
miker [Mon, 12 Apr 2010 15:31:11 +0000 (15:31 +0000)]
Backporting r16201: w/ in-db circ, if patron permit fails with no_item, continue on if this is a noncat checkout

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16209 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoBackporting r16204: Patch from Galen Charlton. This patch adds additional calls...
miker [Mon, 12 Apr 2010 15:08:18 +0000 (15:08 +0000)]
Backporting r16204: Patch from Galen Charlton.  This patch adds additional calls to escape_xml to handle cases where patron or library data could contain ampersand or other characters that need to be converted to entities. Issue discovered by Bibliomation; patch includes contributions by Ben Ostrowsky.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16206 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agobackport 13966: protecting against dissapearing grid cells during grid render of...
erickson [Mon, 12 Apr 2010 12:52:34 +0000 (12:52 +0000)]
backport 13966: protecting against dissapearing grid cells during grid render of autowidget

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16198 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoproper support for in-db renewal of precats
miker [Wed, 7 Apr 2010 03:22:06 +0000 (03:22 +0000)]
proper support for in-db renewal of precats

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16146 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoadd new permission to upgrade script
miker [Sat, 27 Mar 2010 17:46:35 +0000 (17:46 +0000)]
add new permission to upgrade script

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16022 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoPatch from Dan Wells which allows restriction of renewal when the item in question...
miker [Sat, 27 Mar 2010 17:35:48 +0000 (17:35 +0000)]
Patch from Dan Wells which allows restriction of renewal when the item in question is needed to fulfill a hold.

There was concern initially about whether a patrons own holds should be ignored, but that is not the case in scripted circ rules, so the behavior, as implemented by Dan, is correct.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16020 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agotextbox support for oils_persist (to fix stickiness in the label interface). trunk...
phasefx [Fri, 26 Mar 2010 16:02:24 +0000 (16:02 +0000)]
textbox support for oils_persist (to fix stickiness in the label interface).  trunk already has this but is so drastically different that I'm afraid to backport

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@16007 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoFix warning from comparison with a possibly undef variable
dbs [Thu, 25 Mar 2010 18:58:40 +0000 (18:58 +0000)]
Fix warning from comparison with a possibly undef variable

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15984 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years ago"Active" in this context means "Enabled", not not-passive; let's avoid potential...
dbs [Wed, 24 Mar 2010 16:58:29 +0000 (16:58 +0000)]
"Active" in this context means "Enabled", not not-passive; let's avoid potential confusion

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15950 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoDefault to "true" for email notification of holds in example configuration file
dbs [Mon, 22 Mar 2010 22:07:54 +0000 (22:07 +0000)]
Default to "true" for email notification of holds in example configuration file
Fix minor typos in HoldNotify.pm log messages

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15933 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoAdd Karmic support to the prereqs; looks like I mangled the previous merge attempt.
dbs [Fri, 19 Mar 2010 15:32:54 +0000 (15:32 +0000)]
Add Karmic support to the prereqs; looks like I mangled the previous merge attempt.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15917 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoreturn mapped legacy events from in-db circ, so that precat copies check out properly
miker [Thu, 18 Mar 2010 18:32:47 +0000 (18:32 +0000)]
return mapped legacy events from in-db circ, so that precat copies check out properly

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15912 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoneed to pass the $client to transactional methods
miker [Thu, 18 Mar 2010 14:40:06 +0000 (14:40 +0000)]
need to pass the $client to transactional methods

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15909 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agomake sure these selects run against the master db by putting them inside a transaction
miker [Thu, 18 Mar 2010 13:44:42 +0000 (13:44 +0000)]
make sure these selects run against the master db by putting them inside a transaction

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15908 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agomake this use a transaction or replication lag can bite us on patron registration
phasefx [Wed, 17 Mar 2010 20:41:09 +0000 (20:41 +0000)]
make this use a transaction or replication lag can bite us on patron registration

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15885 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoupgrade scrip version of r15879: delete the metarecord link for "deleted" records
miker [Wed, 17 Mar 2010 19:14:39 +0000 (19:14 +0000)]
upgrade scrip version of r15879: delete the metarecord link for "deleted" records

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15880 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agodelete the metarecord link for "deleted" records
miker [Wed, 17 Mar 2010 19:14:07 +0000 (19:14 +0000)]
delete the metarecord link for "deleted" records

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15879 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agomake batch renewal use synchronous calls again to better handle exceptions. The...
phasefx [Tue, 16 Mar 2010 19:56:27 +0000 (19:56 +0000)]
make batch renewal use synchronous calls again to better handle exceptions.  The original push for synchronous calls here was for performance, so we may need to revisit

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15873 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agotypo spotted by Steve Callender and Dan Scott
miker [Tue, 16 Mar 2010 18:55:01 +0000 (18:55 +0000)]
typo spotted by Steve Callender and Dan Scott

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15870 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agothinko spotted by Bill Ott, whereby empty middle name field stops barcode display...
miker [Tue, 16 Mar 2010 15:43:17 +0000 (15:43 +0000)]
thinko spotted by Bill Ott, whereby empty middle name field stops barcode display in brief circ interface

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15865 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoImproved patch from Galen Charlton: removes empty XML elements when ingesting a bib...
miker [Tue, 16 Mar 2010 15:00:20 +0000 (15:00 +0000)]
Improved patch from Galen Charlton: removes empty XML elements when ingesting a bib record

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15864 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoPatch from Galen Charlton: removes empty controlfield elements, which can be produced...
miker [Tue, 16 Mar 2010 14:17:34 +0000 (14:17 +0000)]
Patch from Galen Charlton: removes empty controlfield elements, which can be produced in a couple different ways during the ingest of slightly invalid MARC records

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15860 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agouse logical date math to avoid problems with DST boundary
miker [Tue, 16 Mar 2010 14:13:26 +0000 (14:13 +0000)]
use logical date math to avoid problems with DST boundary

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15854 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoremove unused (and warning-causing) "use" line
miker [Mon, 15 Mar 2010 15:57:57 +0000 (15:57 +0000)]
remove unused (and warning-causing) "use" line

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15848 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoFix some broken survey handling. The patron editor (legacy, haven't checked newer...
phasefx [Mon, 15 Mar 2010 09:52:49 +0000 (09:52 +0000)]
Fix some broken survey handling.  The patron editor (legacy, haven't checked newer one yet) was only saving the response for the first question in any given survey, and the Info/Other -> Survey display screen was likewise
mishandling survey responses and giving an ugly error for multi-question surveys.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15845 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoBackport r15830: scale the response rate with the number of records processed so far
miker [Fri, 12 Mar 2010 19:03:43 +0000 (19:03 +0000)]
Backport r15830: scale the response rate with the number of records processed so far

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15832 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoaaaaaaaargh ... the spelling fix! it hurts!
miker [Fri, 12 Mar 2010 17:04:05 +0000 (17:04 +0000)]
aaaaaaaargh ... the spelling fix! it hurts!

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15829 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoreturn the correct failpart for precat/noncat items
miker [Fri, 12 Mar 2010 14:56:41 +0000 (14:56 +0000)]
return the correct failpart for precat/noncat items

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15825 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoMerge the upgraded permission.usr_has_object_perm() function from r15675
dbs [Thu, 11 Mar 2010 22:07:29 +0000 (22:07 +0000)]
Merge the upgraded permission.usr_has_object_perm() function from r15675

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15810 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agofix this property thingy
phasefx [Thu, 11 Mar 2010 19:40:40 +0000 (19:40 +0000)]
fix this property thingy

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15805 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoBackporting r15797: make the ses cookie go away when the browser is closed
miker [Thu, 11 Mar 2010 18:04:55 +0000 (18:04 +0000)]
Backporting r15797: make the ses cookie go away when the browser is closed

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15799 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agobackport changeset 15162: this should fix some of those set_text on column errors...
phasefx [Thu, 11 Mar 2010 10:11:15 +0000 (10:11 +0000)]
backport changeset 15162: this should fix some of those set_text on column errors in bill Full Details

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15788 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agopreserve time component, when appropriate, on edited due dates and backdated circ...
miker [Wed, 10 Mar 2010 20:25:55 +0000 (20:25 +0000)]
preserve time component, when appropriate, on edited due dates and backdated circ checkins

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15779 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoReworking of a patch from Ben Ostrowsky: add an OILSProxyLoginOU Directory config...
miker [Wed, 10 Mar 2010 19:22:00 +0000 (19:22 +0000)]
Reworking of a patch from Ben Ostrowsky: add an OILSProxyLoginOU Directory config option for apache to supply a pinned workstation OU for permission checking

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15777 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agosupply a string so that the I18N build process does not lose the event definition
miker [Wed, 10 Mar 2010 14:28:38 +0000 (14:28 +0000)]
supply a string so that the I18N build process does not lose the event definition

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15772 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoFix syntax error in new permissions. How did you sneak in?
dbs [Tue, 9 Mar 2010 16:33:08 +0000 (16:33 +0000)]
Fix syntax error in new permissions. How did you sneak in?

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15763 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoFix syntax error in new permissions. How did you sneak in?
dbs [Tue, 9 Mar 2010 16:31:30 +0000 (16:31 +0000)]
Fix syntax error in new permissions. How did you sneak in?

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15762 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoinclude backport of r15619 in 1.6.0.4 upgrade script
miker [Tue, 9 Mar 2010 15:55:47 +0000 (15:55 +0000)]
include backport of r15619 in 1.6.0.4 upgrade script

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15761 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agobackporting the relevant portions of r15619, get a matchpoint as early as possible...
miker [Tue, 9 Mar 2010 15:49:57 +0000 (15:49 +0000)]
backporting the relevant portions of r15619, get a matchpoint as early as possible for override purposes

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15759 dcc99617-32d9-48b4-a31d-7c20da2025e4

15 years agoBackport r15686: Patch from Galen Charlton <gmc@esilibrary.com> to prevent one bad...
dbs [Tue, 9 Mar 2010 12:21:15 +0000 (12:21 +0000)]
Backport r15686: Patch from Galen Charlton <gmc@esilibrary.com> to prevent one bad MARC record from spoiling the rest of the export

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_1_6_0@15758 dcc99617-32d9-48b4-a31d-7c20da2025e4