working/Evergreen.git
8 years agoLP#1569884 Fix two problems in previous commit.
Jason Stephenson [Wed, 27 Apr 2016 19:43:31 +0000 (15:43 -0400)]
LP#1569884 Fix two problems in previous commit.

The CREATE TABLE biblio.monograph_part statement in
010.schema.biblio.sql ended up with a trailing comma.

The CREATE UNIQUE INDEX on biblio.monograph_part cannot be done
CONCURRENTLY at DB creation time, apparently.  At least not on
PostgreSQL 9.3.

Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1569884 Updated base schema with monograph parts index.
Steven Callender [Wed, 27 Apr 2016 16:05:48 +0000 (12:05 -0400)]
LP#1569884 Updated base schema with monograph parts index.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1569884 Allow deleted monograph parts to be recreated.
Steven Callender [Wed, 13 Apr 2016 15:15:27 +0000 (11:15 -0400)]
LP#1569884 Allow deleted monograph parts to be recreated.

Changed the constraint on the biblio.monograph_part table to allow for a
monograph part to be created if a duplicate deleted version is found.

To test:

[1] Add a monograph part to a bib.
[2] Delete that monograph part.
[3] Attempt to add a monograph part to the same bib using
    the same part label. Without the patches installed, this
    will fail; upon applying the database update, this operation
    should succeed.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1569884: add regression test
Galen Charlton [Thu, 28 Apr 2016 15:20:29 +0000 (11:20 -0400)]
LP#1569884: add regression test

This pgTAP test verifies that if you logically delete a monograph part,
you can subsequently add a new one with the same label as that of the
deleted one.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1564079 Stamping upgrade script
Kathy Lussier [Wed, 27 Apr 2016 14:35:49 +0000 (10:35 -0400)]
LP#1564079 Stamping upgrade script

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
8 years agoLP#1564079 Checkout history skips nonexistent items
Bill Erickson [Wed, 30 Mar 2016 21:57:59 +0000 (17:57 -0400)]
LP#1564079 Checkout history skips nonexistent items

Modify the user checkout history migration process
(2.9.3-2.10.0-upgrade-db.sql and 0960.schema.decouple_co_history.sql) to
avoid inserting history rows for circulations whose copies do not
exist in the database.

For reference, this is a rare condition that cannot be recreated in a
modern EG system short of modifying constraints.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
8 years agoLP#1564079 Checkout history handles serials
Bill Erickson [Wed, 30 Mar 2016 21:49:26 +0000 (17:49 -0400)]
LP#1564079 Checkout history handles serials

Remove the target_copy foreign key constraint on action.usr_circ_history
so that it does not prevent creation of rows from circulation's that
link to serial.unit objects.  Similar to action.circulation, the foreign
key constraint is enforced via a evergreen.fake_fkey_tgr trigger
instead.

This modifies the 2.9.3-2.10.0-upgrade-db.sql and 0960 upgrade scripts,
since without this change, the scripts may fail.

A separate upgrade script is added to drop the constraint for those who
have already successfully run the the 2.9.3-2.10.0-upgrade-db.sql script
(i.e. those who don't use serials).  For simplicity, the
evergreen.fake_fkey_tgr trigger is only applied in this separate upgrade
script (in addition to the base schema, of course).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
8 years agofixing missing newline user/sandbergja/cataloging_docs
Jane Sandberg [Tue, 26 Apr 2016 17:23:14 +0000 (10:23 -0700)]
fixing missing newline

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
8 years agoLP954213 adding MARC Editor documentation somewhat based on 2.1
Jane Sandberg [Wed, 16 Mar 2016 04:44:57 +0000 (21:44 -0700)]
LP954213 adding MARC Editor documentation somewhat based on 2.1

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
8 years agoLP1494346: Docs syntax error
Jane Sandberg [Tue, 15 Mar 2016 18:59:44 +0000 (11:59 -0700)]
LP1494346: Docs syntax error

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
8 years agoresolving merge conflict
Jane Sandberg [Tue, 15 Mar 2016 18:50:30 +0000 (11:50 -0700)]
resolving merge conflict

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
8 years agoAdding more information about authorities+Vandelay
Jane Sandberg [Tue, 15 Mar 2016 18:36:01 +0000 (11:36 -0700)]
Adding more information about authorities+Vandelay

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
8 years agoLP#1559121: remove Debian Squeeze support
Galen Charlton [Fri, 18 Mar 2016 14:34:40 +0000 (10:34 -0400)]
LP#1559121: remove Debian Squeeze support

Now that Debian Squeeze's LTS (long-term support) period
has ended, Evergreen no longer offers community support
for that distribution. This patch removes references
to Squeeze from the installation scripts and documentation.

To test:

[1] Verify that Debian Squeeze is no longer referenced in
    the installation documentation.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
Conflicts:
docs/installation/server_upgrade.txt

8 years agoDocs: clean up formatting & typos in using_the_public_access_catalog.txt
Yamil Suarez [Fri, 22 Apr 2016 20:51:20 +0000 (16:51 -0400)]
Docs: clean up formatting & typos in using_the_public_access_catalog.txt

Thanks to Anna Goben for these fixes.

Signed-off-by: Yamil Suarez <yamil@yamil.com>
8 years agoLP#1554714: update to latest Collapse attribute
Galen Charlton [Wed, 20 Apr 2016 15:20:36 +0000 (11:20 -0400)]
LP#1554714: update to latest Collapse attribute

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
8 years agoLP#1554714: final $modal => $uibModal
Galen Charlton [Wed, 20 Apr 2016 15:11:47 +0000 (11:11 -0400)]
LP#1554714: final $modal => $uibModal

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
8 years agoLP#1554714: more drop-down fixes
Galen Charlton [Wed, 20 Apr 2016 15:07:43 +0000 (11:07 -0400)]
LP#1554714: more drop-down fixes

Should be the last of them.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
8 years agoLP#1554714: specify resolution to make angular-animate happy
Galen Charlton [Wed, 20 Apr 2016 15:03:06 +0000 (11:03 -0400)]
LP#1554714: specify resolution to make angular-animate happy

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
8 years agoLP#1554714: fix up more drop-down menus
Galen Charlton [Wed, 20 Apr 2016 14:50:27 +0000 (10:50 -0400)]
LP#1554714: fix up more drop-down menus

This patch intentionally doesn't change templates
under cat/; that will come later.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
8 years agoLP#1554714: (indirectly) bump up PhantomJS version
Galen Charlton [Wed, 20 Apr 2016 14:19:40 +0000 (10:19 -0400)]
LP#1554714: (indirectly) bump up PhantomJS version

It turns out that PhantomJS 2 or later is required for
angular-mocks to succesfully inject dependencies; this patch
updates karma-phantomjs-launcher to a version that will
bring in a recent-enough version of PhantomJS.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
8 years agoLP#1554714 Ang 1.5 org unit dropdown repair
Bill Erickson [Thu, 14 Apr 2016 14:36:13 +0000 (10:36 -0400)]
LP#1554714 Ang 1.5 org unit dropdown repair

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1554714 ng-date-input -> eg-date-input typo
Bill Erickson [Thu, 14 Apr 2016 14:19:24 +0000 (10:19 -0400)]
LP#1554714 ng-date-input -> eg-date-input typo

We're using eg-date-input, not ng-date-input.

Thanks to Mike Rylander for pointing this out.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1554714 Ang. 1.5 navbar menu repairs
Bill Erickson [Thu, 17 Mar 2016 14:26:42 +0000 (10:26 -0400)]
LP#1554714 Ang. 1.5 navbar menu repairs

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1554714 Ang 1.5 requires service to return an object
Bill Erickson [Wed, 16 Mar 2016 22:10:12 +0000 (18:10 -0400)]
LP#1554714 Ang 1.5 requires service to return an object

Return a {} from the dummy patronSvc service used by the standalone
patron editor.  Ang 1.5 requires services to return non-null.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1554714 eg-date-input relays ng-blur
Bill Erickson [Wed, 16 Mar 2016 22:09:51 +0000 (18:09 -0400)]
LP#1554714 eg-date-input relays ng-blur

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1554714 Migrate eg-date-input to ui-datepicker-popup
Bill Erickson [Thu, 10 Mar 2016 18:08:00 +0000 (13:08 -0500)]
LP#1554714 Migrate eg-date-input to ui-datepicker-popup

Also add support for uib-timepicker as an option secondary component of
the input.

Refactor existing use of eg-date-input to use <eg-date-input/>-style
declaration to better differentiate between a normal <input> and the
more complete/stylized date input div.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1554714 Patron reg DoB via datepicker
Bill Erickson [Wed, 9 Mar 2016 19:00:27 +0000 (14:00 -0500)]
LP#1554714 Patron reg DoB via datepicker

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1554714 Patron reg DoB parse month bug repair
Bill Erickson [Wed, 9 Mar 2016 19:01:31 +0000 (14:01 -0500)]
LP#1554714 Patron reg DoB parse month bug repair

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1554714 Patron reg 1.5 controller consolidation
Bill Erickson [Wed, 9 Mar 2016 13:38:41 +0000 (08:38 -0500)]
LP#1554714 Patron reg 1.5 controller consolidation

Angular 1.4+ requires that each controller be instantiated via the
module.controller() function.  No more global functions.  The patron
reg. controller, shared by 2 different modules, was defined as a global
function.  Resolve this by hanging it off the core module (when loaded).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1554714 angular-bootstrap 1.4 uibModal migration
Bill Erickson [Tue, 8 Mar 2016 21:12:48 +0000 (16:12 -0500)]
LP#1554714 angular-bootstrap 1.4 uibModal migration

angular-bootstrap's $modal module is now known as $uibModal.  Ditto
$uibModalInstance.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1554714 Browser client dependency updates note
Bill Erickson [Tue, 8 Mar 2016 21:01:15 +0000 (16:01 -0500)]
LP#1554714 Browser client dependency updates note

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1554714 Angular 1.5 + deps bower.json updates
Bill Erickson [Tue, 8 Mar 2016 20:58:33 +0000 (15:58 -0500)]
LP#1554714 Angular 1.5 + deps bower.json updates

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoDocs: Screenshots and step by step instructions added to Self Check section
Jennifer Pringle [Fri, 22 Apr 2016 03:02:21 +0000 (20:02 -0700)]
Docs: Screenshots and step by step instructions added to Self Check section

Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
8 years agoLP#1573372: Opt-in test broken because it uses bail-out.
Jason Stephenson [Fri, 22 Apr 2016 03:29:42 +0000 (23:29 -0400)]
LP#1573372: Opt-in test broken because it uses bail-out.

Use skip instead!

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
8 years agoDocs: New changes to new patron registration duplicate search.
Jennifer Pringle [Thu, 21 Apr 2016 22:36:36 +0000 (15:36 -0700)]
Docs: New changes to new patron registration duplicate search.

Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
8 years agoLP#1573364: Use a timezone in the future backdate checkin test.
Jason Stephenson [Fri, 22 Apr 2016 03:00:09 +0000 (23:00 -0400)]
LP#1573364: Use a timezone in the future backdate checkin test.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
8 years agoDocs: Exclude Electronic Resources
Anna Goben [Fri, 22 Apr 2016 02:58:14 +0000 (22:58 -0400)]
Docs: Exclude Electronic Resources

Signed-off-by: Yamil Suarez <yamil@yamil.com>
8 years agoLP 1562426: Renumber Perl live_t tests.
Jason Stephenson [Sun, 27 Mar 2016 00:16:34 +0000 (20:16 -0400)]
LP 1562426: Renumber Perl live_t tests.

We had some overlap in numbers at the beginning of test file names.
The OCD in me think this should be straightened out.  This branch
renumbers the duplicates starting with 10-.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
8 years agoDocs: Updated attributions.txt
Jane Sandberg [Thu, 21 Apr 2016 22:22:58 +0000 (15:22 -0700)]
Docs: Updated attributions.txt

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
8 years agoDocs: resized image
Yamil Suarez [Wed, 20 Apr 2016 20:20:16 +0000 (16:20 -0400)]
Docs: resized image

Signed-off-by: Yamil Suarez <yamil@yamil.com>
8 years agoDocs: Expanded information about item record view in OPAC
Debbie Luchenbill [Wed, 20 Apr 2016 20:17:55 +0000 (16:17 -0400)]
Docs: Expanded information about item record view in OPAC

Signed-off-by: Yamil Suarez <yamil@yamil.com>
8 years agoDocs: resized image
Yamil Suarez [Wed, 20 Apr 2016 19:58:12 +0000 (15:58 -0400)]
Docs: resized image

Signed-off-by: Yamil Suarez <yamil@yamil.com>
8 years agoDocs: added tip on using hold counts in renewals
Debbie Luchenbill [Wed, 20 Apr 2016 19:07:51 +0000 (15:07 -0400)]
Docs: added tip on using hold counts in renewals

Signed-off-by: Yamil Suarez <yamil@yamil.com>
8 years agoDocs: image fix
Angela Kilsdonk [Wed, 20 Apr 2016 18:42:09 +0000 (14:42 -0400)]
Docs: image fix

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
8 years agoDocs: Paid PO Lineitems
Angela Kilsdonk [Wed, 20 Apr 2016 18:23:02 +0000 (14:23 -0400)]
Docs: Paid PO Lineitems

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
8 years agoDocs: Funds disencumbered when invoice is closed
Angela Kilsdonk [Wed, 20 Apr 2016 15:04:45 +0000 (11:04 -0400)]
Docs: Funds disencumbered when invoice is closed

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
8 years agoLP#1570091: webstaff: fix typo
Galen Charlton [Thu, 31 Mar 2016 20:50:51 +0000 (16:50 -0400)]
LP#1570091: webstaff: fix typo

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
8 years agoLP#1570091: webstaff: fix transfer Volumes to Previously Marked Library
Galen Charlton [Thu, 31 Mar 2016 20:47:02 +0000 (16:47 -0400)]
LP#1570091: webstaff: fix transfer Volumes to Previously Marked Library

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
8 years agoLP#1570091: webstaff: isolate the scope of eg-status-bar
Galen Charlton [Thu, 31 Mar 2016 02:13:43 +0000 (22:13 -0400)]
LP#1570091: webstaff: isolate the scope of eg-status-bar

The messages array was fighting with ngToast's
messages array... and winning.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
8 years agoLP#1570091: webstaff: make use of ngToast for holdings action notifications
Mike Rylander [Wed, 30 Mar 2016 21:25:06 +0000 (17:25 -0400)]
LP#1570091: webstaff: make use of ngToast for holdings action notifications

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
8 years agoLP#1570091: webstaff: fix deps for ngToast, and put it in place gloablly
Mike Rylander [Wed, 30 Mar 2016 21:24:32 +0000 (17:24 -0400)]
LP#1570091: webstaff: fix deps for ngToast, and put it in place gloablly

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
8 years agoLP#1570091: webstaff: add tree control and a simple toaster for notifications
Mike Rylander [Wed, 30 Mar 2016 17:32:23 +0000 (13:32 -0400)]
LP#1570091: webstaff: add tree control and a simple toaster for notifications

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
8 years agoLP#1570091: webstaff: always check for duplciate barcodes
Mike Rylander [Fri, 25 Mar 2016 20:30:02 +0000 (16:30 -0400)]
LP#1570091: webstaff: always check for duplciate barcodes

... and disallow saving if critical data is missing

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
8 years agoLP#1539084: webstaff: sort column picker entries by class path and column labels
Mike Rylander [Fri, 25 Mar 2016 17:52:54 +0000 (13:52 -0400)]
LP#1539084: webstaff: sort column picker entries by class path and column labels

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Conflicts:
Open-ILS/web/js/ui/default/staff/services/grid.js

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
8 years agoLP#1570091: webstaff: make the vandelay page taller
Mike Rylander [Fri, 4 Mar 2016 17:34:27 +0000 (12:34 -0500)]
LP#1570091: webstaff: make the vandelay page taller

... to support extra-large queue inspection interfaces

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
8 years agoLP#1570091: webstaff: Add Cancel Transit action to item status
Mike Rylander [Fri, 4 Mar 2016 17:14:07 +0000 (12:14 -0500)]
LP#1570091: webstaff: Add Cancel Transit action to item status

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
8 years agoLP#1570091: webstaff: indicate warning/error conditions in volcopy editor
Mike Rylander [Thu, 3 Mar 2016 19:12:37 +0000 (14:12 -0500)]
LP#1570091: webstaff: indicate warning/error conditions in volcopy editor

Indicate when the user has an empty barcode, duplicate barcode,
or empty call number label.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
8 years agoLP#1570091: webstaff: adding item status actions
Mike Rylander [Thu, 3 Mar 2016 17:13:08 +0000 (12:13 -0500)]
LP#1570091: webstaff: adding item status actions

  - add items to bucket
  - request items
  - Link as Conjoined to Previously Marked Bib Record
  - Delete Copies
  - Check In Copies
  - Renew Copies
  - Show Triggered Events
  - Show Item Holds
  - Show Record Holds
  - Mark Item As Damaged
  - Mark Item as Missing
  - Add Copies
  - Add Volumes and Copies
  - Edit Volumes
  - Edit Copies
  - Edit Volumes and Copies
  - Replace Barcodes
  - Transfer Items to Previously Marked Library
  - Transfer Items to Previously Marked Volume

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
8 years agoLP#1570091: webstaff: fix handling of default copy status
Mike Rylander [Wed, 24 Feb 2016 16:32:50 +0000 (11:32 -0500)]
LP#1570091: webstaff: fix handling of default copy status

The status must be an int, so we cast it when coming from an YAOUS

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
8 years agoLP#1570091: Show (index / hit count) in the Back To Results button
Mike Rylander [Wed, 24 Feb 2016 16:02:42 +0000 (11:02 -0500)]
LP#1570091: Show (index / hit count) in the Back To Results button

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Conflicts:
Open-ILS/src/templates/opac/parts/record/navigation.tt2

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
8 years agoLP#1570091: webstaff: tweak display of fixed fields in MARC editor
Mike Rylander [Wed, 24 Feb 2016 14:54:29 +0000 (09:54 -0500)]
LP#1570091: webstaff: tweak display of fixed fields in MARC editor

- Add border to FF boxes
- align Source mnewmonic for the day that the seed data exists

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
8 years agoDocs: small fix for circulation_patron_records_web_client.txt & root.txt
Yamil Suarez [Wed, 13 Apr 2016 02:36:12 +0000 (22:36 -0400)]
Docs: small fix for circulation_patron_records_web_client.txt & root.txt

Signed-off-by: Yamil Suarez <yamil@yamil.com>
8 years agoDocs: small fix for lsa-barcode_completion.txt & root.txt
Yamil Suarez [Wed, 13 Apr 2016 02:33:43 +0000 (22:33 -0400)]
Docs: small fix for lsa-barcode_completion.txt & root.txt

Signed-off-by: Yamil Suarez <yamil@yamil.com>
8 years agoDocs: update root.txt to include 2.10 release notes
Yamil Suarez [Thu, 7 Apr 2016 17:51:14 +0000 (13:51 -0400)]
Docs: update root.txt to include 2.10 release notes

Signed-off-by: Yamil Suarez <yamil@yamil.com>
8 years agoDocs: typo fix in authentication_proxy.txt
Yamil Suarez [Tue, 5 Apr 2016 23:13:03 +0000 (19:13 -0400)]
Docs: typo fix in authentication_proxy.txt

Signed-off-by: Yamil Suarez <yamil@yamil.com>
8 years agoLP#1564685 Prevent linked address edit on reload
Bill Erickson [Sat, 2 Apr 2016 22:11:12 +0000 (18:11 -0400)]
LP#1564685 Prevent linked address edit on reload

Prevent editing of linked addresses when a user is loaded after the
clone operation.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1564685 Avoid referencing out-of-scope stat cats
Bill Erickson [Fri, 1 Apr 2016 00:35:00 +0000 (20:35 -0400)]
LP#1564685 Avoid referencing out-of-scope stat cats

Fixes a bug in the patron editor where out-of-scope stat cats would be
incorrectly bundled in the patron save operation, resulting in a
server-side error on save.  In short, ignore out-of-scope stat cat
entries for patrons in the editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1564685 Prevent edit of linked addresses
Bill Erickson [Mon, 28 Mar 2016 20:10:10 +0000 (16:10 -0400)]
LP#1564685 Prevent edit of linked addresses

Do not allow a cloned user to modify a linked address.  Only the address
owner should be able to do that.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1564685 New Address button is always accessible
Bill Erickson [Mon, 28 Mar 2016 20:00:18 +0000 (16:00 -0400)]
LP#1564685 New Address button is always accessible

The New Address button in the patron editor is now always accessible,
regardless of the existence of any addresses.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1564685 Repair patron editor checkboxes sizing
Bill Erickson [Mon, 28 Mar 2016 19:57:26 +0000 (15:57 -0400)]
LP#1564685 Repair patron editor checkboxes sizing

Fix the checkbox HTML markup to prevent huge checkboxes in the patron
editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1564685 Required-field org settings overlay defaults
Bill Erickson [Mon, 28 Mar 2016 19:48:29 +0000 (15:48 -0400)]
LP#1564685 Required-field org settings overlay defaults

An org setting requiring a value for a field in the patron editor means
the field is required, even if it's not required by default.  IOW, fix
the code that was supposed to do that already.

Of note, county and state can now both be marked as required by org
settings in the patron editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1564685 Allow delete of all patron addresses
Bill Erickson [Mon, 28 Mar 2016 19:30:37 +0000 (15:30 -0400)]
LP#1564685 Allow delete of all patron addresses

If the org setting ui.patron.registration.require_address is not true,
allow all addresses to be removed from a patron's account.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1564685 Alert and stop on invalid fields
Bill Erickson [Mon, 28 Mar 2016 19:22:52 +0000 (15:22 -0400)]
LP#1564685 Alert and stop on invalid fields

Display an alert message and prevent save or save+clone when invalid
values exist in the patron edit form.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1564685 Allow barcode as username despite regex
Bill Erickson [Thu, 24 Mar 2016 02:13:44 +0000 (22:13 -0400)]
LP#1564685 Allow barcode as username despite regex

Allow a patron's barcode to be considered a valid username in the patron
editor even in the presence of an 'opac.username_regex' org setting
value that does not match the barcode.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1564685 Avoid dupe usrname warning on matching patron
Bill Erickson [Thu, 24 Mar 2016 01:21:12 +0000 (21:21 -0400)]
LP#1564685 Avoid dupe usrname warning on matching patron

Do not treat usernames as duplicates when they belong to the patron
being edited.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP1564378: Silence Hash Init Warning
Jason Boyer [Thu, 31 Mar 2016 12:08:03 +0000 (08:08 -0400)]
LP1564378: Silence Hash Init Warning

A trivial change to silence a lot of noise (if your libraries
use extending grace periods.)

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoLP#1373601: Consider relevant characters before using word-boundary checks
Mike Rylander [Tue, 22 Mar 2016 15:50:58 +0000 (11:50 -0400)]
LP#1373601: Consider relevant characters before using word-boundary checks

To perform unanchored phrase limits, we make sure that the phrase supplied
by the user does not end in the middle of a word by bounding the condition
with word-boundary bracket expresssions.  However, if the phrase starts
or ends with a non-word character (that is, something other than numbers,
letters, or the underscore) then the word-boundary expression won't match.
The effect of this is to cause phrase searches starting or ending in
punctuation to fail when the user would not expect them to.

To address this, we now test the phrase for word-iness at the front and
back before applying word-boundary bracket expressions.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
8 years agoupdate upgrade instructions for 2.10.1
Galen Charlton [Wed, 23 Mar 2016 02:27:04 +0000 (22:27 -0400)]
update upgrade instructions for 2.10.1

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agorelease notes for Evergreen 2.10.1
Galen Charlton [Wed, 23 Mar 2016 02:24:33 +0000 (22:24 -0400)]
release notes for Evergreen 2.10.1

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years ago2.10.0 - 2.10.1 schema update script
Galen Charlton [Wed, 23 Mar 2016 01:51:39 +0000 (21:51 -0400)]
2.10.0 - 2.10.1 schema update script

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1560174 Stamping upgrade script
Dan Wells [Mon, 21 Mar 2016 21:49:15 +0000 (17:49 -0400)]
LP#1560174 Stamping upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
8 years agoLP#1560174: fix MARC import for database upgraded to 2.10.0
Galen Charlton [Mon, 21 Mar 2016 19:23:42 +0000 (15:23 -0400)]
LP#1560174: fix MARC import for database upgraded to 2.10.0

This patch applies the correct version of the vandelay.ingest_items()
stored procedure introduced in the patch for bug 1548143.

To test
-------
[1] Upgrade an Evergreen database to 2.10.0 (a fresh database
    will not run into the bug).
[2] Try importing a MARC bib record via Vandelay using a profile
    that imports items.  This should fail.
[3] Apply the schema update in this patch.
[4] Repeat step 2; this time, the import should succeed.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
8 years agoclear slate of RELEASE_NOTES_NEXT entries
Galen Charlton [Mon, 21 Mar 2016 13:44:01 +0000 (09:44 -0400)]
clear slate of RELEASE_NOTES_NEXT entries

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoTranslation updates - po files
Galen Charlton [Thu, 17 Mar 2016 21:43:54 +0000 (17:43 -0400)]
Translation updates - po files

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoforward-port the 2.10.0 upgrade instructions
Galen Charlton [Thu, 17 Mar 2016 22:50:40 +0000 (18:50 -0400)]
forward-port the 2.10.0 upgrade instructions

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoforward-port 2.9.3-2.10.0 monolithic DB update script
Galen Charlton [Thu, 17 Mar 2016 22:46:02 +0000 (18:46 -0400)]
forward-port 2.9.3-2.10.0 monolithic DB update script

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoforward-port 2.10.0 release notes
Galen Charlton [Thu, 17 Mar 2016 21:25:14 +0000 (17:25 -0400)]
forward-port 2.10.0 release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoPorting 2.9.2 to 2.9.3 database upgrade script.
Jason Stephenson [Wed, 16 Mar 2016 20:57:00 +0000 (16:57 -0400)]
Porting 2.9.2 to 2.9.3 database upgrade script.

Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
8 years agoPorting 2.8.6 -> 2.8.7 SQL upgrade
Bill Erickson [Wed, 16 Mar 2016 20:46:38 +0000 (16:46 -0400)]
Porting 2.8.6 -> 2.8.7 SQL upgrade

Signed-off-by: Bill Erickson <berickxx@gmail.com>
8 years agoDocs: 2.9.3 Release notes
Kathy Lussier [Wed, 16 Mar 2016 17:54:10 +0000 (13:54 -0400)]
Docs: 2.9.3 Release notes

Adding bug fixes to the point release notes for 2.9.3

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
8 years agodocs-2.8.7 release notes
Kathy Lussier [Wed, 16 Mar 2016 17:35:22 +0000 (13:35 -0400)]
docs-2.8.7 release notes

Adding point release notes for 2.8.7

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
8 years agoLP#1557621 Verify password barcode / deleted users repair
Bill Erickson [Tue, 15 Mar 2016 16:31:37 +0000 (12:31 -0400)]
LP#1557621 Verify password barcode / deleted users repair

* Fixes bug that caused password verify calls to fail with an exception
  when tested with a barcode.

* Verify API always returns false when tested on deleted users.

To test:

1. In the staff client, navigate to Circulation -> Verify Credentials
2. Confirm username and barcode lookups return success for a non-deleted
   user using the correct password.
3. Delete a test user in the database:
   UPDATE actor.usr SET deleted = TRUE WHERE id = <id-of-test-user>;
4. Re-do step 2 confirming non-success results are returned.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1367926: fix syntax error in DB update script
Galen Charlton [Tue, 15 Mar 2016 17:44:58 +0000 (13:44 -0400)]
LP#1367926: fix syntax error in DB update script

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agodocs: reorganizing, adding information about importing authority records using vandelay
Jane Sandberg [Mon, 14 Mar 2016 23:34:43 +0000 (16:34 -0700)]
docs: reorganizing, adding information about importing authority records using vandelay

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agodocs: Adding instructions for setting up due time in the patron's myopac display
Jane Sandberg [Tue, 1 Mar 2016 00:00:15 +0000 (16:00 -0800)]
docs: Adding instructions for setting up due time in the patron's myopac display

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agodocs: Adding section about facet_groups in advanced search
Jane Sandberg [Mon, 29 Feb 2016 23:42:31 +0000 (15:42 -0800)]
docs: Adding section about facet_groups in advanced search

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoTranslation updates - newpot
Galen Charlton [Tue, 15 Mar 2016 00:50:25 +0000 (20:50 -0400)]
Translation updates - newpot

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP1550035 Address deletion / avoid xact collisions
Bill Erickson [Sun, 6 Mar 2016 23:09:30 +0000 (18:09 -0500)]
LP1550035 Address deletion / avoid xact collisions

Avoid transaction collision errors when updating patrons, in cases where
the patron object has to be updated more than once, by refreshing the
last_xact_id value on the in-progress patron object.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1550036 Linked patrons for new users
Bill Erickson [Sun, 6 Mar 2016 22:50:30 +0000 (17:50 -0500)]
LP#1550036 Linked patrons for new users

Support adding auzillary (linked) groups for new patrons in the browser
client editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1553813 Patron editor validation / perm checks.
Bill Erickson [Thu, 25 Feb 2016 04:07:54 +0000 (23:07 -0500)]
LP#1553813 Patron editor validation / perm checks.

1. Adds support for enforcing ui.patron.edit.*.require and
ui.patron.edit.*.regex org unit settings via Angular's ng-pattern and
ng-required attributes.

2. Supports selecting only valid profile groups and home org units.

3. Warns the user when a duplicate barcode or username is encountered.

When any fields in the form are invalid, the save options are disabled.

==

Adds support for enforcing the following permissions:

UPDATE_USER
CREATE_USER
CREATE_USER_GROUP_LINK
UPDATE_PATRON_COLLECTIONS_EXEMPT
UPDATE_PATRON_CLAIM_RETURN_COUNT
UPDATE_PATRON_CLAIM_NEVER_CHECKED_OUT_COUNT
UPDATE_PATRON_ACTIVE_CARD
UPDATE_PATRON_PRIMARY_CARD

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>