working/Evergreen.git
6 years agoKMAIN-46 - Edit Remove Alert
Bill Erickson [Wed, 29 Oct 2014 21:07:11 +0000 (17:07 -0400)]
KMAIN-46 - Edit Remove Alert

    Cross-port: ff9bc1a

6 years agokmain-46 - Defaul message dropdown
Bill Erickson [Wed, 29 Oct 2014 21:07:10 +0000 (17:07 -0400)]
kmain-46 - Defaul message dropdown

    Cross-port: 776a43f

6 years agoKMAIN-143 - Change publisher weight, add publisher index to dropdown options
Bill Erickson [Wed, 29 Oct 2014 21:07:08 +0000 (17:07 -0400)]
KMAIN-143 - Change publisher weight, add publisher index to dropdown options

    Cross-port: fcf87f0

6 years agokmain-151 - Hyphens are ignored in search.
Bill Erickson [Wed, 29 Oct 2014 21:07:06 +0000 (17:07 -0400)]
kmain-151 - Hyphens are ignored in search.

    Cross-port: 9ff8534

6 years agoKMAIN-403 - Mockups for bib record links in manage authorities
Bill Erickson [Wed, 29 Oct 2014 21:07:04 +0000 (17:07 -0400)]
KMAIN-403 - Mockups for bib record links in manage authorities

    Cross-port: eb75b2c

6 years agoKMAIN-383 - Added link to bib record
Bill Erickson [Wed, 29 Oct 2014 21:07:02 +0000 (17:07 -0400)]
KMAIN-383 - Added link to bib record

    Cross-port: 9982f43

6 years agoKMAIN-227 - Enhance the Manage Authorities interface
Bill Erickson [Wed, 29 Oct 2014 21:07:00 +0000 (17:07 -0400)]
KMAIN-227 - Enhance the Manage Authorities interface

    Cross-port: 2b214f4

6 years agokmain227_Authority_browse_interface
Bill Erickson [Wed, 29 Oct 2014 21:06:58 +0000 (17:06 -0400)]
kmain227_Authority_browse_interface

    Cross-port: 590666f

6 years agokmain-9 additional changes to openils/var/templates_kcls/opac/parts/record/summary...
Bill Erickson [Wed, 29 Oct 2014 21:06:57 +0000 (17:06 -0400)]
kmain-9 additional changes to openils/var/templates_kcls/opac/parts/record/summary.tt2 modified:   openils/var/templates_kcls/opac/parts/record/summary.tt2

    Cross-port: 1f6c0a6

6 years agoKMAIN-110 KCLS-98 Title matches exactly
Bill Erickson [Wed, 29 Oct 2014 21:06:55 +0000 (17:06 -0400)]
KMAIN-110 KCLS-98 Title matches exactly

    Cross-port: a217a39

6 years agoKMAIN-181 Item Status [Addendum]
Bill Erickson [Wed, 29 Oct 2014 21:06:53 +0000 (17:06 -0400)]
KMAIN-181 Item Status [Addendum]

    Cross-port: 57e264a

6 years agoKMAIN-383 - Manage Authorities Interface - Search ID Enhancement
Bill Erickson [Wed, 29 Oct 2014 21:06:51 +0000 (17:06 -0400)]
KMAIN-383 - Manage Authorities Interface - Search ID Enhancement

    Cross-port: 046a96d

Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/SuperCat.pm

6 years agokmain-384_matches_exactly_dollar_sign
Bill Erickson [Wed, 29 Oct 2014 21:06:49 +0000 (17:06 -0400)]
kmain-384_matches_exactly_dollar_sign

    Cross-port: b82547b

6 years agoKMAIN-11: Default Dropdown for patron messages
Bill Erickson [Wed, 29 Oct 2014 21:06:47 +0000 (17:06 -0400)]
KMAIN-11: Default Dropdown for patron messages

    Cross-port: 84acdf5

Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm

Conflicts:
Open-ILS/xul/staff_client/chrome/content/main/constants.js

6 years agoKMAIN-385: Standard Patron Messages
Bill Erickson [Wed, 29 Oct 2014 21:06:45 +0000 (17:06 -0400)]
KMAIN-385: Standard Patron Messages

    Cross-port: a5efc1a

Conflicts:
Open-ILS/xul/staff_client/chrome/content/main/about.html

6 years agokmain-315 - Sort patron messages in chronological order. NOTE: This solution uses...
Bill Erickson [Wed, 29 Oct 2014 21:06:41 +0000 (17:06 -0400)]
kmain-315 - Sort patron messages in chronological order. NOTE: This solution uses javascript; kmain-319 asks for sort using fieldmapper. modified:   openils/var/web/xul/rel_2_4_1/server/patron/standing_penalties.js (cherry picked from commit bb615f7e3b92df02d7430298f22109257e5cd4e7)

    Cross-port: e32ac57

6 years agokmain-9 xul fix kmain-9 tt2 fix hash: 0abd8a19eac0fd93a0e4b5643f4cebe27d7ac860 Signed...
Bill Erickson [Wed, 29 Oct 2014 21:06:39 +0000 (17:06 -0400)]
kmain-9 xul fix kmain-9 tt2 fix hash: 0abd8a19eac0fd93a0e4b5643f4cebe27d7ac860 Signed-off-by: David Boyle <dboyle@catalystitservices.com>

    Cross-port: 2dd0f59

Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Search.pm

6 years agokmain-9. Partial fix - still needs fix to xul <End> button modified: openils/var...
Bill Erickson [Wed, 29 Oct 2014 21:06:37 +0000 (17:06 -0400)]
kmain-9. Partial fix - still needs fix to xul <End> button modified:   openils/var/templates_kcls/opac/parts/record/extras.tt2 modified:   openils/var/templates_kcls/opac/parts/record/summary.tt2 modified:   openils/var/templates_kcls/opac/parts/result/paginate.tt2 modified:   openils/var/templates_kcls/opac/results.tt2 (cherry picked from commit 0abd8a19eac0fd93a0e4b5643f4cebe27d7ac860)

    Cross-port: 57123d4

6 years agoKMAIN227 - part uno fix
Bill Erickson [Wed, 29 Oct 2014 21:06:35 +0000 (17:06 -0400)]
KMAIN227 - part uno fix

    Cross-port: 1c49b88

6 years agokmain-227-part-uno
Bill Erickson [Wed, 29 Oct 2014 21:06:34 +0000 (17:06 -0400)]
kmain-227-part-uno

    Cross-port: 08980d6

6 years agoKMAIN 332 - commit 2
Bill Erickson [Wed, 29 Oct 2014 21:06:32 +0000 (17:06 -0400)]
KMAIN 332 - commit 2

    Cross-port: 909da68

6 years agoKMAIN-332 Staff can toggle circ history
Bill Erickson [Wed, 29 Oct 2014 21:06:30 +0000 (17:06 -0400)]
KMAIN-332 Staff can toggle circ history

    Cross-port: 1178b73

6 years agoUpdated authority files. Added files for import of bibs Getting ready for demo.
Bill Erickson [Wed, 29 Oct 2014 21:06:28 +0000 (17:06 -0400)]
Updated authority files. Added files for import of bibs Getting ready for demo.

    Cross-port: 5984783

6 years agoKMAIN-318 Holds count fix
Bill Erickson [Wed, 29 Oct 2014 21:06:27 +0000 (17:06 -0400)]
KMAIN-318 Holds count fix

    Cross-port: ffb13a0

Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm

Moved custom rec_hold_count() code to a new rec_hold_count_kcls()
to reduce merge conflicts going forward function.

6 years agoKMAIN-330 - Research MVLC implementation of Authority Control
Bill Erickson [Wed, 29 Oct 2014 21:06:25 +0000 (17:06 -0400)]
KMAIN-330 - Research MVLC implementation of Authority Control

    Cross-port: e8b8026

6 years agoKMAIN-160: Shelf Expire Timestamp
Bill Erickson [Wed, 29 Oct 2014 21:06:23 +0000 (17:06 -0400)]
KMAIN-160: Shelf Expire Timestamp

    Cross-port: d73e70c

6 years agoKMAIN-141: OPAC display of ebook CN
Bill Erickson [Wed, 29 Oct 2014 21:06:19 +0000 (17:06 -0400)]
KMAIN-141: OPAC display of ebook CN

    Cross-port: 2a71c1a

6 years agoKMAIN-348 - Add Page Number Navigation to My Lists
Bill Erickson [Wed, 29 Oct 2014 21:06:17 +0000 (17:06 -0400)]
KMAIN-348 - Add Page Number Navigation to My Lists

    Cross-port: 6e75f1b

Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm

6 years agokmain-10. Default staff client page from 2.2 modified:
Bill Erickson [Wed, 29 Oct 2014 21:06:15 +0000 (17:06 -0400)]
kmain-10. Default staff client page from 2.2 modified:

openils/var/web/xul/rel_2_4_1/server/index.xhtml (cherry picked from commit 2c8568b142902b7f2e9b1ae503219bfe10519c8d)

    Cross-port: 96d66b3

Conflicts:
Open-ILS/xul/staff_client/server/index.xhtml

Conflicts:
Open-ILS/xul/staff_client/server/index.xhtml

6 years agokmain-310. Additional language search Searches MARC 041 for additional language codes.
Bill Erickson [Wed, 29 Oct 2014 21:06:14 +0000 (17:06 -0400)]
kmain-310. Additional language search Searches MARC 041 for additional language codes.

SQL scripts add new metabib.language_filter table and associated
trigger/scripts
new file:   sql/kmain-310/kclsupgrad34.rollback.sql
new file:   sql/kmain-310/kclsupgrad34.sql
modified:   usr/lib/perl5/site_perl/5.8.8/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm
(cherry picked from commit baf328d0c8a9ffb10eeb243db2fe4278ff1adcec)

    Cross-port: 7952a80

Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm

Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm

6 years agoKMAIN-328 - single copy count when searching by lib
Bill Erickson [Wed, 29 Oct 2014 21:06:12 +0000 (17:06 -0400)]
KMAIN-328 - single copy count when searching by lib

    Cross-port: b922cca

6 years agoKMAIN153 - Default Search Library (Dan Scott Fix)
Bill Erickson [Wed, 29 Oct 2014 21:06:10 +0000 (17:06 -0400)]
KMAIN153 - Default Search Library (Dan Scott Fix)

    Cross-port: 0b50aa9

6 years agoKMAIN-201 - Karen: Remove Default Phone # from Patron Registration screen under USER...
Bill Erickson [Wed, 29 Oct 2014 21:06:08 +0000 (17:06 -0400)]
KMAIN-201 - Karen: Remove Default Phone # from Patron Registration screen under USER SETTINGS

    Cross-port: f186103

6 years agoKMAIN203 - KCLSUPGRAD95 - KCLSUPGRAD30 - Remove Checkbox for Exempt Collections
Bill Erickson [Wed, 29 Oct 2014 21:06:06 +0000 (17:06 -0400)]
KMAIN203 - KCLSUPGRAD95 - KCLSUPGRAD30 - Remove Checkbox for Exempt Collections

    Cross-port: f2730b1

6 years agoKMAIN326 - Do Not Allow Creation of a List Without a Title.
Bill Erickson [Wed, 29 Oct 2014 21:06:04 +0000 (17:06 -0400)]
KMAIN326 - Do Not Allow Creation of a List Without a Title.

    Cross-port: e9c7422

6 years agoSort results descending was not working properly. Fixed.
Bill Erickson [Wed, 29 Oct 2014 21:06:03 +0000 (17:06 -0400)]
Sort results descending was not working properly. Fixed.

    Cross-port: 704f279

6 years agoFixed a issue with a label not showing up on the Patron Search Screen.
Bill Erickson [Wed, 29 Oct 2014 21:06:01 +0000 (17:06 -0400)]
Fixed a issue with a label not showing up on the Patron Search Screen.

    Cross-port: b8f7788

6 years agoKMAIN-324 Fixes bug: Copy and Hold count were not displaying properly
Bill Erickson [Wed, 29 Oct 2014 21:05:59 +0000 (17:05 -0400)]
KMAIN-324 Fixes bug: Copy and Hold count were not displaying properly

    Cross-port: 77f6b0d

6 years agoKMAIN-49 KCM-3 overwrite old transit info
Bill Erickson [Wed, 29 Oct 2014 21:05:57 +0000 (17:05 -0400)]
KMAIN-49 KCM-3 overwrite old transit info

    Cross-port: ad52384

6 years agoKMIG-72 KCLSUPGRAD-27 Record Summary scroll bar
Bill Erickson [Wed, 29 Oct 2014 21:05:55 +0000 (17:05 -0400)]
KMIG-72 KCLSUPGRAD-27 Record Summary scroll bar

    Cross-port: 4f73c3e

6 years agoKMIG-52-KCLSUPGRAD-98-user_activity_tracking_feature
Bill Erickson [Wed, 29 Oct 2014 21:05:54 +0000 (17:05 -0400)]
KMIG-52-KCLSUPGRAD-98-user_activity_tracking_feature

    Cross-port: e774e36

Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm

6 years ago Search Templates (kmig 123)
Bill Erickson [Wed, 29 Oct 2014 21:05:52 +0000 (17:05 -0400)]
  Search Templates (kmig 123)

    Cross-port: 5f1f13e

6 years agokmain-168 - sort checked out items original ticket KCM-17 modified: openils/conf...
Bill Erickson [Wed, 29 Oct 2014 21:05:48 +0000 (17:05 -0400)]
kmain-168 - sort checked out items original ticket KCM-17 modified:   openils/conf/fm_IDL.xml (cherry picked from commit b4f413dcf9592c321cadc024c427e5c931645c28)

    Cross-port: 0811348

Conflicts:
Open-ILS/examples/fm_IDL.xml

6 years agoKMAIN154 - KMIG45 - KCLSUPGRAD12 - Backdating Lost Item
Bill Erickson [Wed, 29 Oct 2014 21:05:46 +0000 (17:05 -0400)]
KMAIN154 - KMIG45 - KCLSUPGRAD12 - Backdating Lost Item

    Cross-port: ec196ab

Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm

6 years agokmain-27 changes to slider (READometer slide change). jpg from 2.2 Collections.pm...
Bill Erickson [Wed, 29 Oct 2014 21:05:45 +0000 (17:05 -0400)]
kmain-27 changes to slider (READometer slide change). jpg from 2.2 Collections.pm is 2.4 version modified:   openils/var/templates_kcls/opac/parts/homesearch.tt2 (cherry picked from commit 049c548b309052689d25b0d7d7068c5dbb0f753f)

    Cross-port: 00ef5ef

6 years agoKMAIN-85: Holds Pull List - add an indicator for copy-specify item
Bill Erickson [Wed, 29 Oct 2014 21:05:43 +0000 (17:05 -0400)]
KMAIN-85: Holds Pull List - add an indicator for copy-specify item

    Cross-port: 7b8f6f6

6 years agoKMIG43 and KMIG250 - KMAIN117 and KMAIN12 - KCLSUPGRAD10 and KCLSUPGRAD15
Bill Erickson [Wed, 29 Oct 2014 21:05:40 +0000 (17:05 -0400)]
KMIG43 and KMIG250 - KMAIN117 and KMAIN12 - KCLSUPGRAD10 and KCLSUPGRAD15

    Cross-port: 85738f7

6 years agoPorts Marc Edit Tiles (KMIG-99,103,111)
Bill Erickson [Wed, 29 Oct 2014 21:05:39 +0000 (17:05 -0400)]
Ports Marc Edit Tiles (KMIG-99,103,111)

    Cross-port: 2b9072c

6 years agoCopied 2.4.1 staff client build folder into repo
Bill Erickson [Wed, 29 Oct 2014 21:05:37 +0000 (17:05 -0400)]
Copied 2.4.1 staff client build folder into repo

    Cross-port: 958d2a0

6 years agoKMIG49 - KCLSUPGRAD19 - Uncancel Hold Feature - Not Observing Hold Polices
Bill Erickson [Wed, 29 Oct 2014 21:05:35 +0000 (17:05 -0400)]
KMIG49 - KCLSUPGRAD19 - Uncancel Hold Feature - Not Observing Hold Polices

    Cross-port: 2f9c839

6 years agoKMIG-53 : KCLSUPGRAD-28 : Patron search by record number missing
Bill Erickson [Wed, 29 Oct 2014 21:05:33 +0000 (17:05 -0400)]
KMIG-53 : KCLSUPGRAD-28 : Patron search by record number missing

    Cross-port: 518726b

Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/actor.pm

6 years agoKMIG-57 : KCLSUPGRAD-33: Set all patron's Default Search Location to KCLS
Bill Erickson [Wed, 29 Oct 2014 21:05:32 +0000 (17:05 -0400)]
KMIG-57 : KCLSUPGRAD-33: Set all patron's Default Search Location to KCLS

    Cross-port: f194b73

6 years agoKMIG-187: Hold Queue Position
Bill Erickson [Wed, 29 Oct 2014 21:05:30 +0000 (17:05 -0400)]
KMIG-187: Hold Queue Position

    Cross-port: bba2c05

6 years agokmig-214 - email request from KCLS/Bradley for production changes homesearch.tt2...
Bill Erickson [Wed, 29 Oct 2014 21:05:28 +0000 (17:05 -0400)]
kmig-214 - email request from KCLS/Bradley for production changes homesearch.tt2 was changed via kmig-217 modified:   openils/var/templates_kcls/opac/parts/homesearch.tt2 modified:   openils/var/web/css/skin/default/opac/style.css (cherry picked from commit 3c45a198065faabff08fde6f93f1048c4631d4af)

    Cross-port: 006f8ae

6 years agokmig-225 - additional marc templates requested in 07/29/2013 email from Bradley new...
Bill Erickson [Wed, 29 Oct 2014 21:05:25 +0000 (17:05 -0400)]
kmig-225 - additional marc templates requested in 07/29/2013 email from Bradley new file:   openils/var/templates/marc/k_Book_on_CD.xml new file:   openils/var/templates/marc/k_Book_revised.xml new file:   openils/var/templates/marc/k_DVD.xml new file:   openils/var/templates/marc/k_Large_Print.xml new file:   openils/var/templates/marc/k_Music_CD.xml new file:   openils/var/templates/marc/k_Player.xml (cherry picked from commit e3c65708993725528f6472d23cad3ab03379afaa)

    Cross-port: 641ffcf

6 years agoKMIG-71: KCLSUPGRAD-39: Cancel button in staff client Place Hold does not work
Bill Erickson [Wed, 29 Oct 2014 21:05:21 +0000 (17:05 -0400)]
KMIG-71: KCLSUPGRAD-39: Cancel button in staff client Place Hold does not work

    Cross-port: 246a5bd

6 years agoFixes context with new tab!
Bill Erickson [Wed, 29 Oct 2014 21:05:19 +0000 (17:05 -0400)]
Fixes context with new tab!

    Cross-port: f0c436b

6 years agokmig-149 change username text on patron registration page Requested by Bradley in...
Bill Erickson [Wed, 29 Oct 2014 21:05:17 +0000 (17:05 -0400)]
kmig-149 change username text on patron registration page Requested by Bradley in email 04/22/2013 modified:   openils/conf/fm_IDL.xml

    Cross-port: cd87eea

6 years agokmig-147 - 3fab37 Added SQL changes per Matt's email of 04/29/2013 new file: ...
Bill Erickson [Wed, 29 Oct 2014 21:05:15 +0000 (17:05 -0400)]
kmig-147 - 3fab37   Added SQL changes per Matt's email of 04/29/2013 new file:   sql/kmig-147.sql (cherry picked from commit 6c3aaf53653b859ac8ed838ce5377ce6fd545dd4)

    Cross-port: 354d61d

6 years agoForward ported changes for KCM-8
Bill Erickson [Wed, 29 Oct 2014 21:05:10 +0000 (17:05 -0400)]
Forward ported changes for KCM-8

    Cross-port: bbf5fe0

6 years agoPorts KCLSUPGRAD-6 - Creating PO from Acq brief record
Bill Erickson [Wed, 29 Oct 2014 21:05:08 +0000 (17:05 -0400)]
Ports KCLSUPGRAD-6 - Creating PO from Acq brief record

    Cross-port: 219b41c

6 years agoUpgraded stock EG code to tag 2_4_1
Bill Erickson [Wed, 29 Oct 2014 21:05:05 +0000 (17:05 -0400)]
Upgraded stock EG code to tag 2_4_1

    Cross-port: 4de67518bad776e9b2ea2e55169efd016a16b17d

Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/SIP/Transaction/RenewAll.pm
Open-ILS/web/css/skin/default/acq.css
Open-ILS/web/css/skin/default/opac/semiauto.css

6 years agoLP1776736 Record merge marc edit repairs
Bill Erickson [Thu, 14 Mar 2019 16:03:58 +0000 (12:03 -0400)]
LP1776736 Record merge marc edit repairs

1. Fixes issues where edits to MARC records would fail to save during
   merge.

2. Provide options to select flat or non-flat text editor in edit mode
   for record merges.

3. Allow record editor action buttons/selectors to flow down
   horizontally when they don't fit in a narrow space.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP1749502 - Holds Pull List Print Order
Josh Stompro [Tue, 26 Feb 2019 20:21:06 +0000 (14:21 -0600)]
LP1749502 - Holds Pull List Print Order

- Expose call number affix sortkey data.
- Use sortkey data to sort default pull list template.
- Combine all call number info into one field in default pull list template.
- Sorty by shelf location position if it exists, then by shelf location name if it doesn't
- Only grab copy info if copy is assigned, to not break patron holds grid.
- Remove some web console logging only needed for testing.

Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
6 years agoLP 1749502: Add Call Number Prefix & Suffix to pull list print template.
Jason Stephenson [Wed, 12 Sep 2018 19:34:56 +0000 (15:34 -0400)]
LP 1749502: Add Call Number Prefix & Suffix to pull list print template.

We add the call number prefix and suffix as separate columns to the
holds pull list print template.  We also add the suffix to the end of
the orderBy so that we also sort by the suffix.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
6 years agolp1749502 Prefix patch
Kyle Huckins [Tue, 29 May 2018 16:06:59 +0000 (16:06 +0000)]
lp1749502 Prefix patch

- Ensure prefix information is properly set

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/share/print_templates/t_hold_pull_list.tt2
modified:   Open-ILS/web/js/ui/default/staff/circ/services/holds.js

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
6 years agolp1749502 Holds Pull List Print Order
Kyle Huckins [Thu, 17 May 2018 21:08:27 +0000 (21:08 +0000)]
lp1749502 Holds Pull List Print Order

- Ensure copy shelf location position is available for each hold on
holds shelf.
- Add _copy_location_position to hold_data while printing.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/share/print_templates/t_hold_pull_list.tt2
modified:   Open-ILS/web/js/ui/default/staff/circ/services/holds.js

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
6 years agoLP1739293 Record merged edit-in-place avoid wrap
Bill Erickson [Tue, 5 Mar 2019 16:53:09 +0000 (11:53 -0500)]
LP1739293 Record merged edit-in-place avoid wrap

When using the inline editor, prevent text wrapping and instead allow
the text to overflow x and y and use scrolls to navigate.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
6 years agoLP1739293 Record merge fits container
Bill Erickson [Tue, 5 Mar 2019 16:10:44 +0000 (11:10 -0500)]
LP1739293 Record merge fits container

Allow the text contents of each merged MARC record to wrap so the
records may fit horizontally on the screen.  A single vertical scroll
allows the user to scroll down to see any parts of the record that
require more vertical space.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
6 years agoLP1739293 Record merge horizontal; optional holdings
Bill Erickson [Fri, 8 Feb 2019 16:25:10 +0000 (11:25 -0500)]
LP1739293 Record merge horizontal; optional holdings

* Tile bib records horizontally in record bucket => merge records
  interface.

* Add a "Toggle Holdings View" button for displaying holdings and leave
  holdings un-displayed by default.

* Duplicate the Merge and Cancel buttons along the top of the dialog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
6 years agoLP 1819796: Fix method call on undefined value in generate_fines
Jason Stephenson [Wed, 13 Mar 2019 16:37:23 +0000 (12:37 -0400)]
LP 1819796: Fix method call on undefined value in generate_fines

The below message repeats in the open-ils.storage_stderr.log:

Caught error from 'run' method: Can't call method "search_where" on an
undefined value at
/usr/local/share/perl/5.26.1/OpenILS/Application/Storage/Publisher/action.pm
line 1014.

This commit removes an errant ->search_where on a CStoreEditor call to
make that message go away.

Also, delete some lines of code that were commented out at the time the
code was converted to use CStoreEditor.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP1793196 Fix console error when none selected
Remington Steed [Fri, 8 Mar 2019 20:27:45 +0000 (15:27 -0500)]
LP1793196 Fix console error when none selected

If you open the dropdown and close it without selecting anything, the
console shows an error complaining that $scope.selected is undefined.
This commit checks that it exists in that case before using it.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP1793196 Volume batch editor offers MARC call numbers
Bill Erickson [Tue, 5 Feb 2019 17:28:15 +0000 (12:28 -0500)]
LP1793196 Volume batch editor offers MARC call numbers

Provide call numbers extracted from the MARC record as options in the
volume batch editor.  Call numbers to extract are based on the load-time
classification scheme, defaulting to Generic ('1') if no default scheme
is applied.

Patch includes additional sanity checks on volume editor utility
functions to avoid console errors referencing undefined values.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP1665534: Make pickup library in bib record holds view sticky
Jane Sandberg [Sun, 2 Sep 2018 23:13:46 +0000 (16:13 -0700)]
LP1665534: Make pickup library in bib record holds view sticky

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoLP1808006 - Sitemap generator fix to allow shortname parameter.
Steven Callender [Tue, 11 Dec 2018 18:18:27 +0000 (13:18 -0500)]
LP1808006 - Sitemap generator fix to allow shortname parameter.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Geoff Sams <gsams@roanoketexas.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoLP1798628: Copy alert counts in Holdings
Jason Boyer [Thu, 17 Jan 2019 18:33:10 +0000 (13:33 -0500)]
LP1798628: Copy alert counts in Holdings

Currently the count of all copy alerts ever applied
to a copy is displayed in the Holdings view, which
can be quite confusing when clicking Manage and not
seeing the expected number of alerts. This branch
changes the display to only count the number of
events currently active since those are the only
ones available to manage.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoLP#1778571 Fix logic error converting JS bool to DB bool
Remington Steed [Thu, 25 Oct 2018 12:53:32 +0000 (08:53 -0400)]
LP#1778571 Fix logic error converting JS bool to DB bool

Two minor bugs in the Copy Notes editor had the same cause in two
separate places. The cause was forgetting to convert the checkbox status
(a JavaScript bool) to the correct database format ('t' or 'f'). The
resulting symptoms were buggy behavior related to the state of the
"Public Note" checkbox. This commit addresses both cases mentioned in
the bug report and comments.

To test the buggy behavior:
1. Edit an item (e.g. click the "Edit" link from the client OPAC view).
2. Click the "Item Notes" button (near the bottom of the editor).
3. Add a new note and check the "Public Note" box.
4. Click "OK".
5. Click "Item Notes" again and notice that the "Public Note" box on your
   new note is no longer checked. (That's bug #1.)
6. Check "Public Note" again, click "OK", and click "Save & Exit".
7. Edit the same item again. Click "Item Notes".
8. Your note should correctly have the "Public Note" checkbox checked.
9. Uncheck the box and click "OK". Click "Save & Exit".
10. Edit the same item. Click "Item Notes".
11. Notice that your change didn't save. The "Public Note" checkbox is
    still checked. (That's bug #2.)

To test the fixes:
- Clear your browser cache.
- Repeat the steps above, noticing that:
  - At step 5, the new note correctly has the "Public Note" checkbox
    checked.
  - At step 11, the edited note correctly has the "Public Note" checkbox
    unchecked.

NOTE: Testing requires clearing the browser cache, since the
t_copy_notes.tt2 file is fetched asynchronously by AngularJS.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoLP#1759238: stamping upgrade script
Chris Sharp [Fri, 8 Mar 2019 19:19:02 +0000 (14:19 -0500)]
LP#1759238: stamping upgrade script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoLP#1759238: Add upgrade script to fix typo for Physical Description in DB
Ben Shum [Tue, 1 May 2018 14:38:39 +0000 (10:38 -0400)]
LP#1759238: Add upgrade script to fix typo for Physical Description in DB

This upgrade script will check and update the typo if it is present in
an existing installation.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoLP#1769238: fix typo in 950.data.seed-values.sql for Physical Description
Ben Shum [Tue, 1 May 2018 14:29:25 +0000 (10:29 -0400)]
LP#1769238: fix typo in 950.data.seed-values.sql for Physical Description

Instead of "Physical Description", "Physical Descrption" is used by mistake.
Fix the seed data and all related PO files for translation.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Conflicts:
build/i18n/po/db.seed/cs-CZ.po

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoLp 712490: Stamping UPgrade Script
Jason Stephenson [Fri, 8 Mar 2019 18:54:35 +0000 (13:54 -0500)]
Lp 712490: Stamping UPgrade Script

Signed-off-by: Jason Stephenson <jason@sigio.com>
6 years agoLP#712490 Vandelay replace/merge PGTAP tests
Bill Erickson [Thu, 19 Oct 2017 15:42:43 +0000 (11:42 -0400)]
LP#712490 Vandelay replace/merge PGTAP tests

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Jason Stephenson <jason@sigio.com>
6 years agoLP#712490 Vandelay merge-based field replacement
Bill Erickson [Wed, 18 Oct 2017 21:00:59 +0000 (17:00 -0400)]
LP#712490 Vandelay merge-based field replacement

Modify the vandelay field replacement logic to merge replacement data
into existing field data where possible, instead of simply deleting then
re-adding the data.  The key benefit is that subfields retain their order
in affected MARC fields.  As a result, for example, propagating
authority field changes to bib records will no longer result in the $0
field being pushed to the front of the field when it was previously that
last subfield.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Jason Stephenson <jason@sigio.com>
6 years agoLP1794588 Web client edit single call number changes all when multiple items attached
Jason Etheridge [Wed, 16 Jan 2019 13:57:26 +0000 (08:57 -0500)]
LP1794588 Web client edit single call number changes all when multiple items attached

This patch tweaks the behavior Cat.pm's fleshed_volume_update, aka
open-ils.cat.asset.volume.fleshed.batch.update

Previously, if a volume label was edited, all items attached to that
volume would be essentially affected.  Now, if only a sub-set of items
for the original volume being edited are being edited along with the
volume, then a new volume is potentially created instead, leaving the
original volume (and its unedited copies) untouched.  If no copies are
being edited along with a volume, then the volume itself is edited.

Auto-merging of volumes may still happen in all of these scenarios.

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Janet Schrader <jschrader@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
6 years agolp1802662 - Splash Page Icon Links
Sam Link [Thu, 13 Dec 2018 16:06:55 +0000 (11:06 -0500)]
lp1802662 - Splash Page Icon Links

Moved the image icons on splash.component.html and t_splash.tt2 inside
the anchor links to the associated pages.

Signed-off-by: Sam Link <slink@LIBPC002>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoLP#1818576 Offline Noncataloged Checkout Preview
Terran McCanna [Tue, 5 Mar 2019 17:34:49 +0000 (12:34 -0500)]
LP#1818576 Offline Noncataloged Checkout Preview

This adds the noncataloged type and number to the right-hand
preview when doing an offline checkout. (Prior to this, the
display was blank if there was no barcode.)

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoLP#1812389: make Group Penalty Threshold admin page accessible again
Galen Charlton [Wed, 23 Jan 2019 15:52:24 +0000 (10:52 -0500)]
LP#1812389: make Group Penalty Threshold admin page accessible again

As a consequence of the patch for bug 1744756 adding a new
admin/local/permission AngularJS app, the routing for
admin/local/permission/grp_penalty_threshold got broken, making the
embdeded Conify interface for group penalty thresholds inaccessible
from the web staff client. This patch fixes that.

To test
-------
[1] From Administration | Local Administration, go to Group Penalty
    Thresholds. Note that the embedded Conify admin interface
    is not displayed and the URL changes to .../permission/grp_tree.
[2] Apply the patch and repeat step 1. This time, the admin interface
    should appear.
[3] Verify that the Permission Group Tree Entries interface remains
    accessible from Local Administration.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoLP1734775: Show multiple items in Item Status
Jason Boyer [Thu, 17 Jan 2019 14:58:08 +0000 (09:58 -0500)]
LP1734775: Show multiple items in Item Status

The ListCtrl controller was only displaying a single
copy when an id list was passed to Item Status in the
URL. This branch separates each id into a separate
fetch call and when all have been resolved it
refreshes the grid, which now has all of the items.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoLP1721109: Update item status when holdings are edited
Jane Sandberg [Sat, 2 Mar 2019 01:03:31 +0000 (17:03 -0800)]
LP1721109: Update item status when holdings are edited

To test:
1) Go to Item Status List View, select an item, and go to Actions >
Edit > Items (or Call Numbers, or both).
2) Make a change to one of the columns you have active in
the Item Status list view. Click Save and Exit.
3) Note that the list view of Item Status has not updated.
4) Load this commit.
5) Repeat steps 1-2.
6) Note that the columns are updated this time.  Note that
there is a new status column, and that an icon appears for
all the rows that you have changed.  Also, note that there
is a toast message in the bottom right hand corner of the
screen confirming that you have successfully made your change.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoLP #1705497 Replaces functionality in web client from legacy
Adam Bowling [Thu, 7 Mar 2019 04:06:09 +0000 (23:06 -0500)]
LP #1705497 Replaces functionality in web client from legacy
XUL client by including a find function for originating
acquisition where it exists.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoDocs: Fixing broken link
Jane Sandberg [Thu, 7 Mar 2019 15:14:50 +0000 (07:14 -0800)]
Docs: Fixing broken link

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 years agoLP#1800178 Holdings View should also sort by part
Remington Steed [Fri, 26 Oct 2018 15:28:32 +0000 (11:28 -0400)]
LP#1800178 Holdings View should also sort by part

The Holdings View tab of the web client doesn't correctly sort by
monograph parts. The JS is already grabbing the part label for display,
so this commit moves that chunk before the sorting code, and also grabs
the sort key. Note that the part labels and sort keys are joined per
item, since the database supports multiple parts per item (though the UI
hasn't yet supported that). And we now join the label on comma-space,
instead of the default (just a comma).

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP1818153 Stamping DB upgrade - WS user activity
Bill Erickson [Tue, 5 Mar 2019 17:21:00 +0000 (12:21 -0500)]
LP1818153 Stamping DB upgrade - WS user activity

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoLP1818153 Log user activity for websocket login/verify
Bill Erickson [Thu, 28 Feb 2019 22:20:31 +0000 (17:20 -0500)]
LP1818153 Log user activity for websocket login/verify

Adds support for logging additional user activity types:

 * websocket v1 login (apache2-websockets)
 * websocket v2 login (websocketd)
 * websocket v1 verify
 * websocket v2 verify
 * generic login (any ingress)
 * generic verify (any ingress)

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
6 years agoLP#1746360 Add Deleted Column to Record Bucket
Terran McCanna [Tue, 5 Mar 2019 15:50:59 +0000 (10:50 -0500)]
LP#1746360 Add Deleted Column to Record Bucket

This adds the Deleted column to the Record Bucket view.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoLP#1667497 - Define $params{depth} to avoid uninitialized warning.
Josh Stompro [Mon, 4 Mar 2019 14:57:02 +0000 (08:57 -0600)]
LP#1667497 - Define $params{depth} to avoid uninitialized warning.

$depth is set to 0 if $params{depth} is unset, but then $params{depth}
gets used later on, which causes an uninitialized value warning.

So set $params{depth} to whatever $depth was set to.

Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
6 years agoForward-port 3.2.4 upgrade script
Dan Wells [Thu, 28 Feb 2019 20:59:26 +0000 (15:59 -0500)]
Forward-port 3.2.4 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoTranslation updates - po files
Dan Wells [Tue, 26 Feb 2019 18:15:52 +0000 (13:15 -0500)]
Translation updates - po files

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoTranslation updates - newpot
Dan Wells [Tue, 26 Feb 2019 18:13:13 +0000 (13:13 -0500)]
Translation updates - newpot

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoDocs: Adding release notes for 3.2.4
Jane Sandberg [Fri, 22 Feb 2019 21:15:56 +0000 (13:15 -0800)]
Docs: Adding release notes for 3.2.4

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>