working/Evergreen.git
4 years agoschema: adjust fund transfer notes
Galen Charlton [Wed, 2 Jun 2021 20:21:24 +0000 (16:21 -0400)]
schema: adjust fund transfer notes

- Change allocation notes to

Now Transfer {to,from} FUND_CODE (YEAR) (FUND_ORG_UNIT_SHORTNAME)

- Fix issue where the fund org units were not being retrieved
  correctly, leading to incorrect or missing fund allocation notes

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoEDI attr sets: change styling of buttons
Galen Charlton [Wed, 2 Jun 2021 15:48:39 +0000 (11:48 -0400)]
EDI attr sets: change styling of buttons

Addresses LH#51

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agocurrency: change styling of buttons
Galen Charlton [Wed, 2 Jun 2021 15:48:25 +0000 (11:48 -0400)]
currency: change styling of buttons

Addresses LH#51

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoformat: switch from CurrencyPipe to DecimalPipe
Galen Charlton [Tue, 1 Jun 2021 22:23:36 +0000 (18:23 -0400)]
format: switch from CurrencyPipe to DecimalPipe

CurrencyPipe has no easy way of displaying the monetary amount
without a currency symbol, which means that currency amounts
display with a dollar sign -- which isn't a univeral assumption
for Evergreen.

Future work is indicated to (a) teach Evergreen a global flag
or a library setting for the system's base currency and (b) let
the format service be passed a currency code. Once both are in place,
CurrencyPipe can be restored.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agofunds: fix styling and required checks of the fund transfer dialog
Galen Charlton [Tue, 1 Jun 2021 22:01:09 +0000 (18:01 -0400)]
funds: fix styling and required checks of the fund transfer dialog

Resolves LH#44

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agocombobox: add a 'mandatory' attribute
Galen Charlton [Tue, 1 Jun 2021 21:59:49 +0000 (17:59 -0400)]
combobox: add a 'mandatory' attribute

This is a synonym of the 'required' attribute, as overloading
the HTML5 required attribute can lead the colored left border
indicated the state of the weidget extending to the container
of the combobox

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoIDL: change "Claim Policy ID" to "Claim Policy"
Galen Charlton [Tue, 1 Jun 2021 21:37:56 +0000 (17:37 -0400)]
IDL: change "Claim Policy ID" to "Claim Policy"

Resolves LH#27

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agofunds: restrict fund selection for allocation to active funds
Galen Charlton [Tue, 20 Apr 2021 22:28:46 +0000 (18:28 -0400)]
funds: restrict fund selection for allocation to active funds

Also pre-load values.

LH#34

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agofm-editor: add a linkedSearchConditions field option
Galen Charlton [Tue, 20 Apr 2021 21:57:08 +0000 (17:57 -0400)]
fm-editor: add a linkedSearchConditions field option

This option allows the caller to specify conditions to add
when retrieving values for a linked field, e.g., to specify
that only active values should be fetched.

Example usage:

[fieldOptions]="{fund:{linkedSearchConditions:{'active':'t'}}}"

If the underlying record has a value set for the linked field, that
value will be included when preloadLinkedValues and the value
doesn't otherwise meet the search conditions.

This patch also sorts the values if preloadLinkedValues is used.

TODO: add a limit condition?

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agodistribution formulas: link OU and item location selectors to correct permission
Galen Charlton [Tue, 20 Apr 2021 21:02:36 +0000 (17:02 -0400)]
distribution formulas: link OU and item location selectors to correct permission

LH#41 and LH#42

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoitem-location-select: when using permFilter, include locations at ancestors of permit...
Galen Charlton [Tue, 20 Apr 2021 21:00:26 +0000 (17:00 -0400)]
item-location-select: when using permFilter, include locations at ancestors of permitted OUs

LH#41

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agofunds: apply negative-money-amount styling to fund details dialog
Galen Charlton [Tue, 20 Apr 2021 16:04:59 +0000 (12:04 -0400)]
funds: apply negative-money-amount styling to fund details dialog

LH#10

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agogrid: define style for negative money values
Galen Charlton [Tue, 20 Apr 2021 15:44:33 +0000 (11:44 -0400)]
grid: define style for negative money values

Currently all that the negative-money-amount class does is color
the text red.

Part of LH#10

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoIDL: change label of OU column to "Owner" for claiming config tabs
Galen Charlton [Mon, 19 Apr 2021 22:03:00 +0000 (18:03 -0400)]
IDL: change label of OU column to "Owner" for claiming config tabs

Extends idea in LH#43

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoIDL: change label of org column to "Owner" for fund-related tables and views
Galen Charlton [Mon, 19 Apr 2021 22:00:36 +0000 (18:00 -0400)]
IDL: change label of org column to "Owner" for fund-related tables and views

LH#43

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agofunds: group actions for the funding sources grid
Galen Charlton [Mon, 19 Apr 2021 21:57:27 +0000 (17:57 -0400)]
funds: group actions for the funding sources grid

LH#35

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agofunds: set double-click-on-row handlers for funds and funding sources
Galen Charlton [Mon, 19 Apr 2021 21:31:22 +0000 (17:31 -0400)]
funds: set double-click-on-row handlers for funds and funding sources

Both opening the edit dialog for sake of consistency, although for the funds
page the fund details dialog might be a better choice.

Extends fix for LH#11

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoEDI attr sets: fix behavior on row double-click
Galen Charlton [Mon, 19 Apr 2021 21:25:59 +0000 (17:25 -0400)]
EDI attr sets: fix behavior on row double-click

Extends fix for LH#11

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agodistribution formulas: double-click now activates custom edit modal
Galen Charlton [Mon, 19 Apr 2021 21:23:38 +0000 (17:23 -0400)]
distribution formulas: double-click now activates custom edit modal

LH#11

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoAdminPageComponent: move onRowActivate subscription to markup
Galen Charlton [Mon, 19 Apr 2021 21:21:39 +0000 (17:21 -0400)]
AdminPageComponent: move onRowActivate subscription to markup

This allows extenders of this interface to set their own non-default
handlers

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agodistribution formulas: remove skip count from form
Galen Charlton [Mon, 19 Apr 2021 20:46:23 +0000 (16:46 -0400)]
distribution formulas: remove skip count from form

LH#18

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agodistribution formulas: don't permit negative item count
Galen Charlton [Mon, 19 Apr 2021 20:45:21 +0000 (16:45 -0400)]
distribution formulas: don't permit negative item count

LH#18

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agofunds: fix default tab logic
Galen Charlton [Mon, 19 Apr 2021 20:37:52 +0000 (16:37 -0400)]
funds: fix default tab logic

Closes LH#5 and LH#6

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoIDL: mark acqf.fund as mandatory
Galen Charlton [Fri, 16 Apr 2021 21:00:24 +0000 (17:00 -0400)]
IDL: mark acqf.fund as mandatory

LH#7

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoschema: make fund.code NOT NULL
Galen Charlton [Fri, 16 Apr 2021 20:59:51 +0000 (16:59 -0400)]
schema: make fund.code NOT NULL

Any funds whose code was null will have it set to "FUND-WITH-ID-$id"

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agofunds: set label of funding_source_credit in the transfers tab
Galen Charlton [Fri, 16 Apr 2021 20:51:16 +0000 (16:51 -0400)]
funds: set label of funding_source_credit in the transfers tab

LH#29

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agocurrencies: do not allow changing code when editing currency
Galen Charlton [Fri, 16 Apr 2021 20:31:36 +0000 (16:31 -0400)]
currencies: do not allow changing code when editing currency

Database is not set up to propagate code changes.

LH#39

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoEDI attr sets: clone action active only when exactly one row is selected
Galen Charlton [Fri, 16 Apr 2021 20:17:41 +0000 (16:17 -0400)]
EDI attr sets: clone action active only when exactly one row is selected

LH#40

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agocurrencies: sort exchange rates dialog by to-currency code
Galen Charlton [Thu, 15 Apr 2021 22:22:56 +0000 (18:22 -0400)]
currencies: sort exchange rates dialog by to-currency code

LH#38

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoacq splash/funds: tweak Fund Administration label
Galen Charlton [Thu, 15 Apr 2021 21:55:14 +0000 (17:55 -0400)]
acq splash/funds: tweak Fund Administration label

LH#19

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoEDI attr sets: make two columns non-sortable, non-filterable
Galen Charlton [Thu, 15 Apr 2021 21:53:35 +0000 (17:53 -0400)]
EDI attr sets: make two columns non-sortable, non-filterable

Part of LH#23

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agocurrencies: make exchange rates column nonsortable, nonfilterable
Galen Charlton [Thu, 15 Apr 2021 21:51:13 +0000 (17:51 -0400)]
currencies: make exchange rates column nonsortable, nonfilterable

Part of LH#23

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agocurrencies: tweak cannot-delete error message
Galen Charlton [Thu, 15 Apr 2021 21:48:56 +0000 (17:48 -0400)]
currencies: tweak cannot-delete error message

LH#37

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoclaims: adjust tab order
Galen Charlton [Thu, 15 Apr 2021 21:47:44 +0000 (17:47 -0400)]
claims: adjust tab order

LH#26

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agofunds: fix wrong toast upon adding tag
Galen Charlton [Wed, 7 Apr 2021 22:04:11 +0000 (18:04 -0400)]
funds: fix wrong toast upon adding tag

Addresses LH#17

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agofunds: change banner and title of Fund Administration page
Galen Charlton [Wed, 7 Apr 2021 22:02:34 +0000 (18:02 -0400)]
funds: change banner and title of Fund Administration page

Addresses LH#19

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agofunds: include time in various timestamp fields
Galen Charlton [Wed, 7 Apr 2021 21:59:06 +0000 (17:59 -0400)]
funds: include time in various timestamp fields

Addresses LH#8

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoadjust labels for fund allocation and fund debit times
Galen Charlton [Wed, 7 Apr 2021 21:49:55 +0000 (17:49 -0400)]
adjust labels for fund allocation and fund debit times

address LH#9

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agodistribution formula: adjust width of columns
Galen Charlton [Tue, 6 Apr 2021 20:54:14 +0000 (16:54 -0400)]
distribution formula: adjust width of columns

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agocombobox: include org unit in label for acqf
Galen Charlton [Tue, 6 Apr 2021 20:53:14 +0000 (16:53 -0400)]
combobox: include org unit in label for acqf

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agofunds: fix errors that ng build --prod caught
Galen Charlton [Mon, 29 Mar 2021 22:31:58 +0000 (18:31 -0400)]
funds: fix errors that ng build --prod caught

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agofunds: fix lint
Galen Charlton [Mon, 29 Mar 2021 15:48:46 +0000 (11:48 -0400)]
funds: fix lint

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoEDI attr sets: fix lint
Galen Charlton [Mon, 29 Mar 2021 15:48:32 +0000 (11:48 -0400)]
EDI attr sets: fix lint

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agodistribution formulas: fix lint
Galen Charlton [Mon, 29 Mar 2021 15:48:18 +0000 (11:48 -0400)]
distribution formulas: fix lint

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agocurrencies: fix lint
Galen Charlton [Mon, 29 Mar 2021 15:48:03 +0000 (11:48 -0400)]
currencies: fix lint

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoLP#XXX: seed data: acq admin: add grid config settings
Galen Charlton [Mon, 29 Mar 2021 02:50:42 +0000 (22:50 -0400)]
LP#XXX: seed data: acq admin: add grid config settings

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoLP#XXX: new currency and exchange rates interface
Galen Charlton [Fri, 26 Mar 2021 22:21:30 +0000 (18:21 -0400)]
LP#XXX: new currency and exchange rates interface

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoLP#XXX: new distribution formulas interface
Galen Charlton [Fri, 26 Mar 2021 22:13:01 +0000 (18:13 -0400)]
LP#XXX: new distribution formulas interface

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoLP#XXX: EDI attr sets interface
Galen Charlton [Fri, 26 Mar 2021 21:58:51 +0000 (17:58 -0400)]
LP#XXX: EDI attr sets interface

Note the TODO about the onRowActivate subscription, which will require
a change to the base component

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoLP#XXX: (funds) Angular funds interface
Galen Charlton [Wed, 3 Mar 2021 23:25:40 +0000 (18:25 -0500)]
LP#XXX: (funds) Angular funds interface

TODO: uses current calendar year by default; a more sophisticated
      approach would check the fiscal calendar that applies to
      the workstation

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoLP#XXX: schema: change automatically-generated fund allocation notes for transfers
Galen Charlton [Wed, 24 Mar 2021 20:12:17 +0000 (16:12 -0400)]
LP#XXX: schema: change automatically-generated fund allocation notes for transfers

Now Transfer {to,from} FUND_ORG_UNIT_SHORTNAME FUND_CODE (YEAR)

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoLP#XXX: fm-edit: teach how to format selectors when wiring up comoboxes
Galen Charlton [Sun, 28 Mar 2021 17:38:55 +0000 (13:38 -0400)]
LP#XXX: fm-edit: teach how to format selectors when wiring up comoboxes

Matches similar functionality in combobox

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoLP#XXX: grid: teach grid columns how to start with a filter set
Galen Charlton [Thu, 25 Mar 2021 17:44:44 +0000 (13:44 -0400)]
LP#XXX: grid: teach grid columns how to start with a filter set

This adds initialFilterOperator and initialFilterValue inputs
to eg-grid-column to specify that the data set should start off
with a column filter set.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoLP#XXX: IDL: EDI attr sets: add edi_accounts virtual field to aeas
Galen Charlton [Sat, 27 Mar 2021 21:00:02 +0000 (17:00 -0400)]
LP#XXX: IDL: EDI attr sets: add edi_accounts virtual field to aeas

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoLP#XXX: IDL: add acqftr to pcrud
Galen Charlton [Tue, 16 Mar 2021 22:00:24 +0000 (18:00 -0400)]
LP#XXX: IDL: add acqftr to pcrud

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoLP#XXX: IDL: mark some fund columns required
Galen Charlton [Tue, 16 Mar 2021 17:01:43 +0000 (13:01 -0400)]
LP#XXX: IDL: mark some fund columns required

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoLP#XXX: consolidate claiming administration into single page
Galen Charlton [Tue, 2 Mar 2021 22:54:17 +0000 (17:54 -0500)]
LP#XXX: consolidate claiming administration into single page

This patch consolidates the following acquisitions administration
interfaces into a single tabbed page for managing claiming
policies:

- Claim Event Types
- Claim Policies
- Claim Policy Actions
- Claim Types

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoLP1873322: Angular Admin Pages default to workstation OU
Jane Sandberg [Wed, 10 Feb 2021 19:51:55 +0000 (11:51 -0800)]
LP1873322: Angular Admin Pages default to workstation OU

To test:

1) Apply this patch.
2) Log in using a workstation at a particular org unit.
3) Open some of the following admin pages:

Local Admin > Address Alerts
Local Admin > Carousels
Local Admin > Group Penalty Thresholds
Local Admin > Course Reserves List > Terms Tab
Server Admin > Billing Types
Server Admin > Call Number/Volume Suffixes
Server Admin > Copy Tags
Server Admin > Hard Due Date Configuration
Acquisitions Admin > Cancel Reason Configuration
Acquisitions Admin > Claim Policies
Booking Admin > Resource Types
Booking Admin > Resource Attribute Values

4) Verify that these pages automatically open to your
workstation's org unit.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
4 years agoLP#1915323 Angular Staff Client Hamburger Menu Clipped Off Screen
Dan Briem [Wed, 3 Mar 2021 22:11:44 +0000 (17:11 -0500)]
LP#1915323 Angular Staff Client Hamburger Menu Clipped Off Screen

Aligns navbar corner dropdown menu to the right to prevent it
from clipping off-screen.

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
4 years agoLP#1917804: only show MARC 500 data in the General Note field
Jeff Davis [Tue, 16 Mar 2021 22:29:36 +0000 (15:29 -0700)]
LP#1917804: only show MARC 500 data in the General Note field

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Stephenson <jason@sigio.com>
4 years agoStamping upgrade script
Jane Sandberg [Tue, 16 Mar 2021 20:19:09 +0000 (13:19 -0700)]
Stamping upgrade script

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 years agoLP1896840 Publisher display includes 264 tag
Bill Erickson [Thu, 24 Sep 2020 15:46:58 +0000 (11:46 -0400)]
LP1896840 Publisher display includes 264 tag

The stock Publisher display field now extracts data from 260 OR 264
tags, whichever has a value first.

Release notes included with upgrade instructions.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 years agoLP1859513: In-house use link to item summary
Garry Collum [Wed, 17 Feb 2021 19:56:38 +0000 (14:56 -0500)]
LP1859513: In-house use link to item summary

Adds a link from the item's barcode in the in-house checkin screen to the item summary screen.

To test:
Type an item barcode into the In-House Use screen. Click on the barcode that displays in the item list.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
4 years agoLP#1424815: adjust release notes
Galen Charlton [Mon, 15 Mar 2021 21:37:19 +0000 (17:37 -0400)]
LP#1424815: adjust release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoLP#1424815: 'Read more' accordion in record view
Kyle Huckins [Thu, 17 Jan 2019 19:32:45 +0000 (19:32 +0000)]
LP#1424815: 'Read more' accordion in record view

- Introduce custom accordion.JS to handle expand/truncation of
node information.
- Expansion/Truncation of individual nodes based on configurable
length.
- Refactor content.tt2 to properly display multiple notes with both
Read More and Highlighting features.
- Create accordion() macro in summary.tt2 to handle accordion-izing
a string when also supplied with a length, display field string,
and an optional highlighting boolean.
- Implementation of config.tt2 variables to handle enabling and length
requirements for truncation.
- Apply Read More to record Title as well as item details and graphics
text on record and search results.
- Teach Accordion functionality to understand blocks of HTML
- Add release notes for Read More functionality.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Ruth Fraser <rfrasur@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoRevert "LP#1424815: 'Read more' accordion in record view"
Galen Charlton [Mon, 15 Mar 2021 16:27:06 +0000 (12:27 -0400)]
Revert "LP#1424815: 'Read more' accordion in record view"

This reverts commit 9561b5736eadfa9325015676bc64e628d9f72be4.

Pushed by accident.

4 years agoRevert "Revert "LP#705693: add release notes entry""
Galen Charlton [Mon, 15 Mar 2021 16:24:30 +0000 (12:24 -0400)]
Revert "Revert "LP#705693: add release notes entry""

This reverts commit b3695a6fb79eca1c450bcc932734da71813f493e.

Pushed by accident.

4 years agoRevert "LP#705693: add release notes entry"
Galen Charlton [Mon, 15 Mar 2021 16:23:54 +0000 (12:23 -0400)]
Revert "LP#705693: add release notes entry"

This reverts commit dd61efc0e4b96627d5cc4ac96d472273e9da253f.

4 years agoLP#1424815: 'Read more' accordion in record view
Kyle Huckins [Thu, 17 Jan 2019 19:32:45 +0000 (19:32 +0000)]
LP#1424815: 'Read more' accordion in record view

- Introduce custom accordion.JS to handle expand/truncation of
node information.
- Expansion/Truncation of individual nodes based on configurable
length.
- Refactor content.tt2 to properly display multiple notes with both
Read More and Highlighting features.
- Create accordion() macro in summary.tt2 to handle accordion-izing
a string when also supplied with a length, display field string,
and an optional highlighting boolean.
- Implementation of config.tt2 variables to handle enabling and length
requirements for truncation.
- Apply Read More to record Title as well as item details and graphics
text on record and search results.
- Teach Accordion functionality to understand blocks of HTML
- Add release notes for Read More functionality.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Util.pm
modified:   Open-ILS/src/templates/opac/css/style.css.tt2
modified:   Open-ILS/src/templates/opac/i18n_strings.tt2
modified:   Open-ILS/src/templates/opac/parts/config.tt2
modified:   Open-ILS/src/templates/opac/parts/js.tt2
modified:   Open-ILS/src/templates/opac/parts/misc_util.tt2
modified:   Open-ILS/src/templates/opac/parts/record/authors.tt2
modified:   Open-ILS/src/templates/opac/parts/record/contents.tt2
modified:   Open-ILS/src/templates/opac/parts/record/summary.tt2
modified:   Open-ILS/src/templates/opac/parts/result/table.tt2
new file:   Open-ILS/web/js/ui/default/opac/accordion.js
new file:   docs/RELEASE_NOTES_NEXT/OPAC/read-more-feature.adoc

Signed-off-by: Ruth Fraser <rfrasur@gmail.com>
Signed-off-by: Michele <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoLP#705693: add release notes entry
Galen Charlton [Mon, 15 Mar 2021 16:14:27 +0000 (12:14 -0400)]
LP#705693: add release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoLP#705693 Check Number in Bill History
Dan Briem [Tue, 8 Dec 2020 20:42:48 +0000 (15:42 -0500)]
LP#705693 Check Number in Bill History

Adds the check number field to the Bill History payment grids
(hidden by default).

To test:
1. Bill patron and apply a check payment with a check number
2. Go to Bills->History->Payments and note check number is not
   an option (drop-down on top-right of grid shows the list)
3. Right-click the payment line->Full Details->Details and note
   check number is not an option on the bottom payments grid
4. Apply patch (may need to clear cache especially on Firefox)
5. Repeat steps 2-3 and note check number is an available option

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoLP#1174498: stamp schema update
Galen Charlton [Mon, 15 Mar 2021 16:01:37 +0000 (12:01 -0400)]
LP#1174498: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoLP#1174498: (follow-up) reformat release notes
Galen Charlton [Mon, 15 Mar 2021 15:57:48 +0000 (11:57 -0400)]
LP#1174498: (follow-up) reformat release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoLP1174498: Add Release Note
Jason Boyer [Thu, 3 Sep 2020 17:15:51 +0000 (13:15 -0400)]
LP1174498: Add Release Note

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Katie Greenleaf Martin <bcl@blaircountylibraries.org>
Signed-off-by: Elizabeth Davis <edavis@albright.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoLP1174498: IDL changes for Payments by Billing Type
blake [Thu, 3 Sep 2020 14:54:37 +0000 (10:54 -0400)]
LP1174498: IDL changes for Payments by Billing Type

Add the mmpbbt class to make use of the new view.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Katie Greenleaf Martin <bcl@blaircountylibraries.org>
Signed-off-by: Elizabeth Davis <edavis@albright.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoLP1174498: Add a Payments by Billing Type Reporting View
blake [Thu, 3 Sep 2020 14:46:15 +0000 (10:46 -0400)]
LP1174498: Add a Payments by Billing Type Reporting View

This is an updated version of the initial concept by Mike
Rylander with input from Jeff Godin. This view connects
payments to specific billings and allows reports to be
written to determine how accepted payments were distributed
by billing type.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Katie Greenleaf Martin <bcl@blaircountylibraries.org>
Signed-off-by: Elizabeth Davis <edavis@albright.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoLP#1830960: update release notes to account for Bootstrap
Galen Charlton [Mon, 15 Mar 2021 15:51:22 +0000 (11:51 -0400)]
LP#1830960: update release notes to account for Bootstrap

Now that the Bootstrap skin is the default, this patch is
mostly of interest to current users of TPAC, including consortia
that may add new members before switching to the Bootstrap
skin.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agolp1830960 adding more customizing options to opac colors, found issue in old patch...
Rogan Hamby [Tue, 30 Jul 2019 18:42:30 +0000 (14:42 -0400)]
lp1830960 adding more customizing options to opac colors, found issue in old patch plus added docs

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoadding more colors and style.css changes to make them usable to ease customizations
Rogan Hamby [Wed, 29 May 2019 18:01:38 +0000 (14:01 -0400)]
adding more colors and style.css changes to make them usable to ease customizations

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agolP#1863252: (follow-up) fix Angular lint
Galen Charlton [Mon, 15 Mar 2021 15:00:23 +0000 (11:00 -0400)]
lP#1863252: (follow-up) fix Angular lint

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoLP#1893997: stamp schema update
Galen Charlton [Mon, 15 Mar 2021 14:57:19 +0000 (10:57 -0400)]
LP#1893997: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoLP#1893997: mention new settings in the release notes
Galen Charlton [Mon, 15 Mar 2021 14:54:18 +0000 (10:54 -0400)]
LP#1893997: mention new settings in the release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoLP#1893997: (follow-up) fix typos in release notes
Galen Charlton [Mon, 15 Mar 2021 14:51:20 +0000 (10:51 -0400)]
LP#1893997: (follow-up) fix typos in release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoLP#1893997: fix a couple minor thinkos in the upgrade
Galen Charlton [Mon, 15 Mar 2021 14:37:10 +0000 (10:37 -0400)]
LP#1893997: fix a couple minor thinkos in the upgrade

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoLP#1893997: Did You Mean release notes
Mike Rylander [Fri, 12 Mar 2021 21:02:04 +0000 (16:02 -0500)]
LP#1893997: Did You Mean release notes

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoLP#1893997: Did you mean? Single word, single class
Mike Rylander [Thu, 24 Sep 2020 16:48:41 +0000 (12:48 -0400)]
LP#1893997: Did you mean? Single word, single class

This commit embodies the first stage of a larger search suggestion
project.  The bulk of the code is dedicated to providing an
implementation of the SymSpell[1] algorithm as the basis for very fast
word similarity testing for spelling suggestions as well as alternate
search suggestions.

The native in-memory algorithm specifies a hash table lookup using a
runtime-created dictionary.  As it is untenable to create and maintain a
separate in-memory data structure in the distributed environment that
OpenSRF provides, and adds significantly to the administrative complexity
of such a configuration, we instead maintain a dictionary in the
authoritative Postgres database used by Evergreen.  This dictionary is
based directly on indexed terms used for general search, and aims to
avoid zero-hit suggestions wherever possible while imposing as little
performance impact as can be managed.

In addition to the core SymSpell similarity metric, Damerau-Levenshtein
edit distance, we provide Soundex, Trigram, and QWERTY Keyboard
similarity measures.  The importance of these can be adjusted relative
to one another, or turned off individually.

Global term frequncey data is captured for each of the Evergreen search
classes and is used to help decide when to use specific terms, and which
terms to use as suggestions.

Suggestions are provide in the OPAC, including the staff-embedded OPAC
view, the KPAC, and the Angular catalog.

Later development will add the ability to perform mult-word and
phrase-oriented suggestions, to suggest searching requested terms in
other search classes, and provide local thesaurus values and exclusion
term lists.

[1] https://medium.com/@wolfgarbe/1000x-faster-spelling-correction-algorithm-2012-8701fcd87a5f

NOTE: This development adds two new Perl module dependencies, and will
therefore require a dependency update at upgrade time.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoLP1907979: Fix Search by Instructor setting lookup in OPAC
Jane Sandberg [Fri, 18 Dec 2020 16:57:04 +0000 (08:57 -0800)]
LP1907979: Fix Search by Instructor setting lookup in OPAC

Previously, the Search Courses screen in the OPAC relied on a locg
param in the URL to determine whether or not to display the "Search
by Instructor option", defaulting to location id 1 if no such param
exists.  However, we can also consult physical_loc and other settings
to get a more accurate idea of which library's setting we need here.

To test:
1) In the Library settings editor, set Course Materials Module Opt In
to true for BR1.
2) In the Library settings editor, set Search by Instructor to true
for BR1.
3) In eg.conf, add the line:
    SetEnv physical_loc 4
4) Restart httpd
5) Go to your OPAC.  Note that the OPAC is at the BR1 level, and that
course search and browse options are available.
6) Click Search courses.
7) Note that only two values are available in the qtype dropdown: Course
Name and Course Number.
8) Apply this patch.
9) Repeat steps 5-6.
10) Note that the screen now appropriately consults the value for the
"Search by Instructor" setting at the BR1 level, with an "Instructor"
value now available in the qtype dropdown.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoLP1908616 Add email display to hold edit
Terran McCanna [Mon, 4 Jan 2021 20:09:15 +0000 (15:09 -0500)]
LP1908616 Add email display to hold edit

Note: This is built atop the patch for LP1902265

This display's the current email address (or note if there
is no address) on the Edit Hold page of My Account in the
Bootstrap OPAC.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
4 years agoRevert the effects of both LP1687545 and LP1914116
Jason Boyer [Fri, 12 Mar 2021 19:02:19 +0000 (14:02 -0500)]
Revert the effects of both LP1687545 and LP1914116

Revert "LP1687545: Force TT CGI plugin to use ampersands in query strings"
and "LP1914116: Apply html filter to mkurl() output"
until a fix for LP1918470 is available.

Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
4 years agoMinor mis-merge for geosort, missing comma in INSERT VALUES list addition.
Mike Rylander [Thu, 11 Mar 2021 23:13:19 +0000 (18:13 -0500)]
Minor mis-merge for geosort, missing comma in INSERT VALUES list addition.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoLP1863252 Stamping DB Upgrade: Geosort
Bill Erickson [Thu, 11 Mar 2021 20:59:31 +0000 (15:59 -0500)]
LP1863252 Stamping DB Upgrade: Geosort

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1863252 Geosort - add dropped END tag
Terran McCanna [Fri, 19 Feb 2021 21:35:45 +0000 (16:35 -0500)]
LP1863252 Geosort - add dropped END tag

This adds back an END tag in the boostrap copy_table.tt2
that got lost.

Note that in order to fully test this in bootstrap, I had to
add the fix included here as well:
https://bugs.launchpad.net/evergreen/+bug/1916085

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
4 years agolp1863252 fix Get Coordinates button in org admin
Jason Etheridge [Fri, 19 Feb 2021 05:29:13 +0000 (00:29 -0500)]
lp1863252 fix Get Coordinates button in org admin

The underlying method can now handle org objects or org id's, and the UI
will also alert the user with any non-catastrophic error such as the location
not being found.

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agolp1863252 make Geo::Coder::Free optional
Jason Etheridge [Tue, 9 Feb 2021 16:38:22 +0000 (11:38 -0500)]
lp1863252 make Geo::Coder::Free optional

Restore Geo::Coder::Google to the CPAN module list and remove the Googlev3 package.

Geo::Coder::Google requires an API key, and Geo::Coder::Googlev3 purports not to
but is currently giving a REQUEST_DENIED to requests and is a known issue.

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoLP#1863252 - Use APT for Perl dependencies where possible.
Chris Sharp [Fri, 5 Feb 2021 19:01:06 +0000 (14:01 -0500)]
LP#1863252 - Use APT for Perl dependencies where possible.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agolp1863252 fix unrelated issue that was breaking display of the copy_table
Galen Charlton [Wed, 16 Dec 2020 16:10:20 +0000 (11:10 -0500)]
lp1863252 fix unrelated issue that was breaking display of the copy_table

Without this, lack of a 'loc' CGI parameter breaks the page. This
was introduced in the course materials work and just appears to be wrong,
but should be double-checked.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agolp1863252 toward geosort
Galen Charlton [Tue, 15 Dec 2020 23:07:00 +0000 (18:07 -0500)]
lp1863252 toward geosort

* fix swap of lat/lon that broke Math::Trig-based distance calculations
  TODO: might want to drop that entirely in favor of delegating to a DB
  call that uses earthdistance
* first pass at implementing display of distance in the OPAC
* include "Distance" label on mobile view of copy table
* display warning if address input is not translated to coordinates
* add distance column to TPAC copy table
* add default item sort button to both TPAC and Bootstrap
* changes to open-ils.geo registration
  - don't register with the public router
  - add to param redaction list
* add temporary caching of address => coordinates results
  By default, coordinates are cached in memcached for 5 minutes. The
  cache key is derived from a SHA-2 hash of the input address.
* implement query parameter log redaction as a PerLogHandler
* Don't need perl-script for a PerlLogHandler

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agolp1863252 toward geosort
Mike Rylander [Thu, 10 Dec 2020 21:41:24 +0000 (16:41 -0500)]
lp1863252 toward geosort

* Add earthdistance-based org ranking
* Accept user input and get best-guess coordinates from that

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agolp1863252 toward geosort
Jason Etheridge [Thu, 3 Dec 2020 15:08:44 +0000 (10:08 -0500)]
lp1863252 toward geosort

From the release notes:

Sort Holdings by Geographical Proximity
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This functionality integrates 3rd party geographic lookup services to allow patrons
to enter an address on the record details page in the OPAC and sort the holdings
for that record based on proximity of their circulating libraries to the entered
address. To support this, latitude and longitude coordinates may be associated with
each org unit. Care is given to not log or leak patron provided addresses or the
context in which they are used.

squashed commits:

* actor.org_address
* config.geolocation_service
* config.global_flag
* opac.holdings_sort_by_geographic_proximity OUS
* opac.geographic_proximity_in_miles OUS
* opac.geographic_location_service_for_address
* permission.perm_list
* Geo.pm, opensrf*.xml, ils_events.xml
* Org Unit Configuration
* OPAC Record Details
* release notes
* remove base_url
* provide an open-ils.actor wrapper for open-ils.geo.retrieve_coordinates
* some error trapping
  This will throw the GEOCODING_LOCATION_NOT_FOUND event for a wider range of problems.
  With the Google service, you can test by providing a bad API key or sending the
  copyright symbol as an address to lookup.
* distribute permissions to stock perm groups
* prerequisite cpan modules
* live_t/ tests

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
4 years agoLP#1815815: stamp schema update
Galen Charlton [Thu, 11 Mar 2021 18:45:55 +0000 (13:45 -0500)]
LP#1815815: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>