working/Evergreen.git
13 years agoStamping upgrade script for EDI cleanup
Mike Rylander [Mon, 26 Sep 2011 16:18:03 +0000 (12:18 -0400)]
Stamping upgrade script for EDI cleanup

Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoSome EDI translation fixes for troublesome input characters
Lebbeous Fogle-Weekley [Mon, 19 Sep 2011 17:19:22 +0000 (13:19 -0400)]
Some EDI translation fixes for troublesome input characters

This attempts to address enough of the issues in
https://bugs.launchpad.net/evergreen/+bug/812593 to move forward.

When the ? character appears in lineitem attributes for a PO that we
send off for EDI translation, the translator fails if that ? is the last
character of the string.  This commit avoids that situation.

This commit also removes any Unicode characters from the JEDI (the input
to the translator process), as they're not going to make it to the
EDIFACT output anyhow, and will just confound the translator.

This commit also pre-escapes quotation marks in lineitem attributes so
that we don't produce invalid JSON for our JEDI.

This commit also destroys the death star.

Seriously, the right way to fix some of the issues people have had is
for somebody to learn Ruby and to address them either in edi_webrick.rb, in
edi4r, or in openils-mapper (wherever the issues may be).  Working on
that.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoTPac: Page through search results on details page
Bill Erickson [Wed, 14 Sep 2011 18:25:41 +0000 (14:25 -0400)]
TPac: Page through search results on details page

Consistent with jspac, when you land on a record details page and you
got there from doing a search, let the user page through the search
results directly on the record detail page.

This also includes the necessary JS callbacks to support paging in the
staff client.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
13 years agoperl-parent prerequisite for RHEL. hope it's fine for centos :)
Jason Etheridge [Mon, 26 Sep 2011 15:04:12 +0000 (11:04 -0400)]
perl-parent prerequisite for RHEL. hope it's fine for centos :)

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoTPAC: Add some style to MFHD holdings summaries
Dan Scott [Mon, 19 Sep 2011 02:27:00 +0000 (22:27 -0400)]
TPAC: Add some style to MFHD holdings summaries

Simple grey background for the holdings summary header for each record;
add a TBODY element to the holdings table for validity; offset the MFHD
type by 1em to group entries under each holdings location.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoTPAC: Give MFHD summaries OU / depth awareness
Dan Scott [Mon, 19 Sep 2011 01:12:23 +0000 (21:12 -0400)]
TPAC: Give MFHD summaries OU / depth awareness

Rather than returning all results and filtering on the client-side, as
we're currently doing in the JSPAC, teach the
open-ils.search.serial.record.bib.retrieve method to accept optional OU
& OU depth arguments and do the filtering in the query; cuts down on
network traffic and should be generally more efficient.

Note that in the absence of an explicit "depth" CGI param,
EGCatLoader/Record currently defaults to a depth of "0"; we could
teach it to look up & cache the depth of the "loc" param for the sake of
convenience & arguably more accuracy.

Also note that the sub/dist serial approach probably needs to be taught
similar method-side filtering, but I hope more knowledgeable brains will
work out what should happen with ssub.holding_lib / sdist.owning_lib.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoTPAC: tentative MFHD display steps
Dan Scott [Sun, 18 Sep 2011 05:37:37 +0000 (01:37 -0400)]
TPAC: tentative MFHD display steps

Retrieve and display MFHD records in the TPAC, piggybacking on the
"Issues" twisty section.

TODO: Take org_unit & depth into account when deciding which MFHD
records to display. Right now we're just showing all of them.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agolp859190: make marc_stream_import always import non-matches
Galen Charlton [Sun, 25 Sep 2011 20:55:38 +0000 (16:55 -0400)]
lp859190: make marc_stream_import always import non-matches

Fixes regression of (implicit, undocumented) functionality
introduced in commit da3a45344205.  Current use case for
the streaming MARC importer for OCLC Connexion exports assumes
that non-matching records should always be added.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoFix: Current Bills thinks it is Bill History
Jeff Godin [Wed, 21 Sep 2011 20:41:19 +0000 (16:41 -0400)]
Fix: Current Bills thinks it is Bill History

This fixes LP 855894: Bills interface calls itself Bill History,
uses bills_historical receipt template

https://bugs.launchpad.net/evergreen/+bug/855894

At some point in development, the Current Bills and the Bill History
interface were in a unified file, with an xul_param of "current" used
to switch between the two.

Nothing currently sets the xul_param "current", so the Current Bills
interface (bill2.xul and bill2.js) was improperly:

* not hiding the xact_finish column
* using a caption label of "Bill History"
* using the bills_historical receipt template

The Bill History interface was okay -- "not current" was the default.

This commit removes the tests for xul_param('current') and uses the
appropriate code for each interface.

// this code in both bill2.js and bill_history.js:
var template = 'bills_historical';
if (xul_param('current')) template = 'bills_current';

// becomes:
var template = 'bills_current';    // in bill2.js
var template = 'bills_historical'; // in bill_history.js

Also: added missing staff.patron.bill_interface.caption.label entity

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoRemove the old bills interface.
Jeff Godin [Tue, 20 Sep 2011 18:41:10 +0000 (14:41 -0400)]
Remove the old bills interface.

Remove the old bills interface and references to it.

see https://bugs.launchpad.net/evergreen/+bug/854951

Also remove the XUL_PATRON_BILL_ALTERNATE_VIEW constant and the
bills_main_view receipt template, as they were only referenced
in bills.js.

The bills_main_view template will still persist in existing
workstation configurations until such time as we have code to
remove unused templates.

I made no effort to remove strings which may have only been used
by the old bills interface.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoTPac: repair IE check-all action on transaction list
Bill Erickson [Thu, 22 Sep 2011 20:55:50 +0000 (16:55 -0400)]
TPac: repair IE check-all action on transaction list

IE does not respond to 'onchange' for checkboxes?  Use onclick
instead...

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoStamped upgrade script for ACQ fund view repairs
Bill Erickson [Thu, 22 Sep 2011 15:10:09 +0000 (11:10 -0400)]
Stamped upgrade script for ACQ fund view repairs

At the heart of this change is the need to force acq.fund_debit_total to
return exactly 1 row per fund, instead of 1 per fund + encumbrance
value.  However, such a change required rearranging a number of
dependent views.

Also added acq.fund_spent_balance to the set of views that needs
dropping and re-building.

Minor SQL format change to match surrounding code in schema file

See also https://bugs.launchpad.net/evergreen/+bug/800477

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoAddresses LP#800477 where some acq views calculate the totals incorrectly or in unexp...
James Fournie [Mon, 19 Sep 2011 23:01:01 +0000 (16:01 -0700)]
Addresses LP#800477 where some acq views calculate the totals incorrectly or in unexpected ways.

Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoThe tpac should be SSL inside the staff client
Jason Etheridge [Thu, 22 Sep 2011 14:57:47 +0000 (10:57 -0400)]
The tpac should be SSL inside the staff client

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen
Jason Etheridge [Thu, 22 Sep 2011 14:38:48 +0000 (10:38 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen

13 years agoFix broken Work Log UI
Jason Etheridge [Thu, 22 Sep 2011 14:36:57 +0000 (10:36 -0400)]
Fix broken Work Log UI

Missed a map_row_to_columns when I was ripping those out in c9c05ce8e179d7a9d4325ac1f429e91fcfe7c9a0

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoTPac: credit card payment bug fixes / cleanup
Bill Erickson [Thu, 22 Sep 2011 14:27:11 +0000 (10:27 -0400)]
TPac: credit card payment bug fixes / cleanup

* Repaired bug with paying multiple transactions
* Replaced JS-based back/cancel navigation with a's
* Added some debug logging

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoTpac: better param array detection in mkurl()
Bill Erickson [Thu, 22 Sep 2011 14:20:27 +0000 (10:20 -0400)]
Tpac: better param array detection in mkurl()

Avoid propagating empty arrays as "ARRAY(JUNK)"

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoPassword resets: avoid run-on subjects
Dan Scott [Thu, 22 Sep 2011 05:11:06 +0000 (01:11 -0400)]
Password resets: avoid run-on subjects

The password reset template had a space on the first blank line after
the Subject: which lead to the first paragraph being tacked onto the
Subject line. Get rid of the space, and create an upgrade script ready
to roll.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoTPac: password reset honors success/error style
Bill Erickson [Tue, 20 Sep 2011 14:43:58 +0000 (10:43 -0400)]
TPac: password reset honors success/error style

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoTPac: integrated patron password reset
Bill Erickson [Mon, 19 Sep 2011 22:18:41 +0000 (18:18 -0400)]
TPac: integrated patron password reset

Port the existing password reset functionality into TPac.  This allows
us to leverage the TPac innards for localization.  It also means there's
one less moving part.  (and, incidentally, no more dojo for the form).

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoTpac: longer timeout for marc "expert" search
Bill Erickson [Fri, 16 Sep 2011 15:49:08 +0000 (11:49 -0400)]
Tpac: longer timeout for marc "expert" search

Since MARC searches can take a while, raise the default timeout from
1 minute to 2, with the option (at the API layer) of raising it to 5.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoAdd Toggle option to portal for TPac use
Thomas Berezansky [Wed, 21 Sep 2011 17:25:38 +0000 (13:25 -0400)]
Add Toggle option to portal for TPac use

In testing I didn't have to restart the staff client, but as constants.js
is loaded pretty much everywhere I have no clue where the URL array may
be stale.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoCreate preference for opac used in staff client
Thomas Berezansky [Wed, 21 Sep 2011 15:35:24 +0000 (11:35 -0400)]
Create preference for opac used in staff client

If enabled use the TPac. Otherwise JSPac.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoTPAC: Make "Sort by" select box match style of search bar
Dan Scott [Thu, 22 Sep 2011 02:36:09 +0000 (22:36 -0400)]
TPAC: Make "Sort by" select box match style of search bar

The "Sort by" select box in search results had a native widget style,
compared to the search widget styles of the search bar. A simple CSS
tweak makes it consistent.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoGroup "Sort by" and sort select box together user/dbs/tpac_fix_sort_by
Dan Scott [Thu, 22 Sep 2011 01:56:39 +0000 (21:56 -0400)]
Group "Sort by" and sort select box together

The sort select box was weirdly way over on the right. Fix that.

Also address slightly weird vertical alignment of some elements of the
results header bar.

Also use <label> to group the "sort by" with the select box; a bit
better for screen reasers.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoproperties in chrome:// return XHR status 0
Jason Etheridge [Wed, 21 Sep 2011 15:47:36 +0000 (11:47 -0400)]
properties in chrome:// return XHR status 0

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agobump xulrunner version
Jason Etheridge [Wed, 21 Sep 2011 15:16:08 +0000 (11:16 -0400)]
bump xulrunner version

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoLP#854760 messagecat fails with certain 404 pages
Jason Etheridge [Tue, 20 Sep 2011 14:52:02 +0000 (10:52 -0400)]
LP#854760 messagecat fails with certain 404 pages

We were failing to check the HTTP status on the underlying XHR requests.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoCan't have two identical IDs on the same page
Dan Scott [Sat, 17 Sep 2011 03:44:28 +0000 (23:44 -0400)]
Can't have two identical IDs on the same page

Nobody who cares about the pure Web experience ever noticed that this
page has two identical IDs. Chromium and other browsers complain,
though, so make them happy.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agofix Show in Catalog for part holds
Jason Etheridge [Tue, 30 Aug 2011 20:30:44 +0000 (16:30 -0400)]
fix Show in Catalog for part holds

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
13 years agomake it obvious that Request Type is required in Create Request dialog
Jason Etheridge [Fri, 9 Sep 2011 20:09:33 +0000 (16:09 -0400)]
make it obvious that Request Type is required in Create Request dialog

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoacq user requests link from patron display
Jason Etheridge [Thu, 28 Jul 2011 12:16:22 +0000 (08:16 -0400)]
acq user requests link from patron display

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoshow acq user requests action from lineitems in lists
Jason Etheridge [Thu, 28 Jul 2011 11:53:56 +0000 (07:53 -0400)]
show acq user requests action from lineitems in lists

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agowire up Create Request action in acq user requests UI
Jason Etheridge [Thu, 28 Jul 2011 11:27:45 +0000 (07:27 -0400)]
wire up Create Request action in acq user requests UI

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agocontext filters for acq user requests UI
Jason Etheridge [Tue, 26 Jul 2011 13:11:07 +0000 (09:11 -0400)]
context filters for acq user requests UI

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agocopy/paste-o's, remove (near) duplicate code
Jason Etheridge [Tue, 26 Jul 2011 12:31:32 +0000 (08:31 -0400)]
copy/paste-o's, remove (near) duplicate code

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoDo not overwrite controlmap entries, but extend them (Floating Subdivisions!)
Mike Rylander [Tue, 20 Sep 2011 14:55:55 +0000 (10:55 -0400)]
Do not overwrite controlmap entries, but extend them (Floating Subdivisions!)

Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoClear hold shelf [expire] time at checkout to alternate patron
Bill Erickson [Thu, 25 Aug 2011 18:20:56 +0000 (14:20 -0400)]
Clear hold shelf [expire] time at checkout to alternate patron

When an item on the holds shelf is checked out to an alternate patron
(i.e. not the hold user), clear the shelf_time and shelf_expire_time
along with capture_time, current_copy, etc. on the hold.

tsbere++ for isolating the problem.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoTake care of some missed db upgrade script numbers
Lebbeous Fogle-Weekley [Mon, 19 Sep 2011 21:41:48 +0000 (17:41 -0400)]
Take care of some missed db upgrade script numbers

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
13 years agolp854084: fix catalog link in line item table when using TT-OPAC
Galen Charlton [Mon, 19 Sep 2011 18:07:22 +0000 (14:07 -0400)]
lp854084: fix catalog link in line item table when using TT-OPAC

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoTPAC: Enable password resets - crude, for now
Dan Scott [Sat, 17 Sep 2011 03:45:53 +0000 (23:45 -0400)]
TPAC: Enable password resets - crude, for now

Use the existing crude password reset form to enable password resets.
Slightly longer term, we need to destroy the existing form and pull it
into TPAC proper (including such good stuff as real localization and
getting rid of Dojo / Dijit), but this works for now.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoStaff saved searches when browsing catalog in staff client
Lebbeous Fogle-Weekley [Fri, 16 Sep 2011 23:13:12 +0000 (19:13 -0400)]
Staff saved searches when browsing catalog in staff client

By default, show a user's ten most recent searches to them on the left
side of the results and record details pages.  Configurable by org unit
setting 'opac.staff_saved_searches.size'

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoIt's a lineitem detail (copy) batch receiver
Lebbeous Fogle-Weekley [Wed, 3 Aug 2011 20:05:21 +0000 (16:05 -0400)]
It's a lineitem detail (copy) batch receiver

You can get to it via a button in the upper right-hand corner of
the view-invoice interface, assuming you're looking at an invoice that's
already been created/saved (and which has acqlid objects in a receivable
state), not one you're just now creating.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoBookbag enhancements in TTOPAC
Lebbeous Fogle-Weekley [Fri, 16 Sep 2011 22:31:56 +0000 (18:31 -0400)]
Bookbag enhancements in TTOPAC

Bookbags have descriptions now (and they're reflected in feeds).
Bookbag item notes are editable.
Bookbags can now be sorted by title or author using QP tricks.
You can export a bookbag as CSV.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoTPAC: PROCESS config.tt2 needed in results.tt2
Dan Scott [Sat, 17 Sep 2011 02:16:19 +0000 (22:16 -0400)]
TPAC: PROCESS config.tt2 needed in results.tt2

If the values in config.tt2 are not available to the results page, then
all of them are false - so Google Analytics, Resolver, etc, won't work
in the results page.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoSet refworks default org to match org tree root
Bill Erickson [Wed, 6 Jul 2011 14:12:00 +0000 (10:12 -0400)]
Set refworks default org to match org tree root

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoTPac: clicking on open "extras" tab closes the tab
Bill Erickson [Fri, 16 Sep 2011 20:32:34 +0000 (16:32 -0400)]
TPac: clicking on open "extras" tab closes the tab

In record detail page, if a tab (e.g. Subjects) is open, clicking on the
tab header again will close the tab.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoTPac: display table of contents on record details
Bill Erickson [Fri, 16 Sep 2011 18:00:32 +0000 (14:00 -0400)]
TPac: display table of contents on record details

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoStamping db upgrade script for Fixed Field Cont/Conf typo/thinko
Mike Rylander [Fri, 16 Sep 2011 15:29:19 +0000 (11:29 -0400)]
Stamping db upgrade script for Fixed Field Cont/Conf typo/thinko

Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoIn-DB suffered from Cont/Conf issues as well
Thomas Berezansky [Fri, 16 Sep 2011 14:45:38 +0000 (10:45 -0400)]
In-DB suffered from Cont/Conf issues as well

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoFix Fixed Fields Editor Conf and Cont
Thomas Berezansky [Fri, 16 Sep 2011 14:24:01 +0000 (10:24 -0400)]
Fix Fixed Fields Editor Conf and Cont

Conf was defined with Cont's fields
Cont was missing

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agolp 851915: remove last references to /openils/lib/perl5 user/gmcharlt/lp851915_finalize
Galen Charlton [Fri, 16 Sep 2011 14:23:32 +0000 (10:23 -0400)]
lp 851915: remove last references to /openils/lib/perl5

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
13 years agoLP 851915: Remove references to /openils/lib/perl5
Dan Scott [Fri, 16 Sep 2011 13:59:54 +0000 (09:59 -0400)]
LP 851915: Remove references to /openils/lib/perl5

To prevent old versions of the OpenSRF and Evergreen Perl modules from
conflicting with the new versions of these modules (which are now
located in the default system Perl package directories), remove
references to them.

Also, O:W:AddedContent contains an old reference to a distro-specific
Perl directory that we can clean up at the same time.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
13 years agopin down upgrade script version numbers
Jason Etheridge [Thu, 15 Sep 2011 16:08:55 +0000 (12:08 -0400)]
pin down upgrade script version numbers

13 years agoadd in the org setting history triggers
Jason Etheridge [Thu, 15 Sep 2011 16:05:14 +0000 (12:05 -0400)]
add in the org setting history triggers

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoCLEANUP ALL THE COUST and fix history view
Thomas Berezansky [Thu, 8 Sep 2011 18:27:48 +0000 (14:27 -0400)]
CLEANUP ALL THE COUST and fix history view

Move all COUST seed values to the same insert statement in 950.data.seed-values.sql
Make data upgrade file do *all* the changes that happen in the seed values
Add groups to some of the new settings since Joseph looked at the list
Make history view escape &, <, and > before showing values to prevent HTML from being parsed

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoCleanup, yay! Give YAOUS logging table a surrogate pkey and upgrade script; clean...
Mike Rylander [Wed, 7 Sep 2011 18:27:05 +0000 (14:27 -0400)]
Cleanup, yay! Give YAOUS logging table a surrogate pkey and upgrade script; clean up some typos; position the existing upgrade script correctly

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoAdded the following features/imporovements suggested by the community:
Joseph Lewis [Thu, 7 Jul 2011 19:21:53 +0000 (13:21 -0600)]
Added the following features/imporovements suggested by the community:

 * Sort history by date descending.
 * Add revert button to history.
 * Search after pause.
 * Dynamically adjust amount of time message is shown by its length.
 * Fix a bug about things not being shown in history after delete.
 * Fix a problem with user not being shown change if they make a change in a
   context that isn't currently shown.
 * Do i18n on everything.

Signed-off-by: Joseph Lewis <joehms22@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoFixed my database errors (although some still exist, I can't tell if they
Joseph Lewis [Mon, 20 Jun 2011 19:36:25 +0000 (13:36 -0600)]
Fixed my database errors (although some still exist, I can't tell if they
are mine or not, I'm going to test the master and see if they exist there...)

Signed-off-by: Joseph Lewis <joehms22@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoCleaned up so it shouldn't ruin the database creation (hopefully).
Joseph Lewis [Fri, 17 Jun 2011 21:05:51 +0000 (15:05 -0600)]
Cleaned up so it shouldn't ruin the database creation (hopefully).

Signed-off-by: Joseph Lewis <joehms22@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoFixed the non i18n settings for oust.
Joseph Lewis [Wed, 15 Jun 2011 19:28:26 +0000 (13:28 -0600)]
Fixed the non i18n settings for oust.

Signed-off-by: Joseph Lewis <joehms22@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoGot rid of old bug (pre me) that existed when an autowidget was used then
Joseph Lewis [Wed, 15 Jun 2011 17:46:33 +0000 (11:46 -0600)]
Got rid of old bug (pre me) that existed when an autowidget was used then
canceled and the next setting wasn't an autowidget. The autowidget would
continue to appear because it was never destroyed.

Signed-off-by: Joseph Lewis <joehms22@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoChanged text in seed values to reflect addition of groups, added an update
Joseph Lewis [Wed, 15 Jun 2011 17:03:14 +0000 (11:03 -0600)]
Changed text in seed values to reflect addition of groups, added an update
script for groups, fixed org_unit_settings.js so the dojo grid would correctly
alphabetize with the additon of groups and the removal of groups from the
labels themselves.

Signed-off-by: Joseph Lewis <joehms22@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoRemove duplicates due to groups in seed-values.sql, and include groups in
Joseph Lewis [Wed, 15 Jun 2011 14:35:45 +0000 (08:35 -0600)]
Remove duplicates due to groups in seed-values.sql, and include groups in
seed-values; delete seed values upgrade patch.

Signed-off-by: Joseph Lewis <joehms22@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoUpdated so that the history shows the org-unit shortname rather than the id.
Joseph Lewis [Tue, 14 Jun 2011 21:46:59 +0000 (15:46 -0600)]
Updated so that the history shows the org-unit shortname rather than the id.

Signed-off-by: Joseph Lewis <joehms22@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoConvert buttons to toobar cleaning up page a lot. Added new notification
Joseph Lewis [Tue, 14 Jun 2011 19:35:33 +0000 (13:35 -0600)]
Convert buttons to toobar cleaning up page a lot. Added new notification
system.

Signed-off-by: Joseph Lewis <joehms22@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoAdded revision logging to oust, updated fm_IDL.xml to reflect that
Joseph Lewis [Mon, 13 Jun 2011 22:54:06 +0000 (16:54 -0600)]
Added revision logging to oust, updated fm_IDL.xml to reflect that
and changed org_unit_settings.js and org_unit_settings.xhtml to add some
functionality of revisions.

Signed-off-by: Joseph Lewis <joehms22@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoUpdated the staff_client code to be much better at searching, renamed the sql upgrade...
Joseph Lewis [Thu, 9 Jun 2011 21:14:22 +0000 (15:14 -0600)]
Updated the staff_client code to be much better at searching, renamed the sql upgrade script b/c 0549 was just snatched up!

Signed-off-by: Joseph Lewis <joehms22@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoFinished import/export of settings.
Joseph Lewis [Thu, 9 Jun 2011 19:17:16 +0000 (13:17 -0600)]
Finished import/export of settings.

Signed-off-by: Joseph Lewis <joehms22@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoUpdated to include search.
Joseph Lewis [Wed, 8 Jun 2011 20:07:27 +0000 (14:07 -0600)]
Updated to include search.

Signed-off-by: Joseph Lewis <joehms22@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoAdded Tags support in the org_unit_settings display page.
Joseph Lewis [Tue, 7 Jun 2011 17:34:20 +0000 (11:34 -0600)]
Added Tags support in the org_unit_settings display page.

Signed-off-by: Joseph Lewis <joehms22@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoWhoops, typed in the wrong number.
Joseph Lewis [Mon, 6 Jun 2011 22:06:25 +0000 (16:06 -0600)]
Whoops, typed in the wrong number.

Signed-off-by: Joseph Lewis <joehms22@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoForgot to put in the logging information :)
Joseph Lewis [Mon, 6 Jun 2011 21:59:37 +0000 (15:59 -0600)]
Forgot to put in the logging information :)

Signed-off-by: Joseph Lewis <joehms22@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoAdded seed values for the "tags" of the settings in org unit settings.
Joseph Lewis [Mon, 6 Jun 2011 21:03:27 +0000 (15:03 -0600)]
Added seed values for the "tags" of the settings in org unit settings.

Signed-off-by: Joseph Lewis <joehms22@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoSet ind2 to the value of indicicator 2 supplied by the user, not ind1
Mike Rylander [Thu, 15 Sep 2011 13:11:47 +0000 (09:11 -0400)]
Set ind2 to the value of indicicator 2 supplied by the user, not ind1

Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoMake sure we only render the most recent request to the canvas, so a laggy network...
Mike Rylander [Wed, 14 Sep 2011 19:43:55 +0000 (15:43 -0400)]
Make sure we only render the most recent request to the canvas, so a laggy network does not cause double rendering or stale display

Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agolp834961: fix authoritative versions of callnumber retrieval calls
Galen Charlton [Wed, 14 Sep 2011 16:27:45 +0000 (12:27 -0400)]
lp834961: fix authoritative versions of callnumber retrieval calls

Makes open-ils.search.callnumber[.fleshed].retrieve.authoritative
actually be authoritative.  Fixes bug where adding a volume
could result in a false ASSET_CALL_NUMBER_NOT_FOUND error if using
database replication and Slony-II.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
13 years agoProvide a default value for, and explicitly change, the record type so the type dropd...
Mike Rylander [Tue, 13 Sep 2011 19:37:06 +0000 (15:37 -0400)]
Provide a default value for, and explicitly change, the record type so the type dropdown works as intended

Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoUpdate find view link in fund list UI to reflect relocated template
Bill Erickson [Tue, 13 Sep 2011 19:10:27 +0000 (15:10 -0400)]
Update find view link in fund list UI to reflect relocated template

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoRemove unused reference to oils_web.xml in startup.pl
Bill Erickson [Tue, 13 Sep 2011 17:42:01 +0000 (13:42 -0400)]
Remove unused reference to oils_web.xml in startup.pl

TODO: give EGCatLoader child_init-like functionality to connect to
opensrf to address the (unlikely) case that EGWeb/EGCatLoader are
the first/only mod_perl handlers loaded on an Evergreen Apache server.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoFurther updates to eg_vhost for tpac
Bill Erickson [Tue, 13 Sep 2011 17:32:22 +0000 (13:32 -0400)]
Further updates to eg_vhost for tpac

* Comment out locale handlers that do not have translations by default.
Otherwise, Apache will log the error in the error log.

* Added some additional configuration comments

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoStamped upgrade for opac_payment_history_age_limit
Bill Erickson [Tue, 13 Sep 2011 17:00:53 +0000 (13:00 -0400)]
Stamped upgrade for opac_payment_history_age_limit

...which is a new org setting defining how far back to reach for
payments to display in the payments history page in tpac.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoTemplate Toolkit OPAC
Bill Erickson [Tue, 13 Sep 2011 16:49:17 +0000 (12:49 -0400)]
Template Toolkit OPAC

See Template Toolkit OPAC release notes at
http://evergreen-ils.org/dokuwiki/doku.php?id=dev:opac:template-toolkit:release_notes

Additional non-tpac-specific changes include moving web templates
from the web dir into Open-ILS/src/templates/, removing /default/
from the template paths, and porting vandelay strings from the DTD
into the template (for better/consistent translation support).

Merge remote branch 'working/collab/berick/template-toolkit-opac-master-merge'

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen into template-toolkit-opac... collab/berick/template-toolkit-opac-master-merge
Bill Erickson [Tue, 13 Sep 2011 16:45:39 +0000 (12:45 -0400)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen into template-toolkit-opac-master-merge

13 years agoMerge remote branch 'working/user/dbs/tpac-css-buttons' into template-toolkit-opac...
Bill Erickson [Tue, 13 Sep 2011 13:57:54 +0000 (09:57 -0400)]
Merge remote branch 'working/user/dbs/tpac-css-buttons' into template-toolkit-opac-master-merge

13 years agoDelete a set of images that are no longer used user/dbs/tpac-css-buttons
Dan Scott [Tue, 13 Sep 2011 03:42:56 +0000 (23:42 -0400)]
Delete a set of images that are no longer used

Given the switch to CSS-styling instead of images, many of the images in
the repository are no longer used and can be deleted.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoCSS-ize account preference sub-tabs
Dan Scott [Tue, 13 Sep 2011 03:03:33 +0000 (23:03 -0400)]
CSS-ize account preference sub-tabs

Same old, same old.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoFix mislabelling of Cancel button as Submit
Dan Scott [Tue, 13 Sep 2011 02:51:23 +0000 (22:51 -0400)]
Fix mislabelling of Cancel button as Submit

As funny as it was to give people two options: Submit, or Submit, one
could imagine that it would be confusing. Also, remove the alt / title
attributes now that we're using meaningful markup that stands on its
own.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoCSS-ize holds and holds history tabs
Dan Scott [Tue, 13 Sep 2011 02:47:29 +0000 (22:47 -0400)]
CSS-ize holds and holds history tabs

From images to CSS-styled links.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoCSS-ize the search results control bar
Dan Scott [Tue, 13 Sep 2011 02:17:39 +0000 (22:17 -0400)]
CSS-ize the search results control bar

Along with the standard "swap images with fancy CSS links", we also
bring some style to the rather drab "Detailed View" link in the search
results control bar.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoCSS-ize current circ and circulation history tabs
Dan Scott [Mon, 12 Sep 2011 20:41:27 +0000 (16:41 -0400)]
CSS-ize current circ and circulation history tabs

More accessible. More win.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoCSSize fine/payment tabs on My Account page
Dan Scott [Mon, 12 Sep 2011 20:02:45 +0000 (16:02 -0400)]
CSSize fine/payment tabs on My Account page

More consolidation of CSS is a win for making changes in one place.
More accessibility as well.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoCSS versions of the main MyOPAC tabs
Dan Scott [Mon, 12 Sep 2011 19:35:17 +0000 (15:35 -0400)]
CSS versions of the main MyOPAC tabs

We can reuse much of the advanced search tab CSS (imagine that!), so not
only are we getting accessibility and HTTP request wins, we're cutting
down on the size of the CSS to deal with to skin this cat(alogue).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoCSSize the My OPAC login / logout buttons
Dan Scott [Mon, 12 Sep 2011 19:17:33 +0000 (15:17 -0400)]
CSSize the My OPAC login / logout buttons

Use the same relative positioning as the surrounding blocks and things
look relatively (hah) clean.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years ago5% radius for subtly rounded corners
Dan Scott [Mon, 12 Sep 2011 19:16:50 +0000 (15:16 -0400)]
5% radius for subtly rounded corners

15% was too much, especially on long thin blocks; it looked like
space-time was being warped.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoAdd some Web 1.5-ishness with rounder corners for tabs
Dan Scott [Mon, 12 Sep 2011 19:03:18 +0000 (15:03 -0400)]
Add some Web 1.5-ishness with rounder corners for tabs

5% radius is a lot more subtle.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoStyle the advanced search tabs with CSS
Dan Scott [Mon, 12 Sep 2011 18:47:04 +0000 (14:47 -0400)]
Style the advanced search tabs with CSS

We could go further and disable the link on the active advanced search
tab, but for now we're just replacing what was there with a reasonable
visual approximation.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoTurn the login button into a CSS "button"
Dan Scott [Mon, 12 Sep 2011 18:46:13 +0000 (14:46 -0400)]
Turn the login button into a CSS "button"

It's just a fancy link; treat it as such with some fancy CSS.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoTPac: Default to en_us if no locales are configured
Bill Erickson [Mon, 12 Sep 2011 18:13:42 +0000 (14:13 -0400)]
TPac: Default to en_us if no locales are configured

Code will create an en_us handler that falls through to the strings in
the templates.

Signed-off-by: Bill Erickson <berick@esilibrary.com>