lp1193487 Circulation Policy Column Picker not saving configuration.

The circulation policy column picker is not saving its configuration
because ui.grid_columns.conify.config.circ_matrix_matchpoint is not
defined in the config.usr_setting_type table.  This updates the sql
to populate the table.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Stamping upgrade 0839: alternative title index fix

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Replace inappropriate browse reingest with ...

... attempt at reingest across browse/facets/search but limited to
the alternative title index.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Capture all alternative titles

With the addition of bib browse, the alternative title index definition
was made to point at the 740 (ind2 != 2), which contains non-analytic
alternative titles /and/ non-filing indicator info.  It used to capture
both the 246 and (appropriate) 740's.  Allow either to match the XPath.

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping 0838 - remove bibcn normalizers

Signed-off-by: Dan Wells <dbw2@calvin.edu>

The identifier|bibcn field is best served by having no normalizers applied

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

OPAC: Make advanced search -> numeric search -> bib cn hone in on right target

The bib call number search under the advanced search page's numeric
search pane was doing the wrong thing.  By thinking the search field
desired was called 'bib_cn' where it's actually called 'bibcn', it
generated searches that just fell back to the broader search class
'identifier'.  This would often find your matches, but would also find
too many records that *shouldn't* have been matches.

Discovered with help from Erica Rohlfs and Mike Rylander.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Remove unnecessary Title Proper (Browse) index from config.metabib_field

As pointed out by Ben Shum and Dan Wells, we don't need this index, and
it made it only into the seed data and not into any upgrade script in
master.  It's a relic of bib-and-auth-browse development that ought to
have been removed before the merge to master.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Move some release notes to core docs

The release notes for Phonelist.pm and floating groups provided some good
documentation, so let's move them to the core docs and leave just the
intro for the release notes.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Relax MFHD subfield 'a' requirement for caption/patterns

If going by the book, every caption/pattern field would have a
subfield 'a', since the data from subfield 'i' would be moved to
'a' if 'a' was empty.  Since that is arcane, and our own wizards
used to bend this rule, let's make some minor adjustments to our
expectations:

1) When calculating date progression, don't expect there to be an 'a'
subfield which needs to be "carried" into.
2) When determining whether a field is 'open-ended', check the first
availabile enum/chron subfield rather than hard-coding the check to
'a'.

These changes do not affect the display formatters, so strings
generated from 'a'-less caption/pattern combos are not exactly right,
but they suffice.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>

More release note entries

Additional release note entries in the areas of administration,
circulation, staff client, SIP, and serials.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Release note additions for new acquisitions features

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Adding new OPAC features to Release Notes.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Move various release notes into correct directory

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Documentation: Add migrating patron data from 2.1 docs.

Converted and added documentation from http://docs.evergreen-ils.org/2.1/html/migratingpatrons.html.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>

LP#1207281: require SSL when downloading offline patron list

This patch builds on the previous one by forcing use of
SSL for downloading the offline patron list.  It also
updates the Apache 2.4 example configuration.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

LP#1207281 Prevent download of offline patron list without authentication

This patch addresses the vulnerability which allowed a user with the proper
knowledge of the location of offline patron lists to download the file over
regular HTTP without any staff credentials.

This small addition to eg_vhost.conf.in will present users with a login prompt
when trying to access the /standalone/ subdirectory on an Evergreen server.

Users are able to download the patron list in the staff client as normal
because they already have obtained credentials during the normal staff client
authentication process.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

LP#1066141: add authtoken check and related permission for age to lost function

The SET_CIRC_LOST permission is now required in order to invoke
the open-ils.circ.circulation.age_to_lost method.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Fix an omission in the log redaction configuration.

open-ils.actor.patron.password_reset.commit was omitted in the
<log_protect> block of opensrf_core.xml.example.  This commit adds
it and updates the release notes for 2.3 to include it.

There is also a release notes file informing users that they need to
edit opensrf_core.xml to address this issue.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Responsive tpac release notes

Add release notes entry for the recent responsive tpac work.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Correct small errors in new AC cover code

In shelf browser, two problems:
 - missing '%]' after 'args=rec_attrs;'
 - cn.record_id should be cn.record.id

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>

Move 'floating groups' release note docs

Not sure if this is the best place, but it seems like a better
place.

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Translation updates - fix Finnish translator email

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Translation updates - newpot

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Translation updates - po files

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Add apache config examples for AC by record id

Add apache (and apache 2.4) config examples for added content by
record id, update release notes to call out changes.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

Add release notes for AC by record id

Add release notes for Added Content by record ID.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

Show jacket on record page even when no isbn/upc

Show jacket image on record details page even when there is no isbn
or upc found -- because we may have an ISSN or local override image.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

Add ISSN support to Syndetic AC handler

Add ISSN support to OpenILS::WWW::AddedContent::Syndetic added
content handler to take advantage of new support from upstream
provider.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

Add method to permit AC handler to expect keyhash

Add an expects_keyhash method to
OpenILS::WWW::AddedContent::Syndetic and look for it from
OpenILS::WWW::AddedContent. This allows us to pass a keyhash
(containing isbn/upc/whatever) to this handler while still passing a
simple scalar containing an ISBN to other AddedContent handlers.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

Teach TPAC and selfcheck jackets by record ID

Teach TPAC and web-based selfcheck to display jackets by record ID.

Not covered yet: KPAC (uses a non-1x1 placeholder at this time) and
Acq (where we don't always have a bre.id).

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

Teach OPAC (jspac) jacket images by record id

Teach the Javascript OPAC how to retrieve jacket images by
record id.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

Removed unused, commented-out function

Removed unused, commented-out function: an earlier iteration of
buildISBNSrc

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

Teach Syndetic.pm to pass UPC in requests

Teach OpenILS::WWW::AddedContent::Syndetic to pass UPC when
requesting added content from the source.

Protect against warnings when no isbn/upc provided

Protect against Perl giving us uninitialized value warnings when
isbn or upc has not been provided.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

Finish Added Content by record ID

OpenILS::WWW::AddedContent now supports fetching content by record ID.

To start, this lets us request content in a way that uses both ISBN
and UPC as keys, assuming the AC handler and provider support it.

The previous method of requesting AC data continues to be
supported, and should be unaffected.

Business::ISBN is used to clean ISBN values when fetching by record ID

If we find no valid ISBN and no UPC values in the record,
do not attempt to call an AC handler. This will need
to change when we have AC handlers that rely on other
possible keys.

Attempt to serve from cache before fetching keys from the bib
record in the database.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

Start of AC by record ID from 2011 hackfest

Rough, untested cut. use rec id as they added content key;
fetch isbn/upc from full_rec; push full set of isbns and upcs
down to handler code

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

Fix doc typo in public interface setup section

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Clean up minor doc problems

"Content Café" would generate a section ID containing "é" which is not
well-formed XML; that was breaking PDF generation. Provide an explicit
ID for the section in question.

The OPAC advanced features section skipped a level of headings, which
generated a warning during PDF processing.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Include auth browse docs in OPAC section

Also fix a typo in the section title.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Numbering upgrade script for auth-only-bib-auth-browse-signoff

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Some release notes for browse enhancements

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Bi-directional authority enhanced bib browse

This functionality extends the work committed as the following set:

e071eb91a40d3871bc0e0a078b88cfdde7ba3b5e Finish stamping for bib record browser
c7bad82a66554251b8a0f636e629fe98680b7765 Stamping upgrade scripts for bib record browser
32ec20b71540b1230ecc15f1aec95059e044499e Fix problem where basic search bar was flush with left edge of page
256b4d24240332ae3fd2a5cc14b1709c90f18d05 Fix issues with multiple divs having the search-wrapper id.
cfc828d832ecee92478466cd2f4e174c2f4b5c3c OPAC Browse: bugfixes squashed together from LP #1177810
6990fd819c0dae385c3cc7a40d39a0ebed91086c Break up expensive queries, match index to quals
c0dea517395c733b77e8eb219d2c3f43f6098d42 OPAC Browse: some squashed commits from LP #1177810
9d37f6890ce6b591d62972ce3e341cecf7c45535 Fix problem with YYYY.schema.bib-auth-browse.sql.
e710ecbee519d374bcf69b0c535c3f83814c782b Bib record browser with 'see also', etc from linked authority headings
d2f4cac923668ff05854ffc9720cafe514b9b71c Link browse entries to authority record when possible
3eb616e56c82a5106e14f5a446f1d875015db7f0 Inter-authority linking

With this, we enhance the browse method to allow the return of authority-only
terms (that is, main entries not used by a bib record) if the authority record
from which the term comes is linked to another authority record via the
mechanism created by 3eb616e5, and that linked authority record is itself in
use by visible bibliographic records.

In order to accomplish this we:
 * extend normalization of both bib and auth records to allow a custom string
   to be used when joining parts of a term (for instance, joining subject
   components with " -- ")
 * cause authority headings to be including in the unique set of values
   captured by metabib.browse_entry during authority ingest
 * link authority-heading derived browse entries to their authority-indexed
   counterparts
 * extend the metabib.browse() stored procedure (and related) to inspect
   authority-linked browse entries
 * extend bibliographic-visiblity testing to cover those bibliographic records
   in use by remote-linked authority records.
 * generate browse links between headings found to be appropriately linked
   and bibliographically in-use and visible

The addition of this functionality will require, in the least, reingest of
all authority records, and would benefit from reingest of bibliographic
records as well, as ingest has been improved and extended.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Stamping upgrade for floating groups

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Floating Groups

Convert the floating bool to a link to floating groups.

Each group contains zero or more members that define how copies can float.

See the included documentation file for an overview.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

OPAC: on the login page, Make "Questions?"/"FAQs" areas not float weird

One little change from the original patch to make it 2em; instead of just 1em;

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

Push the 2.4.2 inter-version upgrade script forward

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Serials: Support reader address information in routing slip template

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Stamping 'patron credit disable' setting

Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1211473 YAOUS : disable patron credit payments

New org unit setting circ.disable_patron_credit.

This prevents "patron_credit" payments in the payment creation API and
hides all patron credit related actions in the patron payment interface.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

TPAC: Add format icon back to record details

Similar to 502f93acff9a5713668931c980d6ce25962a1f8c finding compromise by
putting the format icon back right next to the format label.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

In reports, show old label name as the default in the Alter Display Header -prompt

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>

Add PhoneList.pm stuff to Apache 2.4 config

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

Add phonelist.txt release notes.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

Fix PhoneList.pm child_init method.

child_init in an Apache module should return something, so it now
returns the OK constant.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

Strip out spaces as well as - from phone numbers in PhoneList::Holds.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

Add PhoneList.pm.

A simple WWW module to list patrons who have holds with their phone
numbers and barcodes. The format is as requested by a specific library
for their automated calling program.

Future modifications may include the ability to rearrange the output
columns and provide formats for some data.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

Fix delete items confirmation typo.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>

Better handling of purchase_order being non-numeric

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

Fiction records / copies test data

Adds 17 (mostly) fiction bib records w/ copies to
OpenILS/tests/datasets/sql/.  New items are loaded via load_all.sql.

Special thanks to Rogan Hamby for donating (and I believe creating)
these records many moons ago.  For reference:

The father hunt;
Southern Gods /
The winter of our discontent /
CliffsNotes Steinbeck's Of mice and men /
The rum diary
Blueberry girl /
Stardust
Coraline
Objective-C programming :
The swordsman of Mars /
Ghost story
The Avengers
Throne of the Crescent Moon /
The walking dead.
Kraken :
The crow
The running man /

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

Added in warning message when placing hold with no email address.

Previously when an account didn't have an email address associated with it
when placing a hold, the input box would be greyed out and the display
would show the Email Address text with no address to go with it.

This change will instead show text warning the user that they have
no email address configured and they need to go to My Account in order
to add one to their account.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

TPAC: Consolidate and simplify button styles

TPAC has at least two distinct types of buttons, those created by
input tags, and those created by anchor (that is, <a>) tags.  This
commit simplifies and consolidates the styles used for both types
of buttons.

At least in Firefox, inline blocks display in a closer size rendering
to <input> tags than plain 'display:inline'.  The switch doesn't seem
to hurt in most cases in IE, FF, or Chrome, so let's do it.

Two cases where inline works better are the floating 'My Account' and
'dash' buttons'.  They already have special classes, so let's revert
those back to inline.  In fact, let's make the logged-in 'dash'
buttons share the style of the 'My Account' button which got us there,
and make all three buttons more visible when hovering.

Inputs do not inherit the body font by default, so let's apply it for
better display consistency.

Finally, Firefox inputs have some extra space around them; let's make
a modest attempt to remove that.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>

TPAC: href not valid on 'button' tags

The 'Clear Form' button was moved to a button tag, which solved a
display issue but didn't actually clear the form.  Let's make it
an <a> again.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>

TPAC: Add format icon back to search results

As a compromise, add the format icon back to the search results to sit alongside
the fully spelled out format label for the record. Having the label next to the
icon helps to inform on the icon without the need to hover.

Local sites may consider customizing this to their personal desires.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

TPAC: Make corner image link to server root

Most people will do this anyway, and in the MOPAC view, you currently
get trapped in 'My Account' with no obvious way out unless we have
a link like this.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

MOPAC: Remove fixed height from fines tabs

With 'overflow:auto' applied, a fixed height isn't needed, and
actually causes minor issues.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

TPAC: Make low hits help support low-width devices

Inline styles were forcing the width of the low-hits help box to be
353px wide, which is wider than our target 320 width for mobile devices.
Let the help use the full available width under the 600px barrier.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

TPAC: Make home search screen work on IE8+

The home logo is now centred on IE, and the white background extends
across the full width of the page. Huzzah!

As a bonus, the markup makes more sense without the <strong><center>.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Add missing ending label tag for format selector

On the basic search, we were missing an ending label tag so it was combining
the one from formats and library pickers into a single element which made
selecting the library misbehave.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Remove extra large facets

While an interesting experiment, as agreed in IRC conversation with kmlussier
and dbs, we will remove the extra wide facets being used in wider screens for
the time being.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Increase height of facet headers

Because the font size is larger now, the bottom of the facet headers was
getting too close to the text.  Increase size slightly for now.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Remove My Account tabs at higher resolution

The My Account tabs begin to break at a higher resolution than 600 so
let's remove them at 800px instead.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Remove explicit widths from My account

There were a couple of explicit width in the My Account area that were
causing the account expiration alert to run off the screen. I removed them
and a tweak to the CSS to get the page elements to display
properly.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

i18n support for field names in myopac css

Signed-off-by: Bill Ott <bott@grpl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Fix margins in advanced search tabs for mobile view too

Similarly, in the mobile view, do not have a bottom margin separating the tab
from the content below. Clean up margin code while we're at it.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Fix tab button margins

Remove a hanging 10px margin that made the advanced search tabs and my account
tabs appear as though they were floating over the contents they were connected
with.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

TPAC: Simplify opac-button styling

Conflicting padding declarations in the stylesheet, in an old attempt to
balance out the sizes of various INPUT types vs A elements in Chrome vs.
Firefox, were resulting in increasingly odd sizes for the buttons
(depending on which browser you used). Switching to a BUTTON instead of
an A tag and dropping all of the padding declarations improves the
situation on Firefox, Chrome, and IE8, while simplifying the CSS.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

TPAC: Retain advanced search tabs via overflow:auto

At small widths, the advanced search tabs could be forced to escape the
search tab header in a displeasing fashion. Also, the background bar
that provides context for the selected tab had been lost - and
overflow:auto fixes that. Thanks to Dan Wells for the suggestion.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

TPAC: Main content needs a clear:both style

On My Account, the content of tabs was riding up against the tabs. Use
clear:both style for #main-content to force the main content to start on
a new line.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

TPAC expert search: wrap labelled fields consistently

Use a new class "nonbreaking-wrapper" with display:inline-block to keep
label + input fields together, rather than the inline "whitespace:
no-wrap" which did not work on Chrome (and oddly enough forced the value
field to the next line).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

TPAC: Prevent IE compatibility view

Windows XP has IE8, and it can handle the CSS we have in the TPAC.
However, the "compatibility view" button, if clicked, actually results
in horribly broken rendering (contrary to what one would expect).

 Adding this <meta> tag prevents the compatibility view button from
displaying and should improve the experience for users.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

TPAC: Clear line for initial advanced search tab

The initial advanced search tab was being rendered right beside the tabs
instead of underneath them; fix in the same way we fixed the numeric and
expert tabs previously.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Restore fines, checkout, and holds tabs

These display well as tabs since there are only two tabs to display. Probably
inadvisable to replace these tabs with menus as we did in other places because
there are already menus on these screens to perform actions on selected
checkouts/holds.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

TPAC: Streamline facet display

Rather than including a DIV containing only a non-breaking space to
clear the lines of the facets, just use CSS to clear each facet and set
a bottom margin appropriately.

Also, take advantage of wide screens by allowing facets to display
more broadly rather than being limited to a 10% width of the screen.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

TPAC: Advanced search - add line break

The header and form for numeric search and expert search were being
displayed inline with the tabs on the advanced search page; push those
down where they should be.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

TPAC: Draw a border under the result header bar

Particularly needed in mobile mode, where the background has been set to
inherit, draw a bottom border to separate the result header actions from
the pagination controls.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

TPAC: Enable search bar elements to wrap gracefully

As the browser window narrows, stack the search bar elements vertically
as needed.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

TPAC: Define result header padding by contents

Rather than defining padding for the result header bar and then defining
margins for the contained labels and buttons, rely strictly on the
buttons and labels to position themselves.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

TPAC: Make result label text consistent size

The text on the result header buttons was all 100%, while the text
labels for the sort and limit to available widgets for some reason were
set to a smaller font size, despite appearing on the same line.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

TPAC: Make result button text consistent

There's no good reason for the result buttons to have underlined text
when most other buttons in the Web UI do not have underlined text.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

TPAC: Remove wide bar under results options header

The hard-coded <br class="clear-both"> adds a full em of empty vertical
space to the full TPAC with no usability gain. Remove it.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

TPAC: Saner search button CSS

Gradients and text shadows begone.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Mobile TPAC: Cleaner Refine/Return to hits behaviour

Have the Refine results / Return to results button be the target ID, so
that clicking the link leaves the opposite action at the top of the page
(giving users a quick exit path back to where they came from).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

TPAC: Consistent results paginator font size

It is weird to have two different font sizes appearing on the same line
in the regular TPAC, and it introduces slight inconsistency for the left
padding of the results pagination in mobile mode.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

TPAC: Avoid paginator HTML rather than hiding it

Rather than generating HTML and then hiding it via CSS, just don't
generate the HTML at all. In this case, avoid generating the Previous /
Next links in those cases where we're on either page one or the last page
of results respectively.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

TPAC: Align results pagination in mobile mode

The results summary and results paginator had been using hard-coded
pixel values for the padding-left value; amusingly, they were different
values. Now that the paginator is part of the CSS stylesheet, switch to
using a standard 1 em so that we can also respond to the chosen font
size of both the stylesheet and the user's preference.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

TPAC: Reduce vertical space in results paginator

An unnecessary span element with inline CSS results in additional blank
vertical space being generated for searches with only one page of
results. Avoid creating the span (which would normally contain the list
of pages), move the CSS to the style sheet, and use ems rather than
hard-coded px values for the padding to adjust relative to the font
size.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Mobile TPAC: Show Advanced Search button in results header

Now that the advanced search UI is reasonably mobile-friendly, make it
visible. At the same time, make the wrapping behaviour more friendly by
giving a little bit of vertical margin between wrapped buttons (because
adding "Advanced Search" is almost guaranteed to cause wrapping).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

TPAC: More responsive search result header buttons

Rather than having a specific height of 40px, which is crazy, remove the
specific height. This enables the buttons contained in the search result
header to wrap without overlapping the bottom border in strange
patterns.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Mobile TPAC: Better styling for facet/results buttons

Adopt the OPAC button style and move the buttons into the search bar to
consolidate result-specific actions into a single contextual area.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

TPAC: Remove "Dynamic catalog" link from footer

The TPAC _is_ the dynamic catalog as of 2.3. It no longer has a need to
link to itself.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>