PINES Self-Check: Fix for Pay Fines Button

The 'Pay Fines' button was appearing in some scenarios, even
though it's not possible to pay fines through the self-check
at this time. This completely removes that button.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP1896285 Post mark-missing serialized item load

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1896285 Patron search add to bucket serialize

Add a batch of patrons to a bucket one patron at a time to avoid
overwhelming the server with bucket item create requests and potentially
exhausing the open-ils.actor service.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1896285 Batch mark item missing serialized

Process batches of items one at a time when marking them lost to avoid
sending too many parallel requests to the server.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1896285 Add new items avoids looping settings lookup

Refactor AngJS volcopy item add actions so it makes the minumum
necessary settings API calls for default copy status.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

(updated)

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Removed password hint since the password is now set differently
depending on whether the patron registers through Quipu or through
the desk.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

only apply fields with values to address objects

LP1893463: Prevent duplicated report outputs

When re-running recurring reports that are interrupted,
it's possible to end up with a duplicate copy of the next
recurrance of that report. This branch adds a unique index
to reporter.schedule and tells clark-kent.pl not to worry
about it.

For the purposes of this change a duplicate report is
one where report.schedule has identical values for report,
(output) folder, runner, run_time, and email.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>

fix -- day_phone issue

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Quipu Ecard Form Update

Added CSS to intro text to hide unless Quipu's code tells it to display.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Quipu Self-Registration Form

Edited both ecard.tt2 and register.tt2 to add quipu form javascript
and add intro text.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

fix guardian field

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

re-comment out the KCLS stuff

Quipu customization - add css for barcode

Added eCARDPatronNumber to CSS to control barcode display.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Quipu Customizations Part 2

Modified CSS to use different class name

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Quipu Customizations

Move library card application link to top menu instead of bottom menu,
cleaned up a lot of whitespace issues and old commented out text,
added CSS controls for parts of the Quipu form.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Quipu eCard Integration for PINES

Altering KCLS's Quipu eCard implementation to align
with PINES's needs, with an eye towards a generic feature
that could be submitted to Evergreen master.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

KCLS Quipu integration bits

Notes:

1. See constants along the top of Ecard.pm which will need changing.
2. Ecard.pm add_stat_cats() is very kcls-specific
3. The vendor login uses a new password type 'ecard_vendor' which does
   not have the intermediate md5 hashing.
4. Ecard.pm and templates have header/footer stuff that's specific to
   bibliocommons and should be removed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Adding missing div

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

COVID update

Modify text alert at top of page.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Revert "COVID update"

This reverts commit 154c9eb2dc6d9def95051dac56b990f9e9ff3f2a.

Advanced Search Page Display Fix

Removed extra "Group formats and editions" checkbox (it had
been on there twice).

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

COVID update

Modify text alert at top of page.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

lp1890498: Replace Item Barcode now warns about duplicate barcode

Modify the Replace Item Barcode page so that it displays an error
message when trying to replace a barcode with a barcode already
in use.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1845241: Use the correct API call to Undelete a bib record

To test:

1) Open up a delete-ready bibliographic record in the Web client
(no attached holdings, no located URI, no open orders attached, etc.)
2) Delete it.
3) Undelete it.  Note that the "Undelete" button briefly turns into a
"Delete" button before changing back to an "Undelete" button.  Note that
the bib record does not show up in search results within the Web client.
4) Apply this commit.
5) Now try undeleting the record again.  Notice that the "Delete" button
does not revert to an "Undelete" button.  Note also that the record is
once again showing up in search results (although you may have to be a
bit creative using search terms, due to search results caching).

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: blake <blake@mobiusconsortium.org>

PINES Staff Client Splash Page Updates

Update MARC batch import/export link, update http to https.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

up the hard-coded value for the record query limit in record bucket UI

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1848550 Cache org settings in IndexedDB (Angular)

Teach the org settings lookup code to store cacheable settings (those
for "here") in IndexedDB to reduce the number of repetitive network
calls for org unit settings.

Settings cached in IndexedDB are cleared upon successful login to avoid
stale values.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1848550 / LP1835128 Redirect to AngJS splash page

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1848550 Cache org settings in IndexedDB (Angular)

Teach the org settings lookup code to store cacheable settings (those
for "here") in IndexedDB to reduce the number of repetitive network
calls for org unit settings.

Settings cached in IndexedDB are cleared upon successful login to avoid
stale values.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1854850 Angular IndexedDB Shared Worker Communication

Implements the client side of the communication to the Evergreen
IndexedDB shared worker for Angular.

From this may be built caching mechanisms, offline transaction
handling, etc.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1848550: client-side caching of org settings for AngularJS

The web client almost always does live lookups any time it needs to
check an org setting.  But these settings rarely change, so it would
make sense to cache them.  They're already cached using Lovefield in
order to support offline; this commit checks the cache first, and only
does a live lookup if the setting is uncached.

The settings cache is cleared on login to ensure stale values don't
stick around forever.  To refresh the cache, simply logout and then
login; cached values will be deleted and the latest values will be
retrieved from the server when they are needed.

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

lp 1844365 patron edit page stat cat persisting old data

Fix the bug on the patron edit page where old stat cat data is
persisting when one does a new patron search and loads a patron
with no stat cats.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/web/js/ui/default/staff/circ/patron/app.js

use old floating groups interface until new one is available - fix typo 2

use old floating groups interface until new one is available - fix typo

use old floating groups interface until new one is available

LP#1842297: Allow for login redirect with hostname

PINES Customization: Help Links on OPAC Login Page

Updated FAQ & Library Locator Links

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES Customization for My Account Holds List

Expand Notes column header to cover the Edit column as well as the
Notes column so it doesn't look unbalanced.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES Customization: Re-display Booking

Booking module was previously hidden from the main navigation menu
because PINES wasn't using it. Re-display it now so that it can
be used.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

additions to post-upgrade script

removing hopeless holds changes from post-upgrade script

PINES Customization for Carousels

Added carousels in the 3.4.1 upgrade January 2020.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP1781274 Fix floating point issue preventing transactions from closing

Limits pending payment amounts to 2 decimal places.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

PINES Customization: Specific Due Date Box

This widens the specific due date box on the patron checkout
screen so that the full date is visible. This will probably
be fixed in master at some point, but fixing it locally
for the time being.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

fixing marc editing locally

adding openathens tasks to post-upgrade script

remove old scripts, combine new features into post-upgrade script

remove unnecessary tasks

adding ILL circulation modifier

LP#1842297: Fix - finds org parent reliably

LP#1842297: Implements patron sign-on to the OpenAthens service.

Allows global or local administrators to configure a connection to the
OpenAthens cloud-based single sign-on service. Allows patrons to connect
seamlessly to third party resources that use OpenAthens authentication.
For more detailed feature description visit
https://wiki.evergreen-ils.org/doku.php?id=dev%3Aproposal%3Aopenathens_integration

Signed-off-by: Julian Clementson <julian.clementson@openathens.net>

LP1857350 Org selector sorts by display value

When displaying the org unit selector, sort each set of children by the
display label (defaults to shortname).

Fixes issues with the org server sortTree function and adds a unit test
to test the repaired sort function.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

PINES Fix to custom holdings list

Corrects system name not showing up on record detail screen in
holdings copy table. Also adds system name to the linked up library
info page.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1843599: AngularJS MARC editor once again sets bib source

This patch fixes a regression introduced by the patch for bug 1693580
that prevent changes to the bib source from being made via the AngularJS
MARC editor.

To test
-------
[1] Apply the patch.
[2] Create a new bib record and save it with a non-empty source. Verify
    that the record sets the source as expected.
[3] Edit a bib record and change the source. Verify that the new source
    is retained when the record is saved.
[4] Edit an authority record and save it. Verify that it can be updated
    without error. (Note that authority records do not have sources in
    the same way that bib records do.)

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

PINES Hide Print and Email Options on Lists

The print & email options on lists in the OPAC are currently
broken (launchpad bug 1854986) - hide them until fixed.

Also includes a couple minor adjustments to spacing.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

lp1712644 Prevent check out due date in past

- Prevents selecting past due date when checking out an item
- Prevents saving a due date with hatch when input date is invalid

Signed-off-by: Katlyn Beck <kbeck@catalyte.io>
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/circ/patron/t_checkout.tt2
modified:   Open-ILS/web/js/ui/default/staff/circ/patron/checkout.js
modified:   Open-ILS/web/js/ui/default/staff/services/ui.js

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES - indent popularity line on search results page

We recently enabled popularity ranking visibility in the OPAC,
but it isn't indented with the rest of the item info. This adds
the indent and un-does the bolding since it is distracting.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES Self-check Customization

New PINES logo and matching color scheme

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Customization of self-check interface so that username, password,
and barcode text banners appear in different colors in an effort
to make it clearer to patrons that they are being asked for a
different type of information.

Note that that this also tweaks the password check because the old
format was different from current master and no longer working correctly.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES KPAC: New logo

Updates to incorporate new PINES logo.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES logo and color scheme changes

For January 2020 upgrade

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES Staff Client Logo Update

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Add new PINES logo.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1846484 - Add BETWEEN SYMMETRIC to reporter SQL builder

Let's give end users a break and forgive them when they mix
up the order of a date range.  BETWEEN SYMMETRIC allows users
to enter a date range in any order rather than strictly
enforcing "oldest date first" and returning an empty result
set.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1849334 - Protect precat volumes from accidental staff edits

It is possible to edit the precat volume (id = -1) in a batch
volume/copy edit in the webclient.  We assume that valid changeable
volumes have an id > 0, then allow changes.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

adding post-3.4 upgrade script

removing legacy upgrade script

LP#1822630: fix sanitizing CGI params on place_hold_result

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Stephenson <jason@sigio.com>
(cherry picked from commit 019118895c94f5cc810b3f1fb95b2634a1c993b6)

Revert "Temp fix for Broken Hold Links"

This reverts commit d8722f1c7a5b76f965e59ffbf20342a4c48bbeb0.

LP#1851524: fix adding a bucket when saving a new carousel

This patch fixes a regression where saving a new carousel
would not result in its bucket being created due to the
post-save callback never getting invoked.

This patch does not fix any carousels that do not have
buckets due to this bug. Because such carousels will
not function anyway, they should be deleted and
recreated by the local admin.

To test
-------
[1] Create a new carousel in local adminstration. Open it
    in the edit modal again and note that no record bucket
    is linked to it.
[2] Apply the patch and repeat step 1. This time, the
    bucket should be created.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

disable trigger USER, not ALL

update 3.3-3.4 upgrade script with PINES customizations and speed improvements

LP#1570072: add release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1570072: update hold notification methods upon preference changes

This patch adds a feature where if a patron's hold notification
preferences are changed, they are given an opportunity to have
notfication methods for their pending hold requests updated to
reflect their new prefernces.

This feature affects both the public catalog My Account interface
and the staff patron registration form. In both cases, the user
is presented with a modal (staff-side) or interstitial page (public
catalog) asking them whether to update current hold requests.

Sponsored-by: MassLNC
Additional-work-by: Mike Rylander <mrylander@gmail.com>
Additional-work-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

update DB upgrade scripts to accommodate what we have already applied

Remove "In Receiving" status from magical status list

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Adding 'In Receiving' status to back-end functionality.

KPAC Updates: Add E-Read Kids

Add new permanent KPAC icon for E-Read Kids, hide summer reading,
show back to school.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES Customization: Alter wording for COPY_CIRC_NOT_ALLOWED

Change wording of COPY_CIRC_NOT_ALLOWED message because the default
wording indicates that it is a problem with the copy, but it can
also be triggered when there is a problem with the user (such as when
a Digital Only user attempts to check out a physical item).

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1713138 EDI buyer codes from RFF+API

Support extracting buyer code (AKE edi_account.vendcode) values directly
from the EDI RFF+API field.  This provides better matching to
edi_accounts based on vendcode values for inbound EDI messages.

The code will still fall back to extracting vendcodes appended to the SAN,
when no RFF+API is present.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Modifies our previously customized code for the new books dropdown
list so that it limits what is retrieved in the new books supercat
feeds by available statuses only.

LP #1705497 Replaces functionality in web client from legacy
XUL client by including a find function for originating
acquisition where it exists.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1642036 Group member detail grid query repair

Teach the grid to automatically use the current version of the grid
query in group member details lookup, since the query changes as
patron's change and is sometimes applied after the grid has already
absorbed the setQuery function.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1029601: Prevent double-clicking when submitting hold requests.

Double clicking on hold submit buttons causes multiple holds to be generated.  This adds some code to
disable the Submit button(s) after the first click, so subsequent clicks don't "work" in unintended ways.

Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>

KPAC Update: Remove Tumblebooks Link

GALILEO canceled Tumblebooks, so removing link.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES KPAC: Summer Reading 2019 Topics

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1630271: Add a field, change a label.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1630271 - Correct encumbrance subquery.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1630271 - Add Purchase Order Summary View

The purchase order reporting source contains several fields that are
available in the reporter but are non-functional (because they are
generated on-the-fly within user interfaces).  This view allows a
similar calculation and provides access back to the PO object as well.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP 1744386 & LP 1777184 - stat cats & stat cat entries not alphabetical

Statistical categories will be alphabetized first by library and then byt category.

The entires within each category will also be alphabetizes

fix broken holds link in My Account page

PINES Customization: Link to spine label documentation

To be added on top of Adam's spine label work.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1777677 Test Notification Method

Correcting two code typos (USER_VIEW should be VIEW_USER in Actor.pm
and language string typo in test_notification.tt2).

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

lp1777677 Security tweaks

- Refactor test notification API to check if requestor
is user,and if not, then check if requestor has
permissions to view users at target user's home ou.
- Change event_def_type references to "hook"
- Separate out sendTestEmail and sendTestSMS functions
in frontend to prevent potential misuse of functionality.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm
modified:   Open-ILS/src/templates/opac/myopac/prefs.tt2
modified:   Open-ILS/src/templates/opac/myopac/prefs_notify.tt2
modified:   Open-ILS/src/templates/staff/circ/patron/t_edit.tt2
modified:   Open-ILS/web/js/ui/default/opac/test_notification.js
modified:   Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

lp1777677 Test Notification Release Notes

- Add release notes for Test Notification functionality.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
new file:   docs/RELEASE_NOTES_NEXT/Circulation/test_notification_method.adoc

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

lp1777677 Test Notification Permission & String change

- Update permission requirement to OPAC_LOGIN
- Update strings to be more end-user friendly

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm
modified:   Open-ILS/src/sql/Pg/950.data.seed-values.sql
modified:   Open-ILS/src/sql/Pg/upgrade/XXXX.data.lp1777677-action-triggers-test-notification.sql
modified:   Open-ILS/src/templates/opac/myopac/prefs.tt2
modified:   Open-ILS/src/templates/opac/myopac/prefs_notify.tt2
modified:   Open-ILS/src/templates/opac/myopac/test_notification.tt2

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

lp1777677 Show test notification buttons by retrieved data

- Prevents test notification buttons from displaying when email or sms
data is input but no data exists on server.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/circ/patron/t_edit.tt2
modified:   Open-ILS/web/js/ui/default/staff/circ/patron/regctl.js

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

lp1777677 Test Notification OPAC success prompt

- Move OPAC success prompt higher up to ensure message is
seen.
- Ensure OPAC SMS test notification doesn't send email.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/opac/myopac/prefs.tt2
modified:   Open-ILS/src/templates/opac/myopac/prefs_notify.tt2

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>