LP#1468422 Make AuthProxy.pm work with new auth

Previously, AuthProxy.pm would simply lookup and use the hashed password
when the external authentication had passed.  This simple method no
longer works, since even cstore doesn't have access to the hashed
password.

Instead, take advantage of the new 'auth_internal' service to create the
user session after the user has been externally authenticated.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1468422 Tighten AuthProxy argument requirements

Basically, if we aren't given a username, and we can't find a username
by barcode, give up immediately.  This helps simplify the rest of the
code a bit.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1468422 Release notes example avoid re-migrate

Update the batch password migrate example code in the release notes to
avoid attempts at migrating already migrated passwords.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Manual password migrate does not re-migrate

Avoid migrating already-migrated passwords when actor.migrate_passwd()
is called manually.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Release notes manual pw migration comments

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Drop auth work factor from 14 to 10

Avoid what may be an unacceptible login delay caused by work factor 14
by dropping down to 10.  This reduces the CRYPT() time from ~1 second to
~.1 seconds.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Always default to root org unit

If no org unit is passed by the caller, always default to the root org
unit.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Auth efficiency improvements

1. Adds an oils_utils function for retrieving the ID of the root org
unit.

2. Avoid multiple cstore/db lookups for the root org unit by caching the
ID at the process level.

3. Move permission checks from open-ils.storage to open-ils.cstore.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Login permission checks are global

For backwards compat, perform all login permission checks using the root
org unit as the context org unit.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Return vanilla login failure on nonexistent username/barcode

For backwards compatibility (and security), return the same login
failure for nonexistent usernames/barcodes as for bad passwords, etc.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Report inactive card on password OK

Prevent leaking information from authentication by only reporting that a
card is inactive if the caller provided the correct credentials.  This
is consistent with how the code handles inactive patrons.

To avoid a lot of code duplication and to reduce the potential for
leaking memory (C code, amiright?), this commit includes a number of
changes to avoid exiting the API function early and saving the memory
cleanup routines until the end of the API call.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 auth-internal validate API

Adds a new open-ils.auth_internal API
open-ils.auth_internal.user.validate for checking whether a user should
be allowed to login.

It tests user existence, active=true, barred=false, deleted=false.

If a barcode is also provided, it confirms the barcode exists and is
active.

Modifies open-ils.auth.authenticate.complete to use the new API instead
of implementing the logic directly.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Remove deprecated open-ils.storage remote_update

User update in Actor.pm was the only remaining code that leveraged
the open-ils.storage remote_update API.  With that code moving to
open-ils.cstore, save some RAM by no longer auto-loading/publishing
remote_update methods.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 SIP password verification

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Implement password reset updates

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Port user update to cstore

Migrate the user update code from open-ils.storage to open-ils.cstore.
This has several benefits:

1. We can re-use the patron password update code
2. Several actions (bad contacts, invalid address) which previously
   resulted in data modifications outside the main transaction now
   take place with the main patron update transaction.
3. Bigger, better, faster, stronger.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Password verify and password update

These API's now support new-style passwords:

open-ils.actor.verify_user_password
open-ils.actor.user.password.update

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Admin seed data sets new-style passwd

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Password storage release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Admin seed data sets new-style passwd

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 New open-ils.auth_internal service

Service is responsible for adding user data to the authentication cache.
Cache times are determined from opensrf.xml/AOUS settings.  No
authentication checks are performed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Add libpcre to build for open-ils.auth

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 open-ils.auth API salted pw changes

Added .init.barcode and .init.username methods.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Password storage/migration SQL getting started

* Backwards compatible salted password storage using pgcrypt
* Adds actor.passwd and actor.passwd_type tables
* Includes pgtap tests
* Includes installation of pgcrypto

Current flow:

1. Application requests a salt to use as the CHAP-style seed
2. If new-style password exists, salt is returned.
3. Else, old password is migrated and the new salt is returned.
4. App finalizes login by checking verify_passwd.

== continued...

Store the iter_count and start using the crypt_algo column.

Make it possible to change the salt, and potentially strengthen
the salt, when changing passwords.

Make is possible to start salt-less passwords, for pw's that are managed
outside of the DB.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1333254 Improve entry debit maintenance for inv. open/close.

Improve handling of debit->entry links for invoices that cross the
open/close boundary, modifying the number of items invoiced on an entry,
and rolling back invoice entry debits.

Prior to this, some debits would be unnecessarily linked to entries and
fail to clean up properly when rolled back.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1333254 Support closing new invoices

Allow invoices to be closed at create time (as originally intended) by
fixing code thinko.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1333254 Release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1333254 Perl live tests

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1333254 Disencumber on invoice close

Set encumbrance=false on invoiced fund debits when the invoice is closed
(complete=true) instead of when the invoice is created.

To test:

1. Activate a purchase order.
2. Create an invoice for the PO.
3. Confirm PO shows same amount encumbered as befor invoicing and $0
   paid.
4. Close the invoice.
5. Confirm amount encumbered on the PO is reduced by the amount invoiced
   and the amount paid on the PO is increased by the amount invoiced.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1527342 Stamping upgrade script decouple checkout history

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1527342 Improve display of C/O history delete warning

Move the history warning to the top of the form for visbility and avoid
displaying the success message when the warning is also displayed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1527342 Patron CO history CSV update core type

Modify circ.format.history.csv to core type of 'auch' in seed data.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1527342 Patron checkout history CSV export repair

When exporting circ history as CSV, export history objects, not
(unrelated) circ objects.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1527342 Patron checkout history table release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1527342 Patron checkout history PGTAP tests

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1527342 search result history tagging

Use circ history data to indicate circulated items in search results.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1527342 Patron checkout history TPAC display

Checkout history is now derived from the new action.usr_circ_history
table.  When a patron disables circ history, all history is deleted from
the new table.  Also, when disabling circ or holds history, the patron
is now warned if data will be deleted or, in the case of holds, become
inaccessible.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1527342 Patron co history remove on purge

Delete checkout history rows when purging a user.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1527342 Patron checkout history SQL/IDL

Adds a new table action.usr_circ_history for tracking opt-in checkout
history.  History is maintained via trigger on action.circulation.

Includes updates to html/email/csv checkout history templates to
gracefully handle NULL checkin_time values, since history starts as soon
as an item is checked out.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1452950: add release notes

Currently treating this as a technology preview; this may
change before release of 2.10.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 Patron reg pending users

Support loading pending users and removing pending users after save.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 Patron reg. clone user

Implemented Save & Clone.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 date input supports null dates

Leave a date unset when its value is null instead of defaulting to now.
Support unsetting a date when its value is cleared.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 re-attach unload warning after click-through

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 Support free-text stat cats

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 Stat cat maps store values, not links

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 Remove unsaved data warning after click-thru

Once the user clicks through the unsaved data warning, clear the warning
for future navigation.  If more fields are changed, the warning will be
reinstated.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 Unload prompts more handlers / dupe styling

Link in remaining unload onchange handlers.  Use bootstrap alert styles
for dupe patron links.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 Secondary groups dialog scrollable groups list

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 Patron reg pass=phone on new patrons only

When changing a patron's phone number, only modify the password for new
patrons when the org setting patron.password.use_phone is enabled.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 Patron reg avoid data re-fetch

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 Remove dupe/doc floating div dashed border

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 patron reg. unload prompt stub

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 page unload warning prompt service

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 patron reg dupe links wording consistency

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 patron reg refactor alert pane

Create a single top-right floating alert pane which contains both the
duplicate patron links and the field documentation.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 patron dupe search links

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 patron dupe search / plumbing

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 patron reg invalidate fields

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 patron reg secondary groups done

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 Patron reg secondary groups part 1

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 Patron reg loading dialog; more caching

* Hide the patron edit form and show a loading dialog while data loads.
* Cache net access levels and ident types to speed up navigation between
  patron edit and other pages within the patron app.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 patron reg code cleanup

Break up one of the bigger chunks by moving new patron defaults to its
own function.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 Field doc display repair

Set the current field doc via function instead of directly within the
ng-click handler.  For unknown reasons, the direct approach was not
working with addresses.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 survey dates/sorting; stat cat sorting

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 pat. reg surveys and stat cats

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 pat. reg surveys and opt-in settings

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 patron reg additions (phone pw, hiding stuff)

1. Generate password from last 4 digits of phone number if library
setting is present (patron.password.use_phone).

2. Only show "replace barcode" and invlidate buttons when editing an
existing patron.

3. Address no longer defaults to within_city_limits, consistent with
dojo version.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 focus barcode field

For new patrons, focus the barcode field.  For existing patrons, disable
the barcode field (except when a new barcode is needed) and focus the
username field by default.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 username defaults to barcode

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 save/delete/modify addresses

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 extract and save patron settings

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 patron reg i18n repair; more saving

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 patron reg saving new patrons repairs

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 patron reg new patron defaults

Additions and repairs for default user setting values, addr type,
password, net access level, ident type, state.

Also includes repairs for barcode replacements.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 patron reg replace barcode

Replace patron barcode.  Includes duplicate barcode detection, but no
styling/warning is produced when a dupe is found, since the structure
for handling invalid form fields in patron reg does not yet exist.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 patron reg initial save operation

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 patron reg barcodes dialog

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 patron reg post code lookup

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 add/delete patron address

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 browser client patron reg additions

* generate password
* update expire date
* phone / email invalide buttons (display only)

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 quiet chatty grid field logging

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 patron summary show/hide repair

Recover the patron summary show/hide link, which was lost in the
fixed-position elements shuffle.  This moves the patron's name back into
the fixed bar along the top so that it's always visible, as before.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 required/suggested/all fields selectors

Wire up links for Required, suggested, and All fields links.

Also move the patron control bar out to its own template since it must
be loaded from 2 different places in the markup, one for edit and one
for register.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 patron reg fixed css repair

Use CSS-style comments within <style> blocks, not HTML comments, lest
your CSS stops working.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 Patron reg fixed navigation

Make the patron navigation tabs fixed.  Adds a fixed patron
edit/registration action bar.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 Register v.s. Edit patron banners

Register patron now has a page-level banner consistent w/ other
full-page UI's.  Patron edit gets a smaller header since it's nestled
under the patron tabs.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 Patrong reg. style repairs

* Reduce vertical space by a few pixels
* Make field labels non-bold
* Make input fields bold
* Remove duplicate padding to avoid label misalignment.
* Use blue alert-info banner along the top of the screen.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1464767 Patron edit billing => physical

Move toward use of "Physical" label over "Billing" in browser client
patron editor.

See also LP#1068646

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1464767 Sort browser client org selector

Sort each level of the shared org unit tree in the browser client by org
unit shortname.  This primarily affects org unit selectors / dropdowns
(unless otherwise sorted).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 patron reg. UI improvements / repairs

 * floating save, clone, etc pane arranged vertically with less padding.
 * reduce vertical spacing between fields
 * alert_message field rendered as textarea
 * avoid showing 'Example:' label when no phone example exists.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1452950 angularize patron registration phase I

Replace legacy Dojo patron registration / edit UI's in the browser
client with an initial cut of an Angular version.  For this commit, the
UI is basically a wireframe, but the selectors display values and
most fields display the correct values set on the patron.

No save or clone etc. operations or data validation are functional.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1206936 Base SQL schema repair

Avoid referencing money.materialized_billable_xact_summary before it's
defined.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1501516 'paid' lineitem release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Christine Burns <christine.burns@bc.libraries.coop>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1501516 PO lineitem 'paid' indicator

Display a new "paid" label for each lineitem within a purchase
order whose items have all been invoiced (or canceled).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Christine Burns <christine.burns@bc.libraries.coop>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP1402770: Do not show Holds Count by default in most item screens

The Holds Count columns was displaying by default in many xul item interfaces
where this info may not be as useful for staff. Let's hide them by default
in most column pickers, and only display it by default in the patron's Items
Out tab.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP1402770: Release notes entry for holds count column picker

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP1402770_column_picker_option_for_number_of_holds

Added a virtual IDL defintion. Added a OpenSRF method to return
the number of holds that a copy is a member of action.hold_copy_map.
Added javascript column definition to surface this in the xul staff client.
Added the column in the web based staff client as well.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Andrea Neiman <aneiman@kent.lib.md.us>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1206936 Stamping upgrade script; adding test

Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1206936 - Fix wrong billing info in money.transaction_billing_summary

The money.transaction_billing_summary view was showing the wrong
last billing type and last billing note for certain transactions.
This fix, from Dan Scott, in turn from Mike Rylander, recreates
that view so that it depends on the speedier and more accurate
money.materialized_billable_xact_summary view.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>