Create facet for going right to records linked to a given authority record

Still need an upgrade script, of course, but so does this whole branch

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

attempted to add sanity to paging, but not really there yet

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Make linking to bib records work better by saying any format will do.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

working! with paging and linking to bibs, except:

... my new facet thingy doesn't seem to work.  here's what I did
sql-wise:

    INSERT INTO config.metabib_field (
        id, field_class, name, label, xpath,
        format, search_field, facet_field
    ) VALUES (
        28, 'identifier',
        'authority_id', 'Authority Record ID',
        '//marc:datafield/marc:subfield[@code=''0'']', 'marcxml', false, true
    );

    INSERT INTO config.metabib_field_index_norm_map (field, norm)
    VALUES (28, 5);

Yet after re-ingesting my bibs I have nothing new in
metabib.facet_entry.  So the "show related bibliographic holdings" links
don't quite work (I believe they /would/, though, if I had the facet
thingy right).

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Merge branch 'authority-control-sets' of git://git.evergreen-ils.org/evergreen/equinox into authority-control-sets

Finally starting to get somewhere: record display

Record display kind of works.  Need paging and links to bibs.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Merge branch 'master' of git.evergreen-ils.org:Evergreen into authority-control-sets

Duh! How long it can take to find the simplest bugs.

a fieldmapper "at" object has a control_set() method, not a controlSet()
method.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

closer to being able to get authority control set from thesaurus code

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Correct copy-paste-o spotted by Dan Scott

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Merge branch 'authority-control-sets' of git://git.evergreen-ils.org/evergreen/equinox into authority-control-sets

Michael Peters provided a patch to add some missing labels...

... to a key acquisitions interface.  It works.  Also fixed
some unclosed tags while I was at it.

Wasn't sure whether to copy and paste Michael's sign-off or what, but
here's the link to his original patch for purists:
https://launchpadlibrarian.net/74191964/0001-LP802578-Acquisitions-Batch-copy-update-missing-head.patch

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

towards using fielder in openils.AuthorityControlSet

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Fix broken images for items without ISBNs in search results

The search results code happily sets the src attribute of the cover
image to an empty string (as returned by cleanISBN()) if currentISBN has
not been defined (which is generally the case if an item doesn't have an
ISBN, such as a DVD or a thesis or an old book).

Protect against the empty string and set the src attribute to
'/opac/images/blank.png' to avoid broken image indicators in search
results.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Merge branch 'master' of git.evergreen-ils.org:Evergreen into authority-control-sets

Merge branch 'master' of git.evergreen-ils.org:Evergreen

Add a method to generate a URI from extracted or supplied parts (both class and object method)

Signed-off-by: Mike Rylander <mrylander@gmail.com>

batch menus for Volume Edit
refactoring menu generators for CN classes and affixes
description of Auto-Merge checkbox in Volume Edit

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Merge branch 'authority-control-sets' of git://git.evergreen-ils.org/evergreen/equinox into authority-control-sets

working on an auth browser

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Saner behavior for Actions for Selected Holds -> Transfer to Marked Title

* Transfer the actual selected title holds, rather than all title holds for
the bibs referenced by those selected.
* middle layer method for changing the target and resetting specified holds
* label change for clarity, Transfer All Title Holds

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Cleanup of missed commit from the original topic branch

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Merge branch 'master' of git.evergreen-ils.org:Evergreen into authority-control-sets

Pinning upgrade script for copy visibility speed boost

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Unwrapped upgrade script

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Attempt to speed up cache visbility trigger

With the old version merges were timing out.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Configuration interface for config.metabib_field table

This interface enables admins to create and modify the entries used for
defining indexes, faceting, and eventually display.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

Merge branch 'master' of git.evergreen-ils.org:Evergreen into authority-control-sets

Upgrade stamping for "overdues fines on lost checkin" merge

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Unstamped upgrade script for circ.lost.generate_overdue_on_checkin seed data

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Option to generate lacking overdues on lost checkin

New org unit setting "circ.lost.generate_overdue_on_checkin".

This org unit setting enables retroactive overdue fine generation for
lost item checkin.  When enabled, the system will generate overdue fines
starting from the date of the last created overdue fine for the
circulation and working its way up to the checkin time or stopping at
the max fine amount (consistent with regular overdue fine generation).

This differs from the existing org unit setting
"circ.restore_overdue_on_lost_return", which only un-voids existing
overdue fines.

Consider an item whose due date is the 1st, that gets marked lost on the
7th, then checked in on the 14th.  If set,
"circ.restore_overdue_on_lost_return" would un-void the fines created up
to the 7th and "circ.lost.generate_overdue_on_checkin" would create new
overdue fines from the 7th up to the 14th (or up to the max fine
amount).

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Merge branch 'master' of git.evergreen-ils.org:Evergreen into authority-control-sets

Add function to set Control Set by Thesaurus Code

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Normalize fixed field names to OCLC values where they exist (what catalogers are used to)

Signed-off-by: Mike Rylander <mrylander@gmail.com>

with scan missing pieces, retarget affected holds prior to recirculating to previous patron, lest the checkout reset the holds for us without retargeting

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

retarget title holds after transfering to a new bib

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Include Apache configuration instructions in README

Borrowing heavily from the wiki for these instructions, this helps round
out the README. Still more to do.

Signed-off-by: Dan Scott <dan@coffeecode.net>

Show human label for Internet Access Level in Patron Search

Looks like fm_columns uses a prefix of "au_" for the column name defined
in util.js. Therefore, au_net_access_level lets us define the label to
display in place of the integer value.

Signed-off-by: Dan Scott <dan@coffeecode.net>

Specify the display field for linked objects with fm_columns

If a display field isn't specified, it defaults to the key field,
which is essentially the same as not fleshing the object in the first
place.  Let me know if fieldmapper has or gains a way of specifying
such "display" fields, and we can augment fm_columns to use it as well.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Dan Scott <dan@coffeecode.net>

Let fm_columns use cached data.hash objects for linked fields

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Dan Scott <dan@coffeecode.net>

Support Fedora 15 as a target in Makefile.install

Add Fedora 15 to the Makefile.install as a simple clone of the Fedora 14
target for now. Correct Makefile.install target names in README, and
point out that nothing special is required for Fedora 15 for PostgreSQL
9 support.

While we're in the README, rip out the Dojo toolkit install info as
packaged releases include Dojo now (we retain the developer instructions
for installing Dojo manually for git users, of course).

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Merge branch 'master' of git.evergreen-ils.org:Evergreen into authority-control-sets

Add checkout override to SIP2 checkout & renew.

OpenILS::SIP::Transaction::Checkout was modified to allow for
the override of certain, configurable events much in the same
way that checkin currently does overrides.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Merge branch 'master' of git.evergreen-ils.org:Evergreen into authority-control-sets

Respect DESTDIR during the build process

Add $(DESTDIR) to paths it is currently missing from
Manually specify the apxs2 install location so that DESTDIR can be prepended
Attempt to create the apache directory if it does not exist

Signed-off-by: Ben Webb <bjwebb67@googlemail.com>
Signed-off-by: Dan Scott <dan@coffeecode.net>

Merge branch 'authority-control-sets' of git.evergreen-ils.org:evergreen/equinox into authority-control-sets

Merge branch 'master' of git.evergreen-ils.org:Evergreen into authority-control-sets

Stamped DB upgrade script for for XMLAGG cleanup

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Upgrade script for the XMLAGG cleanup

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Address LP#801129, in-db unAPI failure

Cleanup of improper use of XMLAGG in the unAPI stored procs first identified by Bill Erickson in https://bugs.launchpad.net/bugs/801129

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

upgrade script for A/T event def: Hold Cancelled (No Target) Email Notification

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

cat.volume.delete_on_empty org setting.  break up and wrap the upgrade script

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Sample hold cancelled with no target notice

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Cancel bib holds with bib is deleted

And notify user via A/T

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Cancel volume/copy holds on delete

Cancel all holds that directly target a copy or volume when the
copy/volume is being deleted.

Sends async message to A/T for each hold to create and run the
necessary events (e.g.  send cancellation notices).

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

unwrapped upgrade script for cat.volume.delete_on_empty

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Delete volume on last copy setting

When the last copy for a volume is deleted, go ahead and delete the
volume when this new setting is activated.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Option to force-delete copies during volume delete

Added a "force_delete_copies" option to
open-ils.cat.asset.volume.fleshed.batch.update* which forces deletion of
all copies attached to a volume if the volume is being deleted.  There
are still scenarios that will result in copies not being deleted
(e.g. copy is checked out), in which case the override option will
behave here the same way it behaves in
open-ils.cat.asset.copy.fleshed.batch.update*

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Stamp the upgrade with a version number

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Un-stamped upgrade script for collection exempt perm

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Permission to control patron-collections-exempt

Adds a new permission 'UPDATE_PATRON_COLLECTIONS_EXEMPT' which controls
who can toggle the circ.collections.exempt user setting in the patron
registration interface.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

config ui trivial improvements, scratching out a place for a browse UI

bump xulrunner version

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Merge branch 'master' of git.evergreen-ils.org:Evergreen into authority-control-sets

Fix minor glitch when trying to create new authority fields

The Autogrid can handle empty arrays as values for acsaf.bib_fields and
acsaf.axis_maps, but can't handle undefined.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Move the authority control set config interfaces back into conify

Really, that's where they make sense.  And they're done.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Axis-field map editor and editor for the axes themselves

The editor for the axes themselves is accessed directly from staff
client menu.  Everything else is reached indirectly from the control set
editor.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Check if hold is really available in Trigger::Validator.

Add checks for shelf time and no fulfillment time in
HoldIsAvailable in OpenILS::Application::Trigger::Validator.

We've had some issues with poorly migrated data and people
messing with holds that causes the original logic to trigger
for unfilled holds. Plus, the extra precaution of checking
more precise conditions of an actually filled hold can't hurt,
can it?

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Merge branch 'authority-control-sets' of git://git.evergreen-ils.org/evergreen/equinox into authority-control-sets

Add bib field editor.  Also make all the editors written so far...

... for authority control sets-related objects do the right thing to
help users create/edit new child objects linked to the right parent
table without extra effort.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Merge branch 'master' of git.evergreen-ils.org:Evergreen into authority-control-sets

Ability to return to specific authority.control_set or

to specific authority.control_set_authority_field from a child table.
Other improvements heading toward finishing authority control set config UI

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Make bucket content retrieval authoritative

LP#492036, we neeed all bucket methods to be authoritative.  Some already were, this finishes the job.

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Further clean-up of Serials interfaces

When trying to come up with good tests, found a few bugs (imagine!).
Some have been nagging for a while now.

1) For 'MFHDDrawn' event, make sure it runs if deleting the last
serials data of any kind for that record (to unpopulate the menus
properly)

2) Make sure global mfhd member (g.mfhd) is cleared in the same case
(i.e. deleting the last serials data for that record)

3) Add a string to better indicate when no MFHD records are available
for 'Legacy Record Entry' drop-down

4) Convert submitted empty drop-down values to 'null' as needed in
distribution editor

5) Mark subscription 'start date' as a required field

6) Make serial virtual records better handle deleted 'legacy record
entries' attached to distributions, and also expose non-deleted
record entries even if in 'use_sdist_only' summary mode

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Better coordination of MFHD/SRE adding/deleting

Adding or deleting MFHD records from the XUL menus requires
coordinating the OPAC display, the XUL menus, and the Serial
Control distribution editors.  The previous code frequently
required some non-obvious manual refreshing to make it work.

This commit keeps them in sync using custom events instead.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Add unit tests for LP 800269 - holdings for captions only

Running "prove -l lib" in Open-ILS/src/perlmods shows that the two new
unit tests pass, whereas they fail using the previously installed
version of MFHD.pm. Good evidence that the fix from dbwells does indeed
solve the reported bug.

Signed-off-by: Dan Scott <dan@coffeecode.net>

MFHD compressed holdings short-circuit logic

If you attempt to get compressed (or uncompressed) holdings from
a MFHD record with only a caption, the code should short-circuit
and return an empty list.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dan Scott <dan@coffeecode.net>

Update serial.unit auditor table along w/ asset.copy change

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Merge branch 'authority-control-sets' of git.evergreen-ils.org:evergreen/equinox into authority-control-sets

Merge branch 'master' of git.evergreen-ils.org:Evergreen into authority-control-sets

Wrapped DB script

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Unwrapped upgrade script for active date

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Active date

Record the date a copy first became "active" after creation in active_date.
Offer Org Unit setting for using the active date for age hold protection.
Any copy without an active_date, with age hold protect using it, will be
    protected until it has an active date. Regardless of create_date.
Circ/Hold matrix can match on item age based on active_date.

Active is defined as entering a status with copy_active set to true. By default:

Available
Checked out
Reshelving
On holds shelf
ILL
Reserves
On reservation shelf

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Refactor cover image fetching in OpenLibrary added content

We were only trying to retrieve images from the items array in the
OpenLibrary response, but there are only items if the OpenLibrary has
online editions available - whereas there may be covers attached to the
metadata for the work. So now we make the metadata work harder.

Also, cut down on broken images in search results by short-circuiting if
OpenLibrary doesn't have a matching record for a given ISBN.

Thanks to Bill Erickson for pointing out that there were a lot of blank
images getting returned due to the items reliance.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Teach result_common.js to OpenLibrary requests

Now that the proxied OpenLibrary requests are working, teach
result_common.js to use them and get an advantage from being an
access-rights-authenticated IP address (if applicable).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Support proxying bulk Read API requests for access rights

Using IP-based access right determination runs into problems with a pure
JavaScript API, as users may be accessing the API from any location in
the world. Proxying the requests via the library system server ensures
that the access rights for users of those libraries are properly
displayed.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Return transparent images if no cover art is found

For now the URL is hardcoded; later on we'll refactor AddedContent.pm to
give us access to more information about our Apache environment to
default to something much, much smarter.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Working TOC HTML and cover images from OpenLibrary Read API

TOCs are now part of the "data" response in the Read API.

Covers are accessed with the "cover" key in the "items" objects.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Get OpenLibrary covers from any related items

Cover requests for exact matches sometimes fail to produce results, but
covers from similar items (other editions of the same work) are often
available. Take that!

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Begin cutting AddedContent over to the OpenLibrary Read API

Use the all-in-one Read API request to get results; this should
cut our requests in half and improve our caching results.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Don't make OpenLibrary requests without an ID

It is rather silly to make requests if you have not pulled any IDs out
of the records to pass along to OpenLibrary, so do not do that. Also
refactor and add a bit more defensiveness.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Implement OpenLibrary ebook availability via Ajax

George Oates provided an OpenLibrary GIF to use for the
links, and we can drop the links right into the block of
white space between copy counts and bibliographic info.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

integrate the OpenLibrary Read API into search results

Still early days, but works based on the sample Read API
output provided by Mike for a single ISBN search.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Merge branch 'authority-control-sets' of git://git.evergreen-ils.org/evergreen/equinox into authority-control-sets

Editor for authority fields

Due to time constraints (and AutoGrid limitations) a click-through UI
with separate pages for separate objects used by the new authority
control sets feature is necessary for now rather than a comprehensive
interface with multiple grids on the same page.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Thesauri editor

Merge branch 'master' of git.evergreen-ils.org:Evergreen into authority-control-sets

Fixed bad DB version number in upgrade script.  Thanks for the heads up, tsbere

Signed-off-by: Bill Erickson <berick@esilibrary.com>

moving stuff where it goes

Merge branch 'master' of git.evergreen-ils.org:Evergreen