Merge branch 'master' of git.evergreen-ils.org:Evergreen into user/berick/lp1626157-ang2-combo

Move eg2 src into top src dir

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1755917: Fix Acq Admin menu order

According to commit cac16285aca, the acq admin menu is supposed to be in
alphabetical order. However, one item remains out of place. This commit
fixes that.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1691263: discourage input of newlines in MARC editor

This patch catches and discards enter keydown events when the
focus is in a contenteditable subfield value div; otherwise, newlines
can infect the MARC record.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1691263: make webstaff MARC editor wrap long fields

This patch makes the MARC editor wrap long fields (e.g.,
bibliographic 505 fields) so that they fit the width of the enclosing
window or modal. The approach taken is replacing the text input
elements with contenteditable divs, which in turn can be better
styled.

To test
-------
[1] Apply the patch.
[2] Locate a record with a long 505 field and open it in the
    MARC editor. Verify that the contents of the field wrap.
[3] Verify that record editing and saving work as expected.

Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: Fix AsciiDoc list formatting

AsciiDoc lists (numbered or bulleted) generally need to be preceded by a
blank line. If not, they will be absorbed into the previous paragraph of
text.  This commit fixes two occurrences of this.

Signed-off-by: Remington Steed <rjs7@calvin.edu>

Docs: Update Authorities.adoc

  - Revised instructions to match web client.
  - Added new screenshots.
  - Improved instructions for "Non-filing indicator".
  - Minor line formatting changes.

Signed-off-by: Remington Steed <rjs7@calvin.edu>

Docs: Add directions for configuring columns

Includes screenshots and instructions on how to expand, shrink and move
columns left and right. Also updates some explanation to match how the
web client stores column settings.

Signed-off-by: Remington Steed <rjs7@calvin.edu>

Lp 1411422: Fix & rename test file.

The tests added for this branch had a bad plan.  It specified 7 tests were
to be run when actually there are 8.

I also renumbered the file to be 26, so that there would be only 1 test
numbered 25.

Signed-off-by: Jason Stephenson <jason@sigio.com>

Lp#1411422: Clean up the code a little bit.

We don't need to left join when we flesh fields.

Signed-off-by: Jason Stephenson <jason@sigio.com>

LP1411422 Copy details repeated in search results when item/volume moved with parts attached

Added regression test and tweaked the part lookup query to remove deleted parts.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP1411422 Copy details repeated in search results when item/volume moved with parts attached

Added the code in perl to respect the existence of parts. Both "transferring volume"
and "transferring items". "Transferring items" was coded to use
open-ils.cat.asset.copy.fleshed.batch.update which means most of the work was done in js.
The web based staff client is coded to use open-ils.cat.transfer_copies_to_volume.
Decided to use that method for xul as well. Making it more consistent with the "transferring
volume" code. Considered coding it to move the part level holds to the destination part but
it's possible that the source part still has items.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1751318 Remove direct tablesort import

Avoid attempts to directly import angular-tablesort.js from the offline
interface.  The script is already included in vendor.bundle.js and the
direct import, which refers to a nonexistant file, breaks the Perl live
test for offline dependency checking.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>

Docs: Update SMS_messaging.adoc for web client

  - update instructions to match web client
  - small whitespace change

Signed-off-by: Remington Steed <rjs7@calvin.edu>

Docs: Update copy_statuses.adoc for web client

  - new screenshots for adding, editing, deleting
  - update instructions to match web client

Signed-off-by: Remington Steed <rjs7@calvin.edu>

Docs: Update "Circulation - Patron Record" for web client

  - Replace screenshots. Thanks to Kevin Tran for many of the new
    screenshots.
  - Update instructions to match web client.

Signed-off-by: Remington Steed <rjs7@calvin.edu>

Merge branch 'master' of git.evergreen-ils.org:Evergreen

Docs: correcting funder names for 3.1 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1750912 - Add add_translations.py convenience script to i18n tools.

This script was authored by Jason Stephenson, who has kindly
agreed to add it to the Evergreen source tree.  As Jason suggested,
I modified the GPL version number to 2 to be in line with the
Evergreen project's licensing requirements.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: adding more funders to 3.1 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: adding translators to 3.1 release notes acknowledgements

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: adding code contributors to 3.1 release notes acknowledgements

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: adding some funding orgs to release notes acknowledgements

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: Fix broken include in root.adoc

A recent commit added a section to root.adoc and root_cataloging.adoc.
The reference was correct in the second file, but in the first file was
missing the subdirectory. This commit adds it.

Signed-off-by: Remington Steed <rjs7@calvin.edu>

Docs: Remove docs not applicable in web client

A few docs chapters relate to features that don't exist (yet) in the web
client, so this commit removes those from the table of contents
(root*.adoc).

Also, duplicate content was found during the web client docs review, so
this commit removes the nearly identical docs file and replaces its
references with references to the slightly better version of the file.

Signed-off-by: Remington Steed <rjs7@calvin.edu>

Fix billing / negative balance test cases

The test cases are set up manually via SQL, but were not taught about
the new data needed for billings.  This caused two tests to fail.

Let's go ahead and update this whole block to have more realistic data
conforming to the new scheme.

Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1717593: Missing strings cause serial item delete (and status change) failures

There are two places in the code that expect a serial-related string to exist,
but neither do.  So, let's correct that.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1753008 Load iframeResizer via script tag

iframeResizer does not currently play nicely with webpack.  Load it
directly via script tag for now.

This resolves a problem where the iframe fails to fill the screen when
loading the reports UI in the browser client.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1626157 more service downgrades; docs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Docs: Update "Alternate Hold Pick up Location" for web client

  - New screenshot
  - Remove instructions for changing location label (e.g. "Drive-thru")
  - Wrap long lines to 72 characters (if those lines were changed)

Signed-off-by: Remington Steed <rjs7@calvin.edu>

Docs: Use raw ampersand '&' to fix conversion error

The AsciiDoc to DocBook conversion process seems handle raw ampersands
just fine, but sometimes chokes on the special entity forms like {amp}
or &#38; . No more fancy talk. Just simple '&'.

Signed-off-by: Remington Steed <rjs7@calvin.edu>

Docs: Fix '&' DocBook conversion error

Using the AsciiDoc named character reference {amp} seems to have
converted to a plain '&' too early, causing the DocBook XML validation
to fail. Let's try a numerical reference: &#38;

Signed-off-by: Remington Steed <rjs7@calvin.edu>

Docs: adding web client screenshot

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: updating return-to-search results for Web client

Docs: adding contributor to 3.0.4 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: Update search_interface.adoc for web client

  - added a screenshot because the instructions seemed to lack a visual
  - changed step 1 from "Search Facet Groups" to "Search Filter Groups"

Signed-off-by: Remington Steed <rjs7@calvin.edu>

Docs: Update "Monograph Parts" for web client

  - Replace screenshots
  - Reformat long lines to around 72 characters
  - Convert numbered list to automatic numbering
  - Update instructions to match web client

Thanks to Kevin Tran for the screenshots.

Signed-off-by: Remington Steed <rjs7@calvin.edu>

LP#1626157 Downgrade ang2 Title service to fix titles

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Docs: Update "Circ Triggered Events" for web client

Added edits for first section "Access and View".

Signed-off-by: Remington Steed <rjs7@calvin.edu>

Docs: Edits and images for "Managing Holds"

Signed-off-by: Remington Steed <rjs7@calvin.edu>

Docs: Update "Managing Holds" for web client

- changed "Actions for Selected Holds" to "Actions"
- several new screenshots
- some instructions updated
- merged and updated steps 3.E - 3.F, and created a new screenshot "holds-managing-5 and 6.JPG" (that will take place of the two current screenshots)

Signed-off-by: Remington Steed <rjs7@calvin.edu>

Docs: Edits and images for "Resetting Patron's Password"

Signed-off-by: Remington Steed <rjs7@calvin.edu>

Docs: Update "Resetting Patron's Password" for web client

A new screenshot has been created. The description in the instructions
have been changed. Some button names have been updated and verify
password has been removed.

Signed-off-by: Remington Steed <rjs7@calvin.edu>

LP#1626157 eg-migration is a separate app

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1626157 per-page setup ; downgrade service example

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Combo experiements

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Combo experiements

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 ang-cli version update

https://github.com/angular/angular-cli/issues/9307

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 ang2 logout/auth repairs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 ang2 catalog tweaks

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 ang2 misc tidying

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 ang2 perms

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 sessionPoll; cleanup

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 consistent naming; less custom css

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments - copy query

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>