contrib/Conifer.git
10 years agoLP#1390138: Updated upgrade docs for 2.7.1
Josh Stompro [Thu, 6 Nov 2014 22:16:26 +0000 (16:16 -0600)]
LP#1390138: Updated upgrade docs for 2.7.1

Missed one instance of 2_6_1 in the /openils/var/web/xul server symlink section.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1390138: Updated upgrade docs for 2.7.1.
Josh Stompro [Thu, 6 Nov 2014 17:24:31 +0000 (11:24 -0600)]
LP#1390138: Updated upgrade docs for 2.7.1.

Added in section about checking the release notes for other upgrade steps to the end.

Added in the step to restart memcached as Galen Charlton mentioned in his 11/5 dev list email
about clearing out old login sessions for security reasons.

Added in Jessie and Trusty with a pointer to the Ruby EDI bug that users of the distributions
will run into.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1413660: Stamping upgrade script to change z3950 function
Ben Shum [Tue, 3 Feb 2015 21:12:14 +0000 (16:12 -0500)]
LP#1413660: Stamping upgrade script to change z3950 function

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1413660 Mark 39.50 config function STABLE
Bill Erickson [Thu, 22 Jan 2015 16:57:43 +0000 (11:57 -0500)]
LP#1413660 Mark 39.50 config function STABLE

Mark SQL function evergreen.z3950_attr_name_is_valid(text) as STABLE
instead of IMMUTABLE, since the output may vary with a single input over
time.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1078593 Regenerate summaries when deleting issuances
Dan Wells [Tue, 8 Apr 2014 20:22:33 +0000 (16:22 -0400)]
LP#1078593 Regenerate summaries when deleting issuances

Both interfaces currently allow you to delete issuances even if they
have items attached and have the delete cascade.  While this might be
a dangerous allowance, we should still make sure to keep our summaries
updated when this happens.

This commit adds automatic summary regeneration when deleting issuances
in either serials interface.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1078593 Add method for regenerating serial summaries
Dan Wells [Wed, 10 Apr 2013 22:42:11 +0000 (18:42 -0400)]
LP#1078593 Add method for regenerating serial summaries

Right now, serial summaries only update when receiving or
resetting items. They need to update more often, so lets start
by adding a method just for doing that.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1078593 Assorted small Serial.pm fixes
Dan Wells [Tue, 8 Apr 2014 20:11:31 +0000 (16:11 -0400)]
LP#1078593 Assorted small Serial.pm fixes

1) fleshed_issuance_alter() changes
  - First, if one of the inner updates returns an event, abort early.
    Otherwise, we might overwrite the event while looping and lose
    the error.
  - Second, add authtoken to the created editor.  This editor gets
    passed around, and other functions might look for it there.

2) pass $type down into _summarize_contents()
  - Right now, we have a bug where supplement/index contents in a
    merged MFHD record will get added to the basic contents (and
    vice-(vice-)versa).  By passing in $type, we can assure that
    we only return the type of contents we are looking for.

3) _prepare_summaries() should acknowledge empty summaries
  - Under normal use, summaries will generally grow, and never shrink
    to nothing.  However, we must still handle cases where we have
    discarded/deleted our last issuance, and in those cases, make sure
    we "empty" the generated_coverage field in our summary.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1415572: Stamping upgrade script for ensuring correct version of authority.normali...
Ben Shum [Tue, 3 Feb 2015 21:01:17 +0000 (16:01 -0500)]
LP#1415572: Stamping upgrade script for ensuring correct version of authority.normalize_heading

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1415572: ensure correct version of authority.normalize_heading() is in place
Galen Charlton [Wed, 28 Jan 2015 17:24:02 +0000 (17:24 +0000)]
LP#1415572: ensure correct version of authority.normalize_heading() is in place

Some upgraded Evergreen databases can have the wrong version
of the authority.normalize_heading() function in place because
of a mixup in the 0848 schema upgrade script.  The problem can
manifest itself by there being rows in authority.record_entry
where the heading and simple_heading columns have "NOHEADING"
values regardless of the control set:

-[ RECORD 1 ]--+---------------------------------------------
heading | NOHEADING_a ff0ed9fcd13e8944d9a718650840787a
simple_heading | NOHEADING_a ff0ed9fcd13e8944d9a718650840787a

This patch ensures that the correct version is in place and
updates authority.record_entry to fix up affected rows without
requiring a full authority ingest.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1414112: Stamping upgrade script for spaces in record attr values
Ben Shum [Tue, 3 Feb 2015 20:54:05 +0000 (15:54 -0500)]
LP#1414112: Stamping upgrade script for spaces in record attr values

Signed-off-by: Ben Shum <bshum@biblio.org>
Conflicts:
Open-ILS/src/sql/Pg/002.schema.config.sql

10 years agoLP#1414112: Correct usage of WITH clause for UPDATE.
Chris Sharp [Tue, 27 Jan 2015 18:33:39 +0000 (13:33 -0500)]
LP#1414112: Correct usage of WITH clause for UPDATE.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1414112: Seed data and avoid reingest
Mike Rylander [Mon, 26 Jan 2015 16:44:45 +0000 (11:44 -0500)]
LP#1414112: Seed data and avoid reingest

Update search metadata without a reingest by identifying records that
use a space in the audience field, and be sure that the coded value map
has a space for "uncoded" audience.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1414112: avoid excluding record attribute values that contain only blanks
Galen Charlton [Mon, 26 Jan 2015 16:05:10 +0000 (16:05 +0000)]
LP#1414112: avoid excluding record attribute values that contain only blanks

Certain record attributes, chiefly the ones whose values comes
from MARC fixed fields and which have a coded value map associated
with them, can have a string consisting of one or more blanks as a
valid value.  Consequently, this patch ensures that
reingest_record_attributes() no longer excludes all attributes that
have blank values from the final attribute list.

This fixes a problem where MARC records with the target audience (008/22)
coded as a blank (unknown or not specified) could no longer be retrieved
using an "audience( )" search filter.

After applying this patch, a reingest of record attributes should be
performed, e.g., by doing

  select metabib.reingest_record_attributes(id)
  from biblio.record_entry
  where not deleted;

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1389403 Normalizer detection compatibility with LP#1373693
Dan Wells [Wed, 19 Nov 2014 17:16:03 +0000 (12:16 -0500)]
LP#1389403 Normalizer detection compatibility with LP#1373693

In LP#1373693, $ou_ids become an optional argument when at the top of
the tree.  We need to account for that.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1415898 Fix Potential Cstore Starvation in the OPAC
Jason Stephenson [Thu, 29 Jan 2015 13:02:03 +0000 (08:02 -0500)]
LP#1415898 Fix Potential Cstore Starvation in the OPAC

When a user views their current circulations and/or renews them via
the OPAC, a connection is made to a cstore drone so that the user's
circulations can be retrieved from the database, bypassing the cache.
This connection is not closed, and thus a cstore drone is left unable
to respond to new requests for several seconds.  On a busy server,
this has actually caused the number of cstore drones to hit the limit
configured in opensrf.xml.  If that situation continues for too long,
it leads to the load on the server spiking to the point where services
must be restarted.

This commit changes from xact_rollback to rollback so that the connection
will be closed.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
10 years agoLP#1415898 Fix Potential Cstore Starvation in KPAC
Jason Stephenson [Thu, 29 Jan 2015 12:59:07 +0000 (07:59 -0500)]
LP#1415898 Fix Potential Cstore Starvation in KPAC

The getit_results function in EGKPacLoader.pm does xact_begin, which
opens a connected session to a cstore drone.  It later does xact_rollback,
which does not disconnect the session.  This leaves a drone hanging for
several seconds unable to responde to new requests.  This commit switches
to a rollback call that does disconnect the session.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
10 years agoLP#1412893: Only apply lost and paid status with the proper transactions
Ben Shum [Wed, 21 Jan 2015 21:30:53 +0000 (16:30 -0500)]
LP#1412893: Only apply lost and paid status with the proper transactions

As discovered while testing the lost and paid feature, when closing earlier transactions where
the item is currently lost, it could change the item status to lost and paid prematurely.

Change the logic so that it only does this if the current transaction being closed either has
a status of lost or longoverdue.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
10 years agoLP#1396161: Improve public docs and change osrf-config default from script help
Remington Steed [Wed, 26 Nov 2014 14:21:52 +0000 (09:21 -0500)]
LP#1396161: Improve public docs and change osrf-config default from script help

The public docs have an "Action Triggers" chapter, so this commit
applies the same improvements there to match the help docs in the
script. Also in the public docs, in two places a filename was split
across lines, causing a gap to appear in the HTML version of the docs.
That is corrected here.  This commit also removes the 'osrf-config'
option from the examples in the script help docs, since they are using
the default value.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1396161: action_trigger_runner.pl documentation update
Josh Stompro [Tue, 25 Nov 2014 21:56:50 +0000 (15:56 -0600)]
LP#1396161: action_trigger_runner.pl documentation update

 - Removed --granularity-only help docs.  Ever since the script was changed to
   support parallel execution of different granularity levels the granularity-only
   setting has always been set when using --granularity.

 - Added --verbose help docs.  This option wasn't included in the help docs.

 - Clarification - added some clarification to a few of the help descriptions.

 - Added an additional example for processing hooks and running pending events
   with a granularity set.

 - Removed two references to the --granularity-only flag in the Telephony docs.

I believe this change is valid for 2.7, 2.6 and 2.5 since the change to the script
 was made in 2010.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1413490 Fix <table><table> markup
Dan Scott [Thu, 22 Jan 2015 06:48:19 +0000 (01:48 -0500)]
LP#1413490 Fix <table><table> markup

Doesn't really have an effect on the display, as XULRunner automatically
repairs it dynamically, but might as well be correct.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1373594: Also ignore subfield 7 in get_graphics_880s
Ben Shum [Tue, 16 Dec 2014 19:34:12 +0000 (14:34 -0500)]
LP#1373594: Also ignore subfield 7 in get_graphics_880s

In the Czech Republic the subfield 7 of MARC fields 1XX and 7XX are used for
the National authority control number.

The problem is, that in current Evergreen versions, the subfield 7 is displayed
as a part of the link to author seach in search result or record details, but
when using the linkt to search rcords of the same author, no results are
returned, no matter whether the records exist or not.

That is why we nedd to add the subfield 7 into get_graphic_880s.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
10 years agoLP#1407171 Avoid DEFLATEing fm_IDL.xml
Bill Erickson [Fri, 2 Jan 2015 22:50:26 +0000 (17:50 -0500)]
LP#1407171 Avoid DEFLATEing fm_IDL.xml

Prevent fm_IDL.xml from going through the Apache DEFLATE filter before
it's passed off to IDLCHUNK, which is unable to process deflated files.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1398926: Allow symbol popup to trigger on new marc fields
Thomas Berezansky [Wed, 3 Dec 2014 18:18:27 +0000 (13:18 -0500)]
LP#1398926: Allow symbol popup to trigger on new marc fields

Or rather, new MARC text entry boxes in general.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
10 years agoLP 1372197: Fixed another link to evergreen-ils.org that changed.
Josh Stompro [Wed, 24 Sep 2014 20:39:30 +0000 (15:39 -0500)]
LP 1372197: Fixed another link to evergreen-ils.org that changed.

Server upgrade section had a link to http://evergreen-ils.org/downloads.php that is now
http://evergreen-ils.org/egdownloads/

Signed-off-by: Josh Stompro <github@stompro.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP 1373197: fixed default "Get Help With Evergreen" link.
Josh Stompro [Wed, 24 Sep 2014 19:48:16 +0000 (14:48 -0500)]
LP 1373197: fixed default "Get Help With Evergreen" link.

The "Get Help" link was pointing to a 404 page, fixed it so it points at the correct page.

Signed-off-by: Josh Stompro <github@stompro.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1310619: Changing relationship between rcil and legacy stat cats to "might_have".
Chris Sharp [Tue, 6 May 2014 17:20:20 +0000 (13:20 -0400)]
LP#1310619: Changing relationship between rcil and legacy stat cats to "might_have".

After discussion with Mike Rylander, I've changed "has_a" to "might_have"
to make left joining rcil and legacy stat cat sources the default behavior.

For reference, see: http://irc.evergreen-ils.org/evergreen/2014-05-06#i_95055

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1310619: Add links in reporter.classic_item_list to legacy_cat1 and legacy_cat2...
Chris Sharp [Mon, 21 Apr 2014 13:10:28 +0000 (09:10 -0400)]
LP#1310619: Add links in reporter.classic_item_list to legacy_cat1 and legacy_cat2 views.

Currently, the reporter.classic_item_list view has the Legacy Cat 1 and 2
fields defined as "text", not "link", so all it will report out is the ID
number of the stat cat.  We want nullability control over stat cat entries,
so these need to be "link".

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1408803 Add 'persist' login type to auth_proxy sample config
Dan Wells [Thu, 8 Jan 2015 21:30:59 +0000 (16:30 -0500)]
LP#1408803 Add 'persist' login type to auth_proxy sample config

A recent version of EG added the option to "stay logged in", and this
was implemented as a new login type. Since basically everyone will use
this option via the OPAC, it makes sense that this should be part of the
sample config for auth_proxy.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
10 years agoLP#1395456: (Fixing) Add back missing 0901 upgrade script
Ben Shum [Mon, 12 Jan 2015 16:52:22 +0000 (11:52 -0500)]
LP#1395456: (Fixing) Add back missing 0901 upgrade script

I apparently fumbled the upgrade script and it was lost in the action.
LP#1395456 is now closed with adding back this script to the repositories.

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoMake Vandelay merge profile names translatable.
Pasi Kallinen [Thu, 4 Jul 2013 09:00:48 +0000 (12:00 +0300)]
Make Vandelay merge profile names translatable.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
10 years agoLP#1414033: Add rel="nofollow" to search/browse links
Dan Scott [Fri, 6 Feb 2015 22:13:27 +0000 (17:13 -0500)]
LP#1414033: Add rel="nofollow" to search/browse links

Mark links in the TPAC that robots should not attempt to crawl (such as
search results, call number browsing, adding records to temporary lists,
placing holds, logging in) using the rel="nofollow" convention, per
https://support.google.com/webmasters/answer/96569?hl=en

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Conflicts:
Open-ILS/src/templates/opac/parts/record/navigation.tt2

10 years agoMerge branch 'feature/circ_scripts_2_7' into rel_2_7_mergery
Dan Scott [Thu, 22 Jan 2015 18:59:26 +0000 (13:59 -0500)]
Merge branch 'feature/circ_scripts_2_7' into rel_2_7_mergery

10 years agoAdd distance education loan periods feature/circ_scripts_2_7
Dan Scott [Thu, 22 Jan 2015 18:57:23 +0000 (13:57 -0500)]
Add distance education loan periods

Signed-off-by: Dan Scott <dscott@laurentian.ca>
10 years agoLP#1409844: Towards more meaningful catalogue <title> elements
Dan Scott [Mon, 12 Jan 2015 18:13:03 +0000 (13:13 -0500)]
LP#1409844: Towards more meaningful catalogue <title> elements

Currently the catalogue <title> elements are formed by concatenating the page
title to "Catalog - ". This means that on browsers with more than a few tabs
open, users will only see "Catalog -", which doesn't help them navigate their
tabs. Also, in search results in general search engines, "Catalog - " is
expected to be a significant word as it appears first in the title of the page.

Instead, let's remove the "Catalog - " prefix entirely and add "- <library
name>" as a suffix to the page title. That way, a user will see the page title
in bookmarks, search results, and other contexts with the most important
information up front (whether that's the title of the work in record details,
or the fact that it's a search for some string), followed by the name of the
library to give it a specific context.

In addition, use the name of the library in the OpenSearch definition to be
more meaningful than the current hardcoded "Evergreen OpenSearch" (many users
will not even know what Evergreen is, if they stumble across the little "Add
search engine" widget at all).

And finally, use the HTML and URI filters appropriately to avoid any possible
damage :)

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Conflicts:
Open-ILS/src/templates/opac/parts/base.tt2

10 years agoLP1406025 Return 404 or 410 HTTP status codes for bibs
Dan Scott [Sun, 28 Dec 2014 01:25:50 +0000 (20:25 -0500)]
LP1406025 Return 404 or 410 HTTP status codes for bibs

If a record has been deleted, return a 410 Gone status code; if it doesn't
exist at all, return a 404 Not Found code.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
10 years agoLP1406451: Prevent some catalogue pages from being indexed
Dan Scott [Sun, 11 Jan 2015 03:09:48 +0000 (22:09 -0500)]
LP1406451: Prevent some catalogue pages from being indexed

Tell search engines that they should not index search results
pages, call number browsing pages, and the like. We really
just want them to focus on records and the library pages.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
10 years agoLP1406451 Set rel=canonical for record and library pages
Dan Scott [Wed, 31 Dec 2014 05:33:41 +0000 (00:33 -0500)]
LP1406451 Set rel=canonical for record and library pages

Search engines use the "<link rel=canonical>" convention to determine that, no
matter how many variations on a URL you might generate through the likes of
appending &query= parameters, etc, those URLs are all the same as the value of
the href attribute in the <link> element.

Start with a simple implementation that, first, provides a placeholder in the
TPAC base where any page-specific <meta> or <link> (or really, any other <head>
contents) should go; then denotes the current page URL (stripped of all query
params) as the canonical URL for record and library pages.

This should help prevent search engines from crawling endless variations of the
same page, lowering load on Evergreen servers and potentially improving the
ranking of the canonical URLs.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
10 years agoLP1406025: Provide graceful human output for HTTP errors
Dan Scott [Sun, 28 Dec 2014 03:35:37 +0000 (22:35 -0500)]
LP1406025: Provide graceful human output for HTTP errors

For the expected HTTP errors of HTTP_GONE (record deleted)
and HTTP_NOT_FOUND (record never existed), return the HTML
pages that we used to return (red border warning that the
record was deleted, or just an empty template for
non-existing records) so that the user can at least try
another search. However, the HTTP status code gets set to
410 or 404 as expected so that machines can react
accordingly.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
10 years agoLP#1031335 No-op the escape_email_header helper
Dan Scott [Wed, 7 Jan 2015 23:22:22 +0000 (18:22 -0500)]
LP#1031335 No-op the escape_email_header helper

As suggested by Mike Rylander, keep the escape_email_header helper
around to avoid breaking templates that already adopted it, but make it
a no-op as the SendEmail reactor now encodes the email headers of
interest by default.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
10 years agoAdd and use a patron search that overrides opt-in invisibility
Dan Scott [Wed, 14 Sep 2011 20:02:14 +0000 (16:02 -0400)]
Add and use a patron search that overrides opt-in invisibility

Something like this is required for API calls that need to operate
against a number of libraries in a given instance that are using opt-in;
otherwise, attempts to search for users will fail and you may end up
creating near-duplicates etc.

The implementation adds an
open-ils.actor.search.patron.advanced.opt_in_override method to
open-ils.actor, which, if invoked, checks to see if the caller has the
OPT_IN_OVERRIDE permission. If so, then the crazy_search ignores the
normal opt-in limits and searches all pertinent users in the database.

As a global permission, OPT_IN_OVERRIDE is a blunt instrument. Others
might want to put together a more refined version that uses OU depths to
define boundaries.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm
Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/actor.pm

Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm
Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/actor.pm

10 years agoMerge branch 'rel_2_7' of git.evergreen-ils.org:Evergreen into rel_2_7_mergery
Dan Scott [Fri, 26 Dec 2014 13:45:36 +0000 (08:45 -0500)]
Merge branch 'rel_2_7' of git.evergreen-ils.org:Evergreen into rel_2_7_mergery

10 years agoLP#1319964 "Summaries & More" displays improperly in TPAC
Michael Peters [Mon, 8 Dec 2014 17:08:21 +0000 (12:08 -0500)]
LP#1319964 "Summaries & More" displays improperly in TPAC

Commit 14eb3d30 added HTML-escaping of OPAC extras display
labels, meaning that if an ampersand in such a label is
desired, it should be entered in the template just as an ampersand.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
[Amended original commit to tweak message and remove unecessary changes
 to .po files, which are rebuilt when a release is rolled.]

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoForward-port 2.7.1-2.7.2 upgrade script
Ben Shum [Wed, 17 Dec 2014 21:04:33 +0000 (16:04 -0500)]
Forward-port 2.7.1-2.7.2 upgrade script

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoUpdate the Conifer 2.4-2.7 upgrade script
Dan Scott [Wed, 17 Dec 2014 04:15:37 +0000 (23:15 -0500)]
Update the Conifer 2.4-2.7 upgrade script

Signed-off-by: Dan Scott <dscott@laurentian.ca>
10 years agoMerge branch 'rel_2_7' of git.evergreen-ils.org:Evergreen into rel_2_7_mergery
Dan Scott [Wed, 17 Dec 2014 05:02:21 +0000 (00:02 -0500)]
Merge branch 'rel_2_7' of git.evergreen-ils.org:Evergreen into rel_2_7_mergery

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Conflicts:
Open-ILS/src/templates/opac/parts/record/summary.tt2

10 years agoLP#1402905 Use stricter matching for UPC values
Dan Scott [Tue, 16 Dec 2014 04:23:49 +0000 (23:23 -0500)]
LP#1402905 Use stricter matching for UPC values

Per http://www.loc.gov/marc/bibliographic/bd024.html we
should be checking to see if either the ind1 is "1" or
if there's a subfield 2 with a value of "upc" before
assuming that any "Other standard identifier" 024 field
is a UPC value.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#921142: Bring back automatic padding of short fixed fields in the GUI MARC editor
Mike Rylander [Fri, 18 May 2012 12:30:08 +0000 (08:30 -0400)]
LP#921142: Bring back automatic padding of short fixed fields in the GUI MARC editor

Bring back automatic padding of short fixed fields in the GUI MARC
editor. Also, use onblur instead of oninput, so that we've already lost
focus and don't care if that happens again.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1394356: Stamping upgrade script for patron purge post code fix
Ben Shum [Tue, 16 Dec 2014 20:15:57 +0000 (15:15 -0500)]
LP#1394356: Stamping upgrade script for patron purge post code fix

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1394356 Patron purge circs retain post code
Bill Erickson [Fri, 28 Nov 2014 21:29:57 +0000 (16:29 -0500)]
LP#1394356 Patron purge circs retain post code

When purging a patron, clear the address data after circulation
anonymization to ensure the usr_post_code is retained.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1400376: Stamping upgrade script for fix to metabib.record_attr
Ben Shum [Tue, 16 Dec 2014 20:01:53 +0000 (15:01 -0500)]
LP#1400376: Stamping upgrade script for fix to metabib.record_attr

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1400376: Don't allow NULL attrs to polute an HSTORE as a key
Mike Rylander [Tue, 16 Dec 2014 01:32:51 +0000 (20:32 -0500)]
LP#1400376: Don't allow NULL attrs to polute an HSTORE as a key

That causes the HSTORE to blow up, which is bad for circs that
want to succeed.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1389403: Stamping upgrade script for normalizer detection to call number browse
Ben Shum [Tue, 16 Dec 2014 19:54:28 +0000 (14:54 -0500)]
LP#1389403: Stamping upgrade script for normalizer detection to call number browse

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1389403 Add normalizer detection to call number browse
Dan Wells [Fri, 4 Oct 2013 14:02:39 +0000 (10:02 -0400)]
LP#1389403 Add normalizer detection to call number browse

When finding the pivot for call number browse, we currently rely on
simple label matching (rather than normalized label matching), since
we do not know at the time of the search which normalizer we should
use.

Rather than blindly using the label, let's select the pivot in two
phases.  First, we will do what we do know, getting as close as
possible by label alone.  If we find an exact match, we are done (same
as the current code).  If we don't find an exact match, we take the
normalizer setting from the closest label match, normalize our input,
then search again.

This method *greatly* improves the overall accuracy of call number
searching whenever the call number being browsed for does not exist,
while causing no harm to accuracy when it does exist (since it will
either match the label or normalize to the same call number anyway).

Eventually, we may want to add interface elements for selecting the
call number type, probably defaulting to the default call number type
for the org unit being searched, but even with that in place, this
"auto-detection" logic should still be valuable.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1401286: Cleaner display of URIs in search results
Dan Scott [Wed, 10 Dec 2014 22:05:38 +0000 (17:05 -0500)]
LP#1401286: Cleaner display of URIs in search results

Right now a record with an 856 like:

856 40 $zAvailable online $uhttp://publications.gc.ca $9LUSYS

shows up in search results with an HTML display like:

<a href="http://publications.gc.ca">http://publications.gc.ca</a> - Available online

rather than the much cleaner:

<a href="http://publications.gc.ca">Available online</a>

My simplistic approach is to check to see if the link text == the href,
and if so, and we have a note to display, to use the note as the text of
the link instead.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1400082 - avoid uninitialized var warning at TPAC login
Dan Scott [Sun, 7 Dec 2014 13:51:33 +0000 (08:51 -0500)]
LP#1400082 - avoid uninitialized var warning at TPAC login

Give username a default value of '', which makes the regex happy (avoiding an
uninit warning in Apache logs if no value was entered) and still counts as de
nada for the purposes of the actual login dance.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1401271: Add missing dependency for Date::Manip perl module
Jason Stephenson [Sat, 29 Nov 2014 15:34:53 +0000 (10:34 -0500)]
LP#1401271: Add missing dependency for Date::Manip perl module

This commit adds lines to distro-specific Makefiles to install
Perl Date::Manip packages so that Date::Manip::Date is
avaliable for marc_export. Somehow, this got missed or removed.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1400100 - Avoid extra </div> when OpenURL is enabled
Dan Scott [Sun, 7 Dec 2014 15:17:42 +0000 (10:17 -0500)]
LP#1400100 - Avoid extra </div> when OpenURL is enabled

When the OpenURL resolver is enabled, the record summary.tt2 page always
inserts a </div>, whether or not there actually are any OpenURL results to
point at (which is the condition that triggers the opening <div>).

This has the effect of resulting in the generated RDFa not including anything
below the OpenURL section, effectvely preventing the schema.org/Offer types
from being associated with the record. Which is not good for the semantic web
of library data.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoUpdate 2.6-2.7.0-upgrade-db.sql to reflect that it actually starts from 2.6.3 and up.
Ben Shum [Fri, 5 Dec 2014 21:02:04 +0000 (16:02 -0500)]
Update 2.6-2.7.0-upgrade-db.sql to reflect that it actually starts from 2.6.3 and up.

So, actually, the 2.7 upgrade path needs to include everything up to 2.6.3 to get all
the fixes.

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoRe-order parts of 0887 upgrade script
Ben Shum [Fri, 5 Dec 2014 20:59:40 +0000 (15:59 -0500)]
Re-order parts of 0887 upgrade script

Based on feedback from dbs, in PostgreSQL 9.1, the order to which we
fix up these functions matters.  So drop if exists first, then create
new.

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoForward-port 2.6.3 upgrade script
Dan Wells [Wed, 5 Nov 2014 19:22:26 +0000 (14:22 -0500)]
Forward-port 2.6.3 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1401177: Stamping upgrade script of unique_mr_attrs.sql.
Jason Stephenson [Wed, 10 Dec 2014 21:03:11 +0000 (16:03 -0500)]
LP#1401177: Stamping upgrade script of unique_mr_attrs.sql.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
10 years agoLP#1401177: uniquify attrs across a metarecord
Mike Rylander [Wed, 10 Dec 2014 18:51:51 +0000 (13:51 -0500)]
LP#1401177: uniquify attrs across a metarecord

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
11 years agoMerge branch 'feature/circ_scripts_2_7' into rel_2_7_mergery
Dan Scott [Sun, 7 Dec 2014 21:36:26 +0000 (16:36 -0500)]
Merge branch 'feature/circ_scripts_2_7' into rel_2_7_mergery

11 years agoMEDIACEN doesn't charge anything on AV-EQUIP items
Dan Scott [Mon, 24 Sep 2012 18:03:18 +0000 (14:03 -0400)]
MEDIACEN doesn't charge anything on AV-EQUIP items

Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoAdd 3-day loan rule for AV-EQUIP for media centre
Dan Scott [Mon, 24 Sep 2012 14:36:28 +0000 (10:36 -0400)]
Add 3-day loan rule for AV-EQUIP for media centre

Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoPrevent renew if item already is targeted for a hold
Dan Scott [Tue, 14 Feb 2012 15:46:24 +0000 (10:46 -0500)]
Prevent renew if item already is targeted for a hold

From http://biblio.laurentian.ca/tickets/conifer/wiki/devHolds
apparently I missed this in moving our customizations from SVN (or it
was only ever local?)

Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoOSBO: Accidental copying of the "DVD VIDEO" rule
Dan Scott [Fri, 23 Sep 2011 20:40:38 +0000 (16:40 -0400)]
OSBO: Accidental copying of the "DVD VIDEO" rule

Meant to remove the "DVD" from the "DVD VIDEO" part of the circ modifier
the second time around.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoOSBO really did want $0.25/hour for all reserve periods
Dan Scott [Tue, 20 Sep 2011 17:01:32 +0000 (13:01 -0400)]
OSBO really did want $0.25/hour for all reserve periods

Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoAdd Reserve circ rules for Boreal
Dan Scott [Thu, 1 Sep 2011 19:01:39 +0000 (15:01 -0400)]
Add Reserve circ rules for Boreal

Still need some clarification on how these rules are to be applied, but
better to get the durations working right now and fix up the fines
later.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoAdd LEDL MISC to the list of allowed circ modifiers for Leddy
Dan Scott [Mon, 15 Aug 2011 17:10:17 +0000 (13:10 -0400)]
Add LEDL MISC to the list of allowed circ modifiers for Leddy

Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoAdd ILL-BOOK to the list of allowed circ modifiers for Leddy
Dan Scott [Mon, 15 Aug 2011 17:08:55 +0000 (13:08 -0400)]
Add ILL-BOOK to the list of allowed circ modifiers for Leddy

Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoAdd LEDL MISC 1 year 0 renew rule
Dan Scott [Thu, 11 Aug 2011 13:42:30 +0000 (09:42 -0400)]
Add LEDL MISC 1 year 0 renew rule

This had been working in production, but apparently never got
checked into git?

Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoAdd Boreal circulation rules
Dan Scott [Thu, 21 Jul 2011 19:08:53 +0000 (15:08 -0400)]
Add Boreal circulation rules

Still need to add their limits based on user profile & item type

Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoAdd ILL-BOOK circ rule for OWA
Dan Scott [Mon, 20 Jun 2011 17:54:23 +0000 (13:54 -0400)]
Add ILL-BOOK circ rule for OWA

Per ticket #683:

Loan period of 3 weeks
NO RENEWALS

Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoTrack Conifer JavaScript circulation rules
Dan Scott [Mon, 30 May 2011 02:18:04 +0000 (22:18 -0400)]
Track Conifer JavaScript circulation rules

Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoMerge remote-tracking branch 'conifer/feature/ldap_osul_2_7' into rel_2_7_mergery
Dan Scott [Sun, 7 Dec 2014 14:07:58 +0000 (09:07 -0500)]
Merge remote-tracking branch 'conifer/feature/ldap_osul_2_7' into rel_2_7_mergery

11 years agolibyaz-dev needs to be specifically 4 or 5
Dan Scott [Sun, 7 Dec 2014 12:33:18 +0000 (07:33 -0500)]
libyaz-dev needs to be specifically 4 or 5

If you're using yaz from Indexdata to avoid the Z39.50
server errors that you get with the packaging from Ubuntu,
then you need to specify either libyaz4-dev or libyaz5-dev.
We were working with libyaz5-dev, so roll with that.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoMerge remote-tracking branch 'remotes/conifer/feature/tpac_hide_awards_2_7' into...
Dan Scott [Sun, 7 Dec 2014 12:25:01 +0000 (07:25 -0500)]
Merge remote-tracking branch 'remotes/conifer/feature/tpac_hide_awards_2_7' into mergery_2_7

11 years agoMerge remote-tracking branch 'remotes/conifer/feature/move_to_storage_2_7' into merge...
Dan Scott [Sun, 7 Dec 2014 12:24:50 +0000 (07:24 -0500)]
Merge remote-tracking branch 'remotes/conifer/feature/move_to_storage_2_7' into mergery_2_7

11 years agoMerge remote-tracking branch 'remotes/conifer/feature/marctemplates_2_7' into mergery_2_7
Dan Scott [Sun, 7 Dec 2014 12:24:37 +0000 (07:24 -0500)]
Merge remote-tracking branch 'remotes/conifer/feature/marctemplates_2_7' into mergery_2_7

11 years agoMerge remote-tracking branch 'remotes/conifer/feature/barcode_generator_2_7' into...
Dan Scott [Sun, 7 Dec 2014 12:24:20 +0000 (07:24 -0500)]
Merge remote-tracking branch 'remotes/conifer/feature/barcode_generator_2_7' into mergery_2_7

11 years agoMerge remote-tracking branch 'remotes/conifer/feature/tpac_eresources_highlander_2_7...
Dan Scott [Sun, 7 Dec 2014 12:24:00 +0000 (07:24 -0500)]
Merge remote-tracking branch 'remotes/conifer/feature/tpac_eresources_highlander_2_7' into mergery_2_7

11 years agoMerge remote-tracking branch 'remotes/conifer/feature/patron_privacy_2_7' into merger...
Dan Scott [Sun, 7 Dec 2014 12:23:34 +0000 (07:23 -0500)]
Merge remote-tracking branch 'remotes/conifer/feature/patron_privacy_2_7' into mergery_2_7

11 years agoMerge remote-tracking branch 'remotes/conifer/feature/fts-polish-l_2_7' into mergery_2_7
Dan Scott [Sun, 7 Dec 2014 12:23:17 +0000 (07:23 -0500)]
Merge remote-tracking branch 'remotes/conifer/feature/fts-polish-l_2_7' into mergery_2_7

11 years agoMerge remote-tracking branch 'remotes/conifer/feature/tpac_show_details_config_2_7...
Dan Scott [Sun, 7 Dec 2014 12:23:01 +0000 (07:23 -0500)]
Merge remote-tracking branch 'remotes/conifer/feature/tpac_show_details_config_2_7' into mergery_2_7

11 years agoMerge remote-tracking branch 'remotes/conifer/features/2.4-to-2.7' into mergery_2_7
Dan Scott [Sun, 7 Dec 2014 12:21:35 +0000 (07:21 -0500)]
Merge remote-tracking branch 'remotes/conifer/features/2.4-to-2.7' into mergery_2_7

11 years agoPrefer a metabib reingest that is not a single transaction features/2.4-to-2.7
Dan Scott [Sun, 7 Dec 2014 12:18:37 +0000 (07:18 -0500)]
Prefer a metabib reingest that is not a single transaction

At least this way we can keep the doors open for business while the reingest
goes on.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoMinor fix to web client section headers in root.txt
Kathy Lussier [Fri, 5 Dec 2014 14:03:20 +0000 (09:03 -0500)]
Minor fix to web client section headers in root.txt

I accidentally added the circulation header twice when adding the new
sections for web client docs. This commit removes one of the headers.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
11 years agoWeb client section headings
Kathy Lussier [Thu, 4 Dec 2014 21:36:08 +0000 (16:36 -0500)]
Web client section headings

Adding section headings for web client documentation, which will be coming
shortly.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
11 years agoDocs: Update to template receipt docs
Lynn Floyd [Wed, 26 Nov 2014 21:37:29 +0000 (16:37 -0500)]
Docs: Update to template receipt docs

Thanks to Lynn Floyd. When adding the new content I ended up splitting new and old content into three files.

Signed-off-by: Yamil Suarez <yamil@yamil.com>
11 years agoAvoid ambiguous function references in upgrade script
Dan Scott [Wed, 26 Nov 2014 04:18:21 +0000 (23:18 -0500)]
Avoid ambiguous function references in upgrade script

Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoFunkiness around 0887 which appears to be missing from 2.6-2.7.0 upgrade
Dan Scott [Wed, 26 Nov 2014 03:25:49 +0000 (22:25 -0500)]
Funkiness around 0887 which appears to be missing from 2.6-2.7.0 upgrade

Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoApply fix for "Could not find trigger" (LP 1261355)
Dan Scott [Tue, 25 Nov 2014 18:49:00 +0000 (13:49 -0500)]
Apply fix for "Could not find trigger" (LP 1261355)

Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoOvercome metabib.record_attr_vector_list missing
Dan Scott [Tue, 25 Nov 2014 16:40:52 +0000 (11:40 -0500)]
Overcome metabib.record_attr_vector_list missing

Perhaps the transaction is too long? Anyway, commit and move on.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoFirst rough 2.4 - 2.7 database upgrade for Conifer
Dan Scott [Mon, 24 Nov 2014 20:21:20 +0000 (15:21 -0500)]
First rough 2.4 - 2.7 database upgrade for Conifer

Nothing special, you know.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
11 years agoLP#1207529: Add /openils assumption note
alzr [Mon, 5 Aug 2013 21:50:09 +0000 (16:50 -0500)]
LP#1207529: Add /openils assumption note

Signed-off-by: alzr <aleksey.lazar@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoLP#1207529: Make sure $PATH includes /openils/bin when configuring
alzr [Mon, 5 Aug 2013 19:33:07 +0000 (14:33 -0500)]
LP#1207529: Make sure $PATH includes /openils/bin when configuring

https://bugs.launchpad.net/evergreen/+bug/1207529

Signed-off-by: alzr <aleksey.lazar@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Conflicts:
docs/installation/server_upgrade.txt

11 years agoLP#1384932: document the zips.txt ZIP code database feature
Josh Stompro [Wed, 29 Oct 2014 21:12:08 +0000 (16:12 -0500)]
LP#1384932: document the zips.txt ZIP code database feature

Patron Address City/State/County Pre-Populate by ZIP Code.

Documented the zips.txt feature that auto fills patron address
(City, State, County) information.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoLP#1246371: Allow BibCommon::title_is_empty to accept a bre id or bre object.
Jason Stephenson [Wed, 30 Oct 2013 15:05:45 +0000 (11:05 -0400)]
LP#1246371: Allow BibCommon::title_is_empty to accept a bre id or bre object.

I was trying to delete copies with the record fleshed in the call number
object and got the following error:

Can't use an undefined value as an ARRAY reference at
/usr/local/share/perl/5.14.2/OpenILS/Application/Cat/BibCommon.pm line 399

Having title_is_empty check for a bre object and use its id solved this
problem for me.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
11 years agoLP#1083639: use "cp -r" instead of "cp -R"
Galen Charlton [Thu, 13 Nov 2014 18:45:14 +0000 (10:45 -0800)]
LP#1083639: use "cp -r" instead of "cp -R"

This change is purely for the sake of consistency; there's
no functional difference.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>