evergreen/tadl.git
13 years agoCorrect error in call number owning library change
Thomas Berezansky [Tue, 7 Jun 2011 17:45:55 +0000 (13:45 -0400)]
Correct error in call number owning library change

Send IDs to the backend, not objects.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoMark invalid home ous as such in patron editor
Thomas Berezansky [Fri, 10 Jun 2011 13:22:56 +0000 (09:22 -0400)]
Mark invalid home ous as such in patron editor

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agomissing string for MFHD deletion
Jason Etheridge [Fri, 10 Jun 2011 14:42:51 +0000 (10:42 -0400)]
missing string for MFHD deletion

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoExtend hold shelf expire date beyond closed dates
Bill Erickson [Wed, 8 Jun 2011 19:44:37 +0000 (15:44 -0400)]
Extend hold shelf expire date beyond closed dates

If the shelf_expire_time on a hold would land on a closed date for the
pickup library, push the expire time out to just beyond the close date
range, similar to the circulation due date overlap logic.

In the current iteration, the time component of the date is pushed out
to the end of the day (23:59:59).  If this is not generally the desired
behavior, an org setting could be added to bypass this step so that the
time matches "now" (i.e. capture time) instead.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agohonor ui.unified_volume_copy_editor setting with Add Volumes in Holdings Maintenance
Jason Etheridge [Thu, 26 May 2011 19:33:20 +0000 (15:33 -0400)]
honor ui.unified_volume_copy_editor setting with Add Volumes in Holdings Maintenance

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agomake unified vol/copy editor honor required stat cats
Jason Etheridge [Wed, 1 Jun 2011 20:25:50 +0000 (16:25 -0400)]
make unified vol/copy editor honor required stat cats

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agoPrevent future dates of birth in patron editor
Lebbeous Fogle-Weekley [Fri, 3 Jun 2011 19:17:48 +0000 (15:17 -0400)]
Prevent future dates of birth in patron editor

The patron editor form allowed staff to enter a date of birth that takes
place in the future. While it is theoretically conceivable (hah) that
a library might register patrons that have yet to be born, it is
unlikely enough that we will not even assign this behavior to an
org-unit setting, but we will take the bold move of using a regular
expression to prevent a future dates of birth at all.

Note that if a library system travels into the past, this will cause all
sorts of problems in the patron editor interface (not to mention
overdues). Please do not mix Evergreen and time travel.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Scott <dan@coffeecode.net>
13 years agoFix false MFHD editing cues (LP #791974)
Dan Wells [Thu, 2 Jun 2011 19:44:36 +0000 (15:44 -0400)]
Fix false MFHD editing cues (LP #791974)

The in-DB serial holdings use the same general display code as
the MFHD records, but were falsely triggering MFHD administration
widgets when in fact no MFHD record exists.  These holdings were
already being marked, so this fix honors that mark.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dan Scott <dan@coffeecode.net>
13 years agoTweak MFHD scoping
Dan Wells [Thu, 2 Jun 2011 14:17:07 +0000 (10:17 -0400)]
Tweak MFHD scoping

Three changes:
1) Add a closure for 'entryNum' value (currently used for some display
placement and menu-entry correlation)
2) Remove depth-climb to simplify code and better approximate copy scoping
3) Move 'here' assignment out of the foreach

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dan Scott <dan@coffeecode.net>
13 years agoFix rendering of MFHD records when ownership is out of scope
Dan Scott [Fri, 27 May 2011 17:51:59 +0000 (13:51 -0400)]
Fix rendering of MFHD records when ownership is out of scope

Dojo would die with a null reference error when an MFHD record
was retrieved that was outside of the current OU search scope.
For example, if a given bib record had one linked MFHD record
for BR1, and one linked MFHD record for BR4, the details page
would choke trying to draw the MFHD holdings in a scope that
only included BR1 and end up drawing nothing. Ungood.

Moving the ownership check and invoking _holdingsDrawMFHD()
only after ensuring that the record is within our scope resolves
the problem.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
13 years agoLP 791546: advanced search ISBN/ISSN in .staff mode
Dan Scott [Mon, 6 Jun 2011 16:11:58 +0000 (12:11 -0400)]
LP 791546: advanced search ISBN/ISSN in .staff mode

In 1.6, advanced search ISBN/ISSN searches always operated in .staff
mode, returning results whether the results should have been visible to
the user or not. This confused patrons who saw records to which they had
no access.

In 2.0, this behaviour changed so that advanced search ISBN/ISSN
searches never operated in .staff mode. This confused staff who were
used to retrieving records via the ISBN/ISSN search when they wanted to
add holdings for their own library to the records.

The pattern for addressing this problem and satisfying both use cases is
the same - use the multiclass.query.staff method if we invoke the ISBN
or ISSN searches with the .staff method name.

One could easily refactor many of the search method bodies in this
module to use the exact same logic, keying off the method name to
identify the identifier field and the .staff portion of the method name
to determine whether to invoke .staff mode or not. For now we just
address the ISBN and ISSN entry points.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
13 years agofix View Holds by preventing an empty IN list with cstore, and stubbing out part_holds
Jason Etheridge [Mon, 6 Jun 2011 16:46:21 +0000 (12:46 -0400)]
fix View Holds by preventing an empty IN list with cstore, and stubbing out part_holds

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
13 years agofor the Circulate as Type column in xul lists, display the actual citm value instead...
Jason Etheridge [Wed, 1 Jun 2011 07:21:06 +0000 (03:21 -0400)]
for the Circulate as Type column in xul lists, display the actual citm value instead of the code

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
13 years agoFix Circulate as Type in the item editor.
Jason Etheridge [Wed, 1 Jun 2011 07:17:17 +0000 (03:17 -0400)]
Fix Circulate as Type in the item editor.

The citm retrieval method was changed to use open-ils.fielder, which
doesn't return actual fieldmapper objects, so when data.js went to
convert the retrieved list to a hash, it broke.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
13 years agoAllow util.functional.convert_object_list_to_hash to handle more than fieldmapper...
Jason Etheridge [Wed, 1 Jun 2011 07:16:05 +0000 (03:16 -0400)]
Allow util.functional.convert_object_list_to_hash to handle more than fieldmapper-like objects

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
13 years agoPO activation date display improvement
Bill Erickson [Fri, 3 Jun 2011 20:35:25 +0000 (16:35 -0400)]
PO activation date display improvement

Use the smarter Util.js date parsing code to prevent small time offsets
in PO activation date display.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agotweak function name
Jason Etheridge [Fri, 3 Jun 2011 19:58:52 +0000 (15:58 -0400)]
tweak function name

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoRefactor the "show copy notes button" functionality
Dan Scott [Fri, 3 Jun 2011 18:48:30 +0000 (14:48 -0400)]
Refactor the "show copy notes button" functionality

Collapse the duplicated code for showing / hiding the "show copy notes
button" into a single method. Might make maintenance a bit easier some
day.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agofix the Copy Notes button in the unified vol/copy editor
Jason Etheridge [Wed, 1 Jun 2011 19:57:50 +0000 (15:57 -0400)]
fix the Copy Notes button in the unified vol/copy editor

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Dan Scott <dan@coffeecode.net>
13 years agoClean up a few stock perm mistakes
Dan Wells [Fri, 3 Jun 2011 17:43:40 +0000 (13:43 -0400)]
Clean up a few stock perm mistakes

This upgrade file does cleanup for two errors:
1) accounts for spelling errors (Admin != Administrator)
2) adds a group missed in 0542, for upgraders

Signed-off-by: Dan Wells <dbw2@calvin.edu>
13 years agoFixed and extended upgrade file 0542 (stock permissions)
Dan Wells [Fri, 3 Jun 2011 17:00:25 +0000 (13:00 -0400)]
Fixed and extended upgrade file 0542 (stock permissions)

This upgrade file did not work on a multi-upgraded DB, as a bunch of new
permissions and groups never made it into any upgrade.

The changes here are intended to both fix the upgrade and rectify the
missing pieces, where needed.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
13 years agoWhitespace cleanup in aisle 3 (O:A:Reporter)
Dan Scott [Wed, 1 Jun 2011 22:06:13 +0000 (18:06 -0400)]
Whitespace cleanup in aisle 3 (O:A:Reporter)

Signed-off-by: Dan Scott <dan@coffeecode.net>
13 years agoLP#740466 Sort report folders by name
Michael Peters [Wed, 1 Jun 2011 12:52:57 +0000 (08:52 -0400)]
LP#740466 Sort report folders by name

Add order_by to Reporter.pm to sort report folders by name

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Dan Scott <dan@coffeecode.net>
13 years agoSerial holdings display consistency fix
Dan Wells [Wed, 1 Jun 2011 18:33:59 +0000 (14:33 -0400)]
Serial holdings display consistency fix

When holdings are sourced from both MFHD and the DB, display may be
inconsistent due to a hard-coded ', ' in Serial.pm.  This patch works around
the problem by storing generated_coverage as a JSON array instead of a string,
leaving display formatting to the OPAC.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
13 years agoRevert "f424dd8" for bad commit message
Dan Wells [Wed, 1 Jun 2011 18:52:49 +0000 (14:52 -0400)]
Revert "f424dd8" for bad commit message

This reverts commit 997eef7b50acf10ec2afcb8d8933b75317e0410f.

13 years agof424dd8
Dan Wells [Wed, 1 Jun 2011 18:40:43 +0000 (14:40 -0400)]
f424dd8

13 years agoMissing db upgrade number bump plus backport fix
Dan Wells [Wed, 1 Jun 2011 17:00:32 +0000 (13:00 -0400)]
Missing db upgrade number bump plus backport fix

Signed-off-by: Dan Wells <dbw2@calvin.edu>
13 years agoRemove specific admin perms, reorganize seed file
Dan Wells [Wed, 1 Jun 2011 15:10:34 +0000 (11:10 -0400)]
Remove specific admin perms, reorganize seed file

The various administrators already have 'EVERYTHING' at their
respective levels, so no need to assign new perms there.  The
seed file is now more consistently organized.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoChange a few permission levels and assignments
Dan Wells [Wed, 1 Jun 2011 13:43:53 +0000 (09:43 -0400)]
Change a few permission levels and assignments

In an attempt to be consistent with existing perms, a few were moved to
levels lower than 'Consortium', and ADMIN_SERIAL_ITEM is only in the
'Serial' group.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoPush the grp perm mappings into the seed data
Jason Etheridge [Thu, 26 May 2011 18:31:04 +0000 (14:31 -0400)]
Push the grp perm mappings into the seed data

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
13 years agowrong group ids for system admin and global admin
Jason Etheridge [Thu, 26 May 2011 16:55:25 +0000 (12:55 -0400)]
wrong group ids for system admin and global admin

Signed-off-by: Dan Wells <dbw2@calvin.edu>
13 years agoput CREATE_PURCHASE_REQUEST into Users, not Staff
Jason Etheridge [Thu, 26 May 2011 16:50:39 +0000 (12:50 -0400)]
put CREATE_PURCHASE_REQUEST into Users, not Staff

Signed-off-by: Dan Wells <dbw2@calvin.edu>
13 years agomap these perms to stock perm groups
Jason Etheridge [Thu, 26 May 2011 16:43:41 +0000 (12:43 -0400)]
map these perms to stock perm groups

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
13 years agoadded other permissions missing in rel_2_1
Jason Etheridge [Thu, 26 May 2011 14:51:19 +0000 (10:51 -0400)]
added other permissions missing in rel_2_1

Signed-off-by: Dan Wells <dbw2@calvin.edu>
13 years agosome recent cataloging permissions, but I'm unsure about the new upgrade/ script...
Jason Etheridge [Thu, 26 May 2011 07:13:26 +0000 (03:13 -0400)]
some recent cataloging permissions, but I'm unsure about the new upgrade/ script regime

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
13 years agoLP#739444 Incrementing opac.dtd copyright date
Michael Peters [Tue, 31 May 2011 12:44:49 +0000 (08:44 -0400)]
LP#739444 Incrementing opac.dtd copyright date

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Dan Scott <dan@coffeecode.net>
13 years agoindicate what date format to use for offline patron registration
Jason Etheridge [Fri, 27 May 2011 17:02:14 +0000 (13:02 -0400)]
indicate what date format to use for offline patron registration

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoFix Hold Capture checkin mode
Thomas Berezansky [Fri, 27 May 2011 15:39:53 +0000 (11:39 -0400)]
Fix Hold Capture checkin mode

oils_persist was trumping hardcoded values.
Also, change how checked is set/unset for reliability.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoPatch suggested by Jason Boyer for LP#788601
Mike Rylander [Thu, 26 May 2011 20:03:39 +0000 (16:03 -0400)]
Patch suggested by Jason Boyer for LP#788601

The <script> tag for the chrome frame message has a misplaced semicolon,
which causes an odd looking display issue in Internet Explorer. I
realize that ideally very few people will be using IE, but even if
they're not interested in a quality browsing experience we should
probably put our best face forward.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
(cherry picked from commit bbc874ddb42ac05130ccfad92fc55ccebd6af882)

Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoDistinguish between 'Show Groups' checkboxes in Serial Control
Dan Wells [Thu, 26 May 2011 15:19:40 +0000 (11:19 -0400)]
Distinguish between 'Show Groups' checkboxes in Serial Control

Two different checkboxes ended up with the same ID, which, as one might
expect, kinda worked and kinda didn't.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
13 years agoChecking for 'twisty' leads to false negatives in Serial Control
Dan Wells [Thu, 26 May 2011 14:53:42 +0000 (10:53 -0400)]
Checking for 'twisty' leads to false negatives in Serial Control

Since a tree can be opened with a double-click, we can't rely on 'twisty'
being set to load the child data.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
13 years agoDon't rely on call number column being rendered before prefix/suffix/class columns...
Jason Etheridge [Thu, 26 May 2011 07:55:26 +0000 (03:55 -0400)]
Don't rely on call number column being rendered before prefix/suffix/class columns.  Also, remove prefix/suffix/class from the check-in interface, since those column definitions can make extra network calls and we want that interface to be as fast as possible.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agowrong target for parts holds in open-ils.circ.holds.retrieve_all_from_title
Jason Etheridge [Thu, 26 May 2011 06:42:07 +0000 (02:42 -0400)]
wrong target for parts holds in open-ils.circ.holds.retrieve_all_from_title

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agomissed this way back when. fix multiple event override handling (for ilsevent lackin...
Jason Etheridge [Wed, 25 May 2011 20:56:24 +0000 (16:56 -0400)]
missed this way back when.  fix multiple event override handling (for ilsevent lacking events), re: lp#757634.  Also add some missing typeof's

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoFix authority linking script typo
Dan Scott [Wed, 25 May 2011 15:38:11 +0000 (11:38 -0400)]
Fix authority linking script typo

Problem reported by Ditty Mulder <dmu@iisg.nl>

Signed-off-by: Dan Scott <dan@coffeecode.net>
13 years agoupgrade_deps_block_check() is not in the branches at this point
Dan Wells [Wed, 25 May 2011 13:29:13 +0000 (09:29 -0400)]
upgrade_deps_block_check() is not in the branches at this point

Signed-off-by: Dan Wells <dbw2@calvin.edu>
13 years agoUse the correct upgrade log format for rel_2_1
Dan Scott [Wed, 25 May 2011 03:22:32 +0000 (23:22 -0400)]
Use the correct upgrade log format for rel_2_1

Signed-off-by: Dan Scott <dan@coffeecode.net>
13 years agoTrivial line-wrapping patch for call number class defaults
Dan Scott [Wed, 25 May 2011 01:56:13 +0000 (21:56 -0400)]
Trivial line-wrapping patch for call number class defaults

Signed-off-by: Dan Scott <dan@coffeecode.net>
13 years agoMake label_class on any new call numbers default to org_unit setting
Dan Wells [Tue, 24 May 2011 14:53:09 +0000 (10:53 -0400)]
Make label_class on any new call numbers default to org_unit setting

Evergreen 2.0 added a label_class column to the call number table with
one major purpose being the generation of correct sort keys. You can
also specify a default label class as an org unit setting. However:

1) There are no interface elements for setting the label class of an
individual call number.

2) The default setting from the actor.org_unit_setting
'cat.default_classification_scheme' value, if set, is not consulted
(that is, not set in the call number table) when new call numbers are
created.

These two facts together greatly reduce the utility of this very
valuable feature, as all new call numbers end up in the 'Generic' class.

While #1 has been addressed in 2.1+, there is still work to be done in
setting this class on import. Also, which interface parts (if any) make
it back to 2.0 is subject to debate.

This commit addresses #2.

See lp #787150.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dan Scott <dan@coffeecode.net>
13 years agoBring serial.unit in line with asset.copy
Dan Wells [Tue, 24 May 2011 20:55:47 +0000 (16:55 -0400)]
Bring serial.unit in line with asset.copy

Signed-off-by: Dan Wells <dbw2@calvin.edu>
13 years agoremove restriction on resetting pw to random number when Use Phone Password setting...
Jason Etheridge [Tue, 24 May 2011 18:55:57 +0000 (14:55 -0400)]
remove restriction on resetting pw to random number when Use Phone Password setting is active.  uEditMakeRandomPw will still get called for new users, but should get overwritten once a phone number is entered

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agowrong identifier and lingering copy/paste-o in code for Item Status -> Add Items
Jason Etheridge [Mon, 23 May 2011 15:09:41 +0000 (11:09 -0400)]
wrong identifier and lingering copy/paste-o in code for Item Status -> Add Items

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoMerge branch 'rel_2_1' of git.evergreen-ils.org:Evergreen into rel_2_1
Mike Rylander [Mon, 23 May 2011 15:14:31 +0000 (11:14 -0400)]
Merge branch 'rel_2_1' of git.evergreen-ils.org:Evergreen into rel_2_1

13 years agoRevert "Wrap proximity refreshing in a transaction to avoid timespans where there...
Mike Rylander [Mon, 23 May 2011 15:06:51 +0000 (11:06 -0400)]
Revert "Wrap proximity refreshing in a transaction to avoid timespans where there is no such information"

This reverts commit 2a16bb01ebf782a248155bee9c2d37d5b3184e0c.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoApply Apache file expiration to the current official Javascript content type
Dan Wells [Mon, 23 May 2011 13:38:22 +0000 (09:38 -0400)]
Apply Apache file expiration to the current official Javascript content type

At least on Ubuntu 10.04, Javascript files are generally delivered
with a Content-Type header of 'application/javascript', not
'application/x-javascript'.  This change applies the much shorter
18 hour expiration to the affected files, rather than allowing them
to default to 1 month.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
13 years agoFix bad seed data in an A/T template
Lebbeous Fogle-Weekley [Fri, 20 May 2011 19:47:04 +0000 (15:47 -0400)]
Fix bad seed data in an A/T template

The action_trigger event def template for printing acq invoices was
syntatically broken.  The collapse filter isn't important per se, but
it balances the extra [% END %] at the bottom of the template, and it
was there originally, and I see no reason not to put it back.

Incidentally, maybe the database upgrade script in the commit will be
the first in master to successfully use the new
evergreen.upgrade_deps_block_check() function ?

Reported by Sally Fortin.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
13 years agoRestore the Replace Barcode option in Holdings Maintenance, as the Edit Item menu...
Jason Etheridge [Fri, 20 May 2011 16:45:08 +0000 (12:45 -0400)]
Restore the Replace Barcode option in Holdings Maintenance, as the Edit Item menu will only serve the same duty if the unified volume/copy editor is activated via org setting (otherwise, it's just the Item Attribute Editor).  klussier++ for the catch

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoMerge branch 'rel_2_1' of git.evergreen-ils.org:Evergreen into rel_2_1
Dan Wells [Fri, 20 May 2011 15:34:06 +0000 (11:34 -0400)]
Merge branch 'rel_2_1' of git.evergreen-ils.org:Evergreen into rel_2_1

13 years agoFix advanced receive bug in manage_items.js
Dan Wells [Fri, 20 May 2011 15:27:53 +0000 (11:27 -0400)]
Fix advanced receive bug in manage_items.js
Signed-off-by: Dan Wells <dbw2@calvin.edu>
13 years agoalign the batch edit menus in the vol creator. mostly aesthetic, but can save horizo...
Jason Etheridge [Fri, 20 May 2011 09:30:55 +0000 (05:30 -0400)]
align the batch edit menus in the vol creator.  mostly aesthetic, but can save horizontal real estate, so usability as well for horizontal vol/copy editor.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agousability tweak for controlling screen real estate, in unified vol/copy editor don...
Jason Etheridge [Fri, 20 May 2011 09:04:17 +0000 (05:04 -0400)]
usability tweak for controlling screen real estate, in unified vol/copy editor don't embed the the Record Summary in the vol editor, but in the main wrapping UI.  Also move CN batch edit bar into groupbox

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agousability tweak, pull the Create button out of the embedded interfaces and into the...
Jason Etheridge [Fri, 20 May 2011 07:55:37 +0000 (03:55 -0400)]
usability tweak, pull the Create button out of the embedded interfaces and into the wrapping UI for the horizontal variant of the unified vol/copy editor

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agocss hooks so we can hide class, affix, and part columns in volume creator/editor...
Jason Etheridge [Fri, 20 May 2011 07:33:52 +0000 (03:33 -0400)]
css hooks so we can hide class, affix, and part columns in volume creator/editor.  can help with screen real estate with the horizontal vol/copy editor

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agousability tweak, spread the template bar across the top of both panes for the horizon...
Jason Etheridge [Fri, 20 May 2011 06:59:31 +0000 (02:59 -0400)]
usability tweak, spread the template bar across the top of both panes for the horizontal unified vol/copy creator/editor

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoFix a problem with open-ils.circ.holds.retrieve_all_from_title
Lebbeous Fogle-Weekley [Fri, 20 May 2011 14:17:05 +0000 (10:17 -0400)]
Fix a problem with open-ils.circ.holds.retrieve_all_from_title

Anoop Atre spotted this bug that's triggered by selecting "View Holds"
from "Actions for Selected Record" in the catalog seen through the staff
client.

Said method would error out like this:

[2011-05-20 10:04:03] open-ils.circ [ERR
:31866:CStoreEditor.pm:109:13058333633194115] editor[0|1] request error
open-ils.cstore.direct.serial.issuance.id_list.atomic :
{"subscription":[]} : Exception:
OpenSRF::DomainObject::oilsMethodException 2011-05-20T10:04:03
OpenILS::Utils::CStoreEditor
/openils/lib/perl5/OpenILS/Utils/CStoreEditor.pm:412 <500>  Severe query
error -- see error log for more details

because when trying to gather issuance-type holds, it didn't properly test
whether there actually were any subscriptions and issuances related to
the bib record in question.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
13 years agoRevert "When placing holds on a bib with monographic part, require selection of a...
Mike Rylander [Fri, 20 May 2011 13:18:05 +0000 (09:18 -0400)]
Revert "When placing holds on a bib with monographic part, require selection of a specific part"

This reverts commit 69395e8c55db3a0993b2a48eb930ab55402d5c8d.

We must not force P-type holds as not all copies may not use parts.  Imagine a situation where
only one library breaks up a season of Seinfeld by using a part per DVD, and all others leave
them bound and therefore need no part designations.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoWhen placing holds on a bib with monographic part, require selection of a specific...
Jason Etheridge [Fri, 20 May 2011 06:40:24 +0000 (02:40 -0400)]
When placing holds on a bib with monographic part, require selection of a specific part

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoorder any monograph parts by sort key when placing holds
Jason Etheridge [Fri, 20 May 2011 02:54:30 +0000 (22:54 -0400)]
order any monograph parts by sort key when placing holds

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoCN prefix/suffix columns in xul-based hold interfaces
Jason Etheridge [Fri, 20 May 2011 02:25:16 +0000 (22:25 -0400)]
CN prefix/suffix columns in xul-based hold interfaces

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agolabel consistency in vol/item creator
Jason Etheridge [Fri, 20 May 2011 01:24:24 +0000 (21:24 -0400)]
label consistency in vol/item creator

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoadd missing upgrade step to create staging schema
Galen Charlton [Fri, 20 May 2011 01:28:50 +0000 (21:28 -0400)]
add missing upgrade step to create staging schema

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
13 years agoAdd permission checking for updating and deleting volumes.
Lebbeous Fogle-Weekley [Wed, 18 May 2011 21:26:58 +0000 (17:26 -0400)]
Add permission checking for updating and deleting volumes.

This addresses LP #784062 reported by Ben Shum, and I think others?

Creating volumes was already covered.  The ability to delete volumes
without permission would be less often an issue in practice since you
would need permission to delete the volume's copies before you could
delete the volume itself.

Anyway, this should square things.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
13 years agoavoid error when generating fines on checkin
Galen Charlton [Wed, 18 May 2011 15:13:16 +0000 (11:13 -0400)]
avoid error when generating fines on checkin

Prevents "No active transaction to commit" error when checking
in overdue loans.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
13 years agofix CN prefix/suffix display in XUL interfaces so we can handle any affix we come...
Jason Etheridge [Wed, 18 May 2011 06:14:52 +0000 (02:14 -0400)]
fix CN prefix/suffix display in XUL interfaces so we can handle any affix we come across

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoInclude call number prefix/suffix in display and sorting of holds for Print Full...
Jason Etheridge [Wed, 18 May 2011 05:05:17 +0000 (01:05 -0400)]
Include call number prefix/suffix in display and sorting of holds for Print Full Pull List (Alternate strategy).  Also fix things so that we're sorting on the label_sortkey for call number, and not the label.  So, for this interface, the hard-wired sort order is Copy Location Order (as defined by Admin -> Local Administration -> Copy Location Order), Call Number Prefix, Call Number Label, Call Number Suffix, and Hold Request time.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agohave the call number checkbox for pocket labels include prefix/suffix. A %call_numbe...
Jason Etheridge [Wed, 18 May 2011 02:27:07 +0000 (22:27 -0400)]
have the call number checkbox for pocket labels include prefix/suffix.  A %call_number% macro is still available for the bare call number label without affixes

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoCan't use encodeURI and decodeURI for everything with persist_helper (in particular...
Jason Etheridge [Wed, 18 May 2011 02:24:21 +0000 (22:24 -0400)]
Can't use encodeURI and decodeURI for everything with persist_helper (in particular, something like "%macro1% %macro2%" as a custom entry in the label interface), so try/catch them and fall back to the original behavior.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoonly use the label to initialize call number browse
Galen Charlton [Tue, 17 May 2011 22:06:38 +0000 (18:06 -0400)]
only use the label to initialize call number browse

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
13 years agoLP#783486: Improve authority lookup performance
Dan Scott [Tue, 17 May 2011 04:29:47 +0000 (00:29 -0400)]
LP#783486: Improve authority lookup performance

Testing showed that the two indexes added herein improve
authority lookup performance radically; on a 16 GB RAM
database server with 1.1M records, lookup times decreased
from 5500 ms to 0.223 ms. Recommended, would EXPLAIN ANALYZE
again.

Signed-off-by: Dan Scott <dan@coffeecode.net>
13 years agostop hold permit check from crashing if age protection in effect
Galen Charlton [Tue, 17 May 2011 04:40:02 +0000 (00:40 -0400)]
stop hold permit check from crashing if age protection in effect

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
13 years agoIgnore "deleted" authority records when using the tag-validation method
Mike Rylander [Mon, 16 May 2011 22:17:30 +0000 (18:17 -0400)]
Ignore "deleted" authority records when using the tag-validation method

Signed-off-by: Mike Rylander <mrylander@gmail.com>
13 years agoBorrow on_or_after() from MFHD/Caption.pm in MFHD/Date.pm
Dan Wells [Mon, 16 May 2011 19:23:10 +0000 (15:23 -0400)]
Borrow on_or_after() from MFHD/Caption.pm in MFHD/Date.pm

Signed-off-by: Dan Wells <dbw2@calvin.edu>
13 years agopersist partial changes to new copies in vol/copy editor has new copies are gathered.
Jason Etheridge [Mon, 16 May 2011 16:12:40 +0000 (12:12 -0400)]
persist partial changes to new copies in vol/copy editor has new copies are gathered.

In other words, you can do something like enter 5 in the "# of Copies" field, enter the first barcode (say b1), edit an attribute (say, set Circulate = No), and then enter a second barcode (b2).  Previously, the changes made to b1 would be lost as b2 was entered (or as other movement around the barcode entry textboxes happened) and both copies would get a Circulate = Yes, but now in this scenario, you would see 1 copy set to No and 1 copy set to Yes for the Circulate attribute.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agosimpler language, and the behavior of this action is configurable
Jason Etheridge [Mon, 16 May 2011 15:56:58 +0000 (11:56 -0400)]
simpler language, and the behavior of this action is configurable

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agousability tweak
Jason Etheridge [Sun, 15 May 2011 20:35:05 +0000 (16:35 -0400)]
usability tweak

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agodefault the label class according to library setting during vol creation
Jason Etheridge [Sun, 15 May 2011 20:15:30 +0000 (16:15 -0400)]
default the label class according to library setting during vol creation

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
13 years agoMore SVN to Git rigging
Thomas Berezansky [Sat, 14 May 2011 19:57:27 +0000 (15:57 -0400)]
More SVN to Git rigging

Staff client Makefile can no longer build based on SVN.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
13 years agoremove references to SVN now that we're using Git
Galen Charlton [Sat, 14 May 2011 20:19:36 +0000 (16:19 -0400)]
remove references to SVN now that we're using Git

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
13 years agoTrivial whitespace change
Galen Charlton [Sat, 14 May 2011 19:39:03 +0000 (15:39 -0400)]
Trivial whitespace change

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 473bc4784377977cc16a4f61cd8961be0ffe40df)

13 years agoadd missing update script for change to circ age stored procedure
gmc [Fri, 13 May 2011 21:00:30 +0000 (21:00 +0000)]
add missing update script for change to circ age stored procedure

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_1@20476 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoPatch from Ben Ostrowsky (LP#782268) to simplify seed/example permission setup and...
miker [Fri, 13 May 2011 17:31:18 +0000 (17:31 +0000)]
Patch from Ben Ostrowsky (LP#782268) to simplify seed/example permission setup and move one step towards being able to rid ourselves of permission.perm_list.id

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_1@20474 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoA bevy of MFHD bug fixes (and test cases)
dbwells [Fri, 13 May 2011 16:02:18 +0000 (16:02 +0000)]
A bevy of MFHD bug fixes (and test cases)

1) Remove hard-coded 'gap' text from format_part()
2) Honor $ypm## for chron_to_date() for annuals
3) Removed overly simple check on $w as digit
4) Allow for combined chronologies other than 2nd level
5) Make calendar changes trump $u counts
6) Honor issue restarts at calendar changes
7) Rudimentary support of $u counts for non-restarting issue numbering
8) Special interpretation of $yps for early winters (i.e. winter is the first season of the calendar year)
9) Teach chron_to_date() about early winters

The last two points deserve some special attention.  A large number of journals consider 'Winter' to be the first season of the year, so Winter 2011 means (roughly) January 2011, not December 2011.  However, there is no explicit way to indicate this in the standard, and also the code relies in many ways on the fact that 24 (chronology code for winter) is greater than 21 (code for spring).  To work around this, we are interpreting a certain ambiguous pattern in a particular way.  Specifically, if you set $w to a digit, then set $y to 'ps24,21,22,23' (or some variation with '24' as the first value), you will get this winter-first behavior.  Also, the season is treated internally as '20' then converted to '24' when processing is completed.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_1@20471 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agofix query in various copy count functions
gmc [Fri, 13 May 2011 15:45:29 +0000 (15:45 +0000)]
fix query in various copy count functions

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_1@20469 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agofor upgrade, let prefix and suffix in audit be null
gmc [Fri, 13 May 2011 13:26:46 +0000 (13:26 +0000)]
for upgrade, let prefix and suffix in audit be null

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_1@20467 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoadd affix columns to acn auditor table
gmc [Fri, 13 May 2011 13:09:54 +0000 (13:09 +0000)]
add affix columns to acn auditor table

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_1@20465 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoPatch from James Fournie addressing LP#781803: Multiple renewal fails on MAX_FINES...
miker [Thu, 12 May 2011 19:51:25 +0000 (19:51 +0000)]
Patch from James Fournie addressing LP#781803: Multiple renewal fails on MAX_FINES circs

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_1@20462 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoWrap proximity refreshing in a transaction to avoid timespans where there is no such...
miker [Thu, 12 May 2011 19:23:08 +0000 (19:23 +0000)]
Wrap proximity refreshing in a transaction to avoid timespans where there is no such information

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_1@20456 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoAddress LP#779975; Status of Available (0) not honored because 0==false -- use ternar...
miker [Thu, 12 May 2011 15:18:20 +0000 (15:18 +0000)]
Address LP#779975; Status of Available (0) not honored because 0==false -- use ternary op with defined() instead

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_1@20453 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoAdd missing permission checks to Serial.pm
dbwells [Thu, 12 May 2011 14:24:07 +0000 (14:24 +0000)]
Add missing permission checks to Serial.pm

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_1@20450 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoMisc updates to installer rigging
phasefx [Fri, 6 May 2011 19:41:31 +0000 (19:41 +0000)]
Misc updates to installer rigging

Fewer spurious errors (extras.nsi, MUI_TEXT)
More checks (makensis, unzip, branding)
Slightly improved Welcome screen

Author: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_1@20447 dcc99617-32d9-48b4-a31d-7c20da2025e4