LP1904036 Billing / payments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 current bills receipt

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 patron tab counts

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 open circ exists dialog; billing

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Billing / payments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Billing; credit card form

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Billing continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Billing continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Bills tab

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Bills wireframing

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Update stats after checkout; quite warning

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 place new hold button/action

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 patron summary pref name; penalties

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 print/copy patron address; summary styling

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 lint

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 add billings

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 add billings and more

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 events and overrides

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Alert dialog honors dialogTitle when present

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 events and overrides

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Renew with due date

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Renew all; initial events override dialog

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Renew; Batch Checkout/Renew; shared circ components

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Claims never checked out

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Claims returned

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Claims returned; circ notices

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron alerts page continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron alerts page; resolver service

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Move precat dialog to shared circ service

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron noncat count display

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Mark items lost

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Mark missing; initial checkin api

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Mark damaged; canceled holds display repair

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Edit due date; styling overdues

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron items out: printing

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron items out grid; shared circ grid; noncats

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Noncat batch retrieval API

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron items out grid; shared circ grid

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Angular login now handles routeTo

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Barcode completion continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Barcode completion dialog

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 checkout continued; grid actions

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 precat checkouts

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 precat dialog

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Prompt dialog focus input followup

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Prompt dialog focus input; submit on enter

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron ui checkout tab

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron ui checkout tab

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron ui checkout tab

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron ui checkout tab; noncats

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Prompt dialog gets input type and min/max

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron UI lint repairs; sanity checks

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron UI; search persistence

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron UI; canceled holds

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 patron Ui holds tabs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 patron UI noncat/holds summary

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 patron expire check

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Angular Patron UI initial structures

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Grid rowSelectionChange Output

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron search form improvements

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron sesarch form improvements

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1913811 progress dialog on Items Out grid

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1913811 Items out notice summary API batching

Tweak the open-ils.actor.user.itemsout.notices API to accept an array of
circulation IDs so the call can be batched from the client.  Similarly
modify the AngJS client to request the notice summaries in batch.

Further improves the notices API by removing an unneeded join and a
minor security fix to verify perms based on the in-database user ID
instead of the ID provided by the caller (w/ the note that the API only
returns numbers, not user data).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1868147-Titles in carousel run together in mobile display.

This patch uses the breakpoint option available in glide.js to limit the number of images in the carousel that display.

Files for both the tpac and the bootstrap opac have been updated.

There are two new variables based on bootstrap sizing, sm_width which defaults to 3, and xs_width which defaults to 2.
If a screen's width is set between 768-992 pixels, 3 images display in the carousel,
if the width is below 768 pixels, only 2 images display in the carousel.
The reduction of images helps with titles overlapping each other.

To test:
Apply the patch to an instance of Evergreen that displays carousels.
Reduce the screen size of the browser.  Eventually the carousel will display 3 and then 2 images.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP1857351 (follow-up): Fix typo that led to failing test

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1855761 Fix additional occurrences of 'Succeessfully'

Credit also to Christine Morgan and Martha Driscoll for working to
hammer out the process of editing and testing Angular files.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1855761 Another typo fix

Fix one more typo in the action dropdown.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1855761 Typo when creating new carousel mapping

Fixes two typos in the carousel messages.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1901760 Shared Worker minor lint repair

Repair a missing semicolon to keep lint happy.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1894131 DB Stamp: Sticky Holdings Org

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1894131 Sticky catalog holdings org select

Adds a workstation setting to make the org selector in the catalog
holdings tab sticky.

Also repairs some logic errors in the org select persistKey loading.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>

LP 1857351: fix field order for Course Terms

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP 1857351: fix field order for Recurring Fine Rules admin interface

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP 1857351: admin-page grid column order respects specified fieldOrder

Grid columns that aren't auto-generated and grids without a
specified autoGeneratedColumnOrder are not affected.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP 1857351: reorder a few other fm-editors

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP 1857351: set basic admin interface field order using route

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP 1857351: refactor basic admin component

Refactors the component to be more consistent in how it
gets data from ActivatedRoute.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1901760 Remove SharedWorker testing cruft

Otherwise they will work for no one!

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>

LP1901760 Improve SharedWorker non-support handling (Angular)

Reject requests to SharedWorker resources when shared workers are not
supported.  The caller is required to handle the rejection in whatever
way makes sense for the calling code.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>

LP1901760 Improve SharedWorker non-support handling (AngJS)

Force the SharedWorker code to run before org settings cache requests
are attempted so that we can tell before the lovefield request is made
wether or not a connection will be successfull.  In other words, we may
not know if cannotConnect is true yet, so force that logic to run first.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>

LP1687545: Force TT CGI plugin to use ampersands in query strings

Change our already-forked version of TemplateToolkit::Plugin::CGI
to use "old" style urls which became the new / only style after
CGI.pm was deprecated. This causes the query_strings property to
consistently use ampersands to separate query parameters.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1911031 Staff catalog honors pickup lib change

Manually modifying the pickup library in the staff catalog holds
placement form now results in using the selected pickup library.
Previously, the change was ignored by the form.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1896285: progress dialog when marking selected items as missing

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1896285 Post mark-missing serialized item load

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1896285 Batch mark item missing serialized

Process batches of items one at a time when marking them lost to avoid
sending too many parallel requests to the server.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1896285 Add new items avoids looping settings lookup

Refactor AngJS volcopy item add actions so it makes the minumum
necessary settings API calls for default copy status.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1896285 Patron search add to bucket serialize

Add a batch of patrons to a bucket one patron at a time to avoid
overwhelming the server with bucket item create requests and potentially
exhausing the open-ils.actor service.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1889128 (follow-up) associating inputs and labels

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1889128 Activation date repair and form reset handling

Fixes an issue where the holds activation date was not correctly
retrieved from the form.  Related, hold suspension and activation date
values are now reset/cleared when a new hold receipt is selected.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1889128 <eg-date-select/> clearable via model

Allow users of <eg-date-select /> to clear the selected value (set
current = null) via updates to their ngModel variable.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1889128 Support user settings for SMS prefs

Honor the user setting values 'opac.default_sms_carrier' and
'opac.default_sms_notify' in the Angular staff catalog place holds form.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1889128 Clear patron barcode on staff hold

Clear the patron barcode from the barcode input when toggling the holds
placement form to request a hold for the logged in staff account.
Otherwise, the barcode sticks around and could cause confusion.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1889128 Place holds honors default phone

Adds support for using the 'opac.default_phone' user setting when
placing holds in the staff catalog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1889128 Reset hold recipient info after success

* When all holds for a given recipient have been successfully placed,
directly or via override, clear the recipient data so new recipient data
can easily be added.

* When placing duplicate Part holds, ensure the same part is applied to
each hold context so the selected part is targeted for all of the
multi-holds.

* Fxes a regression in the display of multiple hold targets where only
the first target would display.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1889128 Confirm data loaded before Place Hold activated

When changing users in the place hold form of the staff catalog, the
form resets itself and refreshes all of the user and bib, etc. data.
This patch ensures all data has been retrieved before the place hold
button is reactivated after changing the user.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1889128 Holds reset repairs and making space

Collapse the Search Form on the holds page so the holds form and data
have more vertical room on the page.  Additionally, to help alleviate
any confusion that may be caused by the collapsed search form (and
because it has come up in other conversations), add a 'Return' button to
the holds page so users have an obvious way back to the previous catalog
page.

Fixes an issue where setting the hold recipient from a patron to the
staff account failed to properly clear the holds form, leaving (e.g.)
the wrong pickup lib in the selector.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1889128 Staffcat holds recipient / multi-hold repairs

1. Modifying the patron barcode input either directly or via patron
search now fully resets the form, including previously placed holds.

2. Modifying the hold receipient clears the previous "placing hold for
patron" receipient applied from within the patron app, i.e. the banner
along the top of the catalog page.

3. Hide the 'Number of copies' selector when multi-copy holds are not
supported.

4. Hide the 'Number of copies' selector when the request does not have
CREATE_DUPLICATE_HOLDS permissions for the currently selected

5. Display an error message when the barcode entered does not result in
finding a patron.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1889128 Staffcat hold form reset option

Adds a Reset button to the staff catalog holds form so subsequent holds
may be placed for the same items but for different patrons.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1889128 Staffcat support placing multiple holds

Adds support for the org unit setting 'circ.holds.max_duplicate_holds',
which allows staff to place multiple holds per target in the staff
catalog hold placement UI.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1887429 Holds supports circ.staff_placed_holds_fallback_to_ws_ou

Add support for the 'circ.staff_placed_holds_fallback_to_ws_ou' org unit
setting when staff place holds for patrons in the Angular staff catalog.
Specifically, if the patron has no preferred pickup lib set, fall back
to either the patron's home org or the workstation org depending on the
value of the org setting.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>