LP1956003 Stamping DB upgrade / hold group grids

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1956003 Hold Group Workstation Settings to Server Settings.

add Group Holds to grid settings in Seeded Values.

Signed-off-by: Lynn Floyd <alynn2671@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1960956 Stamping DB upgrade / usr message index (fix)

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1922975 Build scripts python3 minor fixes

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1922975: install python3 dependencies, rather than python2

Also specifies python3 in the shebang lines of python scripts,
and improves the documentation for translators about installing
these dependencies.

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1922975: update i18n scripts for Python 3

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1843970: Refactor Coded Value Map grid to use eg-admin-page

Also adds a new @Input to eg-admin-page that accepts arbitrary
columns based on <ng-template>s

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1838580: Holds Shelf detail view record summary doesn't populate

Fixes the record summary of the detail view from the holds shelf. After
the patch is applied the bibliographic data displays in the detail view.

To test:

1. Go to Holds Shelf
2. Select a line
3. Click on the Detail View button, and notice that the bibliographic
information doesn't populate.
4. Click on the MARC link, to see to that the link does not take you to the
MARC view.
5. Apply patch.
6. Repeat 1-4.  The bibliographic information now displays, and the MARC link
takes you to the correct page.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1960956 Stamping DB upgrade / usr message index

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1960956: Fix slow user merges/deletes

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1916600 Add Create Date as a column in Holdings View

Splits out Active Date and Create Date into two separate columns in holdings view.

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP#1950394: isolate attribute extraction of metarecord

This patch ensures that calling the Template Toolkit block
get_marc_attrs() on the metarecord's lead record's MARCXML
does not interfere with attributes already parsed from the
current bib's MARCXML on the record summary page in the Bootstrap
OPAC.

This fixes an issue where electronic resource links could fail to
be displayed under the following conditions:

- the MARC record has an 856 field with ind1 = 4 and ind2 = 0 or 1
  and is NOT a located URI
- the bib is part of a metarecord set with at least one other member
- the master record in the metarecord set does not have 856 fields

To test
-------
[1] Create a setup where two bibs are in the same metarecord set, one
    with 856 fields and one without. Arrange that the one without
    856 fields is the lead record in the metarecord.
[2] View the one that has 856 fields in the Bootstrap OPAC's record
    summary page. Note that the electronic resource links do not
    appear.
[3] Apply the patch and repeat step 2. This time, the links should
    appear.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1939426 Traditional Catalog Holds: Patron Info Not Populating

When no hold groups exist, its interface isn't present. When
placing volume holds, the advanced link isn't present.

This checks that those elements exist before accessing their
attributes and adds a missing name attribute to the Bootstrap
catalog to display the email address.

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP1964019: Change span tag to div to work around a Chrome bug

For some reason the span tag wrapping the contents of the Holdable? column
began to cause problems with Chrome 99 on Windows. Changing the spans to divs
works everywhere without turning off tooltips.

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

Revising 'Using the Public Access Catalog' page

Updating screenshots and information in this doc to match Bootstrap.  Some areas need updating still.

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1955931 Staff catalog show more details - add due date

Adds a due date column to the show more details view in
the Angular staff catalog.

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

Update Test for LP1722827 After LP1482757

The 4th part of the old test is incorrect as not deleting these is
the point of 1482757. Test has been updated to reflect that.

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP#1482757: stamp upgrade script

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP#1482757: stamp upgrade script

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP#1482757: Speed Up the Delete of Orphaned URIs in upgrade script

Modify the code that deletes orphaned asset.uri table entries in the
upgrade script to use IN logic on the subquery, because IN is much
faster than NOT IN.  Also take into account the link between
serial.item and asset.uri so that we don't accidentally delete URIs
used by serial items.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jessica Woolford <jwoolford@biblio.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP#1482757: Delete URIs and call numbers when all 856 fields are removed

This patch assures that URIs and call numbers are deleted as appropriate
when all 856 fields are removed from the MARC.

Also provides for tracking editor and edit_date when call numbers are
deleted.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP#1482757: Amend upgrade script to remove existing orphaned URIs

Remove orphaned URIs from the database that have accumulated from past
additions, updates and deletions of records with located URIs.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP#1482757: Remove 'orphaned_uri_list' and 'NOT cn.deleted' criteria

Per Dan Wells' suggestions.

1) One possible "crack" I see for data to fall through is the dead map
selector. The "AND cn.label = '##URI##' AND NOT cn.deleted" seems overly
restrictive. Now, I realize we *shouldn't* have mappings to deleted or
non-##URI## call numbers, but it isn't impossible, and I don't think we'd
have harm in leaving those restrictions out. If a map isn't used, let's
get rid of it regardless, I think.

2) (side note) orphaned_uri_list doesn't seems to be used any more, so
should be removed.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP#1482757: Be sure to remove all orphaned URI

As reported by Michele Morgan, URIs can be orphaned in some cases, such
as when a location drops one of several 856 entries.  This commit tracks
objects at the mapping level, to identify disused URIs even where the
call number level is not changed.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP#1482757: More careful Located URI remapping

Instead of recreating all Located URI mappings, we will add any new
ones and remember all those (existing and new) that are in use. Any
existing maps that we don't see in this record, and whose URI is only
used once previously and therefore about to be orphaned, we remove.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

Update to Batch Search page

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

Avoid fleshing standing penalty org unit children

When fleshing the org unit on standing penalties, exclude child org
units. We don't need them, and they can cause issues when your
standing penalty has a Depth of "Everywhere": you end up with a full
copy of the org unit tree, and you will include this when editing
and saving the user.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1927990 Bootstrap OPAC: Patron messages lose line breaks

Fixes problem where messages added to the Patron Message Center
lose their line breaks in the Bootstrap OPAC and makes them
difficult to read.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP#1949389: reduce number of PCRUD requests by subscription manager

This patch changes how the AngularJS subscription manager fetches
serial item templates. In particular, rather than issuing a PCRUD
request for every org unit in the system, it fetches them in one
fell swoop. This fixes an issue where loading the subscription manager
in a large Evergreen consortium could lead to so many requests that
it drives PCRUD into backlog mode, resulting in higher request
latency across the board.

To test
-------
[1] Apply the patch.
[2] Verify that the subscription manager lets you set the receiving
    template for each distribution and that the drop-down's contents
    changes if the distribution library is changed.
[3] Verify that the Apply Binding Template action works and that
    the binding template drop-down(s) include the relevant copy templates.

Note that if a binding template has been set already, the current
binding template is _not_ displayed as the selected value in the drop-down.
This is existing behavior that this patch does not aim to fix.

Sponsored-by: BC Libraries Cooperative
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>

LP#1946019: copyloc.js change to clear locations on new branch select.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1955927_Barcode_search_fails_in_patron_search_modal

Fixes the barcode search in the patron search modal in the holds screen.

To test:
1. Navigate to the 'place a hold' screen in a bib record and open
the patron search modal.
2. Enter a patron barcode.
3. The search for the patron fails.
4. Apply the patch and repeat.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP1957840 Typo fix in mcrp class in fm_IDL.xml

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1947595: stamp upgrade script

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

Lp 1947595: Remove the array_accum aggregate function

Remove the array_accum aggregate from Evergreen because it will need
to be dropped and redefined when upgrading to PostgreSQL 14.

Replace any uses of array_accum with array_agg in the code.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1951021: account for change in OverDrive checkout response

The OverDrive circulation API soon will stop providing a direct
download link in favor of displaying a separate fulfillment page
(either as an iframe or a redirect). This patch implements this
change with the redirect option.

Additional information on the API change can be found at

http://developer.overdrive.com/overdrive-api-notices/01-sep-2021-coming-soon-changes-to-overdrive-checkouts-api

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Garry Collum <gcollum@gmail.com>

Adding videos from Conferences

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

Docs: Updating Opac Lists doc

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1948035 (follow-up): don't use commonjs in spec tsconfig

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1948035 Angular 12 updates

Run ng upgrade from 10 -> 11 -> 12.

Updates package.json deps for Angular 12.

Removes deprecated angular/http dependency

Fix a couple of cases where Promise<any> now requires resolve(something)
instead of resolve() (which would be Promise<void>).

Fix some CSS syntax issues.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1948035 Update Node/Angular Deps for Ang 12

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

Docs: use asciidoc ordered list rather than adding numbers manually

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

Docs: updating z39.50 overlay doc and images

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

Docs: Update barcode_completion_grid.jpg

Updated barcode grid screenshot; other one was too blurry

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

Docs: Update basic_holds.adoc

removing Print full pull list alternative reference

https://bugs.launchpad.net/evergreen/+bug/1775402
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

Docs: Update basic_holds.adoc to include updated screenshot

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

Docs: add a chapter about the course materials module

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1903476 Followup; Remove perl action, limit to docs/

Since the 'ubuntu-latest' image includes perl 5.30 the
actions-setup-perl step just adds more time to the process.

GitHub Actions can be limited to (or exclude) paths so now
docs will only be built when pushes or PRs happen under docs/.

Also added a couple name tags for the interface.

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP1903476: Use Github Actions to build antora documentation

This allows documenters to submit a pull request and get a
preview version where they can view their changes.  The goal
is to provide quick feedback to documenters on whether their
changes build correctly and appear as desired, without them
having to have a full docs building setup locally.

To test:
1. Use the Github Web site to fork the Evergreen repository.
2. Take the .github/workflows/docs.yml file from this commit.
Add it to any branch of your fork of the Evergreen repository.
3. Click on the Actions tab of your fork in the Github Web
site.
4. Click on the most recent run (at the top of the list).
5. When the build process is done (should take 3-4 minutes),
download and unzip the artifact that appears at the bottom of
the screen.  Open index.html in your browser.  Confirm that
the docs built properly.
6. On the same branch, make some changes to the documentation
in the docs/modules directory.
7. Repeat steps 3-5.  Confirm that your changes are reflected
in the new artifact.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP 1942645: stamp upgrade script

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

lp-1942645 term name uniqueness

dropped name uniqueness between orgs, added constraint to owning lib and name

Includes syntax corrections from Martha Driscoll -- thank you, Martha!

Signed-off-by: malexander <malexander@catalyte.io>
Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

Lp 1862652: pingest.pl reingest record attributes fix

Use the rdeleted parameter when reingesting record attributes in
pingest.pl support script so that passing argument values to the
--attr option makes sense.

Prior to this patch, arguments of the --attr option would be ignored,
and all record attribute fields were reingested for all records,
deleted and not deleted alike.

With this patch, the arguments of the --attr option are respected for
not deleted records.  Deleted records still have all attributes
reingested.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1933275 Staff catalog holdings view shows correct counts

teaches the Holdings view to determine the number of copies and call
numbers attached to each org unit based on the full data set (via new
API) instead of copies in hand, since we may only have copies in hand
for a subset of child org units.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

Docs: remove outdated screenshots

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

Docs: update lsa-barcode-completion

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

Docs: correction to 3.7.2 release notes

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

Docs: correction to Override Action docs

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

LP1772631 Untranslatable Strings

Changes as suggested have been made in t_bills_historical.tt2, marking
appropriate lines for translation.

Signed-off-by: Shula Link <slink@gchrl.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1949910: serialize deleting items from item bucket

This patch serializes the fetching and fleshing of items to delete
when the delete-from-item-bucket action is invoked, thereby
avoiding possible drone starvation from open-ils.search. It
also throws up the progress dialog for good measure while
the deletion occurs.

To test
-------
[1] Set up an item bucket with 25-50 items.
[2] From the item bucket intervace, invoke the action to delete
    all of the items.
[3] Note that the open-ils.search.asset.copy.fleshed2.retrieve calls,
    one for each item, are all made simultaneously. Assuming stock
    max_children settings, this will cause open-ils.search to log
    that some requests are hitting the backlog.
[4] Apply the patch and refresh the item bucket page, then repeat
    step 2 (it doesn't matter for this purpose that the items have
    already been deleted). This time, the open-ils.search API calls
    are made serially and a progress bar is displayed while the
    deletion takes place. Verify that no requests hit the backlog.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

Forward Port 3.6.3 Upgrade Script

docs: updating batch_importing_MARC.adoc

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

Docs: lp1739277 Release Notes for Org Selector Styling

- Add release notes for new Org Selector Styling functionality.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
new file:   docs/RELEASE_NOTES_NEXT/Client/org-select-styling.adoc

Signed-off-by: Jennifer Bruch <jbruch@sparkpa.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

lp1739277 OrgSelect Class Callback Holdings Implementation

- Implement OrgSelectClassCallback in Angular Catalog Holdings UI

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/catalog/record/holdings.component.html
modified:   Open-ILS/src/eg2/src/app/staff/catalog/record/holdings.component.ts

Signed-off-by: Jennifer Bruch <jbruch@sparkpa.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1739277 Angular org selector style callback

Allow the caller of an <eg-org-select> to pass a function which is
called against each org unit in the list to determine what CSS class(es)
should be applied to the org unit label in the list.

Includes sandbox example.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Bruch <jbruch@sparkpa.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

lp1855780 stamp upgrade script

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

lp1855780 preload values for comboboxes in angular event definition editor

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

lp1855780 remove unnecessary whitespace

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1855780: add release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1855780: add grid config settings

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1855780: improve reporting of event test errors

- make error title/caption strings available to i18n
- catch and report on exceptions, not just ILS events

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1855780: adjustments to cloning

- set the owning OU to null in the clone
- reduce console noise when cloning environment entries

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1855780: tweaks to grids

- make main A/T event definition grid header sticky
- do not display environment ID and parameter ID
  columns by default in the event definition
  editor

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1855780: add option to include environment in clone of an event

This recovers a patch from Mike Risher that got dropped
when attempting to get a clean rebase from a branch merge.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1855780: avoid race condition when deleting env or params

When deleting from a grid using pcrud.autoApply, the grid
should be refreshed only at the very end. Otherwise, even if you're
deleting only one row, the grid reload could occur before the
deletion is committed, yielding a grid fetch error when
pcrud complains about verifying access to a row that is
no longer in the database.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1855780: updates to IDL

- mark various action/trigger record fields as required
  for the sake of the Angular record editor
- make atcol retrievable via pcrud

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1855780: fix lint

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1855780: adding the go-back button from Mike Risher's code

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1855780 Angular Notification/Action Triggers port

Port Notification Action Triggers from DOJO to Angular.  This consists of 4 grids, each
navigated to by its corresponding tab. The Trigger Event Definitions grid allows
cloning of records.  When editing an event defintion one can also edit parameters,
environments, and run tests.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1951030: Remove OpenILS/Utils/ISBN from Manifest

Remove a remnant of the OpenILS::Utils::ISBN module that was removed
in the branch for Launchpad bug 1856906.

To test this fix, run make check in Open-ILS/src/perlmods on a test
system to run the tests.  Before this patch, you get the following
message:

WARNING: the following files are missing in your kit:
lib/OpenILS/Utils/ISBN.pm
Please inform the author.

After applying this patch, the message goes away.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1856906: (follow-up) fix unit test count

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Docs: Adding latency test and disable sounds to workstation admin.

Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

Docs: Transit List

Documentation on Transit List.

Signed-off-by: Lynn Floyd <alynn2671@gmail.com>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

Docs: Update receipt_template_editor.adoc

Fixes https://bugs.launchpad.net/evergreen/+bug/1929592

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1766726 Clarify Field Hints on Print Templates

Adds 'patron.' to beginning of patron field hints in Checkout and Items Out
templates to make it easier for users to understand.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1528301: minor tweaks to release notes

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1528301: Release Note for Phone in Checkin Response

Have to tell people about it if they're going to use it.

Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
Signed-off-by: Martha Driscoll <driscoll@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1528301: Hold Notify Phone in Checkin Response

Adds a setting to oils_sip.xml.sample to en/dis-able
the extention of including the hold notify phone number
for captured holds in the SIP Checkin Response.
Defaults to false.

Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
Signed-off-by: Martha Driscoll <driscoll@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1528301 Add SIP Support for BF field on type 10 checkin responses

This little patch will append the BF field in the SIP response during
checkin when the item is for another hold. Some self check software vendors
(ahem Bibliotheca) implement the hold phone number for the next patron this way.
You will need this patch as well as the code change to the SIPServer repo
LP1528301_Add_SIP_Support_for_BF_field_on_type_10_checkin_responses

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Martha Driscoll <driscoll@noblenet.org>
Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
Signed-off-by: Martha Driscoll <driscoll@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1856906: remove unused OpenILS::Utils::ISBN perl module

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1819233 improve AngularJS eg-basic-combo-box filtering

Adjust the eg-basic-combo-box so that it doesn’t give console errors
when typing characters such as [. Fix the bug that causes it to
sometimes show no results when there are valid results that match.

To test
-------
[1] Apply the patch, then create a new report template, add a
    display field, then open the Change Transform modal.
[2] Verify that the selection box will accept characters like '['
    as input without browser console noise, that the filtering
    is case-insensitive, and that filtering continues to work
    after clicking on the selector.
[3] Instances of this combo box can also be found in the AngularJS
    volume/copy editor.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1906842 PLACE_UNFILLABLE_HOLD permission not working if no titles exist

This fix will correct an issue where the screen just keeps looping to
the override screen when trying to place a hold that has no titles
available for it.

Patch courtesy of Mike Rylander.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

docs: 3.8 Triggered Events Log Rewrite

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

docs: 3.8 hold copy ratio reports

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

docs: 3.8 Acq Admin

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

docs: 3.8 Patron Photo URL + Consolidate Patron Notes

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

docs: 3.8 selected new Library Settings

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

docs: 3.8 Override Actions

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

docs: 3.8 Stripe Payment Intents

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1831803: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1831803: (follow-up) update release notes formatting

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1831803: drop the disused search-related types during upgrade

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>