JBAS-2284 Identifier (call number) browse respects '.' chars

When performing an identifier browse, avoid stripping '.' characters
from the sort value when locating the browse pivot.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1813633 TCN search can find deleted records

As with the XUL client, when performing a bib record TCN search
(Cataloging -> Retrieve Record By TCN), first look for non-deleted
records with the requested TCN.  When none are found, perform a
secondary search for deleted records with the requested TCN.

To test in concerto:

[1] Navigate to Cataloging -> Retrieve Record By TCN
[2] Search for TCN value "10", which is deleted by default in Concerto.
[3] Confirm the deleted record is loaded.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>

JBAS-1832 Minor bug avoid errors in holdings edit

Signed-off-by: Bill Erickson <berickxx@gmail.com>

SIP Fines/fees retrieval test

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2279 Record detail search navigation repairs

Teach the browser client catalog to:

1. pass query params from title links from the embedded catalog to the
   angjs wrapper opened in a new tab.

2. pass query params from the record detail page angjs container page
   down to the iframe so the query is propagated to the catalog.

3. add tpac template mods to KCLS record detail template so the wrapper
page can get search result counts.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1832 Ignore ansible retry files

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Invoice export deletes previous day's local file

Keep only the most recent invoice export CVS file on the source
(utility) server in case of delivery failure to prod-depot.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1832 CAPS Librarians get UPDATE_AUTHORITY_RECORD perm

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2239 Browse default sort pubdate repair

Newest to oldest is descending...

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2202 Update items update api fix

Fix an inconsistency between how the KCLS update-items interface calls
the volume save API in some cases with un-fleshed copies.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

CAT-211 Vandelay Label Improvements

- Cause "Save as New Template" to display as "Modify Template" when an
existing template is selected.
- Cause "Upload" to display as "Import" when importing from the queue.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/import.component.html
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/import.component.ts

JBAS-562 Copy quality labels ported to browser

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Revert "JBAS-2242 update receipts for foundation library giving day."

Libary giving day is past.  Reverting.

This reverts commit 34d6ba621d1123fe3d30b3758f7b182a6b756719.

CAT-212 Improve clarity of subfield entry input

- Apply a dotted border line to beginning on .marcsfvalue css class
- Increase width of subfield entry input

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/cat/share/t_marcedit_editable.tt2
modified:   Open-ILS/src/templates/staff/css/cat.css.tt2

Revert "JBAS-2245 Outreach 3 new groups / patron editor"

These groups should not have been added.

This reverts commit d2ca7a72de06cf93605c4bb68c1a4be451f3cc5b.

Activate Mercer Island teacher accounts

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2246 Hold notify settings hide sms; phone example

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2245 Outreach 3 new groups / patron editor

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2232 Self-reg additional cards notice

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2234 eCard verify form WCAG repairs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2232 Self reg link color contrast

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2232 Patron self-reg WCAG fixes

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2141 Patron UI layout improvements

* Move patron address to the top of the UI
* Hide the patron address copy/paste textarea until needed (was taking
  up a lot of space)
* Hide list of penalties and instead display a styled exclamation next
  to the patron's name when alerts exist.
* Move Fines, etc. counts to the bottom of the patron summary.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2242 update receipts for foundation library giving day.

Bradley Bonner
bbonner@kcls.org

JBAS-2185 Batch MARC CN class repair

Be sure MARC call numbers are fetched using the correct call number
classification in the batch call number editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1761222 Holdings batch circ retrieval

Fetch non-checked-in circulations for copies in the Holdings
maintenance grid (for due date display) in batch instead firing a
potentially vary large parallel batch of pcrud API calls.

This also limits due date display to items that have open circulations,
consistent with the XUL client.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1761222: Add four columns available in XUL client

The XUL client had these columns but they hadn't been added to the web client
yet. This commit adds them:

  - Classification
  - Due Date
  - OPAC visible?
  - Quality

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1761222: Add Fine Level, Loan Duration to Holdings View grid

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1693580 Marc editor notify and API changes

1. Indicate in the interface when a bib/auth MARC record edit failed or
succeeded.

2. Handle permission failures on MARC edit by displaying the permission
override dialog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1693580 Authority create/update API repairs

Fixes issues with the authority record create and update open-ils.cat
API calls, where internal function calls were not passed the correct
values.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1716473 A few tweaks to correct field labels

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1716473 Release Notes: copy edit hide disabled

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Geoff Sams <gsams@roanoketexas.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1716473 Copy editor hide disabled defaults

Disabling a field in the copy editor "Defaults" tab now hides the field
instead of simply disabling it.  Once a field is hidden, subsequent
field shift left to fill the space.

The "Working Items" grid is shifted to the bottom of the page, below the
attributes editor.  This allows the attributes to fill the horizontal
space and puts the working items and save operations visually at the end
of the page, i.e. at end of the work flow.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Geoff Sams <gsams@roanoketexas.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

JBAS-1832 3.2 point release updates SQL cross-port

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1832 3.2 point release updates SQL cross-port

Signed-off-by: Bill Erickson <berickxx@gmail.com>

CAT-199 Port browse default sort ws setting

Signed-off-by: Bill Erickson <berickxx@gmail.com>

CAT-199 getLocalItems to getItems

- Refactor implementation of search pane and browse search default value
retrieval when searching the catalog.

Signed-off-by: Katlyn Beck <kbeck@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/web/js/ui/default/staff/cat/catalog/app.js

CAT-199 Save state of default browse dropdown

- Ensure Default Browse Sort selector displays existing choice.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/web/js/ui/default/staff/admin/workstation/app.js

CAT-199 Default Browse SQL additions

- Add eg.search.browse_sort_default to config.workstation_setting_type

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/sql/Pg/950.data.seed-values.sql
new file:   Open-ILS/src/sql/Pg/upgrade/XXXX.data.cat-199-default-browse.sql

CAT-199 Workstation admin default search options for browse

- Set eg.search.browse_sort_default on selection of option
in dropdown.
- Append default browse sort to url on browse search.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Katlyn Beck <kbeck@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/admin/workstation/t_splash.tt2
modified:   Open-ILS/web/js/ui/default/staff/admin/workstation/app.js
modified:   Open-ILS/web/js/ui/default/staff/cat/catalog/app.js

JBAS-2221 Hide CN classification selector

We always use the same classification, so hide the selector in the
volume batch editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2019 Invoice export crontab entry

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2019 Invoice export support

DB function for finding and stamping invoices for export.
Script for calling DB func, creating CSV from the exported invoices, and
SCP'ing the invoices to prod-depot.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2211 Flat text editor uses Courier

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1817601 MARC Flat Text Editor Monospace Font

Use a fixed width font in the MARC flat text editor, consistent with the
fonts used for the non-flat-text editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2145 Hide Parts, Conjoined Items tabs

Hide these tabs in the catalo record detail page since we don't use
them.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2224 Copy detail ISBN display repairs

Prevent long ISBN strings from distorting the copy detail display.
Instead, chop off the overflow and show the entirety via tooltip.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2216 Increase scollable menu height

Increase all scrollable menus (including grid context/action menus) by
50% to reduce scrolling requirements.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1832 Skip reporter simple record rebuild

This step must be done after the display fields have been added as part
of a bib reingest.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2222 Holdings view defaults to KCLS org

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2204 Browser client iframe Reload option

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2215 Move Print Labels menu option

While we're in there, hide 2 of the booking actions since KCLS does not
use booking.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2226 Catalog title links open new tab

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2147 Replace barcode opens volcopy editor

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1832 Ansible deploy chown additions

Signed-off-by: Bill Erickson <berickxx@gmail.com>

CAT-199 Recover XUL browse sort default

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2210 Hide self-reg blank card/section

Signed-off-by: Bill Erickson <berickxx@gmail.com>

CAT-206 Clear Date performs pcrud

- Hitting Clear Date now performs a pcrud operation to clear the date
in the DB.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/cat/share/t_marcedit.tt2

CAT-206 Cataloging Date Compare

- Compare selected and existing cataloging dates to
toggle availability of Update and Clear date buttons.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/cat/share/t_marcedit.tt2
modified:   Open-ILS/web/js/ui/default/staff/cat/services/marcedit.js

CAT-206 Update Date performs pcrud

- Modify Update Date functionality to perform pcrud
update of cataloging_date

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/web/js/ui/default/staff/cat/services/marcedit.js

CAT-206 Cataloging Date in Webby

- Add Cataloging Date row to marc edit interface
- Add update and clear buttons for Cataloging Date

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/cat/share/t_marcedit.tt2
modified:   Open-ILS/web/js/ui/default/staff/cat/services/marcedit.js

CAT-207 XUL catalog Update Items fix

- Added missing update_items function

Signed-off-by: Katlyn Beck <kbeck@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/xul/staff_client/chrome/content/cat/opac.js

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Ecard form language updates.

* Replace "Barcode with "eCard Number"
* Replace "verify" with "confirm"

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1832 Remove dupe rmsr rebuild (3.2 sql upgrade)

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2192 Update bib vis attr cache for 3.2 upgrade

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2196 Staff browse includes transcendant bibs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2196 Avoid dupe browse mattype filter

Rearrange browse SQL to avoid returning duplicate results when browsing
with a mattype (ccvm) filter.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2196 Remove dupe/stle staged_browse function

Remove a stale copy of the staged_browse function from the database so
that we only have to maintain one -- the one with our mattype filters.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

lp1717551 Holdings view action menu clarity adjustment

- Added clarifying wording for add, edit, and delete options

Signed-off-by: Katlyn Beck <kbeck@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/cat/catalog/t_holdings.tt2

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2193 Hide pfx, sfx, parts in vol-copy builder

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1832 Move org setting inserts to block

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1832 Vandelay tracker SQL fixes x-port

Cross-porting 8de5d650be848ab5b36c24ddc6311bf281cca086 for KCLS SQL 3.2
upgrade.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1806968 Vand ses. tracker upgrade SQL additions

Force the default value to show in the DB as 'bib'::text instead of
'bib'::vandelay.bib_queue_queue_type, which might be confusing.

Removed some stray SQL from the script.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>

LP#1806968 Vandelay record_type sql fix

- Change record_type to TEXT rather than an enum, constrained
with the option of "authority" or "bib"

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/sql/Pg/012.schema.vandelay.sql
new file:   Open-ILS/src/sql/Pg/upgrade/XXXX.schema.vandelay-record-type-fix.sql

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>

JBAS-1832 Vandelay grid/template workstation settings

Signed-off-by: Bill Erickson <berickxx@gmail.com>

New self-reg cards Jan 2019

Signed-off-by: Bill Erickson <berickxx@gmail.com>

per JBAS-2187, edit marc template to remove extra spaces between n and eng

JBAS-2832 Trim copy editor shelf locations

Only show copy locations for workstation and parent org units in the
browser client copy edit UI, regardless of which orgs the user has
access to edit.

KCLS maintains a duplicate array of copy location for each org and
performs nightly jobs to ensure the location match the copy's circ lib.
Becuase of this, only a single list of locations need be displayed.

If a copy links to a location outside of the scope of here + parent org
units, add its copy location to the list as well, suffixed by owning lib
to differentiate.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1746360 Bib bucket 'Edition' display repair

Parse the JSON string value when fetching the metabib.wide_display_entry
data used to render the new Edition value.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1746360 Record Bucket Missing Deleted and Edition Columns

Added deleted and edition columns to the record bucket grid.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2181 Authority edit opens MARC editor (browser)

Cross-port b1f25d1d to local file: Open authority file in browser-based
MARC editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2186 XUL Find authority by ID fix

Cross-porting dfdf183 from origin's copy of list.js to list_id.js

---

LP#1638299: adjust staff-side authority browse

Now that the primary key of the authority.thesarus table
has changed from the single-character code to the LC-assigned
authority code, a bit of additional translation is required.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
---

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1779158 Angular7 and ng-lint updates

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1779158 Import field id/class mismatch fix

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1779158 Always clear import selection

Clear the import selection (e.g. Queue => Import All Items) from the
import UI when the user navigates away, regardless of whether the import
succeeded.  Otherwise, the import UI gets stuck in selection mode
requiring the user to manually clear it.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1779158 Vandelay workstation setting repairs/additions

* Fix some workstation setting names that were missing the 'eg.grid.*'
  prefix
* Add workstation setting types for merge profile and attr definition
  admin pages.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1779158 Import non-matching saved template repair

Fix issue in Vandelay import form templates where template variable name
did not match the form variable name.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1779158 Cache new queues / display active queues

* Only list active (non-complete) queues in the Vandelay queue selector
  combobox.
* Display an alert message when the user attempts to create a queue
  whose name collides with an existing queue for the user.
* Be sure newly created queues are added to the local cache of queues in
  the Vandelay service.
* Remove unused activeQueue list from vandelay.service to avoid having
  to maintain 2 separate queue caches.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1779158 Angular alert dialog component

Similar to the PromptDialogComponent except it displays a simple message
(formatted as 'danger') and the only option available to the user is to
close the dialog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

lp1779158 Inspect Queue Improvements

- Add "Delete selected" option to Authority Queues
- Change Queuetype to 'authority' from 'auth' when selecting single record to view
in auth record queue.
- Ensure "Imported As" link correctly navigates to Auth record view for Auth Queues

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/queue-list.component.html
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/queue.component.html
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/queue.component.ts

Signed-off-by: Bill Erickson <berickxx@gmail.com>

lp1779158 Vandelay Authority Import Tweaks

- Check for "Auth" string
- Dummy rec.import_items when record is not bib
- Teach resolveQueue() to assume startQueueId unless a queue is selected already

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/import.component.ts
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/queue.component.ts
modified:   Open-ILS/src/eg2/src/app/staff/cat/vandelay/vandelay.service.ts

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1779158 Vandelay UI accessibilty/usability improvements

* Associate <input>'s with their labels in the import and export forms
* Hide the MARC removal groups selector when record type is authority.
* Disable ACQ copy overlay option when record type is authority.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2182 Rebuild reporter simple record for 3.2 upgrade

Signed-off-by: Bill Erickson <berickxx@gmail.com>

CAT-200 Remember last search template used

- When selected, the template name is saved to localStorage.
- When the page is loaded or refreshed, the template is retrieved
and populated from localStorage based on stored name.

Signed-off-by: Katlyn Beck <kbeck@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/web/js/ui/kcls/conify/global/config/search_templates.js

CAT-205 Add results view option to catalog search template

- Added "Results View" dropdown to Search Templates section with
options for "Simple View" and "Detailed View".
- Selection from dropdown saves to a template.

Signed-off-by: Katlyn Beck <kbeck@catalyte.io>
 Changes to be committed:
modified:   KCLS/openils/var/templates_kcls/opac/parts/advanced/search.tt2

JBAS-2095 Syslog delete all files older than 2 years

In other words, only retain the activity and apache access log files for
2 years total.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2174 Dog/Yeti combo self-reg cards

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-2138 Patron search grid column configs

* Create requested layout config
* Create org setting type to store the value
* Remove the analogous workstation setting type to prevent storing
  overrides to column configs.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1832 3.2 sample data gets workstation setting types

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1832 Crontab updates to match production

Signed-off-by: Bill Erickson <berickxx@gmail.com>