old-git.evergreen-ils.org Git - contrib/Conifer.git/log

CStoreEditor default session locale

Adds a new package-level variable:

$OpenILS::Utils::CStoreEditor::default_locale

If set, this value is used as the session_locale for new opensrf client
sessions. If unset, the session_locale remains untouched by
CStoreEditor.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

Sanity check cstore limit/offset param values

Certain cstore calls (direct / json_query) that support limit/offset
params called with a non-string / non-numeric value

e.g. { "limit": null }

result in a cstore segfault as it tries to call atoi(NULL) under the
covers. This patch prevents this by verifying that the limit/offset
values are actual strings or numbers (i.e. return a value from
jsonObjectGetString) and not JSON_NULL, etc.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Merge branch 'rel_2_3' of git.evergreen-ils.org:Evergreen into rel_2_3_mergery_2

Conflicts:
Open-ILS/src/templates/opac/css/style.css.tt2
Open-ILS/src/templates/opac/parts/js.tt2

Signed-off-by: Dan Scott <dscott@laurentian.ca>

TPAC: size_bigger, not size-bigger

Amusingly, TT2 attempts to treat "bigger" as a value to subtract from
"size". Cute. But we don't want the messages in the Apache log.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>

TPAC: Autosuggest focus() throws a JS error

On page load, the Dojo autosuggest code tries to set focus to the
element with the ID "search_box" - which is fine, except when the page
does not have said ID. Therefore, test for the existence of the ID
before setting focus to it.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Art Rhyno <art632000@yahoo.ca>

Use XUL_REMOTE_BROWSER constant in reporter

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Documentation: Add one paragraph to Auto Override Patron Hold Events.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>

Documentation: add Auto Override Patron Hold Events documentation from ESI.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>

TPAC locale picker: use POST instead of GET

Users could (deliberately or not) change another's language
preferences by sharing links with the "set_eg_locale" GET param given
the locale picker's current behaviour. By switching to a POST param, we
prevent this result from accidentally occurring.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Art Rhyno <art632000@yahoo.ca>

Fix thinkos in EDI Invoicing

The lesson of the day is, test the code you actually commit, not just
the bits and pieces. Thanks to Bill Erickson on this.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Add Conifer's custom MARC templates

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Stamping upgrade script for copy editor field hiding permission

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Update permission name to match existing ones

To be consistent with our previous naming scheme for these.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Provide permission for copy editor field hiding

We can adjust what fields are available in the copy editor in 2.2+, but that
requires the general UPDATE_ORG_SETTING permission. The YAOUS-specific
permission here allows more granular control, so that staff can be given the
ability to adjust only that one OU setting.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Hide OPAC-invisible holdings from SRU/Z39.50

The basic_holdings Supercat method filtered out deleted call numbers and
copies, but didn't filter out copies based on the OPAC visibility status
of copy location / status / the copy itself. This has undesired results
when third-party services request copies via SRU or Z39.50 and expose
copies that should not be visible to the public.

We wrap all of the visibility and deletedness checks for a given copy up
into a subroutine so that we can avoid repeating ourselves in the
basic_holdings logic. Also, if we missed a test, we can add it in one
handy place :)

(Thanks to Galen Charlton for finding two missing tests: circ lib
visibility and owning lib visibility!)

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Art Rhyno <art632000@yahoo.ca>

TPAC: Centralize font size definitions

The TPAC CSS had a mix of absolute and proportional font size
definitions, making it impossible to define a single base size and have
the layout adjust appropriately, as well as making it difficult to tweak
sizes to, say, eliminate the distinction between 11px and 12px text.

Accordingly, create a separate TT2 file to define standard font sizes,
define one base font size, and then use proportional percentage-based
size definitions for a set of standard font sizes. This way, a site
could easily adjust the base font size to 15px and the rest of the
layout should automatically adjust, and/or revert to using absolute font
sizes for different categories if they prefer.

Note that I did simplify some of the categories of font sizes, as the
distinction between 111% and 110% was probably not evident to most
humans at most font sizes, and even the distinction between 120% and
125% would be 14.4px vs. 15px given a base size of 12px - which
different user agents could render differently anyway.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>

Documentation: Add triggered events and holds management docs from ESI.

Content and images from http://www.esilibrary.com/esi/availableDocs.php.
Also fixed some formatting issues for previous committed documentation.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>

Documentation: Add sections to Local System Administration from ESI

Content and images from http://www.esilibrary.com/esi/availableDocs.php

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>

Simplified Hold Pull List: Fix broken filters

Only two filterable fields were available, and at least
one didn't even work.

Now we have a few more, and they seem to all work for me in testing.

This problem was reported to me by Thomas Berezansky.

While we're at it, also make sure the list of shelving locations in that
filter dropdown is sorted alphabetically. This was Kathy Lussier's
request.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Join subqueries as OR'd groups in QueryParser

This makes filter_group_entry(1,2,3) build an OR'd set of the resulting
queries instead of just tacking them onto each other as ANDs.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

Expose ability to use filter groups in TPac

Via config options for basic and advanced search.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

Stage 2: Staff Client

Robustify the oils protocol:

1 - In the event of a problem URL, abort with about:blank.

This prevents a segfault!

2 - In the event of the TPac, or KPac, wrap the channel we return.

The wrapper helps with redirects, but if applied to XMLHttpRequests will
cause full breakage.

Without the wrapper redirects end up setting URLs to https://host/...

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

Stage 1: Perl

Attempt to ensure that we always write to oils://remote when needed.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

Trying to update patron CSS color fails here, so don't try

After modifying user standing penalties ("messages" in the staff client
patron interface), you could get this error message in an alert() dialog:
 TypeError: patron.display is undefined.

We were apparently trying to use patron.util.set_patron_css() wrongly,
so the commented out changed verison of the call got farther, but stopped at
 ...penalties[i].standing_penalty().name is not a function.

Which probably has something to do with unfleshed data. Somebody can
get to the bottom of this if they want, but for now it's easier just not
to try to do this and make the alert() dialog go away.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Check for filled hold on transit checkin

"Fill related hold" can grab a hold out from under a transit, so check for
filled holds in addition to canceled ones.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

SuperCat fixes - Child Init

Sometimes it seems that child_init has not run properly for supercat.

This attempts to fix that by checking for the global appsession objects. If
they are not there we run child_init. The function that does this is being
called from all handler entry functions.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Trying to update patron CSS color fails here, so don't try

After modifying user standing penalties ("messages" in the staff client
patron interface), you could get this error message in an alert() dialog:
 TypeError: patron.display is undefined.

We were apparently trying to use patron.util.set_patron_css() wrongly,
so the commented out changed verison of the call got farther, but stopped at
 ...penalties[i].standing_penalty().name is not a function.

Which probably has something to do with unfleshed data. Somebody can
get to the bottom of this if they want, but for now it's easier just not
to try to do this and make the alert() dialog go away.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Check for filled hold on transit checkin

"Fill related hold" can grab a hold out from under a transit, so check for
filled holds in addition to canceled ones.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

SuperCat fixes - Child Init

Sometimes it seems that child_init has not run properly for supercat.

This attempts to fix that by checking for the global appsession objects. If
they are not there we run child_init. The function that does this is being
called from all handler entry functions.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Silence warnings in search results for holdable copies

Have not yet determined the exact reason the holdable copies size is not
defined in some instances in the search results only, but this commit
prevents warnings from being spewed by apache about undefined variables.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

TPAC: Silence two uninit variable warnings

These warnings were being thrown on every TPAC page request, slowly
filling the logs:

Use of uninitialized value $set_locale in string eq at
/usr/local/share/perl/5.10.1/OpenILS/WWW/EGWeb.pm line 159.

Use of uninitialized value in pattern match (m//) at
/usr/local/share/perl/5.10.1/OpenILS/WWW/EGCatLoader.pm line 250.

Banish them.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

TPAC: Give login boxes a border

For some reason, the boxes for the login form were stripped of
their default border style. Let the natural input box formatting for the
border shine through and give users an easier target when logging in.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

TPAC - Fix footer on hold history page

The hold history page was missing an ending div tag to complete the
block which leads to the footer being generated incorrectly on that
page.

Adding the ending tag repairs the display of the footer to match all
the other pages.

Credit to Melissa Lefebvre for noticing this discrepancy.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

Change grammar for lost and missing failure messages

Update to the lost and missing failure wording to make it
gramatically correct. Removed the word "has" from both
messages.

Signed-off-by: Melissa Lefebvre <mlefebvre@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

TPAC: Remove noise, misleading text from myopac/holds/circs/circ_history

There are many "class='hide_me'" elements that will never be displayed
and which are currently just extra bits to ship over the wire. Same for
the inline comments.

Also move most of the inline styles out to the stylesheet.

Also remove the explicit widths on the table cells; if the font size
changes or the translated text is wider than the table cells, then the
display will become comical.

Also remove explicit tags from localized strings; given the
likelihood that font sizes and column widths will change, tags
inside localized strings make very little sense.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Conflicts:
Open-ILS/src/templates/opac/css/style.css.tt2

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Merge branch 'rel_2_3' of git.evergreen-ils.org:Evergreen into rel_2_3_mergery

Conflicts:
Open-ILS/src/templates/opac/parts/advanced/search.tt2
Open-ILS/src/templates/opac/parts/org_selector.tt2

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Physical Location Fixes/Enhancements

Teach the physical location retrieval function about using an ENV var.

This allows a subdomain to force a specific physical location, say by adding
to their apache config:

SetEnv physical_loc 4

Rewriterules could also be used for more dynamic configuration.

Also, as a fix:

Have preferred library use the stored physical location instead of assuming
that CGI has the setting all the time.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Apply refworks placement fix to Conifer skin

Signed-off-by: Dan Scott <dscott@laurentian.ca>

TPAC: Move "Export to RefWorks" into utility area

When the RefWorks functionality was being added to TPAC, the design and
layout were very much in flux. Now that the layout has been established
with utilities like "Place Hold" on the right hand side, move the
"Export to RefWorks" button into the same location.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

TPAC: Hide inline call number in detailed results

There's no need to show the inline call number in the detailed results
view; it's redundant.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

TPAC: Display the ISSN in search results

Also, do not display URIs from the bib if we have OpenURL results.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

TPAC - fix pickup locations for edit holds

When a patron goes to edit a hold in TPAC, they have the option to
choose a different pickup location. Unfortunately, it looks like that
dropdown does not prevent them from selecting locations that aren't
normally allowed for pickups, such as system groups or consortium
itself.

This patch adds a check for 'can_have_vols_only' to the edit holds
screen.

Credit to Melissa Lefebvre for finally nailing down the source of
the issue.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Avoid top-level copy counts in TPAC

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Default to current fiscal year in ACQ order upload

* Adds a new API call to determine the current fiscal year for a given
org unit: open-ils.acq.org_unit.current_fiscal_year

* Use open-ils.acq.org_unit.current_fiscal_year to populate the correct
fiscal year in the ACQ order upload selector.

This addresses part 2 of LP 1031927

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Enable pcrud access to fiscal year / fiscal calendar

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Fiscal year selector in ACQ order record upload

* Support a 'fiscal_year' parameter to ACQ order record upload API.
* Adds a new "Fiscal Year" selector to the upload form to facilitate
uploading orders to different fiscal years.

This partially resolves LP 1031927 by allowing manual selection of the
correct fiscal year.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

TPAC: More "show details" entry points (result table)

This extends the 'show_more_details.default' setting to the table.tt2
template, which falls through the cracks otherwise.

Signed-off-by: Art Rhyno <art632000@yahoo.ca>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

Fix logic for show details by default

If the CGI param was set, then the hidden input field was not created -
meaning that the next search would fail to show the details. Switching
the logic around sorts that out nicely.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Change "Reset form" to "Clear Form"

As suggested by Thomas Berezansky in the comments on LP 994058, change
the button from "Reset form" to "Clear form" to be absolutely clear
that the button now removes all previous search variables.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

TPAC: Reset Form and New Search should clear queries

Currently, clicking "Another Search" in the search results page, or
"Reset Form" on the advanced search page, keeps the same query terms and
type around. Clear these parameters as expected; essentially, we keep
only the search location (loc or locg) in scope.

Note that we explicitly keep parameters around when someone is going
from a basic search to an advanced search, because the assumption is
that they want to refine their search further.

Also affected are the org_selector, because we want to pull the logic
for loc or locg out into a common area (the get_library block in
misc_util.tt2), and the style (input.opac-button elements now get styled
the same as a.opac-button elements, which makes it easier to intermingle
them on the same form).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>

TPAC: Process loc/locg inside build_org_selector

As show_loc_groups only gets passed to build_org_selector as a
parameter, get_library didn't have a chance to properly check for that
value and therefore was generating loc instead of locg as a CGI param.
The problem was noted by Ben Shum in IRC.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

TPAC: Make call number browse record links retain search lib

In addition to maintaining scope for the call number browse search
results, we also need to maintain the scope for the links for the call
number records in the results themselves (for example, the "retrieve
this record" link, or the "search for this author" link).

Signed-off-by: Dan Scott <dscott@laurentian.ca>

TPAC: Centralize font size definitions

The TPAC CSS had a mix of absolute and proportional font size
definitions, making it impossible to define a single base size and have
the layout adjust appropriately, as well as making it difficult to tweak
sizes to, say, eliminate the distinction between 11px and 12px text.

Accordingly, create a separate TT2 file to define standard font sizes,
define one base font size, and then use proportional percentage-based
size definitions for a set of standard font sizes. This way, a site
could easily adjust the base font size to 15px and the rest of the
layout should automatically adjust, and/or revert to using absolute font
sizes for different categories if they prefer.

Note that I did simplify some of the categories of font sizes, as the
distinction between 111% and 110% was probably not evident to most
humans at most font sizes, and even the distinction between 120% and
125% would be 14.4px vs. 15px given a base size of 12px - which
different user agents could render differently anyway.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

TPAC: Make "Show more details" in results optional

Academic sites typically handle a lot of electronic content and want to
bring most details about entries, such as availability, status, and
URLs, on a results screen to the front.

This adds a 'show_more_details.default' option in 'config.tt2' that can
have the values 'true', 'false' and 'hide'. The 'true' and 'false'
values set the default for the button to more and less respectively, and
'hide' suppresses the button from showing at all.

Signed-off-by: Art Rhyno <art632000@yahoo.ca>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

TPAC - add library scoping to shelf browser

The shelf browser currently uses the 'loc' variable to define scoping and
limit browsing to specific org units. However, since much of the scoping
actually uses 'locg', the scoping was broken for the shelf browser.

Additionally, under Advanced Search's Numeric Search, the option for
'Call Number (Shelf Browse)' only applies the 'cn' variable to searches
and never adds the search scope, despite the search library now being
an available filter choice.

Based on suggestion by Dan Scott in IRC, this patch uses the function for
_get_search_lib() to retrieve the search library and add it to both parts
of the shelf browser.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

TPAC: AutoSuggest throws a JS error on login form

searchbar.tt2 includes a reference to the AutoSuggest widget that
results in an error if the dojo code has not been required, which is
par for the course. However, on the login form we disabled the
AutoSuggest inline code because we didn't want it to override the
autofocus for the login user name; unfortunately, the searchbar exists
on the login form, and a JS error is thrown. On most browsers, not a
problem, but on IE it throws up a nasty dialog if you have the
right/wrong settings.

The simplest way to resolve this is to not set autofocus if we're not on
the basic_search page, but keep the rest of the AutoSuggest code
around.

In addition, we can avoid some other undefined var warnings by stepping
carefully through the search for the dijit value.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

TPAC - add library scoping to shelf browser

The shelf browser currently uses the 'loc' variable to define scoping and
limit browsing to specific org units. However, since much of the scoping
actually uses 'locg', the scoping was broken for the shelf browser.

Additionally, under Advanced Search's Numeric Search, the option for
'Call Number (Shelf Browse)' only applies the 'cn' variable to searches
and never adds the search scope, despite the search library now being
an available filter choice.

Based on suggestion by Dan Scott in IRC, this patch uses the function for
_get_search_lib() to retrieve the search library and add it to both parts
of the shelf browser.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

TPAC: Give login boxes a border

For some reason, the boxes for the login form were stripped of
their default border style. Let the natural input box formatting for the
border shine through and give users an easier target when logging in.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Make opac/results.tt2 remember facet when sorting, etc.

Add a hidden field in the search form and set its value to the value
of the CGI 'facet' param if the facet parameter is set. This appears
to work for multiple facets. Clearing a facet is as simple as clicking
on the gray-backgounded facet name.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

TPAC - fix alignment of "You are now browsing..." in shelf browser

The "You are now browsing..." message does not align to the center of the
page. Changing the <div> to a seems to properly align the text.

Along the way, we should remove the extra and (the strong
is redundant with the css being inherited by color_4 class) and make the
new single line message more i18n-friendly for future translations.

Credit to Michael Peters for noticing the problem and thanks to Dan Scott,
Lebbeous Fogle-Weekley, and Thomas Berezansky for help via IRC for the
i18n-bits.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

Fix TPAC shelf browser's previous link

Line fix suggested by Thomas Berezansky.

The cnoffset was strictly checking for values that start with a digit.
But negative numbers start with a "-" instead. Once this check was
changed, the previous link will continue to move further into negative
offsets.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

Documentation: Fix some issues which caused a2x epub processing to choke.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>

Documentation: add a missing image.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>

Documentation: remove line break characters from file.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>

Documentation: Add kids catalog documentation from ESI site.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>

Authorities: Fix broken UI due to new XUL/Dojo/regressions

New versions of XUL, since Firefox 10, hate dojo.query("foo bar"), so we
have to refactor it to use dojo.query("foo").query("bar") instead. At
least until we upgrade to a new version of Dojo.

In addition, 522d8d82 introduced a regression meaning that the text of
the authorities was no longer wrapped in a SPAN element with a class of
"text". That in turn meant that the Dojo queries weren't picking up the
labels for the merge box, leaving no visual indication to the user as to
what authorities exactly were being merged. So, repair that.

Also, similar to a fix for the MFHD editor, set the initial height of
the spawned MARC Editor for an authority record to something reasonable.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Set a sane initial MFHD Editor size

For most MFHD records, the size of the MARC Editor window when spawned
fits into the confines of a normal desktop. However, for MFHD records
with dozens or more rows, the window chrome can be inaccessible because
it is bumped off the top of the Windows desktop. This makes it
impossible for users to close the window without a workaround like
hitting ALT+F4

This branch sets the window to an initial height of 40 pixels less than
the height of the entire staff client window. This should be enough to
enable the chrome on top to be visible. In addition, we have to set the
width to something reasonable because XUL seems to otherwise set the
window to be extremely skinny once an explicit height is set, so we set
that to be half the width of the staff client window.

Finally, we allow the new window to be resizable according to the user's
preference.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Simplified Hold Pull List: Fix several sorting bugs

First of all, sorting on most columns was broken due to a bug in the way
that the flattener methods of the open-ils.fielder service were
constructing their SQL JOINs. We were coming up with way too many
joins, and then losing track of which JOIN's alias to refer to when
building the ORDER BY clause later. This is fixed.

Secondly, the shelving location column now sorts automatically by the
shelving location *ordering* values, when avaiable. These are the
values that you set up in the drag-and-drop staff client interface
titled "Copy Location Order." When these values are not set for the org
unit whose pull list you're viewing, the sorting will fall back to
alphabetical.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Authorities: Fix broken UI due to new XUL/Dojo/regressions

New versions of XUL, since Firefox 10, hate dojo.query("foo bar"), so we
have to refactor it to use dojo.query("foo").query("bar") instead. At
least until we upgrade to a new version of Dojo.

In addition, 522d8d82 introduced a regression meaning that the text of
the authorities was no longer wrapped in a SPAN element with a class of
"text". That in turn meant that the Dojo queries weren't picking up the
labels for the merge box, leaving no visual indication to the user as to
what authorities exactly were being merged. So, repair that.

Also, similar to a fix for the MFHD editor, set the initial height of
the spawned MARC Editor for an authority record to something reasonable.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Set a sane initial MFHD Editor size

For most MFHD records, the size of the MARC Editor window when spawned
fits into the confines of a normal desktop. However, for MFHD records
with dozens or more rows, the window chrome can be inaccessible because
it is bumped off the top of the Windows desktop. This makes it
impossible for users to close the window without a workaround like
hitting ALT+F4

This branch sets the window to an initial height of 40 pixels less than
the height of the entire staff client window. This should be enough to
enable the chrome on top to be visible. In addition, we have to set the
width to something reasonable because XUL seems to otherwise set the
window to be extremely skinny once an explicit height is set, so we set
that to be half the width of the staff client window.

Finally, we allow the new window to be resizable according to the user's
preference.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Documentation: Update upgrade instruction to 2.3.beta1 and include all docs that were in 2.2.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>

One more fix for the org_selector

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Fix

Signed-off-by: Dan Scott <dscott@laurentian.ca>

TPAC: Reset Form and New Search should clear queries

Currently, clicking "Another Search" in the search results page, or
"Reset Form" on the advanced search page, keeps the same query terms and
type around. Clear these parameters as expected; essentially, we keep
only the search location (loc or locg) in scope.

Note that we explicitly keep parameters around when someone is going
from a basic search to an advanced search, because the assumption is
that they want to refine their search further.

Also affected are the org_selector, because we want to pull the logic
for loc or locg out into a common area (the get_library block in
misc_util.tt2), and the style (input.opac-button elements now get styled
the same as a.opac-button elements, which makes it easier to intermingle
them on the same form).

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Add an API for generating barcodes

Add a custom API to open-ils.actor for generating barcodes; accepts one
argument, user ID, which gets the barcode set to their new value. If no
arg is passed, just generates a new barcode and returns it (should be
useful on the patron editor screen).

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Documentation: Remove a space causing an error during PDF processing.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>

Hide OPAC-invisible holdings from SRU/Z39.50

The basic_holdings Supercat method filtered out deleted call numbers and
copies, but didn't filter out copies based on the OPAC visibility status
of copy location / status / the copy itself. This has undesired results
when third-party services request copies via SRU or Z39.50 and expose
copies that should not be visible to the public.

We wrap all of the visibility and deletedness checks for a given copy up
into a subroutine so that we can avoid repeating ourselves in the
basic_holdings logic. Also, if we missed a test, we can add it in one
handy place :)

(Thanks to Galen Charlton for finding two missing tests: circ lib
visibility and owning lib visibility!)

Signed-off-by: Dan Scott <dscott@laurentian.ca>

TPAC: Remove explicit width on "View my list" button

.cached_list_div, which defines the style for the "View my list" button
on the TPAC button bar once an item has been added to a temporary list,
is given an explicit width of 111px, which is problematic for a number
of reasons:

1. If the font-size of the base style is increased, then the text will
 likely wrap.
2. Translations tend to be longer than English, and indeed in fr-CA
 "Afficher ma liste" ends up wrapping onto a second line, which makes
 the button bar look weird.

Accordingly, remove the explicit "width:111px" from the style definition
for .cached_list_div.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>

Generic login help that leads to example.com is no use

We'll override the generic login help that leads to example.com with a
blank page, and let sites override that with their own help if they so
desire.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Allow some buttons in Import via Z39.50 to wrap lines

Some of our technicians with 4:3 ratio monitors and a reasonable
font-size are unable to see the "Import Record" button on the Import via
Z39.50 screen, because the buttons in that row are laid out in a single,
non-wrapping row, and there is no affordance for scrolling over to the
side.

Simply changing the containing "hbox" element to a "description" element
allows enough of the buttons to overflow to resolve the problem in our
experience.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Merge branch 'rel_2_3' of git.evergreen-ils.org:Evergreen into rel_2_3_mergery

Remove extra xulG redefines

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

Merge branch 'rel_2_3' of git.evergreen-ils.org:Evergreen into rel_2_3_mergery

Fix timestamp typo

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

Redirect to OILS in staff client

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

TPAC: Remove explicit width on "View my list" button

.cached_list_div, which defines the style for the "View my list" button
on the TPAC button bar once an item has been added to a temporary list,
is given an explicit width of 111px, which is problematic for a number
of reasons:

1. If the font-size of the base style is increased, then the text will
 likely wrap.
2. Translations tend to be longer than English, and indeed in fr-CA
 "Afficher ma liste" ends up wrapping onto a second line, which makes
 the button bar look weird.

Accordingly, remove the explicit "width:111px" from the style definition
for .cached_list_div.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Silence warnings in search results for holdable copies

Have not yet determined the exact reason the holdable copies size is not
defined in some instances in the search results only, but this commit
prevents warnings from being spewed by apache about undefined variables.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

TPAC: Silence two uninit variable warnings

These warnings were being thrown on every TPAC page request, slowly
filling the logs:

Use of uninitialized value $set_locale in string eq at
/usr/local/share/perl/5.10.1/OpenILS/WWW/EGWeb.pm line 159.

Use of uninitialized value in pattern match (m//) at
/usr/local/share/perl/5.10.1/OpenILS/WWW/EGCatLoader.pm line 250.

Banish them.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

TPAC locale picker: use POST instead of GET

Users could (deliberately or not) change another's language
preferences by sharing links with the "set_eg_locale" GET param given
the locale picker's current behaviour. By switching to a POST param, we
prevent this result from accidentally occurring.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

TPAC: Add the ability to set a different default locale

Installations with multiple sites might desire different default locales
for their skins. This adds the Apache config directive
"OILSWebDefaultLocale", which enables you to set the default locale on a
global and a per-skin basis.

Note that this prevents the browser Accept-language header from having
any effect; sadly that header is not often used in real life.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Merge branch 'master' of git.evergreen-ils.org:Evergreen into rel_2_3_mergery

Add dependencies for Fedora

Noted by Net Wolf on the mailing list, some core dependencies were
missing from the Fedora Makefile.install installer. As some of them have
recently been packaged for Fedora 17, add them to the package
collection; others are still unpackaged, so leave them there.

Note: the packages are not available on Fedora 16, but that has a
limited remaining shelf life anyway, so consider this a shift to
supporting only the latest stable version of Fedora.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Import updated translations from Launchpad; stage 2

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Import updated translations from Launchpad; stage 1

Signed-off-by: Bill Erickson <berick@esilibrary.com>