Kyle Huckins [Thu, 12 Dec 2019 22:49:28 +0000 (22:49 +0000)]
OPAC Circ Modifier Adjustments
- Improve visuals when logged in as administrator.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/templates/opac/parts/record/copy_table.tt2
Kyle Huckins [Thu, 12 Dec 2019 21:57:34 +0000 (21:57 +0000)]
View Course Information on the Item Record
- Users with the MANAGE_RESERVES permission who are opted
into the course module can view a new Course Info tab on
the item record.
- Course Info tab displays a list of all courses(with link
to the Admin Course Page) item is associated with, and a
list of all instructors associated with those courses.
- Improvements to open-ils.circ.course_users.retrieve.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/perlmods/lib/OpenILS/Application/Circ.pm
new file: Open-ILS/src/templates/staff/cat/item/t_course_pane.tt2
modified: Open-ILS/src/templates/staff/cat/item/t_view.tt2
modified: Open-ILS/web/js/ui/default/staff/cat/item/app.js
Kyle Huckins [Thu, 12 Dec 2019 20:55:38 +0000 (20:55 +0000)]
Reinstate fm-editor in Course List
- Undo removal of fm-editor in Course List
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-list.component.html
Kyle Huckins [Wed, 11 Dec 2019 22:22:47 +0000 (22:22 +0000)]
IDL Typo & Label Changes
- Set datatype of is_public on Course User to 'bool' from 'boolean'
- Relabel is_public on Course User to "OPAC Viewable?"
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/examples/fm_IDL.xml
Kyle Huckins [Tue, 10 Dec 2019 22:09:49 +0000 (22:09 +0000)]
Angular Course Page Improvements
- Condense Course User functionality into its own component,
usable as a dialog and inline.
- Condense Course Material functionality into its own component,
usable as a dialog and inline.
- Add Return to Course List button
- Move Archive Course button above tabs
- Allow Editing of Course Users and Materials
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-associate-material.component.html
copied: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-page.component.ts -> Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-associate-material.component.ts
modified: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-associate-users.component.html
modified: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-associate-users.component.ts
modified: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-list.component.html
modified: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-list.component.ts
modified: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-page.component.html
modified: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-page.component.ts
modified: Open-ILS/src/eg2/src/app/staff/share/course.service.ts
Kyle Huckins [Tue, 10 Dec 2019 19:03:17 +0000 (19:03 +0000)]
Angular Course Page Associate Users Tab
- Apply Course Users functionality to Angular Course Page
Admin UI.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-page.component.html
modified: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-page.component.ts
modified: Open-ILS/src/eg2/src/app/staff/share/course.service.ts
Zavier Banks [Mon, 9 Dec 2019 16:52:39 +0000 (16:52 +0000)]
LP1849212 Associtate and Disassociate Course With Instructors
Creating a component that associates and disassociates instructors with
courses using the course list.
Signed-off-by: Zavier Banks <zbanks@catalyte.io>
Kyle Huckins [Mon, 9 Dec 2019 18:53:03 +0000 (18:53 +0000)]
OPAC course material circulation modifier
- View Circulation Modifier column on Course Materials
while in OPAC record view.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Record.pm
modified: Open-ILS/src/templates/opac/parts/record/copy_table.tt2
Kyle Huckins [Sun, 8 Dec 2019 05:16:32 +0000 (05:16 +0000)]
Whitespace Tweaks
- Remove excess whitespace on OPAC course page.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/templates/opac/parts/course/body.tt2
Kyle Huckins [Sun, 8 Dec 2019 05:15:03 +0000 (05:15 +0000)]
Admin Course Page Preparation for Course Users
- Add a new tab for managing Users associated with
the course, in preparation for the User Dialog code.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-page.component.html
modified: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-page.component.ts
Kyle Huckins [Sun, 8 Dec 2019 04:37:47 +0000 (04:37 +0000)]
Associate Materials Updates
- Ensure Shelving Location input checkbox
ticks when selecting a value.
- Ensure temporary value inputs are not
cleared when entering a new item.
- Fully select contents of Barcode input
field when selected.
- Clear bBarcode input upon hitting enter.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-associate-material.component.html
modified: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-associate-material.component.ts
Kyle Huckins [Sun, 8 Dec 2019 00:07:26 +0000 (00:07 +0000)]
Course Page
- Perl Module and Course Page displaying name and course
number of course, as well as names/roles of publicly viewable
members, course details, and a table of all materials associated
with the course.
- URL listed as eg/opac/course/[COURSE_ID]
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/perlmods/lib/OpenILS/Application/Circ.pm
modified: Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader.pm
new file: Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Course.pm
new file: Open-ILS/src/templates/opac/course.tt2
modified: Open-ILS/src/templates/opac/css/style.css.tt2
new file: Open-ILS/src/templates/opac/parts/course/body.tt2
Kyle Huckins [Sun, 8 Dec 2019 00:03:33 +0000 (00:03 +0000)]
IDL Tweaks for Course Users
- Fixed typo for User Role field, now matcheing DB column, usr_role
- Added boolean "is_public" to differentiate between a role that
should be viewable by anyone on the OPAC.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/examples/fm_IDL.xml
Kyle Huckins [Sat, 7 Dec 2019 07:39:24 +0000 (07:39 +0000)]
OPAC Search Result Course Information
- Provide Associated Course names and numbers on
OPAC Catalog search results.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/perlmods/lib/OpenILS/Application/Circ.pm
modified: Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Record.pm
modified: Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Search.pm
modified: Open-ILS/src/templates/opac/parts/result/table.tt2
Kyle Huckins [Sat, 7 Dec 2019 07:37:23 +0000 (07:37 +0000)]
Course Materials Record Column
- Add a record column to course_module_course_materials
to improve efficiency of API and service methods.
- Add previous circ_modifier adjustments to upgrade script
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/examples/fm_IDL.xml
modified: Open-ILS/src/eg2/src/app/staff/share/course.service.ts
modified: Open-ILS/src/sql/Pg/040.schema.asset.sql
modified: Open-ILS/src/sql/Pg/upgrade/XXXX.schema.course-materials-module.sql
Kyle Huckins [Fri, 6 Dec 2019 23:12:25 +0000 (23:12 +0000)]
OPAC Catalog Result Course Column
- Implement Course column to view Course Numbers of classes associated
with individual copies.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/perlmods/lib/OpenILS/Application/Circ.pm
modified: Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Record.pm
modified: Open-ILS/src/templates/opac/parts/record/copy_table.tt2
Kyle Huckins [Fri, 6 Dec 2019 19:18:19 +0000 (19:18 +0000)]
Course Page Tab Bugfix
- Remove unnecessary artifact from course page html
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-page.component.html
Kyle Huckins [Fri, 6 Dec 2019 09:09:16 +0000 (09:09 +0000)]
Course Material Course-Item Constraint
- Prevent users from associating duplicate items to a
course.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/sql/Pg/040.schema.asset.sql
modified: Open-ILS/src/sql/Pg/upgrade/XXXX.schema.course-materials-module.sql
Kyle Huckins [Fri, 6 Dec 2019 08:30:04 +0000 (08:30 +0000)]
Angular Catalog Course Links Course Page Integration
- Change links in Angular Catalog to navigate the user to the
Admin Course Page.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/eg2/src/app/staff/catalog/record/copies.component.html
modified: Open-ILS/src/eg2/src/app/staff/catalog/result/record.component.html
modified: Open-ILS/src/eg2/src/app/staff/catalog/result/record.component.ts
modified: Open-ILS/src/eg2/src/app/staff/share/bib-summary/bib-summary.component.html
Kyle Huckins [Fri, 6 Dec 2019 07:52:31 +0000 (07:52 +0000)]
Course Page Improvements
- Improve UX of Course Page
- Properly disable inputs and buttons when course
is already archived.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-page.component.html
modified: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-page.component.ts
Kyle Huckins [Fri, 6 Dec 2019 07:51:16 +0000 (07:51 +0000)]
Staff Banner Additions
- Add bannerStyle and bannerIcon parameters to
eg-staff-banner to improve eg-staff-banner
accessability
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/eg2/src/app/staff/share/staff-banner.component.ts
Kyle Huckins [Fri, 6 Dec 2019 07:17:53 +0000 (07:17 +0000)]
Course Admin Page
- Double-clicking on a course in the Course Reserves List will
up a dedicated admin page for an individual course, featuring
tabs for Editing and managing Course Materials.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-list.component.html
modified: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-list.component.ts
new file: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-page.component.html
new file: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-page.component.ts
modified: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-reserves.module.ts
modified: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/routing.module.ts
modified: Open-ILS/src/eg2/src/app/staff/share/course.service.ts
Kyle Huckins [Thu, 5 Dec 2019 17:37:46 +0000 (17:37 +0000)]
lp1849212 Associate Item from Service
- Move bulk of Associate Item funcitonality into Course Service
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-associate-material.component.ts
modified: Open-ILS/src/eg2/src/app/staff/share/course.service.ts
Kyle Huckins [Thu, 5 Dec 2019 19:17:27 +0000 (19:17 +0000)]
lp1849212 Display Associated Courses on Search Results
- Display associated courses on Search Results UI
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/eg2/src/app/staff/catalog/result/record.component.html
modified: Open-ILS/src/eg2/src/app/staff/catalog/result/record.component.ts
Kyle Huckins [Mon, 25 Nov 2019 22:06:04 +0000 (22:06 +0000)]
lp1849212 Angular Catalog Show Link to Course
- Add a column retrieving the names of courses linked to materials
when opted into the Course Reserves functionality.
- Expand the bib record summary when opted in to display all courses
associated with an item.
Changes to be committed:
modified: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-reserves.module.ts
modified: Open-ILS/src/eg2/src/app/staff/catalog/record/copies.component.html
modified: Open-ILS/src/eg2/src/app/staff/catalog/record/copies.component.ts
modified: Open-ILS/src/eg2/src/app/staff/common.module.ts
modified: Open-ILS/src/eg2/src/app/staff/share/bib-summary/bib-summary.component.html
modified: Open-ILS/src/eg2/src/app/staff/share/bib-summary/bib-summary.component.ts
modified: Open-ILS/src/eg2/src/app/staff/share/course.service.ts
Kyle Huckins [Mon, 25 Nov 2019 20:46:53 +0000 (20:46 +0000)]
lp1849212 - Move Course Service to staff/share directory
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-associate-material.component.ts
modified: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-list.component.ts
modified: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-reserves.module.ts
renamed: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course.service.ts -> Open-ILS/src/eg2/src/app/staff/share/course.service.ts
Kyle Huckins [Mon, 25 Nov 2019 18:46:59 +0000 (18:46 +0000)]
lp1849212 Move Course Reserves to Local Admin
- Move the Course Reserves admin UI to Local Admin
instead of Server Admin
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
modified: Open-ILS/src/eg2/src/app/staff/admin/local/admin-local-splash.component.html
renamed: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/course-associate-material.component.html -> Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-associate-material.component.html
renamed: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/course-associate-material.component.ts -> Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-associate-material.component.ts
renamed: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/course-list.component.html -> Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-list.component.html
renamed: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/course-list.component.ts -> Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-list.component.ts
renamed: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/course-reserves.module.ts -> Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-reserves.module.ts
renamed: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/course.service.ts -> Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course.service.ts
renamed: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/routing.module.ts -> Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/routing.module.ts
modified: Open-ILS/src/eg2/src/app/staff/admin/local/routing.module.ts
modified: Open-ILS/src/eg2/src/app/staff/admin/server/admin-server-splash.component.html
modified: Open-ILS/src/eg2/src/app/staff/admin/server/routing.module.ts
Jane Sandberg [Thu, 5 Dec 2019 20:51:34 +0000 (12:51 -0800)]
Fix installation issue with circ mod foreign key
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Kyle Huckins [Wed, 20 Nov 2019 22:30:06 +0000 (22:30 +0000)]
Archive Courses
- Implement functionality to archive a course via the
admin course reserves list UI.
- Disassociate all items from a course and reinstate
their original fields if temporary fields were applied,
upon course archival.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/examples/fm_IDL.xml
modified: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/course-list.component.html
modified: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/course-list.component.ts
modified: Open-ILS/src/sql/Pg/040.schema.asset.sql
modified: Open-ILS/src/sql/Pg/upgrade/XXXX.schema.course-materials-module.sql
Kyle Huckins [Wed, 20 Nov 2019 21:41:59 +0000 (21:41 +0000)]
Disassociate when Deleting a Course.
- Move disassociation code into Course Service.
- Automatically disassociate items and return them
to their original state when deleting a course.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/course-associate-material.component.ts
modified: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/course-list.component.ts
modified: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/course-reserves.module.ts
new file: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/course.service.ts
modified: Open-ILS/src/sql/Pg/040.schema.asset.sql
Kyle Huckins [Tue, 19 Nov 2019 21:18:44 +0000 (21:18 +0000)]
Temporary Fields upon Association/Disassociation
- Optionally apply temporary Call Number, Circ Modifier, Item
Status, and Shelving Location when associating an item with a
course.
- Reapply original values of the above-mentioned fields when
disassociating an item from a course.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/examples/fm_IDL.xml
modified: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/course-associate-material.component.html
modified: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/course-associate-material.component.ts
modified: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/course-reserves.module.ts
modified: Open-ILS/src/sql/Pg/upgrade/XXXX.schema.course-materials-module.sql
Kyle Huckins [Wed, 13 Nov 2019 18:23:08 +0000 (18:23 +0000)]
View Course Materials Dialog
- Implement dialog to view course materials associated with
a particular course in the course list admin UI.
- Implement actions to associate and disassociate materials with
a specific course.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
new file: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/course-associate-material.component.html
new file: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/course-associate-material.component.ts
modified: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/course-list.component.html
modified: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/course-list.component.ts
modified: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/course-reserves.module.ts
Kyle Huckins [Thu, 7 Nov 2019 18:38:04 +0000 (18:38 +0000)]
Tidying Up Grid
- Remove RowFlair and ClassCallback from Course Reserves
Grid.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/course-list.component.html
modified: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/course-list.component.ts
Kyle Huckins [Mon, 4 Nov 2019 18:05:08 +0000 (18:05 +0000)]
lp1849212 IDL Typo
- Change instances of non-cat-course_materials to non_cat_course_materials
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/examples/fm_IDL.xml
Bill Erickson [Wed, 6 Nov 2019 17:41:32 +0000 (12:41 -0500)]
LP1850555 Angular Item (Copy) Location Select Component
<eg-item-location-select .../>
Adds a new item location select component which filters the list of
displayed locations based on a permission-check org or a specific
context org unit.
Values in the selector are decorated with the org unit short name in
parens after the location name to clarify the owning lib.
Sandbox example included.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Zavier Banks [Thu, 24 Oct 2019 22:08:24 +0000 (22:08 +0000)]
LP#
1849212 Create, Edit and Delete Functionality
Added the create, edit, and delete functionality.
Signed-off-by: Zavier Banks <zbanks@catalyte.io>
Zavier Banks [Thu, 24 Oct 2019 18:26:40 +0000 (18:26 +0000)]
LP#
1849212 Course List Ui
Added a grid component that displays the available data, specified
by the class, while also modifying the routing, so the admin splash
page links to the created component.
Signed-off-by: Zavier Banks <zbanks@catalyte.io>
Kyle Huckins [Mon, 21 Oct 2019 20:32:39 +0000 (20:32 +0000)]
Course Modules - Opt-in YAOUS
- YAOUS introduced to allow opting into the Course Materials
module functionality.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/sql/Pg/950.data.seed-values.sql
modified: Open-ILS/src/sql/Pg/upgrade/XXXX.schema.course-materials-module.sql
Kyle Huckins [Mon, 21 Oct 2019 19:55:38 +0000 (19:55 +0000)]
Course Modules - Course Materials Asset
- Create IDL Class & Table for Course Materials
- Create IDL Class & Table for Non-Cataloged Course Materials
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/examples/fm_IDL.xml
modified: Open-ILS/src/sql/Pg/040.schema.asset.sql
modified: Open-ILS/src/sql/Pg/upgrade/XXXX.schema.course-materials-module.sql
Kyle Huckins [Fri, 18 Oct 2019 21:43:31 +0000 (21:43 +0000)]
Course Materials Module - Course Members
- Add IDL Class and asset table to map actor.usr and
asset.course_module_course, along with an optional
string value for the user's role in the course. If
desired, this can later be fleshed out into a separate
course role table.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/examples/fm_IDL.xml
modified: Open-ILS/src/sql/Pg/040.schema.asset.sql
modified: Open-ILS/src/sql/Pg/upgrade/XXXX.schema.course-materials-module.sql
Kyle Huckins [Fri, 18 Oct 2019 20:22:02 +0000 (20:22 +0000)]
Course Materials Module - Course IDL object & table
- Create IDL Object for Courses.
- Create table within asset schema for Courses, containing an id,
a name, a course number, a section number, and an owning library.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/examples/fm_IDL.xml
modified: Open-ILS/src/sql/Pg/040.schema.asset.sql
renamed: Open-ILS/src/sql/Pg/upgrade/XXXX.data.manage-reserves-permission.sql -> Open-ILS/src/sql/Pg/upgrade/XXXX.schema.course-materials-module.sql
Kyle Huckins [Fri, 18 Oct 2019 18:05:57 +0000 (18:05 +0000)]
Course Reserves Permission
- Create MANAGE_RESERVES permission.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/sql/Pg/950.data.seed-values.sql
new file: Open-ILS/src/sql/Pg/upgrade/XXXX.data.manage-reserves-permission.sql
Mike Rylander [Thu, 5 Dec 2019 20:12:57 +0000 (15:12 -0500)]
LP#
1855329: Hold shelf query speed problem
In bug
1827250 I suggested Jason Stephenson look at an alternate SQL
formulation to solve the original problem. He did, and deemed it faster,
so went with that. Unfortunately, on PG 9.6, we're seeing some data sets
that decide on a /very/ poor plan for the wide-hold query with the
solution as implemented, but the original suggestion from Jason works
fine.
In the face of evidence controverting my thought that giving PG more
options for planning is better in this case, this commit moves to his
original query change.
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Galen Charlton [Fri, 3 Jan 2020 16:02:29 +0000 (11:02 -0500)]
LP#
1858138: (follow-up) flesh creator and editor in sandbox's acp grid
Doing so ensures that the usrnames are displayed in the respective
grid columns rather than the au ID.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Galen Charlton [Fri, 3 Jan 2020 15:35:56 +0000 (10:35 -0500)]
LP#
1858138: remove remaining uses of showLinkSelector
Now that showLinkSelector is deprecated and does nothing,
remove current uses of it.
To test
-------
[1] Apply the patch.
[2] Visit Angular admin interfaces that have grids that
refer to linked IDL classes, e.g.,
- Local Admin -> Carousels (carousel type)
- Server Admin -> Weights Association (circ weights and hold
weights)
- Local Admin -> Item Tags (copy tag type)
- Acq Admin -> EDI Accounts (provider)
[3] Verify that the columns for linked fields display the
appropriate selector field rather than the numeric ID.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Thu, 2 Jan 2020 21:31:31 +0000 (16:31 -0500)]
LP1858138 Sandbox example of simple grid filtering
Adds a trimmed down grid example demonstrating consistent filtering and
link selector display for auto and manual fields without requiring any
additional grid markup to define basic column behevior.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Bill Erickson [Thu, 2 Jan 2020 21:28:46 +0000 (16:28 -0500)]
LP1858138 Link selector consolidation/repairs
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Bill Erickson [Thu, 2 Jan 2020 21:22:34 +0000 (16:22 -0500)]
LP1858138 Grid IDL field definition repairs and more
* Deprecate showLinkSelectors, since FormatService now performs that
logic under the covers. Includes deprecation console warning.
* Fix Grid field IDL class extraction off-by-one error. The code was
stamping the source field with the class of the field's link target
instead of the class the field actually belonged to.
* Allow for IDL field info extraction from the 'name' attribute when no
'path' attribute is defined.
* Avoid console errors when clearing combobox values in grid filters.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Bill Erickson [Thu, 2 Jan 2020 21:17:59 +0000 (16:17 -0500)]
LP1858138 Link selector consolidation/repairs
Move more of the IDL link class selector extraction logic into the IDL
service.
Avoid using 'name' as a fall-through selector field when no 'name' field
exists on the class.
Teach the idl service to log warnings on invalid class and field name
combinations in selector lookups.
Modify fm-editor and combobox to use the new idl link selector
functions.
While we're in there, avoid unnecessary API calls from the combobox
by preventing async data lookups with a search term of "_CLICK_".
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Bill Erickson [Thu, 2 Jan 2020 20:19:16 +0000 (15:19 -0500)]
LP1858138 Action/Trigger IDL selector additions
Adds selector field entries for Action/Trigger hook, collector,
validator, reactor, and cleanup classes for ease of admin page building.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Galen Charlton [Fri, 20 Dec 2019 17:55:16 +0000 (12:55 -0500)]
LP#
1857156: handle HHH:MM:SS durations in loans
This patch fixes a problem where loan durations of the form
HHH:MM:SS, where the hours component is longer than 2 digits, could
cause checkouts to fail. This sort of duration has been observed
in cases where a library wanted a long-term reserves loan that
doesn't have the due time bumped up to midnight.
To test
-------
[1] Set up a circulation policy that has a loan duration of 167:59:59.
[2] Attempt a checkout that uses that policy. Note that the checkout
will fail.
[3] Apply the patch and repeat step 2. This time, the checkout should
succeed.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Bill Erickson [Tue, 12 Nov 2019 20:13:39 +0000 (15:13 -0500)]
LP1858118 Hatch enabled check repairs
Teach code asking Hatch whether printing is enabled to properly handle
the asynchronous response of the setting which now exists as a
workstation setting instead of a localStorage setting.
Related, if Hatch is unavailable, use browser printing regardless of the
hatch printing workstation setting.
Additionally update the "reprint last" handling to store the
last_printed value in localStorage instead of attempting to save its
value as a workstation setting.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Mon, 30 Dec 2019 22:50:47 +0000 (14:50 -0800)]
Docs: Fixing asciidoc syntax so fop doesn't complain about staff client admin manual
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jane Sandberg [Mon, 30 Dec 2019 22:24:58 +0000 (14:24 -0800)]
Docs: LP1767378 follow up: adding manual anchor
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
lfloyd [Mon, 23 Dec 2019 17:53:04 +0000 (12:53 -0500)]
Docs: fixed a spacing issue
Signed-off-by: Lynn Floyd <lfloyd@library.in.gov>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
lfloyd [Mon, 23 Dec 2019 16:25:40 +0000 (11:25 -0500)]
DOCS: LP
1767378 Work Log documentation
Updated Work Log documentation with new image.
Deleted old image files, noted which holds log.
Signed-off-by: Lynn Floyd <lfloyd1@library.in.gov>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Galen Charlton [Fri, 27 Dec 2019 21:45:42 +0000 (16:45 -0500)]
LP#
1855931: (follow-up) make grid filter control cells wrap as well
This patch applies "word-wrap: normal" to filter control cells
as well, making it more likely that they will stay aligned with
the width of their corresponding header cells. This can be tested
by adding visible columns to the "Grid with filtering" table in
the Angular sandbox (/eg2/en-US/staff/sandbox) and verifying that
the column after "Circulating Library" continues to have its
filter widget stay aligned with its label.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Mike Risher [Tue, 10 Dec 2019 23:15:35 +0000 (23:15 +0000)]
lp1855931 wrap text for wide Angular eg-grid column headers
Make column headers text wrap so that you can fully read the header even if
it's several words long. This will help when there are multiple headers
that start with the same word and they show up identically.
Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Galen Charlton [Fri, 27 Dec 2019 22:50:08 +0000 (17:50 -0500)]
LP#
1857350: (follow-up) fix lint issue
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Thu, 26 Dec 2019 18:18:26 +0000 (13:18 -0500)]
LP1857350 Org selector sorts by display value
When displaying the org unit selector, sort each set of children by the
display label (defaults to shortname).
Fixes issues with the org server sortTree function and adds a unit test
to test the repaired sort function.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Mike Risher [Fri, 13 Sep 2019 21:53:42 +0000 (21:53 +0000)]
lp1843640 Standing Penalty Followup
Fix 2 issues: grid not updating when a new record is created and
double clicking a row doesn't edit it
Signed-off-by: Mike Risher <mrisher@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/eg2/src/app/staff/admin/local/standing-penalty.component.html
modified: Open-ILS/src/eg2/src/app/staff/admin/local/standing-penalty.component.ts
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Bill Erickson [Fri, 18 Oct 2019 17:47:17 +0000 (13:47 -0400)]
LP1848778 Use consistent MARC breaker delimiter
Use the '$' delimiter in the read-only MARC breaker view for
consistency with the flat text MARC editor to easy copy/paste from one
to the other.
To test
-------
[1] Apply the patch.
[2] Set up two records in a record bucket and initiate a merge. Note
that when you select a lead record and choose to edit it in
flat text mode, you can copy and paste fields from the subordinate
record display without having to change the subfield delimiter
character.
[3] Mark a record for overlay, perform a Z39.50 search, then select
a hit and choose the overlay action. Note that you can copy and
paste fields from the record to overlay when editing the incoming
record using the flat text editor.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Dan Briem [Fri, 9 Aug 2019 03:45:40 +0000 (23:45 -0400)]
LP#
1780283 Checking One Bill Checks Them All
Under Patron->Bills->History if Bill # isn't visible for the Transactions
grid or Payment ID isn't visible for Payments grid, rows can't be selected
individually. This adds the required attribute to those field directives.
1. Under a patron account with multiple bills, go to Bills->History
2. Remove Bill # from the Transactions grid
3. Try to select an individual row (note all rows are selected)
4. Apply patch and repeat steps 1-3 (note rows are selected individually)
Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Katlyn Beck [Mon, 26 Nov 2018 21:23:48 +0000 (21:23 +0000)]
lp1712644 Prevent check out due date in past
- Prevents selecting past due date when checking out an item
- Prevents saving a due date with hatch when input date is invalid
Signed-off-by: Katlyn Beck <kbeck@catalyte.io>
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Galen Charlton [Fri, 27 Dec 2019 18:21:15 +0000 (13:21 -0500)]
LP#
1857710: fix Angular client whitescreen on Firefox
Work done for LP#
1830391 added an instance of a Javascript
regexp replace using the dotAll ("/s") flag, but as of the moment
Firefox treats that flag as a fatal syntax error, breaking the
Angular staff client.
To test
-------
[1] Attempt to log in the Angular staff client with Firefox. Note
that you get a whitescreen with the following in the browser
console:
SyntaxError: invalid regular expression flag s
[2] Apply the patch and repeat step 1. This time, the Angular
staff client should work normally.
[3] Verify that the Angular unit tests pass.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>
Galen Charlton [Fri, 27 Dec 2019 16:04:32 +0000 (11:04 -0500)]
LP#
1827942: follow-up to fix a couple issues
[1] Sets a default value for the modal options for dialogs such
as ProgressDialog that do not supply any value for the
options parameter; otherwise, progress dialogs would not
appear at all.
[2] Fix lint warnings.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Zavier Banks [Tue, 17 Sep 2019 20:59:15 +0000 (20:59 +0000)]
lp1827942: prevent clicking outside an Angular modal from closing it
I added a new property to the "options" object inside the "open"
function, which resides in the dialog.component.ts. The static string
inside the backdrop property makes the form stay, even if the backdrop
is clicked.
Signed-off-by: Zavier Banks <zbanks@catalyte.io>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Dan Scott [Sun, 15 Dec 2019 15:53:33 +0000 (10:53 -0500)]
Fix doc build for glossary
asciidoctor was throwing the error "invalid part, must have at least one
section (e.g., chapter, appendix, etc.)"; including [appendix] in front
of the include mollified it.
Also we don't need the duplicated Glossary / Glossary headings.
Signed-off-by: Dan Scott <dan@coffeecode.net>
Bill Erickson [Fri, 13 Dec 2019 19:27:16 +0000 (14:27 -0500)]
LP1830391 Stamping DB upgrate (hatch omnibus)
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Fri, 13 Dec 2019 19:13:40 +0000 (14:13 -0500)]
LP1830391 Angular test spec updates for Hatch store updates
The store service now leverages Hatch for workstation storage. Update
unit tests which load the store service to also load and propagate the
Hatch service.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Thu, 12 Dec 2019 21:47:31 +0000 (16:47 -0500)]
LP1830391 Warn on dupe workstation settings
Check for duplication workstations (by name and workstation) before
applying the UNIQUE constraint on actor.workstation_setting. If found,
raise a notice to the user to provide suggestions.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>
Bill Erickson [Mon, 28 Oct 2019 17:53:46 +0000 (13:53 -0400)]
LP1830391 Angular Hatch enabled flag lookup repair
Fix the Angular Hatch enabled setting lookup to pull the value from the
workstation setting instead of localStorage. This required shuffling a
few things around to support the asynchronicity.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>
Bill Erickson [Mon, 5 Aug 2019 14:44:55 +0000 (10:44 -0400)]
LP1830391 Hatch core mod import/export repairs
No need to import/export HatchService from the base common module since
it's now a core service which is exported automatically to root.
Includes minor lint repair.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>
Bill Erickson [Thu, 23 May 2019 22:02:41 +0000 (18:02 -0400)]
LP1830391 Workstation settings unique constraint
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>
Bill Erickson [Fri, 12 Apr 2019 19:47:24 +0000 (15:47 -0400)]
LP1824391 Hatch File Writer release notes
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>
Bill Erickson [Mon, 15 Apr 2019 15:34:21 +0000 (11:34 -0400)]
LP1824391 Hatch print-to-file Angular edition
Adds support for the Angular hatch service for sending 'bare' text/plain
print-to-file requests.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>
Bill Erickson [Fri, 12 Apr 2019 16:52:09 +0000 (12:52 -0400)]
LP1824391 Hatch File Writer print support
Adds support for translating receipt data to plain text and writing the
output to a file instead of sending it to a printer.
Adds a new stock printer named "Hatch File Writer" to the print
configuration interface.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>
Bill Erickson [Mon, 22 Apr 2019 21:02:05 +0000 (14:02 -0700)]
LP1825891 Use Hatch 'hostname' for workstation reg.
Populate the workstation name with the hostname of the PC when
registring a new workstation for Hatch-enabled workstations.
Note the code gracefully returns null if Hatch returns a 404 (not found)
or Hatch is not active.
Updates the AngJS and Angular workstation admin pages to load the
hostname value when possible.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>
Bill Erickson [Tue, 23 Apr 2019 14:57:31 +0000 (07:57 -0700)]
LP1825896 Store workstations in Hatch when available
When Hatch is enabled, use Hatch for storing workstation registration
information.
If workstations are found in localStorage, they are merged into the
collection of workstations stored in hatch and removed from
localStorage.
Include DB udpate to add workstation setting 'eg.hatch.enable.printing'
so that it may live on the server.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>
Remington Steed [Fri, 13 Dec 2019 13:22:17 +0000 (08:22 -0500)]
Docs: Fix AsciiDoc syntax error in glossary
This commit fixes a minor syntax problem that causes an AsciiDoc build
error.
Signed-off-by: Remington Steed <rjs7@calvin.edu>
lfloyd [Fri, 6 Dec 2019 19:26:35 +0000 (14:26 -0500)]
Docs: Added linkages, and additonal terms.
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Lynn [Wed, 27 Nov 2019 17:18:01 +0000 (12:18 -0500)]
Docs: Glossary Added
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Dan Briem [Wed, 7 Aug 2019 23:13:21 +0000 (19:13 -0400)]
LP#
1803406 Due date box in check out has display issues at wider resolutions
Adjusted bootstrap .col classes so the specific due date input displays the
full date and prevents the barcode input group from collapsing at < 1179px.
Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Bill Erickson [Thu, 5 Dec 2019 15:08:48 +0000 (10:08 -0500)]
LP1830923 Replace some pesky tabs
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Galen Charlton [Wed, 4 Dec 2019 22:41:38 +0000 (17:41 -0500)]
LP#
1830923: do not show Enhanced MARC editor tab when editing in-place
As the the AngularJS side does not currently offer a path
for directly editing a queued record, the enhancd editor tab
serves no purpose in this context.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Galen Charlton [Wed, 4 Dec 2019 22:34:45 +0000 (17:34 -0500)]
LP#
1830923: add support for editing queued authority records
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Thu, 17 Oct 2019 21:59:08 +0000 (17:59 -0400)]
LP1830923 Vandelay queued record editing
This patch adds MARC record editing the the Angular
Vandelay interface using the Angular MARC editor
component, which as of the date of this patch offers
a flat-text mode.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Bill Erickson [Thu, 17 Oct 2019 21:57:10 +0000 (17:57 -0400)]
LP1830923 Marc edit in-place additions
Improve Angular MARC editor for in-place editing.
* Make inPlaceMode a proper @Input.
* Allow the caller to pass in the bib source
* The recordSaved event now reports both the MARC XML and the currently
selected bib source.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Bill Erickson [Thu, 17 Oct 2019 21:44:40 +0000 (17:44 -0400)]
LP1830923 Combobox LP1844812 regression fix
Allow a combobox to start with an empty array that is later filled by
the caller. This was broken due to changes which prevented the combobox
from seeing an empty/stub array as being different from its
initialization array, thus ignoring empty array as a duplicate.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Andrea Buntz Neiman [Fri, 6 Dec 2019 14:50:10 +0000 (09:50 -0500)]
Docs: corrected image file reference in carousels.adoc
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Andrea Buntz Neiman [Thu, 5 Dec 2019 21:07:20 +0000 (16:07 -0500)]
Docs: follow up commit to fix include error
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Felicia Beaudry [Thu, 5 Dec 2019 20:35:50 +0000 (15:35 -0500)]
Docs: adding Carousels docs and screenshots
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Jason Boyer [Wed, 27 Nov 2019 13:42:27 +0000 (08:42 -0500)]
LP1850955: Include changes to package-lock.json
The package-lock.json file is necessarily changed
by dropping some dependencies. As long as we track
it, it may as well be updated.
Signed-off-by: Jason Boyer <JBoyer@eoli.info>
Bill Erickson [Fri, 1 Nov 2019 16:22:33 +0000 (12:22 -0400)]
LP1850955 Remove PhantomJS polyfills
Remove additional polyfills that were required specifically for
PhantomJS, which we no longer use.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>
Bill Erickson [Fri, 1 Nov 2019 16:18:00 +0000 (12:18 -0400)]
LP1850955 Angular build targets modernized
Apply a specific set of browsers to guide the Angular / Typescript
compilers toward a more modern set of default browsers. This reduces
the amount of compilation and browser files required.
Bump the ES version used by Typescript from ES5 to ES6.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>
Chris Sharp [Tue, 22 Oct 2019 13:21:22 +0000 (09:21 -0400)]
LP#
1849208 - Add PostgreSQL 10 Makfile.install targets
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jane Sandberg [Tue, 30 Jul 2019 20:54:10 +0000 (13:54 -0700)]
LP1607922: Receiving items on page 2 of search results
Previously, if a user selected a bunch of line items on two consecutive
pages of acq search results, and tried to receive items from the second
page, the operation would fail.
This issue was caused by Evergreen caching IDs of selected line items
from page 1, but not caching the data that went along with them.
To test:
1) Go to Acquisitions > General Search
2) In the Select Search Field dropdown, choose LI - State.
3) Set the state to on-order.
4) Click Search.
5) Click the check mark to select all results on the first page.
6) Click the Next button.
7) Click the check mark to select all results on the second page.
8) On the top --Actions-- menu, select Mark Selected Line Items as
Received.
9) Note that the interface does nothing, and that there is a TypeError
error message in the browser console.
10) Apply this commit.
11) Refresh your page completely and repeat steps 1-8.
12) Note that the items on the second page are received. Since they no
longer meet the search criteria, Evergreen gives you the next page of
results.
For further testing, see similar test steps by John Yorio at
https://bugs.launchpad.net/evergreen/+bug/
1607922.
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Bill Erickson [Fri, 8 Nov 2019 15:37:21 +0000 (10:37 -0500)]
LP1851831 Group perm editor null descriptions OK
Avoid assuming a permission description value is non-NULL in the
permission group editor interfaces since values are not required in the
database.
Fixes: ERROR TypeError: "l.description(...) is null"
Similarly repair the permission list title attributes so they display
the permission code (instead of an empty string) for titles when no
description is available.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Galen Charlton [Wed, 6 Nov 2019 16:35:58 +0000 (11:35 -0500)]
LP#
1851524: fix adding a bucket when saving a new carousel
This patch fixes a regression where saving a new carousel
would not result in its bucket being created due to the
post-save callback never getting invoked.
This patch does not fix any carousels that do not have
buckets due to this bug. Because such carousels will
not function anyway, they should be deleted and
recreated by the local admin.
To test
-------
[1] Create a new carousel in local adminstration. Open it
in the edit modal again and note that no record bucket
is linked to it.
[2] Apply the patch and repeat step 1. This time, the
bucket should be created.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Kyle Huckins [Fri, 5 Jul 2019 14:36:05 +0000 (14:36 +0000)]
lp1437103 Allow Receipts to Print when Suppressing Popups
- Move suppress_popup check further along and allow transit receipts
to properly print when popups suppressed.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/web/js/ui/default/staff/circ/services/circ.js
Signed-off-by: Bill Erickson <berickxx@gmail.com>
projects / working / Evergreen.git / log