LP#1579225: fix handling of passwords in patron registration

This patch improves how the new password hashing is invoked
by open-ils.actor.patron.update; in particular, it fixes
a problem whereby newly registered patrons could not
log in.  It also fixes other issues:

- actor.usr.passwd would be set to an MD5 of the password
  for new users, vitiating the strong hashes in actor.passwd
- certain types of updates via patron registration, such as
  adding or deleting addresses, could result in the patron's
  password getting doubly-hashed, thereby locking them out
  of their account.

To test
-------
[1] Register a new patron; verify that they can log in.
[2] Edit an existing patron and change their password; verify
    that they can log in.
[3] Edit an existing patron but do NOT change their password;
    verify that they can still log in.
[4] Inspect the actor.usr rows for these patrons and verify
    that actor.usr.passwd is set to the value MD5(''), not
    the MD5 of their password.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1579225: add live_t regression test

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Docs: Undo heading name change to fix broken link

This commit reverts a chapter heading change, which had broken an
internal cross reference link, thus causing the HTML docs to fail to
build. In this case, it seems best to keep the older heading rather than
fix the link to it.

In general, we should be careful about changing any AsciiDoc
headings, since we currently rely on autogenerated section IDs when
making internal links, and changing a heading changes its ID. If a
heading is changed, then all links to it need to be changed accordingly.

This commit also corrects a heading underline.

Signed-off-by: Remington Steed <rjs7@calvin.edu>

LP#1031335 No-op the escape_email_header helper

As suggested by Mike Rylander, keep the escape_email_header helper
around to avoid breaking templates that already adopted it, but make it
a no-op as the SendEmail reactor now encodes the email headers of
interest by default.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Fix LP#1031335 by escaping some email headers automatically

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Forward port 2.9.3 to 2.9.4 db upgrade script.

Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>

Adding 2.8.7 -> 2.8.8 DB upgrade script

Signed-off-by: Bill Erickson <berickxx@gmail.com>

2.10.1 to 2.10.2 schema upgrade script

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

updates to the 2.10.2 release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

Adding 2.10.2 point release notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

update release notes for 2.9.4

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

Adding 2.9.4 release notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

updates to 2.8.8 release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

Point release notes for the 2.8.8 release

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1562153: fix case where changing sort order to relevance can fail

This patch fixes a cause where sending a 'sort' CGI parameter
with the empty string as value (which specifies relevance sorting)
fails to override a previously-set sort order.

To test:

[1] Do a public catalog search starting from the advanced search form,
    e.g., keyword = "cats"
[2] Change the sort order to (say) Title A-Z from the results page.
[3] Note that the query string changes to "sort(titlesort) cats" and
    that the results are re-sorted
[4] Attempt to change the sort order to relevance.
[5] This time, the sort order does not change ... and it should have.
[6] Apply the patch and repeat steps 1-5. This time, the sort order
    should be successfully changed.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1562153: add regression test

This patch adds a regression test for successfully
overrding the sort order in a query from a 'sort' CGI
parameter.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1563531: add libpcre3/libpcre3-dev deps for Jessie

This patch adds libpcre3 and libpcre3-dev to the list
of packages installed when installing Evergreen on Debian
Jessie. Evergreen's direct dependency on libpcre3 is new in 2.10
(see bug 1468422); it happens that libpcre3 and libpcre3-dev
are installed on Wheezy by virtue of a different dependency
chain.

To test
-------
[1] On a fresh Debian Jessie netinstall, follow the OpenSRF
    and Evergreen installation instructions. Verify that with
    this patch in place, Evergreen's "configure" step succeeds.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1568195: Stamping upgrade script

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1568195: fix retrieving big OUS batches

This patch fixes a regression introduced in LP#1501471
where the Library Settings Editor could fail to retrieve
the values of org unit settings if more than 99 were
requested at a time.

To test
-------
[1] Open the XUL library settings editor and ensure that
    no search filters are in effect. Note that values
    are not displayed for any of the OU settings, and that
    the Pg log contains error messages like this:

    "ERROR: cannot pass more than 100 arguments to a function"

[2] Apply the patch.
[3] Repeat step one, and verify that values are now retrieved
    for all of the OU settings that have values set.
[4] Verify that the pgTAP tests in live_t/aous_batch.pg pass.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1569884: stamp schema update

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1569884: fix schema update script

CREATE INDEX cannot run concurrently in a transaction
block period, at least as of 9.4.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1569884 Fix two problems in previous commit.

The CREATE TABLE biblio.monograph_part statement in
010.schema.biblio.sql ended up with a trailing comma.

The CREATE UNIQUE INDEX on biblio.monograph_part cannot be done
CONCURRENTLY at DB creation time, apparently.  At least not on
PostgreSQL 9.3.

Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1569884 Updated base schema with monograph parts index.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1569884 Allow deleted monograph parts to be recreated.

Changed the constraint on the biblio.monograph_part table to allow for a
monograph part to be created if a duplicate deleted version is found.

To test:

[1] Add a monograph part to a bib.
[2] Delete that monograph part.
[3] Attempt to add a monograph part to the same bib using
    the same part label. Without the patches installed, this
    will fail; upon applying the database update, this operation
    should succeed.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1569884: add regression test

This pgTAP test verifies that if you logically delete a monograph part,
you can subsequently add a new one with the same label as that of the
deleted one.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP 1562426: Renumber Perl live_t tests.

We had some overlap in numbers at the beginning of test file names.
The OCD in me think this should be straightened out.  This branch
renumbers the duplicates starting with 10-.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1564079 Stamping upgrade script

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1564079 Checkout history skips nonexistent items

Modify the user checkout history migration process
(2.9.3-2.10.0-upgrade-db.sql and 0960.schema.decouple_co_history.sql) to
avoid inserting history rows for circulations whose copies do not
exist in the database.

For reference, this is a rare condition that cannot be recreated in a
modern EG system short of modifying constraints.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1564079 Checkout history handles serials

Remove the target_copy foreign key constraint on action.usr_circ_history
so that it does not prevent creation of rows from circulation's that
link to serial.unit objects.  Similar to action.circulation, the foreign
key constraint is enforced via a evergreen.fake_fkey_tgr trigger
instead.

This modifies the 2.9.3-2.10.0-upgrade-db.sql and 0960 upgrade scripts,
since without this change, the scripts may fail.

A separate upgrade script is added to drop the constraint for those who
have already successfully run the the 2.9.3-2.10.0-upgrade-db.sql script
(i.e. those who don't use serials).  For simplicity, the
evergreen.fake_fkey_tgr trigger is only applied in this separate upgrade
script (in addition to the base schema, of course).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: image fix

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>

Docs: Paid PO Lineitems

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>

Docs: Funds disencumbered when invoice is closed

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>

LP#1559121: remove Debian Squeeze support

Now that Debian Squeeze's LTS (long-term support) period
has ended, Evergreen no longer offers community support
for that distribution. This patch removes references
to Squeeze from the installation scripts and documentation.

To test:

[1] Verify that Debian Squeeze is no longer referenced in
    the installation documentation.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
Conflicts:
docs/installation/server_upgrade.txt

Docs: clean up formatting & typos in using_the_public_access_catalog.txt

Thanks to Anna Goben for these fixes.

Signed-off-by: Yamil Suarez <yamil@yamil.com>

Docs: Screenshots and step by step instructions added to Self Check section

Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>

LP#1573372: Opt-in test broken because it uses bail-out.

Use skip instead!

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

Docs: New changes to new patron registration duplicate search.

Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>

LP#1573364: Use a timezone in the future backdate checkin test.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

Docs: Exclude Electronic Resources

Signed-off-by: Yamil Suarez <yamil@yamil.com>

Docs: Updated attributions.txt

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: resized image

Signed-off-by: Yamil Suarez <yamil@yamil.com>

Docs: Expanded information about item record view in OPAC

Signed-off-by: Yamil Suarez <yamil@yamil.com>

Docs: resized image

Signed-off-by: Yamil Suarez <yamil@yamil.com>

Docs: added tip on using hold counts in renewals

Signed-off-by: Yamil Suarez <yamil@yamil.com>

Docs: small syntax fix circulation/circulation_patron_records.txt

Signed-off-by: Yamil Suarez <yamil@yamil.com>

Docs: small syntax fix in cataloging/authorities.txt

Signed-off-by: Yamil Suarez <yamil@yamil.com>

Docs: small fix for circulation_patron_records_web_client.txt & root.txt

Signed-off-by: Yamil Suarez <yamil@yamil.com>

Docs: small fix for lsa-barcode_completion.txt & root.txt

Signed-off-by: Yamil Suarez <yamil@yamil.com>

Docs: update root.txt to include 2.10 release notes

Signed-off-by: Yamil Suarez <yamil@yamil.com>

Docs: typo fix in authentication_proxy.txt

Signed-off-by: Yamil Suarez <yamil@yamil.com>

LP#1564685 Prevent linked address edit on reload

Prevent editing of linked addresses when a user is loaded after the
clone operation.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1564685 Avoid referencing out-of-scope stat cats

Fixes a bug in the patron editor where out-of-scope stat cats would be
incorrectly bundled in the patron save operation, resulting in a
server-side error on save.  In short, ignore out-of-scope stat cat
entries for patrons in the editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1564685 Prevent edit of linked addresses

Do not allow a cloned user to modify a linked address.  Only the address
owner should be able to do that.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1564685 New Address button is always accessible

The New Address button in the patron editor is now always accessible,
regardless of the existence of any addresses.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1564685 Repair patron editor checkboxes sizing

Fix the checkbox HTML markup to prevent huge checkboxes in the patron
editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1564685 Required-field org settings overlay defaults

An org setting requiring a value for a field in the patron editor means
the field is required, even if it's not required by default.  IOW, fix
the code that was supposed to do that already.

Of note, county and state can now both be marked as required by org
settings in the patron editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1564685 Allow delete of all patron addresses

If the org setting ui.patron.registration.require_address is not true,
allow all addresses to be removed from a patron's account.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1564685 Alert and stop on invalid fields

Display an alert message and prevent save or save+clone when invalid
values exist in the patron edit form.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1564685 Allow barcode as username despite regex

Allow a patron's barcode to be considered a valid username in the patron
editor even in the presence of an 'opac.username_regex' org setting
value that does not match the barcode.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1564685 Avoid dupe usrname warning on matching patron

Do not treat usernames as duplicates when they belong to the patron
being edited.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP1564378: Silence Hash Init Warning

A trivial change to silence a lot of noise (if your libraries
use extending grace periods.)

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1373601: Consider relevant characters before using word-boundary checks

To perform unanchored phrase limits, we make sure that the phrase supplied
by the user does not end in the middle of a word by bounding the condition
with word-boundary bracket expresssions.  However, if the phrase starts
or ends with a non-word character (that is, something other than numbers,
letters, or the underscore) then the word-boundary expression won't match.
The effect of this is to cause phrase searches starting or ending in
punctuation to fail when the user would not expect them to.

To address this, we now test the phrase for word-iness at the front and
back before applying word-boundary bracket expressions.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

update upgrade instructions for 2.10.1

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

release notes for Evergreen 2.10.1

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

2.10.0 - 2.10.1 schema update script

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1560174 Stamping upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1560174: fix MARC import for database upgraded to 2.10.0

This patch applies the correct version of the vandelay.ingest_items()
stored procedure introduced in the patch for bug 1548143.

To test
-------
[1] Upgrade an Evergreen database to 2.10.0 (a fresh database
    will not run into the bug).
[2] Try importing a MARC bib record via Vandelay using a profile
    that imports items.  This should fail.
[3] Apply the schema update in this patch.
[4] Repeat step 2; this time, the import should succeed.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Translation updates - newpot

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Translation updates - po files

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

forward-port 2.9.3-2.10.0 monolithic DB update script

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

forward-port the 2.10.0 upgrade instructions

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

final release notes for 2.10.0

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

add list of bugs closed to release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

update acknowledgments in release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Porting 2.9.2 to 2.9.3 database upgrade script.

Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>

Porting 2.8.6 -> 2.8.7 SQL upgrade

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Docs: 2.9.3 Release notes

Adding bug fixes to the point release notes for 2.9.3

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

docs-2.8.7 release notes

Adding point release notes for 2.8.7

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1557621 Verify password barcode / deleted users repair

* Fixes bug that caused password verify calls to fail with an exception
  when tested with a barcode.

* Verify API always returns false when tested on deleted users.

To test:

1. In the staff client, navigate to Circulation -> Verify Credentials
2. Confirm username and barcode lookups return success for a non-deleted
   user using the correct password.
3. Delete a test user in the database:
   UPDATE actor.usr SET deleted = TRUE WHERE id = <id-of-test-user>;
4. Re-do step 2 confirming non-success results are returned.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1367926: fix syntax error in DB update script

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Updates to 2.10 release notes

Updates includes fixing some grammatical errors/typos, some rewording and
reorganization to improve clarity, and explicitly calling out new settings.
We also added Christine Morgan to acknwoledgements for her contribution of
new images for hold and transit alerts/slips.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

docs: reorganizing, adding information about importing authority records using vandelay

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

docs: Adding instructions for setting up due time in the patron's myopac display

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

docs: Adding section about facet_groups in advanced search

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1548143 Add release notes

Add release notes for Vandelay 'parts' import support.

Signed-off-by: Dan Wells <dbw2@calvin.edu>

update 2.10 release notes with some work that made the RC

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP1550035 Address deletion / avoid xact collisions

Avoid transaction collision errors when updating patrons, in cases where
the patron object has to be updated more than once, by refreshing the
last_xact_id value on the in-progress patron object.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1550036 Linked patrons for new users

Support adding auzillary (linked) groups for new patrons in the browser
client editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1553813 Patron editor validation / perm checks.

1. Adds support for enforcing ui.patron.edit.*.require and
ui.patron.edit.*.regex org unit settings via Angular's ng-pattern and
ng-required attributes.

2. Supports selecting only valid profile groups and home org units.

3. Warns the user when a duplicate barcode or username is encountered.

When any fields in the form are invalid, the save options are disabled.

==

Adds support for enforcing the following permissions:

UPDATE_USER
CREATE_USER
CREATE_USER_GROUP_LINK
UPDATE_PATRON_COLLECTIONS_EXEMPT
UPDATE_PATRON_CLAIM_RETURN_COUNT
UPDATE_PATRON_CLAIM_NEVER_CHECKED_OUT_COUNT
UPDATE_PATRON_ACTIVE_CARD
UPDATE_PATRON_PRIMARY_CARD

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#963341: Unrelated YAOUS breaks MFHD management

Part of LP bug 963341 is about how the setting opac.fully_compressed_serial_holdings
breaks staff's ability to manage MFHD attached to serials records.  This
commit unbreaks that by fetching the relevant MFHD regardless of that setting
but should not otherwise change user-visible behavior.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1208613: Reset lineitem cache when resetting table

Stale cache entries in this table were causing the "expand all"
functionality to break.  This might be a nuclear option, but as far as
I could see, this "cache" gets repopulated on every pagination anyway,
so I don't think we're losing anything.

To test:

[1] Select a large list from the Acquisitions --> My Selection List
    screen.
[2] Click on the Expand All button and the items on the page expand
    with more information.
[3] Click on the Next link to bring up page 2 of the list.
[4] Click on the Expand All button and verify that additional
    information is displayed.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Erica Rohlfs <erohlfs@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1370694: stamp database update

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1370694: don't update already-customized format.selfcheck.holds

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1370694: clean up whitespace

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1370694 Selfcheck: "Print List" for Holds view does not work

Prior to this change, the holds data was not getting passed to the
print function. Now, it is being captured and passed to the print
function. Because of some sorting discrepancies between the order of
the information being passed from here to the action trigger and the
order that the information is presented when pulled directly out of the
database by the action trigger (which led to data mismatches between the
title/author and the hold status/pickup locations for each printed item),
I modified this script to pass all of the hold information together in the
desired order to the action trigger rather than relying on the template
to match the data coming from the script with the data from the database.

This change requires the action trigger printing template to be updated in
order to work. I've included an upgrade script as well as an update to the
seed data script.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1551447: stamp database update

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1551447: don't update already-customized format.selfcheck.fines

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1551447 Selfcheck: Printing Fines Prints All Open Transactions

This corrects the behavior of the selfcheck fines receipt print template.
Prior to this, it printed all open billable transactions (eg, every item
that the patron had checked out) regardless of whether or not it had bills
associated with it. This adds a small bit of logic to the template to
check for a balance due. It also updates the javascript to check for a
balance on the account before launching the print function to prevent the
system from taking unnecessary action.

This includes a SQL upgrade script to update the Self-Checked Fines
Receipt template for systems that are already in production, as well as
including an update to the seed data.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1275118 Holds history displays canceled holds as active

Prior to this change, when a patron viewed holds history, canceled holds
displayed as active. From the patron point of view, the hold is no
longer active after it has been canceled.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Erica Rohlfs <erohlfs@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1454871: whitespace cleanup

Signed-off-by: Galen Charlton <gmc@esilibrary.com>