correctly test whether the alert_type fires during renewal

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

no longer display the legacy copy alert message

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

fix styling of manage copy alert button in item status

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

add new-style copy alerts to volcopy defaults selector

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

copy alert type editor can now create and update copy alert types

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

make copy alert suppression editor feature-complete

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

set name as copy alert type selector field

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

add copy alert suppression to splash page

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

start UI for managing copy alert suppression

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

add copy alerts to local admin splash page

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

start on a config editor for config.copy_alert_types

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

teach vol/copy editor how to deal with copy alerts

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

add copy alert ack/manage action to checkin, checkout, and item status

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Conflicts:
Open-ILS/src/templates/staff/cat/item/t_summary_pane.tt2

implement setting next status upon checkin

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

display text for system-generated copy alerts

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

return all potential next copy statuses, not just first

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

have a bit of visual separation between alerts

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

start work on egCopyAlertManagerDialog

This dialog is currently capable of:

- displaying copy alerts during checkin and checkout
- allowing the operator to acknowledge temporary alerts

TODO:

- allow display of all current alerts
- allow alerts to be added

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Conflicts:
Open-ILS/web/js/ui/default/staff/circ/services/circ.js

some sample copy alert types

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

don't generate system copy alerts if copy state is normal

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

support the LOST_AND_PAID status added in LP#1198475

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

fix various thinkos and syntax errors to get the biz logic working

As of now, open-ils.circ.checkin is now starting to emit
custom copy alerts.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

fix some typos, syntax errors, and stray invisible characters

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

add typo/space fixes to baseline schema

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

biz logic for alerts

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Baseline IDL stuff for alerts

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Initial schema for copy alerts

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1691560: start open-ils.qstore service by default

To test
-------
[1] Apply patch, then restart all services.
[2] Verify that open-ils.qstore is running.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1692106: Z39.50 server includes prefix and suffix in 852

Add the call number prefix and suffix to the 852 $k and $m when copy
information is returned by the Z39.50 server.

Signed-off-by: Martha Driscoll <driscoll@noblenet.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP1704463: Item Status Fields Correction

The Loan Duration and Fine Level fields were
being incorrectly pulled from unrelated fields
on the most recent circ rather than the item.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Docs: Search Filter Enhancements

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>

Docs: Update to Statistical Popularity Badges

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>

Docs: Statistical Popularity Badges

Documentation for new statistical popularity badge feature in the web client.

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>

Docs: Email Checkout Receipts (web client)

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>

Docs: Add doc for Cash Reports feature

Add basic documentation for the previously undocumented Cash Reports
feature.

Signed-off-by: Remington Steed <rjs7@calvin.edu>

lp1702568 Copy Location fix for Hold Detail View

hold.current_copy.location is better fleshed than copy.location in this case

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>

lp1661685 fix circ lib in patron holds list

and make it and the circ modifier column hidden by default

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>

lp1661685 webstaff: Circ Lib column for Items Out

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>

lp1661685 webstaff: Fix Owning Lib in Item Status

Detail View

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>

lp1661685 fieldmapper label change for circ

Change "Circulation Library" to "Checkout / Renewal Library"

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>

lp1661685 webstaff: add money.grocery to pcrud

and add a single column called Location to the Bills interface which shows
either the circ.circ_lib or the grocery.billing_location for a given xact

and the specific columns for both xact types

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>

LP#1685933 - Add Owning Library column to grids in ItemsOut and checkout views

Added necessary fleshing in egCirc service and items out to get acn.owning_lib.shortname

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>

LP#1661685 - Adds circ library column to staff webclient grids

Circulation Library was missing as an option from several grids
Added also function to flesh out circ_lib.shortname to display name.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>

LP#1661685 - Adds missing Circulation Modifier column to several grids

Some views like the Checkout,CheckIn, Holds, And Bills
 did not display the copy's circ_modifier field.
 Also added egCirc.flesh_copy_circ_modifier()

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>

LP#1697754 - WebStaff make receipt on payment sticky

    Add circ.bills.receiptonpay local storage setting.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>

LP#1677000 - webstaff Adds a 'has-notes visual indicator' for patrons with notes.

Made the indicator be clickable and route to Other->Notes.
Other ways to address this not mentioned in LP would be
using a glyphicon instead, or moving the Notes submenu item out of Others tab.
Or even making the entire tab/menu be resposive, and collapsing into an Others submenu
only when needed.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>

LP#1672421-Fix for Catalog record Holds view grid not refreshing

Holds view grid was not refreshing upon paging using next/prev
Added call to egHolds service to fix that.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>

LP#1653998 Remove undefined $routeProvider reference

Avoid 'grunt test' failure "Unknown provider: $routeProvider" resulting
from $routeProvider references in startup.js (egCoreMod) without first
loading the ngRoute module.

$routeProvider is not needed by the original patch.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

lp1517595 webstaff: purge patron account action

TODO: disable the menu entry based on permissions

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

webstaff: CSS for disabled anchor <a> elements

Don't let bootstrap override the grey color (for example, when using dropdown-menu)

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Fix Can't locate object method "workstation" error

When trying to utilize the Recall functionality, Evergreen would fail to update
targeted circulations (truncate the due date, etc.)  In the logs, we would have
an error like this:

[] open-ils.storage [ERR ::action.pm:1597:] Processing of hold failed:
Can't locate object method "workstation" via package "action::circulation" at
/usr/local/share/perl/5.14.2/OpenILS/Application/Storage/CDBI.pm line 181.

We first tried adding the workstation column to Storage/CDBI/action.pm, but a
similar message would then appear instead: Can't locate object method
"checkin_workstation"

This sidesteps the problem entirely.

Thanks to Mike for the solution!

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1205190: more CSS tweaks

* replace a few more "background" with "background-color"

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1205190: TPAC: Improve style.css to reduce warnings

* Improve specificity: use background-image (for gradients) or
  background-color (for color) instead of just background, because we
  are only specifying the image or color, and not the rest of the
  background properties.
* Declare the background-color first, followed by the background-images;
  these will only override if recognized by the browser.
* Declare the standard (unprefixed) CSS linear-gradient last to prevent
  prefixed browser quirk versions from overriding the standardized form.
* Remove the -moz- prefix from -moz-border-radius as that has not been
  supported by Gecko since Firefox 13.0; just plain border-radius now.
* Fix bad selector ##rdetail_extras_expand (only one #, please).

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Conflicts:
Open-ILS/src/templates/opac/css/style.css.tt2

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Conflicts:
Open-ILS/src/templates/opac/css/style.css.tt2

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1205190: quiet some CSS Mozilla extensions warnings.

* -moz-dialog-text is actually -moz-dialogtext
* -moz-outline is deprecated, use outline
* -moz-border-radius has been removed, use border-radius
* -moz-border-radius-topleft (etc) are now border-top-left-radius
* Fix some other CSS errors.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Conflicts:
Open-ILS/src/templates/opac/css/style.css.tt2
Open-ILS/web/css/skin/default/register.css
Open-ILS/web/opac/skin/default/xml/home/homesearch.xml
Open-ILS/web/reports/oils_rpt.css
Open-ILS/xul/staff_client/server/admin/org_unit_settings.xhtml
Open-ILS/xul/staff_client/server/serial/notes.xul
Open-ILS/xul/staff_client/server/skin/circ.css

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1697954 Items out fetch grids only when needed

Avoid forcing a refresh of Items Out grids in cases where the grids will
automatically refresh as a new grid is instantiated.  This prevents the
code from calling redundant data collection APIs, resulting in local
cache's with duplicate data sets.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1697954 Items out pre-fetch renders selected range

Items out and noncat items out grids now only render the selected range
of transactions, instead of the full set collected for client-side grid
sorting.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1697954 Notify correct page of patron holds

Instead of notifying the grid on all holds, just notify when we're inside
the current page of results.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1697954 Hold details API additional fleshing

* Support new flesh options in hold details retrieval API:

include_current_copy
include_usr
include_cancel_cause
include_requestor

* Teach browser client code to use the new flesh options.  This reduces
  the number of API calls significantly for rendering holds grids.

* Add debug logging to existing local-flesh calls to indicate when/if
  additional API fleshing may be needed.

* Remove TODO comment about batching holds to avoid cstore exhaustion,
  which was fixed with LP#1653001.  However, leave the batching in place
  since it noticeably improves UI responsiveness, at the cost of a few
  extra API calls.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1697954 TODO comments for client sort all-fetching

Add additional code comments further clarifying why some grids pre-fetch
all rows (for client-side sorting) instead of fetching in pages.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1697954: Enable clientsort for user items out lists

These will generally be small, so we'll fetch all the data to support client-
side sorting.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1697954: Enable clientsort for user holds lists

These will generally be small, so we'll fetch all the data to support client-
side sorting.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1697954: Enable clientsort for checkout

This list is filled by the user, so it's safe to use client-side sorting.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1697954: Provide custom comparator for sorting money on renew

mbts.balance_owed often arrives as a string, so we provide here a custom
comparator function that runs the values through parseFloat() before comparing
them.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1697954: Enable clientsort for renew

This list is filled by the user, so it's safe to use client-side sorting.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1697954: Enable clientsort for pending patrons

This list always retreives all data, so it's safe to use client-side sorting.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1697954: Provide custom comparator for sorting money on checkin

mbts.balance_owed often arrives as a string, so we provide here a custom
comparator function that runs the values through parseFloat() before comparing
them.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1697954: Enable clientsort for checkin

This list is filled by the user, so it's safe to use client-side sorting.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1697954: Enable clientsort for item status list

This list is filled by the user, so it's safe to use client-side sorting.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1697954: Provide client-side sorting for grids that can use it

There are several grids (items out, checkin, checkout, item status, etc) that
could benefit from the ability to sort their items, but either the data
provider uses a complex data structure or an API call that doesn't offer
sorting, or the item list is populated by user input rather than a call to the
server.  In those cases, sorting is not available.  However, if we know that
all the data in the grid is in client memory, it would be reasonable to offer
a client-side sort option.

This commit does that by teaching the grid to accept a "clientsort" feature
and teaching arrayNotifier how to sort the items currently stored.  The sort
works over any mix of IDL objects, hashes, and flattened fields, supports
multisort, and pushes "nulls" to the end of the list.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

lp1678152 webstaff fix Add Copies & Volumes

Changes open-ils.cat.asset.volume.fleshed.batch.update,
AssetCommon::create_volume, and Cat::Merge::merge_volumes
to handle auto-volume merges during volume creation.

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1687125: add release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1687125: adjust relationship between acqpro and acqpron

A provider can have many notes, and "provider_notes" is effectively
virtual.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1687125: adding provider note to provider note in fm_IDL

This patch makes provider notes available to the reporter.

To test
-------
[1] Add a note to a provider record (note that at present,
    this can only be done directly in the database).
[2] In the report editor, verify that the reporting
    source for providers now includes a link to notes.
[3] Create and run a report that includes the provider
    note.

Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1208875: Add Release Note

Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1208875: follow-up to standardize extract fields

This patch removes the proposed custom methods for extracting
title, author, and record format in favor of tweaking
->fetch_user_circ_history to invoke unapi.bre and adjusting
the template to use get_marc_attrs. Also, nowadays
->fetch_user_circ_history can flesh what we need it to without
having to rely on the existance of an action.circulation row,
which won't be present if the circ was aged but was otherwise
retained in the user circ history.

The result is slower than the previous approach, but still
retains the core idea of getting A/T out of the equation, and remains
much faster than the A/T approach.

Dropping use of unapi.bre would speed things up a bit more, as it
was added only to match the addition of the record format column
in the CSV output. Drop the column, and we no longer need to worry
about MVFs.

There would also be opportunities to improve caching further.  Bib
display fields, when it comes, will likely help even more, as it
would mean being able to drop a lot of the XML parsing currently used.

This patch also adjusts misc_util.tt2 so that including it doesn't
result in an unwanted blank line.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

lp1208875 make _get_circ_history_csv work with fetch_user_circ_history

braindead adaptation.. _get_circ_history_csv predates fetch_usre_circ_history

I haven't scrutinized what the two circ_history subs actually do, but I bet
there's room for improvement here.

However, as it is now we do get a significant speed boost.  Thanks Dyrcona!

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1208875: Use text/csv MIME for circ history CSV.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP 1208875: Fix circ history CSV download for many circulations.

We no longer retrieve a user's circ history for download via
action/trigger and instead build the CSV data right in the TPAC.
The reason for this change is that action/trigger imposes just
too much of a delay between initiating the retrieval and getting
the data, particulary for patrons who have a large number of
circulation history entries, for certain values of large.

The new code uses the CStoreEditor to make JSON queries to retrieve
only the information needed for CSV.  Testing revealed that using
the existing fetch_user_circs method in EGCatLoader/Account.pm was
still too slow for the more extreme patrons.  The new code also
caches most of the retrieved bibliographic data.  Testing revealed
that most patrons get multiple checkouts of the same things, or
multiple parts of a multiple part television series.  Caching the
bib data for these records has shaved several seconds off retrieval
time in testing.

This branch makes use of a new, MVF, view when retrieving format
information.  It is thus unsuitable as-is for backport before
2.6.

Along the way, we have accreted a generically reusable CSV filter
for Template Toolkit.  That could be useful not only in other
parts of Evergreen, but in other projects.

Finally, this commit leaves the old action/trigger code in the
database.  Right now, it makes a good reference if anyone wants
to study what has been changed.  It can be removed later, if so
desired.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

lp1653998 webstaff redirect to login page

on invalid/non-existent authtoken in all or most interfaces (hopefully)

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Forward-port 2.12.3 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Forward-port 2.11.6 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

i18n: fix syntax for Spanish lang.dtd

As noted by FreddyEnrique in IRC, there was a syntax problem for the Spanish
file lang.dtd that caused an error when trying to open the Closed Date Editor.

Signed-off-by: Ben Shum <ben@evergreener.net>

Docs: 2.12.3 Release Notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: 2.11.6 Release Notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1665465 - Fix Print receipt on payment cbox not bound to model

Seems that Angular for some reason has issues binding to literals...
According to the interwebs it's likely due to scope nesting via ng-include

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1665115-WebStaff add longoverdue items count to Items Out

Longover due items should always, be reflected in total tally count
Which is what displays in the ItemsOut tab and Patron summary area.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1642035-Small DRY refactor to regctl.js compress_hold_notify()

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

lp1642035: Replace SMS Carrier Dropdown

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

lp1642035: Editing User Hold Preferences

The JS for hold notification values was replacing rather
than concatenating so only the furthest-right true value
would be saved. And because an ng-if directive creates
a child scope[1], the hold_notify_sms primitive could
never be true. Changed hold_notify_* to an object to
avoid this.

An ng-model directive was added to enable
opac.default_sms_notify but opac.default_sms_carrier
will still require some work to enable / replace.

[1]:https://github.com/angular/angular.js/wiki/Understanding-Scopes

Testing:

pre-patch:
Try to do anything with default sms number, fail.
Try to set more than one of phone + email notification, fail.
Try to set sms notification to anything, fail.

post-patch:
Default sms notify value is populated and can be changed.
All 8 possible combinations of hold notify options can be set.

Still can't set opac.default_sms_carrier value, needs additional work.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1696495-WebStaff fix user_settings data caching between patron views

Appends a few promises to make sure that the user_settings are refreshed
each time a user is loaded from within patron app.
Note that testing this requires that LP1642035's fix be in place...
Otherwise you can't properly add user_settings inputs in Webstaff.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1679309: Don't persist advanced search format filters in searchbar

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1693560: Remove permission check for retrieve tag table function

The permission check for the retrieve tag table function was preventing
users who don't have the UPDATE_MARC permssion from performing searches
in the staff catalog. Since there's nothing confidential in the table,
this commit removes that permission check. Thanks to Jason Boyer for
finding the source of the problem.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1691473 Internal Apache HTTP port configuration

Adds an optional new Apache/mod_perl configuration variable for defining
the port Apache listens on for HTTP traffic.  This resolves an issue
where added content lookups attempting HTTP requests on the local Apache
instance on port 80 failed because Apache was using non-standard ports.

To test:

[1] Set a value for OILSWebInternalHTTPPort that's not "80".
[2] Restart/reload Apache
[3] Load a record detail in the catalog
[4] Confirm opensrf logs show:

"tpac: added content connecting to <ip-address>:<new-port> / <hostname>

<new-port> should be the value configured for OILSWebInternalHTTPPort.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1694696 - Check for blank SMS Carriers in A/T reactor

Currently, the get_sms_gateway_email subroutine does not check
for the truthiness of sms_carrier, which can result in catastrophic
failure for a running server.  This adds that check.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1694696: add some unit tests for A/T helpers

In particular, start with get_sms_gateway_email().

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1244547: add release notes

Since this feature is tiny, I'm starting a miscellaneous
section for any other further tiny enhancements in the
'Administration' section.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1244547 Fix reference to new isFiltered variable

This commit completes the intention of the previous commit, which
accidentally checked the isFiltered object instead of its value.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1244547 Maintain Filter Settings on Library Settings Editor

After applying a filter to the rows on the Library Settings
Editor, and then selecting a different OU, the filter settings
are not considered unless the user clicks the "Filter" button
once again.

This patch maintains the filter settings on the edior until
the user clicks the "Clear Filter" button.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1642042 Webstaff noncat real-time display

Update non-cat counts in the patron summary side bar and show the full
set of non-cat circs in the Non-Cataloged Circulations tab as non-cat
circs occur in the patron checkout interface.

Consistent with the XUL client, avoid updating tab-level 'items out'
counts with non-cat circs.

Adds a new work log action for 'noncat_checkout' so the correct data can
be extracted.  As with the XUL client, this appears in the work log as a
'checkout' with no copy.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1686194 Account for adjustments when generating fines

Fine generation stops at a predetermined 'max fines' amount, but this
does not account for possible adjustments which lower the effective
fine amount.  This situation is common in cases where lost items are
returned, and the library wants to generate additional overdues upon
that event.

With this commit, fine generation will pull in any adjustments applied
to overdue fines, and use those to offset the current total fine when
checking for max fines.

Also includes test for this condition.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>