Add Invoice Summary Reporting View.

Before now, there have been no easy ways to gather acq
receiving totals from reports.  Here is an attempt to remedy
that situation.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Driver's license guidelines
Added on-screen tip to remind staff how driver's licenses should be
entered in PINES.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

OPAC Updates related to page text and translations. Also required are the
en-PINES.po custom text file and the es-ES.po translation file.

Language - here are three files I missed including in the prior
collection of translation-related files.

Language files - a few more corrections.

Changing hard-coded string to allow locale to work.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/src/templates/opac/parts/advanced/search.tt2
Open-ILS/src/templates/opac/parts/pref_lib_display.tt2

Restoring selfcheck.js to stock version

Addition of new item format icon for direct audio (ie, Playaways and
similar items that are pre-loaded with audiobooks and do not require
access to a computer to use).

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

adding login redirection page

Adding PINES-ified notification wordings.

Changes to splash screen and receipt template defaults for web client.

(Note: Could not test on terran-testbox since it is not https-enabled,
so I could not log in to the web client.)

These changes undo a couple of small things I tried to tweak on the web
client that didn't work the way I hoped they would.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Self-Check changes in preparation for upgrade:
Changed wording on some of the on-screen directions.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Selfcheck Cookie Path

Change base.xul/base.js to support a "cookie path" option to limit what paths
will use the login cookie, then tell the selfcheck interface to use it.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Additional changes to the self-check interface.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Images for new "no image available" functionality.

Lines 94-104 in eg_vhost.conf need to be un-commented.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

These are modifications to the Evergreen self-check interface to:

1. Fix bugs with printing holds and fines.
2. Improve page layout overall, and with consideration for
   1024x768 resolution monitors that a lot of libraries use.
3. Hide hold status from view on holds table.
4. Hide buttons/fields from screen when user is not logged in.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/src/templates/circ/selfcheck/banner.tt2

Change links old library map to new interactive library locator map.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Enabled Google Analytics for OPAC usage tracking.

branding the built-in selfcheck interface for PINES

Make users_of_interest test for defined actor.usr.card values

If the open-ils.collections.users_of_interest API encounters a patron that
has a null "card" value in actor.usr the API will crash with an error like:

Received Exception:
Name: osrfMethodException
Status:  *** Call to [open-ils.collections.users_of_interest.retrieve] failed for session [1416515351.333446.1416515351406], thread trace [1]:
Can't call method "barcode" on an undefined value at /usr/local/share/perl/5.14.2/OpenILS/Application/Collections.pm line 299.

This patches users_of_interest to be sure that the user has a defined value
for actor.usr.card before proceeding to pull out the barcode for the results
of the API call.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Collections.pm

Removing "Bib Call Number" from the advanced numeric search options.

Commenting out Bib Call Number and uncommenting Call Number Browse.

Conflicts:
Open-ILS/src/templates/opac/parts/advanced/numeric.tt2

Allowing unfillable hold placement in the staff client, not the OPAC

In PINES, we do not allow patrons to override hold policies, but staff
may in certain circumstances.  This change makes the option visible in
the staff client, but not the OPAC.

KPAC squashed

This combines multiple KPAC customizations into a single commit.

Conflicts:

Open-ILS/src/templates/kpac/home.tt2
Open-ILS/src/templates/kpac/parts/copy_table.tt2
Open-ILS/src/templates/kpac/parts/header.tt2
Open-ILS/web/css/skin/default/kpac/style.css

Conflicts:
Open-ILS/src/templates/kpac/parts/copy_table.tt2
Open-ILS/web/css/skin/default/kpac/style.css

Updated dewey.tt2

PINES customization of KPAC - beta ready for testing

Removing "kpac-original" directory in order to keep a clean source directory.

Image handling has changed in the new version...

Removing PINES-customized code that referred to a now-missing image.

Modifications to quick search functions and stylesheet.

Conflicts:

Open-ILS/web/css/skin/default/kpac/style.css

Testing modifications to navigation.

Further tweaks to search limits and modifications to book bag links.

Small changes to Search Limit names and Category names.

Correcting file path for PINES logo on KPAC.

PINES KPAC landing page doesn't include the Print button.

Temporarily hid Add to List functionality until it can be further developed.

Adding KPAC link to header and footer.

Modified style guide to emphasize call numbers in search results and item display.

Attempt to fix default pickup location bug when user is not logged in.

Conflicts:
Open-ILS/src/templates/kpac/getit.tt2

fixed problem with referencing wrong org selector

Conflicts:
Open-ILS/src/templates/kpac/getit.tt2

temporary workaround for holds error when user isn't logged in and doesn't select a pickup location

Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGKPacLoader.pm

Adding fix for KPAC hold placement.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Corrected version of kpac.xml with properly nested preset searches

Added README and graphics template for use of KPAC graphics.

Conflicts:
Open-ILS/examples/kpac.xml

Added Nutrition subcategory under Early Learning category in KPAC.

Add GALILEO for Kids link to KPAC header.

Syncing kpac.xml with rel_2_5_1_kpac

Change to allow KPAC to display more than one format icon (like OPAC).

Fix for KPAC multi-format items

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:

Open-ILS/src/templates/kpac/record.tt2
Open-ILS/web/css/skin/default/kpac/style.css

KPAC Login Redirect Fix

Fixes the redirect from the KPAC login to return back to the
home page of the KPAC from the /opac/login screen, rather
than back to the /opac/home screen, which is the current
behavior, and confuses users of the KPAC when they end
up back in the OPAC after having logged in.

Modified KPAC login code to redirect to KPAC after logging in

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:

Open-ILS/src/templates/kpac/parts/header.tt2

Fix for too-large header sizes causing display issues in KPAC

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Fix for KPAC holdings display issue.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
KPAC 2.7 Upgrade Tweaks

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:

Open-ILS/examples/kpac.xml

Adds B4 Book Log icon and link to KPAC search results page and
KPAC item details page.

(This is a PINES-only customization.)

Adds B4 Book Log icon to KPAC search results page and
KPAC item details page.

Conflicts:
Open-ILS/src/templates/kpac/parts/record_row.tt2
Open-ILS/src/templates/kpac/record.tt2

Updated link to old library map to new library locator map in KPAC.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Improvements to KPAC list display, especially adding
display of list annotations that were not shown.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/src/templates/kpac/parts/record_row.tt2
Open-ILS/src/templates/kpac/results.tt2

Removed added content from the KPAC for now since it doesn't
display properly. Possibly add back in later if we can get
the NoveList content to pull in right.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
KPAC changes in preparation for upgrade:

1. Biggest change was to move the library selector box to the main
search panel instead of on the side - had to modify quite a few files
in order to make this work and pass the values correctly.

2. Also changed the feature icons to use links instead of search terms
to allow more control over search limits and sorting and to see if
caching the searches would improve response speed.

3. A number of smaller UI changes.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
KPAC - Hold results not displaying item title and throwing log error

I believe the path comparison operator in the 'load' subroutine has
a flaw in logic caused by a path-naming problem. The path-matching
function recognizes the kpac/getit_results path as matching positively
for both the load_getit subroutine and the load_getit_results subroutine.

This patch reverses the order in which the matching occurs in an attempt
to resolve the conflict.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
I've redone all of the kpac category links so they no longer use
a link shortener. I also rearranged some of the links so that there
are more options on the home page.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/examples/kpac.xml

Updates to KPAC Features (addition of TumbleBooks)

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Since we only have bits and pieces of Spanish translations for our
customized KPAC right now, removing the parts that would display in
Spanish if Spanish has been selected in the OPAC. In the future when
all parts of the KPAC have been translated and graphic buttons have
been switched to text buttons that can be translated, we will then
need to go back in and re-add the language markup to allow the
translations to occur.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
KPAC Config File: Feature Page Reset

Fresh version of kpac.xml file ready for upgrade to 3.0.

Signed-off-by: McCanna <tmccanna@georgialibraries.org>
KPAC Fix to broken image links

Removes cache info from image links in KPAC because
it was causing links on Dewey page to break.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
KPAC Art and Features for SRP 2018

Signed-off-by: McCanna <tmccanna@georgialibraries.org>
PINES KPAC: Summer Reading 2019 Topics

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
KPAC Update: Remove Tumblebooks Link

GALILEO canceled Tumblebooks, so removing link.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
KPAC Updates: Add E-Read Kids

Add new permanent KPAC icon for E-Read Kids, hide summer reading,
show back to school.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
PINES KPAC: New logo

Updates to incorporate new PINES logo.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Changing the default hold message for when an item is age protected.

adding in gmcharlt's fix for trailing TCN spaces

Conflicts:

Open-ILS/src/perlmods/lib/OpenILS/Application/Cat/BibCommon.pm

adding PINES help links

Conflicts:

Open-ILS/src/templates/opac/parts/login/help.tt2

updating the username/password hints for the opac

Conflicts:

Open-ILS/src/templates/opac/parts/login/form.tt2
Open-ILS/src/templates/opac/parts/login/password_hint.tt2

improving the default hold message for range-protected items

Enabling the display of 856 field URLs for related resources

Password Length Helpers

This branch provides length helpers when patrons are setting or resetting
passwords.

This assumes the default 7 characters, 1 number requirement that comes stock.
You would need to change the hard coded strings if you use a different password
requirement regex in Library Settings Editor.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>

removing journal title and bib call number from query type selector dropdown

Conflicts:

Open-ILS/src/templates/opac/parts/qtype_selector.tt2

Conflicts:
Open-ILS/src/templates/opac/parts/qtype_selector.tt2

removing bib level advanced search filter

Conflicts:

Open-ILS/src/templates/opac/parts/config.tt2

Conflicts:
Open-ILS/src/templates/opac/parts/config.tt2

PINES GALILEO TPAC link and auth redirector

* adds a GALILEO link in the footer template
* adds a new TPAC URL target for /eg/opac/galileo, which redirects the
  user to the GALILEO URL, ensuring the user is first logged in.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Conflicts:
Open-ILS/src/templates/opac/parts/footer.tt2

PINES/GALILEO avoid auth redirect within library

If the physical_loc is set, indicating the patron is physically at a
branch (via IP redirect), link directly to the GALILEO site with no
authentication pass-through.  GALILEO does not requires PINES auth
if the client is coming from a known IP address.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Conflicts:
Open-ILS/src/templates/opac/parts/footer.tt2

Sadly, GALILEO/EBSCO does not use HTTPS, so this will create errors for patrons who authenticate via PINES.  Reverting to HTTP.

LP1752356 Offline Block List Download Date

Amended previous commits by adding the download block list date to
the other reasons why an account could show up on the block list.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Jason Boyer <jboyer@equinoxOLI.org>

LP1752356 Offline expired patrons download date additions

Modify wording to clarify the date displayed is that of the block list
download and not necessarily the date the patron was flagged expired.

Avoid console errors when the file download date is not known -- edge
case where the code is updated but the block list was not updated in the
meantime.

Clean up some debug logging.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Boyer <jboyer@equinoxOLI.org>

LP1752356 Offline block list date addition

In offline mode when checking out for an expired patron, we changed
the error message so that the last date the blocklist was downloaded
is displayed along with the patron barcode

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Boyer <jboyer@equinoxOLI.org>

LP1170795 Stamp Database Update

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP1170795: Void deposits on checkin

Release note

Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Boyer <jboyer@equinoxOLI.org>

LP1170795: Void deposits on checkin

Introduce a library setting circ.void_item_deposit. When set, the money.billing
deposit row will be voided on checkin.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Boyer <jboyer@equinoxOLI.org>

LP#1823983: repeat_delay check removes event definition id filter

This bug has existed since the repeat_delay feature was added, but likely only
rarely was triggered because most events don't have a repeat_delay, and those
that do don't interact with the same target.  However, as more repeatable event
definitions are created, inappropriate interaction becomes more likely.

In this commit we avoid overwriting the whole join condition clause, which
already contains an event definition id filter and needs to retain it.

Included is an unrelated change that uses the new-ish form of
interval_to_seconds that avoids DST boundary shifting issues by passing a
context DateTime object as the second parameter.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1809157 SMS Carriers display not in alphabetical order

This alphabetizes the carrier display when editing the sms carrier in an existing hold.

It also adds the region to the name to make the interface consistent with other interfaces.

To Test:

1. Enable SMS options in the Library Settings.
2. Place a hold for a patron.
3. Use the Edit Notifications Settings.  Enter an SMS number, if needed.
4. Drop-down the Carrier list - the list is not in alphabetical order.
5. Apply the patch and repeat 3-4.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1932051: serialize adding items to bucket from Item Status

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1932051: Batch calls for add items to bucket

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>

LP#1743611 Circ History by Year Info

Adds an info button next to Total Circs in the AngularJS staff
client Item Status screen. Clicking the button displays a
popover list of total circs by year.

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP827356: Stamp Ugrade Script

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

lp827356 new rules protect bre -1, acn -1 and acl 1 as well as marc editing buttons disabled

Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP1931162: Stamp Upgrade Script

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP#1931162: DYM needs some situational optimization

For some data sets and some queries the Did You Mean search suggestion
logic can be much too slow. This is mainly in cases where a "misspelled"
word of sufficient length greater than the symspell prefix length is
checked against many short prefixes that have many long suggestions
attached to them.

This commit optimizes for that case in particular by testing the length
of suggestions and prefix keys against the user input to avoid
unnecessary tests.  Futher, it captures the edit distance of suggestions
that pass that test in-line, avoiding expensive retesting, and caches
the short-cutoff edit distance when in low-verbosity mode to avoid
future different-but-not-too-different suggestions coming from the same
prefix key.

It additionally provides a general optimization by batching the capture
of suggest counts to avoid per-suggestion secondary lookups, and a
micro-optimization of ordering suggestions by length at distance cache
time.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Shula Link <slink@gchrl.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

lp1908439 Auto-override enhancment

This reworks the override action dialogs in the patron display for Check
Out and Items Out, and in the Circulation -> Renew Items interface.  It
exposes the auto-override behavior as checkboxes giving staff more fine
grained control over which events are auto-forced or skipped upon
subsequent encounters.  It also changes the Cancel action for batch
renewals to abort the remaining renewals in the batch, and makes it so
that new authorization credentials provided during such a batch will be
treated as an operator change for the entire batch.  We also fix an
existing bug where events marked as already encountered for
auto-override could leak into other patron contexts via Patron Search.

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Repair missing line in seed data causing build failures

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP#1888723: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1888723: tweak eg-item-location-select

The contextOrgId Input() can now be changed dynamically; doing
so will refresh the list list of shelving locations available
in the drop-down.

Apply this to the distribution formula editor.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Disable special copy statuses in status selector

It is no longer possible to manually move a copy into a special copy
status in the Angular volcopy attributes editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Support disabling select entries in combobox

Adds a new @Input() disableEntries: any[] for tracking identifier
values in the combobox that should be marked as disabled / unselectable.

Substantive updates during rebasing made by Galen Charlton.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Item location select honors context org

The Angular <eg-item-location-select /> component now limits the
locations to display to those within the specified context org unit.

Instead of acting as the source of context org units, the permFilter org
units now act as limiters.  This is done so that users with global
permissions won't by default result in retrieving all copy locations.
In cases where all are needed, however, they can still be retrieved by
setting the context org unit appropriately.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Avoid save warning on vol load; vol save thinko

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Traditional catalog still uses traditional holdings editor

Avoid sending staff to the new holdings editor from within the
traditional catalog, so there remains a way to get to the traditional
editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Remove ref. to nonexistent workstation setting

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Manage mode for single-copy edits notes/tags/alerts

When editing multiple items, always open the Item Alerts/Tags/Notes
dialogs in "manage" mode so users can see and edit existing values on
the edited copy.

In batch copy mode, these dialogs still only allow adding new values.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Angular volcopy Apply All actions

Replace Save and SAve & Exit buttons in the Angular holdings editor with
'Apply All & Save' and 'Apply All, Save & Exit' buttons.  With this,
staff are not required to click Apply on every change.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Merge repairs

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Avoid defaulting CN labels for existing CN's

When a call number is loaded in the editor whose label is an empty
string, avoid applying a default values to the label so it's clear in
the UI that the call number label is blank.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Adds call number edit link to catalog copy table

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Remove no longer needed (click) handler

The holdings Edit link no longer includes a redirect and can be
opened/closed as expected via a regular href (routerLink).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Sort new-volum holding orgs alphabetically

When adding new call numbers to newly represented org units in the
volcopy holdings grid, ensure newly added org units are sorted
alphabetically by the org unit shortname.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Use existing user setting for copy templates

Also propagate the new 'defaults' workstation setting to the seed data
file.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Repair Add Item Alerts action

Adding alerts opens the copy alerts dialog, not the copy notes dialog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Value summaries '1 copy' vs 'x copies'

Add pluralization support to the copy summary counts so that values
linked to only a single copy display as "1 copy" instead of "1 copies"

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Volcopy strings should be global

Moving the <eg-string /> entries to the root of the tepmlate ensures all
references to those strings are defined / non-null.  Otherwise, if the
user opts to hide a field which contained its own strings (e.g. loan
duration), the code would fail on null references, e.g.:

ERROR TypeError: Cannot read property 'text' of undefined

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Copy value counts separation

Provide a small amount of padding and light vertical border for the item
value summary counts so the counts don't blend with longer values (e.g.
long call numbers, etc.)

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Call number modification repair

Fixes an issues where modifying the call number label without modifying
any items would result in modifying the call number for all linked items
instead of the items actually loaded in the volcopy editor.

Also fixes a case where modifying call numbers failed to reflect
correctly in the catalog holdings view.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Detect unapplied changes; improve tab change

1. Detect when a change was initiated for one of the copy attributes,
but not applied during change detection for warning alerts.

2. Improve handling of inter-tab navigation for change alerts.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Improve copy default status lookup

Fixes an issue where a) default copy statuses were not getting correctly
applied and b) the copy status org setting lookup was not correctly
serialized, which can lead to actor drone exhaustion on the server (see
also bug 1896285).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Unsaved changes navigation warning

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Add/Manage item notes from catalog holdings

Adds an entry point for adding and managing Item Notes from the Angular
staff catalog holdings view.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Item notes dialog and volcopy entry point

Support for adding new item notes to one or more items in the copy
editor interface.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Copy tag dialog placeholder fixes

Change the placeholder for the tag label to read 'Enter tag label'.

Modify the 'Select Tag Type' text to 'Select tag type' for consistent
casing.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Volcopy parts on demand; checkdigit preference

Support creating monograph parts on the fly in the Angular holdings
editor.

Create a separate preference for controlling the visibility of the 'Use
Checkdigit' checkbox.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Combobox avoids clearing selected for freetext

Follow-up to LP#1850547: Avoid clearing the selected item in the
combobox when selectedId is set to null in cases where freetext is
enabled and a freetext value is present.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Item attrs edit owning lib change repair

Fixes a thinko in the item update code when changing the owning lib for
an item.  A value must be passed to copy.ischange(...) to have any
effect.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Item attributes editor can now clear stat cats

Correctly implement stat cat copy map deletion in the Angular holdings
editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Angular volcopy UI mods and repairs

* Use plus/minus buttons for adding and removing vols and copies.
* Support adding multiple vols and copies via add-multi pop-over
* Support hiding the Parts column
* Move Generate Barcodes and Use Checkdigit to bottom row.
* Collapse Batch Actions row by default, state stored in preferences.
* Fix issue where loading a record with no holdings would result in a
  mostly image page.
* Various display/layout repairs for showing/hiding columns

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Holdings refresh handles deleted call numbers

Teach the holdings grid in the staff catalog to correctly remove deleted
volumes from its tree when holding are modified in another tab.

To test, in the holding editor, modify a call number to have the same
label as another call number with the same owning org unit and save.  On
the backend, this will result in one of the call numbers getting
deleted.  Confirm the deleted call number no longer appears in the
holdings grid.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Angular holdings broadcast changes

Broadcast to other tabs information about which holdings have changed
during editing in the Angular volcopy UI.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Angular holdings trims barcode spaces

The barcode input form trims leading and trailing spaces from barcodes
in the Angular holdings editor.

Spaces in the middle of the barcode are not removed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Angular holdings from catalog edit link; 1i8n repairs

The 'Edit' link in the copy table within the Angular staff catalog nows
directs users to the Angular volcopy editor.

Remove a number of nested 1i8n declarations.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Angular Holdings Maint / Item Attr Release Notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Angular Holdings Maintenance / Item Attributes Editor

Angular port of the holdings and item attributes editors interfaces.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Angular File exporter service

Package up some of the nitty gritty of supporting file exports from the
Angular client into a utility service.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 combobox down arrow same as click

<eg-combobox /> now treats down arrow as the same as a click operation,
allowing for activation of selectabled options dropdown via keyboard.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Cat vol update API repairs

Repair cases where subs in the volume update API failed to return the
expected response constructs, specifically (response, event).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1888723 Barcode auto-generate API skip-dupes option

Option to verify generated barcodes do not exist in the database.  When
a dupe is found, skip over it and continue to the next barcode.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1906058: Course-term map interface only allow reasonable mappings

Different libraries will use different sets of course terms.  In an
academic library context, for example, a consortium may include
libraries with very different start and end dates to their terms/semesters,
different numbers of terms/year, etc.

This commit changes the interface to only allow users to associate
a course with a term from the same library or one of its ancestors.

To test:
1. Create many courses and course terms and many different OUs.
2. On the course list, click "Terms taught".  Associate some courses
and course terms.  Make sure that you aren't able to associate your
course with any course terms that would not be reasonable for the
course's library.
3. Edit a course, and choose the Course terms tab.  Continue to associate
courses and terms, and make sure the mappings are reasonable.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1917809 Create Course: Owning Library Default

Changes the default for the owning library in the Create Course modal to the logged
in user's workstation org unit instead of the consortium.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Christine Burns <christine.burns@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1905068: (follow-up) never initialize an OU ID to 1

This change has no effect on behavior, as defaultOuId's
initialization value always gets replaced with the user's
WS OU or the org root when the contructor is run, but
avoids any implication during code-reading that the top
of the OU tree can be assumed to have ID 1.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1905068: Add org-family-select to course list

To test:

1) Apply this patch
2) Admin > Local admin > Course reserves list
3) Check that the list defaults to courses available
at your workstation org unit
4) Check that, when you select ancestors, descendants,
or a different org unit, the course list updates
accordingly
5) Check that the list only displays org units for
which you have the MANAGE_RESERVES permission

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1923076: Add Perl live test

Add lp1923076-test-perl-scalar-return.t to the Perl live tests to test
a couple of back end calls affected by the changes in this branch.
These backend calls are those that are easily testable with Concerto
data.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP1923976: Remove some dead code

Remove a block of commented code that was turned up while working on
this issue.  This is in its own commit to make it easier to revert, if
necessary.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP1923076: Add cast to int in more places

Add cast to int of scalar used on arrays in more places where it seems
necessary.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1923076: ensure length of empty array is treated as a number when retrieving hold counts

Thanks to Jason Stephenson for suggesting this solution.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP1935693: Improve spacing on the OPAC course materials table

Signed-off-by; Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Christine Burns <christine.burns@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1935693: Add circulation modifier to course page

Also makes some strings extractable for translation that
were previously missed.

To test:
1) Enable the course materials module
2) Add some courses
3) Add some materials to those courses, using a mix of
circulation modifiers
4) In the OPAC, use the Course Search to search for
your courses
5) Click on the course you created
6) Note that physical items associated with the course
display their circulation modifiers in the circulation
modifier column.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Christine Burns <christine.burns@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1895052: add a release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>