evergreen/bjwebb.git
14 years agoApply a little bit of style to group form elements together in confined spaces
dbs [Fri, 20 Aug 2010 15:41:43 +0000 (15:41 +0000)]
Apply a little bit of style to group form elements together in confined spaces

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17287 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoduring LI creation, adopt the provider of the PO if linked to a PO (and no provider...
erickson [Fri, 20 Aug 2010 15:35:53 +0000 (15:35 +0000)]
during LI creation, adopt the provider of the PO if linked to a PO (and no provider was selected). repair event description copy/paste error

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17286 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agountil distrib formula skip_count is used (and possibly even then), let's hide it...
erickson [Fri, 20 Aug 2010 15:22:03 +0000 (15:22 +0000)]
until distrib formula skip_count is used (and possibly even then), let's hide it from the setup UI

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17285 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agopropagate estimated price to created copy as copy price (aka list price or replacemen...
erickson [Fri, 20 Aug 2010 14:11:27 +0000 (14:11 +0000)]
propagate estimated price to created copy as copy price (aka list price or replacement price); propagate invoiced amount to created copy as copy cost (aka library cost);  caveats and consderations noted in the code.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17284 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agorepair faulty lineitem detachment from invoices
erickson [Fri, 20 Aug 2010 14:11:27 +0000 (14:11 +0000)]
repair faulty lineitem detachment from invoices

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17283 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoHook up the authority management interface to the middle layer
dbs [Fri, 20 Aug 2010 14:01:26 +0000 (14:01 +0000)]
Hook up the authority management interface to the middle layer

For now, uses the first record in the list as the master; we either
need to give users the ability to select the master record at merge
time, or to select it prior to clicking "Merge"

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17282 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAdd the authority record merge middle-layer API (open-ils.cat.authority.records.merge)
dbs [Fri, 20 Aug 2010 13:22:30 +0000 (13:22 +0000)]
Add the authority record merge middle-layer API (open-ils.cat.authority.records.merge)

Also add a pertinent permission (MERGE_AUTH_RECORDS)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17281 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agobug 620899: fix broken test for oils_web.xml
gmc [Fri, 20 Aug 2010 11:25:40 +0000 (11:25 +0000)]
bug 620899: fix broken test for oils_web.xml

Patch from Rick Scott <rick@shadowspar.dyndns.org>

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17280 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoHitting ENTER in the term search box fires off a search now, as you would expect
dbs [Fri, 20 Aug 2010 04:10:07 +0000 (04:10 +0000)]
Hitting ENTER in the term search box fires off a search now, as you would expect

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17279 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoWhen initiating a new authority search, reset the pager to zero to avoid surprises
dbs [Fri, 20 Aug 2010 04:02:44 +0000 (04:02 +0000)]
When initiating a new authority search, reset the pager to zero to avoid surprises

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17278 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAdd a speedbump to the MFHD delete workflow
dbs [Fri, 20 Aug 2010 03:47:46 +0000 (03:47 +0000)]
Add a speedbump to the MFHD delete workflow

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17277 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAdd a speedbump (confirmation dialog) when deleting authority records
dbs [Fri, 20 Aug 2010 03:35:59 +0000 (03:35 +0000)]
Add a speedbump (confirmation dialog) when deleting authority records

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17276 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoGive the Authority List interface the ability to merge records... almost
dbs [Fri, 20 Aug 2010 03:27:04 +0000 (03:27 +0000)]
Give the Authority List interface the ability to merge records... almost

Separate the interface into separate JavaScript vs markup files

To-do:
  * Provide a middle layer method that accepts the array of records to merge and merges them
  * Teach the mergeRecords() to call that method when it exists
  * Provide a way of reordering the records or otherwise flagging which record should be the lead
  * Prevent the same record from being added to the merge slushbox twice

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17275 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agosubmit unified search query on Enter when focused on value widget
erickson [Thu, 19 Aug 2010 22:16:01 +0000 (22:16 +0000)]
submit unified search query on Enter when focused on value widget

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17274 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agomove PO status to top of page for clarity
erickson [Thu, 19 Aug 2010 22:16:01 +0000 (22:16 +0000)]
move PO status to top of page for clarity

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17273 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoClass::DBI::Frozen::301 needs to be forcefully installed on Debian Squeeze
dbs [Thu, 19 Aug 2010 22:11:30 +0000 (22:11 +0000)]
Class::DBI::Frozen::301 needs to be forcefully installed on Debian Squeeze

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17272 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agocirc_modifier codes could be defined, but non-true (i.e. '0'). test for defined...
erickson [Thu, 19 Aug 2010 21:00:30 +0000 (21:00 +0000)]
circ_modifier codes could be defined, but non-true (i.e. '0').  test for defined instead of truthiness when analyzing LID circ modifiers.  repaired (invisible) bug that unnecessarily lead to using circ mod objects instead of codes, depending on context

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17271 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadded util function for printing an html string; use new func for PO printing; ...
erickson [Thu, 19 Aug 2010 20:00:14 +0000 (20:00 +0000)]
added util function for printing an html string;  use new func for PO printing;  TODO, use new func in selfcheck code to reduce duplication

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17270 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoSerials: an alternative batch receiving interface, to support certain
senator [Thu, 19 Aug 2010 18:18:21 +0000 (18:18 +0000)]
Serials: an alternative batch receiving interface, to support certain
heavy-barcoding workflows.

Still needs some things hooked up in the middle layer to create serial.units.
Still needs some configurability.  Access from "Actions for this Record" in
the staff-client-wrapped OPAC for a record with subscriptions and items
attached.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17269 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAcq: make view/place orders open a new tab w/ xul browser wrapped therearound
senator [Thu, 19 Aug 2010 17:35:03 +0000 (17:35 +0000)]
Acq: make view/place orders open a new tab w/ xul browser wrapped therearound

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17268 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoFurther enhancements to the authority list interface
dbs [Thu, 19 Aug 2010 16:51:00 +0000 (16:51 +0000)]
Further enhancements to the authority list interface

  * Offer Next / Previous buttons instead of forcing the number spinner
  * Submit searches onBlur of the search box instead of having to click Submit
  * Accept CGI params so we can kick off a search from other interfaces
  * Factor out the displayRecords() code so we can attach other events to it

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17267 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAdd support to BibTemplate for arbitrary XML chunks (DOM node) via the "xml" construc...
miker [Thu, 19 Aug 2010 15:51:06 +0000 (15:51 +0000)]
Add support to BibTemplate for arbitrary XML chunks (DOM node) via the "xml" constructure param, which disables automatic format-specific fetching.

Add a new module, openils.FeedTemplate which, given:

 * an xml feed (URI or pre-collected DOM node)
 * a dojo.query to pull out items from the feed
 * the DOM node of a template to clone for each item
 * the target DOM node into which it should shove the item-filled template instances

will render a feed of arbitrary xml for you.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17266 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadded missing closing td
erickson [Thu, 19 Aug 2010 15:01:54 +0000 (15:01 +0000)]
added missing closing td

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17265 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agofor consistency, use same 'icons' to indicate PO and PL. don't show PO/PL links...
erickson [Thu, 19 Aug 2010 15:01:53 +0000 (15:01 +0000)]
for consistency, use same 'icons' to indicate PO and PL.  don't show PO/PL links when no such object is linked to the lineitem

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17264 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoautomatically create lineitem assets (i.e. load bibs and items) during po activation...
erickson [Thu, 19 Aug 2010 14:22:28 +0000 (14:22 +0000)]
automatically create lineitem assets (i.e. load bibs and items) during po activation when necessary since activation requires it;  only do this during non-dry-run calls

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17263 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadded clear_marc to po li retrieval to cut down network; mild code cleanup
erickson [Thu, 19 Aug 2010 14:22:27 +0000 (14:22 +0000)]
added clear_marc to po li retrieval to cut down network; mild code cleanup

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17262 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agodowngraded a debug log message from error() to debug()
erickson [Thu, 19 Aug 2010 14:22:26 +0000 (14:22 +0000)]
downgraded a debug log message from error() to debug()

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17261 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoGive the authority list interface a place on the staff client Cataloging menu
dbs [Thu, 19 Aug 2010 13:57:07 +0000 (13:57 +0000)]
Give the authority list interface a place on the staff client Cataloging menu

The interface itself still needs usability love, but exposing basic edit/delete
functionality for authority records should give authoritarians some level of
happiness.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17260 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoFix some defects in the first iteration of the authority edit/delete interface
dbs [Thu, 19 Aug 2010 04:47:53 +0000 (04:47 +0000)]
Fix some defects in the first iteration of the authority edit/delete interface

  * Ensure that the correct ID is assigned to the edit/delete request
  * Prevent caching of results so that when a record is deleted, we don't continue to see it

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17259 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoDon't show deleted authority records in startwith browse, either
dbs [Thu, 19 Aug 2010 03:47:35 +0000 (03:47 +0000)]
Don't show deleted authority records in startwith browse, either

Also restore the >= operator that was stomped in r17257

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17258 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoDon't return deleted authority records in a browse list
dbs [Thu, 19 Aug 2010 03:35:53 +0000 (03:35 +0000)]
Don't return deleted authority records in a browse list

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17257 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoForgot to set the open-ils.pcrud controller for are in r17255
dbs [Thu, 19 Aug 2010 01:26:33 +0000 (01:26 +0000)]
Forgot to set the open-ils.pcrud controller for are in r17255

And making the new perm section tab-consistent while I'm at it

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17256 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAdd basic authority browse/edit/delete interface
dbs [Thu, 19 Aug 2010 01:24:03 +0000 (01:24 +0000)]
Add basic authority browse/edit/delete interface

http://localhost/eg/cat/authority/list should get you where you need to be

The paging is comical, the JS should probably be split out from the
declarative markup, the interface needs i18n, the UI needs to become
usable - but at least we have exposed some functionality for working
with authority records now.

Ideally this becomes a widget that we can just embed into other
interfaces to maintain context (which suggests using openils.cgi
to seed the initial values of the widget).

Note that the delete function works - it sets the deleted flag for
an are to "true" - but the underlying authorities browse interface
currently doesn't care about such niceties and always returns deleted
records along with undeleted records. So that might be the next stop.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17255 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agomoney_open_user_summary may not exist if the user has no transactions to summarize...
erickson [Wed, 18 Aug 2010 18:08:17 +0000 (18:08 +0000)]
money_open_user_summary may not exist if the user has no transactions to summarize.  protect against null summary object

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17253 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoprovide an explicit import() sub to collect the boostrap config name at import. ...
erickson [Wed, 18 Aug 2010 17:40:16 +0000 (17:40 +0000)]
provide an explicit import() sub to collect the boostrap config name at import.  force child_init to run (once) if not run by Apache

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17250 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoOnly Debian Squeeze currently packages MARC::Record > 2.0.1
dbs [Wed, 18 Aug 2010 17:39:34 +0000 (17:39 +0000)]
Only Debian Squeeze currently packages MARC::Record > 2.0.1

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17249 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoFixup ctx.page_title and script type declarations
atz [Wed, 18 Aug 2010 16:48:28 +0000 (16:48 +0000)]
Fixup ctx.page_title and script type declarations

Some had ctc.page_title, another had page_titel, but most didn't have any.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17248 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoso, some datasets have records with multiple 245a subfields. yeah, really.
miker [Wed, 18 Aug 2010 16:33:47 +0000 (16:33 +0000)]
so, some datasets have records with multiple 245a subfields. yeah, really.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17244 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoso, some datasets have records with multiple 245a subfields. yeah, really.
miker [Wed, 18 Aug 2010 16:33:21 +0000 (16:33 +0000)]
so, some datasets have records with multiple 245a subfields. yeah, really.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17243 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoGive authority records an XML-valid XML formats list
dbs [Wed, 18 Aug 2010 16:00:41 +0000 (16:00 +0000)]
Give authority records an XML-valid XML formats list

Still need to trim the actual list of formats for authority records,
as marcxml-full and marcxml-uris get listed, and those do not work
or make sense for authority records.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17242 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agosome defensive coding. TODO: disable actions in Holds list interfaces that affects...
phasefx [Wed, 18 Aug 2010 15:57:24 +0000 (15:57 +0000)]
some defensive coding.  TODO: disable actions in Holds list interfaces that affects items when the selected holds have no Current Copy

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17241 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoFedora packages perl-MARC-Record at 2.0.0, but 2.0.1 is required
dbs [Wed, 18 Aug 2010 15:53:10 +0000 (15:53 +0000)]
Fedora packages perl-MARC-Record at 2.0.0, but 2.0.1 is required

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17240 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoFix closing </tr> tags
atz [Wed, 18 Aug 2010 15:33:42 +0000 (15:33 +0000)]
Fix closing </tr> tags

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17239 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoDescriptive notes in interface
atz [Wed, 18 Aug 2010 15:33:41 +0000 (15:33 +0000)]
Descriptive notes in interface

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17238 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agothinko here was throwing off the tallies for checked_out.count
phasefx [Wed, 18 Aug 2010 15:30:44 +0000 (15:30 +0000)]
thinko here was throwing off the tallies for checked_out.count

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17237 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoCreate indexes on some Vandelay tables to speed up retrieval and delete operations
dbs [Wed, 18 Aug 2010 02:09:17 +0000 (02:09 +0000)]
Create indexes on some Vandelay tables to speed up retrieval and delete operations

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17236 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoTell developers that they need to install Dojo
dbs [Tue, 17 Aug 2010 22:30:43 +0000 (22:30 +0000)]
Tell developers that they need to install Dojo

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17235 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoMove to CSS-based styling of validated vs. unvalidated fields
dbs [Tue, 17 Aug 2010 22:06:12 +0000 (22:06 +0000)]
Move to CSS-based styling of validated vs. unvalidated fields

This sets the stage for differentiating between validated fields that
match authority records, and validated fields with a controlling $0
subfield that match an authority record. This also gives sites a bit
of an easier entry point to customize their MARC editor - say, for example,
to support accessibility requirements if red vs. black doesn't satisfy
the needs of those who are colour-blind.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17234 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoFix typo in i18n Makefile that afflicted install
dbs [Tue, 17 Aug 2010 20:52:19 +0000 (20:52 +0000)]
Fix typo in i18n Makefile that afflicted install

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17233 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agolibbusiness-creditcard-perl is installed with DEBS. removing from squeeze-specific...
erickson [Tue, 17 Aug 2010 16:28:54 +0000 (16:28 +0000)]
libbusiness-creditcard-perl is installed with DEBS.  removing from squeeze-specific debs.  make sure we install the EXTRA_DEBS_SQUEEZE as part of install_extra_debs_squeeze

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17231 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agopatch from Ben Ostrowsky to help clarify the CREATE_MARC and IMPORT_MARC permissions...
erickson [Mon, 16 Aug 2010 18:48:23 +0000 (18:48 +0000)]
patch from Ben Ostrowsky to help clarify the CREATE_MARC and IMPORT_MARC permissions descriptions

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17230 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoui.circ.suppress_checkin_popups disables dialog prompts during check-in, but in the...
phasefx [Mon, 16 Aug 2010 18:44:08 +0000 (18:44 +0000)]
ui.circ.suppress_checkin_popups disables dialog prompts during check-in, but in the case print slip dialogs, it should still print the slips if the Auto-Print Hold and Transit Slips checkbox is toggled on (the action is still occuring).  However, only the dedicated Check-In interface had such a checkbox, and if you were to check-in from Item Status or Items Out with that org unit setting active, you'd have no option to print any slips associated with the check-in.  This fixes all that

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17229 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoforwardport of 17216, org hiding depth in opac
phasefx [Mon, 16 Aug 2010 17:41:54 +0000 (17:41 +0000)]
forwardport of 17216, org hiding depth in opac

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17228 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years ago0372 - acq.edi_message.vendacct
atz [Mon, 16 Aug 2010 16:23:41 +0000 (16:23 +0000)]
0372 - acq.edi_message.vendacct

Needed for some but not all vendors (separate from SAN).

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17227 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoredundant refresh() can cause duplicate rows in list. Also, perm failure is an ...
phasefx [Mon, 16 Aug 2010 13:53:09 +0000 (13:53 +0000)]
redundant refresh() can cause duplicate rows in list.  Also, perm failure is an "expected" error here, so we can skip the skull and crossbones if folks without the permission cancel the Void All Billings action

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17226 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agotsbere pointed out this typo
phasefx [Mon, 16 Aug 2010 13:31:05 +0000 (13:31 +0000)]
tsbere pointed out this typo

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17225 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoDisable Replace Barcode button for new patrons, and disable the barcode field for...
phasefx [Mon, 16 Aug 2010 13:14:41 +0000 (13:14 +0000)]
Disable Replace Barcode button for new patrons, and disable the barcode field for existing patrons.  If Replace Barcode is activated, then enable the barcode field, give it focus, and disable the Replace Barcode button.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17224 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoPedantic changes for const-correctness:
scottmk [Sun, 15 Aug 2010 02:27:01 +0000 (02:27 +0000)]
Pedantic changes for const-correctness:

1. Add the const qualifier to most of the parameters of SELECT().

2. In almost all cases: replace calls to jsonObjectGetKey() with
calls to jsonObjectGetKeyConst().  A couple of calls remain that
would be more trouble to replace than they're likely to be worth.

M    Open-ILS/src/c-apps/oils_sql.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17223 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoPedantic change for const-correctness: replaced two calls to
scottmk [Sun, 15 Aug 2010 01:11:41 +0000 (01:11 +0000)]
Pedantic change for const-correctness: replaced two calls to
jsonObjectGetKey() with calls to jsonObjectGetKeyConst().

M    Open-ILS/src/c-apps/test_json_query.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17222 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoPedantic change for const-correctness: replaced a call to
scottmk [Sun, 15 Aug 2010 00:27:08 +0000 (00:27 +0000)]
Pedantic change for const-correctness: replaced a call to
jsonObjectGetKey() with a call to jsonObjectGetKeyConst().

M    Open-ILS/src/c-apps/oils_auth.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17221 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoPedantic change for const-correctness: changed three calls to
scottmk [Sat, 14 Aug 2010 21:55:50 +0000 (21:55 +0000)]
Pedantic change for const-correctness: changed three calls to
jsonObjectGetKey() to call jsonObjectGetKeyConst() instead.

M    Open-ILS/src/c-apps/oils_utils.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17220 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agomerge seials-integration [sic] branch into trunk
senator [Fri, 13 Aug 2010 18:15:46 +0000 (18:15 +0000)]
merge seials-integration [sic] branch into trunk

Dan Wells has provided tremendous efforts in developing a user interface
and middle-layer logic for controlling serials.  His work builds on the
serial schema hashed out earlier in the year, also with his heavy involvement,
and it provides ways to manage subscriptions, distribution, prediction,
receiving and more.  Although this code is but a beginning, much of it
is functional today.

This commit brings Dan's work into trunk.  Dan has provided some release
notes here: http://www.open-ils.org/dokuwiki/doku.php?id=acq:serials:release_notes:initial_trunk_merge

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17215 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAdd Debian Squeeze prereq support, drop out-of-date items
dbs [Fri, 13 Aug 2010 17:57:54 +0000 (17:57 +0000)]
Add Debian Squeeze prereq support, drop out-of-date items

  * Drop Debian Etch ("Security updates have been discontinued as of the end of February 2010.")
  * Drop PostgreSQL server packages pre-8.4 as they are no longer supported

TODO: To continue to support Ubuntu Hardy and Debian Lenny, we'll need to
start pulling in backports of postgresql-8.4.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17214 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agomeant to hide these Find in Page buttons
phasefx [Fri, 13 Aug 2010 14:50:30 +0000 (14:50 +0000)]
meant to hide these Find in Page buttons

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17213 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agogo ahead and expose the Find in Page functionality, but hide it under the Debug label...
phasefx [Fri, 13 Aug 2010 14:48:15 +0000 (14:48 +0000)]
go ahead and expose the Find in Page functionality, but hide it under the Debug label for now.  Other than being incomplete (no Find Next, etc.), the main problem I see are our dynamic dojo interfaces where the text one might be tempted to search for won't actually be rendered yet on the screen (say in a scrolling list)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17212 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoplaying around with Find in Page functionality; the recent dojo highlighter commit...
phasefx [Fri, 13 Aug 2010 14:48:01 +0000 (14:48 +0000)]
playing around with Find in Page functionality; the recent dojo highlighter commit prompted me to share this

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17211 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agorepaired class name typo (thanks dbs). made args more generally useable
erickson [Fri, 13 Aug 2010 12:25:56 +0000 (12:25 +0000)]
repaired class name typo (thanks dbs).  made args more generally useable

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17210 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agospawn external text editor for Patron Letter during Mark Item Missing Pieces workflow...
phasefx [Fri, 13 Aug 2010 08:18:42 +0000 (08:18 +0000)]
spawn external text editor for Patron Letter during Mark Item Missing Pieces workflow.  Put configuration option under Admin -> Local System Administration -> External Text Editor Command

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17209 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadd standing penalty prompt to Mark Item Missing Pieces workflow
phasefx [Fri, 13 Aug 2010 08:17:45 +0000 (08:17 +0000)]
add standing penalty prompt to Mark Item Missing Pieces workflow

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17208 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadd title to item notes window and an accesskey for closing the window. Spawn the...
phasefx [Fri, 13 Aug 2010 08:17:36 +0000 (08:17 +0000)]
add title to item notes window and an accesskey for closing the window.  Spawn the item note window during the Mark Item Missing Pieces workflow

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17207 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agofix cut-n-paste-o
miker [Fri, 13 Aug 2010 04:07:48 +0000 (04:07 +0000)]
fix cut-n-paste-o

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17206 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoDOM text/pattern highlighter
erickson [Fri, 13 Aug 2010 03:49:35 +0000 (03:49 +0000)]
DOM text/pattern highlighter

openils.Util.hilightNode(
    node,
    [pattern1, pattern2, ...],
    {classname:foo}
);

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17205 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agochange the (Copy) link next to addresses in the patron summary to (Copy/Print), with...
phasefx [Fri, 13 Aug 2010 02:39:49 +0000 (02:39 +0000)]
change the (Copy) link next to addresses in the patron summary to (Copy/Print), with a popup menu for choosing which action to do

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17204 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoprotect authority linking trigger against broken $0 values
miker [Fri, 13 Aug 2010 00:58:26 +0000 (00:58 +0000)]
protect authority linking trigger against broken $0 values

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17203 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAllow * in file portion of pathname
atz [Thu, 12 Aug 2010 19:49:53 +0000 (19:49 +0000)]
Allow * in file portion of pathname

Example:
    incoming/*.xpo => incoming/yegagufoNy.xpo

You cannot put an asterisk in the path portion of the string, however,
since that would mean the target directory was not determined.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17201 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agore-label recv_date as 'Invoice Date' to avoid confusion around the 'receive date...
erickson [Thu, 12 Aug 2010 18:54:25 +0000 (18:54 +0000)]
re-label recv_date as 'Invoice Date' to avoid confusion around the 'receive date' of constituent physical items

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17200 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoyet more auto-scrolling to stamp out
erickson [Thu, 12 Aug 2010 18:53:24 +0000 (18:53 +0000)]
yet more auto-scrolling to stamp out

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17199 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoyet more auto-scrolling to stamp out
phasefx [Thu, 12 Aug 2010 16:07:55 +0000 (16:07 +0000)]
yet more auto-scrolling to stamp out

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17189 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoyet more auto-scrolling to stamp out
phasefx [Thu, 12 Aug 2010 16:03:29 +0000 (16:03 +0000)]
yet more auto-scrolling to stamp out

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17188 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agocreated batch/streaming versions of hold placement and possibility check calls: open...
erickson [Thu, 12 Aug 2010 13:33:31 +0000 (13:33 +0000)]
created batch/streaming versions of hold placement and possibility check calls: open-ils.circ.holds.create[.override].batch and open-ils.circ.title_hold.is_possible.batch.  Arguments are the same as non-batch, just delivered as an array; responses are delivered in order inbound params

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17186 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoavoid confusion by not installing the non-functional GenerateBatchOverduePDF reactor...
erickson [Thu, 12 Aug 2010 12:57:13 +0000 (12:57 +0000)]
avoid confusion by not installing the non-functional GenerateBatchOverduePDF reactor with the seed data.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17185 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoRemove broken old JavaScript in Google Book preview code
dbs [Thu, 12 Aug 2010 07:42:20 +0000 (07:42 +0000)]
Remove broken old JavaScript in Google Book preview code

I /think/ this was supposed to change the title of the "Preview" link to
"Read this online" or the like in the case that the full text is available,
but it was relying on a function that didn't exist (setText) and trying
to reference an ID that didn't exists. So it broke in those rare cases
where Google Books did provide the full text.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17181 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoComplain when a sequence name is not qualified by a schema.
scottmk [Thu, 12 Aug 2010 03:22:10 +0000 (03:22 +0000)]
Complain when a sequence name is not qualified by a schema.

M    Open-ILS/src/c-apps/idlval.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17180 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoregister the autoloader earlier, and log about the use it gets
miker [Thu, 12 Aug 2010 01:23:58 +0000 (01:23 +0000)]
register the autoloader earlier, and log about the use it gets

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17179 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoPlug some memory leaks.
scottmk [Wed, 11 Aug 2010 20:59:25 +0000 (20:59 +0000)]
Plug some memory leaks.

In many places we were creating dbi_results without freeing them;
pretty much everything involving transactions, savepoints,
inserts, updates, and deletes.

M    Open-ILS/src/c-apps/oils_sql.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17177 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoGave the base login code the ability to find username/password from a
erickson [Wed, 11 Aug 2010 20:42:07 +0000 (20:42 +0000)]
Gave the base login code the ability to find username/password from a
cookie.  for security reasons, we don't put login data into cookies, but if the
login info is available to us in that format already (say, via external means), we'll
use it.  This can be useful for persistent logins (e.g. self-check) or
automatic logins (pushing cookie data out to workstations)

Minor cleanup of the login code to make it more re-use friendly.

Added self-check support for verifying the staff login before each patron
login.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17176 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoredundant with util_overlay.xul
phasefx [Wed, 11 Aug 2010 20:40:07 +0000 (20:40 +0000)]
redundant with util_overlay.xul

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17175 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoUse a COALESCE/NULLIF nested structure instead of CASE (one branch, easy peasy) for...
miker [Wed, 11 Aug 2010 20:18:26 +0000 (20:18 +0000)]
Use a COALESCE/NULLIF nested structure instead of CASE (one branch, easy peasy) for 4x speedup in the core search query

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17174 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoRespect activate_po option in interface
atz [Wed, 11 Aug 2010 15:57:14 +0000 (15:57 +0000)]
Respect activate_po option in interface

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17171 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAdd page title and tidy up
atz [Wed, 11 Aug 2010 15:57:13 +0000 (15:57 +0000)]
Add page title and tidy up

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17170 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agomissed one fix in previous optimisation effort
miker [Wed, 11 Aug 2010 13:29:31 +0000 (13:29 +0000)]
missed one fix in previous optimisation effort

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17169 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agotweak the layout for the volume/copy creator so that buttons/etc are always on-screen...
phasefx [Wed, 11 Aug 2010 06:44:42 +0000 (06:44 +0000)]
tweak the layout for the volume/copy creator so that buttons/etc are always on-screen, with just the input textboxes in the scrollable area

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17168 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agochange Check Barcodes? checkbox in Volume/Item creator to Use Checkdigit. In additio...
phasefx [Wed, 11 Aug 2010 06:33:37 +0000 (06:33 +0000)]
change Check Barcodes? checkbox in Volume/Item creator to Use Checkdigit.  In addition to checking the barcodes, it also dictates whether the Auto-Generate Barcodes function will use checkdigits or not

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17167 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agotweak auto-barcode method to support barcodes of arbitrary length. trims last digit...
phasefx [Wed, 11 Aug 2010 06:33:34 +0000 (06:33 +0000)]
tweak auto-barcode method to support barcodes of arbitrary length.  trims last digit from seed barcode if 9 or 14 digits.  works with alphanumeric barcodes like b1, test1, demo1 with no checkdigits (so it'll generate demo2, demo3, etc.)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17166 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadded an UI for editing vandelay import item attribute definitions. it's a basic...
erickson [Wed, 11 Aug 2010 02:18:47 +0000 (02:18 +0000)]
added an UI for editing vandelay import item attribute definitions.  it's a basic autogrid version for now.  TODO: fix some grid height styling issues

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17165 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAcq: fix certain dialogs needlessly flashing on-screen while li_table loads
senator [Tue, 10 Aug 2010 21:12:56 +0000 (21:12 +0000)]
Acq: fix certain dialogs needlessly flashing on-screen while li_table loads

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17161 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agobug 592777: allow authoritative version of open-ils.circ.retrieve
gmc [Tue, 10 Aug 2010 21:10:53 +0000 (21:10 +0000)]
bug 592777: allow authoritative version of open-ils.circ.retrieve

Part of a fix to avoid race condition that can occur
when patron renews an item in the OPAC in a database
that uses pgpool and replication, which sometimes
results in an erroneous 'action_circulation_not_found' error.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17160 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agouse staff query for lineitem->bib linking ui
erickson [Tue, 10 Aug 2010 18:31:33 +0000 (18:31 +0000)]
use staff query for lineitem->bib linking ui

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17158 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agofix age protection proximity test for in-DB circ
gmc [Tue, 10 Aug 2010 18:23:26 +0000 (18:23 +0000)]
fix age protection proximity test for in-DB circ

Patch from John Craig.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17153 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoTwo things: 1) match old output, with rows for no holdings 2) calculate transcendance...
miker [Tue, 10 Aug 2010 17:18:06 +0000 (17:18 +0000)]
Two things: 1) match old output, with rows for no holdings 2) calculate transcendance only once per function call

git-svn-id: svn://svn.open-ils.org/ILS/trunk@17152 dcc99617-32d9-48b4-a31d-7c20da2025e4