fix IP redirection by pulling the X-Real-IP header

PINES Customization: Hide Claims Never Checked Out Action

On the patron account's Items Out screen, hide the
Mark Claims Never Checked Out action since we do not use
it in PINES and there is no associated permission to prevent
it from working.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Temp Fix for Patron Account Expiring Soon Message

Marked as temp fix for testing before packaging for submission
to launchpad bug 1726918.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES Customization: Set default damaged billing type

This sets the default billing type when marking an item damaged to
'Damaged Materials' which is ID 106 in our database.

Signed-off-by: McCanna <tmccanna@georgialibraries.org>

PINES Customization: Require patron identification

Requires something to be entered in the ID value field

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES Cust: Reset Patron Search Form with Defaults

Change code to refresh page instead of clearing individual fields,
which resets fields to the defaults we want (inactive checked and
org unit to consortium).

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES Customization: Hide Barred Checkbox on New Patron Reg

Hide the barred checkbox when creating a new patron account because
it is unnecessary. Display it only when editing accounts.

Signed-off-by: McCanna <tmccanna@georgialibraries.org>

Fix for PINES-Specific Holdings Sort Order

See Tom Berezansky's original fix at:
http://git.evergreen-ils.org/?p=evergreen/pines.git;a=commit;h=adc566e152d10796b73c992a16ae46e69cc3ab77

Some changes to the base code required this fix to be updated.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

remove offline blocked list download button

adding PINES PO file

Staff Client Customization: Browser Tab Naming

Changed tab names from Evergreen Staff XXX to PINES: XXX

Signed-off-by: McCanna <tmccanna@georgialibraries.org>

Staff Client Customization: Backdate Checkin Alert

Makes onscreen checkin alert more obvious.

Signed-off-by: McCanna <tmccanna@georgialibraries.org>

Staff Client Customization: Change Wording on PreCat Form

Change 'ISBN' to 'Call Number' on field label.

Signed-off-by: McCanna <tmccanna@georgialibraries.org>

Staff Client Customization: Hide Delete Patrons Button

Hide Delete Patrons button from user buckets (function was
not allowed by permissions, so no need to even show it).

Signed-off-by: McCanna <tmccanna@georgialibraries.org>

Staff Client Customization: Patron Registration Form Tweaks

- Fixed alignment of checkboxes.
- Hid Claims returned on new patron registration form.
- Hid Claims never checked out.
- Made survey drop 'up' instead of dropdown so it
  doesn't disappear off of page.

Signed-off-by: McCanna <tmccanna@georgialibraries.org>

PINES Customization: Add IMLS logo to footer

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Add Invoice Summary Reporting View.

Before now, there have been no easy ways to gather acq
receiving totals from reports.  Here is an attempt to remedy
that situation.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Driver's license guidelines
Added on-screen tip to remind staff how driver's licenses should be
entered in PINES.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

OPAC Updates related to page text and translations. Also required are the
en-PINES.po custom text file and the es-ES.po translation file.

Language - here are three files I missed including in the prior
collection of translation-related files.

Language files - a few more corrections.

Changing hard-coded string to allow locale to work.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/src/templates/opac/parts/advanced/search.tt2
Open-ILS/src/templates/opac/parts/pref_lib_display.tt2

Addition of new item format icon for direct audio (ie, Playaways and
similar items that are pre-loaded with audiobooks and do not require
access to a computer to use).

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

adding login redirection page

Adding PINES-ified notification wordings.

Images for new "no image available" functionality.

Lines 94-104 in eg_vhost.conf need to be un-commented.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Make users_of_interest test for defined actor.usr.card values

If the open-ils.collections.users_of_interest API encounters a patron that
has a null "card" value in actor.usr the API will crash with an error like:

Received Exception:
Name: osrfMethodException
Status:  *** Call to [open-ils.collections.users_of_interest.retrieve] failed for session [1416515351.333446.1416515351406], thread trace [1]:
Can't call method "barcode" on an undefined value at /usr/local/share/perl/5.14.2/OpenILS/Application/Collections.pm line 299.

This patches users_of_interest to be sure that the user has a defined value
for actor.usr.card before proceeding to pull out the barcode for the results
of the API call.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Collections.pm

adding in gmcharlt's fix for trailing TCN spaces

Conflicts:

Open-ILS/src/perlmods/lib/OpenILS/Application/Cat/BibCommon.pm

PINES GALILEO TPAC link and auth redirector

* adds a GALILEO link in the footer template
* adds a new TPAC URL target for /eg/opac/galileo, which redirects the
  user to the GALILEO URL, ensuring the user is first logged in.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Conflicts:
Open-ILS/src/templates/opac/parts/footer.tt2

PINES/GALILEO avoid auth redirect within library

If the physical_loc is set, indicating the patron is physically at a
branch (via IP redirect), link directly to the GALILEO site with no
authentication pass-through.  GALILEO does not requires PINES auth
if the client is coming from a known IP address.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Conflicts:
Open-ILS/src/templates/opac/parts/footer.tt2

Sadly, GALILEO/EBSCO does not use HTTPS, so this will create errors for patrons who authenticate via PINES.  Reverting to HTTP.

add report creator

update version stamps and ChangeLog

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

more updates to the server upgrade

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

update upgrade instructions for 3.10.0

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

update release notes for 3.10.0

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

update schema update script

- tag for 3.10.0
- add back reingest at the end

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Don't reingest in the middle of the upgrade transaction

Based on Galen's commit ec7d57f880c5bc7f67f156d31dcec78d5c50e21c

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

Check in cs-CZ translations from POeditor

Bumping version numbers, adding Upgrade Script and Changelog

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

Server upgrade docs for 3.10-rc

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

bumping Perl version string for 3.10

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

Translation updates - po files

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

Translation updates - newpot

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

Edited Release Notes

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

3.10 Release Notes

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1864507: (follow-up) another fix to the schema update

Fixing a syntax error to the reingest step this time.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1755876: Add progress bar when renewing items

Signed-off-by: Jessica Woolford <jwoolford@biblio.org>
Signed-off-by: Susan Morrison <smorrison@georgialibraries.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP#1989133: Bootstrap physical description display error.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1995032 follow-up: syntax correction

Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1895675 Bootstrap OPAC: Add notification method testing to My Account

This adds the work done in the TPAC for LP1777677 to the Bootstrap OPAC.
A test email button is added to My Account > Preferences, and a test
text message button is added to My Account > Preferences > Notification
Preferences.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Christine Burns <christine.burns@bc.libraries.coop>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1972928: Show course user role dropdown choices without typing

To test:
1. Go to Admin > Local Admin > Course List
2. Choose a course
3. Go to the Course users tab
4. Activate the Role dropdown.
5. Note that no options appear.
6. Apply the patch
7. Repeat steps 1-5
8. Note that the role options appear when you activate the dropdown now

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>

lp1856097 stamp and small fixes to upgrade script

Don't apply the upgrade if it would overwrite existing customizations
to the description, also add a missing semicolon.

Signed-off-by: Jane Sandberg <js7389@princeton.edu>

lp1856097 Tide Default Classification Scheme Description

- With the updates in lp1839341, the description in the YAOUS for
Default Classification Scheme is incorrect. It prompts for a number:
1, 2, or 3. The Angular Settings Editor now displays a verbose
dropdown. The description has been updated accordingly.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/sql/Pg/950.data.seed-values.sql
new file:   Open-ILS/src/sql/Pg/upgrade/XXXX.data.default_classification-description-update.sql

Signed-off-by: Susan Morrison <smorrison@georgialibraries.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1995032 Add empty alt text to decorative icons

Adds alt="" to alert dialog icons in patron circulation screens.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1824709: Allow comboboxes inputs to have IDs

This adds a new input, domId, for the combobox component.

A good way to test:

1) Download the Wave accessibility checker.
2) Go to one of the following screens:
  - Admin > Local > Course Reserves > Choose a course > Associate
    item from catalog
  - Admin > Local > Course Reserves > Choose a course > Associate
    brief record
  - MARC Batch Import
  - MARC Batch Import/Export > Inspect Queue
  - Staff Catalog Add to bucket
  - Staff catalog conjoined items
  - Hold cancel dialog
3) Right click and select "WAVE this page"
4) On the Details tab of WAVE, notice that there are several "Missing
   form label" errors.
5) Apply this patch.
6) Run WAVE again; notice that the number of missing form label errors
   has decreased.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Garry Collum <gcollum@gmail.com>

LP1993859 Keyboard tabbing for results pagination

In the staff catalog search results pagination component, adds
tabindex="0" to link tags without href attributes to enable keyboard
navigation.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
Signed-off-by: Christine Burns <christine.burns@bc.libraries.coop>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1994159 Higher contrast H2s

The Evergreen logo color used for H2s, including the card headers on the
staff splash page, doesn't pass color contrast checks. I've also removed
the underlines, as those should be used only for links.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

Add another entry for Jason Stephenson to mailmap

Signed-off-by: Jason Stephenson <jstephenson@cwmars.org>

LP#1864507: (follow-up) fix another error in the 1344 schema update

The normalizer is already present, so trying to add it again
breaks the update.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

forward-port 3.9.0-3.9.1 update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

fix version stamp in 1341 update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

add additional fixes in 3.9.1 to release notes

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

docs: release notes 3.9.1 and 3.8.2

Author: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Author: Jennifer Weston <jennifer.weston@equinoxoli.org>
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

check in latest cs-CZ strings for the Angular staff client

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1982887: (follow-up) set l10n list back to en-US

This works around an issue where the Angular staff client's
navbar langauge selector selects all provided locales, but
that can break things without additional configuration.

To enable the Czech translation, edit

Open-ILS/src/eg2/src/environments/environment.prod.ts

to add 'cs-CZ' to the list of locales, then rebuild the
Angular app using

ng build --configuration=production

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1982887: Repair translations for eg2 client

Previously following the build instructions for the Czech localization
placed the results in eg2/cs-CZ/cs-CZ and also broke the en-US build.
These changes bring the staff client a little more in line with current
Angular localization methods.

Note that currently both en-US and cs-CZ are always built. This can be
limited to en-US by using "--localize false" on the ng build command line.
Until an alternative method to determine the number of available locales is
implemented the only way to hide the locale selector is to edit environment.prod.ts.

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Linda Jansova <skolkova@chello.cz>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1954681 - Add Release Notes

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP#1954681 Individual overrides when placing multiple holds

This adds an override all button above the override column if
there are multiple overridable holds (Angular Staff Catalog).

To test:
1. Ensure staff has permission to CREATE_DUPLICATE_HOLDS
   and HOLD_ITEM_CHECKED_OUT.override
2. Set org setting for Maximum number of duplicate holds allowed
   to a value greater than 1
3. Check out an item to a patron
4. Try to place a hold on that item with Number of copies set
   to a value greater than 1
5. Test that the Override All button appears and works

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1829418 release notes

Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1829418 OPAC-Visible Stat Cats Not Visible

This adds patron and item statistical categories to the Bootstrap OPAC.

OPAC-visible patron stat cats will appear in My Account > Preferences >
Personal Information as new rows below the Account Expiration Date.

OPAC-visible item stat cats will appear below Copy Notes in the copy table
on the record details page.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1859701 - Stamping upgrade script

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1859701: remove unused imports

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1859701 follow-up fixes for Cash Report

  * restore totals to area outside of grid
  * add Debit Card Payments
  * relabel Credit Payment to Patron Credit Payment in outside-grid area
  * relabel User Payments to Staff User Payments in outside-grid area
  * relabel "patron" columns in Staff User Payments grid to "staff"

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1859701 Cash reports inline patron info

Display patron info in the User Payments grid inline with the grid
instead of requiring an additional click to open a separate dialog.

Make patron barcode a link so the patron can be opened in a new tab.

Adds grid prefs workstation settings.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1859701 Cash Reports Tidying

* Avoid manual currency data formatting when it can happen in the template.
* Replace ngbTab with ngbNav.  ngbTab is deprecated.
* Tweak date filter form layout to fix some obscured fields.
* Remove no longer needed view child static specifiers
* Use 2-space "tabs" in HTML consistent w/ other angular components.
* Remove unused code / css styles
* ng lint

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1859701 fix routing from admin page

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1859701 release note

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1859701 replace "totals" row in each grid with a totals section above each grid

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1859701 Cash Reports

Migrating the DOJO UI for Cash Reports into
Angular. The disabling of the different orgs
is dependent on bug #1863168.

Signed-off-by: Zavier Banks <zbanks@catalyte.io>
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1983991 release notes

Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1983991 handle when IN list empty

Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1983991 Allow display of source address and source location on transit slips

Added source address and source location information to transit slip & hold transit slip print template documentation.

Signed-off-by: Llewellyn Marshall <llewellyn.marshall@ncdcr.gov>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1966342 follow-up: prefer === over ==

Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP#1966342: (follow-up) adjust for color contrast

The default Bootstrap text-light color on a bg-info background
fails the WCAG color contrast ratio; letting the text default
to black meets level AA.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1966342 Highlight Zero Holdings in Staff Catalog

This highlights the holdings on the staff catalog search results page
when there are zero holdings as such:

bg-warning (yellow) when there are no copies
and the record is NOT transcendant, and bg-info (blue) when there are
no copies, but it is transcendant.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1977761: (follow-up) enforce use of the permission at API level

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1977761: add release note

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1977761: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1977761: (follow-up) adjust seed data

Give ADMIN_FUND_ROLLOVER to Acquisitions Adminsitrators in the
seed data for new databases.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1977761: (follow-up) adjust DB update

Assign the new permission to permission groups that include
ADMIN_FUND; that way, users who were able to rollover funds
are less likely to lose the ability to do so unexpectedly.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1977761: Create fund rollover perm

This patch adds a new permission to perform fund propagation and rollover.

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Lindsay Stratton <lstratton@wlsmail.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1978976: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1978976: (follow-up) tweak formatting of releaste note

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1978976: add release note

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

lp1978976 merge record notes during bib merge

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1982031: add release note

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1982031: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1982031: (follow-up) corrections to DB update

- fix syntax error
- update the label and description only on exact match
  with the legacy value; this prevents overwritting any
  local tweaking of the library setting

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1982031 Reword Acq FYE library setting

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Lp 1943168: Add Release Note

Add a release note for the match quality ratio options to
marc_stream_importer.pl.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Lp 1943168: Add Marc Stream Importer Match Quality Ratio Options

Add options to specify the match quality ratio when running
marc_stream_importer.pl.  There are separate options for bibs and
authorities:

   --bib-match-quality-ratio=f
   --auth-match-quality-ratio=f

They take floating point arguments and correspond to the similar
option in the Vandelay import screen.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1891369: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1891369 Renewal extension never shortens previous due date

Ensure the calculated due date of a renewal never occurs before the due
date of the previous circulation.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1891369 Renewal exentions ignores overdues

Exit renewal extension logic early when the renewed circulation was
overdue.  I.e., there's no time to offer on the subsequent circulation.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>