lkasejf. It's the weekend.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

URLVerify.pm; response throttling repairs

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

A note about open-ils.url_verify.verify_url for future reference

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Verification sorta works but doesn't report progress correctly

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

these new bits untested, to be continued

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Essentials for URL selecting interface

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Fix IDL permissions that require jumps

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Refactor create_session as dojo module.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Various fixes, largely UI

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

fix xpath generation to match what works

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Call URL extraction phase from UI

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Fix previously nonfunctional stored procedure url_verify.extract_urls(INT,INT)

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

whitespace

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Permisison fixing

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Pretty much finished session create UI but for cloning

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Buckets and their items aren't designed to be PCRUD accessible,

so we need a handy view to link URL Verify Sessions to the bib
contained.  We can leverage this in flattener queries.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Fix subtle Perl issue

Not a syntax error that the compiler will catch, but see
"perldoc -f do" which will lead you do "perldoc perlsyn"

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

More UI work. Saved search selector & search scope OU selector & cosmetics

Still not actually functional.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

use a perm that actually exists

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Deal with moved publish_fieldmapper() method

This is a companion commit to
fac45ab9b1cb8924 / Move Fieldmapper API call to Application.pm

Without it, Flattener and Action/Trigger stop working with errors like
this:

[Mon Aug 20 13:50:18 2012] [error] [client XXX.XXX.XXX.XXX] Exception:
OpenSRF::EX::ERROR 2012-08-20T13:50:18 main -e:0 System ERROR:
Exception: OpenSRF::DomainObject::oilsMethodException
2012-08-20T13:50:18 OpenSRF::AppRequest
/usr/local/share/perl/5.10.1/OpenSRF/AppSession.pm:1064 <500>   *** Call
to [open-ils.fielder.flattened_search.execute.atomic] failed for session
[1345485018.767884163.96534353976], thread trace [1]:\nNo field by the
name publish_fieldmapper in Fieldmapper! at
/usr/local/share/perl/5.10.1/OpenILS/Utils/Fieldmapper.pm line
270.\n\n\n\n, referer:
http://XXXXXXX/eg/conify/global/actor/search_filter_group

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

check for session ownership and for previous searchitude

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Get all search results, not just first 10

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Beginnings for the big session kick-off UI.  Not yet functional.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

ML methods to create sessions and do the searching/bucketing

We can't use PCRUD to create url_verify.session objects because a) you
couldn't trust the creator field if we allowed that, and b) the
container foreign key has a not-null constraint, so you have to create
that first, and you can't do that with PCRUD.

I've removed the C, U and D perms for PCRUD for url_verify.session, but
I left the R in case we wind up using that.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Add open-ils.url_verify service to example OpenSRF configs

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

New container type for url verification sessions

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Function for ingesting URLs from container item + session

Signed-off-by: Mike Rylander <mrylander@gmail.com>

URLVerify.pm; docs; tested redirect max/loops and repairs

Signed-off-by: Bill Erickson <berick@esilibrary.com>

URLVerify.pm; docs; url domain looping; cleanup

Signed-off-by: Bill Erickson <berick@esilibrary.com>

URLVerify.pm; docs; url shuffling

Signed-off-by: Bill Erickson <berick@esilibrary.com>

URLVerify.pm; docs; url shuffling

Signed-off-by: Bill Erickson <berick@esilibrary.com>

URLVerify.pm; avoid re-processing same url repairs; honor delay=0

Signed-off-by: Bill Erickson <berick@esilibrary.com>

URLVerify.pm; avoid re-processing same url within the same attempt (thinko)

Signed-off-by: Bill Erickson <berick@esilibrary.com>

URLVerify.pm; avoid re-processing same url within the same attempt

Signed-off-by: Bill Erickson <berick@esilibrary.com>

URLVerify.pm; apply timeout to lwp useragent; comments

Signed-off-by: Bill Erickson <berick@esilibrary.com>

URLVerify.pm; move to lwp to support ftp and simplify

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Do the same thing I did to fix constrain names in upgr scripts to baseline

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

url_verify schema repair / res-code constraint

Signed-off-by: Bill Erickson <berick@esilibrary.com>

url_verify seed data / sql manifest

Signed-off-by: Bill Erickson <berick@esilibrary.com>

url verify seed data repairs

Signed-off-by: Bill Erickson <berick@esilibrary.com>

URLVerify.pm; settings, tmp caching, cleanup / misc

Signed-off-by: Bill Erickson <berick@esilibrary.com>

url verify seed data / null constraint repairs

Signed-off-by: Bill Erickson <berick@esilibrary.com>

url_verify seed data (trigger)

Signed-off-by: Bill Erickson <berick@esilibrary.com>

url_verify perm/org setting seed data

Signed-off-by: Bill Erickson <berick@esilibrary.com>

url_verify perm/org setting seed data

Signed-off-by: Bill Erickson <berick@esilibrary.com>

url_verify perm/org setting seed data

Signed-off-by: Bill Erickson <berick@esilibrary.com>

URLVerify.pm; redirects / error handling

Signed-off-by: Bill Erickson <berick@esilibrary.com>

URLVerify.pm; more testing tweaks

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Move Fieldmapper API call to Application.pm

Move export of opensrf.open-ils.system.fieldmapper API call from
Fieldmapper.pm into Application.pm with the rest of the shared API
calls.  This allows us to remove the OpenSRF::Application base from
Fieldmapper, which was causing some method name collisions.  For
example, if a Fieldmapper object had a field called "session", which,
incidentally, is also a method of OpenSRF::Application, the version
from OpenSRF::Application would get called instead of the Fieldmapper
version, since Fieldmapper methods are defined during AUTOLOAD.
Hilarity was guaranteed to ensue.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

URLVerify.pm; initial testing tweaks

Signed-off-by: Bill Erickson <berick@esilibrary.com>

URLVerify.pm; resume options; docs

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Liberalize res_code constraint

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Constraints need unique names

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

URLVerify.pm; docs / cleanup

Signed-off-by: Bill Erickson <berick@esilibrary.com>

URLVerify.pm; firing batch url verify calls

Signed-off-by: Bill Erickson <berick@esilibrary.com>

URLVerify.pm getting started

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Added is_event check to AppUtils

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Add ON INSERT trigger to parse the URL as it is added

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Add Rose::URI to the CPAN_MODULES list

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Start building URL-Validation related funcitons

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Schema and IDL changes for URL Verification functionality

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Default notify by text receipt replaces to blank

So that when the option is disabled we don't leave behind things like
%notify_by_text% and %notify_by_text_msg%.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

TPAC: Results - don't show the pubdate if we're showing full pubinfo

In the "show few details" mode, we show just the pubdate; in the "show
full details" mode, we're showing the full pubinfo and therefore do not
need to show the stubby pubdate.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>

TPAC: Display full publication info

In both the results table and record summary, we were failing to display
the place of publication - which is critical information for people
trying to track down the right edition or constructing a bibliography.

Grab the place of publication, and then reconstruct 260abc (avoiding
another XPath iteration and giving ourselves the ability to enhance the
schema.org microdata at the same time).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>

Enable 1-hit redirect for item barcode searches

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Protect against fleshed circ_lib in legacy check_age_protect

Retrieving org settings with an org unit object as the context org unit
results in errors and dying.

This affects legacy scripts only.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>

Sort of in line with 949322 but not absolutely necessary
This just supresses the message about what text was copied to the clipboard - globally!

Signed-off-by: edoceo <code@edoceo.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

lp949322 Copy Patron barcode to clipboard when clicking their name
CTRL+Click will open the patron record in a new tab

Signed-off-by: edoceo <code@edoceo.com>
This affects the patron label in Item Status -> Alt View -> Holds/Transits.  Looks good to me.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Various additions to the 2.3 release notes.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

Hide Print Page button on Simplified Pull List

On the Simplified Pull List interface, there is a button for "Print Page"
that shows up in the upper right corner. The suggestion is to hide that
button to avoid library staff printing just what's visible instead of using
the proper "Print Pull List" button that's actually on the page.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

TPAC: Escape single quotes in MFHD record location

If an MFHD record contains an 852 field with a subfield containing a
single quote, the unescaped single quote is introduced directly into the
value of the JavaScript hash that uses single quotes as delimiters -
thereby generating a JS exception and preventing the staff client from
properly populating the MFHD Editor menu.

This commit escapes incoming single quotes from the MFHD location field
to prevent that from happening. The other fields in the JS hash are
numeric and therefore should not need escaping.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Remove defunct variable from 'jtitle' code

With the second part of the 'jtitle' code moved elsewhere,
we no longer need this extra '$q' variable.  No big deal, but
best to sweep up while we're in here.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

Revert "Bug #1044721: QP handles explicit group+joiner badly"

This reverts commit b77bb9943009b81042b4ef1a6ac33ec9e3e96dd7.

Unfortunately this had side effects that escaped our manual testing
processes.  Especially with facets as reported by Ben Shum.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

Journal title hackery - move to a more robust location

The fix for bug #1044721 broke the journal title hack, which probably
should have lived where this commit moves it - if, in the age of filter
groups, we decide whether it's worthwhile to keep it alive at all.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Upgrade bits for Vandelay Overlay Changes

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Increase Overlay Speed for Standard Identifiers

Due to an inefficient query order and a confused query planner,
some overlay matching can end up going abysmally slow.  See LP
bug #1024095 for elaboration on the issue.

This commit reorders the joins as originally suggested by Lebbeous,
then adds a specific index to coax the query planner into making the
best choices.  The example index here only targets the 02x identifier
fields, so other tag/subfield/substring(value) indexes will likely
be necessary for maximum benefit when matching on other fields
(e.g. 010).

These changes combined with the previous commit which replaces 'LIKE
ANY' with 'LIKE (... OR ...)' has shown great promise in testing.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Vandelay: Fix index-miss with MARC Imports using Match Sets

In some Postgres installations, an expression such as:

(value LIKE '13423488%' OR value LIKE '245425%') will use a btree index,
but

value LIKE ANY('{13423488%,245425%}'::TEXT[])

will not.

Missing such an index can make matching incoming bibs based on a field
that's present in most of your existing records terrifically slow.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Bug #1044721: QP handles explicit group+joiner badly

Although the following four queries should be equivalent:
  george  ||  fred
 (george) ||  fred
  george  || (fred)
 (george) || (fred)

The Pg QueryParser driver generates SQL queries that return different
numbers of results for each of those queries, with all desired results
appearing only with the first query. This seems to be because of the way
filters are added in the interface.

This patch adjusts the Search code in TPAC to add an explicit group
around the user-entered query, which enables the Pg QueryParser driver
to handle all four of the above queries properly.

This patch should also resolve the problems encountered with the patch
for bug #1040740, "Implicit ANDs should have higher precedence than
explicit ORs"

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Gracefully handle reporter class with no labels

LP 1045964 -- unable to clone report template

The template interface was failing while rendering the reporter sources
drop-down when a reporter source (IDL class) had no label.  This adds a
sanity check around that.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

Fix Merge All Records in Bucket action

A xul file was not being prefixed with oils://remote

Note: This is a quick fix. Ideally we move the url to constants.js.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Define a few strings missing from cat.properties

By the power of build/i18n/test/check_properties.py ...

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Importing translations for 2.3.rc1

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

Do the SQL upgrade dance for list pubdate in CSV

With a slight tweak to base the upgrade off of the event definition name
instead of the ID; possibly more resilient.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Add pub date to CSV output.

Change the template for the ContainerCSV reactor to add the publication
date (MARC 260$c) in the csv output in the same position that the previous
commit adds it to the html output.

Add an upgrade script to update the existing template for the ContainerCSV
reactor in action_trigger.event_definition.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

TPAC: Add the ability to set a different default locale

Installations with multiple sites might desire different default locales
for their skins. This adds the Apache config directive
"OILSWebDefaultLocale", which enables you to set the default locale on a
global and a per-skin basis.

Note that this prevents the browser Accept-language header from having
any effect; sadly that header is not often used in real life.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Art Rhyno <art632000@yahoo.ca>
Conflicts:
Open-ILS/examples/apache/eg_vhost.conf

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

TPAC: Make call number browse record links retain search lib

In addition to maintaining scope for the call number browse search
results, we also need to maintain the scope for the links for the call
number records in the results themselves (for example, the "retrieve
this record" link, or the "search for this author" link).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>

Documentation: removie file reference to line items since section was moved to another file.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>

Documentation: Add sections for new features in Acquisitions

From: http://www.esilibrary.com/esi/availableDocs.php
RS added some index terms to start beefing up our index for the docs.

Changed the thawing of a hold to first update the hold record and then re-target.

When thawing a hold, originaly we were first re-targeting before actually saving the hold record. On items with large quantities, sometimes the hold would timeout on targetig before getting a chance to actually save. This patch moves things around to first save the hold record before attempting to retarget.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Acq: In general search, make value widgets for OU-linked fields right again

They always used to be OU selector dropdowns until a thinko in 55a82b5.
This restores them.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Acq: Fix General Search for Lineitem Attribute-based fields

Reported by Ben Shum and Kathy Lussier, the Acq General Search interface
was broken in that you couldn't use any of the search fields under
Lineitem Attribute.  This error was indeed introduced by recent commit
55a82b5 as Ben determined, but simply reverting that commit left other
things broken.

This commit actually targets the problem and seems to fix it in my
testing.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Acq: New lineitems added to existing POs should inherit provider

Jeremy Miller of the Albany Public Library in Albany, OR, reports that
through the interface at
    Actions For This Record -> View/Place Orders
in the staff client, when you add a lineitem to an existing PO, the new
lineitem has a null value in the "provider" field, instead of inheriting
the expected value from the PO.

This causes problems for some Acquisitions workflows.

The feature containing the bug appeared in 2.2, and this fix for it can be
backported that far.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

ACQ support for two-step vandelay imports

If a lineitm is loaded into a queue via ACQ+Vandelay and a later attempt
is made to load the record into the catalog via ACQ+Vandelay, the
attempt will fail, because ACQ+Vandelay treats all
not-yet-fully-imported lineitems as new to vandelay.  This change
inspects lineitems at vandelay processing time to determine if they are
already linked to a VL record or if a new one is needed.  It also
removes the requirement that a queue be provided when all records in
process are already linked to a VL record (which already lives in a
queue).

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Add a new "starts with" search option to the advanced search page.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

Add kpac to 2.3 release notes

This is a snippet from the main kpac documentation in
docs/opac/kids_opac.txt, added to make sure it's represented in the
release notes.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>

Fix sorting when printing from FlattenerGrid-based interfaces

This particularly affects the Simplified Hold Pull List.  The printed
verison of your data is supposed to reflect the same sort order that has
been selected in the visual interface, and now it does.

Buggy handling of the different avenues of sorting the grid (clicking column
headers, using the column-picker/multicolumn-sort dialog, default sort order)
had broken the flow of the data needed to build the right sort clause for
some situations.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Fix epub complaint about image with extra colon

The "+" operators are typically only used to embed an image within an
ordered or unordered list to avoid breaking the indentation level or
numbering; here, we were using the "+" operators between regular
paragraphs, which doesn't make much sense. What made less sense was the
processing result, which bizarrely added an extra colon to the front of
the image path, leading to a (naturally) missing image and processing
error.

The fix is just to throw the image tag in between the paragraphs with no
special "+" operators; just blank lines.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Document how to create a TPAC/KPAC search box

Now that we're in the land of the TPAC, it's time to ensure that
everyone can update their simple search boxes so that they no longer
point at the JSPAC and point at the TPAC or Kid's OPAC instead.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Resolve doc PDF transform error

The doc build gets angry when a target that does not exist is linked
from somewhere else in the docs. So, make the target exist.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Documentation: Add documentation for setting maximum checkout by copy location.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>