Fixed bug in staff client offline mode.

https://bugs.launchpad.net/evergreen/+bug/1089657

In list.js at start you create obj.columns for lineno, but later
you don`t process this value so it`s return default render
function.  This code repairs this.

Signed-off-by: Dmitry Nechai <nechai.dmitry@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Prevent compiler warning about unused numtype var

There was a dangling variable left around that was making noise in the
compiler. Credit to Jeff Godin for the heads-up.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Address SQL injection vulnerability in SQL ORM layer

If the user-supplied value and the db column are both numbers
(jsonObject->type == JSON_NUMBER, get_primitive(field) == "number") then
don't quote. Otherwise, quote.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

2.2.7-2.2.8 database upgrade script

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

2.3.5 -> 2.3.6 SQL upgrade

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Stamping upgrade script for reinstate tsconfigs.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Reinstate required TEXT SEARCH CONFIGURATION data

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Address hash/list thinko; Ensure initialization

Two cascading defects were identified after being reported by users. The
first, which was only a potential issue, was an apparent lack of mod_perl
initialization for the item-age record feed.  While not the direct cause
of the error message, a lack of initialization here would manifest in the
same way.  So, we check that initialization.

Feed-generating callbacks were not being constructed properly due to a
simple thinko in the construction of the default record format list provided
by the SuperCat backend.  We need a list of two hashes, not a hash of two
keys.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

TPAC bucket item retrieval operates in streaming mode

TPAC bucket item retreive fleshes bib records with large blobs of MARC
data.  When a bucket contains a few thousand items, the size of the
data passed around in atomic retreival mode will exceed the typical jabber
max stanza size and result in a failure.  Retrieve the records in
streaming mode instead.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

TPAC: Render record titles and authors consistently

Yamil Suarez noticed that the titles and authors in the call number
browse results page were presented differently than the regular search
results. This change removes some of the hard-coded <em> tags and "bold"
classes, in favour of new "record_author" and "record_title" CSS
classes. Now sites can simply change the CSS in one place to keep things
consistent between the two search results pages.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Yamil Suarez <yamil@yamil.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

Use inline-block for opac-multiline-button style

Follow up for LP1102934 which introduced CSS for opac-multiline-button.

The button appeared noticeably larger if using the english text for
"FAQs" on the login help button. Using inline-block for the style shrinks
it to fit more appropriately based on actual amount of text instead of
leaving it an unusually large looking button.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com>

TPAC Turn dashes into space in subject search links for better matching

Thanks to Dan Wells for finding a bug and fixing it for demonstration
purposes.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Add summary creation to embedded alt dist editor

In the Serial Control View, summaries are created automatically with
a new distribution. To avoid unhappy surprises, the embedded version
of the alt distribution editor should do the same.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Ignore canceled holds during alt-queue generation

When zero potential copies exist for a hold, the hold queue stats code
determines the size and shape of the queue by finding and sorting holds
that have the same type and target.  This patch forces the code to
ignore canceled holds when looking for similarly-shaped holds.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Remove a search change and add an invoicing note

With lp1161601, we lost one of the new features from the qp work. Also, we
missed one new feature with invoices.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Release Note Additions

We should probably add the removal of JSPAC to the Release Notes. Also
added the following new features that were missing from the original
notes.

- Options to hide some user preferences from TPAC
- New fields for acq distribution formulas
- Public copy notes
- Direct access to item attribute editor
- Setting staff client search preferences

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

More typo fixing

Change CVS to CSV as noticed by Remington Steed.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Minor edit

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Minor edits to release notes and addition of new permissions

There are some new permissions that didn't get added to the original
release notes. Also, some minor edits.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Fix some typos in the 2.4 release notes

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Update for 2.4 beta1 release notes

- Move more release notes into 2.4 notes.
- Move notify_csv.txt into TechRef directory.
- Include entry for Linkchecker in 2.4 notes.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Initial cut of 2.4 release notes.

Basically, the contents of RELEASE_NOTES_NEXT organized into
RELEASE_NOTES_2_4.txt and removed from RELEASE_NOTE_NEXT.

Move copy of alternate_graphic_fields to TechRef.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Release note template

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Updated README to reflect the future

Signed-off-by: Mike Rylander <mrylander@gmail.com>

proto-script for release note generation

Signed-off-by: Mike Rylander <mrylander@gmail.com>

release notes FS structure

Signed-off-by: Mike Rylander <mrylander@gmail.com>

stamping upgrade for field 264 reporter view

Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1071505 - Add 264 RDA tag to reporter views

Some reports draw from reporter.materialized_simple_record table and these
were not made aware of the new 264 tag which contains publisher related
information.

Change the view for reporter.old_super_simple_record, which feeds into the
other reporter table.

The included upgrade SQL will update this view and then update the table using
the new view.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Populate variable needed for batch item receive

In the integrated alt editor, we load the sub. grid differently, so
'sub' was not being populated.  Since we should only ever have one
subscription showing at a time (in this view), we can simply assign
the item to 'sub' as it is received.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Small fixes for alt sub editor integration

This commit applies some polish to the alt sub editor integration:

 - Prevent spinner from displaying continuously when adding a
   subscription
 - Hide the editor when changing subscriptions to limit confusion
   about what is loaded
 - Dynamically add a node to the tree view when adding a subscription
 - Make sure the 'View/Edit' tab gets populated when backing out of
   the stream or item view
 - Apply some default link styles

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Bash script to be used after the main 2.3-2.4 db upgrade

This script, originally offered by Thomas Berezansky and tested by others,
and augmented by me to include more parallizable SQL, will reduce the
time spent upgrading a large Evergreen 2.3 database to 2.4 by several hours.

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Repair an issue in search filter group UI about filtering on owner OU

What was intended to be a filter against filter groups' owner field was
instead turned into a filter on filter group ID.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

QP copy location group filter repair

Remove reference to nonexistent location group filter callback function.
Copy locations for filters are loaded inline.  No callback needed.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Documentation: Add link checker documentation.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>

Update LP1159768 - Client: Holds Client Controls Confusing

The new string "Are you sure you want to cancel the hold(s)?"
has been added as the following variable,
staff.hold_list.cancel_hold_dialog.confirmation.

The string also needs to be translated to all supported languages.

Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP1159768 - Client: Holds Client Controls Confusing

The buttons were updated per Jason's suggestions to "No" and "Yes" with
a question added, "Are you sure you want to cancel the hold(s)?"

Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP1159768 - Client: Holds Client Controls Confusing

Changed the language from "Cancel" to "Cancel Action" and
"Apply" to "Apply Cancellation".  These need to be translated
to other supported languages.

Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

stamping upgrade script for authority validation fix

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Avoid problems when auth recs are missing the 901c

Fixed the authority.normalize_heading function to better handle
INT's when there is no 901 present. Now we look for the best-fit
control set instead of throwing a db-level error.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Best hold selection: fix a checkin-busting bug affecting Holds-go-home

Several subselects within SQL auxiliary queries can possibly return
multiple rows in situations where outer code requires that they return
only one or zero rows.

When you're using a best-hold order that includes htime or shtime, (such
as those with Holds-go-home) and if there are mutiple circs or transits
related to the copy in hand with certain characteristics, you can
trigger this bug.  The end user at the staff client gets one of those
nasty "Network error" dialogs, and the error in the SQL logs is:

> ERROR:  more than one row returned by a subquery used as an expression

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Fix bug in hold targeter introduced with Calculated Proximity Adjustments

The Calculated Proximity Adjustments feature introduced a bug in the
hold targeter where holds would not discount those copies from the
potentials list that aren't in either the Available or Reshelving
status.

This commit should restore the earlier, correct behavior.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping upgrade script for revive-qp-fts (LP 1161601).

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Upgrade script to bring back the stored proc

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Revert "Remove search.query_parser_fts from schema"

This reverts commit ab9fb958e387a20cfe9fafb6035fb72bc5f1fb3f.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Revert "Remove dependence on search.query_parser_fts proc"

This reverts commit 6d8872cf120caf67ad6f65995b2c5155fa5ab652.

Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP 1126545 repair staff 'return to results' tpac link

Strip the extra "/" from the URL created by the "return to results"
button in the staff client TPAC view.  Havin the extra "/" in place
prevents the next/previous links from functioning.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Allow access to public hold notes via hold "blob"

If a hold note is marked as "public", it seems reasonable that it
should be visible to anyone who can see that hold, regardless of
who created the note.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com>

Fix reversed logic for hold "blob" notes

Hold notes (at least at the data level) allow for both staff and
"private" notes to be attached. This code intended to show "private"
notes to the hold owner and staff notes to staff, but had the logic
reversed.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com>

tpac : honor page locale in record detail copy grid

The query used to load the record detail copy grid now uses the same
locale value set as the default for all cstore-editor calls.  This
solves the issue where copy location names, statuses, etc. are not
properly translated.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping upgrade script for aoupa constraint fix

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Org unit prox adjustment tweaks

1) UI change - pre-select highest OU where user can edit

There's a dropdown in the org unit proximity adjustment interface that
affects the scope of what you can see in the table below.  Before, that
dropdown would be set to the user's home UO (say, BR1 in the example org
tree).  But you might have the permission to make changes everywhere, so
you add a proximity adjustment that affects BR3 in some way.  As soon as
you'd refresh the interface, your new proximity adjustment would not be
visible, because your scope selector would default to BR1.

So now the dropdown defaults to the first context where you have the
permission, which in all but eccentric setups should be the highest OU
(and therefore broadest scope) where you have the permission.

This could also improve other interfaces in the future.  Anything that
invokes openils.User.buildPermOrgSelector() can pass -1 as the third
parameter to get the new behavior.

2) Change UNIQUE index at DB layer.

This prevents the creation of rows that would give the hold targeter
conflicting directives.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Undo holding lib to SRE linkage (alt dist editor)

Since the legacy record dropdown piggy-backs on the OPAC display, it
doesn't work in the alt interface (which has no clear OPAC context).

Worse, this leads to a Javascript error on the first editor load for
the distribution list, preventing subsequent editors.

A better fix will require more consideration, but for now, let's
revert to the unformatted display used in 2.3.

Also, this commit removes an unnecessary conditional (it was always
true).

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

More authority fixed-field cleanup

Even with the efforts by many to add and harmonize the authority fixed-field
setup, and maintain functionality, there were some missing bits.  This commit
should take care of those by realigning the remaining field names and allwowing
those fields to be saved properly.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

MARC strip fields for Acquisitions

Added MARC strip field group selector to acquisitions upload interface
in the same manner as the group selector for non-acq Vandelay

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1160343: remove unused open-ils.circ settings

The circ_modifier and billing_types lists in the
open-ils.circ section of opensrf.xml are no longer
used.  This commit removes them from the opensrf.xml
example config.  It also removes the method
open-ils.circ.billing_type.retrieve.all, which has
not be used by any other code once in-DB billing types
were introduced.

Any external clients that used the method that was
removed should instead use
open-ils.circ.billing_type.ranged.retrieve.all.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

LP 1150458 DB upgrade stamping

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Changed the way authority tags were being pulled to specifically use an aggregate array.

There appears to have been a change in postgres at some point between 9.0 and 9.1
to the aggregate method. Because of this, postgres was not returning the proper
results when pulling tags for authorities. This change will force postgres to do
a proper aggregate array call and return the correct results.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

DB upgrade script for 2.2.7

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

2.3.4 -> 2.3.5 DB upgrade script

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Placeholder DB upgrade for 2.3.4

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

Placeholder DB upgrade for 2.2.6

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

TPAC - Syntax error breaks place-hold page

A recently introduced <label> tag had a ' mismatched with a ", breaking
the pickup library selector on the TPAC place-hold interface.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Updating POT files

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Translation updates!

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Bumping OpenILS.pm version number

Signed-off-by: Mike Rylander <mrylander@gmail.com>

SIP re-login fetches correct auth session

After a login session expires and the SIP server logs in again to
acquire a new authtoken, be sure to use the new authtoken when fetching
the new session object.  Otherwise, the login_session is left undef and
you may see errors like this when checking in items:

Can't call method "ws_ou" on an undefined value at
/usr/local/share/perl/5.10.1/OpenILS/SIP/Transaction/Checkin.pm line 77.

Incidentally, the checkin code is the only code that references
$sip_handler->{login_session}.  And the problem listed above only occurs
when the login session expires just prior to a checkin call.  In any
other scenario, the login_session would ultimately get repaired.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

TPAC - Account preferences headings

Currently, all tabs in My Account show a heading once clicked(Items Checked
Out shows "Current Items Checked Out" heading when clicked); however,
under the Account Preferences for a change of username, password, and
email address no headings appear.

Div classes were added to update_password.tt2, update_username.tt2, and
update_email.tt2 for consistancy in the My Account area.

Signed-off-by: Melissa Lefebvre <mlefebvre@biblio.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1155496: fix typo

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

add typo fix back

I missed this when I was resolving a merge confict
with the previous patch.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Fix some typos

Except for the typo in staff client's multiclass_search_help.html,
the rest are in comments.

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Conflicts:

Open-ILS/examples/apache/startup.pl

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Fix detection of empty Syndetics AC data elements

Due to a change in how the vendor responds to requests for data
elements which are not present for a requested title, we need to
change how we detect "empty" data elements in the "data_exists"
function.

First, we check for the new "No Data Available" title element, then
we check for the previously-used value of "error".

This change resolves the symptom where the catalog would display
tabs for "Author Notes", "Excerpt", "Table of Contents", on every
record in the catalog, even when clicking each tab would show that
the content was not present / available.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1078222 - Add transparency to newtab2.PNG

Some users noted that this image looked bad with white
background when changing to a different colored "welcome"
screen.

This simply converts the icon to a transparent PNG file.

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

fix typo preventing transit abort error dialogs

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Rename "Search Preferences" tab to "Search and History Preferences".

This change better reflects the complete meaning of the preference tab.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP1054322 - libparent-perl not needed for Ubuntu Precise

The newer version of Perl 5.14 which comes with Ubuntu Precise already
contains the contents of libparent-perl, which is now an obsolete package.

Remove this dependency from the extra debs installed for Debian and Ubuntu
but then add to the extras for Debian Squeeze and create a new extras just
for Ubuntu Lucid so that it continues to be installed on those systems and
not on Ubuntu Precise.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP1103068 - Show titles and authors for pre-cat items

As noted in LP1103068, TPAC does not currently show anything when viewing a
pre-cataloged item in the my account summary of items checked out.

If the call number is -1 (pre-cat), then show the dummy title and dummy author
values, which fields are hopefully relevant as long as staff were good to put
something meaningful in those during creation of the pre-cat.

Also, wrap the title in a check for attrs.title.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Michael Peters <mpeters@emeralddata.net>

LP1116258 - Hide download circ history if none to be found

As noted in LP1116258, if there is no circ history for a patron, but they
click on the Download CSV button, it leads them to unhappy server errors.

So, hide the Download CSV button unless the number of circs > 0.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>

LP#791881: make it possible to save copy location translations

TranslatorPopup requires that the i18n fieldmapper class be loaded.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

TPAC: Address severe accessibility issues

Using the Chrome Accessibility Dev Tools extension to run accessibility
audits against the TPAC turned up some "severe" issues, such as input
widgets lacking labels. In most cases the text for the labels was
present, but it needed to be associated with a <label> element. In some
other cases, it was easier to use the aria-label attribute to give the
widget an accessible label. Finally, we can use the placeholder
attribute where warranted as an accessible label.

These changes address the first set of accessibility issues I came
across via the audits and could address quickly.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Fix spelling error of "Successfully" in ils_events.xml

LP#1155495 "card transaction was processed successfuly" is
spelled incorrectly.   This corrects that misspelling.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Use a consistent spelling of "Pickup" throughout the code

LP#1155494 In myopac/holds.tt2 the text "PickUp Location" is
used, and everywhere else it's "Pickup Location".
Pick one spelling and stick to it.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Enable dojo in TPAC if using newer Novelist API

Enable dojo if the apache variable for Novelist URL is set. This avoids
issues such as needing to have dojo enabled via either AutoSuggest or
Google Books preview, which may not be enabled by every TPAC.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Support new-style Novelist for TPAC.

Updates the Novelist loading script to use the newer Novelist API.

Includes minor change to example/apache/eg_vhost.conf for environment
variables.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP 1155611 - prevent unnecessary load of fm_IDL.xml

Ensure fm_IDL.xml is loaded only when IDL2js has not been loaded.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Wrap upgrade script for use ID as TCN value fix

Signed-off-by: Dan Scott <dscott@laurentian.ca>

LP#1155329: better enforce cat.bib.use_id_for_tcn

Restore previous behavior to the maintain_901() trigger
function so that bib records that are loaded without
explicitly setting the TCN have it set to the bib ID
when the cat.bib.use_id_for_tcn global flag is set, rather
than 'AUTOGENERATED-xxx'.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

Allow translating one final untranslatable error message in checkout interface

Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>

Support Apache 2.4 configuration directives

Apache 2.4 uses a different server-side include syntax, but we can
direct it to use the old syntax via the SSILegacySyntax directive.

2.4 also uses different access control syntax: "Require all granted"
instead of "Allow from all", for example.

Accordingly, create a parallel examples/apache_24 directory that
contains sample Apache configuration files suitable for Apache 2.4 and
higher.

Also, amend the README to reflect Apache 2.4 and higher.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>

Add "Show Holds on Bib" menu items

Add a "Show holds on bibs" option from item checkin, item status, and patron
hold interfaces. This makes it quicker to flip to viewing who else has holds
on an item instead of having to click an option to see the bib, then clicking
in the menus for view holds. One less click.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

Repair ACQ nls file synax

Remove trailing comma, which breaks the PO building process.  Thanks to
Pasi Kallinen for spotting this.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Serials: printing routing slips fails with Javascript error

The symptom (an error in the Javascript console about dijit.form.Button
and an empty page for routing slips that you try to print at batch
recieve) may or may not be affected by whether you're in a production
environment with the pre-built dojo 1.3.3 package installed or a
development environment without it.

This simple fix makes the problem go away in any case.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

Stamping upgrade for new general indexes

Note: Changed the commands in the upgrade to CREATE INDEX CONCURRENTLY to be
in all caps to satisfy my own small sense of consistency.

Signed-off-by: Ben Shum <bshum@biblio.org>

Observed speed increases through judicious indexing

These indexes drove high-cost queries down into the noise
at several sites.  They are more applicable for larger
installations, where "larger" can be defined as either "lots
of data in the db" or "has used Evergreen for a long time".

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

TPAC: Add config options to hide phone / user prefs

Libraries using centralized authentication (such as LDAP via
open-ils.auth_proxy) will not want to allow users to change their
passwords or email addresses.

In addition, many libraries do not want to deal with phone
notifications.

This commit adds preferences to config.tt2 that hide these options from
the user.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Preserve serial interface context, if present

If the new 'context' URL parameter is present, we need to make sure
it sticks around for a couple of the "deeper" views (streams and
items).

Also, preserve the tab when coming out of said views in 'scv'
context.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Translation file entries for serial note editors

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Release notes for Serial Control with embedded Alt. Interface

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Move serials interfaces closer together

Back in (I believe) 2.2, we brought the dijit issuance editor into the
serial control interface with two goals: having less code in more places,
and easing the transition to an eventual unified interface which would
likely be more widget-based.

That experiment was well received, so this commit takes things a large
step further in that direction.  Basically, we are embedding the
alternate subscription editing interface into the serial control
scaffolding, which ultimately amounts to giving you some of the
benefits of both.  You get the more modern and maintainable code from
the alternate interfaces, but keep the context-awareness and familiar
navigation of the non-alternate serial control.

That said, this change is not meant to be the last word in serials,
but rather a way to at least come closer together while we still
continue to learn what structures provide the best experience.

Finally, some feature additions were necessary to the alternate serials
code in order to make this change as seamless as possible.  In some
cases, the new feature only works in the embedded version, but a new
'context' variable makes that simple to adjust as we move forward.
Changes include:
  - note editors on subscriptions and distributions
  - labeled dropdown for distribution summary options
  - and legacy record entry linkages

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Numering upgrade scripts related to acq batch update

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Distribution formula fund rollover setting

Adds an org unit setting (acq.fund.rollover_distrib_forms) which
controls whether the fund value on distribution formulae is updated to
use the newly created fund during fiscal year rollover.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>