LP1952931 Receiving...

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 Receiving...

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Revert "LP1952931 ASN Receiving UI / Li Table Experiment"

Staff prefer the scaled down grid view.

This reverts commit 8ee71edbe02fb9b1e3fd0a8846a46b90cf5f4f52.

LP1952931 ASN Receiving UI / Li Table Experiment

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN Receiving UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN Receiving UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN Receiving UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN Receiving UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN Perl Test

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN receiving UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN shipment notifiation IDL

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN receiving UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN shipment notifiation Perl Test

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN shipment notifiation Perl Test

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN shipment notifiation Perl Test

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN shipment notifiation Perl Test

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN shipment notifiation Perl

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN shipment notifiation Perl Test

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN shipment notifiation Perl

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN shipment notifiation SQL / IDL

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN shipment notifiation SQL

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 Parsing DESADV EDI Messages

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 Parsing DESADV EDI Messages

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1942220: add confirmation step to deleting LIs

- also tidy up when the action is avaialble
- also tidy up handling of selected LIs post-deletion
- also reload the page only once
- add TODO about decreasing parallelism
- TODO: toss up spinner?

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1942220: teach LI title sort to ignore common articles

Also move a couple convenience methods related to LI sorting
to LineitemService

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1942220: bump up hardcoded LI retrieval limit back to 10000

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1942220: extend the active LI sort order to PO printing

Note that this reimplements the sorting client-side.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1942220: wording tweaks

- "Copy Location" => "Shelving Location"
- "Zero-Copy" => "Zero-Item"

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1942220: improvements to cancel dialog

- add recordType parameter so that wording can be adjusted
  based on what is to be cancelled
- expand the wording to make it (hopefully) crystal clear
  what to do
- show all cancel reasons upon combobox click

TODO: pluralization for the more-than-one-LI case

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1942220: tweak LI actions around viewing/updating items

- Added "Update Barcodes" as a new LI action that opens the
  item attributes editor
- Changed the "Holdings Maintenance" LI action to open the
  record holdings view page rather than spawning the item
  attributes editor, making it match the behavior of the
  "Holdings Maint." LI action in the Dojo interface.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1929749: point to new PO interface if creating a PO

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1929749: fix lint

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929749 Finetuning LMOR based on LP comments

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1929749: Adds support for picking up library settings.

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929749 ACQ Load MARC Order Records port

[Note that this includes some work by Galen Charlton to reconcile
 the picklist module with work done by Bill Erickson for LP#1929741]

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1942220: link to the Angular PO interface acq search results

Note that this does /not/ follow the setting to display
links to the "experimental" Angular acquisitions interfaces; my
intention is to replace that with a different setting that,
when enabled, provides links to the Dojo interfaces from the
corresponding Angular interfaces.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1942220: start adding filtering to the LI table

TODO:

- publication date age filter
- filereader for 'terms from file'
- claim count and item count filters

Note that this is following the acquisitions search form, not the grid
filters

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1357037: seed data - WS for LI sort order

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1357037: add sorting option to Angular line item lists

This applies to the line item lists in the following new
Angular interfaces:

- purchase order
- selection list
- list of line items related to a bib record

The available sort options are:

- line item ID
- title
- author
- publisher
- order identifier (i.e., ISBN, ISSN, and/or UPC)

The method open-ils.acq.lineitem.unified_search is now used to retrieve
line items to make use of existing sorting functionality.

The last sort order used is persistant via a workstation setting

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1929741: repair adding brief record from PL page

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1942220: implement 'Create Invoice from Selected Lineitems' action

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1942220: hook up claim policies

- Display claim policy (if set) in the LI table
- Add the 'Apply Claim Policy to Selected Lineitems' action

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741: bump up ID for new config.print_template inserts

Resolving a logical merge conflict.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Brief record for PO repair

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Standalone brief record UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LPLP1929741 Optional experimental Acq; seed data

Adds and org setting and a workstation setting to 1) enable display of
experimental Angular ACQ UI's and 2) enable display of links to the
experimental UI's from search results.

Display a new menu entry "Acquisitions (Experimental)" when the org
setting is enabled.  This menu contains "Create Purchase Order" only for
now.

Copy seed data from upgrade file to seed data file.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Welcome page navigates to staff w/ href

When a route failure occurs, etc. and the user is sent back to the
Welcom to Webby page, make the link to the staff page an href instead of
a routerLink, so Angular is forced to load new route data.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Change Op displays failed permission

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 cleanup more PO subs

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Clear previous PO on new PO create

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 cleanup PO subscription; improve charges display

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Fund limit/sort on new charges

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 ng lint

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1928258 Combobox sanity checks

Avoid failures caused by calling toLowerCase() on a number.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Item location select starts with; hide Unset

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Combobox supports startsWith search (p2)

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Blanket order finalizing; improved charges handling

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Sort funds by year desc, then code

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Batch of PO fixes

* Avoid clearing the owning library during batch edit copy operations
* Leverage combobox startsWith for distribution formulas
* Disable the order ident selector so it cannot be modified after a PO
  is activated
* Add some icons to the PO actions for more eye-grabbiness.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Combobox supports startsWith search

In lieu of the default behavor of the typeahead, which does a 'contains'
search.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 ACQ order ident indicate multiples

When multiple order identifer values (e.g. ISBN's) exist on a lineitem,
the number of options is now displayed just to the left of the
identifier selector.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Apply default lineitem order identifers

Apply a default order identifier to lineitems instead of leaving the
selector blank.  Ensure the value that will display in the selector
matches what's in the database by setting the value on load when needed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Bundle of ACQ bug fixes

* Distribution formula combobox now displays entries on click
* Ditto Charge Type combobox
* Items now vanish when deleted
* Estimated amount, etc. update when items are added/deleted
* Lineitem action links match order of previous interface.
* PO dry run checks now fire after a brief record is added
* PO activation is blocked if an item has no owning lib.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Delete action trumps ischanged for LID's

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Cache LI after order ident change

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Lineitem delete repairs

Allow deleting lineitems on PO's for certaian states.

Fix lineitem delete code issues.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 View/Place orders sorts newest to oldest

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Limit to active providers; skip empty name picklist

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 AnJS nav create po goes to new UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Improve catalog service sanity check

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Repair 'Create Invoice' link

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Zero-copy and no-assets PO activation

And summary layout improvements.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Ensure PO items always display when present

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 View/Place Orders UI

View/Place orders from a bib record and add/create selection lists or
PO's from the record.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Display copy row number in copy edit grid

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 ACQ caching / batch editing improvements

Ensure that funds/mods/locations of modified copies are available at
render time after saving changes to copies.

Hide the copy batch update bar when no copies are editable.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Combobox additional sanity checks on async/IDL values

1. Avoid PCRUD queries where the selected id value is set to null.
2. Avoid attempts to add null entries to the async entry cache.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Sanity check distrib. formula values

No fields within a distribution formula are required, so confirm a set
of values exists before calling Object.keys() on an undefined value.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Angular Selection List / Po Seed Data

PO and lineitem worksheet print templates.

Workstation preferences for grids and lineitem list page size.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 ACQ Selection List & PO Angluar Port

New selection list UI
New PO UI
New Lineitem worksheet UI with stub print template
New PO print UI with stub print template
New brief record UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Combobox idl auto query filter addition

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Combobox asyncSupportsEmptyTermClick fix

Fixes situation where combobox would fetch the needed entries in async
mode, but fail to open the drop-down after a click.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Net service tidier request logging

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Revising 'Using the Public Access Catalog' page

Updating screenshots and information in this doc to match Bootstrap.  Some areas need updating still.

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1955931 Staff catalog show more details - add due date

Adds a due date column to the show more details view in
the Angular staff catalog.

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

Update Test for LP1722827 After LP1482757

The 4th part of the old test is incorrect as not deleting these is
the point of 1482757. Test has been updated to reflect that.

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP#1482757: stamp upgrade script

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP#1482757: stamp upgrade script

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP#1482757: Speed Up the Delete of Orphaned URIs in upgrade script

Modify the code that deletes orphaned asset.uri table entries in the
upgrade script to use IN logic on the subquery, because IN is much
faster than NOT IN.  Also take into account the link between
serial.item and asset.uri so that we don't accidentally delete URIs
used by serial items.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jessica Woolford <jwoolford@biblio.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP#1482757: Delete URIs and call numbers when all 856 fields are removed

This patch assures that URIs and call numbers are deleted as appropriate
when all 856 fields are removed from the MARC.

Also provides for tracking editor and edit_date when call numbers are
deleted.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP#1482757: Amend upgrade script to remove existing orphaned URIs

Remove orphaned URIs from the database that have accumulated from past
additions, updates and deletions of records with located URIs.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP#1482757: Remove 'orphaned_uri_list' and 'NOT cn.deleted' criteria

Per Dan Wells' suggestions.

1) One possible "crack" I see for data to fall through is the dead map
selector. The "AND cn.label = '##URI##' AND NOT cn.deleted" seems overly
restrictive. Now, I realize we *shouldn't* have mappings to deleted or
non-##URI## call numbers, but it isn't impossible, and I don't think we'd
have harm in leaving those restrictions out. If a map isn't used, let's
get rid of it regardless, I think.

2) (side note) orphaned_uri_list doesn't seems to be used any more, so
should be removed.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP#1482757: Be sure to remove all orphaned URI

As reported by Michele Morgan, URIs can be orphaned in some cases, such
as when a location drops one of several 856 entries.  This commit tracks
objects at the mapping level, to identify disused URIs even where the
call number level is not changed.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP#1482757: More careful Located URI remapping

Instead of recreating all Located URI mappings, we will add any new
ones and remember all those (existing and new) that are in use. Any
existing maps that we don't see in this record, and whose URI is only
used once previously and therefore about to be orphaned, we remove.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

Update to Batch Search page

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

Avoid fleshing standing penalty org unit children

When fleshing the org unit on standing penalties, exclude child org
units. We don't need them, and they can cause issues when your
standing penalty has a Depth of "Everywhere": you end up with a full
copy of the org unit tree, and you will include this when editing
and saving the user.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1927990 Bootstrap OPAC: Patron messages lose line breaks

Fixes problem where messages added to the Patron Message Center
lose their line breaks in the Bootstrap OPAC and makes them
difficult to read.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP#1949389: reduce number of PCRUD requests by subscription manager

This patch changes how the AngularJS subscription manager fetches
serial item templates. In particular, rather than issuing a PCRUD
request for every org unit in the system, it fetches them in one
fell swoop. This fixes an issue where loading the subscription manager
in a large Evergreen consortium could lead to so many requests that
it drives PCRUD into backlog mode, resulting in higher request
latency across the board.

To test
-------
[1] Apply the patch.
[2] Verify that the subscription manager lets you set the receiving
    template for each distribution and that the drop-down's contents
    changes if the distribution library is changed.
[3] Verify that the Apply Binding Template action works and that
    the binding template drop-down(s) include the relevant copy templates.

Note that if a binding template has been set already, the current
binding template is _not_ displayed as the selected value in the drop-down.
This is existing behavior that this patch does not aim to fix.

Sponsored-by: BC Libraries Cooperative
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>

LP#1946019: copyloc.js change to clear locations on new branch select.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1955927_Barcode_search_fails_in_patron_search_modal

Fixes the barcode search in the patron search modal in the holds screen.

To test:
1. Navigate to the 'place a hold' screen in a bib record and open
the patron search modal.
2. Enter a patron barcode.
3. The search for the patron fails.
4. Apply the patch and repeat.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>