webstaff: another fix to focus-on-new-MARC-field

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: fix setting focus when inserting a new MARC field

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: make context menus in MARC editor scrollable

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: make egGrid actions menu scrollable

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1464767 Browser client scrollable selectors

Adds a new scrollable-menu CSS class.  It's (provisionally?) limited to
larger screens, w/ the assumption that smaller screens handle scrolling
for you.

New class is applied to org unit selects only so far.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
Open-ILS/src/templates/staff/css/style.css.tt2

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: implement subfield stacking in MARC editor

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: add session-stickiness for MARC template selector

The new bib function now remembers the last MARC template
that was used for the lifetime of the browser tab.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: start teaching egHatch about sessionStorage

This patch adds getSessionItem(), setSessionItem(), and
removeSessionItem(), which are all wrappers around
$window.sessionStorage. This is done to support settings
whose values are sticky for the duration of a session,
which at present is the lifetime of the browser tab.

An alternative would be using session cookies; some user
testing is needed to see which lifetime makes the most
sense.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: improve how egVolumeList opens the vol/copy editor

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: teach volcopy editor how to set default item status

It now consults the cat.default_copy_status_fast and
cat.default_copy_status_normal library settings as appropriate.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: add ability to edit copies to the record merge interface

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: teach egVolumeList more tricks

The directive now accepts two new attributes:

* editVolumes - controls display of the 'Edit volumes' button
* editCopies - if true, adds a 'Edit volumes and copies button'

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: require SSL for /eg/staff/

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: force deletion of copies on "delete copies and volumes"

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: Protect against loops before cloning copy/volume data

Also, set proper defaults on newly added copies

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: fetch both staff_client and vandelay_queue record buckets

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: mark some egEmbedFrame bindings as optional

This gets rid of some noise in the browser console.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: fetch MVR to help build record summary

Although this adds another OpenSRF request, using the
MVR rather than fleshing simple_record() gives us
two benefits:

* getting access to the edition
* fields like title and author are now displayed in
  their proper case, rather than the normalized lowercase
  supplied by simple_record().

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: teach record summary how to display the bib call number

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: teach side-by-side editing to the record merge interface

It is now possible to edit the lead record in place (in
flat editor mode).

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: teach MARC editor some more tricks

[1] Now accepts a flat-only attribute specifying that
    the editor should be restricted to flat mode.
[2] Now accepts an embedded attribute specifying that
    various stuff that isn't useful when the editor
    is embedded in another control should be ignored.
[3] The width of the flat editor's textarea is now
    bounded by its container.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: display MARC records in merge interface in breaker format

Doing this will ease copy-and-paste between records.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: add egRecordBreaker directive

This directive takes a blob of MARCXML or a bib
record ID and renders the record in "breaker"
format.

Example usage:

  <eg-record-breaker record-id="1234"></eg-record-breaker>
  <eg-record-breaker marc-xml="xml"></eg-record-breaker>

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: Allow editing of empty volumes

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: fix saving copy price in vol/copy editor

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: unbreak tabs in volume/copy editor

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: teach the merge record dialog how to edit volumes

This adds an "edit volumes" button under each record in the
merge records interface that opens a modal embedding the
volume editor.

The embedding is done via an iframe in lieu of splitting the
relevant bits of the volume/copy editor into an independent
service.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: teach volcopy editor how to be embeddable

The route /eg/staff/cat/volcopy/$key/embedded will
load the volume/copy editor in an embedded mode; specifically,

[1] the navbar and record summary will not be displayed
[2] "Save & Exit" becomes "Save changes"

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: make record merge interface display volumes for all OUs

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: add unit test for egOrg.root()

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: add egOrg.root() method

Also, start adding some documentation for egOrg.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: go to lead record after merge from bucket

After a successful record merge initiated from a record
bucket, go to the lead record rather than refreshing
the bucket display.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: teach the record merge modal how to display volumes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: more changes to holdingsSvc

- convert holdingsSvc from a singleton to a provider
  of holdings service instance objects
- adjust the catalog app accordingly
- add a new egVolumeList directive that displays
  a list of volumes attached to a bib record, including
  owning library, call number, and copies

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: break holdingsSvc out of catalog/app.js

This will allow using its logic for constructing
volume/copy lists in other places.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: make overlay record modal wider

This patch defines a CSS class, eg-wide-modal, that can be
set as the windowClass of 'lg' Boostrap modals and increase
their width from a fixed width to 95% of the window.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: use tabset rather than accordion for bucket record merge modal

This stylistic change will pave the way towards
better side-by-side record management and editing in this
interface.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: move some "mark for" buttons to record summary

This patch moves the "Mark for..." overlay, volume transfer,
and conjoined items buttons from the MARC editor to
the record summary (next to the "Add To Bucket" button).

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: add drop-down for item type Z39.50 search field

It should be noted that this works *only* for OCLC, as
not all targets support use attribute 1001, and the list
of values for that use attribute are target-defined.

A more general solution might be creating a new
config.z3950_attr_value_list table.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: Use record, not owning_lib, for the part record field. Doh.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: tweak labels of remove from bucket actions

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: record buckets: implement show selected in catalog action

This replaces the show all in catalog action.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: Add a few important fields for the holdings view grid

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: Make the last applied template sticky

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: Improve combo box functionality

Clicking on down arrow shows all options (possibly following
filtered options)

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: Normalize the type of values going into in-memory objects

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: replace acn prefix()/suffix() with IDs only when needed

Fixes an issue that could break saving volumes.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: adjust URL when navigating catalog search results

Navigating from record to record after performing a catalog
search now sets the URL in the browser to /eg/staff/cat/catalog/record/{record_id}.
Clicking on the "Back To Results" button will set the URL
back to /eg/staff/cat/catalog/index.

This allows staff to copy and paste record URIs more conveniently.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: add angular-location-update dependency

This module adds a $location.update_path() routine to
allow changing the URL without forcing a controller reload.

This module is copyright (c) 2015 anglibs and released under
the MIT license and is taken from
https://github.com/anglibs/angular-location-update.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: fix issue loading egGrid config

Grid saveConfig can generate bad data (not sure how)
but we will avoid duplicates in loadConfig

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: Add a Save & Exit shortcut to the copy attribute editing pane

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: Avoid blowing away the volume value when there is no merge target

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: Pass IDs instead of objects for prefix and suffix

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: Special case for egOrgSelector value reading/writing in copy templates

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: stylistic fix for MARC editor

Prevent record type display from overlapping the
bibliographic source selector.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: tweak MARC editor in "edit overlay record"

The save button is now labeled "Modify"

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: give more feedback for Z39.50 edit-then-import

The "edit then import" modal now varies the label of the
MARC editor's save button based on whether one has yet
to import the current record or if one is just making
changes to it after having imported it. The dialog now
also has a button for going to the newly-imported record
in catalog view.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: provide feedback after record imported via Z39.50

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: teach egConfirmDialog how to set custom labels for buttons

egConfirmDialog() now accepts optional fourth and fifth
arguments to set custom labels for the "OK" and "cancel"
buttons.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: fix deleting fields in MARC editor

When editing a record that has not yet been saved
to Evergreen (either because it is new or because it
is a record coming from a Z39.50 target), ensure that
the context menu 'delete field' operation works.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: make some MARC editor strings translateable

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: Select on focus for tag, indicators, and sf codes

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

webstaff: Provide context menu options for adding and removing fields

TODO: i18n on strings

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1528596: Add another eval/warning check in marc_export.

This one checks if the $marc->insert_grouped_field for adding items
throws an error or warning.  This happened on my records with a bad
field that somehow made it through the conversion from XML.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1539088: marc_export prints "Waiting for input" when non-interactive

This commit modifies marc_export to only print "Waiting for input"
when run in an interactive manner.  This suppresses the output when
run from a pipe.

To test this change:

Before the commit is applied both of the following command lines will
output "Waiting for input" to standard error:

$ marc_export --format XML

$ echo <bibid> | marc_export --format XML

Where you replace <bibid> with a bibliographic record entry id from
your database.

After the commit is applied, only the first command line will output
the "Waiting for input" message.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

Forward port 2.9.0 to 2.9.1 db upgrade script.

Thanks to Benjamin Shum for noticing that this was missing.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

README: Note about web staff client prerequisites & developer prereqs.

If you're intalling on Debian Jessie or Ubuntu Trusty, you can skip
the manual installation of Node.JS is you've already installed the
<osname>-developer prerequisites.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

README: first draft changes to incorporate steps for new web staff client

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: Circulation - Patron Record web staff client updated content

There are still some sections missing, like 'Merging Patron Records'
and 'Bills and Payments'.

Signed-off-by: Yamil Suarez <yamil@yamil.com>

LP#1522538: Improper detection of jtitle search type

Before this change, the system would only check the first qtype URL parameter
to see if it needed to apply the journal title "bib_level(s)" filter.  Instead
it should check each qtype in turn while it turns an advanced search into a
simple search string.  Here the code is moved into place to accomplish that.

To test, load all test datasets into a fresh database.  Perform an advanced
search on journal title for "proceedings" (no quotes) using the second search
input row.  Before this commit, two records are retrieved.  After, only one
is retrieved.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP 1519465: POs with spaces in the name cause EDI problems.

This is a small modification to the regular expression for parsing
the id from the edi line item fields in EDIReader.pm that allows the
ids to parse correctly when the PO name contained a space or spaces
in it.  This change was suggesting by Bill Erickson (berick) in
http://irc.evergreen-ils.org/evergreen/2015-11-24#i_216736

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP1522686: Force SSL for Web Staff, Add Basic Redirect for Staff URL

1 minor change, 1 less minor change.

First, add a simple redirect for staff that forget to enter the
final '/' at the end of <server>/eg/staff/.

Second, and most importantly, force all connections to the web
staff client to be redirected through an HTTPS connection. By
default the system would accept whichever connection type you
enter by hand, and fewer and fewer people actually enter the
protocol specifier these days.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1530158: ensure that Business::OnlinePayment::PayflowPro is installed

Business::OnlinePayment::PayflowPro is a Perl module required if
the user wants to use PayflowPro as a credit card processor; without
it, attempts to make payments in TPAC using that processor will fail
with an internal server error.

This patch ensures that the module will get installed on Debian,
Ubuntu, and Fedora.

Strictly speaking, the Perl module is strictly optional, as
Business::OnlinePayment uses lazy loading for its drivers, but this
patch is making the assumption that its easiest all around if
we just install all dependencies that an Evergreen application
server might need.

To test
-------
[1] Install or upgrade Evergreen, then run settings-tester.pl to
    verify that the module is installed.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1526543 Truthiness check for reset_password is flawed

We expect boolean options in config.tt2 to be 'true' or 'false',
but the code was simple asking 'IF reset_password', which is true
for either value.

Instead, match on the string (as we do in other places).

To test:
- Load the stock catalog login page
- Notice the "Forgot your password?" link staying no matter which way
  'reset_password' is set in config.tt2
- Apply patch, and change 'reset_password' value in config.tt2 to 'false'
- RESULT: Password reset link doesn't show up

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>

Fixing upgrade 0950 upgrade script

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1319998 Stamping upgrade script

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP1319998_materialized_summary_billing_del_ADDS_to_balance_owed

Switched the plus sign to a minus sign. This will keep the
materialized view correct when deleting rows from money.billing.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1519925 - Allow MARC Federated Search to search UPC index of local catalog.

If a organization added UPC search for certain Z39.50 servers then the UPC search box
would display in the MARC Federated Search interface, but the local catalog would
not be searched.  This adds the ability to search the local catalog "Evergreen Catalog"
UPC index from that interface.

Confirm the Issue:

1. To trigger the initial problem you need a Z39.50 server setup that includes a UPC
Search.  For OCLC the following Z39.50 attributes add UPC searching.
Name:upc, Label:UPC, Code:1007, Format:4, Truncation:0

2. Now the MARC Federated Search should include a UPC search option.  Try searching
for a UPC that exists in the local catalog.  Nothing should come up.

After patch applied:

1. Now if you search for a UPC in the MARC Federated Search that you know exists,
it will show up.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Docs: fix typo for version upgrade 2.8.4-2.9.0 in server upgrade

Oops, got a little ahead of myself, this is more accurate.

Thanks to 2.9 RM Jason Stephenson for noting my mistake.

Signed-off-by: Ben Shum <bshum@biblio.org>

Docs: Missed some acknowledgements in the 2.9.1 point release notes

Missed a few ackwnowledgements in the release notes. Apologies to those who
I missed. Also added bshum since he made a doc change after the release notes
were merged.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: Change references to release 2.9.1

In the server upgrade docs, change references so that we are talking
about major series 2.9 now and note the latest version which is 2.9.1.

Signed-off-by: Ben Shum <bshum@biblio.org>

Docs: Addition to 2.8.5 point release notes

Last-minute addition to 2.8.5 release notes for miker's query parser fix.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: 2.8.5 point release notes

Adding bug fixes and acknowledgements for the 2.8.5 point release.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Adding bug fixes and acknowledgements to 2.9.1. Release Notes

The structure of these point release notes is a little different from what
we did with the 2.8 series. I restructured the headings a bit so that there
is just the one level one header. The two headers in the 2.8 release notes
led to a confusing outline.

Also, I'm adding acknowledgements for each point release rather than adding the
entire batch at the bottom of the file. There are two reasons for this change:

1. The release notes in the official documentation are broken up into different
sections, whereas the ones on the downloads page are available all on one page.
In the official docs, it appeared as if everyone being acknowledged had
contributed to the .0 release, when, in actuality, some had contributed patches
in other point releases. By adding acknowledgements to every point release
section, it is clear who contributed to which release.

2. Consistent contributors get acknolwedgement for every point release they
contribute to, which is a nice thing to do.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1516707: Phrase search ignores CD modifiers

Because phrases are subqueries, we need to look at the top of the parse tree
when looking for modifiers for cover density.  This is because modifers are
normally only allowed at the top of the parse tree (or in the floating sub-
query).  We do that by asking the plan's QueryParse for it's reference to its
parse_tree member, which is always the top of the parse tree in QP.

Included in this commit is a small change to the QP testing script to
facilitate testing of this fix.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP1402018_Acq_Copy_location_UI_scoped_to_registered_workstation

This little patch will open up the acq copy location dropdown UI
to include other library's copy locations outside of the workstation
registration. When the user permissions are scoped to more branches.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Fix LP1175711, OPAC can't renew item on booking resource list

A test sequence to show the behaviour before and after the fix:

1. Using staff client, check out an item to test account.
2. Go to Copy Details on the OPAC, click Book Now, and cancel the form;
the side effect is to put the item on the Resource list.
3. Using the OPAC on a web browser, log in with test account.
4. Go to Items Checked Out, select the item in the list and click Renew
Selected Items.

Before the fix, we saw the OPAC spin forever, and we saw the Javascript
console of the web browser log the error noted in previous comments.

With the fix, we see an error prompt saying, 'The system is unable to
renew the selected item at this time.  This usually means the item is
needed to fulfill a hold.  Please see a librarian for further help.'

Note: A patron with the normal group of permissions will not be able to
renew an item on resource list.

The fix is to check for an error object emitted by the function
Booking.pm/reservation_list_by_filters(), and to propagate it back to
the client, by returning a call to bail_on_events().

We also clarify the coding of the function's parameter list and how the
function checks for mandatory parameters.

Signed-off-by: Steven Chan <schan@sitka.bclibraries.ca>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP 1516786: 0938 Upgrade Script ends in END and not COMMIT.

Change the END; on the last line of 0938.data.some_rda_attributes.sql
to COMMIT; for reasons of consistency and to avoid issues when wrapped
in larger upgrade scripts using the make release script.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1513554 - Stamping Upgrade Script

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP#1513554 - Doc update for cancel reason selection

Adding an update to the docs to inform users that default cancel reasons
cannot be selected.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP#1513554 - Prevent deletion of reserved rows.

It was previously possible to delete reserved rows in
the acq.cancel_reasons table via the UI.  We take a belt
and suspenders approach here:

1) Grey out the checkboxes beside cancel reasons with an
   ID lower than 2000.
2) Create a trigger on the acq.cancel_reason table that
   prevents deletion of rows with an ID lower than 2000.

The trigger executes a new generally available function
for use in similar situations in the future.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP# 1483506 public.first_agg & public.first pgTAP tests

Signed-off-by: Yamil Suarez <yamil@yamil.com>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1483500 - pgtap Test for evergreen.lowercase

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Yamil Suarez <yamil@yamil.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1483508 PGTAP tests for text_concat / agg_text

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Update core committer information on the staff client's About Page

Welcome Kathy Lussier as the newest core committer for the Evergreen Project.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

lp1486294: Add sample order record file to datasets

Adding a sample order record file to the datasets that can be used for test
uploads against the current acq test data.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1486294 ACQ sapmle holding subfield maps

Collection of holding subfield map configurations for ACQ seed data
providers.  Maps for all providers are the same.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1486294 ACQ sample data

Sample ACQ data including:

* funding sources
* funds
* funding source credits
* fund allocations
* providers
* purchase orders
* lineitems (some canceled)
* lineitem details (copies, some canceled)
* fund_debits

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#937789: Stamping upgrade script for part deletion

Signed-off-by: Ben Shum <bshum@biblio.org>

LP#937789: Hide 'deleted' from parts table & editor

This commit hides the new parts 'deleted' field from the Manage Parts
dojo table and popup editor.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>