Galen Charlton [Fri, 23 Oct 2015 19:23:05 +0000 (19:23 +0000)]
LP#
1509479: fix infinite loop bug in QueryParser
An unclosed phrase search that has a modifier can cause QueryParser to
enter an infinite loop, tying up open-ils.storage backends.
Examples of such searches include:
-"cats and dogs
subject:+"physical chemistry
This patch fixes the bug by allowing the end of the query string
to terminate a phrase (in addition to a quotation mark).
To test:
[1] Verify that the t/21-QueryParser.t unit test passes
[2] To test in a *development* database, before applying the patch
run one of the example queries. Observe that no
results are returned, and that one of the open-ils.storage
drones is running at 100% CPU.
[3] Apply the patch and restart the open-ils.storage service.
[4] Try the query again; this time, it should return results
immediately without causing an open-ils.storage drone to
peg a CPU.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Bill Erickson [Mon, 12 Oct 2015 15:12:07 +0000 (11:12 -0400)]
LP#838525 DoB as date SQL upgrade repairs
1. Modify auditor.actor_usr_history DoB column in the same manner
as actor.usr to ensure consistent date truncation.
2. let update_auditors() recreate auditor.actor_usr_lifecycle for us.
3. Wrap the whole shebang in a PLPGSQL "DO" block so we can easily test
for the presence of optional reporter views that depend on actor.usr, so
they can be recreated as needed.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Remington Steed [Fri, 9 Oct 2015 18:58:01 +0000 (14:58 -0400)]
Docs: Rename bullet images to fix epub build error
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Remington Steed [Thu, 24 Sep 2015 15:09:33 +0000 (11:09 -0400)]
Release Notes: Move/copy relevant sections to Upgrade Notes
This commit moves two sections from "New Features -> Administration ->
Upgrade Notes" to the main level "Upgrade Notes" section, which had been
accidentally left empty and was causing AsciiDoc-to-ePub conversion
errors. This commit also copies two other sections to the main "Upgrade
Notes" section, since they contain information relevant to the upgrade
process.
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Jason Stephenson [Fri, 2 Oct 2015 14:17:09 +0000 (10:17 -0400)]
LP
1502156: Fix marc_export error when dumping authorities.
There is a chance that marc_export will attempt to call a nonexistent
field on MARC::Record if an error occurs while exporting authority
records. The bug could only be triggered if a conversion error
occurred while exporting the authority as either MARCXML or USMARC.
The fix is to rename a couple of variables in the Marque::Authority->next
method to be more like those used in Marque::Biblio->next. This will have
the side effect of making marc_export easier to maintain, since the
variables used in one method will now have the same meaning as those
in the other.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Remington Steed [Fri, 2 Oct 2015 13:41:39 +0000 (09:41 -0400)]
Docs 2.9: Add summary of Web Client changes
This commit adds the Web Client release notes summary to the appropriate
docs section. It also updates the wording and links regarding the
completed UI Style Guide internship.
Next we need to copy the Cataloging content into the web client section
and provide web client screenshots.
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Dan Scott [Thu, 1 Oct 2015 20:13:45 +0000 (16:13 -0400)]
Doc build: update the implicit ID for release notes
The implicit ID for a given heading changes each release as we update
the release notes, so bump 2.8 to 2.9 so that the reference to the ID
can be resolved.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Remington Steed [Thu, 17 Sep 2015 15:10:51 +0000 (11:10 -0400)]
Docs: Update release notes reference to 2.9
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Dan Scott [Thu, 1 Oct 2015 20:16:27 +0000 (16:16 -0400)]
Doc build: use the implicit ID for lib settings editor
We no longer have an explicitly set ID for the library settings editor
section, so update references to use the implicit ID instead.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Thu, 1 Oct 2015 20:15:12 +0000 (16:15 -0400)]
Doc build: link to the right media file
The screenshot for the list of call numbers is a PNG image, not a JPEG
image, so referring to it with the appropriate extension will make it
show up in the docs and enable the epub and PDF builds to successfully
complete.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Thu, 1 Oct 2015 20:11:57 +0000 (16:11 -0400)]
Doc build: use XML-compliant IDs
Doc builds that depend on an intermediate XML transform (epub, PDF) also
need to use IDs that comply to the XML standard. In this case, numbers
are not valid NameStartChars:
http://www.w3.org/TR/REC-xml/#NT-NameStartChar
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Thu, 1 Oct 2015 20:10:41 +0000 (16:10 -0400)]
Avoid duplicate IDs in doc build
Defining the same ID twice in the same document results in broken builds
that depend on an intermediate XML transform (epub, PDF), so redefine
the second ID in this document.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Mike Rylander [Thu, 1 Oct 2015 18:50:44 +0000 (14:50 -0400)]
Stamping upgrade script and test file
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Tue, 29 Sep 2015 16:10:53 +0000 (12:10 -0400)]
LP#838525 libdbi DATE types translated via gmtime
libdbi assumes a date (w/ no time or timezone) is GMT. Parse the date
via gmtime() instead of localtime() to ensure the date returned to the
caller matches the date in the DB.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Wed, 30 Sep 2015 16:13:21 +0000 (12:13 -0400)]
LP#838525 DoB as date PGTAP test
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Tue, 29 Sep 2015 16:10:31 +0000 (12:10 -0400)]
LP#838525 Store date of birth as SQL DATE type
Upgrade script translates DoB ahead 3 hours before translating to DATE
(from TIMESTAMPTZ) to ensure dates stored in alternate daylight savings
TZ (e.g. -05 vs. -04) are translated to the proper date.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Kathy Lussier [Thu, 10 Sep 2015 18:28:57 +0000 (14:28 -0400)]
Docs: Documentation for negative balance work
Documentation for negative balance settings in 2.9. The updates in this branch
include:
* Updates of the circulation, patron record, and library settings sections
to reflect the new features contained in the negative balance work.
* General updates, consolidation, and re-organization of some components
of the billing section.
A new understanding and confiuring billing section is still to come, but this
branch brings existing documentaiton up to date.
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Josh Stompro [Sun, 20 Sep 2015 15:43:10 +0000 (10:43 -0500)]
LP#
1497318 - Acknowledgments update Adding Northwest Regional Library System to 2.8 and 2.9
and Matthew Berowski for typo fixes to 2.8 Release Notes.
Signed-off-by: Josh Stompro <stomproj@larl.org>
Jason Stephenson [Fri, 18 Sep 2015 15:06:07 +0000 (11:06 -0400)]
LP
1497307: Fix 2.8.4 to 2.9.0 upgrade script.
Chris Sharp noticed another ERROR: cannot ALTER TABLE
"record_attr_definition" because it has pending trigger events
with the 2.8.4 to 2.9.0 upgrade script. I have rearranged the
transactions so that there are now 3.
1. One for the initial inserts and other changes up to 0937.
2. One for the two alter table statements in 0937.
3. One for 0938 to the end (0944).
This resolves the issue and works for me on an upgrade from a
clean 2.8.4 installation.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Kathy Lussier [Fri, 18 Sep 2015 14:06:31 +0000 (10:06 -0400)]
Docs: Restoring the acknowledgements template
Restoring the acknowledgements template back to **TO DO** so that we don't
mistakenly do acknowledgements for 2.9 contributions in 2.next.
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Jason Stephenson [Thu, 17 Sep 2015 19:12:40 +0000 (15:12 -0400)]
LP
1496977: Duplicate Code in OpenILS::Application::Cat::AssetCommon
It looks like two lines of code got duplicated in commit
e2f6cca0 in
AssetCommon. This duplication can lead to data loss for the function
update_fleshed_copies. It also lead to the following warning when
you use OpenILS::Application::Cat::AssetCommon in a script:
"my" variable $sc_entries masks earlier declaration in same scope at
/usr/local/share/perl/5.18.2/OpenILS/Application/Cat/AssetCommon.pm
line 371.
After this patch, the warning disappears.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Remington Steed [Thu, 17 Sep 2015 13:35:19 +0000 (09:35 -0400)]
Docs: Apache config includes examples for "no image"
This commit adds a note about the new commented config blocks in the
example Apache vhost file for providing a custom image for items with no
image. This commit also moves a related section into the "External
Content" section, so all external content info is together.
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Mike Rylander [Thu, 17 Sep 2015 12:24:56 +0000 (08:24 -0400)]
LP#
1496837: Postgres fixed a bug and broke our test
So, we will unbreak it here. The PG fix in question can be seen here:
http://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=
c975fa4713c2325623d7bbfd81806327234281ac
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Ben Shum [Thu, 17 Sep 2015 03:43:13 +0000 (23:43 -0400)]
Docs: Fix typo in acknowledgements for RELEASE_NOTES_2_9.txt
Signed-off-by: Ben Shum <bshum@biblio.org>
Ben Shum [Thu, 17 Sep 2015 03:09:11 +0000 (23:09 -0400)]
Docs: Add one missing entry to RELEASE_NOTES_2_9.txt
Because one of the notes was written with a .adoc extension
instead of the .txt, the automated script missed it.
Adding this entry to the main RELEASE_NOTES_2_9.txt file and
removing the .adoc file.
Signed-off-by: Ben Shum <bshum@biblio.org>
Jason Stephenson [Wed, 16 Sep 2015 22:08:37 +0000 (18:08 -0400)]
2.9 Release notes creation and cleanup
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Jason Stephenson [Wed, 16 Sep 2015 20:42:52 +0000 (16:42 -0400)]
Forward port 2.9.0 translations.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Jason Stephenson [Wed, 16 Sep 2015 21:41:46 +0000 (17:41 -0400)]
Porting 2.8.4->2.9.0 SQL upgrade
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Remington Steed [Wed, 16 Sep 2015 21:07:13 +0000 (17:07 -0400)]
Docs 2.9: Update and add detail for Holdings Import profile
In order to add details about the new ability to import Stat Cat data
for a copy, this commit adds a table of all the import fields available
in the Holdings Import Profile. It also duplicates some content from
another section about batch importing, and updates the screenshot and
some wording in the original section.
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Kathy Lussier [Wed, 16 Sep 2015 20:14:51 +0000 (16:14 -0400)]
Docs: 2.8 Acknowledgements addition
We missed acknowledgements for a few code contributors during the 2.8.3
point release. Adding them here as well as a fix to get the header to display
properly for the 2.8.4 release notes.
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Kathy Lussier [Wed, 16 Sep 2015 18:03:42 +0000 (14:03 -0400)]
Additions to the 2.9 release notes
Adjusting the release notes entry for conditional negative balances to reflect
recent changes in the code and adding ackwnowledgements. Also, cleaning up some
grammar and removing entries that already made it into point release notes as
bug fixes.
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Bill Erickson [Wed, 16 Sep 2015 19:20:49 +0000 (15:20 -0400)]
Porting 2.8.3->2.8.4 SQL upgrade
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Kathy Lussier [Wed, 16 Sep 2015 18:33:37 +0000 (14:33 -0400)]
2.8.4 release notes
Release notes for the 2.8.4 point release.
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Jason Stephenson [Wed, 16 Sep 2015 17:30:02 +0000 (13:30 -0400)]
LP#
1494544 Stamping Upgrade Script
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Dan Wells [Tue, 15 Sep 2015 19:28:44 +0000 (15:28 -0400)]
LP#
1494544 Complete XUL UI for adjustment vs. void options
This commit does several things to complete the adjustment UI changes.
1) Adds "Adjust to Zero" to the "Actions" menu. It was previously only
on the right-click popup.
2) Shows or hides the void/adjustment controls based on permissions.
3) Generates a new force-verified warning if you attempt to void, but
there is also some chance that doing so would be contrary to your
negative balance policy settings.
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Dan Wells [Mon, 14 Sep 2015 15:12:38 +0000 (11:12 -0400)]
LP#
1494544 Add ADJUST_BILLS permission to seed data
This commit adds the new ADJUST_BILLS permission to the seed data.
Note that the upgrade script only adds the perm and avoids adding it
to any groups, as that should only be done with local discretion.
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Victoria Lewis [Thu, 16 Jul 2015 20:07:04 +0000 (13:07 -0700)]
webstaff: LP#
1437110 add Manual Floating Active
Add Manual Floating Active to Checkin Modifiers in web staff client.
Signed-off-by: Victoria Lewis <“vlewis@catalystitservices.com”>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Wed, 16 Sep 2015 14:28:46 +0000 (10:28 -0400)]
webstaff: LP#
1436980: Default copy circ count to 0 instead of undefined
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Victoria Lewis [Fri, 24 Jul 2015 22:08:15 +0000 (15:08 -0700)]
webstaff: LP#
1436980 Total Circulations in Patron Bills
Add code to display Total Circulations in
Item Summary on Bills page.
Signed-off-by: Victoria Lewis <vlewis@catalystitservices.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Stephen Moss [Tue, 18 Aug 2015 18:28:25 +0000 (11:28 -0700)]
webstaff: LP#
1483857 Add code to clear barcodes from in-house use
Signed-off-by: Stephen Moss <smoss@catalystitservices.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Tue, 15 Sep 2015 21:32:41 +0000 (17:32 -0400)]
webstaff: Provide hooks for on-save callback for marc edit to, for instance, refresh the record summary UI
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Galen Charlton [Tue, 15 Sep 2015 01:22:12 +0000 (01:22 +0000)]
webstaff: record summary now signals if record is deleted
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Kathy Lussier [Fri, 11 Sep 2015 17:54:32 +0000 (13:54 -0400)]
lp1494427: Fix refund error
Fixes an error that occurs when attempting to refund a negative balance from
the patron's bill record. We removed the staff.patron.bills.handle_refund.
confirm_message string, which caused the error when the handle_refund function
tried to retrieve the string. It turns out the string never displayed in the
client. Therefore, in this branch, we stop the handle_refund function from
trying to retrieve the string. I did the confirmation message for the
adjust_to_zero function since the same issue was occurring there.
Test case: Find a negative balance transaction and, from the patron's bills
record, select the transaction and select the option to Refund. Pre-patch, this
action will generate an error message. Post-patch, this action should generate
a prompt asking the user to confirm the action.
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Jason Stephenson [Mon, 14 Sep 2015 20:08:06 +0000 (16:08 -0400)]
Fix typo in comment in 002.schema.config.sql.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Jason Stephenson [Mon, 14 Sep 2015 19:55:26 +0000 (15:55 -0400)]
LP
1495509: Stamping upgrade scripts.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Galen Charlton [Mon, 14 Sep 2015 15:34:47 +0000 (15:34 +0000)]
LP#
1489955: tweak to work on PostgreSQL 9.1
Stored functions written in SQL cannot use parameter
names in their bodies until Pg 9.2.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Galen Charlton [Mon, 14 Sep 2015 13:08:12 +0000 (13:08 +0000)]
webstaff: update release notes for sprint 2
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Galen Charlton [Fri, 11 Sep 2015 13:40:30 +0000 (13:40 +0000)]
webstaff: explicitly pass record type to MARC editor from Z39.50
This fixes a bug where the Edit then Import action would
pop up an empty MARC editor.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mike Rylander [Thu, 10 Sep 2015 19:09:22 +0000 (15:09 -0400)]
webstaff: Remove dependency-suggesting indent from "Use checkdigit" default
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mike Rylander [Thu, 10 Sep 2015 19:08:07 +0000 (15:08 -0400)]
webstaff: Propagate changes to barcode auto-gen defaults immediately
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mike Rylander [Thu, 10 Sep 2015 17:16:20 +0000 (13:16 -0400)]
webstaff: Add barcode generation and checkdigit checking
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Galen Charlton [Thu, 10 Sep 2015 15:01:42 +0000 (15:01 +0000)]
webstaff: tweak Phys Char Wizard layout
Ensure that if a drop-down is particularly wide, it
can no longer overlap with the previous/next buttons.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Bill Erickson [Thu, 10 Sep 2015 00:52:14 +0000 (20:52 -0400)]
webstaff: Phys Char Wiz various additions and repairs
* Show <unset> as selector value when no value is selected
* Properly handle gaps (undefined slots) in 007 field value
* Return to origin value when dialog Cancel is chosen
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Bill Erickson [Tue, 8 Sep 2015 13:23:02 +0000 (09:23 -0400)]
webstaff: Phys Char Wiz : wizard continued
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Bill Erickson [Tue, 8 Sep 2015 00:37:40 +0000 (20:37 -0400)]
webstaff: Phys Char Wiz : wizard continued
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Bill Erickson [Mon, 7 Sep 2015 17:46:01 +0000 (13:46 -0400)]
webstaff: Phys Char Wiz : initial dialog / wizard
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Bill Erickson [Mon, 7 Sep 2015 15:51:39 +0000 (11:51 -0400)]
webstaff: Phys Char Wiz : launcher link
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Bill Erickson [Mon, 7 Sep 2015 15:23:48 +0000 (11:23 -0400)]
webstaff: Phys Char Wiz : initial service funcs
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Galen Charlton [Thu, 10 Sep 2015 01:06:01 +0000 (01:06 +0000)]
webstaff: implement Transfer Title Holds from record bucket
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mike Rylander [Thu, 10 Sep 2015 00:15:33 +0000 (20:15 -0400)]
webstaff: Allow optional override of TITLE_LAST_COPY event
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Jason Etheridge [Wed, 9 Sep 2015 22:02:06 +0000 (18:02 -0400)]
webstaff: Transfer Copies to Marked Volume
in Copy Bucket
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mike Rylander [Wed, 9 Sep 2015 23:51:27 +0000 (19:51 -0400)]
webstaff: Allow editing of /only/ volume data
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mike Rylander [Wed, 9 Sep 2015 23:51:06 +0000 (19:51 -0400)]
webstaff: Allow adding vol/copy to an empty bib (or when no vol/lib is selected)
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Galen Charlton [Wed, 9 Sep 2015 22:56:08 +0000 (22:56 +0000)]
webstaff: implement Merge Selected Records from record bucket
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mike Rylander [Wed, 9 Sep 2015 20:26:44 +0000 (16:26 -0400)]
webstaff: Add "add items to bucket" action to holdings maint
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mike Rylander [Wed, 9 Sep 2015 17:57:41 +0000 (13:57 -0400)]
webstaff: Refactor replace-barcode to be reusable, and reuse it in holdings maint
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mike Rylander [Wed, 9 Sep 2015 14:17:05 +0000 (10:17 -0400)]
webstaff: Conjoined items management
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Galen Charlton [Tue, 8 Sep 2015 21:47:49 +0000 (21:47 +0000)]
webstaff: ensure that side-by-side MARC record views don't overlap text
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Galen Charlton [Tue, 8 Sep 2015 21:42:49 +0000 (21:42 +0000)]
webstaff: Z39.50: unbreak MARC editor embedded in overlay
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Galen Charlton [Tue, 8 Sep 2015 20:44:00 +0000 (20:44 +0000)]
webstaff: flat MARC editor now updates model on blur, not change
This fixes a problem where attempting to type in the flat
MARC editor would result in a fromBreaker()/toBreaker() cycle
being run with each keystroke, which (among other things) made
the user have to fight for control of the insertion cursor.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Galen Charlton [Tue, 8 Sep 2015 19:33:00 +0000 (19:33 +0000)]
webstaff: fix a thinko when saving default Z39.50 targets
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Jason Etheridge [Tue, 8 Sep 2015 18:10:33 +0000 (14:10 -0400)]
webstaff Z39.50: don't risk letting default_targets be undefined
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mike Rylander [Tue, 8 Sep 2015 19:27:22 +0000 (15:27 -0400)]
webstaff: Conjoined item attach-inator
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Galen Charlton [Tue, 8 Sep 2015 19:16:28 +0000 (19:16 +0000)]
webstaff: implement add to record bucket from catalog view
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mike Rylander [Tue, 8 Sep 2015 18:42:36 +0000 (14:42 -0400)]
webstaff: More default values for required fields
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mike Rylander [Tue, 8 Sep 2015 16:38:24 +0000 (12:38 -0400)]
webstaff: Add support for the fast-add copy status org setting
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Galen Charlton [Tue, 8 Sep 2015 16:07:36 +0000 (16:07 +0000)]
webstaff: implement saving default Z39.50 targets
Also make the target password input field's type be
"password".
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mike Rylander [Tue, 8 Sep 2015 15:47:49 +0000 (11:47 -0400)]
webstaff: Use ids for prefix, suffix, label_class
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mike Rylander [Tue, 8 Sep 2015 15:47:27 +0000 (11:47 -0400)]
webstaff: Protect the cloner from undefined values
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mike Rylander [Fri, 4 Sep 2015 20:47:43 +0000 (16:47 -0400)]
webstaff: MARC editor button layout improvement
Also, add mark-vol-transfer-dest and mark-conjoined-dest
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Jason Etheridge [Wed, 12 Aug 2015 17:52:05 +0000 (13:52 -0400)]
webstaff: use localStorage for the overlay-record selection
in the Import Record from z39.50 interface
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Jason Etheridge [Thu, 3 Sep 2015 05:49:19 +0000 (01:49 -0400)]
webstaff: add Mark as Overlay Target to MARC editor
no bells and whistles though :)
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mike Rylander [Fri, 4 Sep 2015 19:32:35 +0000 (15:32 -0400)]
webstaff: Add confirmation before deleting copies/volumes
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mike Rylander [Fri, 4 Sep 2015 17:59:14 +0000 (13:59 -0400)]
webstaff: Allow deleting copys/vols ... need a speed bump?
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mike Rylander [Fri, 4 Sep 2015 17:57:16 +0000 (13:57 -0400)]
webstaff: Add a save-and-continue mode
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mike Rylander [Fri, 4 Sep 2015 17:56:33 +0000 (13:56 -0400)]
webstaff: Provide a fieldmapper-aware cloning method
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mike Rylander [Fri, 4 Sep 2015 14:56:56 +0000 (10:56 -0400)]
webstaff: Make next-barcode-on-enter happy
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mike Rylander [Fri, 4 Sep 2015 12:47:03 +0000 (08:47 -0400)]
webstaff: Enable Fast Item Add functionality in the MARC editor, and improve button layout
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Galen Charlton [Thu, 3 Sep 2015 21:47:25 +0000 (21:47 +0000)]
webstaff: add additional FF definitions for authority records
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Galen Charlton [Thu, 3 Sep 2015 21:27:25 +0000 (21:27 +0000)]
webstaff: put heading validation lookups in a promise chain
Doing this to avoid spamming potentially a couple dozen
authority record lookups all at once.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Galen Charlton [Thu, 3 Sep 2015 21:13:27 +0000 (21:13 +0000)]
webstaff: improve performance of open-ils.search.authority.simple_heading.from_xml
Searching authority.record_entry by comparing are.simple_heading
with the results of authority.simple_normalize_heading() can result
in bad query plans; if we calculate the results of that function
first, we have a much better chance of hitting the index on
simple_heading.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Galen Charlton [Thu, 3 Sep 2015 20:26:24 +0000 (20:26 +0000)]
webstaff: add Validate (headings) button to MARC editor
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mike Rylander [Thu, 3 Sep 2015 18:24:16 +0000 (14:24 -0400)]
webstaff: Add Request Items to copy buckets
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Galen Charlton [Thu, 3 Sep 2015 17:17:59 +0000 (17:17 +0000)]
webstaff: prune empty fields and subfields before saving MARC record
This implements functionality that was handled server-side
by the XUL staff client.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mike Rylander [Thu, 3 Sep 2015 16:42:33 +0000 (12:42 -0400)]
webstaff: Add modal "request items" to holding view
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Galen Charlton [Thu, 3 Sep 2015 16:03:05 +0000 (16:03 +0000)]
webstaff: make authorityControlSet in egTagTable actually be a singleton
This resolves an issue where the control set can be incompletely
initialized when jumping from creating a new bib to opening
in in catalog view.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Galen Charlton [Thu, 3 Sep 2015 15:47:21 +0000 (15:47 +0000)]
webstaff: implement Create New MARC Record
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mike Rylander [Thu, 3 Sep 2015 13:54:33 +0000 (09:54 -0400)]
webstaff: Edit items from copy buckets
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mike Rylander [Thu, 3 Sep 2015 13:11:30 +0000 (09:11 -0400)]
webstaff: Support adding copies and volumes
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mike Rylander [Thu, 3 Sep 2015 12:21:20 +0000 (08:21 -0400)]
webstaff: Transfer volume and item actions
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
projects / evergreen / pines.git / log