erickson [Thu, 12 Aug 2010 12:57:13 +0000 (12:57 +0000)]
avoid confusion by not installing the non-functional GenerateBatchOverduePDF reactor with the seed data.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17185
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Thu, 12 Aug 2010 07:42:20 +0000 (07:42 +0000)]
Remove broken old JavaScript in Google Book preview code
I /think/ this was supposed to change the title of the "Preview" link to
"Read this online" or the like in the case that the full text is available,
but it was relying on a function that didn't exist (setText) and trying
to reference an ID that didn't exists. So it broke in those rare cases
where Google Books did provide the full text.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17181
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Thu, 12 Aug 2010 03:22:10 +0000 (03:22 +0000)]
Complain when a sequence name is not qualified by a schema.
M Open-ILS/src/c-apps/idlval.c
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17180
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Thu, 12 Aug 2010 01:23:58 +0000 (01:23 +0000)]
register the autoloader earlier, and log about the use it gets
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17179
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Wed, 11 Aug 2010 20:59:25 +0000 (20:59 +0000)]
Plug some memory leaks.
In many places we were creating dbi_results without freeing them;
pretty much everything involving transactions, savepoints,
inserts, updates, and deletes.
M Open-ILS/src/c-apps/oils_sql.c
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17177
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Wed, 11 Aug 2010 20:42:07 +0000 (20:42 +0000)]
Gave the base login code the ability to find username/password from a
cookie. for security reasons, we don't put login data into cookies, but if the
login info is available to us in that format already (say, via external means), we'll
use it. This can be useful for persistent logins (e.g. self-check) or
automatic logins (pushing cookie data out to workstations)
Minor cleanup of the login code to make it more re-use friendly.
Added self-check support for verifying the staff login before each patron
login.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17176
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Wed, 11 Aug 2010 20:40:07 +0000 (20:40 +0000)]
redundant with util_overlay.xul
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17175
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 11 Aug 2010 20:18:26 +0000 (20:18 +0000)]
Use a COALESCE/NULLIF nested structure instead of CASE (one branch, easy peasy) for 4x speedup in the core search query
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17174
dcc99617-32d9-48b4-a31d-
7c20da2025e4
atz [Wed, 11 Aug 2010 15:57:14 +0000 (15:57 +0000)]
Respect activate_po option in interface
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17171
dcc99617-32d9-48b4-a31d-
7c20da2025e4
atz [Wed, 11 Aug 2010 15:57:13 +0000 (15:57 +0000)]
Add page title and tidy up
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17170
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 11 Aug 2010 13:29:31 +0000 (13:29 +0000)]
missed one fix in previous optimisation effort
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17169
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Wed, 11 Aug 2010 06:44:42 +0000 (06:44 +0000)]
tweak the layout for the volume/copy creator so that buttons/etc are always on-screen, with just the input textboxes in the scrollable area
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17168
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Wed, 11 Aug 2010 06:33:37 +0000 (06:33 +0000)]
change Check Barcodes? checkbox in Volume/Item creator to Use Checkdigit. In addition to checking the barcodes, it also dictates whether the Auto-Generate Barcodes function will use checkdigits or not
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17167
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Wed, 11 Aug 2010 06:33:34 +0000 (06:33 +0000)]
tweak auto-barcode method to support barcodes of arbitrary length. trims last digit from seed barcode if 9 or 14 digits. works with alphanumeric barcodes like b1, test1, demo1 with no checkdigits (so it'll generate demo2, demo3, etc.)
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17166
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Wed, 11 Aug 2010 02:18:47 +0000 (02:18 +0000)]
added an UI for editing vandelay import item attribute definitions. it's a basic autogrid version for now. TODO: fix some grid height styling issues
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17165
dcc99617-32d9-48b4-a31d-
7c20da2025e4
senator [Tue, 10 Aug 2010 21:12:56 +0000 (21:12 +0000)]
Acq: fix certain dialogs needlessly flashing on-screen while li_table loads
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17161
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Tue, 10 Aug 2010 21:10:53 +0000 (21:10 +0000)]
bug 592777: allow authoritative version of open-ils.circ.retrieve
Part of a fix to avoid race condition that can occur
when patron renews an item in the OPAC in a database
that uses pgpool and replication, which sometimes
results in an erroneous 'action_circulation_not_found' error.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17160
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Tue, 10 Aug 2010 18:31:33 +0000 (18:31 +0000)]
use staff query for lineitem->bib linking ui
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17158
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Tue, 10 Aug 2010 18:23:26 +0000 (18:23 +0000)]
fix age protection proximity test for in-DB circ
Patch from John Craig.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17153
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Tue, 10 Aug 2010 17:18:06 +0000 (17:18 +0000)]
Two things: 1) match old output, with rows for no holdings 2) calculate transcendance only once per function call
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17152
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Tue, 10 Aug 2010 16:16:53 +0000 (16:16 +0000)]
replace this broken regexp with cleanse_ISO8601
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17151
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Tue, 10 Aug 2010 16:16:49 +0000 (16:16 +0000)]
easier to read and corrected regexp for munging iso8601 dates so that they're usable by dojo
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17150
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Tue, 10 Aug 2010 14:45:21 +0000 (14:45 +0000)]
similar to findbib, replace dojox.data.dom.textContent (which fails for unknown reasons) with node.textContent for bibtemplate rendering in related lineitems page
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17149
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Tue, 10 Aug 2010 13:13:23 +0000 (13:13 +0000)]
aaaaand, another typo of the r17147 ilk
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17148
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Tue, 10 Aug 2010 12:38:20 +0000 (12:38 +0000)]
repaired typo/pasto in copy vis upgrade script
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17147
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Mon, 9 Aug 2010 21:50:27 +0000 (21:50 +0000)]
removed executable bit from files that don't need it set
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17146
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 9 Aug 2010 21:05:24 +0000 (21:05 +0000)]
Create the label_class object if null was returned from the method call
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17145
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 9 Aug 2010 20:57:33 +0000 (20:57 +0000)]
Copy/paste-o; asset.call_number ne asset.call_number_class
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17144
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Mon, 9 Aug 2010 20:54:35 +0000 (20:54 +0000)]
In order to speed up the API call where we ask for the number of visible (or total, in the staff client), available and "unshadow" (aka total) copies, as well as record transcendance visiblity, we create here 10 stored procedures. Eight of them implement the record/metarecord, staff/opac, OU/lasso varients, and two more are wrappers simplifying the calling API.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17143
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 9 Aug 2010 20:43:53 +0000 (20:43 +0000)]
SQL 101: Remember to name all of the columns before you insert values into said columns
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17142
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 9 Aug 2010 20:33:26 +0000 (20:33 +0000)]
Teach the staff client volume copy creator to respect OU call number preferences
To teach the "Add volumes" dialog in the staff client how to show the correct
set of call numbers based on the workstation OU's default classification
scheme, this commit:
* Adds a column "field" to the asset.call_number_class table that specifies
the list of tag/subfield combinations to search for a candidate call number
for a given classification scheme
* Adds a new OU setting, 'cat.default_classification_scheme', that points
to the asset.call_number_class ID
* Extends the open-ils.cat.biblio.record.marc_cn.retrieve method to support
a second argument, identifying the classification scheme for the call
number extraction
* Fixes the IDL for asset.call_number_class to include the ID as an explicit
field
* Makes the "Add volumes" dialog look up the 'cat.default_classification_scheme'
setting for the workstation OU and apply that to the call to the
open-ils.cat.biblio.record.marc_cn.retrieve method
TODO:
* Provide a means of switching the classification scheme for the current volume,
repopulating the call number selector widget
* Save the chosen scheme as part of the acn object
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17141
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Mon, 9 Aug 2010 18:30:25 +0000 (18:30 +0000)]
Add middle layer functions for maintaining actor.usr_saved_search.
M Open-ILS/src/perlmods/OpenILS/Application/Actor.pm
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17140
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 9 Aug 2010 14:45:26 +0000 (14:45 +0000)]
And... keep the index creation on asset.call_number in the right place
There's tears in my coffee. These are not tears of joy.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17139
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 9 Aug 2010 14:37:20 +0000 (14:37 +0000)]
And let's create those new auditor columns first, before any changes ripple through the base table
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17138
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Mon, 9 Aug 2010 14:35:16 +0000 (14:35 +0000)]
combine circ and user fetch into 1 cstore call for SIP items. minor cleanup
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17137
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 9 Aug 2010 14:33:52 +0000 (14:33 +0000)]
Avoid the NOT NULL problem on the auditor table by not creating the constraint in the first place
The auditor schemas will be different for a from-scratch DB vs an upgraded database,
but just like the would-be iPhone purchaser says, "I don't care."
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17136
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 9 Aug 2010 13:48:45 +0000 (13:48 +0000)]
Get the entries into asset.call_number_class before altering asset.call_number
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17135
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 9 Aug 2010 13:13:36 +0000 (13:13 +0000)]
Patch from Ben Ostrowsky <ben@esilibrary.com> to specify "staff account" in proxied pages
This change will make it a bit more clear that we're not looking for a
patron barcode/PIN in the Selfcheck Login screen (and make the wording
consistent across similar login pages).
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17131
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Sat, 7 Aug 2010 03:53:01 +0000 (03:53 +0000)]
Basic call-number sorting by classification scheme
Until now, call numbers like 'K 22 .U748 v.18' and 'K 215 .E53 W37 1997' would
sort incorrectly in Evergreen, making call number browsing painful.
The following patch adds the following to Evergreen to support better call
number sorting:
* asset.call_number gains two new columns:
- label_class - identifies the classification scheme for the given callnumber
- label_sortkey - holds the normalized callnumber suitable for sorting
* a new table, asset.call_number_class, which holds the names of each
classification scheme and the name of the assorted normalization function
* implementations of three normalization functions:
* a generic normalizer
* a Dewey Decimal Classification normalizer (courtesy the Koha project)
* an LC classification normalizer (courtesy Bill Dueber's Library::CallNumber::LC)
* a routine in Makefile.install to checkout and install Library::CallNumber::LC
* call number sorting routines were modified to use label_sortkey instead of
label, where I could find them
* corresponding changes to fm_IDL.xml for the new columns + table
A suggested means for applying this to an existing library would be to issue
update statements against asset.call_number setting label_class to the value
in asset.call_number_class that corresponds to owning_lib's scheme, for example:
UPDATE asset.call_number SET label_class = 3 WHERE owning_lib IN (4,5);
We need to teach the staff client holdings maintenance interfaces how to set
the classification scheme for a given call number, and we should also create
an org_unit setting that can set the preferred default classification scheme
that the staff client should inherit. Or maybe we could just make that a
sticky value and have a BEFORE trigger check the incoming value of label_class
and only set it to the org_unit default value if it is NULL (to support bulk
loads).
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17130
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Sat, 7 Aug 2010 03:26:11 +0000 (03:26 +0000)]
Build 210.serial before 200.acq, because 200.acq references serials
Confusing due to the order implied by the filename numbers, but priority
has to be on getting trunk to build cleanly again; we can sort out a
better way later.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17129
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Sat, 7 Aug 2010 02:24:46 +0000 (02:24 +0000)]
Functionality-affecting typo: subjet -> subject
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17128
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 6 Aug 2010 21:04:19 +0000 (21:04 +0000)]
add some tests for copy existence in checkin routines
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17127
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Fri, 6 Aug 2010 20:39:35 +0000 (20:39 +0000)]
bug 532217: work around caching issue resulting doubled title display
Quick hack shamelessly borrowed from Dan Scott to fix problem
of title being displayed twice on bib details page when back
button is used in OPAC or staff client.
This is a temporary fix in lieu of rewriting the bib details
display to use BibTemplate exclusively.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17126
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Fri, 6 Aug 2010 19:45:49 +0000 (19:45 +0000)]
menu.js and patron/display.js were passing xulG functions to browser.js differently. This makes browser.js a little smarter (so that it doesn't trampled xulG-destined members sent via passthru_content_params) and sidesteps some security blockers with inspecting xulG. xulG is a namespace/object for shoving foreign data and/or functions into a given window
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17122
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 6 Aug 2010 19:37:08 +0000 (19:37 +0000)]
repaired circ-mod retrieval call to use retrieve instead of search
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17121
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Fri, 6 Aug 2010 18:12:14 +0000 (18:12 +0000)]
Index the internal bib id and tcn value to make searching simpler
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17120
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Fri, 6 Aug 2010 15:33:11 +0000 (15:33 +0000)]
Refine the way we detect loss of the database connection.
This is a terrible, horrible, no good, very bad kludge.
We do an innocuous SELECT 1. If this query succeeds, then we know that the
connection is still good. If it fails, well...
Sometimes the SELECT 1 query fails, not because the database connection is dead,
but because (due to a previous error) the database is ignoring all commands,
even innocuous SELECTs, until the current transaction is rolled back. The only
known way to detect this condition via the dbi library is by looking at the error
message returned by dbi_conn_error(). This approach will break if the language
or wording of the message ever changes.
Note: the dbi_conn_ping function purports to determine whether the database
connection is live. At this writing, it follows the same approach as described
above: try a SELECT 1 and see if it works. Consequently it presumably suffers
from the same shortcoming: it may erroneously report a dead connection when the
database is in fact just ignoring commands due to a previous error. In addition,
if it determines (rightly or wrongly) that the connection is dead, it silently
tries to reconnect; if the reconnect is succesful, the function reports that the
connection is still alive, as if nothing had happened. If you were in the middle
of a transaction at the time, you wouldn't know that it got rolled back.
M Open-ILS/src/c-apps/oils_sql.c
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17118
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Fri, 6 Aug 2010 14:45:31 +0000 (14:45 +0000)]
added CentOS/RHEL packages for Business::ISBN and friend
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17117
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Fri, 6 Aug 2010 01:21:31 +0000 (01:21 +0000)]
bug 614150: bail out on ACTOR_USER_NOT_FOUND
This fixes a bug where uploading an offline checkout
that refers to a missing patron returns an INTERNAL_SERVER_ERROR
instead of ACTOR_USER_NOT_FOUND. More generally, this avoids
an exception in case case where a circ operation is made
without checking the existence of the patron record beforehand.
mk_env could use a better name, too.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17113
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Fri, 6 Aug 2010 00:49:37 +0000 (00:49 +0000)]
bug 614132: fix glitch when used cached permission group widget
Fixes bug where the initial permission group value in a circ or
hold matrix entry was not displayed when editing an
existing matchpoint.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17108
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 5 Aug 2010 21:16:01 +0000 (21:16 +0000)]
Fixed form validation with surveys (the filteringSelect dijits were treating themselves as invalid if not set)
Some I18N for form validation
Removed some lingering (and annoying) scrollOnFocus behavior with the non-autoField widgets
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17107
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 5 Aug 2010 20:19:48 +0000 (20:19 +0000)]
added oils_obj:required attrs for circ_matrix_matchpoint
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17106
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 5 Aug 2010 20:19:47 +0000 (20:19 +0000)]
honoring IDL 'required' attr for autofieldwidget for styling
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17105
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 5 Aug 2010 20:19:46 +0000 (20:19 +0000)]
updated IDL parser to 1) load oils_object:required attr at field level
instead of class level and 2) added the oils_persist:i18n attr as
another field-level boolean
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17104
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 5 Aug 2010 19:08:08 +0000 (19:08 +0000)]
fix open-ils.circ.prev_renewal_chain.retrieve_by_circ.summary to return the correct user for the previous circ chain, and some debugging tweaks to Item Status Alternate View and avoid a widget collision with hold patrons
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17103
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 5 Aug 2010 16:27:49 +0000 (16:27 +0000)]
repaired primary key column; removed trailing semi's from SQL
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17102
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 5 Aug 2010 16:02:05 +0000 (16:02 +0000)]
prev commit left some un-esacped <'s. fixed
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17101
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Thu, 5 Aug 2010 15:30:51 +0000 (15:30 +0000)]
speed up open circ counting and listing
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17100
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Thu, 5 Aug 2010 15:24:23 +0000 (15:24 +0000)]
Correcting some mistakes. Sequence names must be qualified by schema.
M Open-ILS/examples/fm_IDL.xml
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17099
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 5 Aug 2010 15:21:01 +0000 (15:21 +0000)]
Log the found matchpiont with indb circ policy test
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17098
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 5 Aug 2010 15:21:00 +0000 (15:21 +0000)]
return the matched circ rule during inspect
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17097
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Thu, 5 Aug 2010 14:40:40 +0000 (14:40 +0000)]
The old default skin is the new default skin
We need people willing to maintain the craftsman skin, as it is falling
behind "default" in functionality and goes for long periods in a broken state.
This change gives Evergreen the most functional and most likely to work skin
by default, which is important for making positive first impressions on
possible adopters of the project.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17096
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Thu, 5 Aug 2010 14:27:08 +0000 (14:27 +0000)]
Remove OpenILS::Utils::FlatXML - code that has been unused since before 1.0
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17095
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 5 Aug 2010 14:17:37 +0000 (14:17 +0000)]
removed some deprecated code
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17094
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 5 Aug 2010 07:50:37 +0000 (07:50 +0000)]
disable Create/Modify button in item attribute editor if Required fields are Unset
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17093
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 5 Aug 2010 07:50:35 +0000 (07:50 +0000)]
fix color highlighting for xulrunner 1.9.2
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17092
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 5 Aug 2010 07:50:33 +0000 (07:50 +0000)]
the caption id was important after all, for keyboard navigation
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17091
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 5 Aug 2010 04:46:38 +0000 (04:46 +0000)]
updating some auditor tables that were causing problems in cstore with missing columns, but not sure how to reset the _lifecycle views
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17090
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Thu, 5 Aug 2010 04:10:57 +0000 (04:10 +0000)]
Fix typo in --boostrap option, keeping it as an alias for possible automated scripts
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17089
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Thu, 5 Aug 2010 03:03:15 +0000 (03:03 +0000)]
bug 613703: normalize backdate on item checkin better
Fixes bug that appears to cause all checkins uploaded
via offline circ to fail with an "invalid date format"
error.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17088
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Wed, 4 Aug 2010 22:28:34 +0000 (22:28 +0000)]
add Required to copy stat cat editor, add User Summary to patron stat cat editor for initial stat cat creation, and fix a bug where editing an existing copy stat cat would attempt to set usr_summary. Modified behavior a bit so that an update is attempted whenever the user presses update, and not just if data is changed (this was me punting instead of trying to modify the test for both copy and patron stat cats)
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17084
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Wed, 4 Aug 2010 22:09:30 +0000 (22:09 +0000)]
no need to search for patron summary, instead retrieve directly by usr id
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17083
dcc99617-32d9-48b4-a31d-
7c20da2025e4
senator [Wed, 4 Aug 2010 21:22:40 +0000 (21:22 +0000)]
Provide a handy method for dojo-based interfaces to correctly show timestamps
from fieldmapper object fields.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17082
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Wed, 4 Aug 2010 20:43:44 +0000 (20:43 +0000)]
required column for item stat cats
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17081
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 4 Aug 2010 20:36:10 +0000 (20:36 +0000)]
allow ACQ-driven ordering and claiming of serial items
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17080
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Wed, 4 Aug 2010 20:19:14 +0000 (20:19 +0000)]
require latest last_xact_id for payments
To prevent accidental multiple payments on the transaction or payments
against stale information, require the latest user last_xact_id to be
passed into the payment API call. Update staff client (thanks jason)
and self-check payment interfaces to match.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17079
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Wed, 4 Aug 2010 19:56:26 +0000 (19:56 +0000)]
tweak to item attribute editor to support hiding of fields with cat_custom.css
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17078
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 4 Aug 2010 19:46:59 +0000 (19:46 +0000)]
a glue method used to apply a template to a set of records
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17077
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 4 Aug 2010 19:12:58 +0000 (19:12 +0000)]
segregate the old version of facet-modified JS to be craftsman-specific
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17076
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Wed, 4 Aug 2010 18:57:21 +0000 (18:57 +0000)]
Firefox is picky about having attribute values quoted, let's oblige it
Still some generated dojo.query() expressions throwing warnings but we can tackle those... later
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17075
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Wed, 4 Aug 2010 18:45:02 +0000 (18:45 +0000)]
Close LP bug 613551 - JS error in Internet Explorer from google.loader.callbacks.books
Bizarre, this line does not appear to be necessary at all. Vamoose it.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17074
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Wed, 4 Aug 2010 14:46:17 +0000 (14:46 +0000)]
updated patron fee amount call to use cstore for speed
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17073
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Wed, 4 Aug 2010 08:48:50 +0000 (08:48 +0000)]
print missing pieces slip
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17072
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Wed, 4 Aug 2010 08:48:47 +0000 (08:48 +0000)]
previous changes to better support the embedded browser Print button broke printing elsewhere
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17071
dcc99617-32d9-48b4-a31d-
7c20da2025e4
atz [Wed, 4 Aug 2010 03:56:35 +0000 (03:56 +0000)]
Simple 1-line feature for EDI translator
Allows us to know what the effective version of openils-mapper is.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17070
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Tue, 3 Aug 2010 20:45:45 +0000 (20:45 +0000)]
New org unit setting type: serial.prev_issuance_copy_location
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0359.data.setting-prev-iss-copy-loc.sql
M Open-ILS/src/sql/Pg/950.data.seed-values.sql
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17069
dcc99617-32d9-48b4-a31d-
7c20da2025e4
atz [Tue, 3 Aug 2010 20:21:56 +0000 (20:21 +0000)]
0358 more values for acq.cancel_reason
Note: we won't be using all of them, the set is just there for completeness.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17068
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Tue, 3 Aug 2010 20:11:22 +0000 (20:11 +0000)]
added open-ils.circ.copy.due_date.retrieve API call to return the due date for a given copy if it's circulating. method does not require auth, so only the due date is exposed, not the circ or user, etc.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17067
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Tue, 3 Aug 2010 03:14:49 +0000 (03:14 +0000)]
Slight overhaul of ISBN indexing focused on the translate_isbn1013 function
* Switch to a PLPERLU function built on Business::ISBN for more robust
indexing of records with problematic ISBNs; thanks to Jason Stephenson
<jstephenson@mvlc.org> for the initial implementation
* Remove the first_word, naco_normalize, and split_date_range normalizers
from the indexing chain for ISBNs, as these unnecessarily munge the
ISBNs. We can trust Business::ISBN to determine what is a real ISBN,
hyphens and all.
* Index all ISBNs in a given record and generate the corresponding
ISBN10/ISBN13 variations. Also, fix the checksum if given an ISBN with
a bad checksum, but be sure to index the original bad-checksum ISBN as
well.
* Add a set of 10 MARC records with bad ISBNs (thanks to Jason Stephenson
again for these) for testing purposes to Open-ILS/tests/datasets
* Add the Business::ISBN Perl module as a prerequisite to the installer
* Remove contrib/isn from the PostgreSQL install instructions
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17066
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Tue, 3 Aug 2010 02:24:24 +0000 (02:24 +0000)]
Correct DDL for creating a fresh schema - match upgrade 0356
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17065
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Mon, 2 Aug 2010 20:01:04 +0000 (20:01 +0000)]
escape more in the cn label for browse xml
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17064
dcc99617-32d9-48b4-a31d-
7c20da2025e4
atz [Mon, 2 Aug 2010 19:16:02 +0000 (19:16 +0000)]
0356 fixup - the updates otherwise failed for syntax or dependent constraints
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17063
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Mon, 2 Aug 2010 17:17:55 +0000 (17:17 +0000)]
create correct primary key constraints for some view-based / inheritted tables
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17062
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Mon, 2 Aug 2010 15:00:51 +0000 (15:00 +0000)]
update schema list for Slony replication
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17061
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Mon, 2 Aug 2010 14:17:02 +0000 (14:17 +0000)]
toward printing slip and letter for missing pieces
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17060
dcc99617-32d9-48b4-a31d-
7c20da2025e4
atz [Fri, 30 Jul 2010 20:27:14 +0000 (20:27 +0000)]
Admin Menu link for viewing EDI Messages
Modifies and uses the existing page for viewing one PO's messages.
TODO: Other kinds of filtering/searching.
TODO: Display PO number where name unavailable.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17059
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 29 Jul 2010 23:12:34 +0000 (23:12 +0000)]
repaired copy/paste thinko in the vandelay auto-overlay-with-merge-profile logic
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17058
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Thu, 29 Jul 2010 21:08:36 +0000 (21:08 +0000)]
This patch replaces the result page sidebar new-search trees
(implemented before "faceting" became a thing, and designed for
new-search, not drill-down) with and implementation of what has become
the generally accepted "way to do faceting". This is implemented as a
Dojo Dijit, and the markup and code footprints within the OPAC proper
are small, just a couple <div>s and a little bit of glue code to help
the facet rendering engine find the data it needs. The set and order
of facet classes to display in a given facet bar (title, author,
subject, etc) is configurable in the markup, as are the number of
values displayed for each facet when collapsed (before the [More...]
button is pushed).
Also included is a Searcher Dijit which implements an embeddable
advanced search interface. This is mainly useful for constructing
boolean-chained searches (we support AND and OR now, though they're
spelled && and || in the query string), and has the beginnings of
support for filters and modifiers.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17057
dcc99617-32d9-48b4-a31d-
7c20da2025e4
senator [Thu, 29 Jul 2010 18:54:07 +0000 (18:54 +0000)]
Acq: better labels for adding catalog record based item to PL or PO
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17055
dcc99617-32d9-48b4-a31d-
7c20da2025e4
atz [Thu, 29 Jul 2010 17:08:37 +0000 (17:08 +0000)]
Need to die if we fail to find a picklist, symmetric to the top of the conditional.
Otherwise, we crash out on $conn->respond($picklist->id);
git-svn-id: svn://svn.open-ils.org/ILS/trunk@17054
dcc99617-32d9-48b4-a31d-
7c20da2025e4