LP1952931 ASN eg2 lint repairs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN support Ingram message format (PCI field)

Includes change to allow skipping line items that have no container
code, which happens with Ingram messages sometimes.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN dry run fixes / Notifed Count repair

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 Disable try run by default; focus input on load

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 Receive Shipment AngJS menu entry

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN disable Dry-Run by default

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 More data loading indictor support

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 Blocking receiving before container fully loads

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN EDI can contain multiple containers

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 LI# link goes to LI items fix

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 LI# link goes to LI items; show title in summary

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 Copy upgrade SQL to base schema

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 Stamping process date and processed

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 Add process date and processed by fields

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 Handle barcode not found

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 Unrelated ng build --prod fix

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN Receiving...

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN Receiving UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN Perl Test

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN receiving UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN shipment notifiation IDL

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN receiving UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN shipment notifiation Perl Test

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN shipment notifiation Perl

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN shipment notifiation Perl Test

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN shipment notifiation Perl

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 ASN shipment notification SQL

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 Parsing DESADV EDI Messages

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1952931 Parsing DESADV EDI Messages

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1942220: add confirmation step to deleting LIs

- also tidy up when the action is avaialble
- also tidy up handling of selected LIs post-deletion
- also reload the page only once
- add TODO about decreasing parallelism
- TODO: toss up spinner?

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1942220: teach LI title sort to ignore common articles

Also move a couple convenience methods related to LI sorting
to LineitemService

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1942220: bump up hardcoded LI retrieval limit back to 10000

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1942220: extend the active LI sort order to PO printing

Note that this reimplements the sorting client-side.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1942220: wording tweaks

- "Copy Location" => "Shelving Location"
- "Zero-Copy" => "Zero-Item"

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1942220: improvements to cancel dialog

- add recordType parameter so that wording can be adjusted
  based on what is to be cancelled
- expand the wording to make it (hopefully) crystal clear
  what to do
- show all cancel reasons upon combobox click

TODO: pluralization for the more-than-one-LI case

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1942220: tweak LI actions around viewing/updating items

- Added "Update Barcodes" as a new LI action that opens the
  item attributes editor
- Changed the "Holdings Maintenance" LI action to open the
  record holdings view page rather than spawning the item
  attributes editor, making it match the behavior of the
  "Holdings Maint." LI action in the Dojo interface.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1929749: point to new PO interface if creating a PO

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1929749: fix lint

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929749 Finetuning LMOR based on LP comments

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1929749: Adds support for picking up library settings.

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929749 ACQ Load MARC Order Records port

[Note that this includes some work by Galen Charlton to reconcile
 the picklist module with work done by Bill Erickson for LP#1929741]

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1942220: link to the Angular PO interface acq search results

Note that this does /not/ follow the setting to display
links to the "experimental" Angular acquisitions interfaces; my
intention is to replace that with a different setting that,
when enabled, provides links to the Dojo interfaces from the
corresponding Angular interfaces.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1942220: start adding filtering to the LI table

TODO:

- publication date age filter
- filereader for 'terms from file'
- claim count and item count filters

Note that this is following the acquisitions search form, not the grid
filters

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1357037: seed data - WS for LI sort order

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1357037: add sorting option to Angular line item lists

This applies to the line item lists in the following new
Angular interfaces:

- purchase order
- selection list
- list of line items related to a bib record

The available sort options are:

- line item ID
- title
- author
- publisher
- order identifier (i.e., ISBN, ISSN, and/or UPC)

The method open-ils.acq.lineitem.unified_search is now used to retrieve
line items to make use of existing sorting functionality.

The last sort order used is persistant via a workstation setting

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1929741: repair adding brief record from PL page

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1942220: implement 'Create Invoice from Selected Lineitems' action

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1942220: hook up claim policies

- Display claim policy (if set) in the LI table
- Add the 'Apply Claim Policy to Selected Lineitems' action

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Brief record for PO repair

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Standalone brief record UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LPLP1929741 Optional experimental Acq; seed data

Adds and org setting and a workstation setting to 1) enable display of
experimental Angular ACQ UI's and 2) enable display of links to the
experimental UI's from search results.

Display a new menu entry "Acquisitions (Experimental)" when the org
setting is enabled.  This menu contains "Create Purchase Order" only for
now.

Copy seed data from upgrade file to seed data file.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Welcome page navigates to staff w/ href

When a route failure occurs, etc. and the user is sent back to the
Welcom to Webby page, make the link to the staff page an href instead of
a routerLink, so Angular is forced to load new route data.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Change Op displays failed permission

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 cleanup more PO subs

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Clear previous PO on new PO create

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 cleanup PO subscription; improve charges display

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Fund limit/sort on new charges

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 ng lint

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1928258 Combobox sanity checks

Avoid failures caused by calling toLowerCase() on a number.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Item location select starts with; hide Unset

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Combobox supports startsWith search (p2)

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Blanket order finalizing; improved charges handling

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Sort funds by year desc, then code

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Batch of PO fixes

* Avoid clearing the owning library during batch edit copy operations
* Leverage combobox startsWith for distribution formulas
* Disable the order ident selector so it cannot be modified after a PO
  is activated
* Add some icons to the PO actions for more eye-grabbiness.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Combobox supports startsWith search

In lieu of the default behavor of the typeahead, which does a 'contains'
search.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 ACQ order ident indicate multiples

When multiple order identifer values (e.g. ISBN's) exist on a lineitem,
the number of options is now displayed just to the left of the
identifier selector.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Apply default lineitem order identifers

Apply a default order identifier to lineitems instead of leaving the
selector blank.  Ensure the value that will display in the selector
matches what's in the database by setting the value on load when needed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Bundle of ACQ bug fixes

* Distribution formula combobox now displays entries on click
* Ditto Charge Type combobox
* Items now vanish when deleted
* Estimated amount, etc. update when items are added/deleted
* Lineitem action links match order of previous interface.
* PO dry run checks now fire after a brief record is added
* PO activation is blocked if an item has no owning lib.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Delete action trumps ischanged for LID's

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Cache LI after order ident change

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Lineitem delete repairs

Allow deleting lineitems on PO's for certaian states.

Fix lineitem delete code issues.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 View/Place orders sorts newest to oldest

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Limit to active providers; skip empty name picklist

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 AnJS nav create po goes to new UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Improve catalog service sanity check

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Repair 'Create Invoice' link

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Zero-copy and no-assets PO activation

And summary layout improvements.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Ensure PO items always display when present

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 View/Place Orders UI

View/Place orders from a bib record and add/create selection lists or
PO's from the record.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Display copy row number in copy edit grid

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 ACQ caching / batch editing improvements

Ensure that funds/mods/locations of modified copies are available at
render time after saving changes to copies.

Hide the copy batch update bar when no copies are editable.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Combobox additional sanity checks on async/IDL values

1. Avoid PCRUD queries where the selected id value is set to null.
2. Avoid attempts to add null entries to the async entry cache.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Sanity check distrib. formula values

No fields within a distribution formula are required, so confirm a set
of values exists before calling Object.keys() on an undefined value.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Angular Selection List / Po Seed Data

PO and lineitem worksheet print templates.

Workstation preferences for grids and lineitem list page size.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 ACQ Selection List & PO Angluar Port

New selection list UI
New PO UI
New Lineitem worksheet UI with stub print template
New PO print UI with stub print template
New brief record UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Combobox idl auto query filter addition

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Combobox asyncSupportsEmptyTermClick fix

Fixes situation where combobox would fetch the needed entries in async
mode, but fail to open the drop-down after a click.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1929741 Net service tidier request logging

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1959048: add release notes

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1959048: manual ng lint fixes

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1959048: Run ng lint --fix

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1959048: run ng g @angular-eslint/schematics:convert-tslint-to-eslint

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1957179: improve saving of templates in Angular holdings editor

This patch makes the following improvements to the handling
of holding templates in the Angular holdings editor:

- templates are now saved to the cat.copy.templates user setting,
  matching the AngularJS holdings editor
- toast is displayed upon saving or deleting a template
- upon saving a completely new template, re-style it in the
  combobox so that it no longer has the new-and-freetext
  styling

To test
-------
[1] Apply the patch and open the Angular holdings editor.
[2] Verify that once a template is saved or deleted, that
    refreshing the Angular holdings editor will show the
    updated list of templates.
[3] Verify that toast is displayed upon saving or deleting
    a template.

Note that because of a quirk in how user settings are cached by
the web staff client, if you are testing in more than one browser
(but with the same user account), if you save a template in one
browser, you'll need to log out and back in with the second browser
to see the changes.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP#1980887: fixes cases where shelving location selector didn't work

This patch fixes an issue where the Angular shelving location selection
component (eg-item-location-select) wouldn't work (in particular,
when its contextOrgIds wasn't set, as opposed to contextOrgId).

Coding note: TypeScript confounds the Perl programmer: an empty array
evaulates to true; .length needs to be checked instead.

To test
-------
[1] Apply the patch.
[2] Verify that the shelving location selector works in the following
    interfaces:

    - Acquisitions Administration -> Distribution Formuals
    - Course Materials (in the material form for a course)
    - Linked locations for Circulation Limit Sets

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

Docs: correction to Global Flags docs

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

LP#1989348: set default new record via route data

Allows us to set defaultNewRecord on BasicAdminPageComponent via route data

Signed-off-by: Julian Clementson <51331324+oajulianclementson@users.noreply.github.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP#1920268: properly align titles in Bootstrap search results, regardless of cover art

The changes in this commit were proposed by Eva Cerninakova.

Co-authored-by: Eva Cerninakova <cerninakova@jabok.cz>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

Docs: adding Global Flags documentation

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

LP#1986725: restore portrait/landscape choice when printing from Angular

This patch works around a default setting in Bootstrap 4 that specifies
A3 as the paper size for printing. Specifying any paper size like this
causes Chrome and Firefox to stop offering the users the option to
choose the paper orientation.

My testing suggests that specifying A3 as the default paper size also
resulted in the printed text using a smaller font size when printing
on US paper sizes. Some sort of scaling down from A3 to letter,
perhaps.

To test
-------
[1] Open the Angular Holds Pull List, select a branch that has items
    to pull, and click the Print Full List button. Observe that the
    browser print dialog does not offer an option to choose the
    orientation.
[2] As above, but for any Angular grid's Print Full Grid action.
[3] Apply the patch and repeat 1 and 2. This time, the browser print
    dialog should offer the option to select the orientation.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1947045: add release notes entry

Also do some tidying of other miscellaneous release notes
entries.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>