evergreen/bjwebb.git
14 years ago* Using lineitem estimated_unit_price to store the price instead of the lineitem...
erickson [Tue, 9 Mar 2010 20:24:14 +0000 (20:24 +0000)]
* Using lineitem estimated_unit_price to store the price instead of the lineitem attrs
* If necessary, perform the currency conversion exactly once, when the order is activated.  Otherewise, assume the price is in the currency of the vendor.
* Create fund debits during PO activation instead of PO creation time.
* Cleared out a pile of deprecated code
* TODO: update JEDI template to pull price from the estimated_price_field

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15769 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoteach vandelay.strip_field() how to handle lists of complex field specs (ie: 100d...
miker [Tue, 9 Mar 2010 18:55:13 +0000 (18:55 +0000)]
teach vandelay.strip_field() how to handle lists of complex field specs (ie: 100d,245c,650); add vandelay.add_field() which will transfer fields from an incoming record to an incumbent record; add vandelay.replace_field() and vandelay.preserve_field(), which are wrappers that use strip and add

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15768 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years ago1. Add estimated_unit_price column to acq.lineitem.
scottmk [Tue, 9 Mar 2010 17:22:52 +0000 (17:22 +0000)]
1. Add estimated_unit_price column to acq.lineitem.

2. Bring acq.acq_lineitem_history and acq.acq_purchase_order_history
into sync with their respective source tables.

M    Open-ILS/src/sql/Pg/200.schema.acq.sql
M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0183.schema.acq-cancel-reason-history.sql
M    Open-ILS/examples/fm_IDL.xml

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15767 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoforgot this safety net
phasefx [Tue, 9 Mar 2010 17:09:29 +0000 (17:09 +0000)]
forgot this safety net

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15766 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAbility to auto-generate barcodes in the Volume/Copy dialog. Takes the first barcode...
phasefx [Tue, 9 Mar 2010 17:05:16 +0000 (17:05 +0000)]
Ability to auto-generate barcodes in the Volume/Copy dialog.  Takes the first barcode entered and generates subsequent barcodes using the typical library/codabar checkdigit algorithm if the barcodes are 13-14 digits, otherwise, just incrementing them without checkdigits.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15765 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoFix a NULL pointer problem that, under some circumstances, could segfault.
scottmk [Tue, 9 Mar 2010 04:53:52 +0000 (04:53 +0000)]
Fix a NULL pointer problem that, under some circumstances, could segfault.

The get_primitive() function was returning NULL in some cases, and the calling
code didn't check for NULL.

Fix: return "string" as the default datatype.

M    Open-ILS/src/c-apps/oils_cstore.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15751 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoWe like SQL that doesn't contain syntax errors!
dbs [Tue, 9 Mar 2010 02:51:21 +0000 (02:51 +0000)]
We like SQL that doesn't contain syntax errors!

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15743 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadded auto_merge_vols option to open-ils.cat.asset.volume.fleshed.batch.update. ...
erickson [Mon, 8 Mar 2010 21:29:50 +0000 (21:29 +0000)]
added auto_merge_vols option to open-ils.cat.asset.volume.fleshed.batch.update.  when changing the label (or owner or bib) for a volume creates a collision against an existing volume, auto-merge (or override) will merge the contents of the edited volume into the existing volume

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15741 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoMethods to retrieve lineitems with PO's associated with a specific bib.
phasefx [Mon, 8 Mar 2010 19:51:15 +0000 (19:51 +0000)]
Methods to retrieve lineitems with PO's associated with a specific bib.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15739 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoacq cancel reason administration interface. TODO: add staff client menu entries
erickson [Mon, 8 Mar 2010 19:50:45 +0000 (19:50 +0000)]
acq cancel reason administration interface.  TODO: add staff client menu entries

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15738 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadded org util method to find the full path for an org unit, where the full path...
erickson [Mon, 8 Mar 2010 19:43:33 +0000 (19:43 +0000)]
added org util method to find the full path for an org unit, where the full path is all ancestors, the context org, and all children, as an ordered list of nodes or IDs.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15737 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agopcrud delete is no more, use eliminate
erickson [Mon, 8 Mar 2010 19:42:24 +0000 (19:42 +0000)]
pcrud delete is no more, use eliminate

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15736 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoMake permissions for administering triggers more usable out of the box:
dbs [Mon, 8 Mar 2010 19:25:53 +0000 (19:25 +0000)]
Make permissions for administering triggers more usable out of the box:
  * Add CREATE/DELETE/UPDATE/VIEW variants to the generic ADMIN
  * Add ADMIN/CREATE/DELETE/UPDATE trigger permissions to Local System Administrator group at System depth
  * Add VIEW trigger permissions to Local System Administrator at Consortial depth to enable cloning

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15735 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadded pcrud entries for po notes
erickson [Mon, 8 Mar 2010 18:57:47 +0000 (18:57 +0000)]
added pcrud entries for po notes

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15734 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAdd a cancel_reason column to acq.user_request, pointing to acq.cancel_reason.
scottmk [Mon, 8 Mar 2010 15:53:07 +0000 (15:53 +0000)]
Add a cancel_reason column to acq.user_request, pointing to acq.cancel_reason.

Also: corrected the IDL entries for similar columns elsewhere.  The <link>
should have a reltype of "might_have", not "has_a", since the column is nullable.

M    Open-ILS/src/sql/Pg/200.schema.acq.sql
M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0181.schema.acq-user-request-cancel-cause.sql
M    Open-ILS/examples/fm_IDL.xml

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15733 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoBatch barcode editing and copy (item attribute) editor tweaks. A few things here...
phasefx [Mon, 8 Mar 2010 15:31:03 +0000 (15:31 +0000)]
Batch barcode editing and copy (item attribute) editor tweaks.  A few things here, and I apologize for not cherry-picking into separate commits:

* Modified the volume/copy creator to serve double-duty as an existing copy rebarcoder UI.  This also gets us closer to being able to shove in existing pre-cats as an alternative cataloging workflow to transfering pre-cats to
targeted volumes.

* Tested this out as a Replace Barcode replacement in Holdings Maintenance, but the real motivator was for the Update Barcodes link for lineitems in acquisitions.

* The volume/copy interface now has two options, the new one bypasses the item attribute editor and creates or modifies the items instantly.

* Button labeling tweaks in the item attribute editor.

* Allow folks to change the item status for new copies.  I can't recall the rationale for disallowing this in the first place, but I've heard enough arguments asking for us to allow this.  If need be, we can wrap it in a perm if
folks do want to lock it down .  We may also want to implement an org setting at some point for configuring the default status.

TODO: Replace "Replace Barcode" with this in Item Status UI

TODO: Allow batch call number editing.  There's an existing UI for this, but we need something in the context of acquisitions for taking care of those autogenerated call numbers and barcodes in one shot.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15732 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadded pcrud entries for lineitem retrieval
erickson [Mon, 8 Mar 2010 14:28:44 +0000 (14:28 +0000)]
added pcrud entries for lineitem retrieval

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15731 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoplugged in fund search format. it's like label format, except the search format...
erickson [Mon, 8 Mar 2010 13:59:56 +0000 (13:59 +0000)]
plugged in fund search format.  it's like label format, except the search format gives us the type-ahead searching and it defines the format of the data in the value field of the select widget

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15730 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoInstall the action_trigger_runner example config file
dbs [Mon, 8 Mar 2010 03:14:02 +0000 (03:14 +0000)]
Install the action_trigger_runner example config file

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15727 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAdded comments; tinkered with white space here and there.
scottmk [Sun, 7 Mar 2010 19:33:15 +0000 (19:33 +0000)]
Added comments; tinkered with white space here and there.

Rearranged the code a bit for clarity, without changing functionality.

In doFieldMapperSearch():

- Renamed meta to class_meta, in order to distiguish it from method metadata.
- Rename obj to row_obj, which is more descriptive, and moved its declaration
  closer to its first use.
- Moved the declaration of dedup and links closer to their first uses.

In oilsMakeFieldmapperFromResult():

- Moved the declarations of several variables closer to their first uses.
- Eliminated a couple of unnecessary calls to memset().

M    Open-ILS/src/c-apps/oils_cstore.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15726 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoTidied up white space, mostly by changing indentation from
scottmk [Sat, 6 Mar 2010 17:28:47 +0000 (17:28 +0000)]
Tidied up white space, mostly by changing indentation from
spaces to tabs, and by breaking up excessively long lines.

Added or modified a few comments.

No substantive changes.

M    Open-ILS/src/c-apps/oils_cstore.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15725 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years ago1. In verifyObjectClass(): renamed meta to method_meta in order to distinguish
scottmk [Fri, 5 Mar 2010 20:32:19 +0000 (20:32 +0000)]
1. In verifyObjectClass(): renamed meta to method_meta in order to distinguish
it from class metadata.  Rearranged a bit for clarity.

2. Added or tweaked some comments.

M    Open-ILS/src/c-apps/oils_cstore.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15722 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agocomplete the transition from delete() to eliminate()
miker [Fri, 5 Mar 2010 19:57:06 +0000 (19:57 +0000)]
complete the transition from delete() to eliminate()

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15721 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoForward port r15718 from rel_1_6_0: improved date/time formatting in My Account
dbs [Fri, 5 Mar 2010 19:27:45 +0000 (19:27 +0000)]
Forward port r15718 from rel_1_6_0: improved date/time formatting in My Account

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15720 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAdd a new permission, ADMIN_ACQ_CANCEL_CAUSE
scottmk [Fri, 5 Mar 2010 19:15:26 +0000 (19:15 +0000)]
Add a new permission, ADMIN_ACQ_CANCEL_CAUSE

Add two rows of seed data for acq.cancel_reason

M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0180.data.acq.cancel-reasons.sql
M    Open-ILS/src/sql/Pg/950.data.seed-values.sql
M    Open-ILS/examples/fm_IDL.xml

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15717 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoprovide formatters for translation grid cells; move some inline js to the end, as...
miker [Fri, 5 Mar 2010 16:58:40 +0000 (16:58 +0000)]
provide formatters for translation grid cells; move some inline js to the end, as the nodes referenced to exist yet; fix a couple typos/double-pastes

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15714 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAdd permissions for IMPORT_ALT_TCN and ADMIN_TRIGGER_EVENT_DEF to upgrade and seed...
dbs [Fri, 5 Mar 2010 16:52:34 +0000 (16:52 +0000)]
Add permissions for IMPORT_ALT_TCN and ADMIN_TRIGGER_EVENT_DEF to upgrade and seed data

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15713 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadded support for overriding the searchAttr in addition the labelAttr. This is neces...
erickson [Fri, 5 Mar 2010 16:47:53 +0000 (16:47 +0000)]
added support for overriding the searchAttr in addition the labelAttr.  This is necessary when using HTML labelAttrs, which do not work in type-ahead or in display fields

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15712 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadded ability to use an external function (bypassing pcrud) for retrieving linked...
erickson [Fri, 5 Mar 2010 15:20:34 +0000 (15:20 +0000)]
added ability to use an external function (bypassing pcrud) for retrieving linked data lists

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15707 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAdd a cancel_reason column to acq.lineitem_detail, pointing to
scottmk [Thu, 4 Mar 2010 22:11:29 +0000 (22:11 +0000)]
Add a cancel_reason column to acq.lineitem_detail, pointing to
acq.cancel_reason.  See KCLS ticket #3015.

M    Open-ILS/src/sql/Pg/200.schema.acq.sql
M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0178.schema.acq.lid-cancel-reason.sql
M    Open-ILS/examples/fm_IDL.xml

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15705 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoCreate new table acq.cancel_reason.
scottmk [Thu, 4 Mar 2010 21:31:55 +0000 (21:31 +0000)]
Create new table acq.cancel_reason.

Create new columns pointing to it in acq.purchase_order and
acq.lineitem.

See KCLS ticket #3015.

M    Open-ILS/src/sql/Pg/200.schema.acq.sql
M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0177.schema.cancel_reason.sql
M    Open-ILS/examples/fm_IDL.xml

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15704 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agocorrect the script type
miker [Thu, 4 Mar 2010 20:25:20 +0000 (20:25 +0000)]
correct the script type

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15703 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoMORE: convert from permacrud to pcrud -- not as big as it looks -- and move some...
miker [Thu, 4 Mar 2010 20:20:30 +0000 (20:20 +0000)]
MORE: convert from permacrud to pcrud -- not as big as it looks -- and move some startup logic to the top (even though yslow will hate me)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15702 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoMORE: convert from permacrud to pcrud -- not as big as it looks -- and move some...
miker [Thu, 4 Mar 2010 20:11:59 +0000 (20:11 +0000)]
MORE: convert from permacrud to pcrud -- not as big as it looks -- and move some startup logic to the top (even though yslow will hate me)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15701 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoMORE: convert from permacrud to pcrud -- not as big as it looks -- and move some...
miker [Thu, 4 Mar 2010 20:07:40 +0000 (20:07 +0000)]
MORE: convert from permacrud to pcrud -- not as big as it looks -- and move some startup logic to the top (even though yslow will hate me)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15700 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoMORE: convert from permacrud to pcrud -- not as big as it looks -- and move some...
miker [Thu, 4 Mar 2010 20:05:51 +0000 (20:05 +0000)]
MORE: convert from permacrud to pcrud -- not as big as it looks -- and move some startup logic to the top (even though yslow will hate me)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15699 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoMORE: convert from permacrud to pcrud -- not as big as it looks -- and move some...
miker [Thu, 4 Mar 2010 19:49:03 +0000 (19:49 +0000)]
MORE: convert from permacrud to pcrud -- not as big as it looks -- and move some startup logic to the top (even though yslow will hate me)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15698 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoconvert from permacrud to pcrud -- not as big as it looks -- and move some startup...
miker [Thu, 4 Mar 2010 19:33:29 +0000 (19:33 +0000)]
convert from permacrud to pcrud -- not as big as it looks -- and move some startup logic to the top (even though yslow will hate me)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15697 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAdd two columns, both intervals, both nullable:
scottmk [Thu, 4 Mar 2010 17:42:02 +0000 (17:42 +0000)]
Add two columns, both intervals, both nullable:

 acq.provider.default_claim_interval
 acq.lineitem.claim_interval

See KCLS ticket #3012.

M    Open-ILS/src/sql/Pg/200.schema.acq.sql
M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0176.schema.acq.claim_interval.sql
M    Open-ILS/examples/fm_IDL.xml

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15696 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoforward-porting r15694: preserve time component of original circ when backdating...
miker [Thu, 4 Mar 2010 16:19:14 +0000 (16:19 +0000)]
forward-porting r15694: preserve time component of original circ when backdating -- mainly to avoid over-voiding billings

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15695 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoWhen the patron search interface is spawned from the patron registration interface...
phasefx [Thu, 4 Mar 2010 15:27:56 +0000 (15:27 +0000)]
When the patron search interface is spawned from the patron registration interface for listing potential duplicate patrons, correctly handle the horizontal patron summary setting.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15690 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoSlightly rearranged the treatment of transaction ids so as to avoid
scottmk [Thu, 4 Mar 2010 05:04:58 +0000 (05:04 +0000)]
Slightly rearranged the treatment of transaction ids so as to avoid
repeated calls to getXactId().  Also: when committing or rolling back,
return the transaction id from getXactId() instead of referencing the
session_id of the application session.

In dispatchCRUDMethod: Added comments.  Renamed meta to method_meta
to distinguish it from class metadata.  Avoid unnecessary lookups of
the class metadata.  Rearrange things a bit for clarity.

M    Open-ILS/src/c-apps/oils_cstore.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15689 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agowrap labelFormat formatting in try/catch to present better errors to caller
erickson [Wed, 3 Mar 2010 23:00:23 +0000 (23:00 +0000)]
wrap labelFormat formatting in try/catch to present better errors to caller

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15688 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoCommit Jason Etheridge's base vimrc as some semblance of coding conventions
dbs [Wed, 3 Mar 2010 21:31:19 +0000 (21:31 +0000)]
Commit Jason Etheridge's base vimrc as some semblance of coding conventions

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15687 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoPatch from Galen Charlton <gmc@esilibrary.com> to prevent one bad MARC record from...
dbs [Wed, 3 Mar 2010 21:08:08 +0000 (21:08 +0000)]
Patch from Galen Charlton <gmc@esilibrary.com> to prevent one bad MARC record from spoiling the rest of the export

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15686 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadditional code-level comments
erickson [Wed, 3 Mar 2010 20:25:44 +0000 (20:25 +0000)]
additional code-level comments

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15685 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agofinished support for lableFormat for auto-widgets that use filtering selects
erickson [Wed, 3 Mar 2010 20:25:44 +0000 (20:25 +0000)]
finished support for lableFormat for auto-widgets that use filtering selects

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15684 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agooverride the fund labels in copy edit interface autowidgets to show the fund year...
erickson [Wed, 3 Mar 2010 20:25:43 +0000 (20:25 +0000)]
override the fund labels in copy edit interface autowidgets to show the fund year in addition to fund code

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15683 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agostarted support for overrideing the label for remote object filtering selects
erickson [Wed, 3 Mar 2010 20:25:42 +0000 (20:25 +0000)]
started support for overrideing the label for remote object filtering selects

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15682 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agokeep the original due_date time component of day-granular circs on due_date edit
miker [Wed, 3 Mar 2010 19:36:11 +0000 (19:36 +0000)]
keep the original due_date time component of day-granular circs on due_date edit

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15680 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAcq: middle-layer support for unified lineitem/purchase order/picklist search
senator [Wed, 3 Mar 2010 19:18:55 +0000 (19:18 +0000)]
Acq: middle-layer support for unified lineitem/purchase order/picklist search

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15679 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoneed to add a space here, in case the term contains a : (parser gets confused)
miker [Wed, 3 Mar 2010 17:43:20 +0000 (17:43 +0000)]
need to add a space here, in case the term contains a : (parser gets confused)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15676 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agopatch from Jason Stephenson to allow the EVERYTHING permission in permission.usr_has_...
miker [Wed, 3 Mar 2010 16:38:52 +0000 (16:38 +0000)]
patch from Jason Stephenson to allow the EVERYTHING permission in permission.usr_has_perm_at_nd

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15673 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoPatch from Warren Layton to remove a debugging alert in the permission creation interface
miker [Wed, 3 Mar 2010 16:23:02 +0000 (16:23 +0000)]
Patch from Warren Layton to remove a debugging alert in the permission creation interface

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15670 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoTidied up white space, mainly by indenting with tabs instead of spaces.
scottmk [Wed, 3 Mar 2010 15:52:07 +0000 (15:52 +0000)]
Tidied up white space, mainly by indenting with tabs instead of spaces.
Added some comments.  No substantive changes.

M    Open-ILS/src/c-apps/oils_cstore.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15669 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years ago1. Encapsulated into a few small functions the management of session-level
scottmk [Wed, 3 Mar 2010 03:24:23 +0000 (03:24 +0000)]
1. Encapsulated into a few small functions the management of session-level
information (currently just the transaction ID).

2. Fixed a bug in the treatment of the transaction ID that had caused us to
issue useless extra rollbacks whenever we did a commit or a rollback.

3. Further tinkered with comments.

M    Open-ILS/src/c-apps/oils_cstore.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15668 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAcq: add a tooltip to show lineitem alert text description along with code
senator [Tue, 2 Mar 2010 23:05:16 +0000 (23:05 +0000)]
Acq: add a tooltip to show lineitem alert text description along with code

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15667 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoforward-porting r15664: protect mmbxs mat view from NULLs
miker [Tue, 2 Mar 2010 22:36:39 +0000 (22:36 +0000)]
forward-porting r15664: protect mmbxs mat view from NULLs

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15666 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAdd ALLOW_ALT_TCN permission to the permission list
dbs [Tue, 2 Mar 2010 21:32:20 +0000 (21:32 +0000)]
Add ALLOW_ALT_TCN permission to the permission list

If given this permission, it will enable rogue cataloguers to set a
different TCN if an incoming bib record conflicts with an existing
bib record.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15663 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoFix bug where diacritics could be corrupted in places like the library hierarchy...
dbs [Tue, 2 Mar 2010 20:59:11 +0000 (20:59 +0000)]
Fix bug where diacritics could be corrupted in places like the library hierarchy selection list in the SlimPAC

Apply patch from Galen Charlton to ensure required version of Encode.pm; also removes support for Ubuntu Gutsy

From https://bugs.launchpad.net/evergreen/+bug/525069

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15662 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoApply patch from Galen Charlton to prevent legacy 852 fields from being exported...
dbs [Tue, 2 Mar 2010 20:54:37 +0000 (20:54 +0000)]
Apply patch from Galen Charlton to prevent legacy 852 fields from being exported during bib+holdings export

From https://bugs.launchpad.net/evergreen/+bug/528424

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15661 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAcq: Indicate presence of alerts among notes in lineitem table interface
senator [Tue, 2 Mar 2010 19:42:26 +0000 (19:42 +0000)]
Acq: Indicate presence of alerts among notes in lineitem table interface

Italicize the notes link and mark it with a red flag character when the notes
associated with a given lineitem have alert texts linked to them.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15660 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoNot so fast, tex. The client sorted things, all right, but was completely messed up.
dbs [Tue, 2 Mar 2010 19:16:32 +0000 (19:16 +0000)]
Not so fast, tex. The client sorted things, all right, but was completely messed up.

Pursue wlayton's r14015 instead for client-side sorting.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15657 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadded permacrud retrieve entries for po/li history tables
erickson [Tue, 2 Mar 2010 18:47:30 +0000 (18:47 +0000)]
added permacrud retrieve entries for po/li history tables

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15656 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoSort Z39.50 sources as returned by fetch_service_defs() for a better UX
dbs [Tue, 2 Mar 2010 18:39:36 +0000 (18:39 +0000)]
Sort Z39.50 sources as returned by fetch_service_defs() for a better UX

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15655 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoFix syntax error
senator [Tue, 2 Mar 2010 15:53:59 +0000 (15:53 +0000)]
Fix syntax error

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15653 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoTidied up white space; added comments to several functions.
scottmk [Tue, 2 Mar 2010 04:32:27 +0000 (04:32 +0000)]
Tidied up white space; added comments to several functions.

Eliminated unnecessary return statements from the void functions
userDataFree() and sessionDataFree().

M    Open-ILS/src/c-apps/oils_cstore.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15652 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years ago1. Renamed getSourceDefinition() to getRelation(), since "SourceDefinition"
scottmk [Tue, 2 Mar 2010 00:49:43 +0000 (00:49 +0000)]
1. Renamed getSourceDefinition() to getRelation(), since "SourceDefinition"
could be taken to refer to a subquery defined in the IDL.

2. In getRelation(): when returning a source_definition instead of a table name
or view name, build it in a single allocated buffer instead of a growing_buffer,
in order to save a malloc() and free().

3. In osrfAppChildInit(): Use and reuse a single growing_buffer to build the
SELECT statements, instead of allocating and freeing one repeatedly.

4. In osrfAppChildInit(): if getRelation() returns NULL, skip the class and go
on to the next one, since any attempt to SELECT from it is doomed anyway.

5. In osrfAppChildInit(): eliminate several unnecessary casts.

M    Open-ILS/src/c-apps/oils_cstore.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15651 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoTidying up whte space, adding comments. No substantive changes.
scottmk [Mon, 1 Mar 2010 22:25:02 +0000 (22:25 +0000)]
Tidying up whte space, adding comments.  No substantive changes.

(The diff looks messier than it should because of some
spurious matches.)

M    Open-ILS/src/c-apps/oils_cstore.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15650 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agothis slipped back in and shouldn't have
phasefx [Mon, 1 Mar 2010 22:20:02 +0000 (22:20 +0000)]
this slipped back in and shouldn't have

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15649 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoIn PO Events UI, change Target ID column into a Purchase Order column linking to...
phasefx [Mon, 1 Mar 2010 22:18:16 +0000 (22:18 +0000)]
In PO Events UI, change Target ID column into a Purchase Order column linking to the PO View.  Change deprecated dojo .getValue and .setValue to .attr in places

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15648 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoRetrieval, cancel, and set no hold methods for acq user requests
phasefx [Mon, 1 Mar 2010 20:01:42 +0000 (20:01 +0000)]
Retrieval, cancel, and set no hold methods for acq user requests

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15647 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoDon't assume an options parameter was passed, and remove the ability to 'flesh your...
phasefx [Mon, 1 Mar 2010 19:58:55 +0000 (19:58 +0000)]
Don't assume an options parameter was passed, and remove the ability to 'flesh your way to China'

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15646 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years ago1. Fixed a bug in osrfAppInitialize(). After loading the method name into the
scottmk [Mon, 1 Mar 2010 16:21:08 +0000 (16:21 +0000)]
1. Fixed a bug in osrfAppInitialize().  After loading the method name into the
method metadata, we were deleting it.  Any subsequent access of it invoked
undefined behavior.  It was just our dumb luck that cstore didn't crash and
burn long ago.

2. Tidied up some of the white space.

3. Added doxygen-style comments to three of the functions.

M    Open-ILS/src/c-apps/oils_cstore.c

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15645 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAcq: View and manage distrib formula applications for a given lineitem
senator [Sat, 27 Feb 2010 00:07:40 +0000 (00:07 +0000)]
Acq: View and manage distrib formula applications for a given lineitem

When distribution formulas are applied, each application is represented by an
icon in a new table in the lineitem copies interface.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15644 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoReload button for staff client's browser, and some missing DTD entities
phasefx [Thu, 25 Feb 2010 20:58:10 +0000 (20:58 +0000)]
Reload button for staff client's browser, and some missing DTD entities

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15643 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAdded five new views to the acq schema:
scottmk [Thu, 25 Feb 2010 20:37:21 +0000 (20:37 +0000)]
Added five new views to the acq schema:

all_fund_allocation_total
all_fund_encumbrance_total
all_fund_spent_total
all_fund_spent_balance
all_fund_combined_balance

These views are similar to the correspondingly named views without the
"all_" prefix (i.e. acq.fund_allocation_total, etc) except that the
return a row for every fund in acq.fund, even if the fund is not
represented in acq.fund_debit or acq.fund_allocation.

M    Open-ILS/src/sql/Pg/200.schema.acq.sql
M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0173.schema.acq.all-fund-views.sql
M    Open-ILS/examples/fm_IDL.xml

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15642 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agofix field name for acq.user_request IDL entry
phasefx [Thu, 25 Feb 2010 16:13:18 +0000 (16:13 +0000)]
fix field name for acq.user_request IDL entry

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15641 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoCreated a new table acq.provider_note, similar to acq.po_note, but tied
scottmk [Wed, 24 Feb 2010 21:23:37 +0000 (21:23 +0000)]
Created a new table acq.provider_note, similar to acq.po_note, but tied
to acq.provider instead of to acq.purchase_order.

Also: modified actor.usr_purge_data() to touch the foreign keys to
actor.usr when a user is purged.

M    Open-ILS/src/sql/Pg/999.functions.global.sql
M    Open-ILS/src/sql/Pg/200.schema.acq.sql
M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0172.schema.acq.provider-notes.sql
M    Open-ILS/examples/fm_IDL.xml

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15640 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoneeded to enable the Extension Manager buried in the Admin -> For Developers menu...
phasefx [Wed, 24 Feb 2010 21:12:06 +0000 (21:12 +0000)]
needed to enable the Extension Manager buried in the Admin -> For Developers menu.  emrikol++

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15638 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoFix the spurious "Item is already checked out." warning when placing a copy level...
phasefx [Wed, 24 Feb 2010 20:30:24 +0000 (20:30 +0000)]
Fix the spurious "Item is already checked out." warning when placing a copy level hold

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15637 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAcq: separate LI note creation from LI alert creation; improve notes iface
senator [Wed, 24 Feb 2010 19:36:17 +0000 (19:36 +0000)]
Acq: separate LI note creation from LI alert creation; improve notes iface

Since adding LI notes or alerts takes place immediately, so does deleting
them now, so there's no more need for a Save Changes button on that interface.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15636 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agofetch user groups non-async to prevent clobbering expire date when group dijit update...
erickson [Wed, 24 Feb 2010 19:30:44 +0000 (19:30 +0000)]
fetch user groups non-async to prevent clobbering expire date when group dijit updates with async data.  set required var before it's used.  don't require values in the password field for existing users

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15635 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoDon't require an ident value for offline mode patron registration, since we don't...
phasefx [Wed, 24 Feb 2010 18:03:30 +0000 (18:03 +0000)]
Don't require an ident value for offline mode patron registration, since we don't require it online

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15632 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agonew widgets to disable/enable in the checkout UI based on patron conditions
phasefx [Wed, 24 Feb 2010 17:26:19 +0000 (17:26 +0000)]
new widgets to disable/enable in the checkout UI based on patron conditions

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15631 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agofix double-listing bug in Actions for this Record -> View Holds
phasefx [Wed, 24 Feb 2010 16:54:20 +0000 (16:54 +0000)]
fix double-listing bug in Actions for this Record -> View Holds

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15630 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAdd fax number, phone, url, email to certain provider-related tables.
scottmk [Wed, 24 Feb 2010 14:34:32 +0000 (14:34 +0000)]
Add fax number, phone, url, email to certain provider-related tables.

M    Open-ILS/src/sql/Pg/200.schema.acq.sql
M    Open-ILS/src/sql/Pg/002.schema.config.sql
A    Open-ILS/src/sql/Pg/upgrade/0171.schema.acq.provider-phone-email.sql
M    Open-ILS/examples/fm_IDL.xml

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15627 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agofix an org setting label mixup
phasefx [Tue, 23 Feb 2010 18:35:20 +0000 (18:35 +0000)]
fix an org setting label mixup

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15626 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoupgrade script for ui.staff.require_initials
phasefx [Tue, 23 Feb 2010 18:17:49 +0000 (18:17 +0000)]
upgrade script for ui.staff.require_initials

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15625 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoFix typo in upgrade version number
senator [Tue, 23 Feb 2010 17:03:15 +0000 (17:03 +0000)]
Fix typo in upgrade version number

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15624 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAcq: optionally associate an alert with lineitem note when creating the latter.
senator [Mon, 22 Feb 2010 22:23:33 +0000 (22:23 +0000)]
Acq: optionally associate an alert with lineitem note when creating the latter.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15623 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoPatch from Dan Wells to repair white space error in here-doc (fixes the r15418 reshel...
erickson [Mon, 22 Feb 2010 21:43:24 +0000 (21:43 +0000)]
Patch from Dan Wells to repair white space error in here-doc (fixes the r15418 reshelving problem)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15620 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agowhere possible, return the matchpoint that would have been used had the tests passed
miker [Mon, 22 Feb 2010 21:25:57 +0000 (21:25 +0000)]
where possible, return the matchpoint that would have been used had the tests passed

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15619 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agostop nasty error when cancelling a Claim Return action
phasefx [Mon, 22 Feb 2010 21:20:27 +0000 (21:20 +0000)]
stop nasty error when cancelling a Claim Return action

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15618 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoTrigger patron 'stop sign' page for the ALERT_NOTE penalty
phasefx [Mon, 22 Feb 2010 20:35:47 +0000 (20:35 +0000)]
Trigger patron 'stop sign' page for the ALERT_NOTE penalty

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15617 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAcq: Fix sorting bug in rev 15614 when use_count >= 10
senator [Mon, 22 Feb 2010 20:20:23 +0000 (20:20 +0000)]
Acq: Fix sorting bug in rev 15614 when use_count >= 10

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15616 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agofix actions in the Group summary when seen via the patron search interface
phasefx [Mon, 22 Feb 2010 20:16:00 +0000 (20:16 +0000)]
fix actions in the Group summary when seen via the patron search interface

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15615 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAcq: Distribution formula dropdown in lineitem detail editor shows use count.
senator [Mon, 22 Feb 2010 20:08:04 +0000 (20:08 +0000)]
Acq: Distribution formula dropdown in lineitem detail editor shows use count.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15614 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoverifying dcommit and rolling back last test, please ignore
erickson [Mon, 22 Feb 2010 18:55:06 +0000 (18:55 +0000)]
verifying dcommit and rolling back last test, please ignore

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15613 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agotest commit
erickson [Mon, 22 Feb 2010 18:53:16 +0000 (18:53 +0000)]
test commit

git-svn-id: svn://svn.open-ils.org/ILS/trunk@15612 dcc99617-32d9-48b4-a31d-7c20da2025e4