working/Evergreen.git
14 years agoAdd 830 as a controllable bibliographic field in authority linking script
dbs [Wed, 23 Feb 2011 15:07:17 +0000 (15:07 +0000)]
Add 830 as a controllable bibliographic field in authority linking script

Per http://www.loc.gov/marc/bibliographic/bd830.html, bibliographic 830
should be controlled by authority 130. The "common cataloging practice"
in 830 of omitting non-filing characters may cause some entries to not be
linked that otherwise would be.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19520 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoCorrect the install location for Dojo i18n bundles
dbs [Wed, 23 Feb 2011 02:12:02 +0000 (02:12 +0000)]
Correct the install location for Dojo i18n bundles

We had been converting xx-YY into xx/yy for a directory structure,
but current evidence shows that it should be xx-yy. Hard to believe
we've overlooked this for so long. Also, with the exception of the
en-ca/en-gb/en-us locales, we should probably trim the locale to
just xx - but that's a different problem, and let's just focus on
getting this working to begin with.

Addresses Launchpad # 723489

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19509 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agodojo.js has to be loaded from the same domain as the page, unless it's a cross-domain...
erickson [Tue, 22 Feb 2011 21:19:38 +0000 (21:19 +0000)]
dojo.js has to be loaded from the same domain as the page, unless it's a cross-domain build

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19505 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years ago2.0.2 upgrade script
miker [Mon, 21 Feb 2011 18:45:38 +0000 (18:45 +0000)]
2.0.2 upgrade script

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19500 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoMake sure we continue looping in situations where there is only one copy
miker [Mon, 21 Feb 2011 18:30:19 +0000 (18:30 +0000)]
Make sure we continue looping in situations where there is only one copy

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19497 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAddressing LP bug: https://bugs.launchpad.net/evergreen/+bug/721450
miker [Mon, 21 Feb 2011 15:37:19 +0000 (15:37 +0000)]
Addressing LP bug: https://bugs.launchpad.net/evergreen/+bug/721450

If a series-class index definition has been removed, the data remains in the field entry table.  This is because there was no fkey previously.  We need to clean that data out so that the fkey can be validated during upgrade.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19492 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoWhitespace - convert mix of tabs/spaces to pure spaces
dbs [Fri, 18 Feb 2011 18:46:41 +0000 (18:46 +0000)]
Whitespace - convert mix of tabs/spaces to pure spaces

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19490 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoSwitch to BT.textContent() for Opera compatibility
dbs [Fri, 18 Feb 2011 18:46:22 +0000 (18:46 +0000)]
Switch to BT.textContent() for Opera compatibility

The BT.textContent() method abstracts away some of the browser
differences for us. Most importantly, it makes Opera happy.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19489 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoBackport r19470 from trunk
senator [Thu, 17 Feb 2011 20:57:31 +0000 (20:57 +0000)]
Backport r19470 from trunk

Booking: fix the targeter in the I'm-reserving-this-exact-resource-with-this-
exact-barcode case.

It should have always worked like this. This should better mirror the behavior
in the holds targeter when placing a copy-level hold.  Basically don't fail
to target a resource for a reservation later just because it's not in an
available status right at this moment.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19472 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoNote --admin-user / --admin-pass options for eg_db_config.pl
dbs [Thu, 17 Feb 2011 20:28:56 +0000 (20:28 +0000)]
Note --admin-user / --admin-pass options for eg_db_config.pl

Missed backporting this doc from trunk - thanks to Chris Sharp for
pointing this out.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19469 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAvoid mixed-content warnings due to HTTP link for Google Chrome Frame
dbs [Thu, 17 Feb 2011 18:57:02 +0000 (18:57 +0000)]
Avoid mixed-content warnings due to HTTP link for Google Chrome Frame

We're hardcoding this to HTTPS for now to avoid the mixed-content warnings that
occur when content location is https:// and the linked script is at http:// but
a config-aware patch probably wouldn't be a bad idea.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19468 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoTeach maintain_901 trigger to respect the "Use record ID for TCN" global flag
dbs [Thu, 17 Feb 2011 03:31:01 +0000 (03:31 +0000)]
Teach maintain_901 trigger to respect the "Use record ID for TCN" global flag

Rather than relying on the Perl layer to set the correct TCN on the way in,
do it as part of the in-database indexing to ensure that we have consistent
results no matter how the record gets into the database.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19460 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoPatch based on work by Dan Wells to improve Opera BibTemplate support
miker [Wed, 16 Feb 2011 22:24:16 +0000 (22:24 +0000)]
Patch based on work by Dan Wells to improve Opera BibTemplate support

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19457 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoTeach authority_control_fields.pl about record ranges
dbs [Sun, 13 Feb 2011 03:19:36 +0000 (03:19 +0000)]
Teach authority_control_fields.pl about record ranges

Passing --record 10,000 times at the command line sucks, and
--all is not particularly realistic for large databases. Adding
--start_id and --end_id makes this script more usable.

Also provide reasonably full POD documentation, and rely on
Pod::Usage to provide help based on it when help is requested
or passed in options don't make sense.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19441 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoNormalize ISBNs by stripping hyphens in search methods and in reporter.materialized_s...
dbs [Fri, 11 Feb 2011 21:45:20 +0000 (21:45 +0000)]
Normalize ISBNs by stripping hyphens in search methods and in reporter.materialized_simple_record

We weren't normalizing ISBNs in search or in reporter.materialized_simple_record
which required users to exactly match the form of the ISBN as entered in the
MARC record to get a successful search result - pretty hit or miss.

The longer term fix in 2.0 and above is to make the ISBN search search against
the identifier|isbn index, which also gets ISBN10/ISBN13 equivalence goodness.
But this patch will be relatively easy to backport through to 1.6.1 and plugs
some of the holes in our exposed APIs and search points in the short term.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19434 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoPostgres 9.0 is more strict about variable names in functions. We will probably hit...
miker [Fri, 11 Feb 2011 00:51:07 +0000 (00:51 +0000)]
Postgres 9.0 is more strict about variable names in functions. We will probably hit more of these, but these in particular break the OPAC.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19429 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoCorrect syntax error in BadDebt.pm
dbs [Thu, 10 Feb 2011 15:31:49 +0000 (15:31 +0000)]
Correct syntax error in BadDebt.pm

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19424 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoReduce hard-coded strings in Serial Control interfaces
dbwells [Wed, 9 Feb 2011 18:58:40 +0000 (18:58 +0000)]
Reduce hard-coded strings in Serial Control interfaces

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19421 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoallow item status update if either status-specific perm is allowed or UPDATE_COPY...
erickson [Wed, 9 Feb 2011 18:26:06 +0000 (18:26 +0000)]
allow item status update if either status-specific perm is allowed or UPDATE_COPY is allowed.  fire off related A/T events after the initial transaction has been committed

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19416 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agotweak selector used for font_helper() CSS classes
phasefx [Wed, 9 Feb 2011 05:34:29 +0000 (05:34 +0000)]
tweak selector used for font_helper() CSS classes

Makes the flat-text MARC editor respect the global font settings,
resolving bug https://bugs.launchpad.net/evergreen/+bug/678078

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19413 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoRemove syntax error from O:A:Storage:Publisher:authority and add strict pragma
dbs [Tue, 8 Feb 2011 06:21:18 +0000 (06:21 +0000)]
Remove syntax error from O:A:Storage:Publisher:authority and add strict pragma

Came across a line of dead code while debugging a related problem, and
noticed that strict/warnings wasn't in place, so I culled the dead code
and added use strict/use warnings accordingly (now that we no longer
have the syntax error caused by the dead code).

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19407 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoCreate authorities that only contain controlled subfields (LP 712496)
dbs [Tue, 8 Feb 2011 06:13:05 +0000 (06:13 +0000)]
Create authorities that only contain controlled subfields (LP 712496)

Selecting "Create authority" on a field containing uncontrolled subfields
would generate an authority record that contained those uncontrolled
subfields. This would, in turn, prevent the "Validate" button from operating
correctly - if you added a 700 with $a and $c subfields, clicked "Create
authority", and then immediately clicked "Validate", the field would show
up as red.

Now we filter out the uncontrolled subfields before they get sent to
the "Create authority" function, avoiding this validation problem.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19405 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoEnsure new authority ID subfield is inserted in the correct XUL DOM location
dbs [Tue, 8 Feb 2011 05:12:28 +0000 (05:12 +0000)]
Ensure new authority ID subfield is inserted in the correct XUL DOM location

Addresses LP 712499. After creating an authority via the context menu
in the MARC editor, the new ID subfield ($0) would be created right after
the subfield on which the context menu was invoked. It turns out that it
was being placed in the wrong location, and one symptom was that the
Validate button would not validate the controlled field against the newly
created authority.

Now we hunt through the parent DOM nodes until we find the 'sf_box' element
and then we append the ID subfield to that node. We also eliminate some
duplicate code by defining a common function so that the problem can be
fixed in one stroke...

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19403 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoPrevent authority context menu on whitespace content
dbs [Tue, 8 Feb 2011 03:50:58 +0000 (03:50 +0000)]
Prevent authority context menu on whitespace content

Continuing the refinement of LP 712538, if the subfield contains
only whitespace, treat it as though it were empty for the purposes
of the context menu.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19401 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoPrevent authority context menu from being displayed on empty content (LP 712538)
dbs [Tue, 8 Feb 2011 03:50:27 +0000 (03:50 +0000)]
Prevent authority context menu from being displayed on empty content (LP 712538)

It's confusing to have the authority context menu - particularly the
"Create authority" options - appear for empty content. Check to ensure
that the subfield being clicked on actually has some content before
displaying the authority context menu.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19400 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoupgrade script
miker [Fri, 4 Feb 2011 19:28:58 +0000 (19:28 +0000)]
upgrade script

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19388 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoFix ModsParser.pm bug involving invalid ISBNs. See bug #697398.
dbwells [Fri, 4 Feb 2011 18:53:11 +0000 (18:53 +0000)]
Fix ModsParser.pm bug involving invalid ISBNs.  See bug #697398.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19384 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoported open-ils.actor.user.transaction.[fleshed.]retrieve to CStoreEditor both for...
erickson [Fri, 4 Feb 2011 00:15:24 +0000 (00:15 +0000)]
ported open-ils.actor.user.transaction.[fleshed.]retrieve to CStoreEditor both for cleanup and to take advantage of .authoritative.  Use authoritative version in staff client

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19380 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoclear shelf expire time and some other fields when un-cancelling a hold
erickson [Thu, 3 Feb 2011 23:31:55 +0000 (23:31 +0000)]
clear shelf expire time and some other fields when un-cancelling a hold

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19376 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoTwo binding fixes for manage items
dbwells [Thu, 3 Feb 2011 16:49:24 +0000 (16:49 +0000)]
Two binding fixes for manage items

The first fix is more or less cosmetic. When selecting a target unit, both areas need to refresh in order to not show the selected unit's items in the main list.

The second fix involves handling cases where moving items from one unit to another does not empty the 'donor' unit. In those cases, we need to update the contents of both the new and the old unit.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19374 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAuthorities: control 610/611, do not control 4xx by default
dbs [Thu, 3 Feb 2011 14:16:25 +0000 (14:16 +0000)]
Authorities: control 610/611, do not control 4xx by default

The 4xx fields in bibliographic records have not been controlled
fields for some time (1988 for CAN/MARC, 1999 for USMARC per)
http://www.loc.gov/marc/bibliographic/bd4xx.html; and
http://www.oclc.org/bibformats/en/4xx/default.shtm also lists
these as obsolete. So, remove them from the default controlled
fields in Evergreen.

Also, add 610/611 to the controlled fields list (per LP #712467).

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19372 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agolet due date show up correctly in the copy browser for circulating items
phasefx [Wed, 2 Feb 2011 20:52:11 +0000 (20:52 +0000)]
let due date show up correctly in the copy browser for circulating items

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19370 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agobackport r19364 from trunk for stat cat field value removal in patron editor
phasefx [Wed, 2 Feb 2011 19:57:41 +0000 (19:57 +0000)]
backport r19364 from trunk for stat cat field value removal in patron editor

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19365 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoexit finish_fines_and_voiding() if there is no open circ
erickson [Wed, 2 Feb 2011 18:54:05 +0000 (18:54 +0000)]
exit finish_fines_and_voiding() if there is no open circ

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19362 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoApply autogenerate barcode trigger to serial.unit to enable serial checkin
dbs [Wed, 2 Feb 2011 03:29:27 +0000 (03:29 +0000)]
Apply autogenerate barcode trigger to serial.unit to enable serial checkin

Serial checkin tried to use the '@@AUTO' macro to autogenerate barcodes,
but unfortunately the required trigger had only been defined on the parent
table asset.copy and not on the child table serial.unit. Here we define the
trigger on serial.unit to resolve that problem.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19360 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agomake sure that inline overdue fines generation completes before we attempt to void...
erickson [Tue, 1 Feb 2011 23:40:24 +0000 (23:40 +0000)]
make sure that inline overdue fines generation completes before we attempt to void overdues fines in checkin, otherwise it's possible to create multiple services (storage and cstore) competing for the same DB row mid-transaction, resulting in cstore timeouts and rollback of checkin.  This could happen with backdated or amnesty checkins

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19358 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoBackport r19355 from trunk
senator [Tue, 1 Feb 2011 21:39:37 +0000 (21:39 +0000)]
Backport r19355 from trunk

Acq: Improving on r19351, don't let showCreatePane() be issued repeatedly to
fill the window with redundant dialogs, since a) it looks silly, and b) the
dialogs don't work when there are more than one of them. Thanks again Dan.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19356 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoBackport r19353 from trunk
senator [Tue, 1 Feb 2011 21:23:29 +0000 (21:23 +0000)]
Backport r19353 from trunk

This should get this correct version of postgresql installed for clean
installations on debian-lenny, *if* your system has the backports repo enabled.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19354 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoBackport r19351 from trunk
senator [Tue, 1 Feb 2011 21:16:37 +0000 (21:16 +0000)]
Backport r19351 from trunk

Acq: make the "new provider" button under Admin -> Server Admin ->
Acquisitions -> Providers not produce a dialog with a ton of mysterious
whitespace. Spotted by Dan Scott.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19352 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agobackport 19344, 19345 for patron purge fix for handling former staff users
phasefx [Mon, 31 Jan 2011 19:55:34 +0000 (19:55 +0000)]
backport 19344, 19345 for patron purge fix for handling former staff users

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19346 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoDon't attempt to control 4xx fields in records
dbs [Sun, 30 Jan 2011 05:22:04 +0000 (05:22 +0000)]
Don't attempt to control 4xx fields in records

Per LP bug # 708029, it doesn't make sense to apply an
authority control on a 4xx field; so remove those entries
from the authority tag map.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19337 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoUse the browse method instead of startwith for Manage Authorities, too
dbs [Sun, 30 Jan 2011 05:20:33 +0000 (05:20 +0000)]
Use the browse method instead of startwith for Manage Authorities, too

Now that the browse method is working properly, adopt it for the
Manage Authorities interface as well so that context around the
search term can be provided.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19336 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoCorrect authority browsing for reals
dbs [Sun, 30 Jan 2011 05:19:15 +0000 (05:19 +0000)]
Correct authority browsing for reals

First, restore the >= enable before and after ranges in
authority_tag_sf_browse(), after I mistakenly removed it in
r19131; the second storage request for $after does not
stomp on the prior $before results, it simply gets pushed
onto the carefully constructed list of $before results,
ensuring that our target is in the middle of page 0.

Second, we're treating all of the "tag" members in the
method registration as list references now (for the purpose
of searching against 4xx/5xx in the .refs. variants), but
that was blowing up when we registered just a single tag as
a string and tried to treat the scalar as a list reference.
I could have checked to see if what we had incoming was a
reference and dance accordingly, but opted to just define
all single-tag entries as single-element arrays instead.
Applied the same to startwith.

Finally, in r19331 I had used chop() to ensure that an
exact match for startwith would be returned as element 1 on
page 0, instead of appearing as the last element of page -1.
I had said that the right way to do this would be to naco_normalize()
the value to match the normalized afr.value, and so this is what
I have done. Rather than torturously using O:A:Storage:FTS to get
at the naco_normalize() definition, I moved the function into its
own Utils package and adjusted its usage accordingly through the
affected code. One step closer to single-sourcing the function
in the database, as well?

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19335 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAddress typos in Rollover and Propagation dialogue
dbs [Sat, 29 Jan 2011 05:16:37 +0000 (05:16 +0000)]
Address typos in Rollover and Propagation dialogue

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19330 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoBackport r19327 from trunk
senator [Fri, 28 Jan 2011 21:19:40 +0000 (21:19 +0000)]
Backport r19327 from trunk

Stay in sync with entity name changes

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19328 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoBackport r19325 from trunk
senator [Fri, 28 Jan 2011 20:53:01 +0000 (20:53 +0000)]
Backport r19325 from trunk

Serials: Add some missing permacrud permissions to IDL

7 classes (sdistn, siss, sunit, sin, sbsum, sssum, sisum) were missing IDL
perms.  Appropriate permissions were added to all but sin (serial_item_note).

For the sin class, since it's several leaps away from anything that points at
an org unit, and since no existing code deals with it via PermaCrud, its
PermaCrud section was simply removed.

Some classes retain open <retrieve /> permissions, and others do not.

No new permissions were created for this. All permissions are reused from
"higher" serials objects.

Credit to Mike Rylander for spotting the omissions.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19326 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoenable the checkbox column so we can delete hard due dates
phasefx [Thu, 27 Jan 2011 16:20:52 +0000 (16:20 +0000)]
enable the checkbox column so we can delete hard due dates

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19313 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoOpen-ILS/xul/staff_client/server/locale/en-US/serial.properties
dbwells [Wed, 26 Jan 2011 15:09:53 +0000 (15:09 +0000)]
Open-ILS/xul/staff_client/server/locale/en-US/serial.properties

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19304 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoClear out some unused code, which in some cases was causing "command bleed"
dbwells [Wed, 26 Jan 2011 14:54:33 +0000 (14:54 +0000)]
Clear out some unused code, which in some cases was causing "command bleed"

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19302 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoBackport r19288 : twice tested, thrice approved
dbwells [Tue, 25 Jan 2011 23:29:50 +0000 (23:29 +0000)]
Backport r19288 : twice tested, thrice approved

This change was confirmed to work at two test sites, and also passed a berick eyeball test.  Would always be nice to have more...

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19300 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoFix broken stream functions, re-enable commented-out menu with correct options
dbwells [Tue, 25 Jan 2011 23:21:34 +0000 (23:21 +0000)]
Fix broken stream functions, re-enable commented-out menu with correct options

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19299 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoThis menu was for a different tab (subscriptions), comment out for now
dbwells [Tue, 25 Jan 2011 21:47:15 +0000 (21:47 +0000)]
This menu was for a different tab (subscriptions), comment out for now

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19297 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agofix the svn:mimetype properties for these
phasefx [Tue, 25 Jan 2011 21:32:46 +0000 (21:32 +0000)]
fix the svn:mimetype properties for these

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19295 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agomark this as binary
phasefx [Tue, 25 Jan 2011 21:10:14 +0000 (21:10 +0000)]
mark this as binary

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19292 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoTranslation string in manage_dists.js : right problem, wrong fix
dbwells [Tue, 25 Jan 2011 20:53:21 +0000 (20:53 +0000)]
Translation string in manage_dists.js : right problem, wrong fix

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19291 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agobackport 19287 for button bar image tweaks, courtesy of Michael Peters
phasefx [Tue, 25 Jan 2011 20:44:49 +0000 (20:44 +0000)]
backport 19287 for button bar image tweaks, courtesy of Michael Peters

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19289 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoSmall serial interface string fixes
dbwells [Tue, 25 Jan 2011 19:57:29 +0000 (19:57 +0000)]
Small serial interface string fixes

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19286 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoTeach the i18n Makefile how to handle serial.properties
dbs [Tue, 25 Jan 2011 06:16:45 +0000 (06:16 +0000)]
Teach the i18n Makefile how to handle serial.properties

Also check in the POT for serial.properties and some other
foobar.label matches for foobar.accesskey (does not have
an effect on properties files but hopefully if we're
consistent then the pattern will be evident for entities).

Noting in passing that there are a number of "foobar(s)"
comined singular/plural labels that should be split to
support translation.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19281 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoReplace a few hardcoded strings in the serials JavaScript
dbs [Tue, 25 Jan 2011 05:21:01 +0000 (05:21 +0000)]
Replace a few hardcoded strings in the serials JavaScript

There is, unfortunately, an awful lot of this left to fix.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19280 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoFix existing serial entities that didn't provide .label partners for .accesskey
dbs [Tue, 25 Jan 2011 03:13:38 +0000 (03:13 +0000)]
Fix existing serial entities that didn't provide .label partners for .accesskey

The translate-toolkit project generates a POT file from an input DTD
that requires entities ending in .accesskey to have a corresponding
.label entity; this is a Mozilla convention for localization. Fix up
the serial interface strings that are localized to match this expectation.

Also remove two duplicate entities in lang.dtd that were flagged by
the build/i18n/tests/check_entities.py script (and which cause Launchpad
translation imports to break).

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19278 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoExpose (in a very basic way) existing serial item reset functionality, fix small...
dbwells [Mon, 24 Jan 2011 23:33:07 +0000 (23:33 +0000)]
Expose (in a very basic way) existing serial item reset functionality, fix small bug in reset code (resetting an item with no unit)

Apologies in advance if this shouldn't be backported at this point, but from my perspective, it is both high-value and low-risk.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19276 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoCorrect for over-zealous sdist editor field display code
dbwells [Mon, 24 Jan 2011 23:03:53 +0000 (23:03 +0000)]
Correct for over-zealous sdist editor field display code

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19274 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoUpdated POT from a recent checkout and "make newpot" of 2.0
dbs [Mon, 24 Jan 2011 21:38:14 +0000 (21:38 +0000)]
Updated POT from a recent checkout and "make newpot" of 2.0

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19271 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoi18n support for a few OPAC strings
dbs [Mon, 24 Jan 2011 21:22:06 +0000 (21:22 +0000)]
i18n support for a few OPAC strings

Enable translation of the "More copies listed in full record details"
message for the search results library / call number / item /status
lines

Also provide translation support for the hold queue status message,
including singular / plural variants (most languages do not provide
the equivalent of the "item(s)" idiom in English).

Instead of burying the display of hold queue status with a hard
coded "if (false)" test, turn it into a top-level variable for
a bit more exposure.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19270 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoFix for spurious warning (LP bug #707114)
miker [Mon, 24 Jan 2011 20:29:32 +0000 (20:29 +0000)]
Fix for spurious warning (LP bug #707114)

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19267 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agocorrect XPath attribute test syntax
miker [Sun, 23 Jan 2011 00:05:18 +0000 (00:05 +0000)]
correct XPath attribute test syntax

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19261 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agohandle deleting line item from selection list more carefully
gmc [Sat, 22 Jan 2011 05:49:43 +0000 (05:49 +0000)]
handle deleting line item from selection list more carefully

Once a line item is attached to a purchase order, removing it
from a selection list should mean detaching it from the list,
not deleting it outright.

The open-ils.acq.lineitem.delete method can be removed
once the old jubgrid code is finally purged.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19259 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoProtect against volumes with many copies attached
dbs [Fri, 21 Jan 2011 22:09:22 +0000 (22:09 +0000)]
Protect against volumes with many copies attached

Bill Erickson has good data for testing these cases.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19256 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoUse holdings_xml-full for the copy display
dbs [Fri, 21 Jan 2011 20:53:12 +0000 (20:53 +0000)]
Use holdings_xml-full for the copy display

Less to munge and transfer over the wire = win win win!

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19254 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoslimpac issue where deleted copies are visisble, spotted by Steve Callendar and Jason...
miker [Fri, 21 Jan 2011 20:39:16 +0000 (20:39 +0000)]
slimpac issue where deleted copies are visisble, spotted by Steve Callendar and Jason Etheridge

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19251 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAvoid hard-coded location IDs for displaying library / call number / copy location...
dbs [Fri, 21 Jan 2011 20:20:42 +0000 (20:20 +0000)]
Avoid hard-coded location IDs for displaying library / call number / copy location /copy status

Also use marcxml-full to get the copy location opac visibility attribute,
and remove the "hide_me" attribute to make the results visible by default.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19249 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoMove to the prettier and more useful Laurentian local call number display code as...
miker [Fri, 21 Jan 2011 19:50:39 +0000 (19:50 +0000)]
Move to the prettier and more useful Laurentian local call number display code as the example

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19248 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoPart 3 of a more secure default set up
dbs [Fri, 21 Jan 2011 15:51:45 +0000 (15:51 +0000)]
Part 3 of a more secure default set up

With this commit, the hardcoded default barcode is replaced by an
MD5 hash of a random string of numbers, preventing the barcode from
being used as a known login name in the OPAC interface (which would
remove one of the factors required in a brute forcing of the account
credentials).

You probably don't want to change the barcode for the admin user,
but if you feel the need you can use the usual patron editor in
the staff client.

Thanks to Thomas Berezansky for suggesting this additional change.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19246 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoPart 2 of creating a more secure default setup
dbs [Fri, 21 Jan 2011 15:50:55 +0000 (15:50 +0000)]
Part 2 of creating a more secure default setup

With this commit, the user name and password for the administrative
user will be MD5 hashes of a random string of numbers. You can set
the user name and password to your liking using the --admin-user and
--admin-pass switches for eg_db_config.pl (this will be the
documented method in the install docs) or via straight SQL as:

UPDATE actor.usr SET usrname = 'FOO', passwd = 'BAR' WHERE id = 1;

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19245 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoTowards a more secure default setup
dbs [Fri, 21 Jan 2011 15:49:45 +0000 (15:49 +0000)]
Towards a more secure default setup

Shipping with a default account user name and password is considered
an authentication anti-pattern; see
http://code.google.com/p/owasp-development-guide/wiki/WebAppSecDesignGuide_D2

By making the user select an admin user name and password at the time
they create the database, we avoid the chance that they will forget to
change the default password and leave their system open to access.

Next step is to change the seed data to insert random values for the
admin username and password, then update the documentation accordingly.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19244 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoBackport r19241 from trunk
senator [Thu, 20 Jan 2011 23:06:42 +0000 (23:06 +0000)]
Backport r19241 from trunk

Acq: the "Load Catalog Record IDs" interface failed on files produced in
Windows due to not stripping out carriage returns. Fixed.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19242 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoBackport r19239 from trunk
senator [Thu, 20 Jan 2011 22:37:46 +0000 (22:37 +0000)]
Backport r19239 from trunk

Acq: use the acqlimad table instead of its ancestor acqliad table to
populate a dropdown for the Export Single Attribute List function of lists
of lineitems

The acqliad table may appear to have duplicate entries since it's a parent, and
the point of the function that's trying to use it is just to export lists of
ISBNs or UPCs, so acqlimad is a better fit.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19240 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agodon't offer to cancel related transits that have already completed when canceling...
phasefx [Thu, 20 Jan 2011 19:54:36 +0000 (19:54 +0000)]
don't offer to cancel related transits that have already completed when canceling holds

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19235 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoBackport r19229 from trunk
senator [Thu, 20 Jan 2011 19:42:49 +0000 (19:42 +0000)]
Backport r19229 from trunk

Booking: these lines don't belong; they were erroneously copied and pasted
from a neighboring section of the file

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19230 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoif this user does not have permission to edit an existing user, disable the save...
erickson [Wed, 19 Jan 2011 22:28:02 +0000 (22:28 +0000)]
if this user does not have permission to edit an existing user, disable the save and clone buttons

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19224 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoremove disallowed permission groups from the perm group selector in user registration...
erickson [Wed, 19 Jan 2011 22:28:01 +0000 (22:28 +0000)]
remove disallowed permission groups from the perm group selector in user registration; see bug 699914

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19223 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agolet amnesty checkin mode trump the restore overdues on lost checkin setting
phasefx [Wed, 19 Jan 2011 22:05:53 +0000 (22:05 +0000)]
let amnesty checkin mode trump the restore overdues on lost checkin setting

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19220 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoBackport r19214 from trunk
senator [Wed, 19 Jan 2011 21:53:32 +0000 (21:53 +0000)]
Backport r19214 from trunk

Booking: Robert Soulliere spotted and fixed a bug in processing reservation-
related overdue fines.  See https://bugs.launchpad.net/evergreen/+bug/705061

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19215 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoBuild and flatten a tree, correcting a sorting issue in some OU dropdowns.
miker [Wed, 19 Jan 2011 19:52:12 +0000 (19:52 +0000)]
Build and flatten a tree, correcting a sorting issue in some OU dropdowns.

The previous code assumed that work org units would be delivered in hierarchical order, but alas, they are not. Thus, we build the hierarchy and then flatten it, sorting at each level. This will be non-fast with many work OUs, but the common case is a small set, which is not painful.

Further improvement is warranted when the above proves false.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19209 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agobackport naco_normalize revisions to rel_2_0
gmc [Wed, 19 Jan 2011 16:07:14 +0000 (16:07 +0000)]
backport naco_normalize revisions to rel_2_0

This implements the latest version of the NACO
normalization specification found at

http://www.loc.gov/catdir/pcc/naco/SCA_PccNormalization_Final_revised.pdf

This version of the algorithm is more general -- for example,
all combining characters are removed -- so there should be
fewer fiddly edge cases to worry about for most European
languages.

Rebuilding the metabib.*_field_entry tables (e.g., by using
reingest-1.6-2.0.pl) is recommended if there are any bibs that contain
any non-ASCII characters.

Normalized text is now left in the NFKD form, so while this should
be transparent to the search system after reindexing, it does mean
that (for example) Korean text in metabib.*_field_entry may not
be in the same Unicode normalization form as that found in
biblio.record_entry.

Also includes fix for bug #684467: more bulletproofing of naco_normalize

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19205 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAvoid escaping issues in authority.normalize_heading() by parameterizing the query
dbs [Wed, 19 Jan 2011 15:13:24 +0000 (15:13 +0000)]
Avoid escaping issues in authority.normalize_heading() by parameterizing the query

Long story short: MARC subfield values containing backslashes caused noise
and in some cases painful errors. Using spi_prepare/spi_exec_query is the
safest way of handling escaping, rather than adding more regexes and munging
the data before it even gets to naco_normalize().

Most painful case was <subfield code="a">Foo, Bar\</subfield> - the trailing
slash ended up escaping the enclosing single quote (because PostgreSQL isn't
configured by default with strict conformance to SQL escaping rules yet) and
threw an error.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19202 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoProtect against blank and invalid scap IDs in issuance editor
dbwells [Tue, 18 Jan 2011 23:44:36 +0000 (23:44 +0000)]
Protect against blank and invalid scap IDs in issuance editor

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19198 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agofix glitch that could break invoice proration
gmc [Tue, 18 Jan 2011 22:52:33 +0000 (22:52 +0000)]
fix glitch that could break invoice proration

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19196 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agouser saved searches are only accessible to the originating user; remove (incorrect...
erickson [Tue, 18 Jan 2011 20:00:52 +0000 (20:00 +0000)]
user saved searches are only accessible to the originating user; remove (incorrect) permacrud config for usr_saved_searches

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19194 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAuto-generation of placeholder barcodes approved for backport
dbwells [Tue, 18 Jan 2011 18:15:29 +0000 (18:15 +0000)]
Auto-generation of placeholder barcodes approved for backport

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19191 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoIn serial control, if they defined a *_call_number, honor it as the default
dbwells [Mon, 17 Jan 2011 19:30:19 +0000 (19:30 +0000)]
In serial control, if they defined a *_call_number, honor it as the default

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19188 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agodefault ordering-agency org unit to workstation org in PO create dialog
erickson [Mon, 17 Jan 2011 15:54:49 +0000 (15:54 +0000)]
default ordering-agency org unit to workstation org in PO create dialog

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19186 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoPostpone advanced serial call-number handling until after 2.0
dbwells [Sat, 15 Jan 2011 04:05:40 +0000 (04:05 +0000)]
Postpone advanced serial call-number handling until after 2.0

Sharing of a single call-number for multiple volumes, while well intentioned, was not ready for primetime for various reasons.  This commit:
1) harmonizes and unifies call-number handling in Serial.pm, sticking with current practices
2) adds a very basic and now necessary prompt to the Serial Control view

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19183 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoEnable truncation attribute in Z39.50 queries to be left out entirely
dbs [Fri, 14 Jan 2011 03:00:51 +0000 (03:00 +0000)]
Enable truncation attribute in Z39.50 queries to be left out entirely

Per https://bugs.launchpad.net/evergreen/+bug/702695, some Z39.50
servers hate the truncation attribute (@attr 5=anything) and always
return 0 hits.

This gives you the ability to specify a negative value for the
truncation attribute and thereby prevent the truncation attribute
from being included in the Z39.50 query for a given server.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19177 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAdd Net::SSH2 to the prereqs as the libnet-ssh2-perl package is not on Debian Lenny
dbs [Wed, 12 Jan 2011 21:10:17 +0000 (21:10 +0000)]
Add Net::SSH2 to the prereqs as the libnet-ssh2-perl package is not on Debian Lenny

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19171 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoDeprecate overdue/predue config sections in favour of action/trigger
dbs [Wed, 12 Jan 2011 20:57:15 +0000 (20:57 +0000)]
Deprecate overdue/predue config sections in favour of action/trigger

Set email notification to "false" for holds, overdues, and predues.

Fix one line of whitespace.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19170 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAutoFieldWidget no longer uses CurrencyTextBox dijit
gmc [Wed, 12 Jan 2011 20:52:42 +0000 (20:52 +0000)]
AutoFieldWidget no longer uses CurrencyTextBox dijit

NumberTextBox used instead to work around problem with
CurrencyTextBox's support for negative monetary amounts
in Dojo 1.3.  See https://bugs.launchpad.net/evergreen/+bug/702117

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19168 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoBackport fixes for custom indexes in the database schema during 1.6.1-2.0 upgrade
dbs [Wed, 12 Jan 2011 14:37:52 +0000 (14:37 +0000)]
Backport fixes for custom indexes in the database schema during 1.6.1-2.0 upgrade

r19133 and r19136 provide more sophisticated, working handling of custom
indexes during the 1.6.1-2.0 database schema upgrade.

git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19165 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoallow data entry of negative currency amounts
gmc [Wed, 12 Jan 2011 00:30:41 +0000 (00:30 +0000)]
allow data entry of negative currency amounts

Plug in fix for Dojo bug http://bugs.dojotoolkit.org/ticket/9438, which
was preventing the input of discounts and credits during invoice
creation.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19164 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoallow deletion of incomplete invoice LIs
gmc [Tue, 11 Jan 2011 23:18:43 +0000 (23:18 +0000)]
allow deletion of incomplete invoice LIs

Fix silent failure when attempting to delete a LI
whose type or cost was not set; dojo.string.subtitute
does not like replacement values to be null.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19161 dcc99617-32d9-48b4-a31d-7c20da2025e4