LP#1155313: recalculate normalized labels during upgrade

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1155313: pin upgrade script to 0914

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1155313: fix copy-and-paste-o in test case

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1155313: upgrade script and pgTAP tests for monograph_part label normalization fix

Signed-off-by: Daniel Pearl <dpearl@cwmars.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1155313: Repair generation of label_sortkey for monograph_part entries

The evergreen.lpad_number_substrings function attempts to codify numeric
fields within labels.  It does this by finding the strings, padding them
to a given size, and replacing them in the source string.  For instance:
       3 => 0000000003
    15.4 => 00000000150000000004

The algorithm was fooled by repeated characters, like in 15.1:
    15.1 => 00000000000000000150000000001  INCORRECT

This change will result in the correct value.

Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1395842: fix labels for A/T environment and parameter ID fields

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1426133: followup fix seed data sequence

Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1425967: look for Business::CreditCard in settings-tester.pl

and not Business::CreditCard::Object

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1426133: Stamping upgrade script for set merge_profile_id_seq

Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1426133: Set merge_profile_id_seq explicitly

Many database tables need to explicitly set the id sequence (often to
100) to provide room for stock data with static ids. This commit does so
for vandelay.merge_profile, and also updates the ids of any non-stock
profiles (both in the merge_profile table and in related settings).

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1425191 Restore summarization of serial units

In a previous commit, code was added for force summaries to be limited
to a certain type (to prevent cross type contamination of summaries).
This had the negative side-effect of preventing summaries on units, as
the units were not requesting a 'type' for their summary.

While we could force the unit code to send a type, it seemed generally
more flexible to restore the removed support for returning all summary
information in the absense of a requested type.  This could lead to
cross-type summaries for units, but that is a larger issue altogether
(i.e. how we can properly support cross-type units at all).

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

lp1373203: Allow users to escape metarecord holds

Provides a means for users to escape a metarecord hold if they accidentally
clicked the Advanced Hold Options link. A Basic Hold Options link will be
provided to allow the user to return to a title hold. If the hold starts as a
metarecord hold, the basic hold options link won't display since we don't know
which bib the patron wants.

Also fixes an issue where the hold cancel button always returned the user to
the previous screen. We will instead utilize the existing hold_source_page
parameter to identify the return page.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1402797 Open item status in a new tab

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Allow (and use) a default cancel cause for holds by passing around a scalar instead of an object

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Do not allow workstations as org units that cannot have user

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Test value directly, and invert test for the a-disabled test

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Move aDisabled from patron/app to services/ui so it can be used everywhere

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Attempt to implement disabling tests for orgs in the magic dropdown

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 clean up action rows and styling

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Add (stub) fast item add, and (working) bib source selection

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Mangle the 005 when saving, and support any record_entry type

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 handle up/down arrow (navigate) and ctrl + up/down (duplicate field)

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 canonicalize field.postion after inserting or removing fields

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 insert 00[678], building 008 from record data

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Improve styling; marcrecord bug fixes; implement field/subfield insert and remove

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Start styling marc editor via css

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Code layout cleanup

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Should prompt when there is unsaved data, but does not.  More to do...

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Global undo/redo stack stack

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Make grid action context menu safe for multiple grids per page

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Allow forgive-fines on forced checkout

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 If no row is currently selected on right-click, select the clicked row

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Make grid context menu safer and more state-aware

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Typo

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 use ng-options so that the default option works

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Attach the context menu to the body for proper coordinate mapping

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Grid row context menu from Actions dropdown

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 add a Retrieve All These Patrons button

in the Item Status -> Circ History List

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Add user-related fields to some hold interfaces

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Add missing columns to patron search result grid

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Remove Uncancel Hold action where not useful

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Hide cancel/uncancel as appropriate

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Teach the autogrid how to hide actions

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 remove Group Actions from Group Member Details

place "Move Another Patron To This Group" under Actions

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 change Retrieve Selected Patron

to Retrieve Selected Patrons for Other -> Group Member Details interface

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Context menu infrastructure

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Initial MARC editor -- load, edit content, save, see the Breaker version

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Use jquery xml parser, and appendChild()

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Initial commit and sourcing of the jquery-ified marcrecord.js module

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Remove DOB valid test for now; Change alert valid test (expressions must be simple)

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Add Item Status to the circ menu

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Make the save box smaller to help avoid overlapping the input form

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Add DOB and address validity styling

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Add DOB to patron summary

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Profile Group no longer causes second search to fail, but it does not yet propagate

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Add "forget" mode for grid limit; Use in hold clearing mode

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Pass the top-level class so that the proper tooltip can be generated

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Focus the Print button

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Make Strict Barcode checkbox sticky upon actual use

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Pre-force tab change.  There have been reports of the tab not changing on automatic redirect.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Add Cancel Cause column to hold grid and flesh that object

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Default to staff-forced cancel cause

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Add Circulation Modifier to the column list (must add manually, as it is a link-type field)

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Make warnings more prominent, as in the XUL client

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Style search and clear buttons like action buttons to differentiate from text boxes

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Protect against chrome autofill as best we can in Verfiy Credentials

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Where possible, handle all circ events, not just the first one in the stack

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Change Thaw Date column label to Activation Date

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Fixed typo stopping patron search expand/collapse stickiness

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Renew instead of in/out when the item is already checked out to the user

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Enter sumbits the prompt dialog

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Just hide the statusbar by default. It gets in the way.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Be explicit about which direction users are moving between groups, and provide an informational message when none are selected but should be

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Hold Shefl: Use max_chunk_size to pass updates in a timely fashion; Notify on the correct array to allow paging back to work

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Respect ui.staff.require_initials.patron_standing_penalty OU setting

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Require, and use, initials on penalty creation

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 add "Delete Selected Records From Catalog" action to record buckets

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 catch and allow overriding of COPY_DELETE_WARNING and TITLE_LAST_COPY

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 make it "delete selected" rather than "delete all"

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Implement "set bottom view as default"

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Use target="_self" to force a top-level page load

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Use the staff-wrapped catalog when jumping to a bib record

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 For any grid with a persistKey, store the last selected row count as a localStorage value

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Add record summary bar to the catalog display, and hide Actions for this Record until usable

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 implement "delete all from catalog" for copy buckets

TODO: at present, this is pretty optimistic

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 webstaff: add basic copy bucket management functionality

This adds an interface for managing copy buckets, including
adding and removing them, adding items to a pending list and to
copy buckets by barcode, and removing items from a bucket.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 make clearing the record bucket pending list action functional

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 implement Show All in Catalog action for record buckets

Note that this will typically require the brower's pop-up
blocker to be disabled for the webstaff site.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 use staff search for record bucket queries

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Improve styling of retrieve-by pages

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Implement retrieve record by id and tcn

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Use egCore.env.basePath to construct the URL for last record

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Implement "Retrieve Last Bib Record" using localStorage record cache

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 Save the record we land on from within the staff client as the "last record retrieved"

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#957466: Fix invalid MARCXML syntax

This commit fixes some invalid MARCXML syntax, and also makes the XPath
query more general to allow for namespaces on the tags.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#957466: Added pgTAP test for db function change

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#957466: A simpler version of set_marc_905u.

This version only adds a 905$u if none already exist in the document. It
does so by creating a new 905 tag with subfield u. It does not add on
to any possibly existing 905 tag that does not have a subfield u.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1282286 Tab is NULL error

When editing a MARC record in Vandelay or MFHD holdings in a popup XUL
WIndow, a tab is NULL error is presented to the user.

This happens because an undefined variable is being used when it should
not be.  This code adds a check for that variable to ensure it exists
before using it.  The variable used only matters in cases where tabs are
present, which is not the case with pop up MARC edit windows, so
ignoring the variable in these cases is fine.

Signed-off-by: Liam Whalen <liam.whalen@bc.libraries.coop>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1154579: explicitly alert if copy location failed to be deleted

This patch adds an alert if the act of deleting a copy
location in the staff interface fails -- which would
most commonly happen if there are still active items
attached to the location to be deleted.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1423813: adjust some queries to account for deleted copy locations

This patch adjusts some queries so that if a copy location
is deleted, any undeleted items that are attached to it
are considered deleted for the purpose of generating
OPAC item lists and seeing if items are potentially available
to fill hold request.

It should be noted that if a copy location is marked as
logically deleted, there shouldn't be any undeleted
copies associated with it.  However, as this condition is not
presently enforced by a database contraint, adding additional
checks on acpl.deleted provides some additional defense.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>