working/Evergreen.git
6 years agolpxxx Angular holdings maintenance wip
Bill Erickson [Fri, 22 Mar 2019 16:44:20 +0000 (09:44 -0700)]
lpxxx Angular holdings maintenance wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agolpxxx Angular holdings maintenance wip
Bill Erickson [Thu, 21 Mar 2019 22:07:40 +0000 (15:07 -0700)]
lpxxx Angular holdings maintenance wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agolpxxx Angular holdings maintenance wip
Bill Erickson [Thu, 21 Mar 2019 16:14:30 +0000 (09:14 -0700)]
lpxxx Angular holdings maintenance wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agolpxxx Angular holdings maintenance wip
Bill Erickson [Wed, 20 Mar 2019 22:03:24 +0000 (18:03 -0400)]
lpxxx Angular holdings maintenance wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agolpxxx Angular holdings maintenance wip
Bill Erickson [Wed, 20 Mar 2019 21:10:04 +0000 (17:10 -0400)]
lpxxx Angular holdings maintenance wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agolpxxx Angular holdings maintenance wip
Bill Erickson [Wed, 20 Mar 2019 20:06:27 +0000 (16:06 -0400)]
lpxxx Angular holdings maintenance wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agolpxxx Angular holdings maintenance wip
Bill Erickson [Wed, 20 Mar 2019 17:47:29 +0000 (13:47 -0400)]
lpxxx Angular holdings maintenance wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agolpxxx Angular holdings maintenance wip
Bill Erickson [Wed, 20 Mar 2019 16:49:56 +0000 (12:49 -0400)]
lpxxx Angular holdings maintenance wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agolpxxx bool display component
Bill Erickson [Wed, 20 Mar 2019 16:07:15 +0000 (12:07 -0400)]
lpxxx bool display component

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agolpxxx bool display component
Bill Erickson [Wed, 20 Mar 2019 16:06:20 +0000 (12:06 -0400)]
lpxxx bool display component

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agolpxxx Angular holdings maintenance wip
Bill Erickson [Wed, 20 Mar 2019 14:39:19 +0000 (10:39 -0400)]
lpxxx Angular holdings maintenance wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agolpxxx Angular holdings maintenance wip
Bill Erickson [Wed, 20 Mar 2019 14:03:40 +0000 (10:03 -0400)]
lpxxx Angular holdings maintenance wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agolpxxx Angular holdings maintenance wip
Bill Erickson [Tue, 19 Mar 2019 21:21:42 +0000 (17:21 -0400)]
lpxxx Angular holdings maintenance wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agolpxxx Angular holdings maintenance wip
Bill Erickson [Tue, 19 Mar 2019 20:07:26 +0000 (16:07 -0400)]
lpxxx Angular holdings maintenance wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agolpxxx Angular catalog record tab next/prev
Bill Erickson [Tue, 19 Mar 2019 17:34:39 +0000 (13:34 -0400)]
lpxxx Angular catalog record tab next/prev

Navigation through results on the record detail page stays on same tab.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agolpxxx Angular holdings maintenance wip
Bill Erickson [Tue, 19 Mar 2019 16:19:35 +0000 (12:19 -0400)]
lpxxx Angular holdings maintenance wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agolpxxx Angular holdings maintenance wip
Bill Erickson [Tue, 19 Mar 2019 16:10:37 +0000 (12:10 -0400)]
lpxxx Angular holdings maintenance wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agolpxxx bib summary support collapse setting
Bill Erickson [Tue, 19 Mar 2019 16:10:32 +0000 (12:10 -0400)]
lpxxx bib summary support collapse setting

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agolpxxx Angular holdings maintenance wip
Bill Erickson [Tue, 19 Mar 2019 15:48:03 +0000 (11:48 -0400)]
lpxxx Angular holdings maintenance wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agolpxxx Grid data loading progress
Bill Erickson [Tue, 19 Mar 2019 15:47:52 +0000 (11:47 -0400)]
lpxxx Grid data loading progress

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoAngular holdings maintenance wip
Bill Erickson [Mon, 18 Mar 2019 21:46:42 +0000 (17:46 -0400)]
Angular holdings maintenance wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agolpxx grid disable paging option
Bill Erickson [Mon, 18 Mar 2019 21:46:34 +0000 (17:46 -0400)]
lpxx grid disable paging option

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoAngular holdings maintenance wip
Bill Erickson [Mon, 18 Mar 2019 19:15:06 +0000 (15:15 -0400)]
Angular holdings maintenance wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoAngular holdings maintenance wip
Bill Erickson [Mon, 18 Mar 2019 19:05:51 +0000 (15:05 -0400)]
Angular holdings maintenance wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agolpxxx Grid data loading progress
Bill Erickson [Mon, 18 Mar 2019 19:05:41 +0000 (15:05 -0400)]
lpxxx Grid data loading progress

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoAngular holdings maintenance wip
Bill Erickson [Mon, 18 Mar 2019 17:49:59 +0000 (13:49 -0400)]
Angular holdings maintenance wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoAngular holdings maintenance wip
Bill Erickson [Mon, 18 Mar 2019 14:26:47 +0000 (10:26 -0400)]
Angular holdings maintenance wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoAngular holdings maintenance wip
Bill Erickson [Fri, 15 Mar 2019 22:24:55 +0000 (18:24 -0400)]
Angular holdings maintenance wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoAngular holdings maintenance wip
Bill Erickson [Fri, 15 Mar 2019 21:01:13 +0000 (17:01 -0400)]
Angular holdings maintenance wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoLP1818288 WS Option to pre-fetch record holds user/berick/lp1818288-ang-staff-catalog-record-holds
Bill Erickson [Mon, 4 Mar 2019 16:12:33 +0000 (11:12 -0500)]
LP1818288 WS Option to pre-fetch record holds

Adds a workstation setting allowing staff to decide whether to pre-fetch
all holds on the record detail holds tab, to perform sorting paging in
the client, or to leave the sorting/paging on the server.

Improves client-side sorting in the grid.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoLP1818288 Grid checkboxes emit events
Bill Erickson [Mon, 4 Mar 2019 16:11:24 +0000 (11:11 -0500)]
LP1818288 Grid checkboxes emit events

Modify the grid toolbar checkbox onClick handler to emit events instead
of requesting a reference to a function.  This is more consistent with
other event-handling code.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoLP1818288 Release notes - record holds tab
Bill Erickson [Fri, 1 Mar 2019 20:42:07 +0000 (15:42 -0500)]
LP1818288 Release notes - record holds tab

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoLP1818288 Ang staff catalog record detail holds tab/actions
Bill Erickson [Sat, 16 Feb 2019 19:42:14 +0000 (11:42 -0800)]
LP1818288 Ang staff catalog record detail holds tab/actions

Adds support for the Holds tab in the record detail view of the Angular
staff catalog.  Includes grid and hold-related actions.

* Holds grid built from the new wide-holds API.
* batch cancel holds
* batch retarget holds
* batch edit holds
** Unified form to modify notify options, dates, etc.
* hold detail page (menu and row double-click)
* batch mark items damaged
* batch mark items missing
* show last few circulations
* retrieve patron
* support for indented menu groups a la angjs grids for grouping the
  hold actions menu.

6 years agoLP1739293 Record merged edit-in-place avoid wrap
Bill Erickson [Tue, 5 Mar 2019 16:53:09 +0000 (11:53 -0500)]
LP1739293 Record merged edit-in-place avoid wrap

When using the inline editor, prevent text wrapping and instead allow
the text to overflow x and y and use scrolls to navigate.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
6 years agoLP1739293 Record merge fits container
Bill Erickson [Tue, 5 Mar 2019 16:10:44 +0000 (11:10 -0500)]
LP1739293 Record merge fits container

Allow the text contents of each merged MARC record to wrap so the
records may fit horizontally on the screen.  A single vertical scroll
allows the user to scroll down to see any parts of the record that
require more vertical space.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
6 years agoLP1739293 Record merge horizontal; optional holdings
Bill Erickson [Fri, 8 Feb 2019 16:25:10 +0000 (11:25 -0500)]
LP1739293 Record merge horizontal; optional holdings

* Tile bib records horizontally in record bucket => merge records
  interface.

* Add a "Toggle Holdings View" button for displaying holdings and leave
  holdings un-displayed by default.

* Duplicate the Merge and Cancel buttons along the top of the dialog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
6 years agoLP 1819796: Fix method call on undefined value in generate_fines
Jason Stephenson [Wed, 13 Mar 2019 16:37:23 +0000 (12:37 -0400)]
LP 1819796: Fix method call on undefined value in generate_fines

The below message repeats in the open-ils.storage_stderr.log:

Caught error from 'run' method: Can't call method "search_where" on an
undefined value at
/usr/local/share/perl/5.26.1/OpenILS/Application/Storage/Publisher/action.pm
line 1014.

This commit removes an errant ->search_where on a CStoreEditor call to
make that message go away.

Also, delete some lines of code that were commented out at the time the
code was converted to use CStoreEditor.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP1793196 Fix console error when none selected
Remington Steed [Fri, 8 Mar 2019 20:27:45 +0000 (15:27 -0500)]
LP1793196 Fix console error when none selected

If you open the dropdown and close it without selecting anything, the
console shows an error complaining that $scope.selected is undefined.
This commit checks that it exists in that case before using it.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP1793196 Volume batch editor offers MARC call numbers
Bill Erickson [Tue, 5 Feb 2019 17:28:15 +0000 (12:28 -0500)]
LP1793196 Volume batch editor offers MARC call numbers

Provide call numbers extracted from the MARC record as options in the
volume batch editor.  Call numbers to extract are based on the load-time
classification scheme, defaulting to Generic ('1') if no default scheme
is applied.

Patch includes additional sanity checks on volume editor utility
functions to avoid console errors referencing undefined values.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP1665534: Make pickup library in bib record holds view sticky
Jane Sandberg [Sun, 2 Sep 2018 23:13:46 +0000 (16:13 -0700)]
LP1665534: Make pickup library in bib record holds view sticky

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoLP1808006 - Sitemap generator fix to allow shortname parameter.
Steven Callender [Tue, 11 Dec 2018 18:18:27 +0000 (13:18 -0500)]
LP1808006 - Sitemap generator fix to allow shortname parameter.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Geoff Sams <gsams@roanoketexas.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoLP1798628: Copy alert counts in Holdings
Jason Boyer [Thu, 17 Jan 2019 18:33:10 +0000 (13:33 -0500)]
LP1798628: Copy alert counts in Holdings

Currently the count of all copy alerts ever applied
to a copy is displayed in the Holdings view, which
can be quite confusing when clicking Manage and not
seeing the expected number of alerts. This branch
changes the display to only count the number of
events currently active since those are the only
ones available to manage.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoLP#1780639 - stamping upgrade script
Chris Sharp [Fri, 8 Mar 2019 19:33:44 +0000 (14:33 -0500)]
LP#1780639 - stamping upgrade script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoLP#1780639 - add marc tag identifier field 758
Cesar Velez [Tue, 4 Dec 2018 23:30:56 +0000 (18:30 -0500)]
LP#1780639 - add marc tag identifier field 758

Add needed sql to seed data.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off by: Beth Willis <willis@noblenet.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoLP#1778571 Fix logic error converting JS bool to DB bool
Remington Steed [Thu, 25 Oct 2018 12:53:32 +0000 (08:53 -0400)]
LP#1778571 Fix logic error converting JS bool to DB bool

Two minor bugs in the Copy Notes editor had the same cause in two
separate places. The cause was forgetting to convert the checkbox status
(a JavaScript bool) to the correct database format ('t' or 'f'). The
resulting symptoms were buggy behavior related to the state of the
"Public Note" checkbox. This commit addresses both cases mentioned in
the bug report and comments.

To test the buggy behavior:
1. Edit an item (e.g. click the "Edit" link from the client OPAC view).
2. Click the "Item Notes" button (near the bottom of the editor).
3. Add a new note and check the "Public Note" box.
4. Click "OK".
5. Click "Item Notes" again and notice that the "Public Note" box on your
   new note is no longer checked. (That's bug #1.)
6. Check "Public Note" again, click "OK", and click "Save & Exit".
7. Edit the same item again. Click "Item Notes".
8. Your note should correctly have the "Public Note" checkbox checked.
9. Uncheck the box and click "OK". Click "Save & Exit".
10. Edit the same item. Click "Item Notes".
11. Notice that your change didn't save. The "Public Note" checkbox is
    still checked. (That's bug #2.)

To test the fixes:
- Clear your browser cache.
- Repeat the steps above, noticing that:
  - At step 5, the new note correctly has the "Public Note" checkbox
    checked.
  - At step 11, the edited note correctly has the "Public Note" checkbox
    unchecked.

NOTE: Testing requires clearing the browser cache, since the
t_copy_notes.tt2 file is fetched asynchronously by AngularJS.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoLP#1759238: stamping upgrade script
Chris Sharp [Fri, 8 Mar 2019 19:19:02 +0000 (14:19 -0500)]
LP#1759238: stamping upgrade script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoLP#1759238: Add upgrade script to fix typo for Physical Description in DB
Ben Shum [Tue, 1 May 2018 14:38:39 +0000 (10:38 -0400)]
LP#1759238: Add upgrade script to fix typo for Physical Description in DB

This upgrade script will check and update the typo if it is present in
an existing installation.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoLP#1769238: fix typo in 950.data.seed-values.sql for Physical Description
Ben Shum [Tue, 1 May 2018 14:29:25 +0000 (10:29 -0400)]
LP#1769238: fix typo in 950.data.seed-values.sql for Physical Description

Instead of "Physical Description", "Physical Descrption" is used by mistake.
Fix the seed data and all related PO files for translation.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Conflicts:
build/i18n/po/db.seed/cs-CZ.po

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoLp 712490: Stamping UPgrade Script
Jason Stephenson [Fri, 8 Mar 2019 18:54:35 +0000 (13:54 -0500)]
Lp 712490: Stamping UPgrade Script

Signed-off-by: Jason Stephenson <jason@sigio.com>
6 years agoLP#712490 Vandelay replace/merge PGTAP tests
Bill Erickson [Thu, 19 Oct 2017 15:42:43 +0000 (11:42 -0400)]
LP#712490 Vandelay replace/merge PGTAP tests

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Jason Stephenson <jason@sigio.com>
6 years agoLP#712490 Vandelay merge-based field replacement
Bill Erickson [Wed, 18 Oct 2017 21:00:59 +0000 (17:00 -0400)]
LP#712490 Vandelay merge-based field replacement

Modify the vandelay field replacement logic to merge replacement data
into existing field data where possible, instead of simply deleting then
re-adding the data.  The key benefit is that subfields retain their order
in affected MARC fields.  As a result, for example, propagating
authority field changes to bib records will no longer result in the $0
field being pushed to the front of the field when it was previously that
last subfield.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Jason Stephenson <jason@sigio.com>
6 years agoLP#1709698 - stamping upgrade script
Chris Sharp [Fri, 8 Mar 2019 18:34:53 +0000 (13:34 -0500)]
LP#1709698 - stamping upgrade script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoLP#1709698: no longer require descriptions in report templates
Rogan Hamby [Fri, 30 Nov 2018 19:34:04 +0000 (14:34 -0500)]
LP#1709698: no longer require descriptions in report templates

Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Jessica Woolford <jwoolford@biblio.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoLP1794588 Web client edit single call number changes all when multiple items attached
Jason Etheridge [Wed, 16 Jan 2019 13:57:26 +0000 (08:57 -0500)]
LP1794588 Web client edit single call number changes all when multiple items attached

This patch tweaks the behavior Cat.pm's fleshed_volume_update, aka
open-ils.cat.asset.volume.fleshed.batch.update

Previously, if a volume label was edited, all items attached to that
volume would be essentially affected.  Now, if only a sub-set of items
for the original volume being edited are being edited along with the
volume, then a new volume is potentially created instead, leaving the
original volume (and its unedited copies) untouched.  If no copies are
being edited along with a volume, then the volume itself is edited.

Auto-merging of volumes may still happen in all of these scenarios.

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Janet Schrader <jschrader@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
6 years agolp1802662 - Splash Page Icon Links
Sam Link [Thu, 13 Dec 2018 16:06:55 +0000 (11:06 -0500)]
lp1802662 - Splash Page Icon Links

Moved the image icons on splash.component.html and t_splash.tt2 inside
the anchor links to the associated pages.

Signed-off-by: Sam Link <slink@LIBPC002>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoLP#1818576 Offline Noncataloged Checkout Preview
Terran McCanna [Tue, 5 Mar 2019 17:34:49 +0000 (12:34 -0500)]
LP#1818576 Offline Noncataloged Checkout Preview

This adds the noncataloged type and number to the right-hand
preview when doing an offline checkout. (Prior to this, the
display was blank if there was no barcode.)

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoLP1716473 A few tweaks to correct field labels
Michele Morgan [Fri, 8 Mar 2019 14:49:42 +0000 (09:49 -0500)]
LP1716473 A few tweaks to correct field labels

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoLP1716473 Release Notes: copy edit hide disabled
Bill Erickson [Mon, 4 Mar 2019 21:41:01 +0000 (16:41 -0500)]
LP1716473 Release Notes: copy edit hide disabled

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Geoff Sams <gsams@roanoketexas.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
6 years agoLP1716473 Copy editor hide disabled defaults
Bill Erickson [Mon, 4 Mar 2019 19:06:59 +0000 (14:06 -0500)]
LP1716473 Copy editor hide disabled defaults

Disabling a field in the copy editor "Defaults" tab now hides the field
instead of simply disabling it.  Once a field is hidden, subsequent
field shift left to fill the space.

The "Working Items" grid is shifted to the bottom of the page, below the
attributes editor.  This allows the attributes to fill the horizontal
space and puts the working items and save operations visually at the end
of the page, i.e. at end of the work flow.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Geoff Sams <gsams@roanoketexas.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
6 years agoLP#1812389: make Group Penalty Threshold admin page accessible again
Galen Charlton [Wed, 23 Jan 2019 15:52:24 +0000 (10:52 -0500)]
LP#1812389: make Group Penalty Threshold admin page accessible again

As a consequence of the patch for bug 1744756 adding a new
admin/local/permission AngularJS app, the routing for
admin/local/permission/grp_penalty_threshold got broken, making the
embdeded Conify interface for group penalty thresholds inaccessible
from the web staff client. This patch fixes that.

To test
-------
[1] From Administration | Local Administration, go to Group Penalty
    Thresholds. Note that the embedded Conify admin interface
    is not displayed and the URL changes to .../permission/grp_tree.
[2] Apply the patch and repeat step 1. This time, the admin interface
    should appear.
[3] Verify that the Permission Group Tree Entries interface remains
    accessible from Local Administration.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoLP1811689 Stamping upgrade - truncate simple rec
Bill Erickson [Fri, 8 Mar 2019 14:58:54 +0000 (09:58 -0500)]
LP1811689 Stamping upgrade - truncate simple rec

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoLP1811689 TRUNCATE when rebuilding simple record
Bill Erickson [Fri, 1 Feb 2019 17:28:58 +0000 (12:28 -0500)]
LP1811689 TRUNCATE when rebuilding simple record

TRUNCATE reporter.materialized_simple_record for more efficient
rebuilding of the table.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
6 years agoLP1734775: Show multiple items in Item Status
Jason Boyer [Thu, 17 Jan 2019 14:58:08 +0000 (09:58 -0500)]
LP1734775: Show multiple items in Item Status

The ListCtrl controller was only displaying a single
copy when an id list was passed to Item Status in the
URL. This branch separates each id into a separate
fetch call and when all have been resolved it
refreshes the grid, which now has all of the items.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoLP1721109: Update item status when holdings are edited
Jane Sandberg [Sat, 2 Mar 2019 01:03:31 +0000 (17:03 -0800)]
LP1721109: Update item status when holdings are edited

To test:
1) Go to Item Status List View, select an item, and go to Actions >
Edit > Items (or Call Numbers, or both).
2) Make a change to one of the columns you have active in
the Item Status list view. Click Save and Exit.
3) Note that the list view of Item Status has not updated.
4) Load this commit.
5) Repeat steps 1-2.
6) Note that the columns are updated this time.  Note that
there is a new status column, and that an icon appears for
all the rows that you have changed.  Also, note that there
is a toast message in the bottom right hand corner of the
screen confirming that you have successfully made your change.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoLP #1705497 Replaces functionality in web client from legacy
Adam Bowling [Thu, 7 Mar 2019 04:06:09 +0000 (23:06 -0500)]
LP #1705497 Replaces functionality in web client from legacy
XUL client by including a find function for originating
acquisition where it exists.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoDocs: Fixing broken link
Jane Sandberg [Thu, 7 Mar 2019 15:14:50 +0000 (07:14 -0800)]
Docs: Fixing broken link

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 years agoLP#1800178 Holdings View should also sort by part
Remington Steed [Fri, 26 Oct 2018 15:28:32 +0000 (11:28 -0400)]
LP#1800178 Holdings View should also sort by part

The Holdings View tab of the web client doesn't correctly sort by
monograph parts. The JS is already grabbing the part label for display,
so this commit moves that chunk before the sorting code, and also grabs
the sort key. Note that the part labels and sort keys are joined per
item, since the database supports multiple parts per item (though the UI
hasn't yet supported that). And we now join the label on comma-space,
instead of the default (just a comma).

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP1818153 Stamping DB upgrade - WS user activity
Bill Erickson [Tue, 5 Mar 2019 17:21:00 +0000 (12:21 -0500)]
LP1818153 Stamping DB upgrade - WS user activity

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoLP1818153 Log user activity for websocket login/verify
Bill Erickson [Thu, 28 Feb 2019 22:20:31 +0000 (17:20 -0500)]
LP1818153 Log user activity for websocket login/verify

Adds support for logging additional user activity types:

 * websocket v1 login (apache2-websockets)
 * websocket v2 login (websocketd)
 * websocket v1 verify
 * websocket v2 verify
 * generic login (any ingress)
 * generic verify (any ingress)

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
6 years agoLP#1746360 Add Deleted Column to Record Bucket
Terran McCanna [Tue, 5 Mar 2019 15:50:59 +0000 (10:50 -0500)]
LP#1746360 Add Deleted Column to Record Bucket

This adds the Deleted column to the Record Bucket view.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoLP#1667497 - Define $params{depth} to avoid uninitialized warning.
Josh Stompro [Mon, 4 Mar 2019 14:57:02 +0000 (08:57 -0600)]
LP#1667497 - Define $params{depth} to avoid uninitialized warning.

$depth is set to 0 if $params{depth} is unset, but then $params{depth}
gets used later on, which causes an uninitialized value warning.

So set $params{depth} to whatever $depth was set to.

Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
6 years agoLP1806087 Synchronize browse code for staff cat / tpac
Bill Erickson [Thu, 21 Feb 2019 19:21:47 +0000 (14:21 -0500)]
LP1806087 Synchronize browse code for staff cat / tpac

Teach the TPAC to call the use browse API, which was originally built
from the TPAC browse code.  This way we avoid duplicating the code.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP1806087 Ang catalog pending tabs offer manual redirect
Bill Erickson [Thu, 21 Feb 2019 18:12:52 +0000 (13:12 -0500)]
LP1806087 Ang catalog pending tabs offer manual redirect

Instead of sending users to the AngJS versions of not-yet-implemented
tabs from the Angular catalog, show a message indicating the tab is not
yet implemented and offer a link to open the requested record tab in a
new browser tab.  This better clarifies what is happening and helps to
avoid situations where the back-button is confusingly hijacked via
intermediate redirect.

We now also open the "View" link for copies in a new tab as well for
consistency with the modified "Edit" link.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoStop asciidoc from squawking about missing list number
Dan Wells [Thu, 28 Feb 2019 22:55:15 +0000 (17:55 -0500)]
Stop asciidoc from squawking about missing list number

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoTranslation updates - po files
Dan Wells [Thu, 28 Feb 2019 21:20:14 +0000 (16:20 -0500)]
Translation updates - po files

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoTranslation updates - newpot
Dan Wells [Thu, 28 Feb 2019 21:12:17 +0000 (16:12 -0500)]
Translation updates - newpot

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoForward-port 3.2.4 upgrade script
Dan Wells [Thu, 28 Feb 2019 20:59:26 +0000 (15:59 -0500)]
Forward-port 3.2.4 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoForward-port 3.1.10 upgrade script
Dan Wells [Thu, 28 Feb 2019 20:59:02 +0000 (15:59 -0500)]
Forward-port 3.1.10 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoFirst pass at 3.3 release notes
Dan Wells [Thu, 28 Feb 2019 20:44:46 +0000 (15:44 -0500)]
First pass at 3.3 release notes

Ran create_release_notes.sh, cleaned up the output a bit, and removed
the separate files.  Still TODO are acknowledgments and combing out
any upgrade notes.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP#1813646: For now, direct the Home link to the AngularJS version.
Mike Rylander [Wed, 27 Feb 2019 15:44:59 +0000 (10:44 -0500)]
LP#1813646: For now, direct the Home link to the AngularJS version.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
6 years agoDocs: Adding release notes for 3.2.4
Jane Sandberg [Fri, 22 Feb 2019 21:15:56 +0000 (13:15 -0800)]
Docs: Adding release notes for 3.2.4

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 years agoDocs: adding release notes for 3.1.10
Jane Sandberg [Fri, 22 Feb 2019 20:30:14 +0000 (12:30 -0800)]
Docs: adding release notes for 3.1.10

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 years agoLP#1801191: Refactor for clarity; bugfix
Remington Steed [Fri, 22 Feb 2019 16:31:59 +0000 (11:31 -0500)]
LP#1801191: Refactor for clarity; bugfix

This commit makes a few small adjustments:

- Replace two instances of 'cleanse_ISO8601' with 'clean_ISO8601', as
  the former does not exist (at least in these contexts)
- Delay converting DateTimes to strings until necessary (which allows us
  to compare the original DateTime objects instead of having to recreate
  them from strings)
- Increase comments

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP#1801191: ensure recall does not extend due date
Jeff Davis [Thu, 1 Nov 2018 23:29:36 +0000 (16:29 -0700)]
LP#1801191: ensure recall does not extend due date

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP#1787479: Stamping upgrade script
Chris Sharp [Thu, 21 Feb 2019 18:05:48 +0000 (13:05 -0500)]
LP#1787479: Stamping upgrade script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoLP#1787479 Final fixes for print label customizations. Corrects duplication of pcrud...
Adam Bowling [Wed, 13 Feb 2019 04:15:08 +0000 (23:15 -0500)]
LP#1787479 Final fixes for print label customizations. Corrects duplication of pcrud objects
in previous submission and adds CSS to item label template.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoLP#1787479: Fixes print label template customization saving for local storage
Adam Bowling [Tue, 29 Jan 2019 21:31:43 +0000 (16:31 -0500)]
LP#1787479: Fixes print label template customization saving for local storage

updates and incorporates added template fields from the patch
user/gmcharlt/lp1726568_label_owning_lib.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoLP#1787479: Adds customization for multipage print label printing and fixes the issue
Adam Bowling [Thu, 10 Jan 2019 07:05:50 +0000 (02:05 -0500)]
LP#1787479: Adds customization for multipage print label printing and fixes the issue
with saving templates after the change to DB saving from local storage.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoLP#1787479: Relocate t_view.tt2 file
Kathy Lussier [Fri, 23 Nov 2018 14:07:26 +0000 (09:07 -0500)]
LP#1787479: Relocate t_view.tt2 file

Accidentally saved tt2 changes in last commit to the wrong directory. Fixing
it in this commit.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoLP#1787479: More layout changes
Kathy Lussier [Sat, 17 Nov 2018 18:56:12 +0000 (13:56 -0500)]
LP#1787479: More layout changes

Based on cataloger feedback, we 1) Moved the Label Set Configuration higher
grouped with the spine and spine/pocket options because all of these options
are related 2) Moved the starting label option higher because this is the
one setting that will probably be adjusted on each use of the interface and
3) Made the Gap Between Columns setting label conditional on whether the
user us printing to a sheet with label sets or not.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoLP#1787479: Make the display of some fields conditional on the Print Feed Option
Kathy Lussier [Wed, 14 Nov 2018 17:49:16 +0000 (12:49 -0500)]
LP#1787479: Make the display of some fields conditional on the Print Feed Option

Ideally, we would remove the entire Page Settings section for those who are
printing to a continuous feed printer, but it carries the risk of users
not being able to see a field with a value that is affecting the layout. However, there are several fields within that section that don't affect the
continuous feed layout and can be hidden in continuous feed mode. I also
adjusted one help tip to display different information for continuous and
sheet feed printing.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoLP#1787479: Make label names more descriptive
Kathy Lussier [Wed, 14 Nov 2018 02:07:19 +0000 (21:07 -0500)]
LP#1787479: Make label names more descriptive

As previously discussed on the cataloging list and the LP bug, the previous
label names of 'left' and 'right' no longer make sense since staff can
control the placement of these labels. However, label 1 and label 2 are too
generic. We therefore are going back to spine and pocket labels.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoLP#1787479: Some CSS and other formatting changes
Kathy Lussier [Tue, 13 Nov 2018 17:27:02 +0000 (12:27 -0500)]
LP#1787479: Some CSS and other formatting changes

Moved most of the CSS to cat.css.tt2; removed most borders since they aren't
needed as much without the full settings descriptions on the page; added some
more help text and removed Windows carriage returns.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoLP#1787479: Use help tips for settings descriptions
Kathy Lussier [Mon, 12 Nov 2018 18:04:02 +0000 (13:04 -0500)]
LP#1787479: Use help tips for settings descriptions

We are now using popup help tips for descriptions on this page. Adding these
help tips for the new settings added through this branch.

Also changes strings in this interface to translatable text.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoLP#1787479: Restore spacing fixes
Kathy Lussier [Mon, 12 Nov 2018 14:42:50 +0000 (09:42 -0500)]
LP#1787479: Restore spacing fixes

Restore spacing fixes introduced by Garry Collum that were overwritten with
the original branch.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoModified Evergreen custom print label toolbox with save modifications.
Adam Bowling [Fri, 9 Nov 2018 05:35:25 +0000 (00:35 -0500)]
Modified Evergreen custom print label toolbox with save modifications.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoLP#1787479: Custom label printing toolbox
Adam Bowling [Wed, 17 Oct 2018 20:15:44 +0000 (16:15 -0400)]
LP#1787479: Custom label printing toolbox

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Conflicts:
Open-ILS/src/templates/staff/cat/printlabels/t_view.tt2

6 years agoLP1806087 Repair SQL upgrade script file name
Bill Erickson [Thu, 21 Feb 2019 17:30:45 +0000 (12:30 -0500)]
LP1806087 Repair SQL upgrade script file name

Make the name of the file match the upgrade version number applied by
the file.

As is, build/tools/update_db.sh fails to recognize a new update is
available.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
6 years agoLP#1784893 Reporter - External Documentation Links
McCanna [Fri, 15 Feb 2019 18:29:21 +0000 (13:29 -0500)]
LP#1784893 Reporter - External Documentation Links

Removed old xulG logic which was not working in
the web client. Link now opens in new browser tab.

Signed-off-by: McCanna <tmccanna@georgialibraries.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
6 years agoLP1797934: Simplify header labels
Remington Steed [Wed, 20 Feb 2019 22:08:38 +0000 (17:08 -0500)]
LP1797934: Simplify header labels

Since the patron is already on the "Reservations" tab in their account,
it seems unnecessary to use the word "Reservations" in the header
labels. Also, simpler labels will make translations easier, since "Start
time" and "End time" are already used in other Bookings interfaces.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>