LP#1697954: Provide custom comparator for sorting money on renew

mbts.balance_owed often arrives as a string, so we provide here a custom
comparator function that runs the values through parseFloat() before comparing
them.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1697954: Enable clientsort for renew

This list is filled by the user, so it's safe to use client-side sorting.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1697954: Enable clientsort for pending patrons

This list always retreives all data, so it's safe to use client-side sorting.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1697954: Provide custom comparator for sorting money on checkin

mbts.balance_owed often arrives as a string, so we provide here a custom
comparator function that runs the values through parseFloat() before comparing
them.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1697954: Enable clientsort for checkin

This list is filled by the user, so it's safe to use client-side sorting.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1697954: Enable clientsort for item status list

This list is filled by the user, so it's safe to use client-side sorting.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1697954: Provide client-side sorting for grids that can use it

There are several grids (items out, checkin, checkout, item status, etc) that
could benefit from the ability to sort their items, but either the data
provider uses a complex data structure or an API call that doesn't offer
sorting, or the item list is populated by user input rather than a call to the
server.  In those cases, sorting is not available.  However, if we know that
all the data in the grid is in client memory, it would be reasonable to offer
a client-side sort option.

This commit does that by teaching the grid to accept a "clientsort" feature
and teaching arrayNotifier how to sort the items currently stored.  The sort
works over any mix of IDL objects, hashes, and flattened fields, supports
multisort, and pushes "nulls" to the end of the list.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

lp1678152 webstaff fix Add Copies & Volumes

Changes open-ils.cat.asset.volume.fleshed.batch.update,
AssetCommon::create_volume, and Cat::Merge::merge_volumes
to handle auto-volume merges during volume creation.

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1687125: add release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1687125: adjust relationship between acqpro and acqpron

A provider can have many notes, and "provider_notes" is effectively
virtual.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1687125: adding provider note to provider note in fm_IDL

This patch makes provider notes available to the reporter.

To test
-------
[1] Add a note to a provider record (note that at present,
    this can only be done directly in the database).
[2] In the report editor, verify that the reporting
    source for providers now includes a link to notes.
[3] Create and run a report that includes the provider
    note.

Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1208875: Add Release Note

Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1208875: follow-up to standardize extract fields

This patch removes the proposed custom methods for extracting
title, author, and record format in favor of tweaking
->fetch_user_circ_history to invoke unapi.bre and adjusting
the template to use get_marc_attrs. Also, nowadays
->fetch_user_circ_history can flesh what we need it to without
having to rely on the existance of an action.circulation row,
which won't be present if the circ was aged but was otherwise
retained in the user circ history.

The result is slower than the previous approach, but still
retains the core idea of getting A/T out of the equation, and remains
much faster than the A/T approach.

Dropping use of unapi.bre would speed things up a bit more, as it
was added only to match the addition of the record format column
in the CSV output. Drop the column, and we no longer need to worry
about MVFs.

There would also be opportunities to improve caching further.  Bib
display fields, when it comes, will likely help even more, as it
would mean being able to drop a lot of the XML parsing currently used.

This patch also adjusts misc_util.tt2 so that including it doesn't
result in an unwanted blank line.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

lp1208875 make _get_circ_history_csv work with fetch_user_circ_history

braindead adaptation.. _get_circ_history_csv predates fetch_usre_circ_history

I haven't scrutinized what the two circ_history subs actually do, but I bet
there's room for improvement here.

However, as it is now we do get a significant speed boost.  Thanks Dyrcona!

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1208875: Use text/csv MIME for circ history CSV.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP 1208875: Fix circ history CSV download for many circulations.

We no longer retrieve a user's circ history for download via
action/trigger and instead build the CSV data right in the TPAC.
The reason for this change is that action/trigger imposes just
too much of a delay between initiating the retrieval and getting
the data, particulary for patrons who have a large number of
circulation history entries, for certain values of large.

The new code uses the CStoreEditor to make JSON queries to retrieve
only the information needed for CSV.  Testing revealed that using
the existing fetch_user_circs method in EGCatLoader/Account.pm was
still too slow for the more extreme patrons.  The new code also
caches most of the retrieved bibliographic data.  Testing revealed
that most patrons get multiple checkouts of the same things, or
multiple parts of a multiple part television series.  Caching the
bib data for these records has shaved several seconds off retrieval
time in testing.

This branch makes use of a new, MVF, view when retrieving format
information.  It is thus unsuitable as-is for backport before
2.6.

Along the way, we have accreted a generically reusable CSV filter
for Template Toolkit.  That could be useful not only in other
parts of Evergreen, but in other projects.

Finally, this commit leaves the old action/trigger code in the
database.  Right now, it makes a good reference if anyone wants
to study what has been changed.  It can be removed later, if so
desired.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

lp1653998 webstaff redirect to login page

on invalid/non-existent authtoken in all or most interfaces (hopefully)

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Forward-port 2.12.3 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Forward-port 2.11.6 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

i18n: fix syntax for Spanish lang.dtd

As noted by FreddyEnrique in IRC, there was a syntax problem for the Spanish
file lang.dtd that caused an error when trying to open the Closed Date Editor.

Signed-off-by: Ben Shum <ben@evergreener.net>

Docs: 2.12.3 Release Notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: 2.11.6 Release Notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1665465 - Fix Print receipt on payment cbox not bound to model

Seems that Angular for some reason has issues binding to literals...
According to the interwebs it's likely due to scope nesting via ng-include

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1665115-WebStaff add longoverdue items count to Items Out

Longover due items should always, be reflected in total tally count
Which is what displays in the ItemsOut tab and Patron summary area.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1642035-Small DRY refactor to regctl.js compress_hold_notify()

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

lp1642035: Replace SMS Carrier Dropdown

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

lp1642035: Editing User Hold Preferences

The JS for hold notification values was replacing rather
than concatenating so only the furthest-right true value
would be saved. And because an ng-if directive creates
a child scope[1], the hold_notify_sms primitive could
never be true. Changed hold_notify_* to an object to
avoid this.

An ng-model directive was added to enable
opac.default_sms_notify but opac.default_sms_carrier
will still require some work to enable / replace.

[1]:https://github.com/angular/angular.js/wiki/Understanding-Scopes

Testing:

pre-patch:
Try to do anything with default sms number, fail.
Try to set more than one of phone + email notification, fail.
Try to set sms notification to anything, fail.

post-patch:
Default sms notify value is populated and can be changed.
All 8 possible combinations of hold notify options can be set.

Still can't set opac.default_sms_carrier value, needs additional work.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1696495-WebStaff fix user_settings data caching between patron views

Appends a few promises to make sure that the user_settings are refreshed
each time a user is loaded from within patron app.
Note that testing this requires that LP1642035's fix be in place...
Otherwise you can't properly add user_settings inputs in Webstaff.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1679309: Don't persist advanced search format filters in searchbar

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1693560: Remove permission check for retrieve tag table function

The permission check for the retrieve tag table function was preventing
users who don't have the UPDATE_MARC permssion from performing searches
in the staff catalog. Since there's nothing confidential in the table,
this commit removes that permission check. Thanks to Jason Boyer for
finding the source of the problem.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1691473 Internal Apache HTTP port configuration

Adds an optional new Apache/mod_perl configuration variable for defining
the port Apache listens on for HTTP traffic.  This resolves an issue
where added content lookups attempting HTTP requests on the local Apache
instance on port 80 failed because Apache was using non-standard ports.

To test:

[1] Set a value for OILSWebInternalHTTPPort that's not "80".
[2] Restart/reload Apache
[3] Load a record detail in the catalog
[4] Confirm opensrf logs show:

"tpac: added content connecting to <ip-address>:<new-port> / <hostname>

<new-port> should be the value configured for OILSWebInternalHTTPPort.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1694696 - Check for blank SMS Carriers in A/T reactor

Currently, the get_sms_gateway_email subroutine does not check
for the truthiness of sms_carrier, which can result in catastrophic
failure for a running server.  This adds that check.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1694696: add some unit tests for A/T helpers

In particular, start with get_sms_gateway_email().

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1244547: add release notes

Since this feature is tiny, I'm starting a miscellaneous
section for any other further tiny enhancements in the
'Administration' section.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1244547 Fix reference to new isFiltered variable

This commit completes the intention of the previous commit, which
accidentally checked the isFiltered object instead of its value.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1244547 Maintain Filter Settings on Library Settings Editor

After applying a filter to the rows on the Library Settings
Editor, and then selecting a different OU, the filter settings
are not considered unless the user clicks the "Filter" button
once again.

This patch maintains the filter settings on the edior until
the user clicks the "Clear Filter" button.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1642042 Webstaff noncat real-time display

Update non-cat counts in the patron summary side bar and show the full
set of non-cat circs in the Non-Cataloged Circulations tab as non-cat
circs occur in the patron checkout interface.

Consistent with the XUL client, avoid updating tab-level 'items out'
counts with non-cat circs.

Adds a new work log action for 'noncat_checkout' so the correct data can
be extracted.  As with the XUL client, this appears in the work log as a
'checkout' with no copy.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1686194 Account for adjustments when generating fines

Fine generation stops at a predetermined 'max fines' amount, but this
does not account for possible adjustments which lower the effective
fine amount.  This situation is common in cases where lost items are
returned, and the library wants to generate additional overdues upon
that event.

With this commit, fine generation will pull in any adjustments applied
to overdue fines, and use those to offset the current total fine when
checking for max fines.

Also includes test for this condition.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Remove testrunner-breaking trailing JS comma

Remove unnecessary comma that causes JS tests to fail, while allowing
the code to run fine in the browser.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1691237: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

lp1691237 release notes for new date fmt settings

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1691237 Date settings retrieval via egEnv

Avoid multiple .resolve() calls on the main egStartup promise by asking
egEnv to fetch the new date/time org unit settings.  Related, make the
pathway for adding new universally-loaded data functions more obvious
and consistent in egStartup by putting them right up at the top.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

lp1691237 webstaff: fix Format Dates and Format Times

This change deprecates the existing Format Dates and Format Times settings
and adds two settings for use with the webstaff client:

    Format Dates with this pattern
    Format Date+Time with this pattern

These settings use format strings as documented here:

https://docs.angularjs.org/api/ng/filter/date

There is overlap with how the Dojo formats worked, but also some differences.

The original Format Dates and Format Times settings worked together, but the
new settings work independently.  Certain field elements will use one, and
certain field elements will use the other.  These distinctions are hard-coded
in the various UI templates, with the idea being that timestamp fields in
which the date component alone is sufficient information (for example, DOB)
will use the Format Dates setting.  Fields where the time component is
important (for example, Checkout Time) will use the Format Date+Time setting.

When the settings Format Dates and Format Date+Time are unset, we will default
to "shortDate" (M/d/yy) and "short" (M/d/yy h:mm a), respectively.

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

lp1686459 webstaff: item editor form validation

Specifically for stat cats, we mark the select statements as required if the
corresponding stat cat is required, but we can also start using HTML5 validation
tests elsewhere in the form now as well.

I also fixed the <NONE> entries so that they display instead of blank entries,
and forced the Price, Cost, and Deposit Amount fields to be of input type number,
though you could still enter invalid numbers here from the database's POV, so
better validation tests are still needed there.

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

lp1671603 webstaff: add confirm step for voiding billings

This patch adds a confirmation step for  both Void All Bills
in the main billing UI, and Void Billings in the Full Details UI

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1671596 webstaff: add Adjust to Zero option to Bill UI

To test
-------
1. Apply patch.
2. Go to a patron record that has one or more active billings.
3. Note that in the billing grid, there is now an "Adjust to Zero"
   action.
4. Select one or more billings and apply the action.
5. Verify that the billings are adjusted to zero and that
   the adjustments show up as "payments".

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1616980 webstaff: protect "magic statuses" when editing copies

This patch fixes a bug where the web staff volume/copy editor
could be used to put items in or out of the following status:

1 - Checked out
3 - Lost
6 - In transit
8 - On holds shelf
16 - Long Overdue
18 - Canceled Transit

To test
-------
1. Choose to "Edit Items" on an Available copy.
2. Status field is fully editable. Click to open the dropdown
3. Click "Checked out"
4. Click "Save & Exit"
5. Result is that the item status changes to 'checked out',
   which should not happen.
6. Choose to "Edit Items" on an Checked out copy.
7. Status field is fully editable. Click to open the dropdown
8. Click "Available"
9. Click "Save & Exit"
10. Result is that the item status changes to 'available'.
11. Apply the patch and repeat steps 1-10. This time, the magic
    status are marked as disabled in the copy status selector.
    If the item is already in one of the magic statuses, if the
    user attempts to change the status, the interface will appear
    to allow it, but the change will be silently ignored.

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1533326: follow-up to remove extra logging statement

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1533326 Item status actions menu styling

Webstaff Item Status Details => Actions menu is now scrollabled for
consistency with the matching Actions menu in the List grid.  Menu is
also classed with "dropdown-menu-right" so menu entries pull left,
avoiding scroll / overflow funkiness when the menu expands.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

webstaff: Item Status bugs with Transfer Items...

...to Previously Marked Volume

Now it throws up the override dialog only if an ils event is returned,
and it doesn't prematurely refresh the screen or re-scan a barcode
while the dialog is open.

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

lp1533326 webstaff: Actions for Item Status Detail View

This patch makes the actions available to the item status
grid view also available in the detail view.  It also adds an
indicator to the Detail View for when an item is deleted.

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1681943: show all list fields in mobile view

In mobile view, "rotate" the temporary and permanent list
tables 90 degrees and put the column headings on the left/right
side.  data-label attributes are used to stash copies of the
column labels; the end result is similar to how the current
circulations table is displayed on narrow screens.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1681943: Tweak for RTL handling for responsive my lists

Needs some additional changes to support RTL for responsive my lists.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1681943: Use variables for CSS colors

There were some hardcoded references to #ccc in the stylesheet, and
those should be variables like [% css_colors.accent_light %] instead.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1681943: tweak background color of edit list description box

This makes it consistent with the 'create new list' box
and improves the contrast of the inputs.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1681943 Improve Responsive Design in My Lists

- Moved action dropdown out of header row so that it is no longer
hidden on mobile view.
- Hid less essential columns on mobile view, leaving only title / author.
- Sized and lined up buttons more neatly on both mobile and normal view.
- Added a title to the section for editing a list title and description.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Conflicts:
Open-ILS/src/templates/opac/css/style.css.tt2
Open-ILS/src/templates/opac/parts/anon_list.tt2

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1612752: apply terminology change to web staff

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1612752: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1612752 No canceled transits in webstaff transit list

Avoid displaying canceled (previously aborted/deleted) transits in the
web staff Transit List interface.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1612752 - Do not clobber local perm description changes.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1612752 - Adding release notes for Transit Cancel time and terminology change.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1612752 - s/abort/cancel/ in user interfaces.

Replacing the technical term "abort" with the more
end-user-understandable "cancel". In client-visible
language.  The underlying code has retained "abort".

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1612752 - Add cancel_time to action.transit_copy and friends.

It is useful to have keep action.transit_copy rows intact when
doing forensics on what happens after a staff member cancels a
transit.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#169787 High contrast text in patron summary alert buttons

Rather than displaying red text on the default blue background for alert text
on an active button, display the alert text as a much higher contrast
red-on-white.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1690434: Date Comparisons in the Reporter

Because of the way the where clause is constructed
in queries using the Year + Month Transform reports
using some types of operators could produce invalid
SQL.

To test:
put together a simple report template with a date
in the Basic Filters section, using the Year + Month
transform and the On or After operator. (a count of
circs with an xact_start filter is a simple way to
set this up.) Schedule it with a relative date
such as 1 month ago and run it.

Pre Patch: the report will fail and the error text
will reference a missing text >= double precision
comparison function.

Post Patch: you'll get a count of how many circs
were opened last month (or whatever report you
wrote).

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1694497: fix record links on 2nd+ page of grouped results

This patch fixes a bug wherein the second (and subsequent)
pages of search results in the public catalog (when group
formats and editions is in effect) does not correctly generate
links to hits that are not part of of a multi-bib metarecords.

To test
-------
1. Keyword search concerto for "piano"
2. Check the box for "Group formats and Editions"
3. Click Page 2
4. Click any result that is not a group (missing the parentheses after
   the title). You will get redirected to the my account page.
5. Apply the patch and do steps #1-4 again. This time, you should
   end up on the record details page.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1312824: follow-up to fix whitespace

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1312824: Change success message for transferred holds

The holds transferred success message should clarify which holds were
transferred to mitigate potential confusion.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1312824 open-ils.circ.hold.change_title fix

Add a capture_time => undef limit to both change_title
APIs to prevent currently captured holds from being reset
when moving holds from one title to another.
More work is needed to prevent items currently in transit
from having their transits canceled.

Test plan
---------
1. Create a bib with multiple holdings
2. Add multiple holds to this title and capture one of them - Item
   will have a status of On Holds Shelf
3. Open another bib record, open Actions for this Record menu,
   Mark as Hold Transfer Destination
4. Return to the record that has a captured hold, open Actions for
   this Record, Transfer all Title Holds
5. Check Captured hold, Item status is Available, hold has been reset
   and now points to the new bib record.

With the patch applied, steps 2-5 above should be repeated, but this
time in step 5 the hold will still be on the original record and the
item's status will still be On Holds Shelf.

Signed-off-by: Jason Boyer <JBoyer1@library.in.gov>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1672775 Stamping A/T purge SQL upgrade

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1672775: add purge_at_events.srfsh to example crontab

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1672775 Action/Trigger retention interval release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1672775 Action/Trigger CRON-able purge script

Installs a new purge_at_events.sh script into the Evergreen bin
directory.  Invoked at regular intervals to remove expired events.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1672775 Action/Trigger purge PGTAP tests

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1672775 Action/Trigger retention interval SQL/IDL

Adds a new 'retention_interval' column for Action/Trigger Event
Definitions and an action_trigger.purge_events() function for deleting
events that have exceeded their configured retention time, including any
outputs linked to those events.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1691284 alpha sort circ modifiers on the copy editor

Alphabetically sort circ modifiers on webstaff, so large lists
are easier to use.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: Fix buggy AsciiDoc rendering of backticks

Apparently, AsciiDoc matches backticks (`) with single quotes (') as a
valid quote pair, and this happens before matching a pair of backticks.
So in cases where a pair of backticks is followed by only one single
quote (not within a word), the first backtick is treated as a single
quote, thus breaking the backtick pair and not applying the intended
monospace formatting.

This commit fixes two such cases by escaping the backticks. This doesn't
prevent the same problem in the future, but I haven't found any way to
change this parsing behavior.

Signed-off-by: Remington Steed <rjs7@calvin.edu>

LP#1077212: add qstore to eg_db_config.pl --update-config list

To test
-------
[1] After applying the patch, run eg_db_config --update-config --service all
    as per the upgrade instructions.
[2] Verify that the <open-ils.qstore> section of opensrf.xml contains
    the correct database credentials.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1687971: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1687971: follow-up fix to copy location editor

This fixes an issue where URLs of existing copy locations
could not be edited.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1687971 - Make copy locations in the OPAC clickable.

Adds a url field to asset.copy_location. The presence of a url in the
field will cause the copy location to display as a link in the OPAC. Urls
can be edited in the Copy Locations Editor.

Additional contributors: Martha Driscoll, Christine Morgan, Suzanne
Paterno.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1498155: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1498155 - Also remove user-assigned SET_CIRC_MISSING perm.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1498155 - Remove SET_CIRC_MISSING permission.

SET_CIRC_MISSING isn't used anywhere, remove it to avoid
confusing it with MARK_ITEM_MISSING permission.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1574141: add release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1574141: minor code tweaks

- return the BAD_PARAMS event if client provides neither patron ID
  nor contact value
- more precisely identify missing parameters
- standardize indentation

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1574141 - Allow invalidate for all patrons with the same contact.

Teach the open-ils.actor.invalidate.* methods to allow invalidating
by the contact value, so all patrons with that contact value can have
it invalidated with one call.

This adds a new parameter for the contact value (email address, phone
number).  Then all customers with that value have it invalidated from
their account.

This somewhat simplifies writing a cli script for invalidating email
addresses since the script doesn't have to look up the user first.

The ability to invalidate all with the same contact value was already
there, it just wasn't exposed.

Testing:

1. Make sure the normal staff client invalidate buttons still work.
2. Use srfsh to try the call with a contact value.
  request open-ils.actor open-ils.actor.invalidate.email "<authkey>" "" "" "" "test@email.com"

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1691801 Webstaff grid column move controls

Add options to grid "Configure Columns" interface for moving a column
left or right by one, all the way left, and all the way right.

Most recently modified column is styled so it's easier for users to track
the movement of a column.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Translation updates - po files

Signed-off-by: Ben Shum <ben@evergreener.net>

Translation updates - newpot

Signed-off-by: Ben Shum <ben@evergreener.net>

forward-port 2.12.1-2.12.2 schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

forward-port 2.11.4-2.11.5 schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

2.10.11-2.10.12 schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

release notes for 2.10.12

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

update 2.11.5 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

update 2.12.2 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1478128: Avoid XSS in public catalog

This patch escapes various GET param values by passing them through
the Template Toolkit html filter, including:

* in the locale picker
* in the searchbar
* in the login form

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: 2.12.2 Maintenance release notes

Well, this turned out to be a busy maintenance release. Lots of bug fixes
are now outlined in the 2.12.2 release notes.

This commit also adds a missing new feature - LSE setting for default
status for received acq line items - to the 2.12.0 notes.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: 2.11.5 maintenance release notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1677902: Remove search formats from advanced search limiter block

The original behavior of the advanced search limiter block was to remove
search formats from the display because it is available for limiting in the
search bar. Other code broke this behavior, and I've now restored it by
adding the ignore search format code to the searchbar.tt2 file. It also fixes
a problem where the search format limiters were incorrectly displaying on the
low hits page.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>