evergreen/pines.git
4 years agoLP#1846354 various speed improvements
Mike Rylander [Tue, 8 Sep 2020 19:12:06 +0000 (15:12 -0400)]
LP#1846354 various speed improvements

* Adjust upgrade script for speed

This commit makes minor adjustments to the upgrade script to speed it up
in the face of larger data sets.

NOTE: The DO blocks that provided assertion tests during the the upgrade
have been commented out, as they primarily test that the preceding
insert did not break in some way that would have inserted data from the
wrong table into the intermediate staging tables.  They take a very long
time to run in some cases, but are left here for testers to enable in
order to confirm that they would pass in production.

* Move the deleted filter out of the query for speed

* Rework aum and ausp to use the same sequence, and aump view to use UNION ALL

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
4 years agolp1846354 toward consolidated patron notes
Jason Etheridge [Wed, 8 Jan 2020 14:02:52 +0000 (09:02 -0500)]
lp1846354 toward consolidated patron notes

* changes to IDL, DB, and upgrade script

A new view actor.usr_message_penalty and associated IDL entry will be created
for use with populating the staff Messages interface.  It will perform a full
outer join between penalties and user messages.

The default IDL permissions for user messages will remain VIEW_USER and
UPDATE_USER.

The view that populates the Message Center will be changed slightly to ensure
that staff-only messages are never retrieved for patrons.  The Date column in
the grid/list view will show the edit_date value if populated in lieu of the
create_date value.  The message view will explicitly show an Edit Date label and
value below the Date row if set.

The actor.usr_message table will gain a new boolean column called pub, which
will default to false.

The actor.usr_message table will also gain a stop_date column for handling
archival as with standing penalties.

The actor.usr_message table will also gain editor and edit_date columns.

The actor.usr_message_limited view will be changed to only include rows where
pub is true.

As part of the upgrade script, Patron alert messages will be migrated as
ALERT_NOTE penalties and linked User Messages.  A database assertion will ensure
that this has happened prior to the removal of the alert_message field from the
actor.usr table.  The field will also be removed from the corresponding IDL
entry.  The sending_lib column for these user messages and the org unit field
for these penalties will be set to the top org from the org hierarchy.

Also, non-public entries in the actor.usr_note table will be migrated as
non-public User Messages. Subject to a database assertion that this has
happened, the table actor.usr_note and the actor.convert_usr_note_to_message
trigger will be removed.  The corresponding IDL entry will also be removed.  The
sending_lib column for these user messages will be set to the top org from the
org hierarchy.

Also, rows from actor.org_unit_setting for
ui.staff.require_initials.patron_info_notes will be migrated to
ui.staff.require_initials.patron_standing_penalty.  Collisions will be recorded
in a text file but otherwise dropped.  The row in config.org_unit_setting_type
for ui.staff.require_initials.patron_info_notes will then be removed.  The label
and description for ui.staff.require_initials.patron_standing_penalty in
config.org_unit_setting_type will be edited to reflect the Notes/Penalties
labeling from the UI.

The actor.usr_standing_penalty table and associated IDL entry will gain a
foreign key column linking to actor.usr_message called usr_message, and the note
column itself will be migrated to User Messages.  The usr_message field on the
penalties will be updated accordingly.  Subject to a database assertion that
this has happened, the note field on the actor.usr_standing_penalty table will
be removed.  The corresponding IDL entry will also be removed.  The sending_lib
column for these user messages will be set to match the org_unit column from
their associated penalties.

* middle layer changes

The ApplyPatronPenalty A/T Reactor will be modified to create a user message if
needed instead of setting the note field on the created penalty, and will set
the new usr_message field accordingly.

The API method open-ils.actor.user.penalty.note.update will be similarly
adjusted, though it may edit or create a user message as needed.

The API method open-ils.actor.user.penalty.apply will also be modified to
create user messages in lieu of setting a note field.  The sending_lib field
for such messages will be set to match the session's workstation library,
regardless of the org unit that actually gets applied to the penalty's org_unit
field.  The org_unit field will use the value as passed by the caller, and no
longer do the org_unit_ancestor_at_depth adjustment that happens today.

Both penalty.note.update and penalty.apply will set the editor and edit date
columns on any linked user messages to the current time and staff member for
any already existing message that has its title or message value modified.  The
read_date column will also be NULL'ed in such circumstances so that the message
will appear unread to the patron if public.

The react sub in Event.pm will be tweaked to explicitly set the pub field on
created user messages to true for Action/Trigger.

* OPAC changes

Surface the edit date for patron visible notes in the Message Center.

* staff client changes

References to Message or Messages in the UI, including the button bar that
spawns the interface, will be changed to Note and Notes.

The Alert Message field in the patron editor will be removed.

The Notes interface under Other -> Notes will be removed.

The Notes (and count) indicator in the patron summary sidebar will be removed.
The note count will instead be presented as part of the Notes nav button.

The patron summary sidebar and the "stop sign page" will be modified to
retrieve and display user messages linked to standing penalties that are
flagged as staff alerting.  It will retain the same styling (i.e. red text) by
default.

The Messages interface, including the archived view, will be populated with a
combination of user messages and user penalties, which may or may not be linked
in pairs via a new foreign key on the penalties.  For messages without
associated standing penalties, the sending_lib column will be used for the
implicit filtering on org units that standing penalties get now, based on the
workstation library.  This combined view will result in new columns for the
interface.  At minimum the following columns (subject to label changes) will be
displayed by default: Title, Message, Create Date, Creator, Library, and Patron
Visible.  Columns such as Staff Alert, Org Depth, Block List, Ignore Proximity,
and Penalty Label will still be available.

The Apply Penalty / Message dialog will gain a new widget for toggling whether
or not a message is intended to be visible to the patron.  The Edit message
version of the dialog will also show when/if a patron has read and/or deleted
the message.  An entry field for the message title will be added.  The dialog
will also gain an org selector to the right of the penalty type selector, which
will default to the workstation library, and will change based on the org depth
of any standing penalty type selected in the UI (either via the
Note/Alert/Block buttons or the penalty menu).  This will be passed as the
org_unit field for a penalty instead of the workstation library and org depth
that is implicitly used today  The sending_lib field for the user message will
always be set to the workstation library.

The Archive Penalty / Message action will be modified to work with both
penalties and user messages depending on what it is selected.  If an archived
penalty has a linked user message, then both will have their archive fields
set.  An archived user message may still be otherwise visible to the patron if
it is not marked as deleted or staff only.

The Remove Penalty / Message action will behave as normal for a selected
penalty.  For a user message, linked or unlinked, the message will be flagged
as deleted and, even if public, will no longer show up in the patron's Message
Center.

* release notes

Patron notes, messages, alert messages, and standing penalties have been folded
into one Notes interface.  Notes designated as public will show in the My Account
-> Message Center in the OPAC for patrons.  The underlying data structure has
also changed with all notes living in the actor.usr_message table, so certain
reports may need to be adjusted.

* qa tests

* alert message wording

* set existing user messages to public

before adding new ones; also, remove a lingering reference to alert_message in
Storage/CDBI/actor.pm

* upgrade script tweaks

the main change is that we're creating SILENT_NOTE penalties for migrated
actor.usr_note's in order to preserve the creator.  I'm also removing explicit
TEMP tables in case admins do want to preserve these staging tables (by
commenting out the DROP's at the bottom of the script).

* update auditors

fixes updating patrons and allowing them to login

one consequence of this is that old alert_messages in the auditor will be deleted

* add a WARNING to the release notes

about the auditor table

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoMissed one line in the BooPAC addition
Mike Rylander [Tue, 9 Feb 2021 19:18:29 +0000 (14:18 -0500)]
Missed one line in the BooPAC addition

Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoLP#1893997: Did you mean? Single word, single class
Mike Rylander [Thu, 24 Sep 2020 16:48:41 +0000 (12:48 -0400)]
LP#1893997: Did you mean? Single word, single class

This commit embodies the first stage of a larger search suggestion
project.  The bulk of the code is dedicated to providing an
implementation of the SymSpell[1] algorithm as the basis for very fast
word similarity testing for spelling suggestions as well as alternate
search suggestions.

The native in-memory algorithm specifies a hash table lookup using a
runtime-created dictionary.  As it is untenable to create and maintain a
separate in-memory data structure in the distributed environment that
OpenSRF provides, and adds significantly to the administrative complexity
of such a configuration, we instead maintain a dictionary in the
authoritative Postgres database used by Evergreen.  This dictionary is
based directly on indexed terms used for general search, and aims to
avoid zero-hit suggestions wherever possible while imposing as little
performance impact as can be managed.

In addition to the core SymSpell similarity metric, Damerau-Levenshtein
edit distance, we provide Soundex, Trigram, and QWERTY Keyboard
similarity measures.  The importance of these can be adjusted relative
to one another, or turned off individually.

Global term frequncey data is captured for each of the Evergreen search
classes and is used to help decide when to use specific terms, and which
terms to use as suggestions.

Suggestions are provide in the OPAC, including the staff-embedded OPAC
view, the KPAC, and the Angular catalog.

Later development will add the ability to perform mult-word and
phrase-oriented suggestions, to suggest searching requested terms in
other search classes, and provide local thesaurus values and exclusion
term lists.

[1] https://medium.com/@wolfgarbe/1000x-faster-spelling-correction-algorithm-2012-8701fcd87a5f

NOTE: This development adds two new Perl module dependencies, and will
therefore require a dependency update at upgrade time.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoPINES Workaround for broken place hold links
Terran McCanna [Tue, 2 Mar 2021 19:21:24 +0000 (14:21 -0500)]
PINES Workaround for broken place hold links

This is a temporary workaround for the broken Cancel / Continue /
Back to Search buttons in the OPAC. This workaround can be removed
when a fix for https://bugs.launchpad.net/evergreen/+bug/1917513
is developed.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoPINES Custom hold error messages
Terran McCanna [Tue, 2 Mar 2021 20:10:22 +0000 (15:10 -0500)]
PINES Custom hold error messages

This makes improvements to the error messages that users see when
they have a problem placing holds.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoLP1916904 Bootstrap OPAC: Call Number on Search Result Page
Terran McCanna [Thu, 25 Feb 2021 19:50:13 +0000 (14:50 -0500)]
LP1916904 Bootstrap OPAC: Call Number on Search Result Page

Assigned a new class name to the div so that it can be styled
independently if desired.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoLP 1916904 Bootstrap OPAC: Call number on Search Results Page
Terran McCanna [Thu, 25 Feb 2021 14:58:23 +0000 (09:58 -0500)]
LP 1916904 Bootstrap OPAC: Call number on Search Results Page

This adds the call number to the search results page when
"Show More Details" is not selected. (This brings back the same
behavior as the pre-bootstrap OPAC.)

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoLP1912097 Add timestamps
Tiffany Little [Sun, 17 Jan 2021 19:49:13 +0000 (14:49 -0500)]
LP1912097 Add timestamps

Adds timestamps to the date columns in Acquisitions Search.

4 years agoPINES fix for z39.50 link on splash page
Terran McCanna [Tue, 23 Feb 2021 16:48:00 +0000 (11:48 -0500)]
PINES fix for z39.50 link on splash page

Link was being created incorrectly.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoPINES Workaround for Broken Splash Page Search Box
Terran McCanna [Fri, 22 Jan 2021 18:00:06 +0000 (13:00 -0500)]
PINES Workaround for Broken Splash Page Search Box

With the change from 3.4 to 3.6, the search box on /eg/staff/splash
broke for multiple word searches. This workaround redirects the
old staff page to the Angular staff page.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoLP1916085 Bootstrap OPAC - Pagination on copy table
Terran McCanna [Fri, 19 Feb 2021 00:37:35 +0000 (19:37 -0500)]
LP1916085 Bootstrap OPAC - Pagination on copy table

This adjusts some of the display logic in the Bootstrap OPAC
copy table pagination that had been causing the Next / Prev and
Show Fewer Copies links to be hidden when they shouldn't be.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoLP#1913338: Typo correction
Chris Sharp [Wed, 17 Feb 2021 15:26:47 +0000 (10:26 -0500)]
LP#1913338: Typo correction

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
4 years agoadd OpenAthens to stock PINES database
Chris Sharp [Wed, 17 Feb 2021 15:13:30 +0000 (10:13 -0500)]
add OpenAthens to stock PINES database

4 years agoRevert "Add OpenAthens tables/seed values to PINES."
Chris Sharp [Wed, 17 Feb 2021 15:08:06 +0000 (10:08 -0500)]
Revert "Add OpenAthens tables/seed values to PINES."

This reverts commit 15e87fe3322f7449c91979760f2a3349d07db300.

4 years agoLP1901760 Remove SharedWorker testing cruft
Bill Erickson [Mon, 11 Jan 2021 16:33:56 +0000 (11:33 -0500)]
LP1901760 Remove SharedWorker testing cruft

Otherwise they will work for no one!

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP#1528647 Self-check only accepts user name value if regex
Bob Wicksall [Mon, 6 Jun 2016 17:35:28 +0000 (13:35 -0400)]
LP#1528647 Self-check only accepts user name value if regex
for barcode not set up

This fix allows a patron to log into the self-check interface with either
a barcode or a user name.

Written by: Bob Wicksall <bwicksall@pls-net.org>

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
4 years agoLP1908743 Hold pickup lib does not require have-users; repairs
Bill Erickson [Tue, 9 Feb 2021 16:10:41 +0000 (11:10 -0500)]
LP1908743 Hold pickup lib does not require have-users; repairs

To match the TPAC, only disable org units where can_have_vols is false
in the hold pickup library selector (plus those explicitly disabled via
setting).

Also fixes a thinko in the settings retrieval code.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1914116: Apply html filter to mkurl() output
Jason Boyer [Mon, 8 Feb 2021 19:20:32 +0000 (14:20 -0500)]
LP1914116: Apply html filter to mkurl() output

Because of the way that mkurl() generates its query parameters they're
generally escaped correctly, but nowhere do we run the output of mkurl()
through the html filter to correctly handle ampersands. Rather than adding
"|html" to every invocation of mkurl, it's just added to the macro directly.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
4 years agoRevert "LP908568 Double-click copy opens editor"
Chris Sharp [Mon, 8 Feb 2021 18:14:24 +0000 (13:14 -0500)]
Revert "LP908568 Double-click copy opens editor"

This reverts commit c2eb8179fc3d10684994b0f7eae9e8db4828d6ce.

4 years agoLP1908743 Staff catalog honors org-not-pickup-lib
Bill Erickson [Mon, 11 Jan 2021 19:15:33 +0000 (14:15 -0500)]
LP1908743 Staff catalog honors org-not-pickup-lib

In the Angular staff catalog, disable org units in the pickup library
selector that have the 'opac.holds.org_unit_not_pickup_lib' org unit
setting applied, plus those that have false values for can-have-users or
can-have-vols.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoLP1908743 Org select now supports disabled org unit
Bill Erickson [Fri, 5 Feb 2021 16:16:59 +0000 (11:16 -0500)]
LP1908743 Org select now supports disabled org unit

Org units specified as disabled in <eg-org-select /> are now visible,
but disabled when the typeahead displays.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoRevert "LP1908743 Staff catalog honors org-not-pickup-lib"
Chris Sharp [Fri, 5 Feb 2021 20:30:31 +0000 (15:30 -0500)]
Revert "LP1908743 Staff catalog honors org-not-pickup-lib"

This reverts commit ba99417a1b289593cabffd554a70f2f62aefc323.

4 years agoLP1913338 Catalog search form visibility stickiness
Bill Erickson [Thu, 28 Jan 2021 15:32:11 +0000 (10:32 -0500)]
LP1913338 Catalog search form visibility stickiness

On pages in the Angular staff catalog where the search form is collapsed
by default, users may now also manually expand and re-collapse the form.
The last used choice will be sticky via new workstation setting.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP908568 Double-click copy opens editor
Bill Erickson [Tue, 2 Feb 2021 19:48:46 +0000 (14:48 -0500)]
LP908568 Double-click copy opens editor

Double-clicking a copy row in the Angular staff catalog Holdings View
now opens the copy in the copy editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1913458 Bucket Add/Delete Item Operations Batched
Bill Erickson [Wed, 27 Jan 2021 16:55:56 +0000 (11:55 -0500)]
LP1913458 Bucket Add/Delete Item Operations Batched

In the record bucket administration UI, the act of adding or removing
items from a bucket are now done in batch to avoid too many parallel
requests.

These changes include new batch create/delete API calls that can operate
on any bucket type, so other UI's can be similarly batched as needed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1913811 progress dialog on Items Out grid
Jeff Davis [Mon, 1 Feb 2021 22:17:05 +0000 (14:17 -0800)]
LP1913811 progress dialog on Items Out grid

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
4 years agoLP1913811 Items out notice summary API batching
Bill Erickson [Mon, 1 Feb 2021 15:54:18 +0000 (10:54 -0500)]
LP1913811 Items out notice summary API batching

Tweak the open-ils.actor.user.itemsout.notices API to accept an array of
circulation IDs so the call can be batched from the client.  Similarly
modify the AngJS client to request the notice summaries in batch.

Further improves the notices API by removing an unneeded join and a
minor security fix to verify perms based on the in-database user ID
instead of the ID provided by the caller (w/ the note that the API only
returns numbers, not user data).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
4 years agoQuipu - Adjust iframe height
Terran McCanna [Wed, 3 Feb 2021 16:42:28 +0000 (11:42 -0500)]
Quipu - Adjust iframe height

The iframe was cutting off the form causing a double scroll
bar in the browser. This increases the height so that additional
scrolling is not needed.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoAdds Google Analytics Code to Bootstrap OPAC
Terran McCanna [Wed, 3 Feb 2021 14:54:49 +0000 (09:54 -0500)]
Adds Google Analytics Code to Bootstrap OPAC

(Was already in previous OPAC)

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoAlso making the system level and consortium level bold
Terran McCanna [Wed, 3 Feb 2021 21:58:41 +0000 (16:58 -0500)]
Also making the system level and consortium level bold
for better readability.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoPINES Customization: Styling for not-pickup-lib
Terran McCanna [Wed, 3 Feb 2021 19:44:31 +0000 (14:44 -0500)]
PINES Customization: Styling for not-pickup-lib

On bootstrap OPAC place holds page, add styling to library
selector to make it more obvious which org units cannot be
selected as pickup libraries.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoPINES fix for old catalog hold email display
Terran McCanna [Wed, 3 Feb 2021 15:31:58 +0000 (10:31 -0500)]
PINES fix for old catalog hold email display

Problem: If a staff member uses the old/traditional catalog
through the 3.6 staff client to place a hold, the staff member's
email address displays rather than the patron. It still saved
correctly, just displayed wrong.

Fix: This blocks the display of the email address on the holds
page when using the staff client. It still displays to patrons
using the OPAC.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoAdd OpenAthens tables/seed values to PINES.
Chris Sharp [Wed, 3 Feb 2021 19:29:18 +0000 (14:29 -0500)]
Add OpenAthens tables/seed values to PINES.

4 years agoStaff Client: kludge to allow multiple term searches from splash page
Chris Sharp [Fri, 22 Jan 2021 21:13:01 +0000 (16:13 -0500)]
Staff Client: kludge to allow multiple term searches from splash page

4 years agoOPAC: update size and maxlength of billing zipcode
Chris Sharp [Thu, 21 Jan 2021 19:49:51 +0000 (14:49 -0500)]
OPAC: update size and maxlength of billing zipcode

4 years agoLP1687545: Force TT CGI plugin to use ampersands in query strings
Jason Boyer [Thu, 21 Jan 2021 16:08:36 +0000 (11:08 -0500)]
LP1687545: Force TT CGI plugin to use ampersands in query strings

Change our already-forked version of TemplateToolkit::Plugin::CGI
to use "old" style urls which became the new / only style after
CGI.pm was deprecated. This causes the query_strings property to
consistently use ampersands to separate query parameters.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
4 years agoOPAC: update regex for postal code, correct typo
Chris Sharp [Wed, 20 Jan 2021 21:02:02 +0000 (16:02 -0500)]
OPAC: update regex for postal code, correct typo

4 years agoPINES Custom: Re-add persistent login boxes to OPAC
Terran McCanna [Tue, 19 Jan 2021 15:49:57 +0000 (10:49 -0500)]
PINES Custom: Re-add persistent login boxes to OPAC

I took these off before because I didn't think they actually
worked, but I was wrong, so adding them back in!

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoPINES - Stripe Payment Fix
Terran McCanna [Tue, 19 Jan 2021 20:34:24 +0000 (15:34 -0500)]
PINES - Stripe Payment Fix

Proposed fix to make the Stripe payment form display

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoPINES Custom: 3rd attempt to fix the age protection star
Terran McCanna [Sun, 17 Jan 2021 20:20:27 +0000 (15:20 -0500)]
PINES Custom: 3rd attempt to fix the age protection star

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoPINES Custom OPAC Copy Table: Display Age Protection Star
Terran McCanna [Sun, 17 Jan 2021 18:09:05 +0000 (13:09 -0500)]
PINES Custom OPAC Copy Table: Display Age Protection Star

Fixes a thinko with my previous commit to display a star
next to age-protected items.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoOPAC: fix Quipu ecard for bootstrap
Chris Sharp [Sun, 17 Jan 2021 21:25:34 +0000 (16:25 -0500)]
OPAC: fix Quipu ecard for bootstrap

4 years agoOPAC: disable ebook API by default
Chris Sharp [Sun, 17 Jan 2021 03:44:43 +0000 (22:44 -0500)]
OPAC: disable ebook API by default

4 years agoLP1908743 Staff catalog honors org-not-pickup-lib
Bill Erickson [Mon, 11 Jan 2021 19:15:33 +0000 (14:15 -0500)]
LP1908743 Staff catalog honors org-not-pickup-lib

In the Angular staff catalog, hide org units in the pickup library
selector that have the 'opac.holds.org_unit_not_pickup_lib' org unit
setting applied.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1911031 Staff catalog honors pickup lib change
Bill Erickson [Mon, 11 Jan 2021 17:06:21 +0000 (12:06 -0500)]
LP1911031 Staff catalog honors pickup lib change

Manually modifying the pickup library in the staff catalog holds
placement form now results in using the selected pickup library.
Previously, the change was ignored by the form.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoPINES Customization for Self-Check: Hide Pay Fines Button
Terran McCanna [Tue, 12 Jan 2021 19:18:48 +0000 (14:18 -0500)]
PINES Customization for Self-Check: Hide Pay Fines Button

There are some environments where the Pay Fines button was
appearing even though it is supposed to be hidden via CSS.

This adds more CSS to move the button off the side of the page.
(Removing the button entirely broke the interface.)

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agocorrect issue with metabib search
Chris Sharp [Tue, 12 Jan 2021 19:31:04 +0000 (14:31 -0500)]
correct issue with metabib search

4 years agoRevert "PINES Self-Check: Fix for Pay Fines Button"
Chris Sharp [Tue, 12 Jan 2021 16:39:42 +0000 (11:39 -0500)]
Revert "PINES Self-Check: Fix for Pay Fines Button"

This reverts commit 8e411f5246c7ca3fcd97a81ae063f0c3f63a9a3a.

4 years agoRevert "LP1908743 Staff catalog honors org-not-pickup-lib"
Chris Sharp [Tue, 12 Jan 2021 16:20:14 +0000 (11:20 -0500)]
Revert "LP1908743 Staff catalog honors org-not-pickup-lib"

This reverts commit 1ceb81675e8fb3835e41a0e70602f4b1eb763de2.

4 years agoRevert "LP1901760 Remove SharedWorker testing cruft"
Chris Sharp [Tue, 12 Jan 2021 16:04:46 +0000 (11:04 -0500)]
Revert "LP1901760 Remove SharedWorker testing cruft"

This reverts commit d86fd16bd5e6ddc05ba15d20d525cc2e73e6c777.

4 years agoChanges remaining links not to use ctx media links.
Tiffany Little [Tue, 12 Jan 2021 13:06:15 +0000 (08:06 -0500)]
Changes remaining links not to use ctx media links.

4 years agoLP1908743 Staff catalog honors org-not-pickup-lib
Bill Erickson [Mon, 11 Jan 2021 19:15:33 +0000 (14:15 -0500)]
LP1908743 Staff catalog honors org-not-pickup-lib

In the Angular staff catalog, hide org units in the pickup library
selector that have the 'opac.holds.org_unit_not_pickup_lib' org unit
setting applied.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoPINES Self-Check: Fix for Pay Fines Button
Terran McCanna [Mon, 11 Jan 2021 21:57:44 +0000 (16:57 -0500)]
PINES Self-Check: Fix for Pay Fines Button

The 'Pay Fines' button was appearing in some scenarios, even
though it's not possible to pay fines through the self-check
at this time. This completely removes that button.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoLP1896285 Post mark-missing serialized item load
Bill Erickson [Thu, 17 Dec 2020 15:19:14 +0000 (07:19 -0800)]
LP1896285 Post mark-missing serialized item load

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
4 years agoLP1901760 Remove SharedWorker testing cruft
Bill Erickson [Mon, 11 Jan 2021 16:33:56 +0000 (11:33 -0500)]
LP1901760 Remove SharedWorker testing cruft

Otherwise they will work for no one!

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1901760 Improve SharedWorker non-support handling (Angular)
Bill Erickson [Mon, 4 Jan 2021 17:10:05 +0000 (12:10 -0500)]
LP1901760 Improve SharedWorker non-support handling (Angular)

Reject requests to SharedWorker resources when shared workers are not
supported.  The caller is required to handle the rejection in whatever
way makes sense for the calling code.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoLP1901760 Improve SharedWorker non-support handling (AngJS)
Bill Erickson [Mon, 4 Jan 2021 17:05:24 +0000 (12:05 -0500)]
LP1901760 Improve SharedWorker non-support handling (AngJS)

Force the SharedWorker code to run before org settings cache requests
are attempted so that we can tell before the lovefield request is made
wether or not a connection will be successfull.  In other words, we may
not know if cannotConnect is true yet, so force that logic to run first.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoSQL: address missing booking perms
Chris Sharp [Mon, 11 Jan 2021 17:56:34 +0000 (12:56 -0500)]
SQL: address missing booking perms

4 years agoLP1881607 Angular catalog e-resource links display
Bill Erickson [Mon, 1 Jun 2020 16:32:21 +0000 (12:32 -0400)]
LP1881607 Angular catalog e-resource links display

Display electronic resource links (MARC 856's) in the Angular staff
catalog.  The extraction logic, which matches the TPAC, has been put
into its own API.

To test in concerto, navigate to:

/eg2/staff/catalog/record/208

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoRevert "LP1881607 Angular catalog e-resource links display"
Chris Sharp [Fri, 8 Jan 2021 18:24:02 +0000 (13:24 -0500)]
Revert "LP1881607 Angular catalog e-resource links display"

This reverts commit db72e04fb13eba74fc8304bab0db6b5a050615e5.

4 years agoPINES Local Customizations: Omnibus 3
Terran McCanna [Thu, 7 Jan 2021 21:01:50 +0000 (16:01 -0500)]
PINES Local Customizations: Omnibus 3

This last batch just fixes a translation string issue and fixes a layout
problem on the record detail page.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoLP1908619 Update button label
Terran McCanna [Thu, 7 Jan 2021 18:39:09 +0000 (13:39 -0500)]
LP1908619 Update button label

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoLP1908619 Update to script
Terran McCanna [Thu, 7 Jan 2021 18:00:46 +0000 (13:00 -0500)]
LP1908619 Update to script

And the other bit I forgot to add before...

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoLP1908619 Staff Catalog Preferences
Terran McCanna [Tue, 5 Jan 2021 19:12:14 +0000 (14:12 -0500)]
LP1908619 Staff Catalog Preferences

Aaaaaand, adding the other file I forgot to add in the last commit.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoLP1908619 Adjustments to Staff Search Preferences Page
Terran McCanna [Tue, 5 Jan 2021 19:09:36 +0000 (14:09 -0500)]
LP1908619 Adjustments to Staff Search Preferences Page

Change 'Catalog Preferences' to 'Search Preferences' and
add a Return button at the bottom to make it more obvious how
to get out of the interface.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoSQL: remove acq perm updates per Tiffany
Chris Sharp [Tue, 5 Jan 2021 13:19:19 +0000 (08:19 -0500)]
SQL: remove acq perm updates per Tiffany

4 years agoLP1910138 Display Precat Info in Circ History
Terran McCanna [Mon, 4 Jan 2021 19:32:40 +0000 (14:32 -0500)]
LP1910138 Display Precat Info in Circ History

This adds the precat title and author to the circ
history table in My Account in the Bootstrap OPAC.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
4 years agoLP1906855 Show Covers in My Account
Terran McCanna [Mon, 4 Jan 2021 19:14:13 +0000 (14:14 -0500)]
LP1906855 Show Covers in My Account

Adds covers to current circs, circ history, current holds,
holds history tables.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
4 years agoLP1908616 Add email display to hold edit
Terran McCanna [Mon, 4 Jan 2021 20:09:15 +0000 (15:09 -0500)]
LP1908616 Add email display to hold edit

Note: This is built atop the patch for LP1902265

This display's the current email address (or note if there
is no address) on the Edit Hold page of My Account in the
Bootstrap OPAC.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoPINES Customization: Staff Page Redirect
Terran McCanna [Thu, 31 Dec 2020 22:12:35 +0000 (17:12 -0500)]
PINES Customization: Staff Page Redirect

Add redirect file so that you can get to the staff page
with just /staff instead of /eg/staff.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoLP1908724 Staff Catalog Sort by PubDate Wording
Terran McCanna [Thu, 31 Dec 2020 14:43:31 +0000 (09:43 -0500)]
LP1908724 Staff Catalog Sort by PubDate Wording

Changes wording of dropdown on search results page and matches
sort order to wording.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoLP1900159 Staff Catalog Typo - No Results
Terran McCanna [Thu, 31 Dec 2020 14:58:25 +0000 (09:58 -0500)]
LP1900159 Staff Catalog Typo - No Results

Corrects 'maching' to 'matching' on 3 results pages.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoPINES Customization: Display Report ID
Terran McCanna [Thu, 31 Dec 2020 21:07:57 +0000 (16:07 -0500)]
PINES Customization: Display Report ID

Show report ID in classic reporter to make troubleshooting
easier.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoPINES Customization to Copy Buckets View
Terran McCanna [Wed, 30 Dec 2020 23:28:01 +0000 (18:28 -0500)]
PINES Customization to Copy Buckets View

Note that this view is heavily customized already. This change
adds precat isbn/title/author and item alerts columns.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoLP1907866 Bootstrap Opac: Adding basket to Existing List
Garry Collum [Mon, 14 Dec 2020 20:18:15 +0000 (15:18 -0500)]
LP1907866 Bootstrap Opac: Adding basket to Existing List

Fixes the issue with the screen not showing lists after adding items to an existing list from a basket.

To test:

Create a list in the Bootstrap Opac.

Add some items to a basket. Select Add Basket to Saved List, and send the items to the list that was just created.
Notice on the list page after the items have been added that you can no longer see any existing list names.  The screen displays '...From Basket'

Apply the patch.
Add some more items from a basket into the list.  The existing list names are displayed after the items are sent to the existing list.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoLP1909584 Title for Shared Lists in Bootstrap OPAC
Terran McCanna [Thu, 31 Dec 2020 22:54:50 +0000 (17:54 -0500)]
LP1909584 Title for Shared Lists in Bootstrap OPAC

This displays the title and description for shared lists
when viewed in the Bootstrap OPAC.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoPINES Customization to Staff Place Hold Screen
Terran McCanna [Thu, 31 Dec 2020 21:34:35 +0000 (16:34 -0500)]
PINES Customization to Staff Place Hold Screen

Tighten up the white space a little bit to display better on
laptop monitors.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoPINES Customization: Open Record in OPAC
Terran McCanna [Wed, 30 Dec 2020 20:05:22 +0000 (15:05 -0500)]
PINES Customization: Open Record in OPAC

Add link to new staff catalog record view to open the record
in the public OPAC.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoLP1812866 Item Alert column in Item Buckets
Terran McCanna [Wed, 30 Dec 2020 19:02:00 +0000 (14:02 -0500)]
LP1812866 Item Alert column in Item Buckets

This adds an Item Alert column to Item Buckets that displays
the item alert note(s).

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoPINES Temporary Workaround for LP1908614
Terran McCanna [Wed, 30 Dec 2020 16:58:18 +0000 (11:58 -0500)]
PINES Temporary Workaround for LP1908614

I wasn't able to fix that bug, but this temporary workaround will
do until it gets fixed. This should be reverted when that fix is
available in a future Evergreen version.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoPINES KPAC Customizations
Terran McCanna [Tue, 29 Dec 2020 20:08:10 +0000 (15:08 -0500)]
PINES KPAC Customizations

Fix problem with copy table column headers and styled alert message.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoPINES OPAC Customizations - More Tweaks
Terran McCanna [Tue, 29 Dec 2020 19:51:19 +0000 (14:51 -0500)]
PINES OPAC Customizations - More Tweaks

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoPINES Customizations to OPAC - Advanced Search
Terran McCanna [Tue, 29 Dec 2020 18:35:58 +0000 (13:35 -0500)]
PINES Customizations to OPAC - Advanced Search

Fix problems with advanced search filter display on search results page.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoPINES Bootstrap Customizations
Terran McCanna [Thu, 24 Dec 2020 00:22:31 +0000 (19:22 -0500)]
PINES Bootstrap Customizations

Omnibus 2 - collection of customizations, mostly to
translation strings.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoUpdates PINES eg2 splash page to match eg1.
Tiffany Little [Fri, 18 Dec 2020 18:36:30 +0000 (13:36 -0500)]
Updates PINES eg2 splash page to match eg1.

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
4 years agoUpdates link for Advanced Search on splash screen.
Tiffany Little [Fri, 18 Dec 2020 18:04:32 +0000 (13:04 -0500)]
Updates link for Advanced Search on splash screen.

4 years agoLP1908298 Bootstrap OPAC: Type filter missing from advanced search
Garry Collum [Wed, 16 Dec 2020 19:22:54 +0000 (14:22 -0500)]
LP1908298 Bootstrap OPAC: Type filter missing from advanced search

The Item Type filter and the Bib Level filter were both commented out in the opac's config.tt2 file.
This patch removes the comment hashmarks.

To test.
Go to the Advanced Search in the Bootstrap Opac.
Notice that the Item Type filter and Bib Level Filters are missing.
Apply the patch.
The two filters should now be displayed.

Signed-off-by: Garry Collum <gcollum@gmail.com>
4 years agoLP1907286 Staff catalog sets last retrieved record
Bill Erickson [Tue, 8 Dec 2020 20:33:13 +0000 (12:33 -0800)]
LP1907286 Staff catalog sets last retrieved record

Navigating to the detail page for a bib record in the Angular Staff
Catalog now correctly sets the value for the
'eg.cat.last_record_retrieved' local storage item, allowing Retrieve
Last Bib Record to work as expected.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1895676: Record Print and Email Enhancements for Bootstrap OPAC
Jason Boyer [Fri, 4 Dec 2020 19:13:48 +0000 (14:13 -0500)]
LP1895676: Record Print and Email Enhancements for Bootstrap OPAC

Bring the improvements from LP1749475 to the Bootstrap OPAC.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
4 years agoChanges the color of the Place Hold button to green.
Tiffany Little [Thu, 17 Dec 2020 14:21:09 +0000 (09:21 -0500)]
Changes the color of the Place Hold button to green.

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
4 years agoUpdates the lineitem catalog link to point to the new Angular catalog.
Tiffany Little [Wed, 16 Dec 2020 18:40:20 +0000 (13:40 -0500)]
Updates the lineitem catalog link to point to the new Angular catalog.

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
4 years agoPINES Customization: Added Content Fix
Terran McCanna [Wed, 16 Dec 2020 16:32:55 +0000 (11:32 -0500)]
PINES Customization: Added Content Fix

This adds a missing line that I left off of the previous added
content customization for the bootstrap OPAC.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoOPAC: restore books image for carousels
Chris Sharp [Wed, 16 Dec 2020 13:25:14 +0000 (08:25 -0500)]
OPAC: restore books image for carousels

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
4 years agoStaff Client: remove Classic Circulation View from core sources
Chris Sharp [Tue, 15 Dec 2020 20:17:03 +0000 (15:17 -0500)]
Staff Client: remove Classic Circulation View from core sources

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
4 years agoLP1840950 Patron expiration date & iPads
Terran McCanna [Wed, 20 May 2020 19:33:57 +0000 (15:33 -0400)]
LP1840950 Patron expiration date & iPads

This resolves a problem where the patron expiration date was not
displaying when editing a patron account on an iOS device because
Safari did not allow the deprecated Date() function.

This code uses javascript to reformat the date, similar to how the
DOB on the same form is handled.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoLP1881607 Angular catalog located URIs
Bill Erickson [Wed, 23 Sep 2020 15:15:22 +0000 (11:15 -0400)]
LP1881607 Angular catalog located URIs

Display in-range located URIs in the staff catalog record summary pane.

Also applies a fix to the staff catalog to clear cached record detail
summaries on new searches to ensure the correct org-scoped version of
the record summary is retrieved on each new navigation to the detail
page.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoLP1881607 Angular catalog e-resource links display
Bill Erickson [Mon, 1 Jun 2020 16:32:21 +0000 (12:32 -0400)]
LP1881607 Angular catalog e-resource links display

Display electronic resource links (MARC 856's) in the Angular staff
catalog.  The extraction logic, which matches the TPAC, has been put
into its own API.

To test in concerto, navigate to:

/eg2/staff/catalog/record/208

Signed-off-by: Bill Erickson <berickxx@gmail.com>
4 years agoPINES OPAC Customization: Make Lists Prettier
Terran McCanna [Fri, 11 Dec 2020 23:06:04 +0000 (18:06 -0500)]
PINES OPAC Customization: Make Lists Prettier

Note that more work should be done on master to make lists more
user-friendly, but this will be fine for us now.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
4 years agoPINES OPAC Customization: Renewals Remaining Tooltip
Terran McCanna [Fri, 11 Dec 2020 21:26:55 +0000 (16:26 -0500)]
PINES OPAC Customization: Renewals Remaining Tooltip

Move tooltip from each row in My Account > Items Out to column header.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>