evergreen/tadl.git
8 years agoLP#1569884: stamp schema update
Galen Charlton [Thu, 28 Apr 2016 15:31:20 +0000 (11:31 -0400)]
LP#1569884: stamp schema update

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1569884: fix schema update script
Galen Charlton [Thu, 28 Apr 2016 15:27:11 +0000 (11:27 -0400)]
LP#1569884: fix schema update script

CREATE INDEX cannot run concurrently in a transaction
block period, at least as of 9.4.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1569884 Fix two problems in previous commit.
Jason Stephenson [Wed, 27 Apr 2016 19:43:31 +0000 (15:43 -0400)]
LP#1569884 Fix two problems in previous commit.

The CREATE TABLE biblio.monograph_part statement in
010.schema.biblio.sql ended up with a trailing comma.

The CREATE UNIQUE INDEX on biblio.monograph_part cannot be done
CONCURRENTLY at DB creation time, apparently.  At least not on
PostgreSQL 9.3.

Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1569884 Updated base schema with monograph parts index.
Steven Callender [Wed, 27 Apr 2016 16:05:48 +0000 (12:05 -0400)]
LP#1569884 Updated base schema with monograph parts index.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1569884 Allow deleted monograph parts to be recreated.
Steven Callender [Wed, 13 Apr 2016 15:15:27 +0000 (11:15 -0400)]
LP#1569884 Allow deleted monograph parts to be recreated.

Changed the constraint on the biblio.monograph_part table to allow for a
monograph part to be created if a duplicate deleted version is found.

To test:

[1] Add a monograph part to a bib.
[2] Delete that monograph part.
[3] Attempt to add a monograph part to the same bib using
    the same part label. Without the patches installed, this
    will fail; upon applying the database update, this operation
    should succeed.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1569884: add regression test
Galen Charlton [Thu, 28 Apr 2016 15:20:29 +0000 (11:20 -0400)]
LP#1569884: add regression test

This pgTAP test verifies that if you logically delete a monograph part,
you can subsequently add a new one with the same label as that of the
deleted one.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP 1562426: Renumber Perl live_t tests.
Jason Stephenson [Sun, 27 Mar 2016 00:16:34 +0000 (20:16 -0400)]
LP 1562426: Renumber Perl live_t tests.

We had some overlap in numbers at the beginning of test file names.
The OCD in me think this should be straightened out.  This branch
renumbers the duplicates starting with 10-.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
8 years agoLP#1564079 Stamping upgrade script
Kathy Lussier [Wed, 27 Apr 2016 14:35:49 +0000 (10:35 -0400)]
LP#1564079 Stamping upgrade script

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
8 years agoLP#1564079 Checkout history skips nonexistent items
Bill Erickson [Wed, 30 Mar 2016 21:57:59 +0000 (17:57 -0400)]
LP#1564079 Checkout history skips nonexistent items

Modify the user checkout history migration process
(2.9.3-2.10.0-upgrade-db.sql and 0960.schema.decouple_co_history.sql) to
avoid inserting history rows for circulations whose copies do not
exist in the database.

For reference, this is a rare condition that cannot be recreated in a
modern EG system short of modifying constraints.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
8 years agoLP#1564079 Checkout history handles serials
Bill Erickson [Wed, 30 Mar 2016 21:49:26 +0000 (17:49 -0400)]
LP#1564079 Checkout history handles serials

Remove the target_copy foreign key constraint on action.usr_circ_history
so that it does not prevent creation of rows from circulation's that
link to serial.unit objects.  Similar to action.circulation, the foreign
key constraint is enforced via a evergreen.fake_fkey_tgr trigger
instead.

This modifies the 2.9.3-2.10.0-upgrade-db.sql and 0960 upgrade scripts,
since without this change, the scripts may fail.

A separate upgrade script is added to drop the constraint for those who
have already successfully run the the 2.9.3-2.10.0-upgrade-db.sql script
(i.e. those who don't use serials).  For simplicity, the
evergreen.fake_fkey_tgr trigger is only applied in this separate upgrade
script (in addition to the base schema, of course).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
8 years agoDocs: image fix
Angela Kilsdonk [Wed, 20 Apr 2016 18:42:09 +0000 (14:42 -0400)]
Docs: image fix

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
8 years agoDocs: Paid PO Lineitems
Angela Kilsdonk [Wed, 20 Apr 2016 18:23:02 +0000 (14:23 -0400)]
Docs: Paid PO Lineitems

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
8 years agoDocs: Funds disencumbered when invoice is closed
Angela Kilsdonk [Wed, 20 Apr 2016 15:04:45 +0000 (11:04 -0400)]
Docs: Funds disencumbered when invoice is closed

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
8 years agoLP#1559121: remove Debian Squeeze support
Galen Charlton [Fri, 18 Mar 2016 14:34:40 +0000 (10:34 -0400)]
LP#1559121: remove Debian Squeeze support

Now that Debian Squeeze's LTS (long-term support) period
has ended, Evergreen no longer offers community support
for that distribution. This patch removes references
to Squeeze from the installation scripts and documentation.

To test:

[1] Verify that Debian Squeeze is no longer referenced in
    the installation documentation.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
Conflicts:
docs/installation/server_upgrade.txt

8 years agoDocs: clean up formatting & typos in using_the_public_access_catalog.txt
Yamil Suarez [Fri, 22 Apr 2016 20:51:20 +0000 (16:51 -0400)]
Docs: clean up formatting & typos in using_the_public_access_catalog.txt

Thanks to Anna Goben for these fixes.

Signed-off-by: Yamil Suarez <yamil@yamil.com>
8 years agoDocs: Screenshots and step by step instructions added to Self Check section
Jennifer Pringle [Fri, 22 Apr 2016 03:02:21 +0000 (20:02 -0700)]
Docs: Screenshots and step by step instructions added to Self Check section

Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
8 years agoLP#1573372: Opt-in test broken because it uses bail-out.
Jason Stephenson [Fri, 22 Apr 2016 03:29:42 +0000 (23:29 -0400)]
LP#1573372: Opt-in test broken because it uses bail-out.

Use skip instead!

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
8 years agoDocs: New changes to new patron registration duplicate search.
Jennifer Pringle [Thu, 21 Apr 2016 22:36:36 +0000 (15:36 -0700)]
Docs: New changes to new patron registration duplicate search.

Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
8 years agoLP#1573364: Use a timezone in the future backdate checkin test.
Jason Stephenson [Fri, 22 Apr 2016 03:00:09 +0000 (23:00 -0400)]
LP#1573364: Use a timezone in the future backdate checkin test.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
8 years agoDocs: Exclude Electronic Resources
Anna Goben [Fri, 22 Apr 2016 02:58:14 +0000 (22:58 -0400)]
Docs: Exclude Electronic Resources

Signed-off-by: Yamil Suarez <yamil@yamil.com>
8 years agoDocs: Updated attributions.txt
Jane Sandberg [Thu, 21 Apr 2016 22:22:58 +0000 (15:22 -0700)]
Docs: Updated attributions.txt

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
8 years agoDocs: resized image
Yamil Suarez [Wed, 20 Apr 2016 20:20:16 +0000 (16:20 -0400)]
Docs: resized image

Signed-off-by: Yamil Suarez <yamil@yamil.com>
8 years agoDocs: Expanded information about item record view in OPAC
Debbie Luchenbill [Wed, 20 Apr 2016 20:17:55 +0000 (16:17 -0400)]
Docs: Expanded information about item record view in OPAC

Signed-off-by: Yamil Suarez <yamil@yamil.com>
8 years agoDocs: resized image
Yamil Suarez [Wed, 20 Apr 2016 19:58:12 +0000 (15:58 -0400)]
Docs: resized image

Signed-off-by: Yamil Suarez <yamil@yamil.com>
8 years agoDocs: added tip on using hold counts in renewals
Debbie Luchenbill [Wed, 20 Apr 2016 19:07:51 +0000 (15:07 -0400)]
Docs: added tip on using hold counts in renewals

Signed-off-by: Yamil Suarez <yamil@yamil.com>
8 years agoDocs: small syntax fix circulation/circulation_patron_records.txt
Yamil Suarez [Fri, 15 Apr 2016 15:58:16 +0000 (11:58 -0400)]
Docs: small syntax fix circulation/circulation_patron_records.txt

Signed-off-by: Yamil Suarez <yamil@yamil.com>
8 years agoDocs: small syntax fix in cataloging/authorities.txt
Yamil Suarez [Fri, 15 Apr 2016 15:53:56 +0000 (11:53 -0400)]
Docs: small syntax fix in cataloging/authorities.txt

Signed-off-by: Yamil Suarez <yamil@yamil.com>
8 years agoDocs: small fix for circulation_patron_records_web_client.txt & root.txt
Yamil Suarez [Wed, 13 Apr 2016 02:36:12 +0000 (22:36 -0400)]
Docs: small fix for circulation_patron_records_web_client.txt & root.txt

Signed-off-by: Yamil Suarez <yamil@yamil.com>
8 years agoDocs: small fix for lsa-barcode_completion.txt & root.txt
Yamil Suarez [Wed, 13 Apr 2016 02:33:43 +0000 (22:33 -0400)]
Docs: small fix for lsa-barcode_completion.txt & root.txt

Signed-off-by: Yamil Suarez <yamil@yamil.com>
8 years agoDocs: update root.txt to include 2.10 release notes
Yamil Suarez [Thu, 7 Apr 2016 17:51:14 +0000 (13:51 -0400)]
Docs: update root.txt to include 2.10 release notes

Signed-off-by: Yamil Suarez <yamil@yamil.com>
8 years agoDocs: typo fix in authentication_proxy.txt
Yamil Suarez [Tue, 5 Apr 2016 23:13:03 +0000 (19:13 -0400)]
Docs: typo fix in authentication_proxy.txt

Signed-off-by: Yamil Suarez <yamil@yamil.com>
8 years agoLP#1564685 Prevent linked address edit on reload
Bill Erickson [Sat, 2 Apr 2016 22:11:12 +0000 (18:11 -0400)]
LP#1564685 Prevent linked address edit on reload

Prevent editing of linked addresses when a user is loaded after the
clone operation.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1564685 Avoid referencing out-of-scope stat cats
Bill Erickson [Fri, 1 Apr 2016 00:35:00 +0000 (20:35 -0400)]
LP#1564685 Avoid referencing out-of-scope stat cats

Fixes a bug in the patron editor where out-of-scope stat cats would be
incorrectly bundled in the patron save operation, resulting in a
server-side error on save.  In short, ignore out-of-scope stat cat
entries for patrons in the editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1564685 Prevent edit of linked addresses
Bill Erickson [Mon, 28 Mar 2016 20:10:10 +0000 (16:10 -0400)]
LP#1564685 Prevent edit of linked addresses

Do not allow a cloned user to modify a linked address.  Only the address
owner should be able to do that.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1564685 New Address button is always accessible
Bill Erickson [Mon, 28 Mar 2016 20:00:18 +0000 (16:00 -0400)]
LP#1564685 New Address button is always accessible

The New Address button in the patron editor is now always accessible,
regardless of the existence of any addresses.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1564685 Repair patron editor checkboxes sizing
Bill Erickson [Mon, 28 Mar 2016 19:57:26 +0000 (15:57 -0400)]
LP#1564685 Repair patron editor checkboxes sizing

Fix the checkbox HTML markup to prevent huge checkboxes in the patron
editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1564685 Required-field org settings overlay defaults
Bill Erickson [Mon, 28 Mar 2016 19:48:29 +0000 (15:48 -0400)]
LP#1564685 Required-field org settings overlay defaults

An org setting requiring a value for a field in the patron editor means
the field is required, even if it's not required by default.  IOW, fix
the code that was supposed to do that already.

Of note, county and state can now both be marked as required by org
settings in the patron editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1564685 Allow delete of all patron addresses
Bill Erickson [Mon, 28 Mar 2016 19:30:37 +0000 (15:30 -0400)]
LP#1564685 Allow delete of all patron addresses

If the org setting ui.patron.registration.require_address is not true,
allow all addresses to be removed from a patron's account.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1564685 Alert and stop on invalid fields
Bill Erickson [Mon, 28 Mar 2016 19:22:52 +0000 (15:22 -0400)]
LP#1564685 Alert and stop on invalid fields

Display an alert message and prevent save or save+clone when invalid
values exist in the patron edit form.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1564685 Allow barcode as username despite regex
Bill Erickson [Thu, 24 Mar 2016 02:13:44 +0000 (22:13 -0400)]
LP#1564685 Allow barcode as username despite regex

Allow a patron's barcode to be considered a valid username in the patron
editor even in the presence of an 'opac.username_regex' org setting
value that does not match the barcode.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1564685 Avoid dupe usrname warning on matching patron
Bill Erickson [Thu, 24 Mar 2016 01:21:12 +0000 (21:21 -0400)]
LP#1564685 Avoid dupe usrname warning on matching patron

Do not treat usernames as duplicates when they belong to the patron
being edited.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP1564378: Silence Hash Init Warning
Jason Boyer [Thu, 31 Mar 2016 12:08:03 +0000 (08:08 -0400)]
LP1564378: Silence Hash Init Warning

A trivial change to silence a lot of noise (if your libraries
use extending grace periods.)

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
8 years agoLP#1373601: Consider relevant characters before using word-boundary checks
Mike Rylander [Tue, 22 Mar 2016 15:50:58 +0000 (11:50 -0400)]
LP#1373601: Consider relevant characters before using word-boundary checks

To perform unanchored phrase limits, we make sure that the phrase supplied
by the user does not end in the middle of a word by bounding the condition
with word-boundary bracket expresssions.  However, if the phrase starts
or ends with a non-word character (that is, something other than numbers,
letters, or the underscore) then the word-boundary expression won't match.
The effect of this is to cause phrase searches starting or ending in
punctuation to fail when the user would not expect them to.

To address this, we now test the phrase for word-iness at the front and
back before applying word-boundary bracket expressions.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
8 years agoupdate upgrade instructions for 2.10.1
Galen Charlton [Wed, 23 Mar 2016 02:27:04 +0000 (22:27 -0400)]
update upgrade instructions for 2.10.1

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agorelease notes for Evergreen 2.10.1
Galen Charlton [Wed, 23 Mar 2016 02:24:33 +0000 (22:24 -0400)]
release notes for Evergreen 2.10.1

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years ago2.10.0 - 2.10.1 schema update script
Galen Charlton [Wed, 23 Mar 2016 01:51:39 +0000 (21:51 -0400)]
2.10.0 - 2.10.1 schema update script

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1560174 Stamping upgrade script
Dan Wells [Mon, 21 Mar 2016 21:49:15 +0000 (17:49 -0400)]
LP#1560174 Stamping upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
8 years agoLP#1560174: fix MARC import for database upgraded to 2.10.0
Galen Charlton [Mon, 21 Mar 2016 19:23:42 +0000 (15:23 -0400)]
LP#1560174: fix MARC import for database upgraded to 2.10.0

This patch applies the correct version of the vandelay.ingest_items()
stored procedure introduced in the patch for bug 1548143.

To test
-------
[1] Upgrade an Evergreen database to 2.10.0 (a fresh database
    will not run into the bug).
[2] Try importing a MARC bib record via Vandelay using a profile
    that imports items.  This should fail.
[3] Apply the schema update in this patch.
[4] Repeat step 2; this time, the import should succeed.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
8 years agoTranslation updates - newpot
Galen Charlton [Tue, 15 Mar 2016 00:50:25 +0000 (20:50 -0400)]
Translation updates - newpot

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoTranslation updates - po files
Galen Charlton [Thu, 17 Mar 2016 21:43:54 +0000 (17:43 -0400)]
Translation updates - po files

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoforward-port 2.9.3-2.10.0 monolithic DB update script
Galen Charlton [Thu, 17 Mar 2016 22:46:02 +0000 (18:46 -0400)]
forward-port 2.9.3-2.10.0 monolithic DB update script

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoforward-port the 2.10.0 upgrade instructions
Galen Charlton [Thu, 17 Mar 2016 22:50:40 +0000 (18:50 -0400)]
forward-port the 2.10.0 upgrade instructions

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agofinal release notes for 2.10.0
Galen Charlton [Thu, 17 Mar 2016 21:24:15 +0000 (17:24 -0400)]
final release notes for 2.10.0

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoadd list of bugs closed to release notes
Galen Charlton [Thu, 17 Mar 2016 21:20:32 +0000 (17:20 -0400)]
add list of bugs closed to release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoupdate acknowledgments in release notes
Galen Charlton [Thu, 17 Mar 2016 21:05:45 +0000 (17:05 -0400)]
update acknowledgments in release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoPorting 2.9.2 to 2.9.3 database upgrade script.
Jason Stephenson [Wed, 16 Mar 2016 20:57:00 +0000 (16:57 -0400)]
Porting 2.9.2 to 2.9.3 database upgrade script.

Signed-off-by: Jason Stephenson <jstephenson@mvlcstaff.org>
8 years agoPorting 2.8.6 -> 2.8.7 SQL upgrade
Bill Erickson [Wed, 16 Mar 2016 20:46:38 +0000 (16:46 -0400)]
Porting 2.8.6 -> 2.8.7 SQL upgrade

Signed-off-by: Bill Erickson <berickxx@gmail.com>
8 years agoDocs: 2.9.3 Release notes
Kathy Lussier [Wed, 16 Mar 2016 17:54:10 +0000 (13:54 -0400)]
Docs: 2.9.3 Release notes

Adding bug fixes to the point release notes for 2.9.3

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
8 years agodocs-2.8.7 release notes
Kathy Lussier [Wed, 16 Mar 2016 17:35:22 +0000 (13:35 -0400)]
docs-2.8.7 release notes

Adding point release notes for 2.8.7

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
8 years agoLP#1557621 Verify password barcode / deleted users repair
Bill Erickson [Tue, 15 Mar 2016 16:31:37 +0000 (12:31 -0400)]
LP#1557621 Verify password barcode / deleted users repair

* Fixes bug that caused password verify calls to fail with an exception
  when tested with a barcode.

* Verify API always returns false when tested on deleted users.

To test:

1. In the staff client, navigate to Circulation -> Verify Credentials
2. Confirm username and barcode lookups return success for a non-deleted
   user using the correct password.
3. Delete a test user in the database:
   UPDATE actor.usr SET deleted = TRUE WHERE id = <id-of-test-user>;
4. Re-do step 2 confirming non-success results are returned.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1367926: fix syntax error in DB update script
Galen Charlton [Tue, 15 Mar 2016 17:44:58 +0000 (13:44 -0400)]
LP#1367926: fix syntax error in DB update script

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoUpdates to 2.10 release notes
Kathy Lussier [Tue, 15 Mar 2016 15:29:28 +0000 (11:29 -0400)]
Updates to 2.10 release notes

Updates includes fixing some grammatical errors/typos, some rewording and
reorganization to improve clarity, and explicitly calling out new settings.
We also added Christine Morgan to acknwoledgements for her contribution of
new images for hold and transit alerts/slips.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
8 years agodocs: reorganizing, adding information about importing authority records using vandelay
Jane Sandberg [Mon, 14 Mar 2016 23:34:43 +0000 (16:34 -0700)]
docs: reorganizing, adding information about importing authority records using vandelay

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agodocs: Adding instructions for setting up due time in the patron's myopac display
Jane Sandberg [Tue, 1 Mar 2016 00:00:15 +0000 (16:00 -0800)]
docs: Adding instructions for setting up due time in the patron's myopac display

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agodocs: Adding section about facet_groups in advanced search
Jane Sandberg [Mon, 29 Feb 2016 23:42:31 +0000 (15:42 -0800)]
docs: Adding section about facet_groups in advanced search

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1548143 Add release notes
Dan Wells [Tue, 15 Mar 2016 14:22:37 +0000 (10:22 -0400)]
LP#1548143 Add release notes

Add release notes for Vandelay 'parts' import support.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
8 years agoupdate 2.10 release notes with some work that made the RC
Galen Charlton [Tue, 15 Mar 2016 01:09:02 +0000 (21:09 -0400)]
update 2.10 release notes with some work that made the RC

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP1550035 Address deletion / avoid xact collisions
Bill Erickson [Sun, 6 Mar 2016 23:09:30 +0000 (18:09 -0500)]
LP1550035 Address deletion / avoid xact collisions

Avoid transaction collision errors when updating patrons, in cases where
the patron object has to be updated more than once, by refreshing the
last_xact_id value on the in-progress patron object.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1550036 Linked patrons for new users
Bill Erickson [Sun, 6 Mar 2016 22:50:30 +0000 (17:50 -0500)]
LP#1550036 Linked patrons for new users

Support adding auzillary (linked) groups for new patrons in the browser
client editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1553813 Patron editor validation / perm checks.
Bill Erickson [Thu, 25 Feb 2016 04:07:54 +0000 (23:07 -0500)]
LP#1553813 Patron editor validation / perm checks.

1. Adds support for enforcing ui.patron.edit.*.require and
ui.patron.edit.*.regex org unit settings via Angular's ng-pattern and
ng-required attributes.

2. Supports selecting only valid profile groups and home org units.

3. Warns the user when a duplicate barcode or username is encountered.

When any fields in the form are invalid, the save options are disabled.

==

Adds support for enforcing the following permissions:

UPDATE_USER
CREATE_USER
CREATE_USER_GROUP_LINK
UPDATE_PATRON_COLLECTIONS_EXEMPT
UPDATE_PATRON_CLAIM_RETURN_COUNT
UPDATE_PATRON_CLAIM_NEVER_CHECKED_OUT_COUNT
UPDATE_PATRON_ACTIVE_CARD
UPDATE_PATRON_PRIMARY_CARD

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#963341: Unrelated YAOUS breaks MFHD management
Mike Rylander [Mon, 7 Dec 2015 16:57:11 +0000 (11:57 -0500)]
LP#963341: Unrelated YAOUS breaks MFHD management

Part of LP bug 963341 is about how the setting opac.fully_compressed_serial_holdings
breaks staff's ability to manage MFHD attached to serials records.  This
commit unbreaks that by fetching the relevant MFHD regardless of that setting
but should not otherwise change user-visible behavior.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1208613: Reset lineitem cache when resetting table
Dan Wells [Thu, 7 Jan 2016 16:47:43 +0000 (11:47 -0500)]
LP#1208613: Reset lineitem cache when resetting table

Stale cache entries in this table were causing the "expand all"
functionality to break.  This might be a nuclear option, but as far as
I could see, this "cache" gets repopulated on every pagination anyway,
so I don't think we're losing anything.

To test:

[1] Select a large list from the Acquisitions --> My Selection List
    screen.
[2] Click on the Expand All button and the items on the page expand
    with more information.
[3] Click on the Next link to bring up page 2 of the list.
[4] Click on the Expand All button and verify that additional
    information is displayed.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Erica Rohlfs <erohlfs@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1370694: stamp database update
Galen Charlton [Mon, 14 Mar 2016 21:35:59 +0000 (17:35 -0400)]
LP#1370694: stamp database update

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1370694: don't update already-customized format.selfcheck.holds
Galen Charlton [Mon, 14 Mar 2016 21:33:49 +0000 (17:33 -0400)]
LP#1370694: don't update already-customized format.selfcheck.holds

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1370694: clean up whitespace
Galen Charlton [Mon, 14 Mar 2016 21:09:53 +0000 (17:09 -0400)]
LP#1370694: clean up whitespace

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1370694 Selfcheck: "Print List" for Holds view does not work
Terran McCanna [Tue, 1 Mar 2016 21:47:20 +0000 (16:47 -0500)]
LP#1370694 Selfcheck: "Print List" for Holds view does not work

Prior to this change, the holds data was not getting passed to the
print function. Now, it is being captured and passed to the print
function. Because of some sorting discrepancies between the order of
the information being passed from here to the action trigger and the
order that the information is presented when pulled directly out of the
database by the action trigger (which led to data mismatches between the
title/author and the hold status/pickup locations for each printed item),
I modified this script to pass all of the hold information together in the
desired order to the action trigger rather than relying on the template
to match the data coming from the script with the data from the database.

This change requires the action trigger printing template to be updated in
order to work. I've included an upgrade script as well as an update to the
seed data script.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1551447: stamp database update
Galen Charlton [Mon, 14 Mar 2016 21:01:16 +0000 (17:01 -0400)]
LP#1551447: stamp database update

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1551447: don't update already-customized format.selfcheck.fines
Galen Charlton [Mon, 14 Mar 2016 20:48:50 +0000 (16:48 -0400)]
LP#1551447: don't update already-customized format.selfcheck.fines

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1551447 Selfcheck: Printing Fines Prints All Open Transactions
Terran McCanna [Tue, 1 Mar 2016 22:35:28 +0000 (17:35 -0500)]
LP#1551447 Selfcheck: Printing Fines Prints All Open Transactions

This corrects the behavior of the selfcheck fines receipt print template.
Prior to this, it printed all open billable transactions (eg, every item
that the patron had checked out) regardless of whether or not it had bills
associated with it. This adds a small bit of logic to the template to
check for a balance due. It also updates the javascript to check for a
balance on the account before launching the print function to prevent the
system from taking unnecessary action.

This includes a SQL upgrade script to update the Self-Checked Fines
Receipt template for systems that are already in production, as well as
including an update to the seed data.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1275118 Holds history displays canceled holds as active
Terran McCanna [Wed, 2 Mar 2016 21:52:13 +0000 (16:52 -0500)]
LP#1275118 Holds history displays canceled holds as active

Prior to this change, when a patron viewed holds history, canceled holds
displayed as active. From the patron point of view, the hold is no
longer active after it has been canceled.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Erica Rohlfs <erohlfs@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
8 years agoLP#1454871: whitespace cleanup
Galen Charlton [Mon, 14 Mar 2016 19:10:14 +0000 (15:10 -0400)]
LP#1454871: whitespace cleanup

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1454871: Fix KPAC Hold Notification Preferences
Terran McCanna [Thu, 11 Jun 2015 22:15:13 +0000 (18:15 -0400)]
LP#1454871: Fix KPAC Hold Notification Preferences

Correction to KPAC holds notification default preferences to allow for
SMS text messaging options.

Prior to this correction, KPAC hold notifications would only pick up
hold preferences if set to email and/or phone. This correction allows
it to pick up email and/or phone and/or sms notification preferences.

To test, set hold preferences to different options, place hold via the
KPAC, and then view the hold to see which preferences were recognized.
(May need to show columns for Phone Notify, Text Notify, and Email Notify.)

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1548869: tidy up whitespace
Galen Charlton [Mon, 14 Mar 2016 19:06:12 +0000 (15:06 -0400)]
LP#1548869: tidy up whitespace

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1548869 KPAC hold results screen not displaying complete info
Terran McCanna [Wed, 24 Feb 2016 22:17:27 +0000 (17:17 -0500)]
LP#1548869 KPAC hold results screen not displaying complete info

The getit_results.tt2 page was not displaying item title after
hold placement or after adding to a list. It was also not pulling
in the item id (which was needed for navigational links back to the
record) and was not pulling in the list name after adding an item
to a named list.

This patch adds some logic to prevent subroutine conflicts, adds
missing parameters to a function call, and corrects a variable name.

To test:

Log in to the KPAC and perform the following actions:

1. Place a successful hold (results screen should show item title
   and pickup library, and provide links back to record page).
2. Place an unsuccessful hold (try placing a hold on an item you
   already have a hold on - the results screen should show the item
   title).
3. Add item to a temporary list (results screen should show item title).
4. Add item to a named list (results screen should show item title and
   title of list it was added to).

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1549393 - Remove undef values from isbn and issn arrays.
Josh Stompro [Sat, 27 Feb 2016 14:54:04 +0000 (08:54 -0600)]
LP#1549393 - Remove undef values from isbn and issn arrays.

This prevents empty requests being sent to content providers.

This caused a problem for us because invalid ISBNs were causing
requests to Content Cafe to fail, since Content Cafe returns an
error if there is a blank key sent along with valid ISBNs and UPCs.

Specifically we had problems with DVD records from Baker & Taylor because
B&T creates unoffical ISBNs for the DVDs they sell.  Those ISBN's do
not validate when run through B::ISBN.

ISSNs are also cleaned since they are validated and set to undef if
invalid just like ISBNs are.

It shouldn't hurt to not send blank requests to providers in any case.

To test:
1. I know this is a problem with Content Cafe, I don't
know if any other providers are effected.  Let me know
if you need Content Cafe credentials to test.

2. Add an invalid ISBN 020a entry to a bib record that has added content.
9786316271976 is an example of a fake ISBN that doesn't
pass B::ISBN validation.  Or just make up a fake number.

3. Clear out the memcache entries for that record.  In 2.9+ there
is a link to clear the cache in the record detail view under Permalink.

4. Reload the record and the cover art and other added content should
not be displayed.  This is because the invalid ISBN gets set to undef
, and the undef gets sent to content cafe as a blank key request.

5. Now apply the fix.  Clear the memcache entries for that bib, and now
the cover art should be displayed since the undef entries due to the invalid
ISBN's have been removed.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1550495: stamp DB update
Galen Charlton [Mon, 14 Mar 2016 18:46:19 +0000 (14:46 -0400)]
LP#1550495: stamp DB update

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1550495 - Add EDI Cancel Code 85 - used by Baker & Taylor
Josh Stompro [Fri, 4 Mar 2016 19:51:34 +0000 (13:51 -0600)]
LP#1550495 - Add EDI Cancel Code 85 - used by Baker & Taylor

Baker & Taylor send back a quantity code 85 response when they cancel
a line item.  This code wasn't included as one of the built in EDI
codes so those line items were not being canceled automatically in
evergreen.

The system looks for the response code + 1200 to find the cancel reason,
so this code is entered as ID 1285 in the acq.cancel_reason table.

I received confirmation from another system that uses B&T as an EDI vendor
that they also receive code 85 responses when something gets canceled.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoLP#1556339: Register correct method for open-ils.actor.history.hold.visible*
Jeff Davis [Sat, 12 Mar 2016 01:17:20 +0000 (17:17 -0800)]
LP#1556339: Register correct method for open-ils.actor.history.hold.visible*

This fixes a thinko introduced by the patch for
bug 1527342.

To test:

[1] Log into srfsh as a user that has one or more active
    or historical hold requests, then run

    srfsh# request open-ils.actor open-ils.actor.history.hold.visible "$SESSION"

[2] Verify that data about hold requests is returned.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoDocs: small AsciiDoc table syntax fix
Yamil Suarez [Mon, 14 Mar 2016 17:39:14 +0000 (13:39 -0400)]
Docs: small AsciiDoc table syntax fix

Signed-off-by: Yamil Suarez <yamil@yamil.com>
8 years agoLP#1552060: fix persistent login
Galen Charlton [Fri, 4 Mar 2016 19:50:22 +0000 (14:50 -0500)]
LP#1552060: fix persistent login

This patch makes open-ils.auth_internal look for
default_timeout values for persistent authentication
in the intended section of opensrf.xml.

To test:

[1] Attempt to log into the public catalog with the "Stay logged in?"
    option in effect.  The login will either fail or the session
    will not persist when navigating within the "My Account"
    pages.
[2] Apply the patch and restart services.
[3] Attempt step 1 again; this time, authentication should work
    and the session should remain active.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
8 years agoLP#1454884 Hold placed on grouped metabib result displays wrong title
Terran McCanna [Wed, 2 Mar 2016 17:16:43 +0000 (12:16 -0500)]
LP#1454884 Hold placed on grouped metabib result displays wrong title

Prior to this change, a full/extended title displayed even on metarecord
holds that had different extended titles, which sometimes led to situations
where a video's full title displayed on a book hold, or vice versa. This
change displays the short version of the title on metarecord holds and
the full version on individual record holds.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
8 years agoMinor typo in 2.10 release notes
Remington Steed [Fri, 4 Mar 2016 16:48:44 +0000 (11:48 -0500)]
Minor typo in 2.10 release notes

Signed-off-by: Remington Steed <rjs7@calvin.edu>
8 years agoLP 1533331: Stamping upgrade script.
Jason Stephenson [Fri, 4 Mar 2016 16:31:06 +0000 (11:31 -0500)]
LP 1533331: Stamping upgrade script.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
8 years agoLP#1533331 - Fix evergreen.protect_reserved_rows_from_delete() trigger function
Chris Sharp [Mon, 8 Feb 2016 18:00:06 +0000 (13:00 -0500)]
LP#1533331 - Fix evergreen.protect_reserved_rows_from_delete() trigger function

The fix for bug 1513554 included creating a general trigger function to prevent
the deletion of reserved table rows with an ID lower than a specified threshold.
Testing for that seemed to pass muster, but using the function in practice revealed
a failure to delete deletable rows either.

This adds an explicit RETURN to the function, which fixes the issue.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
8 years agoadd release notes entry from LP#1229757
Galen Charlton [Thu, 3 Mar 2016 21:29:11 +0000 (16:29 -0500)]
add release notes entry from LP#1229757

Text courtesy of Kathy Lussier.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agofix a couple typos in the 2.10 release notes
Galen Charlton [Thu, 3 Mar 2016 20:43:52 +0000 (15:43 -0500)]
fix a couple typos in the 2.10 release notes

Spotted by Jake Litrell.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agoclear slate of release notes for new features
Galen Charlton [Thu, 3 Mar 2016 02:55:03 +0000 (21:55 -0500)]
clear slate of release notes for new features

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agorelease notes: add entry for Editable borrowing history
Galen Charlton [Thu, 3 Mar 2016 16:55:05 +0000 (11:55 -0500)]
release notes: add entry for Editable borrowing history

Also fix an unrelated typo.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years ago2.10 release notes password work factor
Bill Erickson [Thu, 3 Mar 2016 16:43:10 +0000 (11:43 -0500)]
2.10 release notes password work factor

Adding documentation on modifying password encryption work factor to
2.10 release notes.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
8 years agofirst draft of release notes for 2.10
Galen Charlton [Thu, 3 Mar 2016 16:09:52 +0000 (11:09 -0500)]
first draft of release notes for 2.10

Signed-off-by: Galen Charlton <gmc@esilibrary.com>