miker [Sun, 9 Mar 2008 01:02:20 +0000 (01:02 +0000)]
add JSON::XS-based true/false support
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1265
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Fri, 7 Mar 2008 22:33:48 +0000 (22:33 +0000)]
made the pid file reading smarter. removed the nasty killalls since they are no longer necessary
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1264
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Fri, 7 Mar 2008 22:32:42 +0000 (22:32 +0000)]
added a basic signal handler for the top-level C process which sends SIGTERM to its children to clean up
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1263
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Thu, 6 Mar 2008 21:32:27 +0000 (21:32 +0000)]
added support for blocking connect and request calls
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1262
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Thu, 6 Mar 2008 21:32:11 +0000 (21:32 +0000)]
added connect-only handling
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1261
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Thu, 6 Mar 2008 20:22:01 +0000 (20:22 +0000)]
added connect/disconnect support, with onconnect callback
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1260
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Thu, 6 Mar 2008 19:32:07 +0000 (19:32 +0000)]
added support for ses.request(method, param1, param2, ...) style requests
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1259
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Thu, 6 Mar 2008 17:28:04 +0000 (17:28 +0000)]
added support for hash-encoded json objects
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1258
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Thu, 6 Mar 2008 17:22:21 +0000 (17:22 +0000)]
Updated OpenSRF Javascript client library. Currently, it only implements XMLHttpRequest as
a transport layer, and, thus far, only implements the multipart/x-mixed-replace (server push)
content type, which means only Mozilla browsers are support.
Non-multipart support will be added to support all other browsers in the future -- not much
code involved there.
Most of the existing OpenSRF JS files will be deprecated after the mozilla-based jabber
handling is imported into this new lib.
Currently, all you need is opensrf.js and opensrf_xhr.js to use the lib in xmlhttprequest mode
More work to do....
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1257
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Thu, 6 Mar 2008 04:10:35 +0000 (04:10 +0000)]
Remove <domains> element - breaks gateway.
Clean up whitespace, add modelines, and fix typo.
Bump version of opensrf.xml to 0.0.3
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1256
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Thu, 6 Mar 2008 03:02:59 +0000 (03:02 +0000)]
Overcome old setuptools' inability to convert FTP listings to URLs with
a direct URI for python-memcached
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1255
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Wed, 5 Mar 2008 23:14:41 +0000 (23:14 +0000)]
updated to match new config layout
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1254
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Wed, 5 Mar 2008 22:36:59 +0000 (22:36 +0000)]
Added support for multi-router registration
replaced unnecessary <domains><domain/></domains> with a single <domain> element in opensrf_core.xml
wrapped the top-level <router> element in a <routers> container element in opensrf_core.xml to
support additional router configuration
Updated the python, C, and Perl to match the above changes
Gave the router the ability to launch more than one router process, based on the config
Added a transport_error flag to C session to indicate a communcation error, which will prevent
client sessions from hanging when making bad requests
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1253
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Wed, 5 Mar 2008 14:30:12 +0000 (14:30 +0000)]
added a ":" to the getopt "c" option so it would take a param
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1252
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Mon, 3 Mar 2008 13:34:25 +0000 (13:34 +0000)]
Bail with a reasonable error message if OPT_CONFIG does not exist
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1251
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Mon, 3 Mar 2008 03:56:53 +0000 (03:56 +0000)]
Make the path to opensrf_core.xml argument optional, with a default
value based on the path used to invoke osrf_ctl.sh
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1250
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Sat, 16 Feb 2008 18:12:57 +0000 (18:12 +0000)]
x.y.z version numbering seems to make setuptools happier... okay
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1249
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Thu, 14 Feb 2008 00:15:39 +0000 (00:15 +0000)]
updated to fit new opensrf updates
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1248
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Mon, 11 Feb 2008 18:49:44 +0000 (18:49 +0000)]
makeing osrfSystemCacheInit() a "public" function. pushing osrfSystemCacheInit() into the child_init phase to prevent shared cache handles.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1247
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Thu, 7 Feb 2008 20:13:44 +0000 (20:13 +0000)]
gracefully handle a null server resposne
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1246
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Thu, 7 Feb 2008 18:58:50 +0000 (18:58 +0000)]
fix paging for large app introspection
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1245
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Thu, 31 Jan 2008 19:46:21 +0000 (19:46 +0000)]
Patch from Scott McKellar (including commentary):
1. I added the const qualifier to the second parameter of xmlSaxAttr().
2. I moved the prototype of _xmlToJSON() from the header to the
implementation file, and made the function static.
At least in its present form, _xmlToJSON should not be part of the
public interface because it is confusing. Sometimes it allocates a
new jsonObject, which needs to be freed, and sometimes it doesn't.
A better design would be for it to expect to receive a non-NULL pointer
to an existing jsonObject. Since it is called in only one place
(other than a couple of recursive calls), this would be an easy
change to make. However I left it alone -- as long as the function
is visible only from within its own source file, the potential for
confusion is limited.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1244
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Thu, 31 Jan 2008 19:39:02 +0000 (19:39 +0000)]
Patch from Scott McKellar:
1. I replaced the deprecated identifier osrf_message with osrfMessage,
except for the typedef defining the former.
2. In the header I commented out the prototypes for
osrf_message_set_request_info() and osrf_message_to_xml(), since these
functions are nowhere defined.
3. I made sure to initialize all members of a newly allocated
osrfMessage.
4. In osrf_message_deserialize(): I changed a series of ifs into a
series of else ifs, in order to avoid needless comparisons after one
comparison finds a match.
5. Also in osrf_message_deserialize(): I introduced a temporary
variable to cache the result of some calls to jsonObjectGetString(),
in order to avoid repeating the identical calls.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1243
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Thu, 31 Jan 2008 19:32:04 +0000 (19:32 +0000)]
Patch from Scott McKellar to plug a memory leak in the mathbench test application
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1242
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Thu, 31 Jan 2008 19:31:07 +0000 (19:31 +0000)]
Patch from Scott McKellar to plug a memory leak in the mathbench test application
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1241
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Thu, 31 Jan 2008 19:29:08 +0000 (19:29 +0000)]
Patch from Scott McKellar to replace some deprecated identifiers
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1240
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Thu, 31 Jan 2008 19:23:27 +0000 (19:23 +0000)]
Patch from Scott McKellar:
1. In osrfSystemBootstrap(): we build an osrfStringArray of children
to spawn, and then spawn them. However we didn't free the
osrfStringArray afterwards. Now we do.
2. In osrfSystemBootstrapClientResc(): we were potentially leaking
the osrfStringArray arr in an early return. I moved the early return
to a point before the allocation of the osrfStringArray and a number
of other things. Not only does the early return not have to free
the osrfStringArray, it also doesn't have to free the other things
any more.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1239
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Thu, 31 Jan 2008 19:19:47 +0000 (19:19 +0000)]
Patch from Scott McKellar:
1. In osrf_json_gateway_method_handler(): we were leaking the
jsonObject arr.
2. Also in osrf_json_gateway_method_handler(): we were leaking session
in the case of an early exit.
3. Replaced identifiers:
osrf_app_client_session_init ==> osrfAppSessionClientInit
osrf_app_session ==> osrfAppSession (struct)
osrf_message ==> osrfMessage
osrf_message_free ==> osrfMessageFree
string_array ==> osrfStringArray
string_array_destroy ==> osrfStringArrayFree
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1238
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Thu, 31 Jan 2008 19:12:40 +0000 (19:12 +0000)]
Patch from Scott McKellar:
1. In send_request() we allocate a jsonObject o and then immediately
assign the resulting pointer to params. I eliminated the rather
pointless o and allocated params directly.
2. We didn't ever free params. Now we do.
3. I replaced two deprecated identifiers with their camel-case
equivalents:
osrf_app_client_session_init ==> osrfAppSessionClientInit
osrf_message_free ==> osrfMessageFree
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1237
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Thu, 31 Jan 2008 19:09:46 +0000 (19:09 +0000)]
Patch from Scott McKellar to fix up some const correctness issues.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1236
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Thu, 31 Jan 2008 19:07:30 +0000 (19:07 +0000)]
Patch from Scott McKellar:
1. I replaced the following identifiers with their camel-case
equivalents:
osrf_message ==> osrfMessage
osrf_message_free ==> osrfMessageFree
string_array ==> osrfStringArray
string_array_get_string ==> osrfStringArrayGetString
2. In osrf_app_server_session_init() we were leaking session in the
case of an early return. I stuck in a free().
3. Likewise in osrfAppSessionMakeLocaleRequest() we were leaking req
in the case of an early return. I plugged that one too.
4. In osrfAppRequestRespondComplete() we were leaking payload in one
branch of an if/else. I moved the osrfMessageFree() beyond both
branches so that it would be unconditional.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1235
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Thu, 31 Jan 2008 19:05:18 +0000 (19:05 +0000)]
Patch from Scott McKellar:
1. I moved the declarations of the following functions out of the
header and into the implementation file, and declared the functions
as static:
_osrfAppBuildMethod
_osrfAppFindApplication
__osrfAppFindMethod (and removed both underscores)
__osrfAppRunSystemMethod (and removed one underscore)
__osrfAppRegisterSysMethods (and removed one underscore)
__osrfAppPostProcess (and removed one underscore)
_osrfAppRespond
osrfAppIntrospect
osrfAppIntrospectAll
osrfAppEcho
osrfAppSetOnExit
2. I plugged a memory leak in osrfAppRunExitCode (we weren't freeing
the osrfHashIterator).
3. I made sure to populate all members of a new osrfMethod.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1234
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Thu, 31 Jan 2008 18:23:52 +0000 (18:23 +0000)]
Patch from Scott McKellar:
1. I renamed __osrfRouter simply to router, and made it static. We
had one global variable and one auto variable pointing to the same
object, causing some needless juggling. Now we have just one
pointer.
2. I removed the leading underscores from __setupRouter().
3. I renamed the parameter to routerSignalHandler() from "signal"
to "signo", since "signal" is a reserved identifier. I also added
some code to re-raise the signal caught.
[from a followup email]
> I chose instead to terminate the program by re-raising the signal.
> That way the parent process has a chance to detect that the program
> was terminated by a signal rather than by a normal return.
After posting this I realized that the router program runs as a
daemon, and its adopted parent process doesn't care whether it
terminates by a signal or by a normal return. So there's not
much point in re-raising the signal.
It remains true that the signal handler should contrive to
terminate the program, either by exiting or by setting a flag that
the rest of the program tests.
[ The original patch, re-raising the signal, is applied. ]
4. In main() I moved two calls to free() so that they are reachable.
5. In main() I return either EXIT_SUCCESS or EXIT_FAILURE, which are
portable. Otherwise we could find ourselves returning -1, which is
not portable.
6. In setupRouter() I arranged to free resource, and to free
tservers and tclients in the case of an early return. I also free
router in the unlikely event that osrfRouterRun returns.
7. I reworded an error message to something that I think is more
clear.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1233
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Thu, 31 Jan 2008 18:18:29 +0000 (18:18 +0000)]
Patch from Scott McKellar:
1. In the header: I added compilation guards.
2. In the header: I changed leading double underscores to leading
single underscores. These identifiers don't appear elsewhere in the
code base, with either double or single underscores.
3. I moved most of the header into the implementation file. The
headers whose prototypes I moved are now static. Where there were
comments associated with the prototypes, I moved them to the function
definitions.
4. I removed an extra leading underscore from __osrfRouterFillFDSet().
5. I replaced some deprecated identifiers with their camel-case
equivalents:
osrf_message_free ==> osrfMessageFree
osrf_message ==> osrfMessage
6. I added the const qualifier to several function parameters.
7. In a couple of spots we were failing to free classname buffers.
I plugged those leaks.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1232
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Thu, 31 Jan 2008 17:33:02 +0000 (17:33 +0000)]
camelCasingPatch from Scott McKellar
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1231
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Wed, 30 Jan 2008 17:36:43 +0000 (17:36 +0000)]
try/except/finally combinations are only supported in Python 2.5. in this case, the finally is not necessary. removed it
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1230
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Wed, 30 Jan 2008 17:30:43 +0000 (17:30 +0000)]
turn \d{1,10} into a number on the wire
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1229
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Wed, 30 Jan 2008 17:06:21 +0000 (17:06 +0000)]
updating legacy JSON parser to store numbers as strings
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1228
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Tue, 29 Jan 2008 17:03:41 +0000 (17:03 +0000)]
appending neglected boolean object to growing JSON object. Thanks, Scott
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1227
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Tue, 29 Jan 2008 03:17:07 +0000 (03:17 +0000)]
python opensrf pre-forking server implementation. this component manages the
"inbound" and drone processes for server applications.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1226
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Tue, 22 Jan 2008 19:09:37 +0000 (19:09 +0000)]
created a shallow clone method
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1225
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 22 Jan 2008 16:35:51 +0000 (16:35 +0000)]
Set the Makefile shell to bash via the Makefile SHELL variable
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1224
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Sun, 20 Jan 2008 00:00:15 +0000 (00:00 +0000)]
added the ability to wait forever by passing <0 to recv. explicitly setting sender address in messages to be correct. added ability to create a message from raw xml
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1223
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Thu, 17 Jan 2008 16:39:23 +0000 (16:39 +0000)]
libxml2 and libxslt1 Python modules are abnormal - remove them from requires list
We'll document how to install these as system packages instead
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1222
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Wed, 16 Jan 2008 17:40:07 +0000 (17:40 +0000)]
Add dnspython, libxml, and libxslt1 dependencies on behalf of pyxmpp
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1221
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Wed, 16 Jan 2008 16:48:24 +0000 (16:48 +0000)]
added the ability to use cjson for json encoding/decoding. gracefully falls back to simplejson
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1220
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Tue, 15 Jan 2008 23:24:31 +0000 (23:24 +0000)]
I started adding some basic bootstrap options looking ahead to server-side python.
This resulted in a small set of code cleanup including:
move from camelCase to lower_under for method names
move from global variables to class-level static variables
move from global functions to class-level static functions
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1219
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 15 Jan 2008 18:02:41 +0000 (18:02 +0000)]
Revert Gentoo changes (sigh)
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1218
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 15 Jan 2008 17:50:06 +0000 (17:50 +0000)]
Make cleaning in Python dir optional as well, to avoid problems with missing setuptools
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1217
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 15 Jan 2008 17:42:45 +0000 (17:42 +0000)]
Add a build flag for Python modules
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1216
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 15 Jan 2008 17:37:11 +0000 (17:37 +0000)]
Bootstrapping doesn't work as desired on systems that already have setuptools
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1215
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 15 Jan 2008 15:51:49 +0000 (15:51 +0000)]
Bootstrap setuptools, drop unnecessary directory metadata
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1214
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Tue, 15 Jan 2008 14:43:40 +0000 (14:43 +0000)]
removing old, unused code
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1213
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 15 Jan 2008 04:03:07 +0000 (04:03 +0000)]
Switch to setuptools to enable dependency installs as well
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1212
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Mon, 7 Jan 2008 14:55:36 +0000 (14:55 +0000)]
repaired expire time logic to force use of the configured max if timeout is indefinite (0) or larger than max
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1211
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Mon, 7 Jan 2008 02:11:47 +0000 (02:11 +0000)]
Patch from Scott McKellar:
1. I moved almost everything from the header file into the
implementation file, since it isn't referenced elsewhere. All that's
left is one function prototype and a series of nested #includes.
2. I added compilation guards to the header.
3. Except for osrf_prefork_run(), all functions are now static, as is
the child_dead variable.
4. I commented out the MAX_BUFSIZE macro, since it isn't used.
5. I removed the declaration of main(), which seemed rather pointless.
6. I added the const qualifier to the parameters of osrf_prefork_run()
and osrf_prefork_routers().
7. I made sure that all members were explicitly initialized when
creating a prefork_simple or a prefork_child.
8. I commented out both the prototype and the definition of
find_prefork_child(), since we don't call it anywhere.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1210
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Mon, 7 Jan 2008 02:08:10 +0000 (02:08 +0000)]
Patch from Scott McKellar:
1. I moved almost everything from the header into the implementation
file, since it isn't referenced elsewhere. All that's left is one
prototype and some nested #includes.
2. I moved the nested #includes inside the compilation guard.
3. Except for osrf_stack_transport_handler(), all functions are now
static.
4. I applied the const qualifier to the second parameter of
osrf_stack_transport_handler().
5. I plugged a memory leak in osrf_stack_transport_handler(). When
unable to open a session, we were returning without freeing the
input message.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1209
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Mon, 7 Jan 2008 02:04:54 +0000 (02:04 +0000)]
JSON to XML patches from Scott McKellar:
Guard against multiple #inclusions.
Plug a potential memory leak in the jsonObjectToXML
function. If the input parameter was NULL we would fail to free
the growing_buffer we had just allocated. I rearranged it to check
for NULL before allocating the growing_buffer.
Also: I added the static qualifier to the _escape_xml function, to
match the declaration at the top of the file.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1208
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Mon, 7 Jan 2008 02:00:25 +0000 (02:00 +0000)]
Memory leak fixes for the old-style gateway:
1. osrf_locale, allocated by either buffer_release() or strdup().
2. A series of buffers allocated by apacheGetFirstParamValue():
param_locale
service
method
format
input_format
a_l
tout
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1207
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Mon, 7 Jan 2008 01:57:18 +0000 (01:57 +0000)]
Memory leak plugged by Scott McKellar:
In handle_request() we allocate a growing_buffer and pass the pointer
to send_request(). However we weren't freeing the growing_buffer
after the return from send_request().
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1206
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Mon, 7 Jan 2008 01:55:25 +0000 (01:55 +0000)]
Two patch sets from Scott McKellar
First:
1. I moved the macros OSRF_LIST_DEFAULT_SIZE and OSRF_LIST_INC_SIZE
from the header into the implementation file. No other source files
reference them, nor should they.
2. I moved the OSRF_LIST_MAX_SIZE macro into the implementation file
as well, and then commented it out. It is nowhere referenced, but
out of caution I preserved it like a fly in amber.
3. I removed a leading underscore from each of the struct names
__osrfListStruct and __osrfListIteratorStruct.
4. I removed some obsolete comment text concerning osrfNewList().
5. I deleted the declaration for __osrfListSetSize(), which is
nowhere defined.
6. I made sure to explicitly initialize all struct members.
7. When allocating pointer arrays, I explicitly initialize all the
pointers to NULL.
8. I rewrote osrfNewList() as a thin wrapper for osrfNewListSize(),
to eliminate some duplication of code.
Second:
These patches eliminate the following identifiers, which have all been
replaced by their camel-case equivalents:
osrf_app_session_make_req
osrf_app_session_destroy
osrf_app_session_request_recv
osrf_app_request
osrf_system_get_transport_client
osrf_system_bootstrap_client_resc
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1205
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Mon, 7 Jan 2008 01:46:42 +0000 (01:46 +0000)]
Patch from Scott McKellar:
1. Move several internal details from the header to the implementation
file:
The macros OSRF_HASH_LIST_SIZE and OSRF_HASH_NODE_FREE
The declaration of the osrfHashNode struct
The declarations of the osrfNewHashNode and osrfHashNodeFree
functions (which are now static)
2. Remove a leading underscore from each of the struct tags
__osrfHashStruct and __osrfHashIteratorStruct;
3. Explicitly initialize all struct members.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1204
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Mon, 7 Jan 2008 00:37:13 +0000 (00:37 +0000)]
Enable Python build with regular user to avoid perm problems at clean time.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1203
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Sun, 6 Jan 2008 21:12:09 +0000 (21:12 +0000)]
using new C-based JSON parser: JSON::XS - this new code wraps the to/from JSON calls with opensrf class management
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1202
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Sun, 6 Jan 2008 20:24:43 +0000 (20:24 +0000)]
providing option to connect to memcache at general connect time
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1201
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Sun, 6 Jan 2008 20:22:57 +0000 (20:22 +0000)]
made exceptions a litte more generic, passing msg to superclass for networexception
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1200
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Sat, 5 Jan 2008 19:07:02 +0000 (19:07 +0000)]
Patch from Scott McKellar:
These patches are the culmination of several postings on this subject.
The overall effect is to store numbers in jsonObjects as strings,
rather than as doubles, in order to avoid needless loss of precision
in translating back and forth between text and floating point
representations.
I shall not repeat the details outlined in previous posts, but rather
focus on what's new:
1. A new extern function jsonNewNumberStringObject constructs a
JSON_NUMBER from a character string. If the string is not numeric
according to JSON rules, the function returns NULL.
2. A new extern function jsonScrubNumber accepts a character string
and reformats it, if possible, into a numeric string that is valid
according to JSON rules. For example, it transforms " +00.42"
into "0.42". The transformed string is returned as a char* that
the caller is responsible for freeing.
jsonScrubNumber performs this transformation by manipulating text,
not by passing the value through a double. Therefore it can handle
numbers that would be too long, too large, or too small for strtod()
and its kindred to handle.
It accepts leading white space and scientific notation, but not
trailing white space, hex, or octal.
If the input string is not numeric, jsonScrubNumber returns NULL.
3. The doubleToString function now translates the incoming double
to a character string with up to 30 decimal digits of precision.
That should be enough to minimize the impact on existing code,
depending of course on how faithfully snprintf() does the formatting.
4. In osrf_json.h: I changed the signature of the next-to-last
function pointer in a jsonParserHandler, so that it accepts a
character pointer instead of a double. Likewise for the corresponding
declaration of _jsonHandleNumber in osrf_json_utils.h.
5. In osrf_json_parser.c: I construct a JSON_NUMBER from the input
character string without passing it through a double. If the input
character string is not valid according to JSON rules, I try to use
the new jsonScrubNumber() to normalize the formatting so that JSON
can accept it.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1199
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Thu, 3 Jan 2008 22:28:52 +0000 (22:28 +0000)]
removed assumption that settings values would be numbers. cleaned up the code some to make it more readable
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1198
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Wed, 2 Jan 2008 18:53:30 +0000 (18:53 +0000)]
changed str to msg to prevent clobbering. changed repr call to unicode, which seems more appropriate for human-readable error message
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1197
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Tue, 1 Jan 2008 02:00:38 +0000 (02:00 +0000)]
Patch from Scott McKellar:
1. Makes sure that all members of OsrfChatServer and OsrfChatNode are
explicitly initialized;
2. Plugs several actual or potential memory leaks.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1196
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Tue, 1 Jan 2008 01:56:28 +0000 (01:56 +0000)]
Patch from Scott McKellar:
1. Plugs a memory leak in file_to_string(). If we failed to open the
file, we were returning without freeing the growing_buffer that held
the file name.
2. Replaces a couple of calls to buffer_data() with calls to
buffer_release().
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1195
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Tue, 1 Jan 2008 01:52:44 +0000 (01:52 +0000)]
Patch from Scott McKellar:
1. Added the const qualifier in various places.
2. Eliminated some unnecessary calls to strlen(), where they were
used merely to determine whether a string was empty.
3. Ensured that all members of a new transport_message are
explicitly populated.
4. Plugged a memory leak in the case where strdup() fails.
5. Eliminated some unhelpful casts of malloc'd pointers.
6. Added some protective tests for NULL pointer parameters.
7. In several spots I replaced numeric literals with character
literals, both to make the code more readable and to avoid a needless
dependence on ASCII.
8. Rewrote the jid_get_resource function to avoid repeatedly
overwriting the same buffer.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1194
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Tue, 1 Jan 2008 01:42:22 +0000 (01:42 +0000)]
Patch from Scott McKellar; use camelCase instead of under_score function names
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1193
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Tue, 1 Jan 2008 01:41:31 +0000 (01:41 +0000)]
Patch from Scott McKellar; use camelCase instead of under_score function names
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1192
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Tue, 1 Jan 2008 01:40:30 +0000 (01:40 +0000)]
Patch from Scott McKellar; use camelCase instead of under_score function names
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1191
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Tue, 1 Jan 2008 01:38:58 +0000 (01:38 +0000)]
Patch from Scott McKellar; use camelCase instead of under_score function names
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1190
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Tue, 1 Jan 2008 01:37:39 +0000 (01:37 +0000)]
Patch from Scott McKellar; use camelCase instead of under_score function names
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1189
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Tue, 1 Jan 2008 01:34:54 +0000 (01:34 +0000)]
Patch from Scott McKellar which adds some const-correctness.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1188
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Thu, 27 Dec 2007 21:40:04 +0000 (21:40 +0000)]
added a static method to see if there is already a globally connected cache client
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1187
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Thu, 27 Dec 2007 21:05:52 +0000 (21:05 +0000)]
repaired stderr call
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1186
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Thu, 27 Dec 2007 19:37:55 +0000 (19:37 +0000)]
forcing int-ness on timeout value
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1185
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Wed, 26 Dec 2007 14:25:29 +0000 (14:25 +0000)]
changed osrf python version from 1.2. to 1.0 to match opensrf
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1184
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Sun, 23 Dec 2007 02:31:38 +0000 (02:31 +0000)]
Use distutils to install Python into the standard location
Correct a syntax error in http_translator.py
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1183
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Fri, 21 Dec 2007 13:34:51 +0000 (13:34 +0000)]
added a flag to encode/decode flattened data as json
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1182
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Thu, 20 Dec 2007 15:53:54 +0000 (15:53 +0000)]
added a multisession class for agregating requets into a single recv manager
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1181
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Thu, 20 Dec 2007 14:13:29 +0000 (14:13 +0000)]
added an xml flattener similar to the java xml flattener
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1180
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Sun, 16 Dec 2007 21:33:10 +0000 (21:33 +0000)]
added internal log level. added some crucial log lines. logging thread id
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1179
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Sun, 16 Dec 2007 21:06:49 +0000 (21:06 +0000)]
Continue the march towards a pedantic 1.0 python API.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1178
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Sun, 16 Dec 2007 20:01:10 +0000 (20:01 +0000)]
added iscomplete method
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1177
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Sun, 16 Dec 2007 20:00:28 +0000 (20:00 +0000)]
parsing logfile settings and initing logger
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1176
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Sun, 16 Dec 2007 19:58:38 +0000 (19:58 +0000)]
Add rudimentary locale support to srfsh.py
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1175
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Sun, 16 Dec 2007 19:55:41 +0000 (19:55 +0000)]
adding a basic mutlisession manager
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1174
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Sun, 16 Dec 2007 19:00:32 +0000 (19:00 +0000)]
Add some basic locale support.
Revert a dailyWTF that caused massive CPU & memory consumption.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1173
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Sun, 16 Dec 2007 16:37:11 +0000 (16:37 +0000)]
Further pedanticize logging method names.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1172
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Sun, 16 Dec 2007 16:20:41 +0000 (16:20 +0000)]
Move towards Pythonic API style conventions (as informed by pylint)
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1171
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Sun, 16 Dec 2007 16:19:27 +0000 (16:19 +0000)]
created a simplified XSL processing class with test
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1170
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Sun, 16 Dec 2007 05:59:19 +0000 (05:59 +0000)]
xml.py conflicts with other xml module namespace (boo). Renaming.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1169
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Sun, 16 Dec 2007 04:42:25 +0000 (04:42 +0000)]
This file will hold only OpenSRF XML functions.
osrfObjectFindPath will be moved to the net_obj module.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1168
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Fri, 14 Dec 2007 19:01:12 +0000 (19:01 +0000)]
adding a generic xml flattening utility with test
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1167
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Wed, 12 Dec 2007 02:35:36 +0000 (02:35 +0000)]
Patch from Scott McKellar to allow E as well as e for scientific notation
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@1166
9efc2488-bf62-4759-914b-
345cdb29e865