LP1904036 Prompt dialog gets input type and min/max

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1904036 Patron UI lint repairs; sanity checks

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1904036 Patron UI; search persistence

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1904036 Patron UI; canceled holds

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1904036 patron Ui holds tabs

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1904036 patron UI noncat/holds summary

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1904036 patron expire check

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1904036 Angular Patron UI initial structures

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1904036 Grid rowSelectionChange Output

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1904036 Patron search form improvements

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1904036 Patron sesarch form improvements

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1724032: add release note entry

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1724032 Permisson Group on Hold Shelf Slip Print Template

This makes the patron permission group available to the hold shelf slip print template.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Susan Morrison <smorrison@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1951996 release notes

Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP#1818303: add release note

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1818303 Add Approval Code to Bill History Grid

Adds the credit card payment approval code to the payments grid
under bill history in the patron record.

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1951996 Preferred names in group member details

Adds columns for preferred family, middle, and first names to group member
details.  These added columns are hidden by default.

To test:
1. In a patron's record add a preferred first, middle, and last name.
2. Go to Other - Group member details and notice that there are no columns
   for preferred.
3. Apply patch.
4. Go to group member details and use the drop-down to display the preferred
   columns.
5. Add some more patrons to the group for good measure.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1864507: (follow-up) fix seed data and schema update

Syntax error terminated the DB update and would have left
certain field without the new normalizer.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1952931 release notes

Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1952931 stamp upgrade script

Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1952931 Support ACQ Advanced Shipment Notices (DESADV -- Dispatch Advice Messages)

* Parsing DESADV EDI Messages
* ASN shipment notification SQL
* ASN shipment notifiation Perl
* ASN shipment notifiation Perl Test
* ASN receiving UI
* ASN shipment notifiation IDL
* ASN Perl Test
* Handle barcode not found
* Add process date and processed by fields
* Stamping process date and processed
* Copy upgrade SQL to base schema
* LI# link goes to LI items; show title in summary
* LI# link goes to LI items fix
* ASN EDI can contain multiple containers
* Blocking receiving before container fully loads
* More data loading indictor support
* ASN disable Dry-Run by default
* Receive Shipment AngJS menu entry
* Disable try run by default; focus input on load
* ASN dry run fixes / Notifed Count repair
* ASN support Ingram message format (PCI field)

Includes change to allow skipping line items that have no container
code, which happens with Ingram messages sometimes.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1964629 release note

LP#1964629 - Item Status - add column for Total Circs

Adds Total Circulations to the column picker.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1864507 follow-up, stamp upgrade script, and release notes

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1864507: Improve browse by removing more ISBD

The fix for bug 1308090 introduced an improvement targetted at Facets
that removed some extraneous punctuation from author-ish fields.  Here
we expand that to cover more field types (primarily title), and protect
some author data from unhelpful changes.  The need for this is primarily
driven by the browse interface for patrons.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1396764 - Stamping upgrade script

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1396764 - Add Release Notes

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1396764 - Apply Hours of Operation Note Field to tpac

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

lp1396764 - Hourse of Operation Note Field

- Add a note field to each day of the week for the Hours of Operation object
- Display any existing notes note in the OPAC after their specified day

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

Add release notes for OS versions

Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1990969: Remove Ubuntu Bionic Beaver Installation Prerequisites

Since Ubuntu Bionic Beaver (18.04) is soon EOL, remove it as a viable
installation target.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1947728: Remove Debian Stretch Prerequisites

Since Debian Stretch is soon EOL, remove it as a viable installation
target.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1948946 release notes

Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1948946 Block transfers on inactive funds

If a fund is inactive, the Create Allocation and Transfer Money buttons will be disabled.

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

lp1895706 release notes

Signed-off-by: Jane Sandberg <js7389@princeton.edu>

lp1895706 - Unarchive Course Button handles correctly

- Ensure changes made in 1939994 are reflected properly
- Hide Archive Course button if Course is archived
- Hide Unarchive Course button if Course is active

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

lp1895706 Unarchive Old Courses

- Add option to unarchive old courses
- Remove non-public Course Users when unarchiving course

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-list.component.html
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-list.component.ts
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-page.component.html
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-page.component.ts

Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1953692: release notes

LP1953692 follow-up: missing character

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1953692 Angular Catalog Record Summary links should open in new tab

Changes the link behavior in the Angular Catalog Record summary.

The following links now open in new tabs:

Title
Created By
Last Edited By
Jacket image
Course

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1411819 stamp upgrade script and add release notes

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1411819 follow-up: add a pgtap test

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1411819: org setting to override PATRON_EXCEEDS_FINES penalty on renewals

Original commit ca3a554b71c0bbcd013baab0e4246ddae212d6fb

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1931737: Stamping upgrade scripts

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1931737: Allow the delay of symspell updates

This commit adds a new internal flag, auto-created at the time of need,
to control whether record ingest will cause immediate updates to the
symspell dictionary, or if those updates will simply be recorded for
later incorporation.  Inline symspell dictionary updates can cause
record updates to be logically serialized, impacting the preformance of
other tools used for batch reingest.

pingest.pl is changed to allow an administrator to make use of this
feature via the --delay-symspell command line flag.

NOTE: includes a minor fixup from blake@mobiusconsortium.org for a
syntax error.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: blake <blake@mobiusconsortium.org>

LP#1931737: DYM can cause deadlocks w/ parallel ingest

This patch causes all symspell dictionary updates to occur at then end
of metabib search field updates in one go, which allows Postgres' INSERT
... ON CONFLICT mechanism to properly lock and serialize changes when
necessary.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: blake <blake@mobiusconsortium.org>

LP1993922 - Fix terminology Archival->Archiving

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1993922: Course material delete should not delete other courses' materials

To test:
* Apply this patch
* Login to BR1 workstation
* Go to Admin - Local Admin - Course Reserves List
* Create two courses, Course 1 and Course 2
* Associate materials to both courses
* Archive Course 1
* Go to Course materials on Course 2 and note that
it still has all of its materials attached.

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP 1993534: Followup to replace deprecated command

Running ng xi18n manually complained that it's deprecated and extract-i18n
is the new hotness.

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1993534: Command line flag usage for ng xi18n

To test:

1) cd [Evergreen repo]/Open-ILS/src/eg2
2) npm install
3) npm run export-strings # should fail
4) Apply this patch
5) npm run export-strings # should successfully create a file in the locales directory

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP1981746 follow-up: docs and makefile updates

The jammy target was merged after this PR was posted, so this commit adds the new dependency.
Also adds release notes and a small update to the docs

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1981746: add Geo::Coder::Bing to geosort application module

Signed-off-by: Llewellyn Marshall <llewellyn.marshall@ncdcr.gov>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1913604 - Stamping upgrade script

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1913604: Course materials module should remember original circ_lib

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1913604: course materials module shouldn't move items to different owning libs

To test:
1) Create a course that can have volumes (e.g. a branch or bookmobile, not a consortium)
2) Associate an item with that course that is from a different branch
3) Note that the item's owning and circ libraries have not changed.

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1913604: Alert staff when associating item with course at a different library

1) Create a new course at a branch that can have items (BR3, for
   example).
2) Add an item with the circ_lib of BR3. Note that the item is
   added to the grid.
3) Add an item with a different circ_lib. Note that you get an
   alert showing that the item is not at the course's owning library.
4) Push the Cancel button.  Notice that the item is not added to the
   course.
5) Repeat step 3 and push the Confirm button.  Notice that the item is
   added to the course this time.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1940105: Perl detach material correctly resets item location

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

lp1940105 Archive Course Should Use detach_material

- Replaced resetItemFields with detachMaterials in Course Service
- Refactored disassociateMaterials to utilize detach_materials
- Refacotred deleteSelectedMaterials to utilize Course Service detachMaterials function

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1898775: Add basket to bucket in bootstrap

The bootstrap OPAC uses links, rather than <select> for the basket dropdown, so the
existing event listener couldn't get attached to the correct element.

To test:
1. Confirm that you are using the bootstrap OPAC.
2. In the staff client, select the traditional staff catalog.
3. Add several items to your basket.
4. Click the basket icon, and select 'Add Basket to Bucket'
5. Note that you get a 404 error.
6. Apply this patch.
7. Repeat steps 1-3.
8. Note that you can now select a bucket, and that the process completes successfully.

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1980297 Booking:reservations page not formatted in bootstrap opac

Formats the page's title and table in a consistent manner with other
pages in the bootstrap opac's myopac pages.  Also adds CSS so that
the correct labels are displayed on smallish screens.

To test.

1. Set ctx.show_reservations_tab in config.tt2 to true.
2. Create a couple of bookings for a patron and login to the opac as that
patron.
3. In the opac go to the reservations screen and notice the formatting.
Resize the screen to view the display on a small scale.
4. Apply the patch
5. Repeat 3 and now notice the page title and the table formatting. View
the table in a small screen.
6. Also view the reservations page as a patron with no bookings.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1501870: stamping upgrade script

Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP#1501870 - Remove invalid Z39.50 search attribute from LOC

Removes the 1001 Item Type attribute from seed date for LOC.

Also includes an upgrade script to remove the 1001 attribute from
config.z3950_attr.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1956619 Holdings editor sanity check for VIEW_USER perm

When the staff accessing holdings in the holdings editor do not have the
VIEW_USER permission at a level sufficient to display the creator/editor
of a set of items, display the ID of the user instead of attempting and
failing to display the username, which causes a page rendering error.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP#1956619: use Angular holdings editor when accessing from item status and item buckets

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1891375 Perm Group Editor Indicates Overridden Perms

When a permission for the selected group overrides the same permission
applied to a parent group, indicate it in the permission list with an
icon.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1735221 Item Alert Prevents Hold Capture Delay Verification

Clicking OK on an item alert triggers a checkin override. If the
response contains an override event, an error is thrown. Since
a hold capture delay event is handled as an override, an error
throws before the hold capture delay dialog opens.

This handles the capture delay event separately from the override
events so the dialog will open after an override attempt.

To test:
1. set Hold Capture Requires Verification on a shelving location
2. add an item alert to an item in that shelving location
3. place an item hold on that item
4. checkin that item
5. click OK on the alert dialog and Capture on the delay dialog
6. note the hold is captured`

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1907495 release notes

LP1907495 Adds PO ID as a column in Acq LI search

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

lp1930896 - Course Reserves Carriage Return Shouldn't Add

- Removed Enter KeyUp property from the Patron Barcode field on Associate User
- Removed Enter KeyUp property from the Item Barcode field on Associate Item

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1821950, LP198049 - Stamping upgrade script

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1980409 require barcode in order to save

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Christine Morgan <cmorgan@noblenet.org>
Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1821950 & LP1980409 Option to require call number label

This uses a new Library Setting for "Require call number labels
in Copy Editor" for the benefit of libraries that with to use a
predefined Prefix (such as FIC or EZ) instead of individual call
number labels for each volume.

When the setting is True, the call number label field is marked
required and the Save buttons disabled until a value is present.

When the setting is False, the call number label is not required.
In addition, the Angular interface adds an additional check for
Prefix, so if the call number label is empty then the Prefix is
required.

Acknowledgements:
Org Unit Setting created by Kyle Huckins
Angular and AngularJS changes done by New Developers Working Group

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

lp1821950 Require Call Number Label YAOUS

- Add YAOUS to Require Call Number Labels in Copy Editor
- Set new YAOUS to true
- Don't display empty call number field warning if call numbers
aren't required on the copy editor.
- Properly enable/disable saving an item in the volcopy editor when
CN label is empty, based on Require Call Number Label setting.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/sql/Pg/950.data.seed-values.sql
new file:   Open-ILS/src/sql/Pg/upgrade/XXXX.lp1821950-call-number-label-required-yaous.sql
modified:   Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1839341: stamp upgrade script

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1839341 follow-up: no console error when reverting to unset value

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1839341: Fix boolean save (and other issues)

This commit makes sure that YAOUSen of type 'bool' are saved as JSON
booleans rather than one of the strings "true" or "false".  A database
cleanup script may be useful to make sure that erroneously set values
from earlier iterations of this interface don't stick around and cause
problems.  A simple version of this would be:

UPDATE  actor.org_unit_setting
  SET   value = BTRIM(value,'"')
  WHERE value IS NOT NULL
        AND name IN (
                SELECT  name
                  FROM  config.org_unit_setting_type
                  WHERE datatype ='bool'
        );

Also addressed in this commit are linked field label display (see the
Acquisitions "Default copy location" setting) and a minor low-level call
that requests too-deep object fleshing.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1839341: Allow staff to fetch view_perm on settings

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

Hide the selection grid elements when selection is not allowed

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1839341: Really stop duplicates, and provide an initial sort order

Duplicates snuck back in due to something firing the getRows function
multiple times, concurrently.  We avoid this problem by returning an
empty observable if we're already mid-fetch.

This commit also sorts the settings by group and label at load time.
Finally, we bring back the "change not visible" warning when editing
for a location other than the context org as a toast.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1839341 YAOUS editor batch operation improvements

* Apply batch updates serially to avoid large parallel batches.
* Replace manual JSON string compilation with JSON.stringify()
* Show progress dialog during batch updates / hide toasts since they
  occur too fast to read.
* Batch update avoids applying the value "0" for numerics when the value
  is null or undefined.
* Minor linting

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1839341: Address sort, revert, and layout

Based on testing feedback, this commit:
 * improves the layout and styling of the Edit dialog buttons
 * adds the Description as a (hidden) column
 * enables sort/multisort on the main grid
 * corrects the logic of the Revert function
 * corrects the logic used when saving booleans

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1839341: Improve grid layouts

Correctly hide the ID column on the history grid, and disable tooltips
on action columns in both grids.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1839341: Fix row duplication and linked field lookup

The grid needed to be refreshed after a filter change to address
duplicated rows noticed in testing.  In addition, for settings with
typed linked objects, we need to look up the labeling column via the
selector attribute, or use the pkey, rather than assuming a "name"
column will exist.

There is an additional issue with setting typed linked objects in the
Edit dialog, but this is addressed in an enhancement to the core widgets
provided as part of the Simple Reporter work in LP#1945836.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

Seed Values Missing Parens and Consistency

- Fix missing Parens in Seed Values
- Ensure added Seed Value is consistent with upgrade script

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

Update Workstation Setting to proper name

- Change update sql file to add admin.actor.org_unit_settings

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

Switching Org Units properly removes wrong-OU data

- When switching context locations, the grid reloads the data fully, ensuring no data from previously selected Org Unit displays where it shouldn't.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

Angular Library Settings Editor Touch-up

- Remove case-sensitivity from Filter
- Ensure filter returns you to the beginning of the grid results when
  applying or clearing the filter.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1839341: Small tweaks to org unit settings UI

* Changes Edit link into a button so that the modal opens
* Adds [flex] widths to grid columns
* Removes some unnecessary @Import statements
* Fixes lint errors

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1839341: Updating Angular Org Unit Settings for Ang10

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1838341: Double-Click Setting to open Edit Dialog

- Add an OnRowActivate to allow the Edit Dialog to open
when double-clicking a row on the Org Unit Settings Grid.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/org-unit-settings.component.ts

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

lp1839341 Minor Tweaks

- Add aria-label to Filter Input
- Add Name column to settings grid
- Correctly Parse HTML links in setting descriptions
- Correctly clear Value column when deleting settings

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/amin/local/org-unit-settings/org-unit-settings.component.html
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/edit-org-unit-setting-dialog.component.html
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/org-unit-settings.component.ts

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

lp1839341 - Item Location Integration

- Integrate Item Location Selector for acpl-linked org
unit setting value editing in the Org Unit Setting Editor.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/edit-org-unit-setting-dialog.component.html
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/edit-org-unit-setting-dialog.component.ts
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/org-unit-settings.module.ts

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

lp1839341 Port Org Setting Editor UI

- Speedy Retrieval for display all Org Unit Settings (~6 seconds
instead of DOJO's 20)
- Implement org_unit.settings.history.retrieve API Call utilizing
CSTORE operations
- View and revert OU settings to specific changes
- Update Org Unit Setting context orgs and values
- Filtering of Org Unit Settings by string found in name, description,
label, and/or group fields of Org Unit settings
- Get history in properly descending order based on date_applied
field
- Strip surrounding quotes from new values in history log
- Add columns for Edit and History actions.
- Add sql changes to support workstation setting for org unit settings grid
- Port Import/Export Dialog for batch-modifying settings using a JSON string.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/admin-local-splash.component.html
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/edit-org-unit-setting-dialog.component.html
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/edit-org-unit-setting-dialog.component.ts
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/org-unit-setting-history-dialog.component.html
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/org-unit-setting-history-dialog.component.ts
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/org-unit-setting-json-dialog.component.html
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/org-unit-setting-json-dialog.component.ts
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/org-unit-settings-routing.module.ts
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/org-unit-settings.component.html
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/org-unit-settings.component.ts
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/org-unit-settings/org-unit-settings.module.ts
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/routing.module.ts
modified:   Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm
modified:   Open-ILS/src/perlmods/lib/OpenILS/Application/AppUtils.pm
modified:   Open-ILS/src/sql/Pg/950.data.seed-values.sql
new file:   Open-ILS/src/sql/Pg/upgrade/XXXX.data.ouSettings-grid-ws-settings.sql

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1991344 rxjs empty() function deprecated

Futureproofing for rxjs 8 and the deprecation of the empty() function.
All the references to empty() have been replaced with the EMPTY constant.
Places where empty() was imported without being used have been removed.

Signed-off-by: Shula Link <slink@gchrl.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

lp1992657 - fix broken NPM test

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1838553 User Display Name

Add preferred names to 'User Alias or Display Name'

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1838553 User Display Name

This modifies the User Display Name to incorporate the Preferred
Name if present.

(Note: Ryan Eby did this work, I just put it into a git branch. I
have not tested it. - TMcCanna)

Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1981628 Third follow-up

The last follow-up had the inadvertent side-effect of hiding the
message directing the patron to contact their library if they had a
negative balance. My thought is that if there are negative bills then
the patron should see the alert to contact their library about them
regardless of whether or not online payments are allowed. So, this
additional followup separates that alert from the myopac_cc_allowed logic.

This also makes some minor display tweaks to the BooPAC:
- Applies the Bootstrap 'alert-warning' to the negative bills message
in the BooPAC.
- Adds a page header.
- Changes the styling and wording of the grocery charges heading to match
the circulation charges heading.
- Changes the styling of the grocery and circulation tables to be
consistent with each other.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1981628 follow-up to the follow-up

Consolidate some of the logic to make it more clear what is happening,
leverage the existing myopac_cc_allowed boolean, and catch the
Pay All Charges button in the TPAC.  This also clears up some display
oddities and makes sure the non-payment labeling is being used.

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1981628 Follow up to Stripe payment intents bug

The bug fix for 1965579 only resolved the negative bills problem
for grocery bills. This follow up resolves the problem for
circulation bills as well.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>