Docs: Fixed antora landing page

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

Added Holdings Details Defaults to Holdings Editor section.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

DOCS: Update auth proxy xml in docs to match example

Also, move file to better admin_local_setup folder and update nav

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: small asciidoc syntax fix

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: Update Navigation for Negative Balances

Adding Navigations

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: Adding Negative Balances

Adding documentations for Patron with Negative Balances Screen.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: fix antora build asciidoc warnings

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: Adding more info about credit card payments

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1856868: Remove deprecated open-ils.circ.renew.auto API

The deprecated open-ils.circ.renew.auto API was removed.  You will
want to use open-ils.circ.renew with the auto_renewal option set
to 1.  This mainly affects those who have written custom code using
the open-ils.circ backend.

This removal was broadcast in the release notes for Launchpad bug
1835085: https://bugs.launchpad.net/bugs/1835085.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1913338: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1913338: (follow-up) aria-hide the icon names

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1913338: Typo correction

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1913338 Catalog search form visibility stickiness

On pages in the Angular staff catalog where the search form is collapsed
by default, users may now also manually expand and re-collapse the form.
The last used choice will be sticky via new workstation setting.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1898114: (follow-up) adjust the style of the org selector

This patch makes the new hold pull list org selector match
the selector on the holds shelf page.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1898114: Add org selector to holds pull list

To test:
1) Go to the Holds Pull List
2) Try looking at the hold lists for all libraries where
you have the VIEW_HOLD permission.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Jennifer Bruch <jbruch@sparkpa.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

lp1902302 Opac. SMS and Carriers appear in Edit Holds Regardless of OU Setting.

The SMS Number field and Default Carrier field display when editing an
individual hold in the opac, regardless of the 'Enable features that send SMS text messages' setting.
This patch rectifies that behavior.

To test.
Set the 'Enable features that send SMS text messages' to False.
Place a hold for a patron.
Login to the opac as that patron and view the holds.
Edit the hold, and notice that the SMS and Carrier fields are displayed.

Apply the patch.
Refresh the edit form.  The fields no longer display.

Set the 'Enable features that send SMS text messages' to True.
Refresh the edit form.  The fields now display.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1901710: Properly nest HTML tags and TT2 directives

This is a first pass at cleaning these up and the W3C's
HTML validator is a lot happier about some of the pages,
but the advanced search page at least needs some TLC.

I'm having trouble getting the shelving location selector
to appear at all and the aria complaints will require more
fixing.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1916936-Bootstrap opac: item tags display as separate copies on small screen.

This fixes the display of item tags and item notes in the bootstrap opac.
It also cleans up some <a> tags that had class defined twice.

To test.
1. Add an item tag and an item note to an item.
2. In the bootstrap opac make the screen as small as possible.
   Notice that the display shows the tags and items as copies.
3. Apply the patch and repeat.  The tags and notes should be displayed with the item that they are associated with.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1910288 Bootstrap opac: E-items lines always display in account summary.

The E-item summary of ckos and holds always display in the My Account Summary of the Bootstrap Opac
regardless of the ebook_api.enabled flag in config.tt2.  This fixes that issue.

It also sets both the ebook_api.enabled and ebok_api.ebook_test.enabled flags to default to false.

To test:
1. Set ebook_api.enabled in config.tt2 to false.
2. Look at a patron's account summary and notice that it displays the e-item lines.
3. Apply the patch.
4. The E-item lines are now suppressed.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1920042 Bootstrap Opac: Simple Selector in Advanced Search

Fixes the simple selector in advanced search.

To Test:
1. Go to Administration - Server Administration - MARC Coded Value Maps
2. Assign the 'Is Simple Selector' option to some record attributes.
  In concerto:
     Lang - French, German
     Type - Musical Sound Recording
  Are good choices to test searching.
3. Notice in advanced search that these options no longer appear in the
   Language or Item Type search filters.
4. Apply the patch.
5. The simple selector options should now appear at the top of each search
   filter category.
6. Perform some searches using the simple selector options.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1923225: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1923225: clean up some double-escaping of HTML in record display

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1923225: have search highlighting stored procedure do HTML-escaping

This patch builds on the previous work to have the stored procedures
that produced highlighted and unhighlighted versions of display
attributes HTML-escape the source values, then adjusts the TPAC
and Bootstrap templates to avoid double-escaping.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1923225: fix handling of untruncated display fields in accordion

A previous commit used the TT2 "html" filter to escape strings to which the
accordion macro is applied, but which don't get truncated.  But that's
incompatible with display fields, which contain embedded HTML and
therefore shouldn't be escaped in that way.  This commit uses
HTML::Defang on untruncated accordion input instead (which is consistent
with how truncated strings are handled by the same macro).

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1923225: avoid over-escaping ISBNs and ISSNs

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1928684 Catalog view holds tab sort by patron barcode error

This changes the Patron Barcode column name to ucard_barcode to
match the field name in the database.

Note: due to the name change, users who saved the column on the
grid will have to add it again.

To test:
1. Go to the View Holds tab on a record that has hold requests
2. Add the Patron Barcode column to the grid
3. Sort by the barcode column and note that it works
4. It's a good idea to test that the grid settings save properly

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

DOCS LP 1857917 Update glossary.adoc to include IDL

LP bug https://bugs.launchpad.net/evergreen/+bug/1857917
Add IDL definition to glossary, with synonym link to Fieldmapper IDL & change anchor point for F heading

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1912097 Add timestamps

Adds timestamps to the date columns in Acquisitions Search.

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

update to Antora styleguide

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1918362 Unchanged workstation settings applied on every checkin

* Stop attempting to save the Update Inventory setting on every
checkin - incorrect prefix & redundant (it's a modifier now)
* Stop saving the Strict Barcode setting on every checkin,
renewal, and checkout
* Save Strict Barcode on user interaction with its checkbox

To test:
1. confirm Strict Barcode and Do Inventory Update settings still
apply and are "sticky" on the Circulation->Checkin interface
2. confirm Strict Barcode still applies and is "sticky" on the
Circulation->Renew Items and Circulation->Checkout interfaces

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1911238 Angular grid shift-click support

Clicking on a row, then shift+clicking on another row now selects both
the second row and all rows between the first and second in Angular
grids.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1924185: use preferred name before legal name in My Account

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1924185: use preferred name in patron summary

When available, the preferred name is used as the main name in the
patron summary (rather than as a less-prominent field beneath the main
name).  The legal name is displayed further down in the summary, just
after the ID fields.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1881607 stamp upgrade script

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1881607 E-resource relationship labels

Display the relationship designation for 856 URL's in the staff catalog.

See Second Indicator:

https://www.loc.gov/marc/bibliographic/bd856.html

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1881607 Angular catalog located URIs

Display in-range located URIs in the staff catalog record summary pane.

Also applies a fix to the staff catalog to clear cached record detail
summaries on new searches to ensure the correct org-scoped version of
the record summary is retrieved on each new navigation to the detail
page.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1881607 Angular catalog e-resource links display

Display electronic resource links (MARC 856's) in the Angular staff
catalog.  The extraction logic, which matches the TPAC, has been put
into its own API.

To test in concerto, navigate to:

/eg2/staff/catalog/record/208

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1906825 Flesh acqcr on PO search

Fleshes the cancel reason column on PO searches.

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Chrisy Schroth <chrisy.schroth@kentonlibrary.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1873539 Active column in SMS carrier configuration

This fixes the lack of values displaying in the Active column of the
SMS Carrier configuration screen.  (Administration->Server Administration->SMS Carriers)

To test apply the patch.
Go to the Carrier Configuration screen and note that the 'Yes' and 'No'
boolean values now display for the Active column.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

lp1615800 Accessibility on Patron Pages

Modify patron search, patron search results, and patron edit pages so
that they are compatible with screen readers. aria-labelledby can be
used to associate input fields with their labels.

(Rebased to master)

Signed-off-by: Mike Risher <mrisher@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/circ/patron/t_edit.tt2
modified:   Open-ILS/src/templates/staff/share/t_patron_search_form.tt2

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1891699 Ang grid column picker sorting

Angular grid column picker displays colums in the following order:

1. Visible colums first, sorted alphabetically.
2. Non-visible columns second, sorted alphabetically.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1895660: Booking.pm, Search/Biblio.pm

Argument "whatev_strings" isn't numeric in numeric eq (==) at ...

A couple places that use == to compare strings. Numbers are == to
each other, but strings are eq to each other.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1895660: Proxy.pm Proxy/Authen.pm

Checking perms LOUD_NOISES for user 123 at location 321

So? I have changed these to use $logger->debug though they can
maybe just be removed entirely?

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1895660: Search/Authority.pm

Argument "" isn't numeric in numeric ne (!=)

One of the "fun" things about perl and its type system is that
it uses different operators to compare strings vs comparing numbers...

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1895660: AppUtil.pm

substr outside of string

unique_unnested_numbers expects a list of pg arrays, but if its given
an empty results list it tries to remove { and } from an undefined value.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1895660: HoldTarger.pm

"order_by" object in a query is not a JSON_HASH or JSON_ARRAY;no ORDER BY generated

json_query and CStoreEditor search_* functions don't want a string field name,
they work with hashes or arrays thereof.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1895660: EGCatLoader/Search.pm

CGI::param called in list context from ...
this can lead to vulnerabilities

For any call to $cgi->param that happens in a list context we need
to verify 2 things: 1, that it is intentional (otherwise use scalar())
and 2, that we don't use the results in an unsafe manner.
For those situations where it's safe and a list is expected (join,
foreach, etc.) there is a $cgi->multi_param() that behaves the same way
but does not issue a warning on use in a list context.

An assumption was made that there will only be a single 'query'
parameter (see _prepare_biblio_search_basics) but if that should
instead be run through a join() that function will need to be updated.

For more details about the potential issues read
https://metacpan.org/pod/distribution/CGI/lib/CGI.pod#Fetching-the-value-or-values-of-a-single-named-parameter

Note that this change will likely require additional testing to
be sure there are no surprises.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1895660: Course.pm

"my" variable $results masks earlier declaration in same scope

my $var should only be used once within a block.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1895660: Biblio.pm

Odd number of elements in anonymous hash

The type key is missing from some param descriptions,
leaving things uneven.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1895660: SuperCat.pm

"my" variable $U masks earlier declaration in same scope

AppUtils is 'use'-ed and assigned to $U at the top of the file
and shared among the rest of the modules already.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1895660: Silence Perl Warnings

There are many perl warnings in make check and the day-to-day
logs when using Evergreen. This branch aims to address the
warnings and to make reviewing easier each file will be
individually committed with a small rationale for the changes
though it is assumed that this branch will be largely squashed
away if / when committed.

Booking.pm: Possible precedence issue with control flow operator
The precedence of 'or' is significantly lower than '||', so much so
that it can be less than the precedence for assignments.
Replace 'or' with '||' since they're equivalent in this case anyway,
and also add parens for flavor.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1917944k: (follow-up) fix ng lint issue

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1917944-Hold Pickup Library sometimes Empty

Checks to make sure that the opac.default_pickup_location in usr_setting
has a value.

To test.
1. The patron must have a opac.default_pickup_location set to ""
2. Place a hold for this patron.
3. Notice that the pickup location is blank.
4. Apply the patch.
5. The hold pickup location should now be filled with the patron's home library.

To re-create this in concerto you may have to tweak the usr_setting table.
1. Assign a default pickup location to a patron.
2. Find the id field for the above in the usr_setting table.
   select * from actor.usr_setting;
3. Update the setting.
   update actor.usr_setting set value = '""' where id = <the id number>;

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1925725 Relabel copy location filter to shelving location

Changes the labeling of the all copy locations filter to say "All Shelving Locations" instead, reflecting current practice.

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1926310 Record bucket batch edit destination

Record Bucket => Batch Edit now opens the new Angular MARC Batch Edit
interface.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1927527: (follow-up) add comment

Just in case there's a question in the future, make it clear
that the case where the context OU is the root OU is special.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1927527 Catalog: Root OU shelving locations do not display

When the top level org unit is selected in the staff catalog you
only have the option to search all shelving locations.

This allows you to filter on the root org unit's shelving
locations, which is the same behavior as the OPAC.

To test:
1. Make sure the top level org unit has shelving locations
   (Local Administration->Shelving Locations Editor)
2. In the staff catalog, select the top level org unit
3. Click the three dot icon next to the query text input
4. The root org unit's shelving location options display

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Docs: fixing a typo

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Introduce documentation on how to contribute docs

This commit adds several screenshots and the basic outline on contributing
to the Evergreen documentation

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1908440: Stamp Upgrade Script

Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>

lp1908440 editing the photo url in the staff client

Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Seth Erickson <serickson@tds.lib.mn.us>
Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>

LP#1892435 - Add Release Note

Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>

LP#1892435 Splash page catalog searches don't work with spaces

On older versions of Apache's mod_rewrite, splash page catalog
searches are escaped in JavaScript and escaped again during the
redirect to the Angular locale path, so searches with special
characters result in a search that's still encoded.

Test on Ubuntu 16.04.7, Apache 2.4.18, EG 3.6+. A splash page
catalog search for Harry Potter results in a search for
Harry%20Potter.

Add the NE (noescape) flag to the Angular locale path redirect
in /etc/apache2/eg_vhost.conf as indicated in this example file.
A splash page search for Harry Potter then works as expected.

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>

docs: Antora search index limit to master plus new switch

This provides a new option for generate_docs.p:

--antora-ui-repo-branch

where the user can optionally specify a branch on our UI repo for testing

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

update release notes for 3.7.0

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

update version upgrade script for 3.7.0

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

update release notes for 3.7-rc

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

update version-upgrade script for 3.7-rc

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

docs: update target branches for Antora

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

docs: fix a few asciidoc syntax errors

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Sort by Geographic Proximity

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Single Sign On

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Did You Mean SWSC

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Hold Groups

Signed-off-by: Felicia Beaudry <felicia.beaudry@equinoxinitiative.org>
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Report Sources

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Library Groups

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1905091: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1905091 Supply environment for added print/email triggers

Ensures that OPAC print and email triggers added by upgrade script 1231
(lp 1749475) have appropriate environment.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1879769 Cannot Edit Carousels from Action Menu

The Edit Carousels action was appearing in the action menu and
right-click menu, but wasn't wired up. This adds in the missing
piece.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1917495 Angular Catalog: Hold status in View Holds is not saved

To test:
1. Go to a record in the Angular catalog
2. Click the View Holds tab
3. If status col is visible, remove status col, and save grid
4. Add status col and save grid.
5. Refresh page and note status field didn't stay visible
6. Apply patch, repeat steps 1-5, note Status stays visible

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1920815 Item edit link displayed for all users

The Angular catalog item table doesn't check UPDATE_COPY perm
before displaying an edit link. The back-end checks, so this is
a display issue only. This commit grabs a list of org Ids where
the user has UPDATE_COPY perm and checks the copy circ lib or
cn owning lib is in the list before displaying the edit link.

To test:
1. Search for a record with items you don't have perm to edit
2. Note the edit link shows on every item
3. Apply patch
4. Repeat steps 1-2
5. Note edit link displays if you have perm to edit

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: added script info to Carousels docs

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

Docs: correction to 3.7 release notes

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

Docs: a few typos in 3.7 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Translation updates - po files (3.7 beta)

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

docs: add upgrade instructions to release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

docs: more tweaks to 3.7 release notes

- add an acknowledgment
- fix heading levels in the upgrade section

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

docs: additional edits to the 3.7 release notes

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: 3.6.3 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: 3.5.4 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

update Czech translations for Angular staff client

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Translation updates - newpot

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1902965: removing nesting of accordion() calls

This was resulting in double-encoding of content notes, making the public
catalog display things like

<div class="content_field">...</div>

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1902965: HTML filter on OPAC search results and record display, with accordion

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Conflicts:
Open-ILS/src/templates/opac/parts/record/contents.tt2
Open-ILS/src/templates/opac/parts/record/summary.tt2
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1902965: Fix search in Bootstrap OPAC

Filters and localization functions don't mix. Assign the html filtered
title to a temp var first.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1902965: change format type in XML transform to avoid XSS in SuperCat

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1902965: HTML filter on Bootstrap OPAC search results and record display

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

3.6.2 to 3.7-beta DB update script

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1896840: (follow-up) update script to include the DB rev

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

docs: add new perms/settings/etc. to 3.7 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>