not using coverage test plugin at the moment

Signed-off-by: Bill Erickson <berick@esilibrary.com>

unit tests for egCore, egEvent, and egStrings

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Merge branch 'master' of git.evergreen-ils.org:Evergreen into web-staff-proto

add staff web build dirs to gitignore

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Grunt-based dependencies, minification, and unit testing

Files to support Grunt-based browser staff building.

* Fetching dependencies (angularjs, etc.)
* Runs unit tests with grunt-karma
* Concatenates and minifies files with grunt-uglify

* Moved unit tests into web directory
* Taught t_base_js.tt2 how to load the minified version of the file

TODO:

* minifiying non-core files and (possibly) copying them into the build
  directory.
* Support for using non-minified files via browser option?
* Makefile options for building, testing, and copying the correct files
  into the actual web directory (instead of cp -r web/*)
* Build docs

Signed-off-by: Bill Erickson <berick@esilibrary.com>

remove dupe deflate stanza; example locales

Signed-off-by: Bill Erickson <berick@esilibrary.com>

minification repairs; minor nits

Signed-off-by: Bill Erickson <berick@esilibrary.com>

init cached patrons list for testing

Signed-off-by: Bill Erickson <berick@esilibrary.com>

avoid cookie dep.  store authtoken in sessionStorage

Signed-off-by: Bill Erickson <berick@esilibrary.com>

login form 'failed' label repair

Signed-off-by: Bill Erickson <berick@esilibrary.com>

grid config persistence; slimmer persist keys

Signed-off-by: Bill Erickson <berick@esilibrary.com>

remove flattener; access via egNet instead for streaming

Signed-off-by: Bill Erickson <berick@esilibrary.com>

focus last name (first input) in patron search

Signed-off-by: Bill Erickson <berick@esilibrary.com>

checkout added to nav; p search form starts w/ last name

Signed-off-by: Bill Erickson <berick@esilibrary.com>

browser staff : more egCore integration; egStrings

Signed-off-by: Bill Erickson <berick@esilibrary.com>

FF login repairs

Signed-off-by: Bill Erickson <berick@esilibrary.com>

start compressing services into egCore; minor patron lookup repair

Signed-off-by: Bill Erickson <berick@esilibrary.com>

misc fixes for patron search; local item storage

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Fix for docs on library information pages

Fixes an AsciiDoc URL processing error.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

checkout from patron barcode entry UI

* includes opt-in logic
* includes link from splash page

Signed-off-by: Bill Erickson <berick@esilibrary.com>

repair select-me link handler

Signed-off-by: Bill Erickson <berick@esilibrary.com>

workstation reg repairs

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Docs 2.6: Lost Item Billing Min/Max Price Settings

Add a short description for the new 2.6 feature "Lost Item Billing: New
Min/Max Price Settings" to the only section where it seems to fit, and it
seems obscure and hard to find. It could be useful to create a new, more
prominent section for common Org Unit Settings, possibly organized by
category. Sending this via GitHub to test the new Docs workflow.

Signed-off-by: Remington Steed <rjs7@calvin.edu>

workstations continued

Signed-off-by: Bill Erickson <berick@esilibrary.com>

workstation reg / display additions

Signed-off-by: Bill Erickson <berick@esilibrary.com>

new egPerm mod

Signed-off-by: Bill Erickson <berick@esilibrary.com>

new <eg-org-selector> directive

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Documentation: added missing word to 'library settings editor' docs

Added "editor" to label of what menu should be used.

Signed-off-by: Yamil Suarez <yamil@yamil.com>

Documentation: Removed bare setting names from Stripe payment doc

Per jboyer-isl's suggestions

Signed-off-by: Yamil Suarez <yamil@yamil.com>

Documentation: Copied Stripe payment info into 'Library Settings Editor'

Only modified slightly from the documentation provided in the EG 2.6
release notes.

Signed-off-by: Yamil Suarez <yamil@yamil.com>

more workstation config UI bits

Signed-off-by: Bill Erickson <berick@esilibrary.com>

grid cleanup / docs cont.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

UI for toggling hatch requried..

Signed-off-by: Bill Erickson <berick@esilibrary.com>

avoid bucket fetch sans bucket id

Signed-off-by: Bill Erickson <berick@esilibrary.com>

avoid no-op templates in grid

Signed-off-by: Bill Erickson <berick@esilibrary.com>

browser: only add to the grid scope data that's needed; not the whole grid object

Signed-off-by: Bill Erickson <berick@esilibrary.com>

minor repairs; grid required cols and onitemretrieve

Signed-off-by: Bill Erickson <berick@esilibrary.com>

docs, cleanup, minor grid item value repair

Signed-off-by: Bill Erickson <berick@esilibrary.com>

list.js superceded by grid.js; removing

Signed-off-by: Bill Erickson <berick@esilibrary.com>

moving more code over from list, etc. to grid

Signed-off-by: Bill Erickson <berick@esilibrary.com>

moving more code over from list, etc. to grid

Signed-off-by: Bill Erickson <berick@esilibrary.com>

inject array for patron app resolver; comments

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Library information pages

Updating the linked libraries documentation to include details on the new
library information pages introduced in 2.6.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Linked libraries docs

Documentation to the 2.5 feature that allows sites to add links in the
catalog from copy details area of the catalog.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

browser staff : port holds to grid; kill eglist for patron app

Signed-off-by: Bill Erickson <berick@esilibrary.com>

browser staff : patron UI migrations..

porting items out and checkout UI to eg-grid.

move items out and checkout to standalone js files

streamline items out to use streaming PCRUD request instead of
call/response (yay, websockets)

Signed-off-by: Bill Erickson <berick@esilibrary.com>

browser staff : repair prefs icon name

Signed-off-by: Bill Erickson <berick@esilibrary.com>

browser staff : prefs page shows local and remote prefs

Signed-off-by: Bill Erickson <berick@esilibrary.com>

browser staff : make accessing remote vs local actions possible

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Only create extension intarray if it does not already exist

Simple change to skip over adding intarray if it already exists in a database
for some reason.

Signed-off-by: Ben Shum <bshum@biblio.org>

browser staff : stored prefs perm check

Signed-off-by: Bill Erickson <berick@esilibrary.com>

browser staff : egUser.hasPermHere()

Signed-off-by: Bill Erickson <berick@esilibrary.com>

browser staff : new stored settings admin page

Page lets staff view and delete stored preferences.

TODO: permission

Signed-off-by: Bill Erickson <berick@esilibrary.com>

browser staff : remove extra dialog classes

... which were causing the alert and confirm dialogs to have double
backgrounds.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

browser staff : print config UI cont.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

browser staff : print config UI cont.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

LP#1310283: Propogate .staff through Z3950 searches

So that local catalog Z3950 searches don't only show opac visible bibs.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

browser staff : print config UI cont.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

LP#1311467: fix heading validation in bib editor

This patch fixes a regression whereby clicking the validate button
in the bib editor would result in no headings getting checked.

In the process, it enables 'startwith' to be used as a JSON query
operator for all types of predicates, not just the results of
transformed values.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

browser staff : print config UI cont.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Compile and Tweak Release Notes for 2.6.0

Also, add '.txt' to template name, since our build process expects
and uses that extension.

Signed-off-by: Dan Wells <dbw2@calvin.edu>

browser staff : print config UI cont.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Grab an up-to-date relator code list. Thanks, LoC!

Signed-off-by: Mike Rylander <mrylander@gmail.com>

browser staff : print config UI cont.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

browser staff : print config UI cont.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Rejigger 2.4.3-2.5.0 upgrade bits

As reported in LP#1261355, Postgres fails in some cases when changing
constraints on existing data inside a transaction.  This may or may not
fix the actual problem, but it at least tidies up these changes, and
will make it much cleaner to move outside the transaction if needed.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Remington Steed <rjs7@calvin.edu>

browser staff : print config UI cont.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

browser staff : print config UI initial

Signed-off-by: Bill Erickson <berick@esilibrary.com>

web staff: printing

Signed-off-by: Bill Erickson <berick@esilibrary.com>

browser staff: more printing and storage

Signed-off-by: Bill Erickson <berick@esilibrary.com>

browser staff: more printing and storage

Signed-off-by: Bill Erickson <berick@esilibrary.com>

LP#1308590: Fix schema.org type mapping

The switch to config.coded_value_map for format icon types and labels
inadvertently broke schema.org type mapping. Restore it and attempt
to take advantage of the finer-grained types that are now available
to us.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

browser staff : printing cont.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Translation updates - po files

Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1306176: force installation of Business::Stripe from CPAN

Business::Stripe can fail to pass its tests on platforms that
happen to have Pod::Simple 3.24 or later and Test::Pod.  In
particular, Debian Jessie and Ubuntu Trusty meet those conditions
(since the OpenSRF installation process installs libtest-pod-perl)
and Debian Wheezy with backports enabled does as well.

Since the failing test cases are only for POD, this patches moves
Business::Stripe to the CPAN_MODULES_FORCE list across the board.

This can be undone if/when Business::Stripe releases a fix for
the POD validation warnings.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

browser staff : return to page 1 on grid sort

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Merge branch 'master' of git.evergreen-ils.org:Evergreen into web-staff-proto

LP#1304559 - stamping upgrade script for vandelay_record_attr_to_flat

Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1304559 Fix slow Vandelay-based imports

Whether a planning limitation or otherwise, we have seen a few cases
where queries run very, very slowly (appear to hang) when using the
updated metabib.record_attr view in a WHERE clause.

The simplest code change is to switch Vandelay to use the intermediate
'_flat' view instead, and early reports indicate that this at least
gets us back to a functional state.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1305958 Fix copy table header ID error

Currently there is a <td headers='copy_header_date_format'> entry in
copy_table.tt2 that does not link to an associated table header with an
ID of that value. The desired target ID is "copy_header_create_date".

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1306133: Avoid metabib.rec_descriptor where possible

metabib.rec_descriptor has been a view over other data structures
for some time now, but with the advent of the new attribute infrastructure
it is a view over a view over a view, variously transforming IDs to
a slim table to an HSTORE structure and finally to a wide table. Thus,
it is extremely expensive to query. So we won't unless we're asked to.
Which, in the TPAC world, is never.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Doug Kyle <dkyle@grpl.org>

LP#1302113: acknowledgments for 2.6.0

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1302113: define a file for storing lists of folks to acknowledge in the release notes

If a file called _acknowlegments is present in the docs/RELEASE_NOTES_NEXT
directory, its contents will be appended to the end of the release
notes under an "Acknowledgments" heading when
create_release_notes.sh is run.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1301510 Align element name with Fixed Field type

We depend on the field name in the XUL to line up the fixed field
value maps in the database with the appropriate context menus. ELvl
was not capitalized the same in all required spots, causing the
context menu to render but be ineffective.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1303987: Fully populate Ills from context menu

The Ills fixed field is 4 characters long (allowing for up to four
types of illustrations to be noted, per 008/006), but the fixed field
editor dropdown menus are not (a) multi-select capable nor (b) ready
to support multi-value-per-field, because, well Ills is the only one
like this, and that would be a pretty big complication to the code.
However, even though multi-select is not supported, we should still
apply the value selected and update the fixed field, otherwise the
value is not updated in the record itself.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

browser staff : status bar; print repairs

Signed-off-by: Bill Erickson <berick@esilibrary.com>

LP#1281678 Fixed field context menus should trigger close confirmation dialog

Same for using the Physical Characteristics Wizard.

Thanks Dan Wells for the spot.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Reset the displayed mouse cursor

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Add alert in user editor for method errors

Add an alert() in the user editor so that method errors are not
silent.

Without this, a method error (such as when saving a patron fails at
the db level) is silent. Better to at least inform the user that
something is amiss.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1301955: disable autosuggest by default

Until we solve the accessibility issues caused by autosuggest as noted in
https://bugs.launchpad.net/evergreen/+bug/1187993, we shall disable the
feature by default for new installations.

An entry for the release notes is included.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP1301567: New format icons

This set adds icons for the new formats that can now be represented due to
the recent MVF work. Many thanks to Jim Keenan at C/W MARS for creating
many of these icons.

The serial.png icon was borrowed from the Koha project and was originally
contributed by VOKAL (Vermont Organization of Koha Automated Libraries).

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

browser staff : inline print content

adds support for an inline print container controlled by print css for
printing content from the browser when the external print engine is not
available

Signed-off-by: Bill Erickson <berick@esilibrary.com>

LP#1115599: Ignore canceled lineitems during batch cancel

Continue ignoring already-canceled lineitems during batch cancel so that
a) no unnecessary calls are made and b) staff can be alerted when no
viable lineitems were selected for the requested action.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1115599: Allow cancelled lineitems to be received and invoiced

Acquisitions staff need to be able to receive and invoice cancelled items,
particularly when those items are backordered. This branch restores the
ability to perform these actions on cancelled lineitems from the PO
screen.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1282704: Serials: in routing lists, avoid extra page breaks wasting paper at print time

If you're using batch receive, and you have two copies (and therefore
two streams) that you're receiving with the Routing List? checkbox
checked, but only one of those streams actually has a routing list,
you'll note before this patch is applied that you get an extra page of
blank paper if you print the routing list that pops up.

This fixes that.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

browser staff : more print stuff

Signed-off-by: Bill Erickson <berick@esilibrary.com>

LP#1303940: pin schema upgrade to 0878

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1303940: don't attempt to store NULL values in keyword, browse, or facet indexes

This patch implements a suggestion by Dan Wells and builds on Mike
Rylander's patch to skip inserting into field_entry and facet
indexes values that have been normalized to NULL.  As a side effect,
the following warning will no longer be logged when attempting
to store such values in the facet index:

WARNING:  Use of uninitialized value in subroutine entry at /usr/lib/perl/5.18/Unicode/Normalize.pm line 80.
CONTEXT:  PL/Perl function "force_unicode_normal_form"

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1303940: Protect against bogus data that can breaking indexing

In at least the case of browse indexing, some MARC contents can
cause us problems when normalization (such as stripping all
punctuation) can leave us with a NULL value for index-intended
data. The patch avoids the specific case of browse data being null
and causing an ingest failure.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1303940: improve readability of test case

This patch adds some whitespace and a comment in the MARCXML
to clarify the sort of data that triggers the bug.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>