working/Evergreen.git
10 years agoHonor "obscure DOB" YAOUS
Mike Rylander [Tue, 31 Mar 2015 20:46:32 +0000 (16:46 -0400)]
Honor "obscure DOB" YAOUS

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoFF context menus, generated from DB data
Mike Rylander [Tue, 31 Mar 2015 19:53:37 +0000 (15:53 -0400)]
FF context menus, generated from DB data

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoResolve after saving
Mike Rylander [Tue, 31 Mar 2015 19:52:06 +0000 (15:52 -0400)]
Resolve after saving

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoFixed field editor!
Mike Rylander [Mon, 30 Mar 2015 18:14:20 +0000 (14:14 -0400)]
Fixed field editor!

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoNew directive for FF editing
Mike Rylander [Fri, 27 Mar 2015 21:47:11 +0000 (17:47 -0400)]
New directive for FF editing

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoFetch FF pos map and value map, per record type
Mike Rylander [Fri, 27 Mar 2015 21:46:14 +0000 (17:46 -0400)]
Fetch FF pos map and value map, per record type

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoMake Date of Birth label red if DOB is emtpy
Mike Rylander [Thu, 26 Mar 2015 21:14:07 +0000 (17:14 -0400)]
Make Date of Birth label red if DOB is emtpy

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoAdd Profile to the column list on patron search results
Mike Rylander [Thu, 26 Mar 2015 20:41:05 +0000 (16:41 -0400)]
Add Profile to the column list on patron search results

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoRemove unnecessary dropdown-toggle attr
Mike Rylander [Thu, 26 Mar 2015 13:58:46 +0000 (09:58 -0400)]
Remove unnecessary dropdown-toggle attr

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoClose other context menus before showing this one
Mike Rylander [Fri, 20 Mar 2015 22:14:11 +0000 (18:14 -0400)]
Close other context menus before showing this one

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoindicator value lists now use "description" to, well, label descriptions
Galen Charlton [Mon, 16 Mar 2015 21:04:18 +0000 (21:04 +0000)]
indicator value lists now use "description" to, well, label descriptions

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoLP#1427287: (erratum) create Pg enum type to represent MARC record type
Galen Charlton [Mon, 16 Mar 2015 20:47:43 +0000 (20:47 +0000)]
LP#1427287: (erratum) create Pg enum type to represent MARC record type

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoLP#1427287: (erratum) use "description" rather than "value"
Galen Charlton [Mon, 16 Mar 2015 20:35:44 +0000 (20:35 +0000)]
LP#1427287: (erratum) use "description" rather than "value"

This makes the indicator list have the same shape as the
subfield code list.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agouse contextItemGenerator instead of contextItemContainer
Mike Rylander [Mon, 16 Mar 2015 20:02:04 +0000 (16:02 -0400)]
use contextItemGenerator instead of contextItemContainer

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoTypo (missing space)
Mike Rylander [Mon, 16 Mar 2015 20:08:20 +0000 (16:08 -0400)]
Typo (missing space)

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoTooltips for holdable/visible on status and location in item summary
Mike Rylander [Mon, 16 Mar 2015 19:12:36 +0000 (15:12 -0400)]
Tooltips for holdable/visible on status and location in item summary

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoAngularJS egTagTable service + context menus for tags, subfield codes, and indicator...
Galen Charlton [Mon, 16 Mar 2015 18:48:39 +0000 (18:48 +0000)]
AngularJS egTagTable service + context menus for tags, subfield codes, and indicator values

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoDo not change the tab on iframe changes when using the summary bar buttons
Mike Rylander [Thu, 12 Mar 2015 14:39:08 +0000 (10:39 -0400)]
Do not change the tab on iframe changes when using the summary bar buttons

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoUse ng-show instead of ng-if to avoid an extra scope injection
Mike Rylander [Thu, 12 Mar 2015 14:37:49 +0000 (10:37 -0400)]
Use ng-show instead of ng-if to avoid an extra scope injection

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoToward dirty data flag and better prev/next/start/end buttons
Mike Rylander [Thu, 12 Mar 2015 02:26:08 +0000 (22:26 -0400)]
Toward dirty data flag and better prev/next/start/end buttons

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoAdd buttons to call appropriate opac functions from the record summary bar
Mike Rylander [Wed, 11 Mar 2015 20:57:05 +0000 (16:57 -0400)]
Add buttons to call appropriate opac functions from the record summary bar

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoAllow UIs wrapping the opac to call functions in the opac iframe
Mike Rylander [Wed, 11 Mar 2015 20:56:23 +0000 (16:56 -0400)]
Allow UIs wrapping the opac to call functions in the opac iframe

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoAllow the iframe code to pass a handle to the iframe out to the parent scope
Mike Rylander [Wed, 11 Mar 2015 20:55:37 +0000 (16:55 -0400)]
Allow the iframe code to pass a handle to the iframe out to the parent scope

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoRespect items-out tally settings
Mike Rylander [Wed, 11 Mar 2015 19:58:41 +0000 (15:58 -0400)]
Respect items-out tally settings

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoGive the Holds Shelf a template and print button, and expose both that and the Pull...
Mike Rylander [Wed, 11 Mar 2015 18:18:04 +0000 (14:18 -0400)]
Give the Holds Shelf a template and print button, and expose both that and the Pull List in the workstation print interface

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoAdd support for a context menu item generator function on the scope (ContextItemGener...
Mike Rylander [Wed, 11 Mar 2015 15:52:28 +0000 (11:52 -0400)]
Add support for a context menu item generator function on the scope (ContextItemGenerator), and pull ContextItemContainer from the parent scope

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoMove the MARC namespace to MARC21 so someone can make a more generic superclass one day
Mike Rylander [Wed, 11 Mar 2015 15:44:02 +0000 (11:44 -0400)]
Move the MARC namespace to MARC21 so someone can make a more generic superclass one day

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoUse menu grouping on holds-for-this-record grid
Mike Rylander [Fri, 6 Mar 2015 20:54:31 +0000 (15:54 -0500)]
Use menu grouping on holds-for-this-record grid

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoTeach autogrid about grouping Actions menu options
Mike Rylander [Fri, 6 Mar 2015 20:54:16 +0000 (15:54 -0500)]
Teach autogrid about grouping Actions menu options

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoAdd "show holds", "show patrons", "show recent circs", and "show triggered events...
Mike Rylander [Fri, 6 Mar 2015 00:09:13 +0000 (19:09 -0500)]
Add "show holds", "show patrons", "show recent circs", and "show triggered events" to various grids

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoAllow Record Summary to collapse (and remember the choice)
Mike Rylander [Thu, 5 Mar 2015 20:16:45 +0000 (15:16 -0500)]
Allow Record Summary to collapse (and remember the choice)

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoAdd authority control sets support to the MARC namespace. Some TTS support will...
Mike Rylander [Tue, 3 Mar 2015 19:03:44 +0000 (14:03 -0500)]
Add authority control sets support to the MARC namespace.  Some TTS support will be required for Angular use.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoLP#1427287: methods to retrieve entire tag table
Galen Charlton [Tue, 3 Mar 2015 18:58:27 +0000 (18:58 +0000)]
LP#1427287: methods to retrieve entire tag table

This patch adds methods to open-ils.cat for
retrieving either the entire tag table or just the list
of MARC fields, either from the stock MARC format
seed definition or as potentially customized for the user's
workstation OU:

open-ils.cat.tag_table.all.retrieve.stock
open-ils.cat.tag_table.all.retrieve.local
open-ils.cat.tag_table.field_list.retrieve.stock
open-ils.cat.tag_table.field_list.retrieve.local

The user must have UPDATE_MARC permission.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoAllow hotkeys to work in form elements -- we may need to use the underlying Mousetrap...
Mike Rylander [Tue, 3 Mar 2015 17:23:55 +0000 (12:23 -0500)]
Allow hotkeys to work in form elements -- we may need to use the underlying Mousetrap library directly, however

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoLP#1427287: update fm_IDL.xml add ADMIN_TAG_TABLE permission
Galen Charlton [Mon, 2 Mar 2015 21:00:18 +0000 (21:00 +0000)]
LP#1427287: update fm_IDL.xml add ADMIN_TAG_TABLE permission

A question: should cataloging administrators get
system-level ADMIN_TAG_TABLE by default?

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoLP#1427287: tag table seed data for MARC 21
Galen Charlton [Mon, 2 Mar 2015 19:13:10 +0000 (19:13 +0000)]
LP#1427287: tag table seed data for MARC 21

This was converted from marcedit-tooltips.xml
using the marc_tooltips_to_sql script introduced in the
previous commit.  As a consequence, the tag table
data is somewhat out of date; this will be addressed
later.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoLP#1427287: script to migrate MARC tooltips data file
Galen Charlton [Mon, 2 Mar 2015 19:10:13 +0000 (19:10 +0000)]
LP#1427287: script to migrate MARC tooltips data file

marc_tooltips_to_sql is a script that converts an
Evergreen MARC tooltips file to a set of SQL statements
for seeding config.marc_field, config.marc_subfield,
config.record_attr_definition, and config.coded_value_map
with tag table data.

Example usage:

marc_tooltips_to_sql --input Open-ILS/xul/staff_client/server/locale/en-US/marcedit-tooltips.xml \
                     --output /tmp/bibs.sql --type biblio

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoLP#1427287: database schema for storing MARC tag+subfield metadata
Galen Charlton [Mon, 2 Mar 2015 17:14:30 +0000 (17:14 +0000)]
LP#1427287: database schema for storing MARC tag+subfield metadata

This patch defines several tables, views, and functions for
storing information about MARC tags and subfields recognized
by Evergreen:

Tables:

* config.marc_format:   list of MARC formats; at present, however,
                        only MARC21 is supported
* config.marc_field:    list of fields recognized by the Evergreen
                        database.
* config.marc_subfield: list of subfields recognized by Evergreen

Views:

* config.marc_field_for_ou
* config.marc_subfield_for_ou

These two views assist in the process of determining the set of
MARC fields and subfields are meant to be in force at a particular
OU.  These are generally not meant to be queried directly, in
favor of the config.ou_marc_{sub}fields() functions.

Functions:

* config.ou_marc_fields(marc_format, marc_record_type, ou)
* config.ou_marc_subfields(marc_format, marc_record_type, ou)

These functions return the authoritative set of fields or
subfields in force at a given OU.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoAdd F1 hotkey (checkout)
Mike Rylander [Fri, 27 Feb 2015 19:00:50 +0000 (14:00 -0500)]
Add F1 hotkey (checkout)

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agouse preventDefault() on navbar hotkeys
Mike Rylander [Fri, 27 Feb 2015 18:42:59 +0000 (13:42 -0500)]
use preventDefault() on navbar hotkeys

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agowire the date filter into the payments grid in billing xact history
Jason Etheridge [Fri, 27 Feb 2015 05:20:24 +0000 (00:20 -0500)]
wire the date filter into the payments grid in billing xact history

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
10 years agoApply date filter range on command in billing xact history
Bill Erickson [Wed, 11 Feb 2015 15:54:22 +0000 (10:54 -0500)]
Apply date filter range on command in billing xact history

Adds an Apply button for apply changes to the date filter to the grid.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
10 years agoGrid supports automatic refresh with query change
Bill Erickson [Wed, 11 Feb 2015 15:43:43 +0000 (10:43 -0500)]
Grid supports automatic refresh with query change

Adds a new gridControls function watchQuery(), which returns the
contents of the grid query.  When the contents change, the grid
automatically redraws.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
10 years agoSet refresh function so Actions trigger refresh
Mike Rylander [Fri, 27 Feb 2015 18:25:11 +0000 (13:25 -0500)]
Set refresh function so Actions trigger refresh

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agointernalize jquery
Mike Rylander [Fri, 27 Feb 2015 17:13:52 +0000 (12:13 -0500)]
internalize jquery

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoLP#1312308 circ scripts, penalty removal release notes
Bill Erickson [Fri, 22 May 2015 20:25:18 +0000 (16:25 -0400)]
LP#1312308 circ scripts, penalty removal release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
10 years agoLP#1312308 remove deprecated open-ils.penalty service
Bill Erickson [Fri, 22 May 2015 20:07:29 +0000 (16:07 -0400)]
LP#1312308 remove deprecated open-ils.penalty service

open-ils.penalty service has not been used by Evergreen since before
version 2.0.  Instead of just cleaning out the script configuration,
clean out the entire application.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
10 years agoLP#1312308 script circ and deps removal
Bill Erickson [Wed, 13 May 2015 17:14:21 +0000 (13:14 -0400)]
LP#1312308 script circ and deps removal

* Remove libjs and spidermonkey from prereq installer
* Remove references to spidermonkey and script runner
* Remove stock JS circ and catalog scripts

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
10 years agoDocs: 2.8 Patron Message Center
Angela Kilsdonk [Thu, 25 Jun 2015 15:42:14 +0000 (10:42 -0500)]
Docs: 2.8 Patron Message Center

Documentation for Patron Message Center development in 2.8

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
10 years agoDocs: 2.6 Duplicate Serials Barcode Alert
Angela Kilsdonk [Wed, 24 Jun 2015 17:16:21 +0000 (12:16 -0500)]
Docs: 2.6 Duplicate Serials Barcode Alert

Documentation for new duplicate serials barcode alert in Serials Batch Receive.

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
10 years agoMerge branch 'master' of git.evergreen-ils.org:Evergreen
Angela Kilsdonk [Wed, 24 Jun 2015 16:55:03 +0000 (11:55 -0500)]
Merge branch 'master' of git.evergreen-ils.org:Evergreen

10 years agoNew Documentation for 2.8
Angela Kilsdonk [Wed, 24 Jun 2015 16:49:00 +0000 (11:49 -0500)]
New Documentation for 2.8

2.8 Display Count of Existing Copies
2.8 Duplicate PO Name Alert
2.8 Negative Balances on Patron Accounts

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
10 years agoLP#1468362 fix release me syntax and update acknowledgements
Yamil Suarez [Wed, 24 Jun 2015 15:09:04 +0000 (11:09 -0400)]
LP#1468362 fix release me syntax and update acknowledgements

Signed-off-by: Yamil Suarez <yamil@yamil.com>
10 years agoDocs: Update action trigger docs to add missing fields.
Josh Stompro [Tue, 28 Apr 2015 13:16:54 +0000 (08:16 -0500)]
Docs: Update action trigger docs to add missing fields.

Rename heading to "Notifications / Action Trigger" so it matches
the staff client admin menu.

Signed-off-by: Josh Stompro <stomproj@larl.org>
10 years agoLP#1465830: authority linker now ignores $e and $4 in bib name headings
Yamil Suarez [Fri, 19 Jun 2015 14:50:45 +0000 (10:50 -0400)]
LP#1465830: authority linker now ignores $e and $4 in bib name headings

presence of relator terms or codes in $e or $4 can prevent authority
headings linking

To test
-------
[1] Create an authority record with a name heading like this

    100 $a Example, Natalia $d 1945-

[2] Create a bib record that contains the name and a relator
    code or term, e.g.,

    100 $a Example, Natalia $d 1945- $4edt

[3] Run authority_control_fields.pl. Note that the
    heading in the bib is *NOT* linked, as evidence
    by no $0 being added to the bib heading and no
    rows added to authority.bib_linking for that bib
    and authority.

[4] Apply the patch and re-run step 3.  This time,
    the link gets established:

    100 $a Example, Natalia $d 1945- $4 edt $0 (CONS)xxx

Signed-off-by: Yamil Suarez <yamil@yamil.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoDocs: Change references to release 2.8.2 for server upgrade
Ben Shum [Thu, 18 Jun 2015 04:02:09 +0000 (00:02 -0400)]
Docs: Change references to release 2.8.2 for server upgrade

Since 2.8.2 is released, change references in upgrade docs to this newest
release.

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoPorting 2.8.1 -> 2.8.2 SQL upgrade
Bill Erickson [Wed, 17 Jun 2015 21:51:50 +0000 (17:51 -0400)]
Porting 2.8.1 -> 2.8.2 SQL upgrade

Signed-off-by: Bill Erickson <berickxx@gmail.com>
10 years agoLP#1446816 HTML-escape notes in XUL patron alert page
Bill Erickson [Wed, 17 Jun 2015 17:27:05 +0000 (13:27 -0400)]
LP#1446816 HTML-escape notes in XUL patron alert page

Avoid rendering HTML contained in patron messages, etc. in the XUL
patron stop-sign page.

Thanks to Jason Etheridge, ESI for noting this problem and contributing
the original patch fix.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoRelease notes for 2.8.2
Kathy Lussier [Wed, 17 Jun 2015 20:19:58 +0000 (16:19 -0400)]
Release notes for 2.8.2

Adding a section for 2.8.2 bug fixes in the 2.8 Release Notes.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
10 years agoRemove alpha and RC scripts for 2.3-2.4
Ben Shum [Tue, 3 Mar 2015 02:40:47 +0000 (21:40 -0500)]
Remove alpha and RC scripts for 2.3-2.4

These were in the repository from the testing phase of 2.3-2.4 during the
2.4 alpha/RC period. These script are not required and may be confusing if
run. Remove as unnecessary.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
10 years agoLP#1205061: Add IF EXISTS to some DROP statements in 2.3-2.4 upgrade script
Ben Shum [Tue, 3 Mar 2015 02:34:53 +0000 (21:34 -0500)]
LP#1205061: Add IF EXISTS to some DROP statements in 2.3-2.4 upgrade script

To prevent potential issues, add IF EXISTS clauses to DROP statements in this
version upgrade script.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
10 years agoDocumentation LP1369203 - Removed formatting around image link to
Josh Stompro [Fri, 9 Jan 2015 22:03:49 +0000 (16:03 -0600)]
Documentation LP1369203 - Removed formatting around image link to
re-enable the image.

Signed-off-by: Josh Stompro <stomproj@larl.org>
10 years agoDocs: Updated opensearch example with new label format
Josh Stompro [Tue, 2 Jun 2015 18:09:10 +0000 (13:09 -0500)]
Docs: Updated opensearch example with new label format

The OpenSearch title now specifies the library name instead of the generic
"Evergreen OpenSearch" at every scope.

This is one of many TPAC Discoverability Enhancements included in
Evergreen 2.8.

Signed-off-by: Josh Stompro <stomproj@larl.org>
10 years agoDocs: LP#1387639 - Barcode Completion Documentation
Josh Stompro [Wed, 3 Jun 2015 19:17:19 +0000 (14:17 -0500)]
Docs: LP#1387639 - Barcode Completion Documentation

Signed-off-by: Josh Stompro <stomproj@larl.org>
Conflicts:
docs/root.txt

Signed-off-by: Josh Stompro <stomproj@larl.org>
10 years agofix live_t/08-lp1366964-libdbi-error.t
Jason Etheridge [Tue, 16 Jun 2015 16:30:38 +0000 (12:30 -0400)]
fix live_t/08-lp1366964-libdbi-error.t

from this:

opensrf@dev141:~/git/Evergreen/Open-ILS/src/perlmods/live_t (lp902255test)$ prove 08-lp1366964-libdbi-error.t
08-lp1366964-libdbi-error.t .. # Tests libdbi transaction error reporting
08-lp1366964-libdbi-error.t .. 1/2
 #   Failed test 'CStoreEditor returns standard query error'
 #   at 08-lp1366964-libdbi-error.t line 31.
 #          got: 'DATABASE_UPDATE_FAILED'
 #     expected: 'DATABASE_QUERY_FAILED'
 # Looks like you failed 1 test of 2.
08-lp1366964-libdbi-error.t .. Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/2 subtests

Test Summary Report
-------------------
08-lp1366964-libdbi-error.t (Wstat: 256 Tests: 2 Failed: 1)
  Failed test:  2
  Non-zero exit status: 1
Files=1, Tests=2,  1 wallclock secs ( 0.02 usr  0.01 sys +  0.82 cusr  0.11 csys =  0.96 CPU)
Result: FAIL

to this:

opensrf@dev141:~/git/Evergreen/Open-ILS/src/perlmods/live_t (lp902255test)$ prove 08-lp1366964-libdbi-error.t
08-lp1366964-libdbi-error.t .. # Tests libdbi transaction error reporting
08-lp1366964-libdbi-error.t .. ok
All tests successful.
Files=1, Tests=2,  2 wallclock secs ( 0.02 usr  0.02 sys +  0.85 cusr  0.08 csys =  0.97 CPU)
Result: PASS

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoLP 902255: Fix upgrade script.
Jason Stephenson [Mon, 15 Jun 2015 20:29:02 +0000 (16:29 -0400)]
LP 902255: Fix upgrade script.

Run as-is, the upgrade script produces an error:

ERROR:  CREATE INDEX CONCURRENTLY cannot run inside a transaction block

Following this conversation in IRC, it was decided to remove the keyword
CONCURRENTLY from the create index statement.

http://irc.evergreen-ils.org/evergreen/2015-06-15#i_182857

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
10 years agoLP 902255: Stamping upgrade script
Jason Stephenson [Mon, 15 Jun 2015 19:22:09 +0000 (15:22 -0400)]
LP 902255: Stamping upgrade script

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
10 years agoLP#902255: Use simple alert box
Mike Rylander [Fri, 12 Jun 2015 18:29:02 +0000 (14:29 -0400)]
LP#902255: Use simple alert box

Instead of the generic communication error dialog, we'll use
the simple yns_alert box instead.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
10 years agoLP#902255: Correct "ILS Event at check in" logic
Mike Rylander [Thu, 11 Jun 2015 12:49:21 +0000 (08:49 -0400)]
LP#902255: Correct "ILS Event at check in" logic

In a classic case of "fix a bug to reveal another" it turn out that
there was a small logic bug hiding in the check in hold-capture code.
The result of this bug was that the wrong ILS Event object was being
returned when we ran into the double-scan hold-capture situation by
overwriting the correct one immediately after we construct it, which
in turn prevented the previous commit from working as designed.

We now return the correct ILS Event immediately so that we can
properly detect the situation.  Two birds with one branch.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
10 years agoLP#902255: Protect against hold double-capture
Mike Rylander [Mon, 8 Jun 2015 15:11:04 +0000 (11:11 -0400)]
LP#902255: Protect against hold double-capture

When the staff client is in Fast Scan (async) mode, it is possible
to double-scan at checkin and cause two holds to be captured by the
same item.  By creating a specially crafted unique index we ensure
that the database rejects this situation.

This protection would cause unhandled errors in the staff client, so
we also register a new string to be displayed when this particular
situation occurs, alerting staff to the possible double-scan of a
barcode at checkin IFF they are using async mode.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
10 years agoLP#1463145 - Debian Jessie needs libexcel-writer-xlsx-perl
Ben Shum [Thu, 11 Jun 2015 00:57:29 +0000 (20:57 -0400)]
LP#1463145 - Debian Jessie needs libexcel-writer-xlsx-perl

Without this package, attempts to run clark-kent.pl will fail on Debian Jessie.

Also remove old libspreadsheet-writeexcel-perl package from pre-reqs as it is
no longer required.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
10 years agoLP#1365661 Found patrons with same name not opening
Adam Bowling [Fri, 16 Jan 2015 22:18:24 +0000 (17:18 -0500)]
LP#1365661 Found patrons with same name not opening

This patch fixes the error, while registering a new patron
and clicking the link "Found {$0} patron(s) with the same
name" did not previously work in the staff client.

To reproduce the bug, register a new patron with the name of an
existing patron.  The little widget with the message described
above will appear.  The message is a hyperlink, but nothing
appears to happen if you click it.  The JavaScript console will
contain an error ReferenceError:js2JSON is not defined.

After applying this patch, clicking the hyperlink does a search
for matching patrons as intended.  The ReferenceError also
disappears.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
10 years agoLP#1154656 MARC Expert Search "Add Rows" adds duplicate row
Michael Peters [Tue, 9 Jun 2015 14:10:04 +0000 (10:10 -0400)]
LP#1154656 MARC Expert Search "Add Rows" adds duplicate row

This patch changes the behavior of the "Add Search Row" link
(JavaScript function from simple.js "addExpertRow()") so that
we are always cloning the initial "empty" row instead of
potentially cloning a row -- by way of cloneNode() -- with user
input in place, and causing duplicate search rows.

To reproduce the bug, go to Advanced Search, fill in all three
search fields with some text, click on Add Search Row.  You wil
see that the Title search row along with the data in the text
box is duplicated and added to the search.

After this patch, the new row should be added with an empty
text box.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Signed-off-by: Rashma Kumaran <rkumaran@kcls.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
10 years agoLP#1342227 - Allow EDI Ruby dependency installation on Ubuntu 14.04
Chris Sharp [Tue, 7 Apr 2015 00:17:30 +0000 (20:17 -0400)]
LP#1342227 - Allow EDI Ruby dependency installation on Ubuntu 14.04

Create a script for Ubuntu 14.04 ruby installation and installation
for EDI dependencies.  Remove 'rcov', which has been deprecated for
Ruby 1.9.1 and install Bill Erickson's GIR improvements.

In the future we will need to remove this dependency altogether (see
bug 1373690), but for now, at least get it working on Ubuntu 14.04.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
10 years agoLP1424646 Paid-For Long Overdue Items Still Appear in "Other/Special Circulations...
blake [Fri, 10 Apr 2015 19:29:08 +0000 (14:29 -0500)]
LP1424646 Paid-For Long Overdue Items Still Appear in "Other/Special Circulations" Window

Edited the query inside the fm_IDL.xml file

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
10 years agoDocs LP#1371646: Add better screenshots
Remington Steed [Wed, 10 Jun 2015 21:07:43 +0000 (17:07 -0400)]
Docs LP#1371646: Add better screenshots

This commit borrows two screenshots from the Sitka Evergreen Training
Manual to replace one in the Alternate Serial Control View section.
Thanks Sitka!

Signed-off-by: Remington Steed <rjs7@calvin.edu>
10 years agoLP1444623: Remove "Safe" CPAN dependency from Debian/Ubuntu Makefile.install files
Chris Sharp [Wed, 15 Apr 2015 18:05:23 +0000 (14:05 -0400)]
LP1444623: Remove "Safe" CPAN dependency from Debian/Ubuntu Makefile.install files

Following up on IRC discussion at http://irc.evergreen-ils.org/evergreen/2015-04-15#i_170386
it was agreed that it is no longer necessary to install Safe from CPAN
since it is included in the standard Perl package.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Conflicts:
Open-ILS/src/extras/install/Makefile.debian-jessie

10 years agoLP#638509: Handle COPY_STATUS_LOST and COPY_STATUS_LONG_OVERDUE in renewal.
Jason Stephenson [Sat, 15 Feb 2014 17:56:58 +0000 (12:56 -0500)]
LP#638509: Handle COPY_STATUS_LOST and COPY_STATUS_LONG_OVERDUE in renewal.

Modify Open-ILS/xul/staff_client/server/circ/util.js so that the
above events are available for override.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#638509: Remove the stop_fines checks from do_renew's circulation search.
Jason Stephenson [Sun, 2 Feb 2014 20:59:34 +0000 (15:59 -0500)]
LP#638509: Remove the stop_fines checks from do_renew's circulation search.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1396263: Fix for 'Return to Record' link breaks after texting
Terran McCanna [Wed, 10 Jun 2015 19:44:46 +0000 (15:44 -0400)]
LP#1396263: Fix for 'Return to Record' link breaks after texting

If user is already logged into OPAC when texting a call number from
the record screen, the 'Return to Record' link works properly. However,
if user is not logged in and is prompted to log in first, the 'Return to
Record' link actually returns the user to 'My Account.' This patch
corrects that problem and returns the user to the record regardless of
whether they were initially logged in or not.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP1440148 Long overdue Items out TPAC OPAC display My Account
Blake Henderson [Fri, 10 Apr 2015 20:43:54 +0000 (15:43 -0500)]
LP1440148 Long overdue Items out TPAC OPAC display My Account

Removed Long overdue circs from the total_out count

Signed-off-by: Blake Henderson <blake@mobiusconsortium.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1463973: Use dollar-quoting for report literals
Mike Rylander [Wed, 10 Jun 2015 18:17:37 +0000 (14:17 -0400)]
LP#1463973: Use dollar-quoting for report literals

When inserting string literal into SQL for Clark, we quote
apostrophes with a backslash.  That worked fine until Postgres
changed its default for the standard_conforming_strings GUC to "on"
after which it no longer worked fine.

So, we will now use "dollar quoting" for string literals instead
in much the same way we do for our search queries.

Test plan
---------

Pre-patch: Try to run a report where a string value is required as
a filter parameter, and include an apostrophe in that string.  The
report will fail with an SQL error.

Post-patch: Do the same, it will not fail.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1446860 - Correct mistaken logic in previous fix.
Chris Sharp [Wed, 22 Apr 2015 13:54:11 +0000 (09:54 -0400)]
LP#1446860 - Correct mistaken logic in previous fix.

See https://bugs.launchpad.net/evergreen/+bug/1446860/comments/2
for reference.  The logic was not enforcing the "if the editing
staff member doesn't have permission to edit a user in this
permission group" check.  This corrects that.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1446860 Staff were able to edit their own accounts.
Chris Sharp [Tue, 21 Apr 2015 21:10:49 +0000 (17:10 -0400)]
LP#1446860 Staff were able to edit their own accounts.

This change reverses what appears to be a thinko in the
original programming.  If the editing user is the same
as the user being edited, disable the Save button.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1074096: Remove Bib Call Number from query type selector
Jeff Davis [Thu, 16 Apr 2015 15:58:17 +0000 (08:58 -0700)]
LP#1074096: Remove Bib Call Number from query type selector

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1452883: prevent staff client warnings w/ Google Analytics
Jason Etheridge [Thu, 7 May 2015 20:02:00 +0000 (16:02 -0400)]
LP#1452883: prevent staff client warnings w/ Google Analytics

In particular, the Security Warning that goes "You have requested an encrypted
page that contains some unencrypted information..."

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1403966: Remove publication-specific information from metarecord results page
Kathy Lussier [Thu, 28 May 2015 02:11:49 +0000 (22:11 -0400)]
LP#1403966: Remove publication-specific information from metarecord results page

The records that make up a matarecord search result typically contain different
publication information. Therefore, we should remove the master record's
specific publication information from that search results page.

Test plan
Prior to loading the patch, conduct a search on the Concerto dataset
for "brahms piano concerto no. 1" with "Group Formats and Editions" turned on.
In the brief view, you will see a call number and, in the more details view, you
will see publisher and physical description information. Run the same search
after loading the patch, and you will no longer see that information.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Andrea Neiman <aneiman@kent.lib.md.us>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1194860: You have permission to override some of the failed holds. appearing when...
Blake Henderson [Mon, 8 Dec 2014 21:52:15 +0000 (15:52 -0600)]
LP#1194860: You have permission to override some of the failed holds. appearing when it should not for patrons in the OPAC Edit

A quick value check before assigning the override variable.
This should eliminate the OPAC showing the override option
for those who do not have the permission.

Signed-off-by: Blake Henderson <blake@mobiusconsortium.org>
Signed-off-by: Liam Whalen <liam.whalen@bc.libraries.coop>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1456021 Enable apache modcgi during install for Debian Jessie
Josh Stompro [Sun, 31 May 2015 22:49:34 +0000 (17:49 -0500)]
LP#1456021 Enable apache modcgi during install for Debian Jessie

Apache mod cgi isn't enabled when installing apache2.4 on Debian Jessie,
this causes the /updates/manualupdate.html to not be processed and
to just return the raw code of that script since it uses mod cgi.

This adds 'cgi' to the list of apache modules to enable during the
dependency install.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1457094 Switch to package libtemplate-plugin-posix-perl for Debian Jessie
Josh Stompro [Sun, 31 May 2015 22:19:58 +0000 (17:19 -0500)]
LP#1457094 Switch to package libtemplate-plugin-posix-perl for Debian Jessie

Debian Jessie includes a package for Template::Plugin::Posix that was
being installed via CPAN.  This patch removes the CPAN install and adds
the Debian package.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#757533: adds scrollbars (when necessary) to the item status alternate view tab...
Bradley Bonner [Wed, 10 Jun 2015 21:26:57 +0000 (14:26 -0700)]
LP#757533: adds scrollbars (when necessary) to the item status alternate view tab box.

Signed-off-by: Bradley Bonner <bbonner@kcls.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1289486 Stamping upgrade for dropping acq audit fkey
Dan Wells [Wed, 10 Jun 2015 19:05:13 +0000 (15:05 -0400)]
LP#1289486 Stamping upgrade for dropping acq audit fkey

Signed-off-by: Dan Wells <dbw2@calvin.edu>
10 years agoLP#1289486: Remove blocking constraint from audit table
Mike Rylander [Mon, 8 Jun 2015 21:30:52 +0000 (17:30 -0400)]
LP#1289486: Remove blocking constraint from audit table

The ACQ lineitem audit table was augmented with an fkey pointing
to the queued record that was related to the line item.  That's
bad because there are also triggers which attempt to manage that
table.  Hilarity ensues.  We should not have an fkey on an audit
table, so, we now remove that.

In order to test this, first attempt to delete an ACQ queue and
have that fail.  Apply the DB change, attempt again, and have it
succeed.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
10 years agoLP#1447168 Stamping upgrade script for index on ash record
Dan Wells [Wed, 10 Jun 2015 18:29:27 +0000 (14:29 -0400)]
LP#1447168 Stamping upgrade script for index on ash record

Signed-off-by: Dan Wells <dbw2@calvin.edu>
10 years agoLP#1447168: add an index on authority.simple_heading.record
Galen Charlton [Wed, 22 Apr 2015 13:43:19 +0000 (13:43 +0000)]
LP#1447168: add an index on authority.simple_heading.record

This index is needed so that full table scans on ash aren't
needed during authority record reingest.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
10 years agoLP#1449709: Always get a real hostname for the cache key
Mike Rylander [Fri, 22 May 2015 17:11:18 +0000 (13:11 -0400)]
LP#1449709: Always get a real hostname for the cache key

EGCatLoader overwrites $ctx->{hostname} when serving the staff client
version of TT-generated content.  This is bad for us because we use
that as part of the TT Processor cache key.  Instead, we'll just
always ask Apache, via $r.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
10 years agoLP#1452366: allow EGWeb context loaders to have child_init actions
Galen Charlton [Tue, 5 May 2015 22:15:39 +0000 (22:15 +0000)]
LP#1452366: allow EGWeb context loaders to have child_init actions

This patch adds the ability for EGWeb to call
an initialization function for context loaders
during the child_init phase of Apache backend
startup.

In particular, portions of the R/O object cache
for EGCatLoader are now initialized when a backend
starts up; testing indicates that this can shave
a couple seconds off the time it takes for a
backend to render a bib details page the first time.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
10 years agoLP#1452352: use fresh CStore editors when populating R/O cache
Galen Charlton [Wed, 6 May 2015 18:23:49 +0000 (18:23 +0000)]
LP#1452352: use fresh CStore editors when populating R/O cache

This change ensures that there's no longer a cached
editor with its original session locale grabbing
the wrong labels when a template invokes ctx.search_foo.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
10 years agoLP#1452352: don't leak $ctx when initializing TPAC R/O object cache
Mike Rylander [Wed, 6 May 2015 15:10:44 +0000 (11:10 -0400)]
LP#1452352: don't leak $ctx when initializing TPAC R/O object cache

Create a closure over a simple scalar instead of the
whole $ctx object when all we need is the locale.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
10 years agoLP#1452352: fix generation of locale-specific RO object fetchers
Galen Charlton [Wed, 6 May 2015 13:50:32 +0000 (13:50 +0000)]
LP#1452352: fix generation of locale-specific RO object fetchers

The TPAC R/O object cache is now keyed by locale.  This
fixes an issue where an OPAC session that starts in one
locale and gets switched to another could see (e.g.)
format labels for the original locale.

The issue fixed by this patch can be most readily reproduced
as follows:

[1] Enable both the en-US and fr-CA locales. Make sure
    that there are some translations for record format
    coded values in place as well.
[2] Run Apache in single-process mode
    (e.g., ". /etc/apache2/envvars && apache2 -X")
[3] Visit a record details page in the en-US locale. Note
    the label associated with the record format.
[4] Change the locale to fr-CA. Note that the label is
    still the English version.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>