dbs [Wed, 2 Mar 2011 05:14:58 +0000 (05:14 +0000)]
Syntax, baby, syntax (for the buildbot)
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2190
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Wed, 2 Mar 2011 05:10:21 +0000 (05:10 +0000)]
Avoid running Perl unit tests when our branches have them not
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2189
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Wed, 2 Mar 2011 03:51:42 +0000 (03:51 +0000)]
Coerce the weird test env for MFHD into working inside buildbot
'use testlib.pm' throws the standard "prove --lib lib -r t" recipe for testing
Perl packages out the window, so we have to override the Perl testing class
and point to the known location of testlib.pm
This may still fail for Evergreen branches prior to rel_2_1, but it's
_something_. Throw me a bone, here, will ya?
Ultimately, the best thing to do is probably to make MFHD tests conform.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2188
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 1 Mar 2011 23:06:32 +0000 (23:06 +0000)]
Distinguish between the projects being built (duh)
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2187
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Mon, 28 Feb 2011 04:05:40 +0000 (04:05 +0000)]
Recommend Fedora 14 as F13 goes out of support in a few months
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2182
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 22 Feb 2011 14:28:19 +0000 (14:28 +0000)]
Resolve encoding problem found by attempting to register patrons with Unicode names
Symptoms were:
1. a gateway.log entry showing http_translator receiving an XMPP error message
2. a corresponding osrfsys.log entry "server: died with error Wide character in syswrite at /usr/local/share/perl5/OpenSRF/Server.pm line 239"
Per normal Perl Unicode handling practices, decoding input and encoding output
using the Encode module and decode_utf8() / encode_utf8() appears to resolve
the problem.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2168
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Mon, 14 Feb 2011 13:54:50 +0000 (13:54 +0000)]
added sample rsyslog opensrf configuration file
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2167
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Mon, 14 Feb 2011 06:21:36 +0000 (06:21 +0000)]
Add Evergreen to the buildbot configuration
Now all that we need are Evergreen buildslaves!
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2166
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Mon, 31 Jan 2011 05:56:39 +0000 (05:56 +0000)]
Whitespace consistency (tabs for Makefiles I guess)
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2164
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Mon, 31 Jan 2011 05:49:10 +0000 (05:49 +0000)]
Use an Exporter-approved version number (only one decimal place)
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2162
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Mon, 31 Jan 2011 05:39:24 +0000 (05:39 +0000)]
Create a function for explicit trunk changes (shouldn't be necessary, but...)
Also untabify (augh) the file. Oh the whitespace!
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2161
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Mon, 31 Jan 2011 04:36:13 +0000 (04:36 +0000)]
To specify trunk in the ChangeFilter, use branch=None
At least, that's how I'm reading the buildbot docs at this time of night:
http://buildbot.net/buildbot/docs/current/Change-Filters.html
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2159
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Mon, 31 Jan 2011 04:22:23 +0000 (04:22 +0000)]
We're not just OpenSRF trunk, we've got other branches
Also, drop %%BRANCH%% from the SVN baseURL and give it a default
branch.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2158
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Mon, 31 Jan 2011 02:28:51 +0000 (02:28 +0000)]
Correct copy/paste error in Build.PL metadata
OpenSRF uses GPL v2 or later, not the Perl license.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2157
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Fri, 28 Jan 2011 16:15:11 +0000 (16:15 +0000)]
Add OpenSRF rel_1_6 and rel_2_0 builds to the OpenSRF build slave
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2155
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Thu, 27 Jan 2011 05:19:06 +0000 (05:19 +0000)]
Try sending failure notification to the -dev list
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2154
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Thu, 27 Jan 2011 04:12:37 +0000 (04:12 +0000)]
buildbot configuration: add mail notification, explicit builder name
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2153
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Wed, 26 Jan 2011 19:55:29 +0000 (19:55 +0000)]
Check in a sample buildbot configuration file for OpenSRF
Change XXX to meaningful values before deploying :)
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2152
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Wed, 26 Jan 2011 17:51:26 +0000 (17:51 +0000)]
OpenSRF::UnixServer doesn't live here any more
This test was still succeeding on hosts that had installed
previous versions of OpenSRF, but failed on a shiny new
test instance.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2151
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Wed, 26 Jan 2011 03:31:47 +0000 (03:31 +0000)]
Set the correct number of expected tests so that we don't fail 100% of the time
I guess we haven't run "make test" here since r2024 - heh.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2149
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 25 Jan 2011 18:15:22 +0000 (18:15 +0000)]
Trivial typo fix (also tests OpenSRF buildbot)
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2148
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Fri, 21 Jan 2011 15:00:46 +0000 (15:00 +0000)]
repaired call to handle_request for router query; cannot survive without the self.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2145
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Fri, 21 Jan 2011 14:58:35 +0000 (14:58 +0000)]
make the api CALL log line consistent across Perl and C and make it something that can be pasted directly into srfsh
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2144
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 11 Jan 2011 23:05:27 +0000 (23:05 +0000)]
Get that brace back in the right place
Unbreak the build. Argh.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2143
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 11 Jan 2011 23:00:35 +0000 (23:00 +0000)]
Add hints to increase max_children config variable if we're hitting the maximum
Already added this hint to the Python implementation, now propagating to
C and Perl.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2142
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 11 Jan 2011 22:59:18 +0000 (22:59 +0000)]
Clean up Python server implementation, guided by pylint
Add some docstrings, keep line lengths at 80 or less (MORE
WHITESPACE!), remove some dead code, and add a hint to check
max_children config value if we're bumping up against the
limit.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2141
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 11 Jan 2011 21:33:09 +0000 (21:33 +0000)]
Remove max_requests config stanza from C language implementations in example config
Only Perl implementations support the max_requests stanza, so let's not confuse
matters with an unused element.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2140
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Mon, 20 Dec 2010 02:55:24 +0000 (02:55 +0000)]
Straighten out -f / -d flag confusion in libmemcached prerequisite
There are two different styles of checking for previously downloaded
tarballs in this Makefile; the libmemcached entry combined them both
with unfortunate results.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2138
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Mon, 20 Dec 2010 02:54:32 +0000 (02:54 +0000)]
repaired bug in total request time calc, particularly when a request returns no response
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2136
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Mon, 20 Dec 2010 01:20:48 +0000 (01:20 +0000)]
Python srfsh enhancements
* Srfsh plugins can now insert new commands and add words to the tab
completion word bank.
* Addded support reading script files
* Added support for service open/close (connect/disconnect) for stateful
connections
* Moved to class-based srfsh module for easier state maintenance
* More doc strings
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2133
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Thu, 16 Dec 2010 21:02:41 +0000 (21:02 +0000)]
Remove extraneous line for dnsmasq / Python
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2130
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Mon, 13 Dec 2010 14:57:44 +0000 (14:57 +0000)]
on second thought, removing debug sleep method, which is (more than most) a DOS waiting to happen.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2126
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Mon, 13 Dec 2010 14:53:47 +0000 (14:53 +0000)]
improved select/read/write fault tolerance; cleaner and more efficient child process idle/active list management; improved logging
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2124
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 7 Dec 2010 14:30:45 +0000 (14:30 +0000)]
Apply libtools versioning to OpenSRF c-apps as well
We apply a -version-info argument of 2:0:2, meaning:
* interface = 2: interface '2' of this library
* revision = 0: first implementation of interface '2'
* age = 2: this library can be linked with executables going back
two interface versions
See http://sourceware.org/autobook/autobook/autobook_91.html for more
information on the -version-info argument.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2123
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Wed, 1 Dec 2010 03:10:53 +0000 (03:10 +0000)]
Apply patch for dnsmasq documentation
Thanks to Michael Giarlo <leftwing@alumni.rutgers.edu> for
providing this correction to the dnsmasq configuration line!
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2121
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Tue, 30 Nov 2010 14:27:30 +0000 (14:27 +0000)]
fail gracefully when opensrf.settings is not up and running
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2119
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 30 Nov 2010 04:16:30 +0000 (04:16 +0000)]
Prepare for version 2.0.0 with versioning for 2.0.0
Use the libtool -version-info option to provide an explicit version
for the libopensrf.so library. Introducing versioned libraries will
give us the ability to force recompiles of linked applications when
binary compatibility has been broken.
Also, bump the Perl version number to 2.0.0
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2118
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Mon, 29 Nov 2010 20:15:33 +0000 (20:15 +0000)]
don't clean up child attributes until we're done with them; added pid map hash for easy/quick access to child via pid
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2116
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Mon, 29 Nov 2010 19:17:37 +0000 (19:17 +0000)]
added opensrf.system.sleep method; takes 1 param (seconds); useful for debugging child process management
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2111
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Mon, 29 Nov 2010 19:16:34 +0000 (19:16 +0000)]
avoid calling sysread when select exited from interruption.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2110
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Mon, 29 Nov 2010 19:15:07 +0000 (19:15 +0000)]
add fault tolerance (e.g. recover from interrupted select/sysread); always perform idle maintenance when there are any active child processes; exit check status early when no active processes exist
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2109
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Sun, 28 Nov 2010 20:56:43 +0000 (20:56 +0000)]
Lenny needs zlib1g-dev package to install XML::LibXML and others
Per https://rt.cpan.org/Public/Bug/Display.html?id=51439; also,
libmemcached failed to configure and build without this.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2106
9efc2488-bf62-4759-914b-
345cdb29e865
gmc [Wed, 24 Nov 2010 17:11:49 +0000 (17:11 +0000)]
no longer need FreezeThaw
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2104
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Mon, 22 Nov 2010 22:21:35 +0000 (22:21 +0000)]
in the rare case the select() is interrupted while waiting on child statuses, exit early to prevent read()'s on invalid file handles and allow the calling code to loop back around and try again
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2101
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Sat, 20 Nov 2010 15:50:30 +0000 (15:50 +0000)]
added support for introspect operation
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2099
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Sat, 20 Nov 2010 15:25:36 +0000 (15:25 +0000)]
install srfsh.py when --enable-python is set
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2095
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Sat, 20 Nov 2010 15:24:55 +0000 (15:24 +0000)]
added support for paging through 'less' (like C); added 'router' query docs; added separate env vars for pretty printing json and for print network object keys; explicit opensrf disconnect on exit
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2094
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Sat, 20 Nov 2010 15:23:57 +0000 (15:23 +0000)]
added network disconnect func
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2093
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Fri, 19 Nov 2010 02:41:57 +0000 (02:41 +0000)]
added 'router' command for router class info queries; improved redline tab completion; more changes for consistency with C version; general cleanup
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2091
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Tue, 16 Nov 2010 14:08:29 +0000 (14:08 +0000)]
repaired logic in the as-yet-unused import_array_data; use the more efficient enumerate func; capture array length outside of loop for efficiency; avoid calls to set/get_field and access _data directly inside of the NetworkObject class for faster accessor/mutator's
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2088
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Tue, 16 Nov 2010 14:06:02 +0000 (14:06 +0000)]
removed debug print statement
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2087
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Tue, 16 Nov 2010 03:36:49 +0000 (03:36 +0000)]
rely on logic, not failure through try/catch, to determine of an object is a registered network object; if an object is unregistered, do not treat it as an __unknown network object (which obfuscates and provides no value).
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2084
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Tue, 16 Nov 2010 03:29:32 +0000 (03:29 +0000)]
killed the terminal colors in srfsh.py output. They are cute and all, but are likely the cause of readline oddities/artifacts (and kind of distracting). Default to raw (json) output for consistency
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2083
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Sun, 14 Nov 2010 04:15:24 +0000 (04:15 +0000)]
Limit list of Python services to those within the domain-specific activeapps section
Fix up help with correct default PID directory and document list_all action
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2077
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Thu, 11 Nov 2010 14:47:12 +0000 (14:47 +0000)]
If an alternate config file is pointed to in osrf_ctl.sh, respect it
In a previous edit, I accidentally removed the config file option
from the start_python command, which would break if anything other
than the configured default config file was specified as an option to
osrf_ctl.sh. This makes opensrf.py once again respect the authority
of osrf_ctl.sh.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2076
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Thu, 11 Nov 2010 14:25:02 +0000 (14:25 +0000)]
Use the same PID directory as the opensrf-perl.pl and opensrf.py scripts
The default PID directories for the opensrf-perl.pl and opensrf.py scripts
was /openils/var/run/opensrf (assuming a prefix of '/openils'), while the
default PID directory for osrf_ctl.sh was /openils/var/run. This complicated
matters when trying to restart individual Python or Perl services, as without
passing an explicit PID directory argument the restart command from the
language-specific script would check for a PID in a different PID directory,
find none, and end up running a second copy of the service instead of
restarting the existing service.
The change groups all PIDs in the 'run/opensrf' subdirectory to avoid any
PID file conflicts (as unlikely as that might be) if OpenSRF is installed
in the default location - so rather than /var/local/run/*.pid, one will
be able to look at /var/local/run/opensrf/*.pid
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2075
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Wed, 10 Nov 2010 19:14:19 +0000 (19:14 +0000)]
Add the sanity-saving step of a munged PERL5LIB to the README
Thanks for the nudge from Thomas Berezanksy!
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2074
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Wed, 10 Nov 2010 03:33:15 +0000 (03:33 +0000)]
Commit some unit tests for Python osrf.json module
Recommendation: add *_test.py scripts that mirror each
osrf.* module in src/python/tests. Boo-yah.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2073
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 9 Nov 2010 22:54:39 +0000 (22:54 +0000)]
osrf.json clean up
* Use the right variable name in to_json_raw()
* PEP8 compliance for variable naming
* Add docstrings
* Simpler __tabs() implementation
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2072
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 9 Nov 2010 21:39:44 +0000 (21:39 +0000)]
A solution for starting all Python services: make sh do the work
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2071
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 9 Nov 2010 18:17:50 +0000 (18:17 +0000)]
Enhanced do_start() implementation in Python management script
Unclean shutdowns and fork() misery can create PID files that have
no actual process behind them. Instead of just trusting the PID file, check
for the running PID; if the process is not running, then remove the PID file
and actually start the service.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2070
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 9 Nov 2010 17:54:13 +0000 (17:54 +0000)]
Assign, don't test equality (thanks berick)
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2069
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 9 Nov 2010 17:28:29 +0000 (17:28 +0000)]
Make start_all automatically daemonize services
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2068
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 9 Nov 2010 16:21:15 +0000 (16:21 +0000)]
Give opensrf.py reasonable defaults for options
Rather than:
opensrf.py -l -d -f /openils/conf/opensrf_core.xml -p /openils/var/run/ -a start_all
you can now use:
opensrf.py -l -d -a start_all
Isn't that better? Note that we put the PIDs into PID_DIR/run/opensrf/
so that if/when OpenSRF is installed outside of the /openils/ prefix,
the names of the processes won't conflict with any other application PIDs.
Unlikely, but you never know.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2067
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 9 Nov 2010 15:58:21 +0000 (15:58 +0000)]
Try not to stomp on global variable names and built-ins, add docstrings
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2066
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 9 Nov 2010 14:59:21 +0000 (14:59 +0000)]
Typos: s/wait_for_child/try_wait_child/ and s/min_childen/min_children/
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2065
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 9 Nov 2010 14:56:01 +0000 (14:56 +0000)]
Typo: Pass in the array of servers to the memcached client if we have one
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2064
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 9 Nov 2010 14:46:03 +0000 (14:46 +0000)]
Reference constants properly
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2063
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 9 Nov 2010 14:32:13 +0000 (14:32 +0000)]
Make pylint happier with PEP8-compliant argument name
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2062
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 9 Nov 2010 14:22:25 +0000 (14:22 +0000)]
Fix daemonize problem that surfaced in start_all
Thanks to Michael Giarlo for reporting the problem, Bill Erickson
for pointing the way to the solution, and http://bugs.python.org/issue5313
for providing me with more context for the problem & solution.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2061
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 9 Nov 2010 13:59:55 +0000 (13:59 +0000)]
More debuggery for the spawning of child processes
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2060
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 9 Nov 2010 13:50:43 +0000 (13:50 +0000)]
Minutes and months were reversed in Python logging timestamps
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2059
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 9 Nov 2010 01:59:03 +0000 (01:59 +0000)]
Add a Python and curl example of invoking the Perl simpletext services
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2058
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 9 Nov 2010 01:57:38 +0000 (01:57 +0000)]
Add a streaming version of the split() method in simpletext example
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2057
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Mon, 8 Nov 2010 21:03:55 +0000 (21:03 +0000)]
Make opensrf-perl.pl handle missing configuration for services more gracefully
As we might want to ship configuration files with commented out sections,
this will alert the user that a service was listed in the hosts section
but the configuration for that service could not be found.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2056
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Fri, 5 Nov 2010 20:57:43 +0000 (20:57 +0000)]
Patch from Michael Giarlo to integrate python service control into osrf_ctl.sh.
I made the following additional changes:
1. copy opensrf.py into the BIN dir during install when --enable-python is used.
2. osrf_ctl.sh will not attempt to control python services when python is not enabled for opensrf.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2055
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Fri, 5 Nov 2010 15:15:53 +0000 (15:15 +0000)]
patch from Michael Giarlo for better sanity checking during settings file reading in python (avoid #comment's)
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2054
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Fri, 5 Nov 2010 14:48:14 +0000 (14:48 +0000)]
added osrf.apps to installed pachages (thanks for the tip, dbs). bumped version in prep for 2.0
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2053
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Fri, 5 Nov 2010 12:59:00 +0000 (12:59 +0000)]
socket_bundle typo patch from Jason Stephenson
Further discussion and DCO:
http://libmail.georgialibraries.org/pipermail/open-ils-dev/2010-November/006476.html
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2051
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Tue, 26 Oct 2010 14:12:15 +0000 (14:12 +0000)]
consistent w/ the C libs, only log server message processing duration at INFO. log server response processing duration at debug and w/ slighly different wording. let the processing duration log message act as the indication of a successfully handled message to reduce logging
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2049
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Mon, 25 Oct 2010 16:28:23 +0000 (16:28 +0000)]
log message processing duration at INFO level, instead of DEBUG, consistent with the C libs
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2047
9efc2488-bf62-4759-914b-
345cdb29e865
scottmk [Thu, 14 Oct 2010 16:30:17 +0000 (16:30 +0000)]
Plug a minor memory leak that could occur when we opened a TCP connection
to a server. In practice this meant whenever we opened a Jabber session.
We call getaddrinfo() to get a dynamically allocated linked list of
addresses for a given server name. Then we traverse the list, looking
for one that accepts streaming connections over IPV4, in order to get
an IP address.
At the end, we call freeaddrinfo() to free the linked list.
Previously we would pass to freeaddrinfo() a pointer, not to the
head of the list, but to the node that we used for getting an IP
address. Prior nodes, if any, would leak.
Also: added calls to freeaddrinfo() in the case of early returns, to
avoid leaking the list in the event of an error.
M src/libopensrf/socket_bundle.c
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2036
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Tue, 12 Oct 2010 14:53:41 +0000 (14:53 +0000)]
implemented an optional per-service stderr log for capturing miscellaneous stderr output from services, similar to the old-style _unix.log files, since there are often useful warnings and error messages that never bubble up to syslog. for clarity, the files now use _stderr as a suffix instead of _unix. stderr logs are enabled by default. included opensrf.xml example of how to disable it for a given service
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2035
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Tue, 12 Oct 2010 02:58:16 +0000 (02:58 +0000)]
when we add xhr responses onto the end of the queue, stash the original session as well, otherwise we're attempting to ask a session questions about requests it's not tracking
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2031
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Thu, 7 Oct 2010 12:57:56 +0000 (12:57 +0000)]
in json encoder, replace 2 sub calls w/ 1 hash lookup in heavily called code path. we lose some abstraction, but it's probably worth it here
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2030
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Tue, 28 Sep 2010 17:35:26 +0000 (17:35 +0000)]
Work around a Net::Domain bug that can result in fqdn's like foo.example.com,bar.com
The bug manifested when trying to run autogen.sh, with the output:
Updating fieldmapper
No Response from settings server...going to sleep
This was because SettingsParser was generating invalid XPath and consquently
errors in the opensrf.settings service; with no response, the attempt to run
autogen.sh would die.
This workaround splits the fqdn on commas and tries each possible domain in
the server setting XPath. Long term we either need to wait for Net::Domain
bug #60729 (https://rt.cpan.org/Public/Bug/Display.html?id=60729) to be
resolved, or consider alternatives.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2029
9efc2488-bf62-4759-914b-
345cdb29e865
miker [Tue, 28 Sep 2010 00:04:19 +0000 (00:04 +0000)]
return the trace-augmented message as written to the log
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2028
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Mon, 13 Sep 2010 15:44:11 +0000 (15:44 +0000)]
removing vestigial references to Inbound.pm, which no longer exists in the repository. this also removes get/set_listener, which were never taken advantage of and are no longer of use since the listener is thoroughly hard-coded into the opensrf stack now
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2024
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Thu, 9 Sep 2010 17:09:42 +0000 (17:09 +0000)]
Bump trunk version number for OpenSRF up to 1.8.0; better than 1.4.0.
perlmodstyle says "A correct CPAN version number is a floating point
number with at least 2 digits after the decimal." so we're not in
compliance in any case. Oh well.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2023
9efc2488-bf62-4759-914b-
345cdb29e865
dbs [Sun, 5 Sep 2010 02:31:35 +0000 (02:31 +0000)]
Update the manifest for Perl modules to avoid build warnings
r2016 removed two Perl modules, src/perl/lib/OpenSRF/Transport/SlimJabber/Inbound.pm
and src/perl/lib/OpenSRF/UnixServer.pm, and the build gets upset because the
manifest suggests they're missing. But no, we know where they are, and we
don't expect them to come back.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2021
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Wed, 1 Sep 2010 17:34:56 +0000 (17:34 +0000)]
added support for reading ContinueStatus opensrf messages in the JS opensrf lib
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2019
9efc2488-bf62-4759-914b-
345cdb29e865
gmc [Wed, 1 Sep 2010 13:56:12 +0000 (13:56 +0000)]
updated mailing address of the FSF
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2018
9efc2488-bf62-4759-914b-
345cdb29e865
gmc [Wed, 1 Sep 2010 13:43:25 +0000 (13:43 +0000)]
remove executable bit from module files that don't need it
Small nit to pick for Debianization.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2017
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Wed, 1 Sep 2010 00:17:12 +0000 (00:17 +0000)]
Replace Net::Server with local pre-forking server
Support max/min children and max/min spare children
For more, see http://libmail.georgialibraries.org/pipermail/open-ils-dev/2010-May/006068.html
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2016
9efc2488-bf62-4759-914b-
345cdb29e865
gmc [Tue, 31 Aug 2010 20:49:44 +0000 (20:49 +0000)]
remove ntp and ntpdate dependencies
Not used by OpenSRF; these are legacies of
Evergreen dependencies at the time OpenSRF was
split off. Quite likely a bunch of deps in
Makefile.install aren't needed by OpenSRF
proper.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2015
9efc2488-bf62-4759-914b-
345cdb29e865
erickson [Wed, 18 Aug 2010 20:11:18 +0000 (20:11 +0000)]
Due to the async nature of xmllhttprequest, processing http responses (which often lead to further async-request laden callbacks) at receive time can result in out-of-order message handling. To bring order to this chaos, push all inbound message onto a queue, then go back to processing the older messages in order of oldest to newest.
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2008
9efc2488-bf62-4759-914b-
345cdb29e865
scottmk [Mon, 16 Aug 2010 16:27:32 +0000 (16:27 +0000)]
A few minor tweaks in the name of const-correctness.
M src/router/osrf_router_main.c
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2007
9efc2488-bf62-4759-914b-
345cdb29e865
scottmk [Mon, 16 Aug 2010 15:18:08 +0000 (15:18 +0000)]
Several minor and inconsequential changes:
1. Tidied up the white space in a few places.
2. Commented out several unused functions, used only for development,
in order to eliminate some annoying compiler warnings.
3. Added the const qualifier to several variables.
4. Added three branches to a switch/case structure, in order to
eliminate some compiler warnings about untested enum values. The
new branches merely issue warning messages to the log (presumably
we don't expect to see RESULT or STATUS messages in this
context).
M src/gateway/osrf_http_translator.c
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2006
9efc2488-bf62-4759-914b-
345cdb29e865
scottmk [Sun, 15 Aug 2010 00:57:53 +0000 (00:57 +0000)]
1. Pedantic change for const-correctness: replaced all calls to
jsonObjectGetKey() with calls to jsonObjectGetKeyConst().
2. Tidied up white space and comments here and there.
M src/router/osrf_router_main.c
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2005
9efc2488-bf62-4759-914b-
345cdb29e865
scottmk [Sat, 14 Aug 2010 21:38:11 +0000 (21:38 +0000)]
Pedantic change for const-correctness: change three calls to
jsonObjectGetKey() to call jsonObjectGetKeyConst() instead.
M src/gateway/osrf_http_translator.c
git-svn-id: svn://svn.open-ils.org/OpenSRF/trunk@2004
9efc2488-bf62-4759-914b-
345cdb29e865